[PATCH] D63623: [clang-tidy] Add a check on expected return values of posix functions (except posix_openpt) in Android module.

jcai19 added a comment. In D63623#1556161 , @lebedev.ri wrote: > In D63623#1552716 , @jcai19 wrote: > > > In D63623#1552679 , @lebedev.ri > > wrote: > > > > > Why is this in

[PATCH] D62977: [clang-tidy]: Google: new check 'google-upgrade-googletest-case'

EricWF added inline comments. Comment at: clang-tools-extra/clang-tidy/google/GoogleTidyModule.cpp:30 #include "UnnamedNamespaceInHeaderCheck.h" #include "UsingNamespaceDirectiveCheck.h" Just tried building this. I think you're missing an include for `Upgrad

[PATCH] D62739: AMDGPU: Always emit amdgpu-flat-work-group-size

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62739/new/ https://reviews.llvm.org/D62739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r364236 - [Syntax] Do not glue multiple empty PP expansions to a single mapping

Author: ibiryukov Date: Mon Jun 24 14:39:51 2019 New Revision: 364236 URL: http://llvm.org/viewvc/llvm-project?rev=364236&view=rev Log: [Syntax] Do not glue multiple empty PP expansions to a single mapping Summary: This change makes sure we have a single mapping for each macro expansion, even if

[PATCH] D62953: [Syntax] Do not glue multiple empty PP expansions to a single mapping

This revision was automatically updated to reflect the committed changes. Closed by commit rL364236: [Syntax] Do not glue multiple empty PP expansions to a single mapping (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior t

[PATCH] D63518: WIP BitStream reader: propagate errors

jfb added a comment. All of `check-llvm` now passes. I'll look at other users of this stuff in the monorepo, compile and run their tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63518/new/ https://reviews.llvm.org/D63518 _

[PATCH] D62825: [C++2a] Add __builtin_bit_cast, used to implement std::bit_cast

erik.pilkington updated this revision to Diff 206304. erik.pilkington marked 10 inline comments as done. erik.pilkington added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62825/new/ https://reviews.llvm.org/D62825 Files: clang/include/clang-c/Ind

[PATCH] D62825: [C++2a] Add __builtin_bit_cast, used to implement std::bit_cast

erik.pilkington added inline comments. Comment at: clang/include/clang/Basic/DiagnosticASTKinds.td:223 +def note_constexpr_bit_cast_invalid_type : Note< + "cannot constexpr evaluate a bit_cast with a " + "%select{union|pointer|member pointer|volatile|struct with a reference me

[PATCH] D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang

morehouse added a comment. Thanks for the patch! Seems like a useful feature for targeted fuzzing. Comment at: clang/docs/SanitizerCoverage.rst:310 + +In most cases, the whitelist will list the folders or source files for which you want +instrumentation and allow all function

[PATCH] D63720: [analyzer] ExprEngine: Escape pointers in bitwise operations

NoQ added a comment. Nice!~ I'm glad this is getting sorted out. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineC.cpp:103 +if (const MemRegion *LeftMR = LeftV.getAsRegion()) + IsLhsPtr = LeftMR->getSymbolicBase(); +if (const MemRegion *RightMR = Ri

r364245 - Fix test cl-response-file.c to work on all platforms including Windows/Solaris.

Author: dyung Date: Mon Jun 24 15:26:08 2019 New Revision: 364245 URL: http://llvm.org/viewvc/llvm-project?rev=364245&view=rev Log: Fix test cl-response-file.c to work on all platforms including Windows/Solaris. Differential Revision: https://reviews.llvm.org/D63678 Modified: cfe/trunk/test/

[PATCH] D63678: Fix test Clang :: Driver/cl-response-file.c for Solaris

This revision was automatically updated to reflect the committed changes. Closed by commit rL364245: Fix test cl-response-file.c to work on all platforms including Windows/Solaris. (authored by dyung, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed p

[PATCH] D63742: [WebAssembly] Implement Address Sanitizer for Emscripten

quantum created this revision. quantum added reviewers: tlively, aheejin. Herald added subscribers: llvm-commits, cfe-commits, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added projects: clang, LLVM. This diff enables address sanitizer on Emscripten. On Emscripten, real memory

[PATCH] D63663: [clang-doc] Add html links to the parents of a RecordInfo

DiegoAstiazaran updated this revision to Diff 206317. DiegoAstiazaran edited the summary of this revision. DiegoAstiazaran added a comment. Herald added a subscriber: ormris. Path name generation was moved to serialization phase as @juliehockett suggested. Empty string declaration fixed. Removed

r364251 - AMDGPU: Fix missing declaration for mbcnt builtins

Author: arsenm Date: Mon Jun 24 16:34:06 2019 New Revision: 364251 URL: http://llvm.org/viewvc/llvm-project?rev=364251&view=rev Log: AMDGPU: Fix missing declaration for mbcnt builtins Modified: cfe/trunk/include/clang/Basic/BuiltinsAMDGPU.def cfe/trunk/test/CodeGenOpenCL/builtins-amdgcn.c

[PATCH] D63720: [analyzer] ExprEngine: Escape pointers in bitwise operations

Charusso updated this revision to Diff 206332. Charusso marked 11 inline comments as done. Charusso added a comment. - Fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63720/new/ https://reviews.llvm.org/D63720 Files: clang/lib/StaticAnalyzer/Core/ExprEngineC.cpp clang/test/Analy

[PATCH] D63720: [analyzer] ExprEngine: Escape pointers in bitwise operations

Charusso marked an inline comment as done. Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineC.cpp:103 +if (const MemRegion *LeftMR = LeftV.getAsRegion()) + IsLhsPtr = LeftMR->getSymbolicBase(); +if (const MemRegion *Righ

[PATCH] D63663: [clang-doc] Add html links to the parents of a RecordInfo

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:21 namespace { Eugene.Zelenko wrote: > Anonymous namespace is used for functions when LLVM Coding Guidelines tells > using static for same purpose. Actually, since

[PATCH] D63720: [analyzer] ExprEngine: Escape pointers in bitwise operations

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineC.cpp:123 state = state->BindExpr(B, LCtx, Result); } Charusso wrote: > I have seen we are producing tons of Unknowns and I am still not sure where > they go, but ev

[PATCH] D51262: Implement P0553 and P0556

mclow.lists updated this revision to Diff 206339. mclow.lists added a comment. Update this patch to implement P1355R2 which makes out-of-bound inputs for `ceil2`UB. This was easy for integer types that are at least as big as `int`, but harder for smaller ones. CHANG

[PATCH] D63720: [analyzer] ExprEngine: Escape pointers in bitwise operations

Charusso updated this revision to Diff 206341. Charusso marked 8 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63720/new/ https://reviews.llvm.org/D63720 Files: clang/lib/StaticAnalyzer/Core/ExprEngineC.cpp clang/test/Analysis/symbol-escape.cpp Index: clang

[PATCH] D63720: [analyzer] ExprEngine: Escape pointers in bitwise operations

Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineC.cpp:123 state = state->BindExpr(B, LCtx, Result); } NoQ wrote: > Charusso wrote: > > I have seen we are producing tons of Unknowns and I am still not sure wher

[PATCH] D63720: [analyzer] ExprEngine: Escape pointers in bitwise operations

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Great, thanks! Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineC.cpp:104 + + // If we cannot evaluate the operation escape the operands. + } else { P

r364259 - [analyzer] ExprEngine: Escape pointers in bitwise operations

Author: charusso Date: Mon Jun 24 17:44:33 2019 New Revision: 364259 URL: http://llvm.org/viewvc/llvm-project?rev=364259&view=rev Log: [analyzer] ExprEngine: Escape pointers in bitwise operations Summary: After evaluation it would be an Unknown value and tracking would be lost. Reviewers: NoQ, x

[PATCH] D63720: [analyzer] ExprEngine: Escape pointers in bitwise operations

This revision was automatically updated to reflect the committed changes. Closed by commit rL364259: [analyzer] ExprEngine: Escape pointers in bitwise operations (authored by Charusso, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D63720: [analyzer] ExprEngine: Escape pointers in bitwise operations

Charusso updated this revision to Diff 206344. Charusso marked an inline comment as done. Charusso added a comment. - Better comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63720/new/ https://reviews.llvm.org/D63720 Files: clang/lib/StaticAnalyzer/Core/ExprEngineC.cpp clang/

[PATCH] D63720: [analyzer] ExprEngine: Escape pointers in bitwise operations

Charusso added a comment. Thanks for the review ! That was the largest-work three lines of code of the history because I was blind. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63720/new/ https://reviews.llvm.org/D63720 ___

[PATCH] D51262: Implement P0553 and P0556

mclow.lists marked 4 inline comments as done. mclow.lists added inline comments. Comment at: include/bit:254 + +if constexpr (sizeof(_Tp) <= sizeof(unsigned int)) + return __clz(static_cast(__t)) EricWF wrote: > Cool use of `if constexpr`. > > Ple

[PATCH] D51262: Implement P0553 and P0556

mclow.lists added a comment. > Also are the unsigned types that aren't integral? I believe that people are allowed to specialize `is_unsigned` for their own (bignum, say) types. However, `is_integral` is not extensible. It refers to the types in `[basic.fundamental]` > Type `bool` is a distinc

r364265 - [cxx2a] P1236R1: the validity of a left shift does not depend on the

Author: rsmith Date: Mon Jun 24 18:45:26 2019 New Revision: 364265 URL: http://llvm.org/viewvc/llvm-project?rev=364265&view=rev Log: [cxx2a] P1236R1: the validity of a left shift does not depend on the value of the LHS operand. Added: cfe/trunk/test/Analysis/left-shift-cxx2a.cpp cfe/trunk

[PATCH] D51262: Implement P0553 and P0556

Quuxplusone added inline comments. Comment at: libcxx/include/bit:199 +!is_same_v, char32_t> + > {}; + Given how heavily the code controlled by this trait depends on `numeric_limits<_Tp>`, would it make sense to add something in here about how that

r364267 - [analyzer] NFC: exploded-graph-rewriter: Extract some code into functions.

Author: dergachev Date: Mon Jun 24 19:16:50 2019 New Revision: 364267 URL: http://llvm.org/viewvc/llvm-project?rev=364267&view=rev Log: [analyzer] NFC: exploded-graph-rewriter: Extract some code into functions. Differential Revision: https://reviews.llvm.org/D63684 Modified: cfe/trunk/utils/

r364268 - [analyzer] exploded-graph-rewriter: Add support for range constraints.

Author: dergachev Date: Mon Jun 24 19:16:53 2019 New Revision: 364268 URL: http://llvm.org/viewvc/llvm-project?rev=364268&view=rev Log: [analyzer] exploded-graph-rewriter: Add support for range constraints. Diff support included. A cheap solution is implemented that treats range constraints as "

r364269 - [analyzer] exploded-graph-rewriter: Fix escaping for bitwise-or.

Author: dergachev Date: Mon Jun 24 19:16:56 2019 New Revision: 364269 URL: http://llvm.org/viewvc/llvm-project?rev=364269&view=rev Log: [analyzer] exploded-graph-rewriter: Fix escaping for bitwise-or. '|' is a special character in graphviz, so it needs to be properly escaped and unescaped. Modif

r364266 - [analyzer] Add more timers for performance profiling.

Author: dergachev Date: Mon Jun 24 19:16:47 2019 New Revision: 364266 URL: http://llvm.org/viewvc/llvm-project?rev=364266&view=rev Log: [analyzer] Add more timers for performance profiling. The -analyzer-stats flag now allows you to find out how much time was spent on AST-based analysis and on pa

[PATCH] D63685: [analyzer] exploded-graph-rewriter: Add support for range constraints.

This revision was automatically updated to reflect the committed changes. Closed by commit rL364268: [analyzer] exploded-graph-rewriter: Add support for range constraints. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D63684: [analyzer] exploded-graph-rewriter: NFC: Extract some code into functions.

This revision was automatically updated to reflect the committed changes. Closed by commit rL364267: [analyzer] NFC: exploded-graph-rewriter: Extract some code into functions. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pr

[PATCH] D63227: [analyzer] Better timers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL364266: [analyzer] Add more timers for performance profiling. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: http

[PATCH] D63727: [analyzer] print() JSONify: Stable LocationContext IDs

NoQ added a comment. In normal dumps i'd rather have it the old way because it's similar to how stack frames are displayed in the debugger. And in exploded graph rewriter we can always reverse our lists if we want; this number isn't really telling us much. Repository: rC Clang CHANGES SINC

[PATCH] D63726: [analyzer] print() JSONify: Create pointers

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Yay thx! For Environment they aren't that useful, but it definitely doesn't hurt. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63726/new/ https://reviews.llvm.org/

[PATCH] D51262: Implement P0553 and P0556

mclow.lists marked an inline comment as done. mclow.lists added inline comments. Comment at: libcxx/include/bit:378 + const unsigned __retVal = 1u << (__n + __extra); + return (_Tp) (__retVal >> __extra); +} Quuxplusone wrote: > Why so complicated

[PATCH] D63727: [analyzer] print() JSONify: Stable LocationContext IDs

NoQ added a comment. I think i'd rather remove it entirely. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63727/new/ https://reviews.llvm.org/D63727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D63726: [analyzer] print() JSONify: Create pointers

Charusso added a comment. In D63726#1556825 , @NoQ wrote: > Yay thx! > > For Environment they aren't that useful, but it definitely doesn't hurt. It is pretty interesting when you could track the call among the entire graph, it is could be our first `Ex

[PATCH] D63462: [analyzer] JsonSupport: Escape escapes

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thx! I guess it makes sense to add a test into `test/Analysis/exploded-graph-rewriter/escapes.c` as well, so that to learn if we can actually parse it later. CHANGES SINCE LAST ACTION https://r

[PATCH] D63462: [analyzer] JsonSupport: Escape escapes

NoQ added a comment. See also https://xkcd.com/1638/ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63462/new/ https://reviews.llvm.org/D63462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D63727: [analyzer] print() JSONify: Stable LocationContext IDs

Charusso abandoned this revision. Charusso added a comment. In D63727#1556821 , @NoQ wrote: > I think i'd rather remove it entirely. I have seen a TODO in the differentiation of such indices, just why I made it. Okai. Repository: rC Clang CHANGES S

[PATCH] D51262: Implement P0553 and P0556

mclow.lists marked 2 inline comments as done. mclow.lists added inline comments. Comment at: libcxx/include/bit:199 +!is_same_v, char32_t> + > {}; + Quuxplusone wrote: > Given how heavily the code controlled by this trait depends on > `numeric_limits

[PATCH] D51262: Implement P0553 and P0556

mclow.lists marked an inline comment as done. mclow.lists added inline comments. Comment at: libcxx/include/bit:378 + const unsigned __retVal = 1u << (__n + __extra); + return (_Tp) (__retVal >> __extra); +} mclow.lists wrote: > Quuxplusone wrote:

[PATCH] D63462: [analyzer] JsonSupport: Escape escapes

Charusso updated this revision to Diff 206356. Charusso added a comment. - More test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63462/new/ https://reviews.llvm.org/D63462 Files: clang/include/clang/Basic/JsonSupport.h clang/test/Analysis/dump_egraph.c clang/test/Analysis/expl

[PATCH] D63462: [analyzer] JsonSupport: Escape escapes

Charusso added a comment. In D63462#1556831 , @NoQ wrote: > See also https://xkcd.com/1638/ Well, after a month of escaping we are still have problems, so it is truly comes to your brain. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63462/new

[PATCH] D51262: Implement P0553 and P0556

Quuxplusone added inline comments. Comment at: libcxx/include/bit:378 + const unsigned __retVal = 1u << (__n + __extra); + return (_Tp) (__retVal >> __extra); +} mclow.lists wrote: > mclow.lists wrote: > > Quuxplusone wrote: > > > Why so complicat

r364270 - [analyzer] JsonSupport: Escape escapes

Author: charusso Date: Mon Jun 24 20:08:32 2019 New Revision: 364270 URL: http://llvm.org/viewvc/llvm-project?rev=364270&view=rev Log: [analyzer] JsonSupport: Escape escapes Summary: - Reviewers: NoQ Reviewed By: NoQ Subscribers: xazax.hun, baloghadamsoftware, szepet, a.sidorin, m

[PATCH] D63462: [analyzer] JsonSupport: Escape escapes

This revision was automatically updated to reflect the committed changes. Closed by commit rL364270: [analyzer] JsonSupport: Escape escapes (authored by Charusso, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm

[PATCH] D63462: [analyzer] JsonSupport: Escape escapes

Charusso updated this revision to Diff 206357. Charusso added a comment. - A working one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63462/new/ https://reviews.llvm.org/D63462 Files: clang/include/clang/Basic/JsonSupport.h clang/test/Analysis/dump_egraph.c clang/test/Analysis/

r364271 - [analyzer] print() JSONify: Create pointers

Author: charusso Date: Mon Jun 24 20:17:55 2019 New Revision: 364271 URL: http://llvm.org/viewvc/llvm-project?rev=364271&view=rev Log: [analyzer] print() JSONify: Create pointers Summary: - Reviewers: NoQ Reviewed By: NoQ Subscribers: xazax.hun, baloghadamsoftware, szepet, a.sidorin,

[PATCH] D63726: [analyzer] print() JSONify: Create pointers

This revision was automatically updated to reflect the committed changes. Closed by commit rL364271: [analyzer] print() JSONify: Create pointers (authored by Charusso, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews

[PATCH] D51262: Implement P0553 and P0556

mclow.lists marked 4 inline comments as done. mclow.lists added inline comments. Comment at: libcxx/include/bit:252 +while (true) { +__t = rotr<_Tp>(__t, __ulldigits); +if ((__iter = countl_zero(static_cast(__t))) != __ulldigits)

[PATCH] D51262: Implement P0553 and P0556

mclow.lists marked an inline comment as done. mclow.lists added inline comments. Comment at: libcxx/include/bit:378 + const unsigned __retVal = 1u << (__n + __extra); + return (_Tp) (__retVal >> __extra); +} mclow.lists wrote: > Quuxplusone wrote:

[PATCH] D51262: Implement P0553 and P0556

mclow.lists marked an inline comment as done. mclow.lists added inline comments. Comment at: libcxx/include/bit:378 + const unsigned __retVal = 1u << (__n + __extra); + return (_Tp) (__retVal >> __extra); +} mclow.lists wrote: > mclow.lists wrote:

[PATCH] D63518: BitStream reader: propagate errors

jfb added a comment. I did a build of all LLVM monorepo projects, and only LLVM / clang / clang-tools-extra are impacted. I therefore ran tests as follows, and they all pass: rm -rf debug ; mkdir debug && (cd debug && cmake -G Ninja ../llvm -DLLVM_ENABLE_ASSERTIONS=ON -DCMAKE_BUILD_TYPE=Debu

[PATCH] D61879: WIP: Prototype of DSE optimizations for -ftrivial-auto-var-init

vitalybuka updated this revision to Diff 206365. vitalybuka added a comment. Herald added subscribers: asbirlea, george.burgess.iv. Bugfixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61879/new/ https://reviews.llvm.org/D61879 Files: clang/te

<    1   2