[PATCH] D35388: [libc++] Give extern templates default visibility on gcc

thakis added a comment. Herald added a subscriber: dexonsmith. > I would think that both this change and https://reviews.llvm.org/D35326 are > good. What's the status here and in D35326 ? We still have a workaround in chromium's build files pointing at these two

r364157 - Fix test for 32-bit targets.

Author: rsmith Date: Sun Jun 23 10:42:18 2019 New Revision: 364157 URL: http://llvm.org/viewvc/llvm-project?rev=364157&view=rev Log: Fix test for 32-bit targets. Modified: cfe/trunk/test/CodeGenCXX/tail-padding.cpp Modified: cfe/trunk/test/CodeGenCXX/tail-padding.cpp URL: http://llvm.org/vi

[PATCH] D61838: [Sema] Suppress additional warnings for C's zero initializer

Lekensteyn added a comment. @rsmith The latest patch version has addressed your feedback, can you confirm that this is ready to be merged? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61838/new/ https://reviews.llvm.org/D61838 ___

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

Lekensteyn added a comment. Hi @dankm, any progress on this feature? The proposed branch off date for Clang 9.0.0 is 18 July 2019: https://lists.llvm.org/pipermail/cfe-dev/2019-June/062628.html Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49466/new/ https://re

[PATCH] D62375: [ASTImporter] Mark erroneous nodes in from ctx

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62375/new/ https://reviews.llvm.org/D62375 __

[PATCH] D62738: [HIP] Support device_shadow variable

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:3775 + // left undefined. + bool IsHIPDeviceShadowVar = getLangOpts().HIP && getLangOpts().CUDAIsDevice && + D->hasAttr();

[PATCH] D63697: clang-format: Fix error return when using inplace with stdin

woodruffw created this revision. woodruffw added reviewers: clang, thakis. woodruffw added a project: clang. Herald added a subscriber: cfe-commits. Causes clang-format to exit with an appropriate error code when the invalid combination of -i and stdin is provided. Repository: rC Clang https:

Re: [PATCH] D63451: P0840R2: support for [[no_unique_address]] attribute

On Fri, 21 Jun 2019 at 19:38, Richard Smith wrote: > > Thanks, should hopefully be fixed by r364081. Problem fixed, Thanks richard. > On Fri, 21 Jun 2019 at 01:12, Yvan Roux via cfe-commits > wrote: >> >> Hi Richard, >> >> This commit broke ARM bots, logs are available here: >> >> http://lab.l

Re: r364080 - [OPENMP]Fix PR42068: Vla type is not captured.

Hi Alexey, This commit broke ARM bots, logs are availabale here: http://lab.llvm.org:8011/builders/clang-cmake-armv8-quick/builds/13627/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Aparallel_codegen.cpp Thanks, Yvan On Fri, 21 Jun 2019 at 19:25, Alexey Bataev via cfe-commits wrote: > > Aut

[PATCH] D62373: [ASTImporter] Store import errors for Decls

a_sidorin accepted this revision. a_sidorin added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/AST/ASTImporterTest.cpp:4697 +DefaultTestValuesForRunOptions, ); + INSTANTIATE_TEST_CASE_P(ParameterizedTests,

r364165 - PR42362: Fix auto deduction of template parameter packs from

Author: rsmith Date: Sun Jun 23 22:53:11 2019 New Revision: 364165 URL: http://llvm.org/viewvc/llvm-project?rev=364165&view=rev Log: PR42362: Fix auto deduction of template parameter packs from type-dependent argument packs. We need to strip off the PackExpansionExpr to get the real (dependent) t

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

vivekvpandya added a comment. Minor suggestion, you may want to update http://clang.llvm.org/cxx_status.html page for "typename optional in more contexts" with in this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53847/new/ https://review