[PATCH] D63316: [clangd] Include the diagnostics's code when comparing diagnostics

kadircet added a comment. Could you also add a lit test for the case you mentioned in the github issue? You can find pointers in clang-tools-extra/clangd/test/diagnostics.test and clang-tools-extra/clangd/test/fixits-codeaction.test Comment at: clang-tools-extra/clangd/Protoc

[PATCH] D58880: [clangd] Type hierarchy subtypes

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM with a few small comments. Thanks for implementing this awesome feature! Comment at: clang-tools-extra/clangd/FindSymbols.cpp:42 +llvm::Optional symbolToLocation(

[PATCH] D62839: [clangd] Index API and implementations for relations

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62839/new/ https://reviews.llvm.org/D62839 __

[PATCH] D60523: [clang] Don't segfault on incorrect using directive (PR41400)

This revision was automatically updated to reflect the committed changes. Closed by commit rL363360: [clang] Don't segfault on incorrect using directive (PR41400) (authored by Tyker, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r363056 - [RISCV][NFC] Add missing test files for D54091

Author: lewis-revill Date: Tue Jun 11 05:49:15 2019 New Revision: 363056 URL: http://llvm.org/viewvc/llvm-project?rev=363056&view=rev Log: [RISCV][NFC] Add missing test files for D54091 Added: cfe/trunk/test/CodeGen/riscv-inline-asm.c cfe/trunk/test/Sema/inline-asm-validate-riscv.c Added

r363055 - [RISCV] Add inline asm constraints I, J & K for RISC-V

Author: lewis-revill Date: Tue Jun 11 05:44:01 2019 New Revision: 363055 URL: http://llvm.org/viewvc/llvm-project?rev=363055&view=rev Log: [RISCV] Add inline asm constraints I, J & K for RISC-V This allows the constraints I, J & K to be used in inline asm for RISC-V, with the following semantics

[PATCH] D54091: [RISCV] Add inline asm constraints I, J & K for RISC-V

This revision was automatically updated to reflect the committed changes. Closed by commit rL363055: [RISCV] Add inline asm constraints I, J & K for RISC-V (authored by lewis-revill, committed by ). Changed prior to commit: https://reviews.llvm.org/D54091?vs=203367&id=204043#toc Repository:

r363360 - [clang] Don't segfault on incorrect using directive (PR41400)

Author: tyker Date: Fri Jun 14 01:25:52 2019 New Revision: 363360 URL: http://llvm.org/viewvc/llvm-project?rev=363360&view=rev Log: [clang] Don't segfault on incorrect using directive (PR41400) Summary: this is a bugfixe for [[ https://bugs.llvm.org/show_bug.cgi?id=41400 | PR41400 ]] added null

[PATCH] D33029: [clang-format] add option for dangling parenthesis

gracicot added a comment. Will this option also work with dangling braces from initializers? I have some code that looks like this: return some_type_with_a_long_name{ get_param_number_one(), get_param_number_two() }; Clang format will put the brace at the end of the line: ret

[PATCH] D54295: [RISCV] Add inline asm constraint A for RISC-V

lewis-revill updated this revision to Diff 204512. lewis-revill retitled this revision from "[WIP, RISCV] Add inline asm constraint A for RISC-V" to "[RISCV] Add inline asm constraint A for RISC-V". Herald added subscribers: Jim, benna, psnobl. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D63072: [clang] Fixing incorrect implicit deduction guides (PR41549)

This revision was automatically updated to reflect the committed changes. Closed by commit rL363361: [clang] Fixing incorrect implicit deduction guides (PR41549) (authored by Tyker, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: h

[PATCH] D61790: [C++20] add Basic consteval specifier

This revision was automatically updated to reflect the committed changes. Closed by commit rL363362: [C++20] add Basic consteval specifier (authored by Tyker, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org

[PATCH] D63323: [clangd] Don't maintain a list of c-family extensions in vscode extension.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. There is no need to maintain this list by ourself, vscode already provides this feature. Repository: rG LLVM Github Monorepo htt

[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

Blackhart created this revision. Blackhart created this object with edit policy "Only User: Blackhart (Thomas Manceau)". Blackhart added a project: clang-tools-extra. Herald added subscribers: cfe-commits, xazax.hun, mgorny. Herald added a project: clang. This patch will: - replace all occurrenc

Re: [PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

On Fri, Jun 14, 2019 at 12:48 PM Thomas Manceau via Phabricator via cfe-commits wrote: > > Blackhart created this revision. > Blackhart created this object with edit policy "Only User: Blackhart (Thomas > Manceau)". You might want to unset that :) > Blackhart added a project: clang-tools-extra.

[PATCH] D63270: [clangd] Add include-mapping for C symbols.

hokein updated this revision to Diff 204731. hokein marked 7 inline comments as done. hokein added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63270/new/ https://reviews.llvm.org/D63270 Files: clang-tools-ex

[PATCH] D63270: [clangd] Add include-mapping for C symbols.

hokein added inline comments. Comment at: clang-tools-extra/clangd/include-mapping/gen_std.py:90 +symbol_index_root = page_root +parse_pages = [(page_root, "index.html", "")] + kadircet wrote: > maybe we should rather pass some something like "INVALID" as

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

anton-afanasyev created this revision. anton-afanasyev added reviewers: russell.gallop, lebedev.ri, thakis. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. Add `Frontend` time trace entry to `HandleTranslationUnit()` function. Add test to check a

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

anton-afanasyev updated this revision to Diff 204738. anton-afanasyev added a comment. Small fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63325/new/ https://reviews.llvm.org/D63325 Files: clang/lib/CodeGen/CodeGenAction.cpp clang/test/Dri

[PATCH] D63270: [clangd] Add include-mapping for C symbols.

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/include-mapping/gen_std.py:95 - parse_pages = [ -(cpp_root, "symbol_index.html", "std::"), -# std sub-namespace symbo

[PATCH] D63323: [clangd] Don't maintain a list of c-family extensions in vscode extension.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. could you also bump the version numbers? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63323/new/ https://reviews.llvm.org/D63323 ___

r363369 - add a missing parenthese in the clang doc

Author: sylvestre Date: Fri Jun 14 04:33:40 2019 New Revision: 363369 URL: http://llvm.org/viewvc/llvm-project?rev=363369&view=rev Log: add a missing parenthese in the clang doc Modified: cfe/trunk/docs/ThinLTO.rst Modified: cfe/trunk/docs/ThinLTO.rst URL: http://llvm.org/viewvc/llvm-projec

[PATCH] D63299: [Clang] Parse GNU fallthrough attributes

xbolva00 marked an inline comment as done. xbolva00 added a comment. isDeclarationStatement() returns true for __attribute__((fallthough)) ; Comment at: lib/Parse/ParseStmt.cpp:102 ParsedAttributesWithRange Attrs(AttrFactory); + MaybeParseGNUAttributes(Attrs); MaybeParse

[PATCH] D63299: [Clang] Parse GNU fallthrough attributes

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: lib/Parse/ParseStmt.cpp:102 ParsedAttributesWithRange Attrs(AttrFactory); + MaybeParseGNUAttributes(Attrs); MaybeParseCXX11Attributes(Attrs, nullptr, /*MightBeObjCMessageSend*/ true); --

[clang-tools-extra] r363372 - [clangd] Don't maintain a list of c-family extensions in vscode extension.

Author: hokein Date: Fri Jun 14 04:56:13 2019 New Revision: 363372 URL: http://llvm.org/viewvc/llvm-project?rev=363372&view=rev Log: [clangd] Don't maintain a list of c-family extensions in vscode extension. Summary: There is no need to maintain this list by ourself, vscode already provides this

[PATCH] D63323: [clangd] Don't maintain a list of c-family extensions in vscode extension.

hokein added a comment. In D63323#1543331 , @kadircet wrote: > could you also bump the version numbers? We usually bump the version in a separate commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63323

[PATCH] D63323: [clangd] Don't maintain a list of c-family extensions in vscode extension.

This revision was automatically updated to reflect the committed changes. Closed by commit rL363372: [clangd] Don't maintain a list of c-family extensions in vscode extension. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D63329: Allow static linking of libc++ on Linux, just like -static-libstdc++

erikjv created this revision. erikjv added reviewers: dlj, cfe-commits. Herald added a reviewer: EricWF. Herald added a subscriber: jfb. Herald added a project: clang. Dynamic linking against libc++ on Linux was already supported, as is dynamic and static linking against libstdc++. What was missin

[PATCH] D63329: Allow static linking of libc++ on Linux, just like -static-libstdc++

lebedev.ri added a comment. Tests? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63329/new/ https://reviews.llvm.org/D63329 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[PATCH] D63330: [clangd] Add Value field to HoverInfo

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Put a symbols value information which is deduced from initializer expression into HoverInfo struct. Repository:

[clang-tools-extra] r363375 - [clangd] Bump vscode-clangd v0.0.14

Author: hokein Date: Fri Jun 14 05:11:04 2019 New Revision: 363375 URL: http://llvm.org/viewvc/llvm-project?rev=363375&view=rev Log: [clangd] Bump vscode-clangd v0.0.14 CHANGELOG: - use the vscode-buildin feature to detect language (rather than using file extensions), this fixes the extension n

r363376 - Revert "[OpenCL] Move OpenCLBuiltins.td and remove unused include"

Author: svenvh Date: Fri Jun 14 05:14:58 2019 New Revision: 363376 URL: http://llvm.org/viewvc/llvm-project?rev=363376&view=rev Log: Revert "[OpenCL] Move OpenCLBuiltins.td and remove unused include" This reverts commit r363242 as it broke some builds with make[2]: *** No rule to make target '

[PATCH] D63331: [clangd] WIP/RFC: Prototype for semantic highlighting proposal

nik created this revision. nik added reviewers: ilya-biryukov, sammccall. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, javed.absar, mgorny. Herald added a project: clang. TODO: Is the visitor the right approach? TODO: Add tests TODO: Test that only highlightings

Re: r363376 - Revert "[OpenCL] Move OpenCLBuiltins.td and remove unused include"

Most builds seem to be happy. Since you're seeing this problem, maybe you could debug it a bit? On Fri, Jun 14, 2019 at 8:11 AM Sven van Haastregt via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: svenvh > Date: Fri Jun 14 05:14:58 2019 > New Revision: 363376 > > URL: http://llvm.org

[PATCH] D63331: [clangd] WIP/RFC: Prototype for semantic highlighting proposal

nik added a comment. Any interest in having the *proposal* implemented? While there is a client implementation available in the theia ide (https://github.com/theia-ide/theia/pull/2332), I have only tested this against Qt Creator's client implementation (also work in progress). Repository: r

Re: r363376 - Revert "[OpenCL] Move OpenCLBuiltins.td and remove unused include"

Nevermind, just saw the discussion on phab. Reverting while debugging is of course fine. On Fri, Jun 14, 2019 at 8:26 AM Nico Weber wrote: > Most builds seem to be happy. Since you're seeing this problem, maybe you > could debug it a bit? > > On Fri, Jun 14, 2019 at 8:11 AM Sven van Haastregt vi

[PATCH] D62739: AMDGPU: Always emit amdgpu-flat-work-group-size

arsenm added a comment. In D62739#1536390 , @yaxunl wrote: > My concern is that this essentially forcing user to add > amdgpu_flat_work_group_size attribute to all kernels that are executed > outside of (128,256). Potentially this can cause lots of regre

[PATCH] D62739: AMDGPU: Always emit amdgpu-flat-work-group-size

arsenm added a comment. In D62739#1536428 , @b-sumner wrote: > We need to communicate with anyone generating IR to ensure this is being > generated before we change the default. clang is only one of those > generators. This change will also need to be

r363379 - Revert r363298 "[lit] Disable test on darwin when building shared libs."

Author: nico Date: Fri Jun 14 05:58:17 2019 New Revision: 363379 URL: http://llvm.org/viewvc/llvm-project?rev=363379&view=rev Log: Revert r363298 "[lit] Disable test on darwin when building shared libs." It broke running check-lld on mac, see https://reviews.llvm.org/D61697 Modified: cfe/tru

[PATCH] D63331: [clangd] WIP/RFC: Prototype for semantic highlighting proposal

hokein added subscribers: jvikstrom, nridge, hokein. hokein added a comment. Yeah, we definitely have interest in this feature, and our intern @jvikstrom will work on this feature this summer. You probably missed the discussion o

[PATCH] D61697: [lit] Disable test on darwin when building shared libs.

thakis added a comment. I reverted this in r363379 to unbreak check-lld on mac. I think the if config.enable_shared: features.add("enable_shared") bit belongs in clang/test/lit.cfg.py, not in llvm/utils/lit/lit/llvm/config.py. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D62883: [analyzer] Track conditions of terminator statements on which the reported node depends on

xazax.hun added a comment. I looked at bug path with the Optional. I did not debug into the analyzer but my intuition is the following: `DefChainEnd` is interesting. `TerminatedPaths` is the control dependency of `DefChainEnd`. And there are probably other things that are the control and/or val

[PATCH] D63164: [HIP] Add option to force lambda nameing following ODR in HIP/CUDA.

hliao added a comment. PING Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63164/new/ https://reviews.llvm.org/D63164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D62739: AMDGPU: Always emit amdgpu-flat-work-group-size

arsenm added a comment. In D62739#1543437 , @arsenm wrote: > In D62739#1536390 , @yaxunl wrote: > > > My concern is that this essentially forcing user to add > > amdgpu_flat_work_group_size attribute to all kernels

[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

Blackhart updated this revision to Diff 204757. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63324/new/ https://reviews.llvm.org/D63324 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.txt clang-tools-extra/clang-tidy/modernize/ModernizeTidyModule.cpp clang-tools-extra/cla

[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

lebedev.ri added a comment. Missing tests. Comment at: clang-tools-extra/clang-tidy/modernize/ReplaceMemcpyByStdCopy.cpp:120 +} // namespace clang \ No newline at end of file please add all the missing newlines Comment at: clang-tools-extra

r363390 - AMDGPU: Use AMDGPU toolchain for other OSes

Author: arsenm Date: Fri Jun 14 06:39:57 2019 New Revision: 363390 URL: http://llvm.org/viewvc/llvm-project?rev=363390&view=rev Log: AMDGPU: Use AMDGPU toolchain for other OSes This would need more work to actually support them, but this is less wrong than the default. Modified: cfe/trunk/li

[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

Blackhart updated this revision to Diff 204758. Blackhart added a comment. Herald added a subscriber: jsji. Add missing "override" keywords CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63324/new/ https://reviews.llvm.org/D63324 Files: clang-tools-extra/clang-tidy/modernize/CMakeList

[PATCH] D62696: AMDGPU: Use AMDGPU toolchain for other OSes

arsenm closed this revision. arsenm added a comment. r363390 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62696/new/ https://reviews.llvm.org/D62696 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

Blackhart updated this revision to Diff 204759. Blackhart added a comment. Fix file comments typo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63324/new/ https://reviews.llvm.org/D63324 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.txt clang-tools-extra/clang-tidy/moder

[PATCH] D63329: Allow static linking of libc++ on Linux, just like -static-libstdc++

erikjv added a comment. In D63329#1543407 , @lebedev.ri wrote: > Tests? I can add a test, but I'd first like to know if this would be accepted. Test would be along the lines of "test/Driver/fuchsia.cpp" line 36, where it tests "-static-libstdc++". Re

[PATCH] D59673: [Clang] Harmonize Split DWARF options with llc

tejohnson added a comment. lgtm for the LTO bits. Suggestion below for comment. Comment at: llvm/include/llvm/LTO/Config.h:92 + /// The name for the split debug info file used for the DW_AT_[GNU_]dwo_name + /// attribute in the skeleton CU. + std::string SplitDwarfFile;

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

gtbercea updated this revision to Diff 204763. gtbercea added a comment. - Fix function name. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63009/new/ https://reviews.llvm.org/D63009 Files: lib/CodeGen/CGOpenMPRuntime.cpp test/OpenMP/target_depend_codegen.cp

[PATCH] D41217: [Concepts] Concept Specialization Expressions

saar.raz updated this revision to Diff 204764. saar.raz added a comment. Add support for CSE mangling Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41217/new/ https://reviews.llvm.org/D41217 Files: include/clang/AST/ExprCXX.h include/clang/AST/RecursiveASTVi

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

gtbercea marked 2 inline comments as done. gtbercea added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:5122 +NewTask = CGF.EmitRuntimeCall( + createRuntimeFunction(OMPRTL__kmpc_omp_target_task_alloc), AllocArgs); + } else { ABataev wrote

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:5122 +NewTask = CGF.EmitRuntimeCall( + createRuntimeFunction(OMPRTL__kmpc_omp_target_task_alloc), AllocArgs); + } else { gtbercea wrote: > ABataev wrote: > > Can we use the same

[PATCH] D62739: AMDGPU: Always emit amdgpu-flat-work-group-size

b-sumner added a comment. In D62739#1543438 , @arsenm wrote: > In D62739#1536428 , @b-sumner wrote: > > > We need to communicate with anyone generating IR to ensure this is being > > generated before we change the

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:5122 +NewTask = CGF.EmitRuntimeCall( + createRuntimeFunction(OMPRTL__kmpc_omp_target_task_alloc), AllocArgs); + } else { ABataev wrote

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:5122 +NewTask = CGF.EmitRuntimeCall( + createRuntimeFunction(OMPRTL__kmpc_omp_target_task_alloc), AllocArgs); + } else { gtbercea wrote: > ABataev wrote: > > gtbercea wrote: > >

[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

Blackhart updated this revision to Diff 204768. Blackhart marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63324/new/ https://reviews.llvm.org/D63324 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.txt clang-tools-extra/clang-tidy/modernize/Mod

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:5122 +NewTask = CGF.EmitRuntimeCall( + createRuntimeFunction(OMPRTL__kmpc_omp_target_task_alloc), AllocArgs); + } else { ABataev wrote

[PATCH] D59673: [Clang] Harmonize Split DWARF options with llc

aaronpuchert added inline comments. Comment at: llvm/include/llvm/LTO/Config.h:92 + /// The name for the split debug info file used for the DW_AT_[GNU_]dwo_name + /// attribute in the skeleton CU. + std::string SplitDwarfFile; tejohnson wrote: > Probably needs

[PATCH] D62883: [analyzer] Track conditions of terminator statements on which the reported node depends on

Szelethus added a comment. I don't understand why the visibility had to be changed (especially without explanation), and unless there's a strong reason for it, I strongly disagree with it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62883/new/ https://reviews.llvm.org/D62883

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:5122 +NewTask = CGF.EmitRuntimeCall( + createRuntimeFunction(OMPRTL__kmpc_omp_target_task_alloc), AllocArgs); + } else { gtbercea wrote: > ABataev wrote: > > gtbercea wrote: > >

[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

Blackhart updated this revision to Diff 204770. Blackhart added a comment. Modernize memcpy only if C++20 is enabled CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63324/new/ https://reviews.llvm.org/D63324 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.txt clang-tools-ext

[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

lebedev.ri added a comment. In D63324#1543607 , @Blackhart wrote: > Modernize memcpy only if C++20 is enabled ... why? This is also missing documentation,releasenotes changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63324/new/ https://re

[PATCH] D63335: [HIP] Change kernel stub name again

hliao created this revision. hliao added reviewers: yaxunl, tra. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Prefix kernel stub with `__device_stub__` to avoid potential symbol name conflicts in debugger. - Revise the interface to derive the stub name and simplify the

[PATCH] D62739: AMDGPU: Always emit amdgpu-flat-work-group-size

arsenm added a comment. In D62739#1543578 , @b-sumner wrote: > In D62739#1543438 , @arsenm wrote: > > > In D62739#1536428 , @b-sumner > > wrote: > > > > > We need to communi

[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

Blackhart added a comment. In D63324#1543609 , @lebedev.ri wrote: > In D63324#1543607 , @Blackhart wrote: > > > Modernize memcpy only if C++20 is enabled > > > ... why? > This is also missing documentation,releasen

[PATCH] D63256: [OpenCL] Split type and macro definitions into opencl-c-base.h

asavonic added a comment. LGTM, except for the `IncludeDefaultHeader` and `DeclareOpenCLBuiltins` logic. Comment at: lib/Frontend/CompilerInvocation.cpp:2194 } +// Include base header file for builtin types and constants. +if (Opts.DeclareOpenCLBuiltins) {

r363414 - [AMDGPU] Enable the implicit arguments for HIP (CLANG)

Author: yaxunl Date: Fri Jun 14 08:54:47 2019 New Revision: 363414 URL: http://llvm.org/viewvc/llvm-project?rev=363414&view=rev Log: [AMDGPU] Enable the implicit arguments for HIP (CLANG) Enable 48-bytes of implicit arguments for HIP as well. Earlier it was enabled for OpenCL. This code is speci

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:5122 +NewTask = CGF.EmitRuntimeCall( + createRuntimeFunction(OMPRTL__kmpc_omp_target_task_alloc), AllocArgs); + } else { ABataev wrote

[PATCH] D62244: [AMDGPU] Enable the implicit arguments for HIP (CLANG)

This revision was automatically updated to reflect the committed changes. Closed by commit rL363414: [AMDGPU] Enable the implicit arguments for HIP (CLANG) (authored by yaxunl, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:

[PATCH] D63108: [OpenMP] Add support for handling declare target to clause when unified memory is required

gtbercea added a comment. ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63108/new/ https://reviews.llvm.org/D63108 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D60883: [OpenMP] Avoid emitting maps for target link variables when unified memory is used

gtbercea updated this revision to Diff 204780. gtbercea added a comment. - Remove virtual. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60883/new/ https://reviews.llvm.org/D60883 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h lib/Sem

[PATCH] D41569: [Concepts] Constraint enforcement and diagnostics

saar.raz updated this revision to Diff 204782. saar.raz added a comment. Add support for CSE mangling Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41569/new/ https://reviews.llvm.org/D41569 Files: include/clang/AST/ExprCXX.h include/clang/Basic/DiagnosticSe

[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

lebedev.ri added a comment. In D63324#1543626 , @Blackhart wrote: > In D63324#1543609 , @lebedev.ri > wrote: > > > In D63324#1543607 , @Blackhart > > wrote: > > > > > Moder

r363415 - Reland: [Remarks] Refactor optimization remarks setup

Author: thegameg Date: Fri Jun 14 09:20:51 2019 New Revision: 363415 URL: http://llvm.org/viewvc/llvm-project?rev=363415&view=rev Log: Reland: [Remarks] Refactor optimization remarks setup * Add a common function to setup opt-remarks * Rename common options to the same names * Add error types to

[PATCH] D41217: [Concepts] Concept Specialization Expressions

saar.raz updated this revision to Diff 204784. saar.raz added a comment. Delay support for mangling to later patch (where CSEs are formed instead of UnresolvedLookupExprs with dependent args) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41217/new/ https://revie

[PATCH] D60883: [OpenMP] Avoid emitting maps for target link variables when unified memory is used

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:1628 + /// Return whether the unified_shared_memory has been specified. + bool hasRequiresUnifiedSharedMemory(); }; You can make this function const. Repository: rC Clang CHANGES SIN

[PATCH] D63108: [OpenMP] Add support for handling declare target to clause when unified memory is required

ABataev added a comment. Will review it next week, when I'm back to work, need to think about it a little bit. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63108/new/ https://reviews.llvm.org/D63108 ___ cfe-commits

[PATCH] D62739: AMDGPU: Always emit amdgpu-flat-work-group-size

arsenm updated this revision to Diff 204795. arsenm added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62739/new/ https://reviews.llvm.org/D62739 Files: lib/CodeGen/TargetInfo.cpp test/CodeGenOpenCL/amdgpu-attrs.cl Index: test/CodeGenOpenCL/amdgpu-attrs.cl

[PATCH] D61697: [lit] Disable test on darwin when building shared libs.

hintonda added a comment. In D61697#1543443 , @thakis wrote: > I reverted this in r363379 to unbreak check-lld on mac. I think the > > if config.enable_shared: > features.add("enable_shared") > > > bit belongs in clang/test/lit.cfg.py

[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

xbolva00 added a comment. This might not be currently ideal recommendation since std::copy produces memmove with -O3. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63324/new/ https://reviews.llvm.org/D63324 ___ cfe-commits mailing list cfe

[PATCH] D63256: [OpenCL] Split type and macro definitions into opencl-c-base.h

svenvh updated this revision to Diff 204796. svenvh added a comment. Change `IncludeDefaultHeader` and `DeclareOpenCLBuiltins` logic as per @asavonic's comments. Also extend `test/SemaOpenCL/fdeclare-opencl-builtins.cl` to test the interplay of both options. CHANGES SINCE LAST ACTION https

[PATCH] D59673: [Clang] Harmonize Split DWARF options with llc

tejohnson added inline comments. Comment at: llvm/include/llvm/LTO/Config.h:92 + /// The name for the split debug info file used for the DW_AT_[GNU_]dwo_name + /// attribute in the skeleton CU. + std::string SplitDwarfFile; aaronpuchert wrote: > tejohnson wrot

[PATCH] D63335: [HIP] Change kernel stub name again

tra added a comment. Is there particular reason you need to switch to this naming scheme? One issue with this patch is that demanglers will no longer be able to deal with the name. While they do know to ignore .stub suffix, they can't deal with `__device_stub_` prefix. E.g: % c++filt __devic

[PATCH] D63335: [HIP] Change kernel stub name again

hliao marked an inline comment as done. hliao added a comment. it's requested from debugger people. they don't want to the host-side stub could match the device-side kernel function name. the previous scheme cannot prevent that. Comment at: clang/lib/CodeGen/CGCUDANV.cpp:222-

[PATCH] D63335: [HIP] Change kernel stub name again

hliao marked an inline comment as done. hliao added inline comments. Comment at: clang/lib/CodeGen/CGCUDANV.cpp:222-226 + assert((CGF.CGM.getContext().getAuxTargetInfo() && + (CGF.CGM.getContext().getAuxTargetInfo()->getCXXABI() != + CGF.CGM.getContext().getTa

[PATCH] D63335: [HIP] Change kernel stub name again

tra added a comment. In D63335#1543845 , @hliao wrote: > it's requested from debugger people. they don't want to the host-side stub > could match the device-side kernel function name. the previous scheme cannot > prevent that. I understand that you wan

[PATCH] D62831: [CodeGen][ObjC] Add attribute "objc_arc_intert" to ObjC globals that are retain-agnostic

rjmccall added a comment. Please rename the test. There's also a typo in the differential title; please make sure that doesn't get into the commit message. Otherwise LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62831/new/ https://reviews.llvm.org/D62831

[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

Eugene.Zelenko added a comment. New check must be mentioned in Release Notes and its documentation provided. Comment at: clang-tools-extra/clang-tidy/modernize/ReplaceMemcpyByStdCopy.cpp:68 +const CallExpr *MemcpyNode) { + const auto

[PATCH] D60883: [OpenMP] Avoid emitting maps for target link variables when unified memory is used

gtbercea updated this revision to Diff 204806. gtbercea added a comment. - Make function const. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60883/new/ https://reviews.llvm.org/D60883 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h li

r363428 - C++ DR712 and others: handle non-odr-use resulting from an lvalue-to-rvalue conversion applied to a member access or similar not-quite-trivial lvalue expression.

Author: rsmith Date: Fri Jun 14 10:46:37 2019 New Revision: 363428 URL: http://llvm.org/viewvc/llvm-project?rev=363428&view=rev Log: C++ DR712 and others: handle non-odr-use resulting from an lvalue-to-rvalue conversion applied to a member access or similar not-quite-trivial lvalue expression.

r363430 - Remove unused SK_LValueToRValue initialization step.

Author: rsmith Date: Fri Jun 14 10:46:39 2019 New Revision: 363430 URL: http://llvm.org/viewvc/llvm-project?rev=363430&view=rev Log: Remove unused SK_LValueToRValue initialization step. In addition to being unused and duplicating code, this was also wrong (it didn't properly mark the operand as b

r363429 - PR23833, DR2140: an lvalue-to-rvalue conversion on a glvalue of type

Author: rsmith Date: Fri Jun 14 10:46:38 2019 New Revision: 363429 URL: http://llvm.org/viewvc/llvm-project?rev=363429&view=rev Log: PR23833, DR2140: an lvalue-to-rvalue conversion on a glvalue of type nullptr_t does not access memory. We now reuse CK_NullToPointer to represent a conversion from

Re: r363295 - C++ DR712 and others: handle non-odr-use resulting from an lvalue-to-rvalue conversion applied to a member access or similar not-quite-trivial lvalue expression.

On Thu, 13 Jun 2019 at 21:02, Nico Weber wrote: > Hi, > > this made clang segfault on some inputs seen in ANGLE. I filed PR42276 > with a reduced repro and reverted this (and the two dependent changes) in > r363352 for now. > Thanks for the revert and the reduced testcase. Fixed and recommitted

[PATCH] D63156: [clang][NewPM] Add -fno-experimental-new-pass-manager to tests

leonardchan added a comment. I did some more digging and found the following differences between PMs for each test, and they seem to all differ and can be fixed for different reasons. **CodeGen/aggregate-assign-call.c**: The new PM on -O1 codegen produces the do/while loop differently but still

[PATCH] D63156: [clang][NewPM] Add -fno-experimental-new-pass-manager to tests

leonardchan updated this revision to Diff 204808. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63156/new/ https://reviews.llvm.org/D63156 Files: clang/lib/CodeGen/Ba

r363435 - [OpenMP] Avoid emitting maps for target link variables when unified memory is used

Author: gbercea Date: Fri Jun 14 10:58:26 2019 New Revision: 363435 URL: http://llvm.org/viewvc/llvm-project?rev=363435&view=rev Log: [OpenMP] Avoid emitting maps for target link variables when unified memory is used Summary: This patch avoids the emission of maps for target link variables when

  1   2   >