[PATCH] D63081: [WebAssembly] Cleanup toolchain test files. NFC.

dschuff added a comment. LGTM Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63081/new/ https://reviews.llvm.org/D63081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

sylvestre.ledru added a comment. I will wait for @dexonsmith 's opinion Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63048/new/ https://reviews.llvm.org/D63048 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D63092: [Frontend] Use executable path when creating invocation from cmdline

sammccall added a comment. Thanks for pushing on this. I guess this must affect all clang-tools when used with a wrapper, which seems important. (I've just been using bazel and local cmake, so haven't hit this myself). In D63092#1536890 , @phosek wrote:

r363036 - [Support][Test] Time profiler: add regression test

Author: anton-afanasyev Date: Tue Jun 11 01:25:54 2019 New Revision: 363036 URL: http://llvm.org/viewvc/llvm-project?rev=363036&view=rev Log: [Support][Test] Time profiler: add regression test Summary: Add output to `llvm::errs()` when `-ftime-trace` option is enabled, add regression test checkin

[clang-tools-extra] r363037 - [clangd] Add missing header guard.

Author: hokein Date: Tue Jun 11 01:50:35 2019 New Revision: 363037 URL: http://llvm.org/viewvc/llvm-project?rev=363037&view=rev Log: [clangd] Add missing header guard. Modified: clang-tools-extra/trunk/clangd/refactor/Rename.h Modified: clang-tools-extra/trunk/clangd/refactor/Rename.h URL:

[PATCH] D32478: [clang-format] Fix AlignOperands when BreakBeforeBinaryOperators is set

Typz updated this revision to Diff 203987. Typz added a comment. Herald added a project: clang. Rebase Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D32478/new/ https://reviews.llvm.org/D32478 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Forma

[PATCH] D63098: [CodeComplete] Allow completing enum values within case statements, and insert 'case' as a fixit.

ilya-biryukov added a comment. Not displaying 'case' is actually confusing to my taste. WDYT about allowing multiple "typed text" chunks or allowing to mark other chunks that are supposed be part of filter text? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63098

[PATCH] D63126: [clangd] Implement "prepareRename"

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. "prepareRename" request is added in LSP v3.12.0. No test yet, but want some early feedback. Unfortunately, due to the bu

[PATCH] D63098: [CodeComplete] Allow completing enum values within case statements, and insert 'case' as a fixit.

sammccall added a comment. In D63098#1537601 , @ilya-biryukov wrote: > Not displaying 'case' is actually confusing to my taste. > WDYT about allowing multiple "typed text" chunks or allowing to mark other > chunks that are supposed be part of filter tex

[PATCH] D63127: [clang-tidy] Fixed checker for abseil to work in C++17 mode

jvikstrom created this revision. jvikstrom added reviewers: hokein, gribozavr. Herald added a subscriber: xazax.hun. Herald added a project: clang. Fixes the checker for abseil to make tests pass in C++17 mode Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D63127 Files: clang

r363041 - [Frontend] Avoid creating auxilary files during a unit test. NFC

Author: ibiryukov Date: Tue Jun 11 02:52:30 2019 New Revision: 363041 URL: http://llvm.org/viewvc/llvm-project?rev=363041&view=rev Log: [Frontend] Avoid creating auxilary files during a unit test. NFC A test added in r363009 logs diagnostics into a file inside current working directory. This brea

Re: r363009 - [Frontend] SetUpDiagnosticLog should handle unowned diagnostic consumer

Hi Alex, Just wanted to let you know that I removed logging of diagnostics into a file inside the unit test in r363041 to unbreak our integrate. On Tue, Jun 11, 2019 at 1:29 AM Alex Lorenz via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: arphaman > Date: Mon Jun 10 16:32:42 2019 >

[PATCH] D63128: Fixed google-readability-casting test to work in c++17

SureYeaah created this revision. SureYeaah added reviewers: gribozavr, hokein. Herald added a project: clang. Fixed google-readability-casting.cpp to get tests working in c++17 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D63128 Files: clang-tools-extra/clang-tidy/google/Av

[PATCH] D63128: Fixed google-readability-casting test to work in c++17

gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land. I'll commit this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63128/new/ https://reviews.llvm.org/D63128 _

[PATCH] D63129: [clang-tidy] Fix invalid read on destruction

nik created this revision. Herald added subscribers: cfe-commits, jfb, xazax.hun. Herald added a project: clang. ...in case the clang tidy plugin is linked into the clang binary. Valgrind's memcheck reports: 8949== Invalid read ==8866== Invalid read of size 4

[clang-tools-extra] r363047 - Fixed google-readability-casting test to work in c++17

Author: gribozavr Date: Tue Jun 11 03:59:22 2019 New Revision: 363047 URL: http://llvm.org/viewvc/llvm-project?rev=363047&view=rev Log: Fixed google-readability-casting test to work in c++17 Summary: Fixed google-readability-casting.cpp to get tests working in c++17 Reviewers: gribozavr, hokein

[PATCH] D63128: Fixed google-readability-casting test to work in c++17

This revision was automatically updated to reflect the committed changes. Closed by commit rL363047: Fixed google-readability-casting test to work in c++17 (authored by gribozavr, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: htt

[PATCH] D61939: AArch64: add support for arm64_23 (ILP32) IR generation

t.p.northover marked an inline comment as done. t.p.northover added a comment. Thanks for the suggestion Florian, and sorry it's taken so long to act on it. I've split the patch up as you suggest, I'll make this one cover the Triple bits. Comment at: clang/lib/Basic/Targets/A

[PATCH] D61939: AArch64: add support for arm64_23 (ILP32) IR generation

t.p.northover updated this revision to Diff 204009. t.p.northover added a comment. This diff now only covers the trivial additions so that "arm64_32" is understood by the driver and creates AArch64 instantiations of relevant classes. Code generated is still wildly incorrect (not even ILP32 yet).

[PATCH] D63130: [Clang] Rename -split-dwarf-file to -split-dwarf-output

aaronpuchert created this revision. aaronpuchert added reviewers: dblaikie, echristo. Herald added subscribers: dexonsmith, steven_wu, aprantl, mehdi_amini. Herald added a project: clang. This is the first in a series of changes trying to align clang -cc1 flags for Split DWARF with those of llc. T

[PATCH] D63131: arm64_32: implement the desired ABI for the ILP32 triple.

t.p.northover created this revision. t.p.northover added a reviewer: fhahn. Herald added subscribers: jfb, kristof.beyls, javed.absar, mcrosier. Herald added a project: clang. This adds all of the ABI tweaks we need to match the arm64_32 ABI as it exists in the wild. Most cirtically, of course, i

[PATCH] D59673: [Clang] Harmonize Split DWARF options with llc

aaronpuchert updated this revision to Diff 204013. aaronpuchert added a comment. Split from other changes as suggested. A predecessor is in D63130 , and a successor will come soon. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D596

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

Typz updated this revision to Diff 204015. Typz added a comment. Rebase Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50078/new/ https://reviews.llvm.org/D50078 Files: lib/Format/ContinuationIndenter.cpp lib/Format/ContinuationIndenter.h lib/Format/Whitesp

[PATCH] D63127: [clang-tidy] Fixed checker for abseil to work in C++17 mode

hokein added a comment. Thanks for investigating these, nice work! Some initial comments: - since your patch fixes four different check, I'd suggest to separate it (one patch per check) - there are some non-functional changes (code format), I'd avoid them in this patch (we could address them i

[PATCH] D59673: [Clang] Harmonize Split DWARF options with llc

aaronpuchert updated this revision to Diff 204017. aaronpuchert added a comment. Correct an oversight. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59673/new/ https://reviews.llvm.org/D59673 Files: include/clang/Basic/CodeGenOptions.h include/clang/Driver/C

[PATCH] D63127: [clang-tidy] Fixed checker for abseil to work in C++17 mode

gribozavr added inline comments. Comment at: clang-tools-extra/clang-tidy/abseil/FasterStrsplitDelimiterCheck.cpp:86 +.bind("ByAnyChar"), +expr(hasDescendant(cxxConstructExpr( + hasType(recordDecl(hasName("::absl::ByAnyChar"))), --

r363052 - Make sure a test from r363036 does not write into a working directory

Author: ibiryukov Date: Tue Jun 11 05:05:03 2019 New Revision: 363052 URL: http://llvm.org/viewvc/llvm-project?rev=363052&view=rev Log: Make sure a test from r363036 does not write into a working directory It breaks if build directory is not writable. This change is required to fix our integrate.

[clang-tools-extra] r363053 - [clang-tidy] Fix typo in bugprone-string-constructor.

Author: courbet Date: Tue Jun 11 05:12:06 2019 New Revision: 363053 URL: http://llvm.org/viewvc/llvm-project?rev=363053&view=rev Log: [clang-tidy] Fix typo in bugprone-string-constructor. s/bigger then/bigger than/ Modified: clang-tools-extra/trunk/clang-tidy/bugprone/StringConstructorCheck.

[PATCH] D63062: [clang-format] Added New Style Rule: BitFieldDeclsOnSeparateLines

Manikishan updated this revision to Diff 204022. Manikishan marked 4 inline comments as done. Manikishan added a comment. Changed Style name to OnePerLineBitFieldDecl Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63062/new/ https://reviews.llvm.org/D63062 Files:

[PATCH] D63134: [clang] improving diagnotics for invalid constexpr defaulted special membres

Tyker created this revision. Tyker added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. this patch improves diagnostic for invalid constexpr defaulted special members by adding notes explaining why the special member cannot be constexpr. example input:

[PATCH] D63062: [clang-format] Added New Style Rule: BitFieldDeclsOnSeparateLines

Manikishan updated this revision to Diff 204040. Manikishan marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63062/new/ https://reviews.llvm.org/D63062 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/ContinuationIndent

[PATCH] D60709: [ARM] Support inline assembler constraints for MVE.

simon_tatham updated this revision to Diff 204039. simon_tatham added a comment. Remastered patch to apply cleanly against current trunk. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60709/new/ https://reviews.llvm.org/D60709 Files: clang/lib/B

[PATCH] D63134: [clang] improving diagnotics for invalid constexpr defaulted special membres

Tyker updated this revision to Diff 204041. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63134/new/ https://reviews.llvm.org/D63134 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaDeclCXX.cpp Index: clang/lib/Sema/SemaDeclCXX.cpp =

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

Fznamznon added a comment. @aaron.ballman , please let me know if you have additional comments/suggestions. If not, could you please accept this revision? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60455/new/ https://reviews.llvm.org/D60455

[PATCH] D63062: [clang-format] Added New Style Rule: BitFieldDeclsOnSeparateLines

MyDeveloperDay added a comment. mark sure you mark off the comments as you consider them done. Comment at: lib/Format/FormatToken.h:519 +/// Returns whether the token is a Bit field, and checks whether +/// the Style is C / C++. this looks like it needs a cla

[PATCH] D61939: AArch64: add support for arm64_32 (ILP32) triple and -arch option.

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61939/new/ https://reviews.llvm.org/D61939 _

[PATCH] D62064: [ASTImporter] Fix unhandled cases in ASTImporterLookupTable

martong marked 3 inline comments as done. martong added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:4259 static const RecordDecl * getRecordDeclOfFriend(FriendDecl *FD) { QualType Ty = FD->getFriendType()->getType(); + if (auto *Inner = dyn_cast(Ty.g

[PATCH] D62064: [ASTImporter] Fix unhandled cases in ASTImporterLookupTable

martong updated this revision to Diff 204048. martong marked an inline comment as done. martong added a comment. - Simplify getRecordDeclOfFriend Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62064/new/ https://reviews.llvm.org/D62064 Files: cla

[PATCH] D63129: [clang-tidy] Fix invalid read on destruction

gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land. This fix works. The alternative would have been to wrap these variables into llvm::ManagedStatic, just like the problematic TrueMatcherInstance in ASTMatchersInternal.cpp. Repository:

r363062 - [ASTImporter] Fix unhandled cases in ASTImporterLookupTable

Author: martong Date: Tue Jun 11 06:35:25 2019 New Revision: 363062 URL: http://llvm.org/viewvc/llvm-project?rev=363062&view=rev Log: [ASTImporter] Fix unhandled cases in ASTImporterLookupTable Summary: In most cases the FriendDecl contains the declaration of the befriended class as a child node,

[PATCH] D62064: [ASTImporter] Fix unhandled cases in ASTImporterLookupTable

This revision was automatically updated to reflect the committed changes. Closed by commit rL363062: [ASTImporter] Fix unhandled cases in ASTImporterLookupTable (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D59253: [AIX][libcxx] AIX system headers need stdint.h and inttypes.h to be re-enterable when macro _STD_TYPES_T is defined

xingxue added a comment. Hi @mclow.lists, Do you have any further comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59253/new/ https://reviews.llvm.org/D59253 ___ cfe-commits mailing list cfe-com

[PATCH] D63091: [clangd] Add a capability to enable completions with fixes.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. NIT: I've been pushing towards giving clangd-specific extensions names that would absolutely never clash with anything that LSP proposes. In particular, the file status notificat

Re: [PATCH] D60455: [SYCL] Implement SYCL device code outlining

I'm out of the office until next week and won't be able to review it until then. If another trusted reviewer accepts, I can always do post commit review. ~Aaron On Tue, Jun 11, 2019, 2:43 PM Mariya Podchishchaeva via Phabricator < revi...@reviews.llvm.org> wrote: > Fznamznon added a comment. > >

[PATCH] D59744: Fix i386 ABI "__m64" type bug

wxiao3 updated this revision to Diff 204057. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59744/new/ https://reviews.llvm.org/D59744 Files: lib/CodeGen/TargetInfo.cpp test/CodeGen/x86_32-arguments-linux.c test/CodeGen/x86_32-m64.c Index: test/CodeGen/x86_32-m64.c

[PATCH] D59744: Fix i386 ABI "__m64" type bug

wxiao3 added a comment. Thanks for the suggestions! I have updated it. Ok now? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59744/new/ https://reviews.llvm.org/D59744 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

r363067 - [libclang] Allow skipping warnings from all included files

Author: nik Date: Tue Jun 11 07:14:24 2019 New Revision: 363067 URL: http://llvm.org/viewvc/llvm-project?rev=363067&view=rev Log: [libclang] Allow skipping warnings from all included files Depending on the included files and the used warning flags, e.g. - Weverything, a huge number of warnings ca

[PATCH] D48116: [libclang] Allow skipping warnings from all included files

This revision was automatically updated to reflect the committed changes. Closed by commit rL363067: [libclang] Allow skipping warnings from all included files (authored by nik, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https

[PATCH] D63139: [Diagnostics] Implement -Wswitch-unreachable

xbolva00 created this revision. xbolva00 added reviewers: aaron.ballman, rsmith, rjmccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. Detects unreachable statements in switches. GCC supports this warning too, on by default. Repository: rC Clang https://reviews.llv

[clang-tools-extra] r363068 - [clang-tidy] Fix invalid read on destruction

Author: nik Date: Tue Jun 11 07:19:09 2019 New Revision: 363068 URL: http://llvm.org/viewvc/llvm-project?rev=363068&view=rev Log: [clang-tidy] Fix invalid read on destruction ...in case the clang tidy plugin is linked into the clang binary. Valgrind's memcheck reports: 8949== Invalid read ==886

[PATCH] D63129: [clang-tidy] Fix invalid read on destruction

This revision was automatically updated to reflect the committed changes. Closed by commit rL363068: [clang-tidy] Fix invalid read on destruction (authored by nik, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTI

r363069 - Reapply r362994 & co "[analyzer][tests] Add normalize_plist to replace diff_plist"

Author: hubert.reinterpretcast Date: Tue Jun 11 07:21:32 2019 New Revision: 363069 URL: http://llvm.org/viewvc/llvm-project?rev=363069&view=rev Log: Reapply r362994 & co "[analyzer][tests] Add normalize_plist to replace diff_plist" Following r363007, which reverted r362998, r362996, and r362994,

r363070 - [NFC][PowerPC] Header-dependent test requires "native"

Author: hubert.reinterpretcast Date: Tue Jun 11 07:23:55 2019 New Revision: 363070 URL: http://llvm.org/viewvc/llvm-project?rev=363070&view=rev Log: [NFC][PowerPC] Header-dependent test requires "native" Two recently added tests mention complications for cross-compile, but they do not actually en

[PATCH] D62804: [clangd] Enable extraction of system includes from custom toolchains

kadircet updated this revision to Diff 204066. kadircet marked 27 inline comments as done. kadircet added a comment. Herald added a subscriber: mgorny. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62804/new/ https://reviews.llvm

[PATCH] D63140: [clangd] Return TextEdits from ClangdServer::applyTweak

ilya-biryukov created this revision. ilya-biryukov added a reviewer: kadircet. Herald added subscribers: arphaman, jkorous, MaskRay. Herald added a project: clang. Instead of tooling::Replacements. So that embedders do not need to store the contents of the file. This also aligns better ClangdServ

[PATCH] D63062: [clang-format] Added New Style Rule: OnePerLineBitFieldDecl

Manikishan updated this revision to Diff 204068. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63062/new/ https://reviews.llvm.org/D63062 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/ContinuationIndenter.cpp lib/Format/F

[PATCH] D62804: [clangd] Enable extraction of system includes from custom toolchains

kadircet added a comment. In D62804#1533710 , @ilya-biryukov wrote: > Could you give more context on what the custom toolchains are? > One feasible alternative is to move this detection to clang's driver (where > the rest of include path detection lives

RE: [PATCH] D60455: [SYCL] Implement SYCL device code outlining

Hi Aaron, I think Anastasia is on vacation. Could you recommend someone who can be “trusted reviewer” for this change, please? If no, we will wait for your/Anastasia review. Thanks, Alexey From: Aaron Ballman Sent: Tuesday, June 11, 2019 5:04 PM To: reviews+d60455+public+bc9d5bb3412ac...@revie

r363074 - Fix for r42230, MSVC test failure in DependencyDirectivesSourceMinimizerTest.cpp

Author: erichkeane Date: Tue Jun 11 07:58:26 2019 New Revision: 363074 URL: http://llvm.org/viewvc/llvm-project?rev=363074&view=rev Log: Fix for r42230, MSVC test failure in DependencyDirectivesSourceMinimizerTest.cpp r362459 introduced DependencyDirectivesSourceMinimizerTest.cpp, which hits an M

[PATCH] D62804: [clangd] Enable extraction of system includes from custom toolchains

ilya-biryukov added a comment. In D62804#1538155 , @kadircet wrote: > For example a gcc cross compiling to arm comes with its own system includes > and has some mechanisms to discover that implicitly, without requiring any > "-I" flags. > Hence when use

r363076 - Revert r344630 Disable code object version 3 for HIP toolchain.

Author: yaxunl Date: Tue Jun 11 08:05:11 2019 New Revision: 363076 URL: http://llvm.org/viewvc/llvm-project?rev=363076&view=rev Log: Revert r344630 Disable code object version 3 for HIP toolchain. Remove the workaround so that by default code object v3 is enabled. Modified: cfe/trunk/lib/Dri

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

serge-sans-paille updated this revision to Diff 204073. serge-sans-paille marked 3 inline comments as done. serge-sans-paille added a comment. @beanz : In addition to your suggested changes, I've renamed the cmake utility into `add_llvm_pass_plugin` to match other functions from `AddLLVM.cmake`

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

serge-sans-paille added inline comments. Comment at: polly/lib/Support/RegisterPasses.cpp:727 +extern "C" ::llvm::PassPluginLibraryInfo LLVM_ATTRIBUTE_WEAK +llvmGetPassPluginInfo() { + return getPassPluginInfo(); Meinersbur wrote: > [serious] Unfortunately, the

[PATCH] D63098: [CodeComplete] Allow completing enum values within case statements, and insert 'case' as a fixit.

ilya-biryukov added a comment. Notes from the offline discussion: - Sam: supporting multiple typed text chunks is hard, many clients that expect only one. Objective-C already does that, though, but in a way that does not break most targets. - Sam: supporting any other form of custom text for fi

[PATCH] D63143: [HIP] Enforce ODR rule for lambda in HIP/CUDA.

hliao created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D63143 Files: clang/include/clang/Basic/LangOptions.def clang/include/clang/Driver/CC1Options.td clang/include/clang/Sema/Sema.

Re: [PATCH] D60455: [SYCL] Implement SYCL device code outlining

Richard Smith, but his time is sometimes limited. John McCall would also be a great choice. Otherwise, I am happy to review when back next week. ~Aaron On Tue, Jun 11, 2019, 4:45 PM Bader, Alexey wrote: > Hi Aaron, > > > > I think Anastasia is on vacation. > > Could you recommend someone who ca

Re: r363009 - [Frontend] SetUpDiagnosticLog should handle unowned diagnostic consumer

Hmm, the logging was meant to exercise the creation of chained diagnostic consumer, so without it the test is kind of pointless. I'll undo your change, but will set the file to "-" which will print the log to STDERR and won't create new files. Does that sound reasonable? Cheers, Alex On Tue, 11 J

[PATCH] D59744: Fix i386 ABI "__m64" type bug

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Minor comments, then LGTM. Comment at: lib/CodeGen/TargetInfo.cpp:1094 +// FreeBSD) don't want to spend any effort dealing with the ramifications +// of ABI break

[PATCH] D62988: Add an attribute to allow fields of non-trivial types in C unions

rjmccall added a comment. In D62988#1537401 , @ahatanak wrote: > In D62988#1537082 , @rjmccall wrote: > > > Does this lead to C/C++ ABI mismatches? Should we just honor this in C++ > > as well by ignoring it when

[PATCH] D62831: [CodeGen][ObjC] Add attribute "arc_retain_agnostic" to ObjC globals that are retain-agnostic

rjmccall added a comment. Should `objc` be in the attribute somewhere to avoid any future awkwardness? I don't remember what we've called similar attributes. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62831/new/ https://reviews.llvm.org/D62831 ___

[PATCH] D63149: Added AST matcher for ignoring elidable constructors

jvikstrom created this revision. jvikstrom added reviewers: hokein, gribozavr. Herald added a project: clang. Herald added a subscriber: cfe-commits. Added AST matcher for ignoring elidable move constructors Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D63149 Files: clang/d

[PATCH] D63149: Added AST matcher for ignoring elidable constructors

gribozavr added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:6455 +/// Matches expressions that match InnerMatcher after any elidable constructor are stripped off. +/// 80 columns Comment at: clang/include/clang

r363088 - Remove redundant check for whether a DeclRefExpr that names a capture

Author: rsmith Date: Tue Jun 11 10:50:37 2019 New Revision: 363088 URL: http://llvm.org/viewvc/llvm-project?rev=363088&view=rev Log: Remove redundant check for whether a DeclRefExpr that names a capture constitutes an odr-use. We now track this accurately on the DeclRefExpr. Modified: cfe/tr

r363087 - For DR712: store on a MemberExpr whether it constitutes an odr-use.

Author: rsmith Date: Tue Jun 11 10:50:36 2019 New Revision: 363087 URL: http://llvm.org/viewvc/llvm-project?rev=363087&view=rev Log: For DR712: store on a MemberExpr whether it constitutes an odr-use. Modified: cfe/trunk/include/clang/AST/Expr.h cfe/trunk/include/clang/AST/Stmt.h cfe/

r363086 - For DR712: store on a DeclRefExpr whether it constitutes an odr-use.

Author: rsmith Date: Tue Jun 11 10:50:32 2019 New Revision: 363086 URL: http://llvm.org/viewvc/llvm-project?rev=363086&view=rev Log: For DR712: store on a DeclRefExpr whether it constitutes an odr-use. Begin restructuring to support the forms of non-odr-use reference permitted by DR712. Modified

[PATCH] D63153: [clang][NewPM] Fix broken -O0 test from the AlwaysInliner

leonardchan created this revision. leonardchan added reviewers: chandlerc, echristo, phosek, serge-sans-paille. leonardchan added a project: clang. Herald added subscribers: kristof.beyls, javed.absar. This contains the part of D62225 which prevents insertion of

[PATCH] D62738: [HIP] Support texture type

yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62738/new/ https://reviews.llvm.org/D62738 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D62926: [analyzer] ReturnVisitor: Bypass everything to see inlined calls

Charusso marked 2 inline comments as done. Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:842-849 + if (Optional CEE = Node->getLocationAs()) if (CEE->getCalleeContext()->getCallSite() == S) break; -

[PATCH] D62926: [analyzer] ReturnVisitor: Bypass everything to see inlined calls

Charusso updated this revision to Diff 204111. Charusso marked an inline comment as done. Charusso added a comment. - I have used `LocationContext::isParentOf()`which is not worked well, so I thought we are out of our context. - With that I made some misleading assumptions about our code. CHANG

[PATCH] D62978: [analyzer] trackExpressionValue(): Handle unknown values better

Charusso marked 8 inline comments as done. Charusso added inline comments. Comment at: clang/test/Analysis/diagnostics/deref-track-symbolic-region.c:14 int m = 0; - syz.x = foo(); // expected-note{{Value assigned to 'syz.x'}} Here. Commen

[PATCH] D62988: Add an attribute to allow fields of non-trivial types in C unions

rsmith added a comment. How do you write correct (non-leaking, non-double-freeing, non-releasing-invalid-pointers) code with this attribute? For example, suppose I have a `__strong` union member: does storing to it release the old value (which might be a different union member)? If so, how do y

[PATCH] D62738: [HIP] Support texture type

tra added a comment. Syntactically the patch looks OK to me, but I think the purpose and meaning of the builtin type should be documented in more details. Based on this patch alone it's not clear at all what it's supposed to be used for and how. Comment at: include/clang/Basi

[PATCH] D63155: [clang][NewPM] Fix broken profile test

leonardchan created this revision. leonardchan added reviewers: chandlerc, echristo, phosek, serge-sans-paille. leonardchan added a project: clang. leonardchan added a parent revision: D62225: [clang][NewPM] Fixing -O0 tests that are broken under new PM. This contains the part of D62225

[PATCH] D63156: [clang][NewPM] Add -fno-experimental-new-pass-manager to tests

leonardchan created this revision. leonardchan added reviewers: chandlerc, echristo, phosek, serge-sans-paille. leonardchan added a project: clang. Herald added subscribers: dexonsmith, steven_wu, javed.absar, mehdi_amini. As per the discussion on D58375 , we disab

[PATCH] D62115: fix a issue that clang is incompatible with gcc with -H option.

kimgr added a comment. I think the test needs a bit more work. It's essentially checking the same thing twice to exercise the Windows path separators. It looks like there's already a test for `-H` in `FrontEnd/print-header-includes.c`. That also demonstrates the use of `--check-prefix` to hand

[PATCH] D63157: C++ DR712 and others: handle non-odr-use resulting from an lvalue-to-rvalue conversion applied to a member access or similar not-quite-trivial lvalue expression.

rsmith created this revision. rsmith added a reviewer: rjmccall. Herald added a subscriber: jdoerfert. Herald added a project: clang. When a variable is named in a context where we can't directly emit a reference to it (because we don't know for sure that it's going to be defined, or it's from an

[PATCH] D63012: Use fully qualified name when printing S_CONSTANT records

akhuang updated this revision to Diff 204137. akhuang added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Change to not emit DIGlobalVariable for enums when they are defined in a class, which matches MSVC's behavior and gets around the issue of having to create

[PATCH] D63010: [OpenMP] Add task alloc function

gtbercea updated this revision to Diff 204138. gtbercea added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Add tests. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63010/new/ https://reviews.llvm.org/D63010 Files: lib/Cod

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

gtbercea updated this revision to Diff 204139. gtbercea added a comment. Herald added a project: OpenMP. Herald added a subscriber: openmp-commits. - Add temporary implementation. Repository: rOMP OpenMP CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63009/new/ https://reviews.llvm.or

[PATCH] D63010: [OpenMP] Add task alloc function

gtbercea updated this revision to Diff 204140. gtbercea added a comment. - Add temporary implementation. Repository: rOMP OpenMP CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63010/new/ https://reviews.llvm.org/D63010 Files: runtime/src/kmp.h runtime/src/kmp_tasking.cpp Index:

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

gtbercea updated this revision to Diff 204141. gtbercea added a comment. - Add tests. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63009/new/ https://reviews.llvm.org/D63009 Files: lib/CodeGen/CGOpenMPRuntime.cpp test/OpenMP/target_depend_codegen.cpp test

[PATCH] D63161: Devirtualize destructor of final class.

yamauchi created this revision. yamauchi added a reviewer: davidxl. Herald added a subscriber: Prazek. Herald added a project: clang. Take advantage of the final keyword to devirtualize destructor calls. Fix https://bugs.llvm.org/show_bug.cgi?id=21368 Repository: rC Clang https://reviews.llv

[PATCH] D63143: [HIP] Enforce ODR rule for lambda in HIP/CUDA.

hliao updated this revision to Diff 204152. hliao added a comment. Add the comment for the motivation of this patch as well as reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63143/new/ https://reviews.llvm.org/D63143 Files: clang/inclu

[PATCH] D63161: Devirtualize destructor of final class.

rsmith added inline comments. Comment at: lib/CodeGen/CGExprCXX.cpp:1867-1868 - if (Dtor->isVirtual()) { + if (Dtor->isVirtual() && + !(Dtor->hasAttr() || RD->hasAttr())) { CGF.CGM.getCXXABI().emitVirtualObjectDelete(CGF, DE, Ptr, ElementType, --

[PATCH] D62970: [clang-doc] De-duplicate comments and locations

DiegoAstiazaran updated this revision to Diff 204146. DiegoAstiazaran retitled this revision from "[clang-doc] De-duplicate comments" to "[clang-doc] De-duplicate comments and locations". DiegoAstiazaran edited the summary of this revision. DiegoAstiazaran added a comment. Herald added a subscribe

[PATCH] D63164: [HIP] Add option to force lambda nameing following ODR in HIP/CUDA.

hliao created this revision. hliao added reviewers: tra, yaxunl. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Clang follows its own scheme for lambdas which don't need to follow ODR rule. That scheme will assign an unqiue ID within the TU scope and won't be unique or

[PATCH] D62970: [clang-doc] De-duplicate comments and locations

DiegoAstiazaran marked 4 inline comments as done. DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/clang-doc/Representation.cpp:124 + for (auto &Comment : Other.Description) { +bool IsCommentUnique = std::find(Description.begin(), Description.end(), +

[PATCH] D63012: Use fully qualified name when printing S_CONSTANT records

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63012/new/ https://reviews.llvm.org/D63012 ___ cfe-c

[PATCH] D62738: [HIP] Support texture type

yaxunl updated this revision to Diff 204155. yaxunl marked 5 inline comments as done. yaxunl added a comment. Revised by Artem's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62738/new/ https://reviews.llvm.org/D62738 Files: include/clang/Basic/Attr.td include/clang/Basic

[PATCH] D62437: [clang-tidy] Splits fuchsia-default-arguments

DiegoAstiazaran updated this revision to Diff 204157. DiegoAstiazaran added a comment. Improve format of documentation in ReleaseNotes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62437/new/ https://reviews.llvm.org/D62437 Files: clang-tools-extra/clang-tidy/fuchsia/CMakeLists.txt

  1   2   >