[PATCH] D59481: [clangd] Count number of references while merging RefSlabs inside FileIndex

kadircet updated this revision to Diff 198770. kadircet marked 7 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59481/new/ https://reviews.llvm.org/D59481 Files: clang-tools-ex

[PATCH] D41911: [clangd] Include scanner that finds compile commands for headers.

sammccall marked 2 inline comments as done. sammccall added a comment. Context here, this patch is over a year old and predates the work on heuristically picking a compile command from another file in the CDB. I don't think anyone has concrete plans to revive this, the heuristics work well enou

[PATCH] D60827: [rename] Deduplicate symbol occurrences

kadircet requested changes to this revision. kadircet added a comment. This revision now requires changes to proceed. Note that the bug has been fixed with D61596 incidentally Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D61566: Fix for bug 41747: AST Printer doesn't print nested name specifier for out of scope record definitions

dyatkovskiy updated this revision to Diff 198771. dyatkovskiy added a comment. Patch updates per review remarks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61566/new/ https://reviews.llvm.org/D61566 Files: clang/lib/AST/DeclPrinter.cpp clang/test/AST/ast-print-record-decl.c Ind

[PATCH] D61717: Fix arm_neon.h to be clean under -fno-lax-vector-conversions.

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. Looks okay to me. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61717/new/ https://reviews.llvm.org/D61717 _

[PATCH] D59481: [clangd] Count number of references while merging RefSlabs inside FileIndex

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:101 FileToRefs.erase(Path); - else -FileToRefs[Path] = std::move(Refs); + else { +R

[PATCH] D61488: [OpenCL] Make global ctor init function a kernel

kpet accepted this revision. kpet added a comment. This revision is now accepted and ready to land. The comments could use a bit more polishing but nothing that justifies making another iteration IMHO. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61488/new/ https://reviews.llvm.

[PATCH] D61639: Add Triple::isSPIR() to simplify code

This revision was automatically updated to reflect the committed changes. Closed by commit rL360323: [SPIR] Simplified target checking. (authored by stulova, committed by ). Herald added a subscriber: kristina. Changed prior to commit: https://reviews.llvm.org/D61639?vs=198429&id=198780#toc Re

r360324 - [ARM] Fix the extensions implied by a cpu name

Author: dnsampaio Date: Thu May 9 03:24:36 2019 New Revision: 360324 URL: http://llvm.org/viewvc/llvm-project?rev=360324&view=rev Log: [ARM] Fix the extensions implied by a cpu name Summary: When using `clang -mcpu=CPUNAME+FEATURELIST`, the implied features defined by CPUNAME are not obtained, a

[PATCH] D61668: [ARM] Fix the extensions implied by a cpu name

This revision was automatically updated to reflect the committed changes. Closed by commit rL360324: [ARM] Fix the extensions implied by a cpu name (authored by dnsampaio, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE L

r360325 - [SPIR] Simplified target checking.

Author: stulova Date: Thu May 9 03:25:45 2019 New Revision: 360325 URL: http://llvm.org/viewvc/llvm-project?rev=360325&view=rev Log: [SPIR] Simplified target checking. Switched to Triple::isSPIR() helper to simplify code. Patch by kpet (Kevin Petit)! Differential revision: https://reviews.llvm

r360326 - Revert "[OPENMP]Fix PR41767: diagnose DSA for variables in clauses with default(none)."

Author: lebedevri Date: Thu May 9 03:47:45 2019 New Revision: 360326 URL: http://llvm.org/viewvc/llvm-project?rev=360326&view=rev Log: Revert "[OPENMP]Fix PR41767: diagnose DSA for variables in clauses with default(none)." This implementation isn't sound as per the standard. It erroneously diag

r360327 - Revert "[OPENMP]Fix PR41768: check DSA for globals with `default(none)` clauses."

Author: lebedevri Date: Thu May 9 03:48:13 2019 New Revision: 360327 URL: http://llvm.org/viewvc/llvm-project?rev=360327&view=rev Log: Revert "[OPENMP]Fix PR41768: check DSA for globals with `default(none)` clauses." This has introduced (exposed?) a crash in clang sema, that does not happen wit

[PATCH] D61722: Prototype of RecoveryExpr. Here, it's emitted when overload resolution fails.

sammccall created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D61722 Files: include/clang/AST/Expr.h include/clang/AST/RecursiveASTVisitor.h include/clang/AST/Stmt.h include/clang/Basic/StmtNodes.td

[PATCH] D61488: [OpenCL] Make global ctor init function a kernel

Anastasia added a comment. In D61488#1496154 , @kpet wrote: > The comments could use a bit more polishing but nothing that justifies making > another iteration IMHO. LGTM! Sure, feel free to put up a patch if you like. :) Thanks! CHANGES SINCE LAST A

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

RKSimon added inline comments. Comment at: cfe/trunk/lib/Parse/ParseDecl.cpp:3939 + "both or neither of isAlreadyConsumed and " + "RangeEnd needs to be set"); +DS.SetRangeEnd(isAlreadyConsumed ? RangeEnd

[PATCH] D50993: [clangd] Increase stack size of the new threads on macOS

ilya-biryukov added a comment. We should definitely land this. @Dmitry.Kozhevnikov, you don't have commit access, right? Should we land these two revisions for you? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50993/new/ https://reviews.llvm.org/

[PATCH] D61722: Prototype of RecoveryExpr. Here, it's emitted when overload resolution fails.

sammccall updated this revision to Diff 198786. sammccall added a comment. Fix serialization maybe. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61722/new/ https://reviews.llvm.org/D61722 Files: include/clang/AST/Expr.h include/clang/AST/RecursiveASTVisitor

r360329 - [FIX] Change test to read file instead

Author: dnsampaio Date: Thu May 9 04:23:00 2019 New Revision: 360329 URL: http://llvm.org/viewvc/llvm-project?rev=360329&view=rev Log: [FIX] Change test to read file instead This should fix the test file failing in windows by reading the file it self instead of stdin, from 543913c3b41f Modified

[PATCH] D61724: [clangd] Use AsyncTaskRunner in BackgroundIndex instead of std::thread

ilya-biryukov created this revision. ilya-biryukov added a reviewer: kadircet. Herald added subscribers: jfb, arphaman, jkorous, MaskRay. Herald added a project: clang. To unify the way we create threads in clangd. This should simplify landing D50993 . Repository

[PATCH] D50993: [clangd] Increase stack size of the new threads on macOS

ilya-biryukov added a comment. D61724 refactors `BackgroundIndexer` to use `AsyncTaskRunner`. So by the time this lands, it should cover all places where threads are created in clangd. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://

[PATCH] D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment

ztamas updated this revision to Diff 198787. ztamas added a comment. Changed "might not" to "does not" in the warning message. Added the requested test case with the swapped template arguments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60507/new

[PATCH] D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment

ztamas updated this revision to Diff 198789. ztamas added a comment. copy operator -> copy assignment operator Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60507/new/ https://reviews.llvm.org/D60507 Files: clang-tools-extra/clang-tidy/bugprone/

[PATCH] D61724: [clangd] Use AsyncTaskRunner in BackgroundIndex instead of std::thread

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang-tools-extra/clangd/index/Background.cpp:152 + for (unsigned I = 1; I <= ThreadPoolSize; ++I) { +ThreadPool.runAsync("background-worker-" + llv

[PATCH] D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment

ztamas added a comment. > I definitely want to see the diagnostic text changed away from "might be" -- > that's too noncommittal for my tastes. I'd also like to see the additional > test case (I suspect it will just work out of the box, but if it doesn't, it > would be good to know about it). T

[PATCH] D53072: [clang-format] Create a new tool for IDEs based on clang-format

yvvan added a comment. @ilya-biryukov I don't really care how it's used from the tool side. I'm also fine to have a new option in clang-format itself. That's why this review is here - to ask for opinions. It's easy to remove that "ide" part from this patch and just add an option for clang-forma

r360330 - [OpenCL] Switched CXX mode to be derived from C++17

Author: stulova Date: Thu May 9 04:55:24 2019 New Revision: 360330 URL: http://llvm.org/viewvc/llvm-project?rev=360330&view=rev Log: [OpenCL] Switched CXX mode to be derived from C++17 Differential revision: https://reviews.llvm.org/D61506 Modified: cfe/trunk/include/clang/Frontend/LangSta

[PATCH] D61724: [clangd] Use AsyncTaskRunner in BackgroundIndex instead of std::thread

ilya-biryukov updated this revision to Diff 198791. ilya-biryukov marked 4 inline comments as done. ilya-biryukov added a comment. - Count from 0. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61724/new/ https://reviews.llvm.org/D61724 Files: cl

[PATCH] D61724: [clangd] Use AsyncTaskRunner in BackgroundIndex instead of std::thread

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/index/Background.cpp:152 + for (unsigned I = 1; I <= ThreadPoolSize; ++I) { +ThreadPool.runAsync("background-worker-" + llvm::Twine(I), +[this] { run(); }); kad

[PATCH] D61506: [OpenCL] Switch to C++17

This revision was automatically updated to reflect the committed changes. Closed by commit rL360330: [OpenCL] Switched CXX mode to be derived from C++17 (authored by stulova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://

[PATCH] D61724: [clangd] Use AsyncTaskRunner in BackgroundIndex instead of std::thread

This revision was automatically updated to reflect the committed changes. Closed by commit rL360332: [clangd] Use AsyncTaskRunner in BackgroundIndex instead of std::thread (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D61566: Fix for bug 41747: AST Printer doesn't print nested name specifier for out of scope record definitions

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61566/new/ https://reviews.llvm.org/D61566 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[clang-tools-extra] r360332 - [clangd] Use AsyncTaskRunner in BackgroundIndex instead of std::thread

Author: ibiryukov Date: Thu May 9 05:04:07 2019 New Revision: 360332 URL: http://llvm.org/viewvc/llvm-project?rev=360332&view=rev Log: [clangd] Use AsyncTaskRunner in BackgroundIndex instead of std::thread Summary: To unify the way we create threads in clangd. This should simplify landing D50993

[PATCH] D53072: [clang-format] Create a new tool for IDEs based on clang-format

sammccall added a comment. My feedback would be: - I definitely think more control over preserving line breaks would be useful. Actually preserving *blank* lines is an important property. If you see D60605 , there are a lot of cases where clang-format wants to

r360333 - Fix gcc compilation warning in an assert [NFC]

Author: uabelho Date: Thu May 9 05:11:57 2019 New Revision: 360333 URL: http://llvm.org/viewvc/llvm-project?rev=360333&view=rev Log: Fix gcc compilation warning in an assert [NFC] Without this, gcc (7.4) complains with ../tools/clang/lib/Parse/ParseDecl.cpp:3937:63: error: suggest parentheses

[clang-tools-extra] r360334 - Fix gcc compilation warning in test case [NFC]

Author: uabelho Date: Thu May 9 05:12:35 2019 New Revision: 360334 URL: http://llvm.org/viewvc/llvm-project?rev=360334&view=rev Log: Fix gcc compilation warning in test case [NFC] Without this, gcc (7.4) complains with ../tools/clang/tools/extra/clangd/unittests/PrintASTTests.cpp:99:28: error:

[clang-tools-extra] r360336 - [clangd] Fix a TSAN warning in TUSchedulerTests

Author: ibiryukov Date: Thu May 9 05:21:28 2019 New Revision: 360336 URL: http://llvm.org/viewvc/llvm-project?rev=360336&view=rev Log: [clangd] Fix a TSAN warning in TUSchedulerTests Modified: clang-tools-extra/trunk/clangd/unittests/TUSchedulerTests.cpp Modified: clang-tools-extra/trunk/cl

[PATCH] D60456: [RISCV][WIP/RFC] Hard float ABI support

asb updated this revision to Diff 198797. asb marked 3 inline comments as done. asb added a comment. Update: - Expanded and improved tests - Set ABI defines - Remove errant TODO - Use alignTo Still to do: - Review and test bitfield handling (which is likely incomplete) CHANGES SINCE LAST ACTI

[PATCH] D53866: [Preamble] Stop circular inclusion of main file when building preamble

nik marked an inline comment as done. nik added inline comments. Comment at: lib/Basic/SourceManager.cpp:1594 SourceFileName = llvm::sys::path::filename(SourceFile->getName()); -if (*SourceFileName == llvm::sys::path::filename(MainFile->getName())) { +if

[PATCH] D53866: [Preamble] Stop circular inclusion of main file when building preamble

nik updated this revision to Diff 198799. nik added a comment. Moved the MainFile / MainContentCache->OrigEntry check a bit further up, for consistency with the same test further down in SourceManager::translateFile(). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D24892: [clang-tidy] Add option "LiteralInitializers" to cppcoreguidelines-pro-type-member-init

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp:361 + case BuiltinType::Float: +return " = 0.0F"; + case BuiltinType::Double: We may not have

[PATCH] D60456: [RISCV][WIP/RFC] Hard float ABI support

asb added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:9223 + + bool IsInt = Ty->isIntegralOrEnumerationType(); + bool IsFloat = Ty->isRealFloatingType(); rjmccall wrote: > Should this include pointers? Pointers are often interchangeably with > int

Re: r360073 - [OPENMP]Fix PR41767: diagnose DSA for variables in clauses with

... and i had to revert this & the other commit. Sorry :( This implementation isn't sound as per the standard. It erroneously diagnoses e.g. the following case: ``` $ cat test.cpp void f(int n) { #pragma omp parallel default(none) if(n) ; } ``` ``` $ ./bin/clang -fopenmp test.cpp test.cpp:2:40

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

aaron.ballman added a comment. In D56160#1495847 , @bernhardmgruber wrote: > @aaron.ballman and @JonasToth: Thank you for the patience and all the > feedback! It means a great deal to me to have a patch accepted here! You're very welcome! Do you need o

[PATCH] D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60507/new/ https://reviews.llvm.org/D60507

[PATCH] D60274: [ELF] Implement Dependent Libraries Feature

ruiu accepted this revision. ruiu added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60274/new/ https://reviews.llvm.org/D60274 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

bernhardmgruber marked 2 inline comments as done. bernhardmgruber added a comment. @aaron.ballman I do not have commit privileges and I would be very thankful, if you could commit this patch for me! Thank you! Comment at: clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:203

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:203 + if (ContainsQualifiers + ContainsSpecifiers + ContainsSomethingElse > 1) +return {}; + bernhardmgruber wrote: > aaron.ballman wrote: > > This should re

[PATCH] D53866: [Preamble] Stop circular inclusion of main file when building preamble

ilya-biryukov added inline comments. Comment at: lib/Basic/SourceManager.cpp:1594 SourceFileName = llvm::sys::path::filename(SourceFile->getName()); -if (*SourceFileName == llvm::sys::path::filename(MainFile->getName())) { +if (MainFile && *SourceFileNam

[PATCH] D61497: [clangd] Introduce a structured hover response

sammccall added a comment. comments on interface again, will take another pass at implementation Comment at: clang-tools-extra/clangd/XRefs.h:65 + /// Fully qualiffied name for the scope containing the Sym. + std::string Scope; + std::string ParentScope; kad

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

nik updated this revision to Diff 198809. nik added a comment. Addressed inline comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41005/new/ https://reviews.llvm.org/D41005 Files: include/clang/Frontend/ASTUnit.h lib/Frontend/ASTUnit.cpp lib/Frontend

[PATCH] D61729: [docs] Fix example for Allman brace breaking style

gerriet created this revision. gerriet added reviewers: jkorous, llvm-commits. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Commit 3fd4a968ad80 by @jkorous was wrongfully rolled back. Openi

[PATCH] D61335: [LibTooling] Add support to Transformer for composing rules as an ordered choice.

ymandel updated this revision to Diff 198811. ymandel added a comment. Folded CompositeRewriteRule into RewriteRule and added examples to comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61335/new/ https://reviews.llvm.org/D61335 Files: c

r360342 - [OpenCL] Make global ctor init function a kernel

Author: stulova Date: Thu May 9 06:55:44 2019 New Revision: 360342 URL: http://llvm.org/viewvc/llvm-project?rev=360342&view=rev Log: [OpenCL] Make global ctor init function a kernel We need to be able to enqueue internal function that initializes global constructors on the host side. Therefore i

[PATCH] D61488: [OpenCL] Make global ctor init function a kernel

This revision was automatically updated to reflect the committed changes. Closed by commit rL360342: [OpenCL] Make global ctor init function a kernel (authored by stulova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

Tyker marked an inline comment as done. Tyker added inline comments. Comment at: cfe/trunk/lib/Parse/ParseDecl.cpp:3939 + "both or neither of isAlreadyConsumed and " + "RangeEnd needs to be set"); +DS.Se

[PATCH] D61335: [LibTooling] Add support to Transformer for composing rules as an ordered choice.

ymandel added a comment. In D61335#1495324 , @ilya-biryukov wrote: > Sorry for the delay. > I personally like the `RewriteRule::Action` best. Allows to use a rather > common term, while still avoiding any possible confusion. I tried going with `Rewrit

[PATCH] D53866: [Preamble] Stop circular inclusion of main file when building preamble

nik marked an inline comment as done. nik added inline comments. Comment at: lib/Basic/SourceManager.cpp:1594 SourceFileName = llvm::sys::path::filename(SourceFile->getName()); -if (*SourceFileName == llvm::sys::path::filename(MainFile->getName())) { +if

[clang-tools-extra] r360344 - [clangd] Count number of references while merging RefSlabs inside FileIndex

Author: kadircet Date: Thu May 9 07:22:07 2019 New Revision: 360344 URL: http://llvm.org/viewvc/llvm-project?rev=360344&view=rev Log: [clangd] Count number of references while merging RefSlabs inside FileIndex Summary: For counting number of references clangd was relying on merging every duplica

[PATCH] D59481: [clangd] Count number of references while merging RefSlabs inside FileIndex

kadircet updated this revision to Diff 198816. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59481/new/ https://reviews.llvm.org/D59481 Files: clang-tools-ex

[PATCH] D59481: [clangd] Count number of references while merging RefSlabs inside FileIndex

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE360344: [clangd] Count number of references while merging RefSlabs inside FileIndex (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D59481?vs=198816&id=198818#

[PATCH] D61522: Added an assertion to constant evaluation enty points that prohibits dependent expressions

gribozavr marked an inline comment as done. gribozavr added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:6369 // very difficult. Ideally, we should handle them more gracefully. -if (!EIA->getCond()->EvaluateWithSubstitution( +if (EIA->getCond()->isVal

[PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

martong marked 8 inline comments as done. martong added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:5039 + if (!ToOrErr) +// FIXME: return the error? +consumeError(ToOrErr.takeError()); aprantl wrote: > We don't typ

[PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

martong updated this revision to Diff 198822. martong marked 3 inline comments as done. martong added a comment. - Remove FIXME and return the error - Use early return where possible and remove redundant else Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

martong updated this revision to Diff 198824. martong added a comment. - Remove remaining FIXMEs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61438/new/ https://reviews.llvm.org/D61438 Files: clang/include/clang/AST/ASTImporter.h clang/lib/AS

[clang-tools-extra] r360345 - Add the modernize-use-trailing-return check to rewrite function signatures to use trailing return types.

Author: aaronballman Date: Thu May 9 07:48:17 2019 New Revision: 360345 URL: http://llvm.org/viewvc/llvm-project?rev=360345&view=rev Log: Add the modernize-use-trailing-return check to rewrite function signatures to use trailing return types. Patch by Bernhard Manfred Gruber. Added: clang-

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

aaron.ballman added a comment. In D56160#1496391 , @bernhardmgruber wrote: > @aaron.ballman I do not have commit privileges and I would be very thankful, > if you could commit this patch for me! Thank you! I've commit for you in r360345, thank you for

[PATCH] D61734: [clangd] Bump index version and get rid of wrong assertion

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay. Herald added a project: clang. After rL360344 , BackgroundIndex expects symbols with zero refcounts. Therefore existing i

[clang-tools-extra] r360346 - Fixing a link in the release notes to appease the Sphinx bot.

Author: aaronballman Date: Thu May 9 08:00:38 2019 New Revision: 360346 URL: http://llvm.org/viewvc/llvm-project?rev=360346&view=rev Log: Fixing a link in the release notes to appease the Sphinx bot. Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified: clang-tools-extra/trunk/d

[clang-tools-extra] r360348 - Revert r360345 and r360346, as they are not passing the testbots.

Author: aaronballman Date: Thu May 9 08:06:41 2019 New Revision: 360348 URL: http://llvm.org/viewvc/llvm-project?rev=360348&view=rev Log: Revert r360345 and r360346, as they are not passing the testbots. http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/48063/st

[PATCH] D61734: [clangd] Bump index version and get rid of wrong assertion

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61734/new/ https://reviews.llvm.org/D61734 _

[clang-tools-extra] r360349 - [clangd] Bump index version and get rid of wrong assertion

Author: kadircet Date: Thu May 9 08:07:53 2019 New Revision: 360349 URL: http://llvm.org/viewvc/llvm-project?rev=360349&view=rev Log: [clangd] Bump index version and get rid of wrong assertion Summary: After rL360344, BackgroundIndex expects symbols with zero refcounts. Therefore existing index

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

aaron.ballman reopened this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D56160#1496594 , @aaron.ballman wrote: > In D56160#1496391 , @bernhardmgruber > wrote: > > >

[PATCH] D61497: [clangd] Introduce a structured hover response

sammccall added a comment. Main comment is that I think the code is doing too much work to exactly reproduce the current output, and include as much information as possible. Minimizing the diff is good all else equal, but one of the goals here is to have richer hovercards that are more consisten

[PATCH] D53866: [Preamble] Stop circular inclusion of main file when building preamble

ilya-biryukov accepted this revision. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. See the nit about naming of an error, though Comment at: include/clang/Basic/DiagnosticLexKinds.td:429

[PATCH] D50993: [clangd] Increase stack size of the new threads on macOS

Dmitry.Kozhevnikov added a comment. In D50993#1496250 , @ilya-biryukov wrote: > We should definitely land this. > > @Dmitry.Kozhevnikov, you don't have commit access, right? Should we land > these two revisions for you? The depending review was never d

[PATCH] D50993: [clangd] Increase stack size of the new threads on macOS

sammccall added a comment. In D50993#1496638 , @Dmitry.Kozhevnikov wrote: > In D50993#1496250 , @ilya-biryukov > wrote: > > > We should definitely land this. > > > > @Dmitry.Kozhevnikov, you don't have commit acce

[PATCH] D60974: Clang IFSO driver action.

plotfi marked 2 inline comments as done. plotfi added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3590 +Twine("-interface-stubs-version=") + +Args.getLastArgValue(options::OPT_ifso_version_EQ))); + } compnerd wr

[PATCH] D61734: [clangd] Bump index version and get rid of wrong assertion

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE360349: [clangd] Bump index version and get rid of wrong assertion (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D61734?vs=198825&id=198828#toc Repository:

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

micah-s added a comment. @djasper @klimek @krasimir @sammccall @enyquist Can I trouble you for an update? In D28462#1492600 , @jkorous wrote: > Hi @VelocityRa, just FYI - it's considered fine to ping your reviewers once > per week here if you've addres

[PATCH] D59885: [Lex] Allow to consume tokens while preprocessing

ilya-biryukov added a comment. Here are some numbers from running `clang -cc1 -Eonly` on `SemaExpr.cpp`, it includes a whole ton of headers, including a rather large `TreeTransform.h`. This was run on my machine, so keep in mind it's rather noisy. Minimal times should be somewhat representative

[PATCH] D61739: check_clang_tidy.py now passes `-format-style=none` to clang_tidy

gribozavr created this revision. gribozavr added a reviewer: alexfh. Herald added a project: clang. Herald added a subscriber: cfe-commits. If the test does not specify a formatting style, force "none"; otherwise autodetection logic can discover a ".clang-tidy" file that is not related to the test

[PATCH] D61739: check_clang_tidy.py now passes `-format-style=none` to clang_tidy

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61739/new/ https://reviews.llvm.org/D61739

[PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

aprantl added inline comments. Comment at: clang/include/clang/AST/ASTImporter.h:203 /// context, or the import error. -llvm::Expected Import_New(TypeSourceInfo *FromTSI); -// FIXME: Remove this version. -TypeSourceInfo *Import(TypeSourceInfo *FromTSI); +llvm

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

ilya-biryukov updated this revision to Diff 198857. ilya-biryukov added a comment. - Move the constuction logic to a separate class, split into multiple methods. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59887/new/ https://reviews.llvm.org/D598

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

ilya-biryukov added inline comments. Comment at: clang/lib/Tooling/Syntax/Tokens.cpp:130 + OS << llvm::formatv( + "['{0}'_{1}, '{2}'_{3}) => ['{4}'_{5}, '{6}'_{7})\n", + PrintToken(File.SpelledTokens[M.BeginSpelled]), M.BeginSpelled, il

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

ilya-biryukov updated this revision to Diff 198862. ilya-biryukov marked 6 inline comments as done. ilya-biryukov added a comment. - Move filling the gaps at the end of files to a separate function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59887

[PATCH] D61742: [Driver][Windows] Add dependent lib argument for profile instr generate

russell.gallop created this revision. russell.gallop added reviewers: rnk, bogner. russell.gallop added a project: clang. This is needed so lld-link can find clang_rt.profile when self hosting on Windows with PGO. Trying to self host on Windows with PGO runs into undefined symbols as lld-link d

[PATCH] D61689: Change -gz and -Wa,--compress-debug-sections to use gABI compression (SHF_COMPRESSED)

compnerd added a comment. I don't really have a problem with this change. But, if we make this change, please include a change to the release notes *now*. This is something which may catch users off guard and confuse them and require them to go looking for what happened. As an aside, I think

[PATCH] D61743: New clang option -MD-filter=prefix to filter files from make dependencies

mibintc created this revision. mibintc added reviewers: clang-c, fedor.sergeev. mibintc added a project: clang. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Intel is developing an offload compiler based on clang (that will eventually be contributed to open source). In th

[clang-tools-extra] r360358 - check_clang_tidy.py now passes `-format-style=none` to clang_tidy

Author: gribozavr Date: Thu May 9 10:08:10 2019 New Revision: 360358 URL: http://llvm.org/viewvc/llvm-project?rev=360358&view=rev Log: check_clang_tidy.py now passes `-format-style=none` to clang_tidy Summary: If the test does not specify a formatting style, force "none"; otherwise autodetection

[PATCH] D61689: Change -gz and -Wa,--compress-debug-sections to use gABI compression (SHF_COMPRESSED)

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. (Accepting with the condition that you will update the release notes before committing) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61689/new/ https://r

[PATCH] D61739: check_clang_tidy.py now passes `-format-style=none` to clang_tidy

This revision was automatically updated to reflect the committed changes. Closed by commit rL360358: check_clang_tidy.py now passes `-format-style=none` to clang_tidy (authored by gribozavr, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to co

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

ilya-biryukov updated this revision to Diff 198867. ilya-biryukov marked 5 inline comments as done. ilya-biryukov added a comment. - Check invariants on FileRange construction, unify access to all fields Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

ilya-biryukov marked 2 inline comments as done. ilya-biryukov added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tokens.h:62 + SourceLocation location() const { return Location; } + SourceLocation endLocation() const { +return Location.getLocWithOffset(Le

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

ilya-biryukov marked 3 inline comments as done. ilya-biryukov added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tokens.h:78 + /// For debugging purposes. + std::string str() const; + sammccall wrote: > ilya-biryukov wrote: > > sammccall wrot

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

ilya-biryukov updated this revision to Diff 198868. ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. - Use bsearch instead of upper_bound Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59887/new/ https://reviews.llvm.or

[PATCH] D50993: [clangd] Increase stack size of the new threads on macOS

ilya-biryukov added a comment. I'd still put it into LLVM to avoid platform-specific code in clangd. Maybe `std::abort()` in the added `...Async` function if threads are disabled? It's a bit unusual, but would allow keeping this function where it belongs. Repository: rCTE Clang Tools Extra

r360359 - [CodeGen][ObjC] Remove the leading `l_` from ObjC symbols and make

Author: ahatanak Date: Thu May 9 10:43:52 2019 New Revision: 360359 URL: http://llvm.org/viewvc/llvm-project?rev=360359&view=rev Log: [CodeGen][ObjC] Remove the leading `l_` from ObjC symbols and make private symbols in the __DATA segment internal. This prevents the linker from removing the symb

[PATCH] D61454: [CodeGen][ObjC] Remove the leading 'l_' from ObjC symbols and make private symbols in the __DATA segment internal.

This revision was automatically updated to reflect the committed changes. Closed by commit rC360359: [CodeGen][ObjC] Remove the leading `l_` from ObjC symbols and make (authored by ahatanak, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61454/new/

  1   2   >