[PATCH] D24892: [clang-tidy] Add option "LiteralInitializers" to cppcoreguidelines-pro-type-member-init

mgehre updated this revision to Diff 198714. mgehre added a comment. Herald added a project: clang. Implement review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D24892/new/ https://reviews.llvm.org/D24892 Files: clang-tools-extra/clang

[PATCH] D61667: Assume `__cxa_allocate_exception` returns an under-aligned memory on Darwin if the version of libc++abi isn't new enough to include the fix in r319123

ahatanak marked an inline comment as done. ahatanak added inline comments. Comment at: include/clang/Basic/AlignedExceptionObject.h:31 + case llvm::Triple::MacOSX: // Earliest supporting version is 10.14. +return llvm::VersionTuple(10U, 14U); + case llvm::Triple::IOS: -

[PATCH] D61667: Assume `__cxa_allocate_exception` returns an under-aligned memory on Darwin if the version of libc++abi isn't new enough to include the fix in r319123

ahatanak updated this revision to Diff 198716. ahatanak marked 3 inline comments as done. ahatanak edited the summary of this revision. ahatanak added a comment. Move the code that was in `AlignedExceptionObject.h` to `getExnObjectAlignment` and remove the header. Repository: rC Clang CHANGE

[PATCH] D60910: [WIP] Dumping the AST to JSON

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. If you're happy with these two conditions, then I have no concerns with this moving forward: - There is no implied stability for the content or format of the dump between major releases, othe

[PATCH] D61697: [lit] Disable test on darwin when building shared libs.

hintonda created this revision. hintonda added a reviewer: zturner. Herald added subscribers: llvm-commits, delcypher. Herald added projects: clang, LLVM. This test fails to link shared libraries because tries to run a copied version of clang-check to see if the mock version of libcxx in the same

[PATCH] D61697: [lit] Disable test on darwin when building shared libs.

hintonda added a comment. @zturner, I only disabled this on Darwin because that's all I can test on right now. Please let me know if there's a better way to do this or if it should fire on different platforms. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D61700: [clang-tidy] readability-redundant-declaration: fix false positive with C "extern inline"

mgehre created this revision. mgehre added reviewers: alexfh, danielmarjamaki. Herald added a subscriber: xazax.hun. Herald added a project: clang. readability-redundant-declaration was diagnosing a redundant declaration on "extern inline void f();", which is needed in C code to force an external

[PATCH] D61667: Assume `__cxa_allocate_exception` returns an under-aligned memory on Darwin if the version of libc++abi isn't new enough to include the fix in r319123

rjmccall added inline comments. Comment at: include/clang/Basic/DiagnosticGroups.td:411 def OpenCLUnsupportedRGBA: DiagGroup<"opencl-unsupported-rgba">; +def UnderalignedExcpObj : DiagGroup<"underaligned-exception-object">; def DeprecatedObjCIsaUsage : DiagGroup<"deprecated-obj

[PATCH] D61646: Include corecrt.h/vcruntime.h to improve MS compatibility

phosek added a comment. This change broke our build which is using Clang and the `x86_64-windows-msvc` target to cross-compile our EFI bootloader. Now the compilation fails

r360291 - Revert Include corecrt.h in stddef.h and vcruntime.h in stdarg.h to improve MS compatibility.

Author: rnk Date: Wed May 8 15:01:20 2019 New Revision: 360291 URL: http://llvm.org/viewvc/llvm-project?rev=360291&view=rev Log: Revert Include corecrt.h in stddef.h and vcruntime.h in stdarg.h to improve MS compatibility. This reverts r360271 (git commit a0933bd8ec1515167ea653f7ee788b8bbde27d5

[PATCH] D61646: Include corecrt.h/vcruntime.h to improve MS compatibility

rnk added a comment. In D61646#1495778 , @phosek wrote: > This change broke our build which is using Clang and the > `x86_64-windows-msvc` target to cross-compile our EFI bootloader. Now the > compilation fails >

r360297 - Try to restore some clang test headers lost in r360291

Author: rnk Date: Wed May 8 15:30:46 2019 New Revision: 360297 URL: http://llvm.org/viewvc/llvm-project?rev=360297&view=rev Log: Try to restore some clang test headers lost in r360291 I'm not sure why 'git llvm revert' removed them. Added: cfe/trunk/test/Headers/Inputs/ cfe/trunk/test/H

[PATCH] D50993: [clangd] Increase stack size of the new threads on macOS

umanwizard added a comment. By the way, index/Background.{cpp,h} also need to be changed to use the new API. I made that change locally and clangd with full project indexing is now working for me on macOS. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

bernhardmgruber added a comment. @aaron.ballman and @JonasToth: Thank you for the patience and all the feedback! It means a great deal to me to have a patch accepted here! Comment at: clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:95-98 +if (!S->getQualifierLoc() && N

[PATCH] D61522: Added an assertion to constant evaluation enty points that prohibits dependent expressions

rsmith added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:6369 // very difficult. Ideally, we should handle them more gracefully. -if (!EIA->getCond()->EvaluateWithSubstitution( +if (EIA->getCond()->isValueDependent() || +!EIA->getCond()->Eval

[PATCH] D61707: [Preprocessor] Fix crash emitting note with framework location for "file not found" error.

vsapsai created this revision. vsapsai added reviewers: arphaman, erik.pilkington, jkorous. Herald added a subscriber: dexonsmith. A filename can be remapped with a header map to point to a framework header and we can find the corresponding framework without the header. But if the original filenam

[PATCH] D61709: [NewPM] Port HWASan

leonardchan created this revision. leonardchan added reviewers: philip.pfaffe, fedor.sergeev, chandlerc, phosek. leonardchan added projects: LLVM, clang. Herald added subscribers: hiraditya, srhines. Port hardware assisted address sanitizer to new PM following the same guidelines as msan and tsan

r360302 - When typo-correcting a function name, consider correcting to a type name

Author: rsmith Date: Wed May 8 17:57:24 2019 New Revision: 360302 URL: http://llvm.org/viewvc/llvm-project?rev=360302&view=rev Log: When typo-correcting a function name, consider correcting to a type name for a function-style cast. Modified: cfe/trunk/lib/Sema/SemaExpr.cpp cfe/trunk/lib/

[PATCH] D41911: [clangd] Include scanner that finds compile commands for headers.

nridge added a comment. Herald added subscribers: jfb, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Are there are plans to move forward with this sort of an include scanning approach? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.

r360310 - [cxx_status] Mark support for std::is_constant_evaluated as done.

Author: rsmith Date: Wed May 8 20:49:47 2019 New Revision: 360310 URL: http://llvm.org/viewvc/llvm-project?rev=360310&view=rev Log: [cxx_status] Mark support for std::is_constant_evaluated as done. Eric implemented this in r359067. Modified: cfe/trunk/www/cxx_status.html Modified: cfe/trun

Re: r359067 - [Builtins] Implement __builtin_is_constant_evaluated for use in C++2a

I went ahead and did this in r360310. On Thu, 25 Apr 2019 at 14:31, Richard Smith wrote: > > On Wed, 24 Apr 2019 at 19:28, Eric Fiselier via cfe-commits > wrote: > > Do I just edit the HTML file directly? > > Or is it generated by something? > > Just edit the HTML file directly. > > > On Wed, Ap

[PATCH] D61716: Expose AtomicType

slowhog created this revision. slowhog added reviewers: yvvan, jbcoe. Herald added subscribers: cfe-commits, jfb, arphaman. Herald added a project: clang. Expose atomic type through the C API. Repository: rC Clang https://reviews.llvm.org/D61716 Files: clang/include/clang-c/Index.h clang

[PATCH] D41911: [clangd] Include scanner that finds compile commands for headers.

klimek added inline comments. Comment at: clangd/IncludeScanner.cpp:75 + bool WasEmpty = Queue.empty(); + for (const auto &Cmd : Cmds) { +QueueEntry E(Cmd, VFS); Usually I'd try to not lock a loop, as a large number of compile commands now blocks other thr

Re: r359067 - [Builtins] Implement __builtin_is_constant_evaluated for use in C++2a

Sorry, I should have been on top of this. /Eric On Wed., May 8, 2019, 11:47 p.m. Richard Smith, wrote: > I went ahead and did this in r360310. > > On Thu, 25 Apr 2019 at 14:31, Richard Smith wrote: > > > > On Wed, 24 Apr 2019 at 19:28, Eric Fiselier via cfe-commits > > wrote: > > > Do I just

r360313 - [NewPM] Setup Passes for KASan and KMSan

Author: phosek Date: Wed May 8 23:09:35 2019 New Revision: 360313 URL: http://llvm.org/viewvc/llvm-project?rev=360313&view=rev Log: [NewPM] Setup Passes for KASan and KMSan While ASan and MSan passes were already ported to new PM, the kernel variants weren't setup in the pipeline which makes the

[PATCH] D61664: [NewPM] Setup Passes for KASan and KMSan

This revision was automatically updated to reflect the committed changes. Closed by commit rC360313: [NewPM] Setup Passes for KASan and KMSan (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D61664?vs=198580&id=198760#toc Repository: rC Clang CHANGES SI

[PATCH] D61717: Fix arm_neon.h to be clean under -fno-lax-vector-conversions.

rsmith created this revision. rsmith added reviewers: t.p.northover, javed.absar, SjoerdMeijer, pbarrio. Herald added a subscriber: kristof.beyls. Herald added a project: clang. arm_neon.h produces a large number of errors under -fno-lax-vector-conversions, which disables some deeply dangerous imp

[PATCH] D61717: Fix arm_neon.h to be clean under -fno-lax-vector-conversions.

rsmith updated this revision to Diff 198762. rsmith added a comment. Remove unneeded test change. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61717/new/ https://reviews.llvm.org/D61717 Files: test/Headers/arm-neon-header.c utils/TableGen/NeonEmitter.cpp

[PATCH] D61709: [NewPM] Port HWASan

phosek added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:956 + + if (LangOpts.Sanitize.has(SanitizerKind::HWAddress)) { +bool Recover = CodeGenOpts.SanitizeRecover.has(SanitizerKind::HWAddress); Can you also add `KernelHWAddress` (akin to

<    1   2