[PATCH] D61664: [NewPM] Setup Passes for KASan and KMSan

philip.pfaffe accepted this revision. philip.pfaffe added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61664/new/ https://reviews.llvm.org/D61664

Re: r360109 - Recommit r359859 "[Attribute/Diagnostics] Print macro if definition is an attribute declaration"

Just wanted to update. My latest revision (r360225) seems to have fixed the bots. 🎉 On Tue, May 7, 2019 at 3:50 PM Jonas Devlieghere wrote: > Hi Leonard, > > My personal rule of thumb is that if I can fix it in something like 30 > minutes or less, I'll leave the bot red and commit a fix. Otherwi

[PATCH] D61642: [clang-tidy] Do not show incorrect fix in modernize-make-unique

This revision was automatically updated to reflect the committed changes. Closed by commit rL360231: [clang-tidy] Do not show incorrect fix in modernize-make-unique (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to comm

[clang-tools-extra] r360231 - [clang-tidy] Do not show incorrect fix in modernize-make-unique

Author: ibiryukov Date: Wed May 8 01:52:18 2019 New Revision: 360231 URL: http://llvm.org/viewvc/llvm-project?rev=360231&view=rev Log: [clang-tidy] Do not show incorrect fix in modernize-make-unique Summary: The case when initialize_list hides behind an implicit case was not handled before. Rev

[PATCH] D61667: Assume `__cxa_allocate_exception` returns an under-aligned memory on Darwin if the version of libc++abi isn't new enough to include the fix in r319123

ahatanak created this revision. ahatanak added reviewers: rjmccall, ldionne. ahatanak added a project: clang. Herald added a reviewer: EricWF. Herald added subscribers: dexonsmith, jkorous. This patch resurrects r264998, which was committed to work around a bug in libc++abi that was causing `_cxa

[PATCH] D61522: Added an assertion to constant evaluation enty points that prohibits dependent expressions

gribozavr updated this revision to Diff 198603. gribozavr added a comment. Addressed review comments: - Simplified error handling in SemaOpenMP, - Only check isValueDependent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61522/new/ https://revie

[PATCH] D61522: Added an assertion to constant evaluation enty points that prohibits dependent expressions

gribozavr marked an inline comment as done. gribozavr added a comment. In D61522#1494155 , @rsmith wrote: > The right thing to check in all of these cases should be only > `isValueDependent()`. Every type-dependent expression should generally also > be v

[PATCH] D61485: Added an assert in `isConstantInitializer`: initializer lists must be in semantic form

gribozavr added a comment. @rsmith Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61485/new/ https://reviews.llvm.org/D61485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D61668: [ARM] Fix the extensions implied by a cpu name

dnsampaio created this revision. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. dnsampaio added reviewers: keith.walker.arm, DavidSpickett, carwil. When using `clang -mcpu=CPUNAME+FEATURELIST`, the intrinsic features defined by CPUNAME are not obt

[PATCH] D61637: [Syntax] Introduce syntax trees

ilya-biryukov added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Corpus.h:23 +/// token buffers, source manager, etc. +class Corpus { +public: sammccall wrote: > I think plain SyntaxArena might be a better name here :-/ > Corpus refers to texts

[PATCH] D61637: [Syntax] Introduce syntax trees

ilya-biryukov updated this revision to Diff 198609. ilya-biryukov added a comment. - s/corpus/arena - Remove an accidental cmake change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61637/new/ https://reviews.llvm.org/D61637 Files: clang/include

[PATCH] D61637: [Syntax] Introduce syntax trees

ilya-biryukov updated this revision to Diff 198606. ilya-biryukov marked 5 inline comments as done. ilya-biryukov added a comment. - Make traverse() internal to its only use-site. - s/Corpus/Arena. - Address some other comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D61668: [ARM] Fix the extensions implied by a cpu name

DavidSpickett added a comment. LGTM but the use of "intrinsic" in the commit message is confusing. Do you mean feature/implied feature, as in "the implied features defined by"? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61668/new/ https://reviews.llvm.org/D61

[PATCH] D61664: [NewPM] Setup Passes for KASan and KMSan

glider added a comment. Rubberstamp LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61664/new/ https://reviews.llvm.org/D61664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D61670: [RFC] [MinGW] Allow opting out from .refptr stubs

mstorsjo created this revision. mstorsjo added a reviewer: rnk. Herald added a project: clang. In GCC, the .refptr stubs are only generated for x86_64, and only for code models medium and larger (and medium is the default for x86_64 since this was introduced). They can be omitted (for projects t

[PATCH] D61506: [OpenCL] Switch to C++17

Anastasia added a comment. In D61506#1493953 , @keryell wrote: > In D61506#1490555 , @rsmith wrote: > > > Per the OpenCL C++ 1.0 specification, section 2: > > > > > The OpenCL C++ programming language is based on th

[PATCH] D58236: Make address space conversions a bit stricter.

ebevhan added a comment. This was accepted a while ago, but never landed. I don't have commit access; could someone commit it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58236/new/ https://reviews.llvm.org/D58236 ___ cfe-commits mailing

[PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

martong updated this revision to Diff 198618. martong added a comment. - Add braces to 'true' cases when 'false' case has braces - Simplify logging and error handling with LLDB_LOG_ERROR Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61438/new/ http

[PATCH] D58236: Make address space conversions a bit stricter.

Anastasia added a comment. In D58236#1494722 , @ebevhan wrote: > This was accepted a while ago, but never landed. I don't have commit access; > could someone commit it? Sure! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58236/new/ https://re

[PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

martong updated this revision to Diff 198623. martong added a comment. - Use LLDB_LOG_ERROR in ImportDefinitionTo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61438/new/ https://reviews.llvm.org/D61438 Files: clang/include/clang/AST/ASTImporter

[PATCH] D61644: Documentation for bugprone-inaccurate-erase: added an example of a bug that this checker catches

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61644/new/ https://reviews.llvm.org/D61644 _

[PATCH] D61424: [ASTImporter] Fix inequivalence of unresolved exception spec

martong updated this revision to Diff 198626. martong marked 2 inline comments as done. martong added a comment. - Improve and fix typo in comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61424/new/ https://reviews.llvm.org/D61424 Files: c

[clang-tools-extra] r360247 - Documentation for bugprone-inaccurate-erase: added an example of a bug that this checker catches

Author: gribozavr Date: Wed May 8 05:02:31 2019 New Revision: 360247 URL: http://llvm.org/viewvc/llvm-project?rev=360247&view=rev Log: Documentation for bugprone-inaccurate-erase: added an example of a bug that this checker catches Reviewers: alexfh Subscribers: cfe-commits Tags: #clang Diff

[PATCH] D61506: [OpenCL] Switch to C++17

Anastasia updated this revision to Diff 198627. Anastasia added a comment. Added `HexFloat`! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61506/new/ https://reviews.llvm.org/D61506 Files: include/clang/Frontend/LangStandards.def test/CodeGenOpenCLCXX/addrspace-of-this.cl Index:

[PATCH] D61644: Documentation for bugprone-inaccurate-erase: added an example of a bug that this checker catches

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE360247: Documentation for bugprone-inaccurate-erase: added an example of a bug that… (authored by gribozavr, committed by ). Changed prior to commit: https://reviews.llvm.org/D61644?vs=198492&id=19862

[PATCH] D60910: [WIP] Dumping the AST to JSON

riccibruno marked an inline comment as done. riccibruno added inline comments. Comment at: include/clang/AST/JSONNodeDumper.h:55 + } + + /// Add a child of the current node with an optional label. aaron.ballman wrote: > riccibruno wrote: > > Perhaps you should

[PATCH] D60956: [Sema] Fix the lookup for a declaration conflicting with an enumerator

riccibruno updated this revision to Diff 198629. riccibruno marked 4 inline comments as done. riccibruno added a comment. Address Aaron's comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60956/new/ https://reviews.llvm.org/D60956 Files: lib/Sema/SemaDec

[PATCH] D61506: [OpenCL] Switch to C++17

kpet accepted this revision. kpet added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61506/new/ https://reviews.llvm.org/D61506 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D61497: [clangd] Introduce a structured hover response

kadircet updated this revision to Diff 198630. kadircet marked 23 inline comments as done. kadircet added a comment. - Address comments - Make little modifications to existing tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61497/new/ https://r

[PATCH] D61497: [clangd] Introduce a structured hover response

kadircet added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:574 - // We want to include the template in the Hover. - if (TemplateDecl *TD = D->getDescribedTemplate()) -D = TD; +llvm::raw_ostream &operator<<(llvm::raw_ostream &OS, +

[PATCH] D61497: [clangd] Introduce a structured hover response

kadircet marked 6 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:539 -/// Generate a \p Hover object given the declaration \p D. -static Hover getHoverContents(const Decl *D) { - Hover H; - llvm::Optional NamedScope = g

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from a formatting issue, this LGTM, thank you! Comment at: clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:93 +DeclarationName Name = S->getNameIn

[PATCH] D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_check'

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. This LGTM, but you may want to wait a day or so to see if @alexfh has any remaining concerns. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D59481: [clangd] Count number of references while merging RefSlabs inside FileIndex

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/index/Background.cpp:482 FileDigest Digest; +bool IsMainFile; }; NIT: maybe initialize with `=false` to avoid potential UB. `Digest` seems uninitialized too, could also `={}` fo

[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

nik updated this revision to Diff 198637. nik added a comment. The plugin makes use of ClangTidyDiagnosticConsumer and forwards diagnostics to the external diagnostic engine. @alexfh: What do you think? If that looks roughly OK for you, I'll finish it. Repository: rCTE Clang Tools Extra CHAN

r360249 - [libclang] PR41649: Remove pointless duplicate flag. NFC.

Author: nik Date: Wed May 8 06:19:29 2019 New Revision: 360249 URL: http://llvm.org/viewvc/llvm-project?rev=360249&view=rev Log: [libclang] PR41649: Remove pointless duplicate flag. NFC. Modified: cfe/trunk/tools/libclang/CIndex.cpp Modified: cfe/trunk/tools/libclang/CIndex.cpp URL: http:/

r360250 - Allow 'static' storage specifier on an out-of-line class member template declaration in MSVCCompat mode.

Author: aaronballman Date: Wed May 8 06:24:36 2019 New Revision: 360250 URL: http://llvm.org/viewvc/llvm-project?rev=360250&view=rev Log: Allow 'static' storage specifier on an out-of-line class member template declaration in MSVCCompat mode. Patch by Soumi Manna. Modified: cfe/trunk/lib/S

[PATCH] D52967: Extend shelf-life by 70 years

bmwiedemann accepted this revision. bmwiedemann added a comment. Herald added a subscriber: dexonsmith. Herald added a project: clang. Can someone please merge this change? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52967/new/ https://reviews.llvm.org/D52967

r360254 - Allow test to pass after 2030.

Author: aaronballman Date: Wed May 8 06:42:44 2019 New Revision: 360254 URL: http://llvm.org/viewvc/llvm-project?rev=360254&view=rev Log: Allow test to pass after 2030. Patch by Bernhard M. Wiedemann. Modified: cfe/trunk/test/Modules/fmodules-validate-once-per-build-session.c Modified: cfe

[PATCH] D52967: Extend shelf-life by 70 years

aaron.ballman closed this revision. aaron.ballman added a comment. In D52967#1494969 , @bmwiedemann wrote: > Can someone please merge this change? I commit the change in r360254, thank you for the patch! Repository: rC Clang CHANGES SINCE LAST ACTIO

r360256 - [clang] Fix a bug that reports UTF32 (LE) files as UTF16 (LE) ones

Author: owenpan Date: Wed May 8 06:49:17 2019 New Revision: 360256 URL: http://llvm.org/viewvc/llvm-project?rev=360256&view=rev Log: [clang] Fix a bug that reports UTF32 (LE) files as UTF16 (LE) ones Also fix a typo for the SCSU byte order mark. Differential Revision: https://reviews.llvm.org/D

[PATCH] D61628: Fix a bug that reports UTF16 (LE) files as UTF32 (LE) ones

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL360256: [clang] Fix a bug that reports UTF32 (LE) files as UTF16 (LE) ones (authored by owenpan, committed by ). Herald ad

[PATCH] D60672: [libclang] visit c++14 lambda capture init expressions

nik added a comment. Tests do not pass on current trunk: /d2/llvm/trunk/builds/DebugShared % bin/llvm-lit -a /d2/llvm/trunk/source/tools/clang/test/Index/cxx14-lambdas.cpp llvm-lit: /d2/llvm/trunk/source/utils/lit/lit/llvm/config.py:341: note: using clang: /d2/llvm/trunk/builds/DebugShared/

[PATCH] D61559: Fix the crash when formatting unsupported encodings

owenpan updated this revision to Diff 198652. owenpan added a comment. Fixed the typo for SCSU. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61559/new/ https://reviews.llvm.org/D61559 Files: clang/tools/clang-format/ClangFormat.cpp Index: clang/tools/clang-

[PATCH] D53866: [Preamble] Stop circular inclusion of main file when building preamble

nik updated this revision to Diff 198654. nik edited the summary of this revision. nik added a comment. Rebased for current trunk. If I miss something obvious, please tell me. Otherwise I'm waiting. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53866/new/ https:

[PATCH] D61559: Fix the crash when formatting unsupported encodings

owenpan marked an inline comment as done. owenpan added inline comments. Comment at: clang/tools/clang-format/ClangFormat.cpp:273 +.StartsWith("\xFF\xFE", "UTF-16 (LE)") +.StartsWith("\x2B\x2F\x76", "UTF-7") +.StartsWith("\xF7\x64\x4C", "UTF-1") sammc

r360257 - [clang-format] Fix the crash when formatting unsupported encodings

Author: owenpan Date: Wed May 8 07:11:12 2019 New Revision: 360257 URL: http://llvm.org/viewvc/llvm-project?rev=360257&view=rev Log: [clang-format] Fix the crash when formatting unsupported encodings Fixes PR33946 Differential Revision: https://reviews.llvm.org/D61559 Modified: cfe/trunk/t

[PATCH] D61559: Fix the crash when formatting unsupported encodings

This revision was automatically updated to reflect the committed changes. Closed by commit rL360257: [clang-format] Fix the crash when formatting unsupported encodings (authored by owenpan, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to com

[PATCH] D53866: [Preamble] Stop circular inclusion of main file when building preamble

ilya-biryukov added a comment. Sorry for losing this. Neat change, minimal and focused, thanks! Just wanted to clarify why we need the change in `SourceManager.cpp`, will LGTM as soon as we resolve this Comment at: lib/Basic/SourceManager.cpp:1594 SourceFileName = ll

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

nik updated this revision to Diff 198656. nik added a comment. Herald added a subscriber: dexonsmith. Minor diff update fixing indentation and removing not needed include. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41005/new/ https://reviews.llvm.org/D4

r360258 - [Sema][OpenCL] Make address space conversions a bit stricter.

Author: stulova Date: Wed May 8 07:23:49 2019 New Revision: 360258 URL: http://llvm.org/viewvc/llvm-project?rev=360258&view=rev Log: [Sema][OpenCL] Make address space conversions a bit stricter. The semantics for converting nested pointers between address spaces are not very well defined. Some c

[PATCH] D58236: Make address space conversions a bit stricter.

This revision was automatically updated to reflect the committed changes. Closed by commit rL360258: [Sema][OpenCL] Make address space conversions a bit stricter. (authored by stulova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D61681: [clangd] A code tweak to expand a macro

ilya-biryukov created this revision. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, mgorny. Herald added a project: clang. ilya-biryukov added a parent revision: D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library. Repository: rG LLVM Github Monorepo https

[PATCH] D61681: [clangd] A code tweak to expand a macro

ilya-biryukov added a comment. This actually works, but still far from landing. Notable problems: - this adds a dependency on `TokenBuffer`, so we need to land it first. - this change is too big, planning to split into multiple changes: (1) collecting tokens when building the AST for clangd, (2)

[PATCH] D61667: Assume `__cxa_allocate_exception` returns an under-aligned memory on Darwin if the version of libc++abi isn't new enough to include the fix in r319123

ldionne added inline comments. Comment at: include/clang/Basic/AlignedExceptionObject.h:15 + +#ifndef LLVM_CLANG_BASIC_ALIGNED_ALLOCATION_H +#define LLVM_CLANG_BASIC_ALIGNED_ALLOCATION_H The guards look wrong. Comment at: include/clang/Basic/Al

[PATCH] D61475: Update an information about ReSharper C++ and clang-tidy custom binary integration

ZaMaZaN4iK added a subscriber: Szelethus. ZaMaZaN4iK added a comment. @JonasToth @NoQ @Szelethus can anyone merge it? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61475/new/ https://reviews.llvm.org/D61475 ___

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

ilya-biryukov added a comment. Again, sorry for the delay. This looks good, just a few NITs from me before I stamp it Comment at: lib/Frontend/PrecompiledPreamble.cpp:457 + llvm::StringMap OverridenFileBuffers; for (const auto &RB : PreprocessorOpts.RemappedFileBuffers)

[PATCH] D59885: [Lex] Allow to consume tokens while preprocessing

ilya-biryukov updated this revision to Diff 198662. ilya-biryukov added a comment. Herald added subscribers: jsji, kbarton, nemanjai. - Propagate whether the token came from a token stream through CachingLex. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D61130: [llvm-mc] Add reportWarning() to MCContext

sidneym accepted this revision. sidneym added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61130/new/ https://reviews.llvm.org/D61130 _

[PATCH] D59885: [Lex] Allow to consume tokens while preprocessing

ilya-biryukov added a comment. I've managed to get what I needed by returning a flag from `Lex`. @rsmith, could you take a look? Is there a better way to do the equivalent? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59885/new/ https://reviews.ll

[PATCH] D59885: [Lex] Allow to consume tokens while preprocessing

ilya-biryukov updated this revision to Diff 198663. ilya-biryukov added a comment. - Get rid of an accidental change in how LexAfterModuleImport is handled Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59885/new/ https://reviews.llvm.org/D59885 Fi

r360261 - [ASTImporter] Fix inequivalence of unresolved exception spec

Author: martong Date: Wed May 8 08:23:48 2019 New Revision: 360261 URL: http://llvm.org/viewvc/llvm-project?rev=360261&view=rev Log: [ASTImporter] Fix inequivalence of unresolved exception spec Summary: Structural equivalence of methods can falsely report false when the exception specifier is un

[PATCH] D61399: [OpenMP][Clang] Support for target math functions

gtbercea updated this revision to Diff 198664. gtbercea added a comment. - Eliminate declarations of functions not needed for math function resolution. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61399/new/ https://reviews.llvm.org/D61399 Files: lib/Driver/T

[PATCH] D61424: [ASTImporter] Fix inequivalence of unresolved exception spec

This revision was automatically updated to reflect the committed changes. Closed by commit rL360261: [ASTImporter] Fix inequivalence of unresolved exception spec (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D61335: [LibTooling] Add support to Transformer for composing rules as an ordered choice.

ymandel added a comment. Gentle ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61335/new/ https://reviews.llvm.org/D61335 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

martong added a comment. Ping @shafik @teemperor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61333/new/ https://reviews.llvm.org/D61333 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

r360265 - [OpenMP][Clang] Support for target math functions

Author: gbercea Date: Wed May 8 08:52:33 2019 New Revision: 360265 URL: http://llvm.org/viewvc/llvm-project?rev=360265&view=rev Log: [OpenMP][Clang] Support for target math functions Summary: In this patch we propose a temporary solution to resolving math functions for the NVPTX toolchain, temp

[PATCH] D61399: [OpenMP][Clang] Support for target math functions

This revision was automatically updated to reflect the committed changes. Closed by commit rC360265: [OpenMP][Clang] Support for target math functions (authored by gbercea, committed by ). Changed prior to commit: https://reviews.llvm.org/D61399?vs=198664&id=198677#toc Repository: rC Clang

[PATCH] D61488: [OpenCL] Make global ctor init function a kernel

Anastasia updated this revision to Diff 198678. Anastasia added a comment. - Improved comments - Switched to SPIR kernel CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61488/new/ https://reviews.llvm.org/D61488 Files: lib/CodeGen/CGDeclCXX.cpp lib/CodeGen/CodeGenFunction.cpp lib/C

[PATCH] D60605: [clangd] Revamp textDocument/onTypeFormatting.

yvvan added a comment. @ilya-biryukov What do you think about D53072 ? It can be polished and combined with this change removing some code from here (which I assume is a good thing). The idea there is that clang-format knows that it's not allowed to remove new

[PATCH] D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_check'

hintonda added a comment. In D60629#1494908 , @aaron.ballman wrote: > This LGTM, but you may want to wait a day or so to see if @alexfh has any > remaining concerns. Will do, thanks Aaron... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D60605: [clangd] Revamp textDocument/onTypeFormatting.

ilya-biryukov added a comment. In D60605#1495268 , @yvvan wrote: > @ilya-biryukov > What do you think about D53072 ? It can be > polished and combined with this change removing some code from here (which I > assume is a

[PATCH] D61689: Change -gz and -Wa,--compress-debug-sections to use gABI compression (SHF_COMPRESSED)

MaskRay created this revision. MaskRay added reviewers: compnerd, rsmith, echristo. Herald added a project: clang. Herald added a subscriber: cfe-commits. Since July 15, 2015 (binutils-gdb commit 19a7fe52ae3d0971e67a134bcb1648899e21ae1c, included in 2.26), gas --compress-debug-sections=zlib (gcc -

[PATCH] D53072: [clang-format] Create a new tool for IDEs based on clang-format

ilya-biryukov added a comment. In D53072#1478575 , @yvvan wrote: > @sammccall > > Having a separate tool is nice because it allows the client to make it > plugable. clang-format sometimes changes options quite significantly and it > can be nice if you ha

[PATCH] D17741: adds __FILE_BASENAME__ builtin macro

NSProgrammer added a comment. In D17741#1413864 , @kristina wrote: > If the author is still missing at the end of next week, any objections to me > resubmitting a similar patch that just implements `__FILE_NAME__` or > `__BASE_NAME__` (Need a few more op

[PATCH] D61335: [LibTooling] Add support to Transformer for composing rules as an ordered choice.

ilya-biryukov added a comment. Sorry for the delay. I personally like the `RewriteRule::Action` best. Allows to use a rather common term, while still avoiding any possible confusion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61335/new/ https:/

[PATCH] D61454: [CodeGen][ObjC] Remove the leading 'l_' from ObjC symbols and make private symbols in the __DATA segment internal.

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Lgtm, thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61454/new/ https://reviews.llvm.org/D61454 ___ cfe-commits

[PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

aprantl added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:5039 + if (!ToOrErr) +// FIXME: return the error? +consumeError(ToOrErr.takeError()); We don't typically commit FIXME's into LLVM code. Why not just deal wit

[PATCH] D17741: adds __FILE_BASENAME__ builtin macro

kristina commandeered this revision. kristina added a reviewer: weimingz. kristina added a comment. Sorry, forgot about this, will make a new diff with just the macro for review later tonight. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17741/new/ https://reviews.llvm.org/D17741 _

r360271 - Include corecrt.h in stddef.h and vcruntime.h in stdarg.h to improve MS

Author: mikerice Date: Wed May 8 10:15:21 2019 New Revision: 360271 URL: http://llvm.org/viewvc/llvm-project?rev=360271&view=rev Log: Include corecrt.h in stddef.h and vcruntime.h in stdarg.h to improve MS compatibility. This allows some applications developed with MSVC to compile with clang wit

[PATCH] D61646: Include corecrt.h/vcruntime.h to improve MS compatibility

This revision was automatically updated to reflect the committed changes. Closed by commit rL360271: Include corecrt.h in stddef.h and vcruntime.h in stdarg.h to improve MS (authored by mikerice, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

sgraenitz added inline comments. Comment at: lldb/source/Symbol/ClangASTImporter.cpp:68 + return *ret_or_error; +} else { + Log *log = aprantl wrote: > The `else` is redundant. Here it's necessary for the scope of `ret_or_error`. That's a bit unfort

[clang-tools-extra] r360277 - [clang-tidy] Update documentation on ReSharper integration.

Author: dergachev Date: Wed May 8 11:12:12 2019 New Revision: 360277 URL: http://llvm.org/viewvc/llvm-project?rev=360277&view=rev Log: [clang-tidy] Update documentation on ReSharper integration. It's now possible to set custom clang-tidy binary. Patch by Alexander Zaitsev! Differential Revisio

[PATCH] D61350: [clang-tidy] New check calling out uses of +new in Objective-C code

mwyman added inline comments. Comment at: clang-tools-extra/clang-tidy/google/AvoidNSObjectNewCheck.cpp:112 + Result.Nodes.getNodeAs("new_call")) { +// Don't warn if the call expression originates from a macro expansion. +if (isMessageExpressionInsideMacro(CallEx

[PATCH] D61475: Update an information about ReSharper C++ and clang-tidy custom binary integration

This revision was automatically updated to reflect the committed changes. Closed by commit rL360277: [clang-tidy] Update documentation on ReSharper integration. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D61350: [clang-tidy] New check calling out uses of +new in Objective-C code

mwyman updated this revision to Diff 198702. mwyman marked 2 inline comments as done. mwyman added a comment. Update for review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61350/new/ https://reviews.llvm.org/D61350 Files: clang-tools-extra/clang-tidy/google/AvoidNSObjectN

[PATCH] D61620: [NewPassManager] Add tuning option: LoopUnrolling [clang-change]

asbirlea updated this revision to Diff 198704. asbirlea added a comment. Update test. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61620/new/ https://reviews.llvm.org/D61620 Files: lib/CodeGen/BackendUtil.cpp test/CodeGen/loop-unroll.c Index: test/CodeGen

[PATCH] D61670: [RFC] [MinGW] Allow opting out from .refptr stubs

rnk added a comment. I'm a little concerned about overloading the code model this way. Currently we have the levels tiny, small, medium, large. Default is the same as small in every way so far as I'm aware. On COFF, the code models are currently untested, so far as I know, and I've been assumin

[PATCH] D61646: Include corecrt.h/vcruntime.h to improve MS compatibility

thakis added a comment. Did I get the bug right that this adds almost 400kB to every file that includes stddef.h? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61646/new/ https://reviews.llvm.org/D61646 ___ cfe-commi

[PATCH] D59885: [Lex] Allow to consume tokens while preprocessing

rsmith added inline comments. Comment at: clang/lib/Lex/Preprocessor.cpp:870-900 + TokenSource Source; do { +Source = TokenSource(); + switch (CurLexerKind) { case CLK_Lexer: + Source.InDirective = CurLexer->ParsingPreprocessorDirective; il

[PATCH] D61670: [RFC] [MinGW] Allow opting out from .refptr stubs

mstorsjo added a comment. Fair enough. On GCC, where the mingw x86_64 default code model is medium, switching it to small gave a small but not insignificant save in code size (around 9KB on a 1,3 MB DLL). On clang, where the default code model is small, getting rid of the extra refptrs didn't

[PATCH] D61646: Include corecrt.h/vcruntime.h to improve MS compatibility

rnk added a comment. In D61646#1495517 , @thakis wrote: > Did I get the bug right that this adds almost 400kB to every file that > includes stddef.h? I didn't put much confidence in that number because it was with `-frewrite-includes` which adds line m

[PATCH] D61670: [RFC] [MinGW] Allow opting out from .refptr stubs

rnk added a comment. Well, I'm curious what meaning GCC ascribes to a medium code model for COFF. Do they generate code to allow PE images larger than 2GB, or is it more like the ELF small code model, where they assume everything can be reached with RIP relative addressing? Repository: rC C

[PATCH] D18914: [clang-tidy] new readability-redundant-inline

mgehre added a comment. Thank you for the review input! After learning about `inlinehint`, I don't feel its worthwhile for me to continue this check. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D18914/new/ https://reviews.llvm.org/D18914

[PATCH] D61667: Assume `__cxa_allocate_exception` returns an under-aligned memory on Darwin if the version of libc++abi isn't new enough to include the fix in r319123

rjmccall added inline comments. Comment at: include/clang/Basic/AlignedExceptionObject.h:31 + case llvm::Triple::MacOSX: // Earliest supporting version is 10.14. +return llvm::VersionTuple(10U, 14U); + case llvm::Triple::IOS: ldionne wrote: > Would it make

[PATCH] D61667: Assume `__cxa_allocate_exception` returns an under-aligned memory on Darwin if the version of libc++abi isn't new enough to include the fix in r319123

rjmccall added inline comments. Comment at: include/clang/Basic/AlignedExceptionObject.h:31 + case llvm::Triple::MacOSX: // Earliest supporting version is 10.14. +return llvm::VersionTuple(10U, 14U); + case llvm::Triple::IOS: rjmccall wrote: > ldionne wrote

[PATCH] D61670: [RFC] [MinGW] Allow opting out from .refptr stubs

mstorsjo added a comment. In D61670#1495535 , @rnk wrote: > Well, I'm curious what meaning GCC ascribes to a medium code model for COFF. > Do they generate code to allow PE images larger than 2GB, or is it more like > the ELF small code model, where they

[PATCH] D61646: Include corecrt.h/vcruntime.h to improve MS compatibility

thakis added a comment. I agree with that. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61646/new/ https://reviews.llvm.org/D61646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D61646: Include corecrt.h/vcruntime.h to improve MS compatibility

mikerice added a comment. For the most part, these headers are going to be included in almost every compilation unit anyway since they will come in through other C/C++ library headers. So this would presumably affect only a small numbers of compilation units that only include stddef.h and none

[PATCH] D50993: [clangd] Increase stack size of the new threads on macOS

umanwizard added a comment. Herald added a subscriber: dexonsmith. Herald added a project: clang. Is there any good reason not to land this? Clangd is crashing for me on macOS with stack overflow in the worker threads. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://re

  1   2   >