[PATCH] D60417: [libunwind] Add support for ARMv7-M architecture which uses the Thumb 2 ISA (unified syntax)

2019-04-08 Thread Jérémie Faucher-Goulet via Phabricator via cfe-commits
jeremfg added a comment. In D60417#1458778 , @mstorsjo wrote: > The change looks sensible to me, but should we maybe even skip the `#if` > altogether? If the files uses unified syntax and can't be parsed in thumb > mode otherwise, there's maybe no need f

[PATCH] D46140: [coroutines] Add std::experimental::task type

2019-04-08 Thread Lewis Baker via Phabricator via cfe-commits
lewissbaker marked an inline comment as done. lewissbaker added a comment. Gentle ping. Is there anything else people would like to see changed? Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D46140/new/ https://reviews.llvm.org/D46140 __

[PATCH] D59415: Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on Windows.

2019-04-08 Thread Igor Kudrin via Phabricator via cfe-commits
ikudrin added a comment. Ping. Please note, that, in contrary to POSIX OSes, on Windows a path like `dir1\\..` refers to `dir1`. That's why we do not need to ask the system for the fully expanded path and can do all calculations internally. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D59924: [PowerPC][Clang] Port MMX intrinsics and basic test cases to Power

2019-04-08 Thread Chaofan Qiu via Phabricator via cfe-commits
qiucf marked 2 inline comments as done. qiucf added inline comments. Comment at: clang/lib/Driver/ToolChains/PPCLinux.cpp:22 + if (getArch() != llvm::Triple::ppc && + !DriverArgs.hasArg(clang::driver::options::OPT_nostdinc) && + !DriverArgs.hasArg(options::OPT_nobuilti

[PATCH] D59347: [DebugInfo] Combine Trivial and NonTrivial flags

2019-04-08 Thread Aaron Smith via Phabricator via cfe-commits
asmith updated this revision to Diff 194249. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59347/new/ https://reviews.llvm.org/D59347 Files: lib/CodeGen/CGDebugInfo.cpp test/CodeGenCXX/debug-info-composite-triviality.cpp Index: test/CodeGenCXX/debug-info-composite-triviality.cpp ==

[PATCH] D60417: [libunwind] Add support for ARMv7-M architecture which uses the Thumb 2 ISA (unified syntax)

2019-04-08 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. In D60417#1459128 , @jeremfg wrote: > In D60417#1458778 , @mstorsjo wrote: > > > The change looks sensible to me, but should we maybe even skip the `#if` > > altogether? If the files uses

<    1   2