[PATCH] D60183: Fix typos in tests. NFC.

Higuoxing created this revision. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits, kubamracek. Herald added projects: clang, Sanitizers, LLVM. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D60183 Files: clang/test/Analysis/analyzer-list-configs.c compiler-rt/t

[clang-tools-extra] r357561 - [clangd] Return clangd::TextEdit in ClangdServer::rename. NFC

Author: ibiryukov Date: Wed Apr 3 00:18:43 2019 New Revision: 357561 URL: http://llvm.org/viewvc/llvm-project?rev=357561&view=rev Log: [clangd] Return clangd::TextEdit in ClangdServer::rename. NFC Summary: Instead of tooling::Replacement. To avoid the need to have contents of the file at the cal

[PATCH] D60179: [clangd] Return clangd::TextEdit in ClangdServer::rename. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rL357561: [clangd] Return clangd::TextEdit in ClangdServer::rename. NFC (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit

r357562 - [libclang][test] Suppress annoying 'LIBCLANG TOOLING ERROR' output

Author: maskray Date: Wed Apr 3 00:25:04 2019 New Revision: 357562 URL: http://llvm.org/viewvc/llvm-project?rev=357562&view=rev Log: [libclang][test] Suppress annoying 'LIBCLANG TOOLING ERROR' output check-all invokes check-clang-python which prints the annoying message: LIBCLANG TOOLING ERROR:

[PATCH] D60115: Adding 'CLion integration' to clang-format doc

MarinaKalashina updated this revision to Diff 193441. MarinaKalashina added a comment. added a link to CLion CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60115/new/ https://reviews.llvm.org/D60115 Files: docs/ClangFormat.rst Index: docs/ClangFormat.rst

[PATCH] D60115: Adding 'CLion integration' to clang-format doc

sylvestre.ledru accepted this revision. sylvestre.ledru added a comment. This revision is now accepted and ready to land. works for me, thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60115/new/ https://reviews.llvm.org/D60115 ___ cfe-

[PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. LGTM with the new changes. Specifying the `clang::Expr` type explicitly when calling `change` looks a bit less clear than the original approach, but also looks pretty clear to me. Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D59449: [clang-tidy] Integrate clang-tidy-diff.py machinery into run-clang-tidy.py

zinovy.nis added a comment. @alexfh, do you still have any objections? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59449/new/ https://reviews.llvm.org/D59449 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D60116: [clang-format] Regroup #includes into blocks for Google style

ioeric updated this revision to Diff 193446. ioeric added a comment. - Improved test. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60116/new/ https://reviews.llvm.org/D60116 Files: lib/Format/Format.cpp unittests/Format/CleanupTest.cpp unittests/Format/So

[PATCH] D60186: Support CLANG_ENABLE_DEFAULT_PIE like gcc --enable-default-pie

jiangyi created this revision. Herald added subscribers: cfe-commits, mstorsjo, aheejin, jgravelle-google, sbc100, mgorny, dschuff, emaste. Herald added a project: clang. GCC 6 added the --enable-defaut-pie flag, which would provide better security with ASLR enabled. --enable-defaut-pie is enab

[PATCH] D60115: Adding 'CLion integration' to clang-format doc

MarinaKalashina marked an inline comment as done. MarinaKalashina added a comment. @sylvestre.ledru Thank you! Could you please explain how I should proceed with the accepted revision now (without commit access, do I need to ask someone to make the commit for me)? CHANGES SINCE LAST ACTION h

[PATCH] D60115: Adding 'CLion integration' to clang-format doc

sylvestre.ledru added a comment. Sure, i will do it for you CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60115/new/ https://reviews.llvm.org/D60115 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

r357566 - Adding 'CLion integration' to clang-format doc

Author: sylvestre Date: Wed Apr 3 01:56:30 2019 New Revision: 357566 URL: http://llvm.org/viewvc/llvm-project?rev=357566&view=rev Log: Adding 'CLion integration' to clang-format doc Summary: This commit adds a chapter 'CLion integration' to ClangFormat.rst. The official announcement of clang-fo

[PATCH] D60115: Adding 'CLion integration' to clang-format doc

This revision was automatically updated to reflect the committed changes. Closed by commit rC357566: Adding 'CLion integration' to clang-format doc (authored by sylvestre, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60115/new/ https://reviews.llv

[PATCH] D60115: Adding 'CLion integration' to clang-format doc

MarinaKalashina added a comment. @sylvestre.ledru Thanks a lot for your help Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60115/new/ https://reviews.llvm.org/D60115 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D60115: Adding 'CLion integration' to clang-format doc

sylvestre.ledru added a comment. You are welcome, thanks for your contribution! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60115/new/ https://reviews.llvm.org/D60115 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D60139: [clang-tidy] Add misc-placement-new-target-size check

DennisL updated this revision to Diff 193449. DennisL marked 13 inline comments as done. DennisL added a comment. Updated patch to address reviewer feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60139/new/ https://reviews.llvm.org/D60139 Files: clang-tidy/misc/CMakeLists.txt

r357567 - [clang-format] Regroup #includes into blocks for Google style

Author: ioeric Date: Wed Apr 3 02:25:16 2019 New Revision: 357567 URL: http://llvm.org/viewvc/llvm-project?rev=357567&view=rev Log: [clang-format] Regroup #includes into blocks for Google style Summary: Regrouping #includes in blocks separated by blank lines when sorting C++ #include headers wa

[PATCH] D60116: [clang-format] Regroup #includes into blocks for Google style

This revision was automatically updated to reflect the committed changes. Closed by commit rC357567: [clang-format] Regroup #includes into blocks for Google style (authored by ioeric, committed by ). Changed prior to commit: https://reviews.llvm.org/D60116?vs=193446&id=193452#toc Repository:

[PATCH] D60139: [clang-tidy] Add misc-placement-new-target-size check

DennisL updated this revision to Diff 193454. DennisL added a comment. Remove debug output CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60139/new/ https://reviews.llvm.org/D60139 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/PlacementNe

[PATCH] D59932: [clang-tidy] **Prototype**: Add fix description to clang-tidy checks.

hokein marked an inline comment as done. hokein added a comment. As discussed offline, the current approach only works for checks provide a single fix, providing such API is somehow misleading. Instead, we'd emit the check fix and the fix description via diagnostic::Note, rather than attaching

[PATCH] D55049: Changed every use of ASTImporter::Import to Import_New

martong added a comment. Ping @shafik @a_sidorin Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55049/new/ https://reviews.llvm.org/D55049 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D59985: Re-fix invalid address space generation for clk_event_t arguments of enqueue_kernel builtin function

AlexeySotkin marked an inline comment as done. AlexeySotkin added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:3711 + EventList = EventList->getType()->isIntegerTy() + ? Builder.CreateIntToPtr(EventList, EventPtrTy) + : Bui

[PATCH] D60130: gn build: Add build files for clangd xpc framework code

mbonadei accepted this revision. mbonadei added a comment. This revision is now accepted and ready to land. Really nice work and thanks for the thread on gn-dev about create_bundle! LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60130/new/ https://reviews.llvm.org/D60130 __

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

Anastasia created this revision. Anastasia added reviewers: rjmccall, ebevhan. Herald added a subscriber: yaxunl. This change adds extra cast operator `addrspace_cast` described earlier in this RFC: http://lists.llvm.org/pipermail/cfe-dev/2018-December/060546.html This operator is intended for c

[PATCH] D59985: Re-fix invalid address space generation for clk_event_t arguments of enqueue_kernel builtin function

Anastasia added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:3711 + EventList = EventList->getType()->isIntegerTy() + ? Builder.CreateIntToPtr(EventList, EventPtrTy) + : Builder.CreatePointerCast(EventList, EventPtrTy); ---

[PATCH] D60194: [Tooling] add a Heuristic field indicating that a CompileCommand was guessed.

sammccall created this revision. sammccall added reviewers: ilya-biryukov, klimek. Herald added subscribers: cfe-commits, kadircet, ioeric. Herald added a project: clang. Use cases: - a tool that dumps the heuristic used for each header in a project can be used to evaluate changes to the heurist

[PATCH] D60139: [clang-tidy] Add misc-placement-new-target-size check

DennisL updated this revision to Diff 193471. DennisL added a comment. Simplify logic CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60139/new/ https://reviews.llvm.org/D60139 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/PlacementNewTarg

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: include/clang/Basic/TokenKinds.def:564 +// OpenCL addrspace_cast operator +KEYWORD(addrspace_cast , KEYOPENCLCXX) + If I mark it as CXX keyword this will make it

[PATCH] D59806: [clang-tidy] Add a check for [super self] in initializers 🔍

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/objc/SuperSelfCheck.cpp:112 + << Message->getMethodDecl() + << FixItHint::CreateReplacement(Message->getSourceRange(), + StringRef("[super init]")); --

[clang-tools-extra] r357574 - gn build: Add build files for clangd xpc framework code

Author: nico Date: Wed Apr 3 05:33:19 2019 New Revision: 357574 URL: http://llvm.org/viewvc/llvm-project?rev=357574&view=rev Log: gn build: Add build files for clangd xpc framework code This is a bit of a larger change since this is the first (and as far as I can tell only) place where the LLVM

[PATCH] D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/llvm/AvoidCastInConditionalCheck.cpp:18 + +AST_MATCHER(Expr, isMacroID) { return Node.getExprLoc().isMacroID(); } +} // namespace ast_matchers hintonda wrote: > @aaron.ballman: This ma

[PATCH] D60130: gn build: Add build files for clangd xpc framework code

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE357574: gn build: Add build files for clangd xpc framework code (authored by nico, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D60130?vs=193313&id=

[PATCH] D59646: [PR40778][PR41157][OpenCL] Prevent implicit initialization of local address space objects

Anastasia updated this revision to Diff 193474. Anastasia added a comment. Improved comment about initializers in __local addr space. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59646/new/ https://reviews.llvm.org/D59646 Files: lib/Sema/SemaDecl.cpp test/CodeGenOpenCLCXX/addrspac

[PATCH] D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/llvm/AvoidCastInConditionalCheck.cpp:145 + +diag(MatchedDecl->getBeginLoc(), "use dyn_cast_or_null") +<< FixItHint::CreateReplacement(SourceRange(MatchedDecl->getBeginLoc(), ---

[PATCH] D59628: Add support for __attribute__((objc_class_stub))

aaron.ballman added inline comments. Comment at: include/clang/Basic/Attr.td:293 bit Negated = negated; + string CustomCode = customCode; } I think the type here should be `code` instead of `string` since the user is passing in code snippets, no?

r357576 - [LibTooling] Add Transformer, a library for source-to-source transformations.

Author: ymandel Date: Wed Apr 3 06:05:19 2019 New Revision: 357576 URL: http://llvm.org/viewvc/llvm-project?rev=357576&view=rev Log: [LibTooling] Add Transformer, a library for source-to-source transformations. Summary: Adds a basic version of Transformer, a library supporting the concise speci

[PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

This revision was automatically updated to reflect the committed changes. Closed by commit rC357576: [LibTooling] Add Transformer, a library for source-to-source transformations. (authored by ymandel, committed by ). Changed prior to commit: https://reviews.llvm.org/D59376?vs=193306&id=193480#t

[PATCH] D59985: Re-fix invalid address space generation for clk_event_t arguments of enqueue_kernel builtin function

AlexeySotkin marked an inline comment as done. AlexeySotkin added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:3711 + EventList = EventList->getType()->isIntegerTy() + ? Builder.CreateIntToPtr(EventList, EventPtrTy) + : Bui

[PATCH] D59985: Re-fix invalid address space generation for clk_event_t arguments of enqueue_kernel builtin function

AlexeySotkin marked an inline comment as done. AlexeySotkin added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:3711 + EventList = EventList->getType()->isIntegerTy() + ? Builder.CreateIntToPtr(EventList, EventPtrTy) + : Bui

[PATCH] D60183: Fix typos in tests. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rL357577: Fix typos in tests. NFC. (authored by Higuoxing, committed by ). Herald added a subscriber: delcypher. Changed prior to commit: https://reviews.llvm.org/D60183?vs=193439&id=193482#toc Repositor

[PATCH] D60197: [clang-tidy] Remove the old ClangTidyCheck::registerPPCallbacks method

alexfh created this revision. alexfh added reviewers: sammccall, hokein. Herald added subscribers: kadircet, arphaman, jkorous, xazax.hun. Herald added a project: clang. All in-tree clang-tidy checks have been migrated to the new ClangTidyCheck::registerPPCallbacks method. Time to drop the old one

[PATCH] D60151: [clang-tidy] Add using SmallSet to LLVM.h to fix bug in typedef in llvm checkers.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. The change looks fine, but I don't understand the description of this revision. Could you clarify which checkers you're talking about and which bug you observe? Repository: rG LLVM Github M

[PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.

alexfh added a comment. Can you verify that the add_new_check.py script works fine with this new module? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59963/new/ https://reviews.llvm.org/D59963 ___

r357577 - Fix typos in tests. NFC.

Author: higuoxing Date: Wed Apr 3 06:15:09 2019 New Revision: 357577 URL: http://llvm.org/viewvc/llvm-project?rev=357577&view=rev Log: Fix typos in tests. NFC. Reviewers: Higuoxing Reviewed By: Higuoxing Subscribers: kubamracek, cfe-commits, #sanitizers, llvm-commits Tags: #clang, #sanitizers

[PATCH] D60151: [clang-tidy] Add using SmallSet to LLVM.h to fix bug in typedef in llvm checkers.

aaron.ballman requested changes to this revision. aaron.ballman added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/clang-tidy/utils/HeaderFileExtensionsUtils.h:21 -typedef llvm::SmallSet HeaderFileExtensionsSet; +using HeaderFile

r357579 - Fixing a typo; NFC.

Author: aaronballman Date: Wed Apr 3 06:37:56 2019 New Revision: 357579 URL: http://llvm.org/viewvc/llvm-project?rev=357579&view=rev Log: Fixing a typo; NFC. Modified: cfe/trunk/docs/LibASTMatchersReference.html cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h Modified: cfe/trunk/docs/

[PATCH] D59646: [PR40778][PR41157][OpenCL] Prevent implicit initialization of local address space objects

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59646/new/ https://reviews.llvm.org/D59646 ___ cfe-commits mailing list cfe-comm

[PATCH] D59988: [PR41276] Generate address space cast of 'this' for objects attributed by an address space in C++

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59988/new/ https://reviews.llvm.org/D59988 ___ cfe-commits mailing list cfe-comm

[clang-tools-extra] r357582 - [clang-tidy] Remove the old ClangTidyCheck::registerPPCallbacks method

Author: alexfh Date: Wed Apr 3 07:03:43 2019 New Revision: 357582 URL: http://llvm.org/viewvc/llvm-project?rev=357582&view=rev Log: [clang-tidy] Remove the old ClangTidyCheck::registerPPCallbacks method Summary: All in-tree clang-tidy checks have been migrated to the new ClangTidyCheck::register

[PATCH] D60199: [clang-format] Do not emit replacements while regrouping if Cpp includes are OK

krasimir created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. krasimir added a reviewer: ioeric. Currently clang-format would always emit a replacement for multi-block #include sections if `IBS_Regroup`, even if the sections are correct: % cat ~/test.h

[PATCH] D60197: [clang-tidy] Remove the old ClangTidyCheck::registerPPCallbacks method

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE357582: [clang-tidy] Remove the old ClangTidyCheck::registerPPCallbacks method (authored by alexfh, committed by ). Changed prior to commit: https://reviews.llvm.org/D60197?vs=193481&id=193486#toc Re

[PATCH] D60139: [clang-tidy] Add misc-placement-new-target-size check

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/misc-placement-new-target-size.rst:5 +== + + Eugene.Zelenko wrote: > Unnecessary empty line. Somehow empty line is still there. CHANGES SINCE LAST ACTION http

[PATCH] D33841: [clang-tidy] redundant keyword check

alexfh added inline comments. Comment at: docs/clang-tidy/checks/readability-redundant-keyword.rst:8 + +`extern` is redundant in function declarations + koldaniel wrote: > alexfh wrote: > > xazax.hun wrote: > > > alexfh wrote: > > > > Could you explain, why you t

[PATCH] D60141: [HIP-Clang] Fat binary should not be produced for non GPU code

ashi1 added a comment. Thank you, I submitted a clang-formatted fix for the if statement. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60141/new/ https://reviews.llvm.org/D60141 ___ cfe-commits mailing list cfe-commi

[PATCH] D60201: Make clangd-fuzzer use the normal add_llvm_fuzzer() machinery

thakis created this revision. thakis added a reviewer: bkramer. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov, mgorny. This allows building it even if no fuzzer is enabled. (Sadly, it only builds on Linux at the moment.) https://reviews.llvm.org/D60201

r357585 - Add a new attribute documentation category for declarations.

Author: aaronballman Date: Wed Apr 3 07:26:32 2019 New Revision: 357585 URL: http://llvm.org/viewvc/llvm-project?rev=357585&view=rev Log: Add a new attribute documentation category for declarations. This moves documentation for some attributes into new categories that are hopefully a bit more c

[PATCH] D59628: Add support for __attribute__((objc_class_stub))

aaron.ballman added inline comments. Comment at: include/clang/Basic/AttrDocs.td:1116 +def ObjCClassStubDocs : Documentation { +let Category = DocCatFunction; +let Content = [{ aaron.ballman wrote: > slavapestov wrote: > > aaron.ballman wrote: > > > This

r357589 - Whitespace and formatting changes; NFC.

Author: aaronballman Date: Wed Apr 3 07:40:00 2019 New Revision: 357589 URL: http://llvm.org/viewvc/llvm-project?rev=357589&view=rev Log: Whitespace and formatting changes; NFC. Modified: cfe/trunk/include/clang/Basic/AttrDocs.td Modified: cfe/trunk/include/clang/Basic/AttrDocs.td URL: htt

[PATCH] D60199: [clang-format] Do not emit replacements while regrouping if Cpp includes are OK

ioeric added inline comments. Comment at: unittests/Format/SortIncludesTest.cpp:28 std::string sort(StringRef Code, std::vector Ranges, + llvm::Optional ExpectedNumRanges = llvm::None, StringRef FileName = "input.cc") { As

[PATCH] D59811: [clangd] Add fallback mode for code completion when compile command or preamble is not ready.

sammccall added a comment. Got here trying to understand how D60126 works. It seems there's two fairly independent changes here: - the one described, allow actions to run without a preamble - defer the blocking getCompileCommand() call until we're building the

[PATCH] D59371: [LibTooling] Add Stencil library for format-string style codegen.

ymandel updated this revision to Diff 193496. ymandel added a comment. Sever dependency on NodeId and some general cleanup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59371/new/ https://reviews.llvm.org/D59371 Files: clang/include/clang/Tooli

[PATCH] D59449: [clang-tidy] Integrate clang-tidy-diff.py machinery into run-clang-tidy.py

alexfh added a comment. In D59449#1449664 , @zinovy.nis wrote: > > Why not just use clang-tidy-diff.py? The clang-tidy-diff.py script has a > > distinct and somewhat self-documenting name and a very specific purpose > > (find clang-tidy regressions in a

[PATCH] D59371: [LibTooling] Add Stencil library for format-string style codegen.

ymandel updated this revision to Diff 193498. ymandel added a comment. Remove noisy default-defined constructors/operators Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59371/new/ https://reviews.llvm.org/D59371 Files: clang/include/clang/Toolin

[PATCH] D60199: [clang-format] Do not emit replacements while regrouping if Cpp includes are OK

krasimir updated this revision to Diff 193500. krasimir added a comment. - Address review comments Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60199/new/ https://reviews.llvm.org/D60199 Files: lib/Format/Format.cpp unittests/Format/SortIncludesTest.cpp In

[PATCH] D60151: [clang-tidy] Add using SmallSet to LLVM.h to fix bug in typedef in llvm checkers.

hintonda added a comment. In D60151#1453099 , @alexfh wrote: > The change looks fine, but I don't understand the description of this > revision. Could you clarify which checkers you're talking about and which bug > you observe? Sorry for not being clea

[PATCH] D60203: Updating Chromium's Java import order

SamMaier created this revision. SamMaier added a reviewer: thakis. Herald added subscribers: cfe-commits, srhines. Herald added a project: clang. Adding in androidx as another import group. Repository: rC Clang https://reviews.llvm.org/D60203 Files: lib/Format/Format.cpp Index: lib/Forma

r357599 - [clang-format] Do not emit replacements while regrouping if Cpp includes are OK

Author: krasimir Date: Wed Apr 3 08:16:04 2019 New Revision: 357599 URL: http://llvm.org/viewvc/llvm-project?rev=357599&view=rev Log: [clang-format] Do not emit replacements while regrouping if Cpp includes are OK Summary: Currently clang-format would always emit a replacement for multi-block #i

[PATCH] D60199: [clang-format] Do not emit replacements while regrouping if Cpp includes are OK

This revision was automatically updated to reflect the committed changes. Closed by commit rC357599: [clang-format] Do not emit replacements while regrouping if Cpp includes are OK (authored by krasimir, committed by ). Changed prior to commit: https://reviews.llvm.org/D60199?vs=193500&id=19350

[PATCH] D59985: Re-fix invalid address space generation for clk_event_t arguments of enqueue_kernel builtin function

AlexeySotkin added a comment. Alternative way to fix it is to use `isNullPointerConstant` like we do in `SemaOpenCLBuiltinEnqueueKernel`. So in case we have a zero literal value we can emit `ConstantPointerNull` directly, without `EmitScalarExpr` . Repository: rC Clang CHANGES SINCE LAST AC

[PATCH] D60203: Updating Chromium's Java import order

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Thanks! (Test?) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60203/new/ https://reviews.llvm.org/D60203 ___ cf

[PATCH] D59932: [clang-tidy] **Prototype**: Add fix description to clang-tidy checks.

hokein updated this revision to Diff 193510. hokein added a comment. Emit the check fix description via diagnostic::note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59932/new/ https://reviews.llvm.org/D59932 Files: clang-tools-extra/clang-app

[PATCH] D60151: [clang-tidy] Add using SmallSet to LLVM.h to fix bug in typedef in llvm checkers.

hintonda marked an inline comment as done. hintonda added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/HeaderFileExtensionsUtils.h:21 -typedef llvm::SmallSet HeaderFileExtensionsSet; +using HeaderFileExtensionsSet = SmallSet; aaron.ballman

[PATCH] D59932: [clang-tidy] **Prototype**: Add fix description to clang-tidy checks.

hokein added a comment. Running out of time today, the patch is not finished yet, but it should be good for another initial review/comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59932/new/ https://reviews.llvm.org/D59932 __

[PATCH] D60151: [clang-tidy] Add using SmallSet to LLVM.h to fix bug in typedef in llvm checkers.

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/HeaderFileExtensionsUtils.h:21 -typedef llvm::SmallSet HeaderFileExtensionsSet; +using HeaderFileExtensionsSet = SmallSet; hintonda wrote: > aaron.ballman wrote: > > I do not

[PATCH] D60151: [clang-tidy] Add using SmallSet to LLVM.h to fix bug in typedef in llvm checkers.

hintonda marked an inline comment as done. hintonda added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/HeaderFileExtensionsUtils.h:21 -typedef llvm::SmallSet HeaderFileExtensionsSet; +using HeaderFileExtensionsSet = SmallSet; aaron.ballman

[PATCH] D60018: [codeview] Remove Type member from CVRecord

rnk marked 2 inline comments as done. rnk added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60018/new/ https://reviews.llvm.org/D60018 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D60018: [codeview] Remove Type member from CVRecord

rnk updated this revision to Diff 193526. rnk added a comment. - final updates Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60018/new/ https://reviews.llvm.org/D60018 Files: lld/COFF/PDB.cpp lldb/source/Plugins/SymbolFile/NativePDB/UdtRecordC

[PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

ABataev added a comment. Patch breaks the build with the shared libraries, for example, http://lab.llvm.org:8011/builders/clang-ppc64le-linux-multistage/builds/9498. Seems to me, you need to add an extra dependency on clangTooling. clangToolingCore is not enough. Repository: rC Clang CHANG

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

nickdesaulniers added a comment. Note that with: 1. https://reviews.llvm.org/D60208 ("[X86] Extend boolean arguments to inline-asm according to getBooleanType") 2. https://reviews.llvm.org/D58260 ("[INLINER] allow inlining of blockaddresses if sole uses are callbrs") 3. https://reviews.llvm.o

Re: [PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

Thanks. Do you have build command I can run before/after to verify my fix before I submit? On Wed, Apr 3, 2019 at 12:43 PM Alexey Bataev via Phabricator < revi...@reviews.llvm.org> wrote: > ABataev added a comment. > > Patch breaks the build with the shared libraries, for example, > http://lab.l

[libunwind] r357606 - [libunwind] Do not share an object library to create the static/shared libraries

Author: phosek Date: Wed Apr 3 09:59:33 2019 New Revision: 357606 URL: http://llvm.org/viewvc/llvm-project?rev=357606&view=rev Log: [libunwind] Do not share an object library to create the static/shared libraries This change is similar to r356150, with the same motivation. Modified: libunwi

[PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

ABataev added a comment. You need to provide -DBUILD_SHARED_LIBS=true to cmake. Unfortunately, there is a dependency from the libToolingRefactor to libTooling. I don't think it will be easy to fix this. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59376/new/ h

[PATCH] D60213: Add clangTooling dependency to fix the build.

ymandel created this revision. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. Fixes https://reviews.llvm.org/D59371, which broke the build for shared libraries. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D60213 Files: clang/lib/Tooling/Refa

Re: [PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

https://reviews.llvm.org/D60213 for the record On Wed, Apr 3, 2019 at 12:55 PM Yitzhak Mandelbaum wrote: > Thanks. Do you have build command I can run before/after to verify my fix > before I submit? > > On Wed, Apr 3, 2019 at 12:43 PM Alexey Bataev via Phabricator < > revi...@reviews.llvm.org>

[PATCH] D60213: Add clangTooling dependency to fix the build.

ABataev added a comment. Nope, it won't work. There is a cyclic dependency, unfortunately. clangTooling depends on clangToolingRefactor already. You need to revert your commit and refactor it to remove the cyclic dependency. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D59932: [clang-tidy] **Prototype**: Add fix description to clang-tidy checks.

alexfh added a comment. This looks like a more promising direction. Thanks for the readiness to experiment with this. See the comments inline. Comment at: clang-tools-extra/clang-tidy/ClangTidy.cpp:130 + + // If we have alternative fixes (attached via diagnostic::Notes),

r357610 - Bug-40323: MS ABI adding template static member in the linker directive section to make sure init function can be called before main.

Author: jyu2 Date: Wed Apr 3 10:21:40 2019 New Revision: 357610 URL: http://llvm.org/viewvc/llvm-project?rev=357610&view=rev Log: Bug-40323: MS ABI adding template static member in the linker directive section to make sure init function can be called before main. Added: cfe/trunk/test/CodeG

[PATCH] D60213: Add clangTooling dependency to fix the build.

ymandel added a comment. In D60213#1453516 , @ABataev wrote: > Nope, it won't work. There is a cyclic dependency, unfortunately. > clangTooling depends on clangToolingRefactor already. You need to revert your > commit and refactor it to remove the cyclic

[PATCH] D60213: Add clangTooling dependency to fix the build.

ABataev added a comment. I can revert it for you, if you want Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60213/new/ https://reviews.llvm.org/D60213 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D60151: [clang-tidy] Add using SmallSet to LLVM.h to fix bug in typedef in llvm checkers.

alexfh added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/HeaderFileExtensionsUtils.h:21 -typedef llvm::SmallSet HeaderFileExtensionsSet; +using HeaderFileExtensionsSet = SmallSet; hintonda wrote: > aaron.ballman wrote: > > hintonda wrote:

Re: [PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

I'll revert the change. On Wed, Apr 3, 2019 at 1:00 PM Yitzhak Mandelbaum wrote: > https://reviews.llvm.org/D60213 for the record > > On Wed, Apr 3, 2019 at 12:55 PM Yitzhak Mandelbaum > wrote: > >> Thanks. Do you have build command I can run before/after to verify my >> fix before I submit? >

r357612 - Revert "[LibTooling] Add Transformer, a library for source-to-source transformations."

Author: abataev Date: Wed Apr 3 10:34:04 2019 New Revision: 357612 URL: http://llvm.org/viewvc/llvm-project?rev=357612&view=rev Log: Revert "[LibTooling] Add Transformer, a library for source-to-source transformations." This reverts commit r357576 to fix the problem with the cyclic dependencies

Re: [PATCH] D60213: Add clangTooling dependency to fix the build.

That would be great, thank you. On Wed, Apr 3, 2019 at 1:28 PM Alexey Bataev via Phabricator < revi...@reviews.llvm.org> wrote: > ABataev added a comment. > > I can revert it for you, if you want > > > Repository: > rG LLVM Github Monorepo > > CHANGES SINCE LAST ACTION > https://reviews.llvm.

[PATCH] D60213: Add clangTooling dependency to fix the build.

ABataev added a comment. Reverted in r357612 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60213/new/ https://reviews.llvm.org/D60213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D60151: [clang-tidy] Add using SmallSet to LLVM.h to fix bug in typedef in llvm checkers.

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/HeaderFileExtensionsUtils.h:21 -typedef llvm::SmallSet HeaderFileExtensionsSet; +using HeaderFileExtensionsSet = SmallSet; alexfh wrote: > hintonda wrote: > > aaron.ballman wr

[PATCH] D60151: [clang-tidy] Add using SmallSet to LLVM.h to fix bug in typedef in llvm checkers.

hintonda marked an inline comment as done. hintonda added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/HeaderFileExtensionsUtils.h:21 -typedef llvm::SmallSet HeaderFileExtensionsSet; +using HeaderFileExtensionsSet = SmallSet; aaron.ballman

[PATCH] D58160: MS ABI: adding template static member in the linker directive section to make sure init function can be called before main.

jyu2 closed this revision. jyu2 added a comment. Closed by commit rG0b28b8b09be7 : Bug-40323: MS ABI adding template static member in the linker directive section… (authored by jyu2). Repository: rL LLVM CHANGES SINCE LAS

r357617 - [OPENMP]Add codegen for firstprivate vars with allocate clause.

Author: abataev Date: Wed Apr 3 10:57:06 2019 New Revision: 357617 URL: http://llvm.org/viewvc/llvm-project?rev=357617&view=rev Log: [OPENMP]Add codegen for firstprivate vars with allocate clause. Added codegen/test for the firstprivatized variables with the allocate clause. Modified: cfe/t

[PATCH] D60220: [CUDA][Windows] Final fix for bug 38811 (Step 3 of 3)

emankov created this revision. emankov added a reviewer: tra. emankov added a project: clang. Herald added a subscriber: cfe-commits. Last fix for the clang Bug 38811 "Clang fails to compile with CUDA-9.x on Windows". **[IMPORTANT]** With that last f

  1   2   >