[PATCH] D48116: [libclang] Allow skipping warnings from all included files

nik added a comment. Herald added a project: clang. >> For filtering in StoredDiagnosticConsumer one needs to pass the new bool >> everywhere along where "bool CaptureDiagnostics" is already passed on (to >> end up in the StoredDiagnosticConsumer constructor) . Also, >> ASTUnit::CaptureDiagnost

[PATCH] D48116: [libclang] Allow skipping warnings from all included files

nik updated this revision to Diff 187318. nik added a comment. Herald added a subscriber: jdoerfert. OK, filtering happens now in FilterAndStoreDiagnosticConsumer, the former StoredDiagnosticConsumer. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48116/new/ https

[PATCH] D58345: [clangd] Using symbol name to map includes for STL symbols.

sammccall added a comment. In D58345#1401213 , @hokein wrote: > In D58345#1401040 , @ioeric wrote: > > > Looks great! Thanks for doing this. > > > > Could you also check in the tool that is used to generate the mapp

[PATCH] D52150: [clang-format] BeforeHash added to IndentPPDirectives

to-miz added a comment. I understand that adding new options adds costs to the development of clang-format, but there was a feature request and there is interest for this option. As for the cost to the development, there already exists PPDIS_AfterHash. All I did was make the changes introduced

[PATCH] D58377: Remove extraneous space in MSVC-style diagnostic output

hans created this revision. hans added a reviewer: thakis. Herald added a subscriber: jdoerfert. There was an extra space between the file location and the diagnostic message: /tmp/a.c(1,12): warning: unused parameter 'unused' the tests didn't catch this due to FileCheck not running in --stri

[PATCH] D58377: Remove extraneous space in MSVC-style diagnostic output

hans updated this revision to Diff 187320. hans added a comment. Output a char instead of a one-character string. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58377/new/ https://reviews.llvm.org/D58377 Files: clang/lib/Frontend/TextDiagnostic.cpp clang/test/Misc/diag-format.c In

[PATCH] D58346: [Sema] Change addr space diagnostics in casts to follow C++ style

ebevhan added inline comments. Comment at: lib/Sema/SemaCast.cpp:2224 + } else if (IsLValueCast) { Kind = CK_LValueBitCast; } else if (DestType->isObjCObjectPointerType()) { Anastasia wrote: > ebevhan wrote: > > This might not be applicable to this patch

[PATCH] D58294: [clangd] Enable indexing of template type parameters

kadircet added a comment. Yeah you are right, no need to have those in the index. I thought we looked at only index for findreferences(which turned out to be wrong, we also traverse ast), therefore I had turned this functionality on for dynamic index. Repository: rCTE Clang Tools Extra CHAN

[PATCH] D58294: [clangd] Enable indexing of template type parameters

kadircet updated this revision to Diff 187322. kadircet added a comment. - Turn off indexing of template type parms for dynamic index Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58294/new/ https://reviews.llvm.org/D58294 Files: clangd/XRefs.cpp

[PATCH] D58294: [clangd] Enable indexing of template type parameters

ilya-biryukov added inline comments. Comment at: clangd/XRefs.cpp:42 // Only a single declaration is allowed. - if (isa(D)) // except cases above + if (isa(D) || isa(D)) // except cases above return D; Should probably also handle `TemplateTemplateParmDe

[PATCH] D48116: [libclang] Allow skipping warnings from all included files

ilya-biryukov added a comment. This LGTM wrt to layering, i.e. it's nice we don't need to change the code of diagnostics. It's been a while since I've looked at the ASTUnit code, though, would be good if someone else took an extra look at it. Added a few nits too. Comment at

[PATCH] D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer

baloghadamsoftware added a comment. If I understand it correctly, this is more of an infrastructure improvement than check enhancement. It looks like a nice and clean code. Where do we expect to use this new behavior? In the current check or in the upcoming "modernize" check? ===

[PATCH] D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Sorry for the reviews, i'm really stalling it seems.. This looks like a straight-forward change, but i'm not sure i'm familiar enough with ExceptionAnalyzer to fully properly review th

[PATCH] D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer

baloghadamsoftware accepted this revision. baloghadamsoftware added a comment. In D57883#1402049 , @lebedev.ri wrote: > It's for D57108 , i'we guessed that such > ternary answer will be required there. Oh, I was not awar

[PATCH] D58346: [Sema] Change addr space diagnostics in casts to follow C++ style

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: lib/Sema/SemaCast.cpp:2224 + } else if (IsLValueCast) { Kind = CK_LValueBitCast; } else if (DestType->isObjCObjectPointerType()) { ebevhan wrote: > Anastasia wrote:

[PATCH] D54295: [WIP, RISCV] Add inline asm constraint A for RISC-V

lewis-revill updated this revision to Diff 187335. lewis-revill added a comment. Herald added subscribers: llvm-commits, jdoerfert. Herald added a project: LLVM. Correct test. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54295/new/ https://reviews.llvm.org/D54295

[PATCH] D57450: [RISCV] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth for RV32/RV64 targets with atomics

asb added a comment. Herald added a project: clang. Ping? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57450/new/ https://reviews.llvm.org/D57450 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D57896: Variable names rule

michaelplatings updated this revision to Diff 187339. michaelplatings added a comment. Changed recommendation for acronyms from lower case to upper case, as suggested by several responses to the RFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57

[PATCH] D58179: [OpenCL][PR40707] Allow OpenCL C types in C++ mode

Anastasia closed this revision. Anastasia added a comment. Committed in r354121. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58179/new/ https://reviews.llvm.org/D58179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D58293: [clang][Index] Enable indexing of Template Type Parameters behind a flag

kadircet added inline comments. Comment at: lib/Index/IndexingContext.cpp:51 + bool IndexingContext::handleDecl(const Decl *D, SymbolRoleSet Roles, ilya-biryukov wrote: > Do we call `handleDecl` for template parameters now too?

[PATCH] D58293: [clang][Index] Enable indexing of Template Type Parameters behind a flag

kadircet updated this revision to Diff 187341. kadircet marked 2 inline comments as done. kadircet added a comment. - Fix handling of TemplateTemplateTypeParams Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58293/new/ https://reviews.llvm.org/D58293 Files: inc

[PATCH] D58343: Enablement for AMD znver2 architecture - skeleton patch

GGanesh updated this revision to Diff 187340. GGanesh added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Addressed the comments from Craig Topper Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58343/new/ https://reviews.llvm.or

[PATCH] D58294: [clangd] Enable indexing of template type parameters

kadircet updated this revision to Diff 187342. kadircet added a comment. - Add handling for template template type parameters Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58294/new/ https://reviews.llvm.org/D58294 Files: clangd/XRefs.cpp unitt

[PATCH] D57896: Variable names rule

miyuki added inline comments. Comment at: llvm/docs/CodingStandards.rst:1065 case 'J': { -if (Signed) { - Type = Context.getsigjmp_bufType(); - if (Type.isNull()) { -Error = ASTContext::GE_Missing_sigjmp_buf; +if (signed) { + type = context.getsi

[PATCH] D57450: [RISCV] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth for RV32/RV64 targets with atomics

rogfer01 added a comment. Looks sensible to me. I'm just curious why we want to prevent emission of atomic LLVM instructions at this point. Won't LLVM's AtomicExpand perform a similar lowering already? Perhaps the goal is to save that pass some work? Repository: rC Clang CHANGES SINCE LAST

[PATCH] D58185: [clangd] Handle unresolved scope specifier when fixing includes.

ioeric added inline comments. Comment at: clangd/IncludeFixer.cpp:191 +//~~ +llvm::Optional qualifiedByUnresolved(llvm::StringRef Code, + size_t Offset) { sammccall wrote: > this isn't wrong per se

[PATCH] D58185: [clangd] Handle unresolved scope specifier when fixing includes.

ioeric updated this revision to Diff 187343. ioeric marked 16 inline comments as done. ioeric added a comment. - address review comment Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58185/new/ https://reviews.llvm.org/D58185 Files: clangd/Include

[PATCH] D57896: Variable names rule

michaelplatings updated this revision to Diff 187344. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57896/new/ https://reviews.llvm.org/D57896 Files: .clang-tidy clang/.clang-tidy llvm/.clang-tidy llvm/docs/CodingStandards.rst Index: llvm/d

[PATCH] D57450: [RISCV] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth for RV32/RV64 targets with atomics

asb added a comment. In D57450#1402153 , @rogfer01 wrote: > Looks sensible to me. > > I'm just curious why we want to prevent emission of atomic LLVM instructions > at this point. Won't LLVM's AtomicExpand perform a similar lowering already? > Perhaps th

[PATCH] D57450: [RISCV] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth for RV32/RV64 targets with atomics

jrtc27 added a comment. Also worth noting that the frontend needs to know the max width otherwise `warn_atomic_op_misaligned` will be triggered with the message `large atomic operation may incur significant performance penalty` (name is misleading since the `%select{large|misaligned}0` means it

[PATCH] D58294: [clangd] Enable indexing of template type parameters

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58294/new/ https://reviews.llvm.org/D58294 __

[PATCH] D55250: [clangd] Enhance macro hover to see full definition

ilya-biryukov added inline comments. Comment at: clangd/ClangdLSPServer.cpp:823 + (*H)->contents.value = + llvm::formatv("```C++\n{0}\n```", (*H)->contents.value); +} The contents of the hover is not strictly C++ code, so

[PATCH] D57896: Variable names rule

lattner added a comment. > Changed recommendation for acronyms from lower case to upper case, as > suggested by several responses to the RFC. I haven't been following the discussion closely - why is this the preferred direction? I don't think that things like "Basicblock *bb" or "MachineInstr

[PATCH] D58306: [AArch64] Change size suffix for FP16FML intrinsics.

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. LGTM The ACLE has been updated and a new version with change included will be released soon. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58306/n

[PATCH] D57896: Variable names rule

michaelplatings added a comment. In D57896#1402194 , @lattner wrote: > > Changed recommendation for acronyms from lower case to upper case, as > > suggested by several responses to the RFC. > > I haven't been following the discussion closely - why is this

[clang-tools-extra] r354330 - [clangd] Handle unresolved scope specifier when fixing includes.

Author: ioeric Date: Tue Feb 19 06:32:22 2019 New Revision: 354330 URL: http://llvm.org/viewvc/llvm-project?rev=354330&view=rev Log: [clangd] Handle unresolved scope specifier when fixing includes. Summary: In the following examples, "clangd" is unresolved, and the fixer will try to fix include f

[PATCH] D58185: [clangd] Handle unresolved scope specifier when fixing includes.

ioeric updated this revision to Diff 187359. ioeric added a comment. - minor cleanup Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58185/new/ https://reviews.llvm.org/D58185 Files: clangd/IncludeFixer.cpp unittests/clangd/DiagnosticsTests.cpp

[PATCH] D58185: [clangd] Handle unresolved scope specifier when fixing includes.

This revision was automatically updated to reflect the committed changes. Closed by commit rL354330: [clangd] Handle unresolved scope specifier when fixing includes. (authored by ioeric, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D58320: [Darwin] Introduce a new flag, -flink-builtins-rt that forces linking of the builtins library.

peter.smith added a comment. The implementation changes in the Darwin toolchain look fine to me, although with respect to the command line option I think Petr Hosek's message on cfe-dev is interesting: > GCC implements -nolibc which could be used to achieve the same effect when > combined with

Re: r354075 - [clang][FileManager] fillRealPathName even if we aren't opening the file

I didn't realize it just copied a string. I just saw a call to "fillRealPathName" and the "RealPath" bit sounded slow. From clicking around in http://llvm-cs.pcc.me.uk/tools/clang/lib/Basic/FileManager.cpp#361 it looks like it's not really computing a realpath (for symlinks). It still does quite a

[PATCH] D58377: Remove extraneous space in MSVC-style diagnostic output

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. wht CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58377/new/ https://reviews.llvm.org/D58377 ___ cfe-commits mailing list cfe-commit

[PATCH] D58293: [clang][Index] Enable indexing of Template Type Parameters behind a flag

ilya-biryukov added inline comments. Comment at: include/clang/Index/IndexingAction.h:49 bool IndexParametersInDeclarations = false; + bool IndexTemplateParmDecls = false; }; NIT: maybe rename to `IndexTemplateParameters`? The `ParmDecl` is a somewhat weird

[PATCH] D57896: Variable names rule

zturner added a comment. In D57896#1402194 , @lattner wrote: > > Changed recommendation for acronyms from lower case to upper case, as > > suggested by several responses to the RFC. > > I haven't been following the discussion closely - why is this the pre

[PATCH] D57896: Variable names rule

zturner requested changes to this revision. zturner added a comment. This revision now requires changes to proceed. Since someone already accepted this, I suppose I should mark require changes to formalize my dissent Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

r354337 - [OpenCL] Change type of block pointer for OpenCL

Author: bader Date: Tue Feb 19 07:19:06 2019 New Revision: 354337 URL: http://llvm.org/viewvc/llvm-project?rev=354337&view=rev Log: [OpenCL] Change type of block pointer for OpenCL Summary: For some reason OpenCL blocks in LLVM IR are represented as function pointers. These pointers do not point

[PATCH] D58277: [OpenCL] Change type of block pointer for OpenCL

This revision was automatically updated to reflect the committed changes. Closed by commit rL354337: [OpenCL] Change type of block pointer for OpenCL (authored by bader, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revie

[PATCH] D58341: [clangd] Index UsingDecls

kadircet updated this revision to Diff 187367. kadircet added a comment. - Add tests for code completion Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58341/new/ https://reviews.llvm.org/D58341 Files: unittests/clangd/SymbolCollectorTests.cpp u

[PATCH] D58341: [clangd] Index UsingDecls

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM from my side, with a few NITs. But let's wait for an LGTM from Haojian too, to make sure his concerns are addressed. Comment at: unittests/clangd/SymbolCo

[PATCH] D58293: [clang][Index] Enable indexing of Template Type Parameters behind a flag

kadircet updated this revision to Diff 187370. kadircet marked 2 inline comments as done. kadircet added a comment. - Change options name - Also index decls Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58293/new/ https://reviews.llvm.org/D58293 Files: include

[PATCH] D58294: [clangd] Enable indexing of template type parameters

kadircet updated this revision to Diff 187371. kadircet marked an inline comment as done. kadircet added a comment. - Option's name has changed Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58294/new/ https://reviews.llvm.org/D58294 Files: clangd

[PATCH] D58293: [clang][Index] Enable indexing of Template Type Parameters behind a flag

kadircet added inline comments. Comment at: lib/Index/IndexingContext.cpp:51 + bool IndexingContext::handleDecl(const Decl *D, SymbolRoleSet Roles, ilya-biryukov wrote: > kadircet wrote: > > ilya-biryukov wrote: > > > Do we call

[PATCH] D58314: [Driver] Sync ARM behavior between clang-as and gas.

peter.smith added a comment. My main concern is that this changes the default behaviour for arm-linux-gnueabi and arm-linux-gnueabihf targets. I've put some suggestions on what I think the behaviour should be. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:277 + } + r

[PATCH] D58341: [clangd] Index UsingDecls

kadircet updated this revision to Diff 187376. kadircet marked an inline comment as done. kadircet added a comment. - Revert last change Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58341/new/ https://reviews.llvm.org/D58341 Files: unittests/cla

[PATCH] D58387: [clangd] Add an option in the code to not display number of fixes

ilya-biryukov created this revision. ilya-biryukov added reviewers: sammccall, ioeric. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Only to the APIs, which are used by our embedders. We do not plan to add a user-facing option for this. Repository

[PATCH] D58346: [Sema] Change addr space diagnostics in casts to follow C++ style

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: lib/Sema/SemaCast.cpp:2309 +auto DestPointeeTypeWithoutAS = Self.Context.removeAddrSpaceQualType( +DestPointeeType.getCanonicalType()); +return Self.Context.hasSameType(SrcPoi

[PATCH] D57660: [Sema] SequenceChecker: Handle references and members

riccibruno planned changes to this revision. riccibruno added a comment. This needs more work. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57660/new/ https://reviews.llvm.org/D57660 ___ cfe-commits mailing list cfe

[PATCH] D58388: [OpenCL] Simplify LLVM IR generated for OpenCL blocks

AlexeySotkin created this revision. AlexeySotkin added reviewers: Anastasia, yaxunl, svenvh. AlexeySotkin added a project: clang. Emit direct call of block invoke functions when possible, i.e. in case the block is not passed as a function argument. Also doing some refactoring of `CodeGenFunction::

[PATCH] D58343: Enablement for AMD znver2 architecture - skeleton patch

craig.topper added a comment. I think you uploaded the clang patch into the llvm review? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58343/new/ https://reviews.llvm.org/D58343 ___ cfe-commits mailing list cfe-commi

[clang-tools-extra] r354349 - [clangd] Add an option in the code to not display number of fixes

Author: ibiryukov Date: Tue Feb 19 08:50:37 2019 New Revision: 354349 URL: http://llvm.org/viewvc/llvm-project?rev=354349&view=rev Log: [clangd] Add an option in the code to not display number of fixes Summary: Only to the APIs, which are used by our embedders. We do not plan to add a user-facing

[PATCH] D58387: [clangd] Add an option in the code to not display number of fixes

This revision was automatically updated to reflect the committed changes. Closed by commit rL354349: [clangd] Add an option in the code to not display number of fixes (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to co

r354351 - Remove extraneous space in MSVC-style diagnostic output

Author: hans Date: Tue Feb 19 08:58:25 2019 New Revision: 354351 URL: http://llvm.org/viewvc/llvm-project?rev=354351&view=rev Log: Remove extraneous space in MSVC-style diagnostic output There was an extra space between the file location and the diagnostic message: /tmp/a.c(1,12): warning: un

[PATCH] D58344: Enablement for AMD znver2 architecture - skeleton

GGanesh updated this revision to Diff 187387. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58344/new/ https://reviews.llvm.org/D58344 Files: include/clang/Basic/X86Target.def lib/Basic/Targets/X86.cpp test/CodeGen/target-builtin-noerror.c test/Driver/x86-

[PATCH] D58343: Enablement for AMD znver2 architecture - skeleton patch

GGanesh updated this revision to Diff 187386. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58343/new/ https://reviews.llvm.org/D58343 Files: include/llvm/Support/X86TargetParser.def lib/Support/Host.cpp lib/Target/X86/X86.td test/CodeGen/X86/cpus-amd.ll

[PATCH] D58377: Remove extraneous space in MSVC-style diagnostic output

This revision was automatically updated to reflect the committed changes. Closed by commit rC354351: Remove extraneous space in MSVC-style diagnostic output (authored by hans, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D58377?vs=187320&id=18

[PATCH] D58343: Enablement for AMD znver2 architecture - skeleton patch

GGanesh updated this revision to Diff 187389. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58343/new/ https://reviews.llvm.org/D58343 Files: include/llvm/Support/X86TargetParser.def lib/Support/Host.cpp lib/Target/X86/X86.td test/CodeGen/X86/cpus-amd.ll

[PATCH] D58343: Enablement for AMD znver2 architecture - skeleton patch

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58343/new/ https://reviews.llvm.org/D58343 ___ cfe

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

tmroeder updated this revision to Diff 187393. tmroeder marked 6 inline comments as done. tmroeder added a comment. Thanks for the review and the suggestions for improving the tests. This update cleans up the tests as suggested. Repository: rC Clang CHANGES SINCE LAST ACTION https://review

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

tmroeder added inline comments. Comment at: test/ASTMerge/choose-expr/Inputs/choose1.c:1 +#define abs_int(x) __builtin_choose_expr( \ +__builtin_types_compatible_p(__typeof(x), unsigned int), \ a_sidorin wrote: > This test duplicates unit

[PATCH] D58293: [clang][Index] Enable indexing of Template Type Parameters behind a flag

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM, but see the comment about avoiding code duplication Comment at: lib/Index/IndexDecl.cpp:678 IndexCtx.indexTypeSourceInfo(TTP->getDefaultArgum

[PATCH] D58388: [OpenCL] Simplify LLVM IR generated for OpenCL blocks

AlexeySotkin updated this revision to Diff 187399. AlexeySotkin added a comment. Fix ObjC lit tests failure CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58388/new/ https://reviews.llvm.org/D58388 Files: lib/CodeGen/CGBlocks.cpp lib/CodeGen/CGOpenCLRuntime.cpp lib/CodeGen/CGOpenC

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

pgousseau updated this revision to Diff 187400. pgousseau added a comment. Updated to use an array as suggested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57914/new/ https://reviews.llvm.org/D57914 Files: include/clang/Basic/Attr.td include/clang/Basic/Sanitizers.def include/

[PATCH] D57450: [RISCV] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth for RV32/RV64 targets with atomics

jyknight added inline comments. Comment at: lib/Basic/Targets/RISCV.h:94 +if (HasA) + MaxAtomicPromoteWidth = MaxAtomicInlineWidth = 32; + } MaxAtomicPromoteWidth is an incompatible ABI-change kind of thing. We should set that to the maximum atomic siz

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

nemanjai added a comment. There is a long series of comments in this patch and I am not clear at this point on whether this patch breaks anything or it is fine. Could you please `Request Changes` if this patch is broken or approve if it is fine? Repository: rC Clang CHANGES SINCE LAST ACTIO

Re: r354075 - [clang][FileManager] fillRealPathName even if we aren't opening the file

I see. You're right the name sounds slow indeed. Thank you for the explanation! > On Feb 19, 2019, at 6:43 AM, Nico Weber wrote: > > I didn't realize it just copied a string. I just saw a call to > "fillRealPathName" and the "RealPath" bit sounded slow. From clicking around > in http://llvm-cs

[PATCH] D58243: [OPENMP] Delay emission of the asm target-specific error messages.

tra added inline comments. Comment at: lib/Sema/SemaStmtAsm.cpp:256-263 // If we're compiling CUDA file and function attributes indicate that it's not // for this compilation side, skip all the checks. if (!DeclAttrsMatchCUDAMode(getLangOpts(), getCurFunctionDecl())) {

[PATCH] D58392: [analyzer] MIGChecker: Fix false negatives for releases in automatic destructors.

NoQ created this revision. NoQ added a reviewer: dcoughlin. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. The problem that was fixed in D25326

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

tra added a subscriber: rsmith. tra added a comment. In D56411#1400300 , @rjmccall wrote: > Okay, but it's not great design to have a kind of overloading that can't be > resolved to an exact intended declaration even by an explicit cast. That's > why I

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

mgrang updated this revision to Diff 187418. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50488/new/ https://reviews.llvm.org/D50488 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/PointerSortingChecke

[PATCH] D58397: [analyzer] MIGChecker: Pour more data into the checker.

NoQ created this revision. NoQ added a reviewer: dcoughlin. Herald added subscribers: cfe-commits, jdoerfert, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Previous patches were about the infrastructure of the chec

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

mgrang added a comment. In D50488#1400823 , @whisperity wrote: > Yeah, it seems upstream has moved away due to @Szelethus' implementation of a > much more manageable "checker dependency" system. You most likely will have > to rebase your patch first, the

[PATCH] D58365: [attributes] Add a MIG server routine attribute.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:4047-4048 +that have their return value of type ``kern_return_t`` unconditionally returned +from the routine. The attribute can be applied to C++ methods, and in thi

[PATCH] D57662: [clang-tidy] Parallelise clang-tidy-diff.py

zinovy.nis updated this revision to Diff 187421. zinovy.nis added a comment. - `-j` is `1` by default; - fixed minor remarks; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57662/new/ https://reviews.llvm.org/D57662 Files: clang-tidy/tool/clang-tidy-diff.py Index: clang-tidy/tool/cla

[PATCH] D57977: [HIP] compile option code-object-v3 propagate to llc

ashi1 added a comment. This was submitted again with the fix. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57977/new/ https://reviews.llvm.org/D57977 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

riccibruno marked an inline comment as done. riccibruno added a comment. Looks mostly fine to me. I have added a few inline comments but they are all little nits. Comment at: include/clang/Basic/Sanitizers.h:39 +struct SanitizerMask { +private: + // Number of array elements.

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

vit9696 added a comment. This is a series of patches, which I believe should merged altogether. Currently the following patches are relevant: - https://reviews.llvm.org/D49754 - https://reviews.llvm.org/D54409 - https://reviews.llvm.org/D54583 - https://reviews.llvm.org/D56703 The patches are i

[PATCH] D58367: [analyzer] NFC: Improve upon the concept of BugReporterVisitor.

Szelethus added a comment. I love the idea! It looks way cleaner, tbh how messy visitors are have kept me away from implementing one for my own checker. Couple thoughts: 1. It would be great to have unit tests for this. Side note, I have already managed to make CSA unit tests tun under check-cl

[PATCH] D58243: [OPENMP] Delay emission of the asm target-specific error messages.

ABataev marked an inline comment as done. ABataev added inline comments. Comment at: lib/Sema/SemaStmtAsm.cpp:256-263 // If we're compiling CUDA file and function attributes indicate that it's not // for this compilation side, skip all the checks. if (!DeclAttrsMatchCUD

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

Szelethus added a comment. In D50488#1402699 , @mgrang wrote: > In D50488#1400823 , @whisperity > wrote: > > > Yeah, it seems upstream has moved away due to @Szelethus' implementation of > > a much more manageable

[PATCH] D58365: [attributes] Add a MIG server routine attribute.

aaron.ballman added a comment. > @aaron.ballman, are you actually interested in reviewing these attributes? > 'Cause George added you on his reviews but i totally understand that these > are fairly exotic. Yeah, I'd like to review these attributes -- thanks for double-checking with me! =

[PATCH] D58243: [OPENMP] Delay emission of the asm target-specific error messages.

tra added inline comments. Comment at: lib/Sema/SemaStmtAsm.cpp:256-263 // If we're compiling CUDA file and function attributes indicate that it's not // for this compilation side, skip all the checks. if (!DeclAttrsMatchCUDAMode(getLangOpts(), getCurFunctionDecl())) {

[PATCH] D58367: [analyzer] NFC: Improve upon the concept of BugReporterVisitor.

NoQ added a reviewer: Charusso. NoQ marked an inline comment as done. NoQ added a subscriber: Charusso. NoQ added a comment. In D58367#1402796 , @Szelethus wrote: > 2. I guess most of the visitors could be changed to this format, do you have > plans to co

[PATCH] D58404: [clang-format] Add basic support for formatting C# files

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: djasper, klimek, krasimir, benhamilton, JonasToth. MyDeveloperDay added a project: clang. Herald added subscribers: jdoerfert, mgorny. This revision adds basic support for formatting C# files with clang-format, I know the barr

[PATCH] D58243: [OPENMP] Delay emission of the asm target-specific error messages.

kkwli0 added a comment. The change looks okay to me. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58243/new/ https://reviews.llvm.org/D58243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D54880: Ignore gcc's stack-clash-protection flag

tstellar added a comment. Herald added a project: clang. See D42593 , I don't think it's good to ignore security flags like this. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54880/new/ https://reviews.llvm.org/D54880 ___

[PATCH] D42593: GCC compatibility: Ignore -fstack-clash-protection

tstellar abandoned this revision. tstellar added a comment. Herald added a subscriber: jdoerfert. Herald added a project: clang. I agree with Joerg, I don't think we should be ignoring these kinds of security flags (even though we already ignore -fstack-check). Repository: rC Clang CHANGES S

[PATCH] D58375: [Clang][NewPM] Disable tests that are broken under new PM

efriedma added a comment. I can understand why tests that use -O1 or -O2 would produce different results with the new pass manager, but it looks like not all the tests are like that. Do you know why those tests are failing? For the tests that do use -O, instead of marking them unsupported, cou

[PATCH] D58065: [analyzer] Document the frontend library

mgrang added inline comments. Comment at: docs/analyzer/developer-docs/FrontendLibrary.rst:12 +This document will describe the frontend of the Static Analyzer, basically +everything from compiling the analyzer from source, through it's invocation up +to the beginning of the analy

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

mgrang updated this revision to Diff 187466. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50488/new/ https://reviews.llvm.org/D50488 Files: docs/analyzer/checkers.rst include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

mgrang added a comment. > It's because it invokes CodeChecker, which by default enables > valist.Uninitialized, but not ValistBase. Do you have assert failures after > my hotfix? @Szelethus Thanks. I run into this assert when run through CodeChecker: Assertion `CheckerTags.count(tag) != 0 &&

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

mgrang added a comment. Also I don't see the helptext for PointerSorting when I run: clang -cc1 -analyzer-checker-help | grep Pointer alpha.core.PointerArithmCheck for pointer arithmetic on locations other than array elements alpha.core.PointerSub Check for pointer

  1   2   >