[PATCH] D57910: [ASTImporter] Find previous friend function template

a_sidorin accepted this revision. a_sidorin added a comment. Hi Gabor, This patch LGTM with a minor nit. Comment at: unittests/AST/ASTImporterTest.cpp:5109 + // Currently chains of FunctionTemplateDecls are not implemented + //EXPECT_EQ(Imported->getPreviousDecl(), Friend); +

[PATCH] D57236: [ASTImporter] Unify redecl chain tests as type parameterized tests

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. Thanks for the changes! The patch looks completely fine to me now. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57236/new/ https://reviews.llvm.org/D572

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

a_sidorin requested changes to this revision. a_sidorin added a comment. This revision now requires changes to proceed. Hi Tom, The change looks reasonable but the tests need some improvements. Comment at: test/ASTMerge/choose-expr/Inputs/choose1.c:1 +#define abs_int(x) __built

r354201 - Move multiline raw string literal out of macro. NFC

Author: dmgreen Date: Sat Feb 16 03:19:04 2019 New Revision: 354201 URL: http://llvm.org/viewvc/llvm-project?rev=354201&view=rev Log: Move multiline raw string literal out of macro. NFC Certain combinations of gcc and ccache fail when the raw string literal is preprocessed. This just moves the st

[PATCH] D58322: remove microsoft intrinsics test that passes on osx but fails on linux

davidb created this revision. Herald added subscribers: cfe-commits, jdoerfert. Herald added a project: clang. davidb abandoned this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D58322 Files: clang/test/CodeGen/ms-x86-intrinsics.c Index: clang/test/CodeGen/ms-x86-i

Re: [PATCH] D56850: [ASTMatchers][NFC] Add tests for assorted `CXXMemberCallExpr` matchers.

FWIW, this was fixed by SVN r354201. Thanks David! // Martin On Sat, 16 Feb 2019, Martin Storsjö via cfe-commits wrote: It broke on the first commit and is broken even after all of them. // Martin On Fri, 15 Feb 2019, Yitzhak Mandelbaum wrote: Was it the complete diff or one of the interme

[PATCH] D58137: [clang-tidy] Add the abseil-time-subtraction check

JonasToth added inline comments. Comment at: clang-tidy/abseil/DurationRewriter.cpp:92 + DurationScale Scale, const Expr &Node) { + const llvm::StringRef &InverseFunction = getTimeInverseForScale(Scale); + if (const auto *MaybeCallArg = selectFirst( --

[PATCH] D58137: [clang-tidy] Add the abseil-time-subtraction check

Eugene.Zelenko added inline comments. Comment at: clang-tidy/abseil/TimeSubtractionCheck.cpp:72 + +// Match the cases where we know that the result is a Duration and the first +// argument is a Time. Just knowing the type of the first operand is not Jon

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

jacob-keller added a comment. Is there anything holding this up that could use help? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D28462/new/ https://reviews.llvm.org/D28462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D58324: Enable esan for the cache frag support

devnexen created this revision. devnexen added a reviewer: bsdjhb. devnexen created this object with visibility "All Users". Herald added subscribers: cfe-commits, emaste. Herald added a project: clang. Repository: rC Clang https://reviews.llvm.org/D58324 Files: lib/Driver/ToolChains/FreeBSD

[PATCH] D58137: [clang-tidy] Add the abseil-time-subtraction check

JonasToth added inline comments. Comment at: clang-tidy/abseil/TimeSubtractionCheck.cpp:72 + +// Match the cases where we know that the result is a Duration and the first +// argument is a Time. Just knowing the type of the first operand is not Eugene.Z

[PATCH] D54176: [PGO] clang part of change for context-sensitive PGO.

tejohnson added a comment. Herald added a subscriber: jdoerfert. LGTM except for place noted below where I disagree with a change made earlier. Will let @davidxl chime in if he disagrees with me or has any other comments. Comment at: lib/CodeGen/BackendUtil.cpp:967 + if (Code

[PATCH] D58325: [Driver][Fuchsia] Support -nolibc flag

phosek created this revision. phosek added reviewers: jakehehrlich, juliehockett, mcgrathr. Herald added a project: clang. Herald added a subscriber: cfe-commits. This can be used to disable libc linking. This flag is supported by GCC since version 8.x as well as some Clang target toolchains. Re

[PATCH] D58325: [Driver][Fuchsia] Support -nolibc flag

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. This is only on GCC trunk (i.e. 9), not in 8.2 or even the current gcc-8 branch. So clarify the log entry. We don't know if 8.x,x>2 will add it or only gcc 9. Repository: rC Clang C

[PATCH] D58325: [Driver][Fuchsia] Support -nolibc flag

phosek updated this revision to Diff 187149. phosek edited the summary of this revision. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58325/new/ https://reviews.llvm.org/D58325 Files: clang/lib/Driver/ToolChains/Fuchsia.cpp clang/test/Driver/fuchsia.c clang

r354208 - [Driver][Fuchsia] Support -nolibc flag

Author: phosek Date: Sat Feb 16 17:02:40 2019 New Revision: 354208 URL: http://llvm.org/viewvc/llvm-project?rev=354208&view=rev Log: [Driver][Fuchsia] Support -nolibc flag This can be used to disable libc linking. This flag is supported by GCC since version 9 as well as some Clang target toolchai

[PATCH] D58325: [Driver][Fuchsia] Support -nolibc flag

This revision was automatically updated to reflect the committed changes. Closed by commit rL354208: [Driver][Fuchsia] Support -nolibc flag (authored by phosek, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.o

[PATCH] D58326: [Driver][Gnu] Support -nolibc flag

phosek created this revision. phosek added reviewers: echristo, mcgrathr. Herald added a project: clang. Herald added a subscriber: cfe-commits. This can be used to disable libc linking. This flag is supported by GCC since version 9 as well as some Clang target toolchains. Repository: rC Clang

Re: [PATCH] D58326: [Driver][Gnu] Support -nolibc flag

Weird. Ok. On Sat, Feb 16, 2019, 5:20 PM Petr Hosek via Phabricator < revi...@reviews.llvm.org> wrote: > phosek created this revision. > phosek added reviewers: echristo, mcgrathr. > Herald added a project: clang. > Herald added a subscriber: cfe-commits. > > This can be used to disable libc link

r354210 - [Driver][Gnu] Support -nolibc flag

Author: phosek Date: Sat Feb 16 18:42:48 2019 New Revision: 354210 URL: http://llvm.org/viewvc/llvm-project?rev=354210&view=rev Log: [Driver][Gnu] Support -nolibc flag This can be used to disable libc linking. This flag is supported by GCC since version 9 as well as some Clang target toolchains.

[PATCH] D58326: [Driver][Gnu] Support -nolibc flag

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL354210: [Driver][Gnu] Support -nolibc flag (authored by phosek, committed by ). Herald added a project: LLVM. Herald added

r354211 - [X86] Prevent clang clobber checking for asm flag constraints.

Author: niravd Date: Sat Feb 16 19:53:23 2019 New Revision: 354211 URL: http://llvm.org/viewvc/llvm-project?rev=354211&view=rev Log: [X86] Prevent clang clobber checking for asm flag constraints. Update getConstraintRegister as X86 Asm flag output constraints are no longer fully alphanumeric, Mo