[PATCH] D53633: [AArch64] Implement FP16FML intrinsics

ab added inline comments. Comment at: cfe/trunk/test/CodeGen/aarch64-neon-fp16fml.c:12 + +float32x2_t test_vfmlal_low_u32(float32x2_t a, float16x4_t b, float16x4_t c) { +// CHECK-LABEL: define <2 x float> @test_vfmlal_low_u32(<2 x float> %a, <4 x half> %b, <4 x half> %c) ---

[PATCH] D57075: [ObjC] For type substitution in generics use a regular recursive type visitor.

This revision was automatically updated to reflect the committed changes. Closed by commit rL354180: [ObjC] For type substitution in generics use a regular recursive type visitor. (authored by vsapsai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

r354180 - [ObjC] For type substitution in generics use a regular recursive type visitor.

Author: vsapsai Date: Fri Feb 15 14:14:58 2019 New Revision: 354180 URL: http://llvm.org/viewvc/llvm-project?rev=354180&view=rev Log: [ObjC] For type substitution in generics use a regular recursive type visitor. Switch to the inheritance-based visitor from the lambda-based visitor to allow both

[PATCH] D58297: [Sema] SequenceChecker: C++17 sequencing rules for built-in operators <<, >>, .*, ->*, =, op=

riccibruno updated this revision to Diff 187089. riccibruno added a comment. 1. Only call `note{Pre,Post}{Use, Mod}` if we have a valid memory location. 2. Fixed 2 tests in `CXX/drs` which I initially missed. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58297/new

[PATCH] D57659: [Sema] SequenceChecker: Add some comments + related small NFCs in preparation of the following patches

riccibruno updated this revision to Diff 187090. riccibruno marked an inline comment as done. riccibruno added a comment. Rebased and fixed a comment. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57659/new/ https://reviews.llvm.org/D57659 Files: lib/Sema/Sema

Re: [PATCH] D56850: [ASTMatchers][NFC] Add tests for assorted `CXXMemberCallExpr` matchers.

It broke on the first commit and is broken even after all of them. // Martin On Fri, 15 Feb 2019, Yitzhak Mandelbaum wrote: Was it the complete diff or one of the intermediate commits? I accidentally committed the diff as a series of commits rather than one (squashed) commit.  On Fri, Feb 15,

[PATCH] D58307: [Clang Driver] Add support for "-static-pie" argument to the Clang driver.

sivachandra created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change mimics GCC's support for the "-static-pie" argument. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D58307 Files: clang/include/clang/Driver/Options.td clan

r354183 - clang-format with UseTab: Always sometimes doesn't insert the right amount of tabs.

Author: alexfh Date: Fri Feb 15 15:07:43 2019 New Revision: 354183 URL: http://llvm.org/viewvc/llvm-project?rev=354183&view=rev Log: clang-format with UseTab: Always sometimes doesn't insert the right amount of tabs. Trailing comments are not always aligned properly when UseTab is set to Always.

[PATCH] D57655: clang-format with UseTab: Always sometimes doesn't insert the right amount of tabs.

This revision was automatically updated to reflect the committed changes. Closed by commit rC354183: clang-format with UseTab: Always sometimes doesn't insert the right amount of… (authored by alexfh, committed by ). Changed prior to commit: https://reviews.llvm.org/D57655?vs=186629&id=187096#t

[PATCH] D57112: [ASTTypeTraits] OMPClause handling

alexfh added a comment. In D57112#1399516 , @lebedev.ri wrote: > Ping @hokein / @alexfh (as per git blame). > Not sure who is best suited to review this. I only made a couple of random fixes to these files, so I don't feel particularly competent to rev

[PATCH] D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. In D58074#1399881 , @lildmh wrote: > Thanks for the catch! I also change the name from `OMPMappableExprListLocTy` > to `OMPVarListLocTy` to be more a

[PATCH] D57662: [clang-tidy] Parallelise clang-tidy-diff.py

alexfh added inline comments. Comment at: clang-tidy/tool/clang-tidy-diff.py:98 + parser.add_argument('-j', type=int, default=0, + help='number of tidy instances to be run in parallel.') zinovy.nis wrote: > alexfh wrote: > > The "clang-tid

[PATCH] D58236: Make address space conversions a bit stricter.

rjmccall added inline comments. Comment at: lib/Sema/SemaCast.cpp:2306 + SrcPPointee.getAddressSpace()) || + !DestPPtr->isAddressSpaceOverlapping(*SrcPPtr)) { +Self.Diag(OpRange.getBegin(), This should `if (Nested ? DestPPoint

Re: r354091 - Fix implementation of [temp.local]p4.

> On Feb 15, 2019, at 1:53 PM, Richard Smith wrote: > > On Fri, 15 Feb 2019 at 09:56, Richard Smith > wrote: >> >> On Thu, 14 Feb 2019, 18:35 Francis Visoiu Mistrih via cfe-commits, >> wrote: >>> >>> Hi Richard, >>> >>> This seems to now emit an error when bu

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

mgrang added a comment. I hacked around the run_experiments.py to set CMAKE_C_FLAGS and now I see the following error in stats.html. Note: I see the same error with an existing checker like PointerArithmChecker. And I do not hit this assert when I run the checker outside of csa-testbench. As

[PATCH] D57579: [analyzer][WIP] Enable subcheckers to possess checker options

NoQ accepted this revision. NoQ added a comment. Herald added a subscriber: jdoerfert. > since I couldn't reproduce the error Me neither, actually :/ This patch does provide a backup plan and it makes the code prettier, so we should definitely land it and i'm really greatful for it, but the opt

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

yaxunl added a comment. In D56411#1398586 , @rjmccall wrote: > But what we've just been talking about is not a validity rule, it's an > overload-resolution rule. It's not *invalid* to use a device function as a > template argument to a host function tem

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

tmroeder added a comment. In D58292#1399774 , @shafik wrote: > This looks reasonable, I will wait for @martong and/or @a_sidorin to review. > > FYI LLDB is the other big user of ASTImpoter so it is helpful if you can run > `check-lldb` especially on MacOS

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

tmroeder updated this revision to Diff 187113. tmroeder added a comment. Updated Registry.cpp, regenerated the documentation, and added direct tests for the matcher. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58292/new/ https://reviews.llvm.org/D58292 Files:

[PATCH] D58065: [analyzer] Document the frontend library

NoQ added a comment. Had a look. Great stuff, just as planned :) Old fanboy wisdom: Try to avoid documenting bugs you want to fix! But i don't have many high-level comments here - only appreciation of the effort. In D58065#1394864 , @Szelethus wrote: >

r354189 - [ObjC generics] Fix applying `__kindof` to the type parameter.

Author: vsapsai Date: Fri Feb 15 17:01:08 2019 New Revision: 354189 URL: http://llvm.org/viewvc/llvm-project?rev=354189&view=rev Log: [ObjC generics] Fix applying `__kindof` to the type parameter. Fixes the warning about incompatible pointer types on assigning to a subclass of type argument an ex

[PATCH] D58314: [Driver] Sync ARM behavior between clang-as and gas.

danalbert created this revision. danalbert added reviewers: peter.smith, kristof.beyls, srhines, pirama. Herald added a subscriber: javed.absar. Herald added a project: clang. The ARM gas driver previously enabled NEON for ARMv7 and up, and a handful of other extensions for ARMv8 and up (although

[PATCH] D57076: [ObjC generics] Fix applying `__kindof` to the type parameter.

This revision was automatically updated to reflect the committed changes. vsapsai marked an inline comment as done. Closed by commit rC354189: [ObjC generics] Fix applying `__kindof` to the type parameter. (authored by vsapsai, committed by ). Herald added a subscriber: jdoerfert. Herald added a p

[PATCH] D57075: [ObjC] For type substitution in generics use a regular recursive type visitor.

vsapsai added a comment. Thanks for the review, Erik. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57075/new/ https://reviews.llvm.org/D57075 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D58254: [Sema] Diagnose floating point conversions based on target semantics

This revision was automatically updated to reflect the committed changes. Closed by commit rC354190: [Sema] Diagnose floating point conversions based on target semantics (authored by epilk, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D58254?v

r354190 - [Sema] Diagnose floating point conversions based on target semantics

Author: epilk Date: Fri Feb 15 17:11:47 2019 New Revision: 354190 URL: http://llvm.org/viewvc/llvm-project?rev=354190&view=rev Log: [Sema] Diagnose floating point conversions based on target semantics ...instead of just comparing rank. Also, fix a bad warning about _Float16, since its declared ou

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

rsmith added inline comments. Herald added a reviewer: martong. Comment at: lib/AST/StmtProfile.cpp:324 VisitStringLiteral(S->getClobberStringLiteral(I)); + ID.AddInteger(S->getNumLabels()); } Don't we also need to profile the labels themselves?

[PATCH] D58317: [clang] Add install targets for development headers

smeenai added a comment. I'm not entirely happy with the name clang-dev-headers, and am open to suggestions. It's unfortunate clang-headers was already taken for something different, but renaming that target or increasing its scope seems bad for existing users. Other possibilities I thought of

[PATCH] D58317: [clang] Add install targets for development headers

smeenai created this revision. smeenai added reviewers: beanz, phosek. Herald added subscribers: jdoerfert, mgorny. Herald added a project: clang. smeenai added a comment. I'm not entirely happy with the name clang-dev-headers, and am open to suggestions. It's unfortunate clang-headers was alread

r354192 - Fix some tests I broke in r354190

Author: epilk Date: Fri Feb 15 17:51:19 2019 New Revision: 354192 URL: http://llvm.org/viewvc/llvm-project?rev=354192&view=rev Log: Fix some tests I broke in r354190 This was breaking on MSVC, since long double and double have the same semantics there. Modified: cfe/trunk/test/Misc/warn-in-s

[PATCH] D58121: [analyzer][WIP] Attempt to fix traversing bindings of non-base regions in ClusterAnalysis

NoQ added a comment. After staring at this for an hour or two, i didn't manage to force myself to understand how our cluster analysis works here, but i totally agree that it's most likely broken; i guess, we should eventually move away from the idea that everything works through base regions, b

[PATCH] D57850: [analyzer] Emit an error rather than assert on invalid checker option input

NoQ added inline comments. Herald added a subscriber: jdoerfert. Comment at: lib/StaticAnalyzer/Checkers/PaddingChecker.cpp:352-355 + if (Checker->AllowedPad < 0) + Mgr.getDiagnostics().Report(diag::err_analyzer_checker_option_invalid_input) +<< (llvm::Twine() + Chec

[PATCH] D58289: [clang] Only provide C11 features in starting with C++17

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58289/new/ https://reviews.llvm.org/D58289 ___ cfe-commit

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

rjmccall added a comment. It is totally unreasonable, at the time you are resolving a template argument, to investigate how the corresponding template parameter is used within the template and use that to shape how the template argument is resolved. That is simply not how the C++ template mode

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

jyu2 added inline comments. Comment at: lib/AST/StmtProfile.cpp:324 VisitStringLiteral(S->getClobberStringLiteral(I)); + ID.AddInteger(S->getNumLabels()); } rsmith wrote: > Don't we also need to profile the labels themselves? How this can be lost? :-( Ch

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

jyu2 updated this revision to Diff 187124. jyu2 marked 5 inline comments as done. jyu2 added a comment. Herald added a subscriber: rnkovacs. Review comments addressed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56571/new/ https://reviews.llvm.org/D56571 Files: include/clang/AST/St

[PATCH] D57080: [clang-tidy] Delete obsolete objc-property-declaration options ✂️

This revision was automatically updated to reflect the committed changes. Closed by commit rL354195: [clang-tidy] Delete obsolete objc-property-declaration options ✂️ (authored by stephanemoore, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior t

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

yaxunl added a comment. In D56411#1400251 , @rjmccall wrote: > It is totally unreasonable, at the time you are resolving a template > argument, to investigate how the corresponding template parameter is used > within the template and use that to shape ho

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

rjmccall added a comment. Okay, but it's not great design to have a kind of overloading that can't be resolved to an exact intended declaration even by an explicit cast. That's why I think making *optional* host/device typing is a good idea. And I strongly want to caution you against doing la

[PATCH] D58320: [Darwin] Introduce a new flag, -flink-builtins-rt that forces linking of the builtins library.

aemerson created this revision. aemerson added reviewers: peter.smith, dexonsmith, ab. aemerson added a project: clang. Herald added subscribers: jdoerfert, jfb. This driver flag is useful when users want to link against the compiler's builtins, but nothing else, and so use flags like -nostdlib.

[PATCH] D58321: [WIP] Support for relative vtables

leonardchan created this revision. Herald added subscribers: cfe-commits, jdoerfert. Herald added a project: clang. This is a revisit to D20749 which introduces a flag that enables the relative ABI described in https://bugs.llvm.org/show_bug.cgi?id=26723. Repo

<    1   2