[PATCH] D57787: [clang-tidy] modernize-avoid-c-arrays: avoid main function (PR40604)

lebedev.ri added inline comments. Comment at: clang-tidy/modernize/AvoidCArraysCheck.cpp:35 + const clang::DeclContext *DC = Node.getDeclContext(); + const clang::FunctionDecl *FD = llvm::dyn_cast(DC); + if (!FD) lebedev.ri wrote: > JonasToth wrote: > > There

[PATCH] D57787: [clang-tidy] modernize-avoid-c-arrays: avoid main function (PR40604)

lebedev.ri updated this revision to Diff 185499. lebedev.ri added a comment. Add an assert to ensure that `clang::FunctionDecl::castFromDeclContext()` is safe to do. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57787/new/ https://reviews.llvm.org/

[PATCH] D57021: [clangd] Suggest adding missing includes for typos (like include-fixer).

sammccall added inline comments. Comment at: clangd/IncludeFixer.cpp:209 + std::vector Scopes; + if (Typo.SS) { +Scopes.push_back(*Typo.SS); ioeric wrote: > sammccall wrote: > > why do we do this here rather than compute the scopes/name already in > > Corr

[PATCH] D57755: [clangd] Some minor fixes.

This revision was automatically updated to reflect the committed changes. Closed by commit rL353283: [clangd] Some minor fixes. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://re

[clang-tools-extra] r353283 - [clangd] Some minor fixes.

Author: hokein Date: Wed Feb 6 01:08:26 2019 New Revision: 353283 URL: http://llvm.org/viewvc/llvm-project?rev=353283&view=rev Log: [clangd] Some minor fixes. Reviewers: ilya-biryukov Subscribers: ioeric, MaskRay, jkorous, arphaman, kadircet, cfe-commits Tags: #clang Differential Revision: ht

[clang-tools-extra] r353284 - [clangd] Add CLI flag "-clang-tidy" to enable/disable running clang-tidy checks.

Author: hokein Date: Wed Feb 6 01:10:47 2019 New Revision: 353284 URL: http://llvm.org/viewvc/llvm-project?rev=353284&view=rev Log: [clangd] Add CLI flag "-clang-tidy" to enable/disable running clang-tidy checks. Reviewers: sammccall Subscribers: ilya-biryukov, ioeric, MaskRay, jkorous, arphama

[PATCH] D57746: [clangd] Add CLI flag "-clang-tidy" to enable/disable running clang-tidy checks.

This revision was automatically updated to reflect the committed changes. Closed by commit rL353284: [clangd] Add CLI flag "-clang-tidy" to enable/disable running clang-tidy checks. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Reposit

[PATCH] D57746: [clangd] Add CLI flag "-clang-tidy" to enable/disable running clang-tidy checks.

hokein updated this revision to Diff 185505. hokein marked an inline comment as done. hokein added a comment. Set the flag to false by default. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57746/new/ https://reviews.llvm.org/D57746 Files: clangd

[PATCH] D57768: [SYCL] Add SYCL device compilation flow.

Naghasan accepted this revision. Naghasan added a subscriber: Anastasia. Naghasan added a comment. LGTM Side note: might be good to also involve @Anastasia, as some of the future patches will overlap with OpenCL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D57787: [clang-tidy] modernize-avoid-c-arrays: avoid main function (PR40604)

JonasToth added inline comments. Comment at: clang-tidy/modernize/AvoidCArraysCheck.cpp:35 + const clang::DeclContext *DC = Node.getDeclContext(); + const clang::FunctionDecl *FD = llvm::dyn_cast(DC); + if (!FD) lebedev.ri wrote: > lebedev.ri wrote: > > JonasT

[PATCH] D57740: [ASTImporter] Import every Decl in lambda record

gamesh411 updated this revision to Diff 185509. gamesh411 added a comment. Remove unnecessary ToTU variable from test case. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57740/new/ https://reviews.llvm.org/D57740 Files: lib/AST/ASTImporter.cpp unittests/AST/

[libunwind] r353287 - Merging r352016:

Author: hans Date: Wed Feb 6 02:22:11 2019 New Revision: 353287 URL: http://llvm.org/viewvc/llvm-project?rev=353287&view=rev Log: Merging r352016: r352016 | phosek | 2019-01-24 04:04:42 +0100 (Thu, 24 Jan 2019) | 12 lines [

Re: [libunwind] r352016 - [libunwind] Don't abort if encoutering invalid .eh_frame_hdr

It seems like a good change, so merged in r353287. Please let me know if you have any concerns. On Tue, Jan 29, 2019 at 3:11 PM Hans Wennborg wrote: > > Should we merge this to 8.0? > > On Wed, Jan 23, 2019 at 10:04 PM Petr Hosek via cfe-commits > wrote: > > > > Author: phosek > > Date: Wed Jan

[PATCH] D57427: [CodeGen][ObjC] Fix assert on calling `__builtin_constant_p` with ObjC objects.

hans added a comment. What's the status of this patch? Is it something we should merge onto the 8.0 release branch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57427/new/ https://reviews.llvm.org/D57427 ___ cfe-commits mailing list cfe-c

[PATCH] D57768: [SYCL] Add SYCL device compilation flow.

bader added a comment. In D57768#1386754 , @Naghasan wrote: > LGTM > > Side note: might be good to also involve @Anastasia, as some of the future > patches will overlap with OpenCL. Sure. I'll add @Anastasia as a reviewer to the relevant patches. Thank

[PATCH] D57464: Generalize method overloading on addr spaces to C++

ebevhan added a comment. In D57464#1386614 , @rjmccall wrote: > Moving parsed attributes between lists isn't unreasonable if that's what you > have to do; we already do that when processing the ObjC ARC qualifiers. The > ambiguity with function attribut

[PATCH] D57813: [clangd] Enable clangd on ObjC in VSCode

ilya-biryukov created this revision. ilya-biryukov added a reviewer: hokein. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric. Herald added a project: clang. Thanks to Andreas Ostermeyer for raising this on the mailing list. Repository: rG LLVM Github Monorepo https://re

[PATCH] D57814: [clangd] Update clangd-vscode dependencies

ilya-biryukov created this revision. ilya-biryukov added a reviewer: hokein. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric, dschuff. Herald added a project: clang. Also add 'package-lock.json' to the repo, it's a common practice to check in those files into the repository.

[PATCH] D57814: [clangd] Update clangd-vscode dependencies

ilya-biryukov added a comment. Update the description to add some context Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57814/new/ https://reviews.llvm.org/D57814 ___ cfe-commits mailing list cfe-commi

[PATCH] D57768: [SYCL] Add SYCL device compilation flow.

Anastasia added subscribers: rjmccall, rsmith. Anastasia added a comment. In D57768#1386791 , @bader wrote: > In D57768#1386754 , @Naghasan wrote: > > > LGTM > > > > Side note: might be good to also involve @Anastas

[PATCH] D57739: [clangd] Format tweak's replacements.

hokein updated this revision to Diff 185529. hokein added a comment. Move format to the tweak. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57739/new/ https://reviews.llvm.org/D57739 Files: clangd/ClangdServer.cpp clangd/ClangdUnit.cpp clang

[PATCH] D57739: [clangd] Format tweak's replacements.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clangd/refactor/Tweak.h:81 + /// EXPECTS: prepare() was called and returned true. + virtual Expected execute(const Selection &Sel) = 0; }; I think the current name is slightly b

[PATCH] D57813: [clangd] Enable clangd on Objective-C in VSCode

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57813/new/ https://reviews.llvm.org/D57813

[PATCH] D57814: [clangd] Update clangd-vscode dependencies

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. This patch updates **dev** dependencies, please correct the commit title to avoid confusion :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D578

[PATCH] D57739: [clangd] Format tweak's replacements.

ilya-biryukov added inline comments. Comment at: clangd/refactor/Tweak.h:56 +/// The style to format generated changes. +format::FormatStyle Style; }; NIT: Maybe make this a second argument of `apply`? This would convey the idea that `execute()` should

[PATCH] D57764: [AArch64] Add Cortex-A76 and Cortex-A76AE Support

olista01 accepted this revision. olista01 added a comment. This revision is now accepted and ready to land. LGTM, but please remember to upload with more context. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57764/new/ https://reviews.llvm.org/D57764

[PATCH] D57768: [SYCL] Add SYCL device compilation flow.

ABataev requested changes to this revision. ABataev added a comment. This revision now requires changes to proceed. This definitely requires a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57768/new/ https://reviews.llvm.org/D57768 ___

[PATCH] D57765: [ARM] Add Cortex-M35P Support

olista01 requested changes to this revision. olista01 added inline comments. This revision now requires changes to proceed. Comment at: test/Driver/arm-cortex-cpus.c:826 // RUN: %clang -target arm -mcpu=cortex-m33 -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-CPUV8MMAIN %s +/

[PATCH] D57787: [clang-tidy] modernize-avoid-c-arrays: avoid main function (PR40604)

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/AvoidCArraysCheck.cpp:35 + const clang::DeclContext *DC = Node.getDeclContext(); + const clang::FunctionDecl *FD = llvm::dyn_cast(DC); + if (!FD) JonasToth wrote: > lebedev.ri wrote: > > leb

[PATCH] D57739: [clangd] Format tweak's replacements.

ilya-biryukov added inline comments. Comment at: clangd/refactor/Tweak.h:81 + /// EXPECTS: prepare() was called and returned true. + virtual Expected execute(const Selection &Sel) = 0; }; hokein wrote: > I think the current name is slightly better than `doAppl

[PATCH] D57768: [SYCL] Add SYCL device compilation flow.

bader added a comment. In D57768#1386924 , @ABataev wrote: > This definitely requires a test. @ABataev, I tried to find some tests on similar `-fcuda-is-device` and `-fopenmp-is-device` options, but I wasn't able to find a dedicated test. Could you sug

[PATCH] D57739: [clangd] Format tweak's replacements.

hokein updated this revision to Diff 185530. hokein marked 3 inline comments as done. hokein added a comment. Address review comments. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57739/new/ https://reviews.llvm.org/D57739 Files: clangd/ClangdSe

[PATCH] D57768: [SYCL] Add SYCL device compilation flow.

ABataev added a comment. In D57768#1386933 , @bader wrote: > In D57768#1386924 , @ABataev wrote: > > > This definitely requires a test. > > > @ABataev, I tried to find some tests on similar `-fcuda-is-device` and >

[PATCH] D57739: [clangd] Format tweak's replacements.

hokein updated this revision to Diff 185531. hokein added a comment. Add missing file. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57739/new/ https://reviews.llvm.org/D57739 Files: clangd/ClangdServer.cpp clangd/ClangdUnit.cpp clangd/Compil

[PATCH] D57739: [clangd] Format tweak's replacements.

hokein added inline comments. Comment at: clangd/refactor/Tweak.h:56 +/// The style to format generated changes. +format::FormatStyle Style; }; ilya-biryukov wrote: > NIT: Maybe make this a second argument of `apply`? > This would convey the idea that

[clang-tools-extra] r353295 - [clangd] Enable clangd on Objective-C in VSCode

Author: ibiryukov Date: Wed Feb 6 05:47:49 2019 New Revision: 353295 URL: http://llvm.org/viewvc/llvm-project?rev=353295&view=rev Log: [clangd] Enable clangd on Objective-C in VSCode Summary: Thanks to Andreas Ostermeyer for raising this on the mailing list. Reviewers: hokein Reviewed By: hoke

[PATCH] D57814: [clangd] Update dev dependencies of clangd-vscode

ilya-biryukov added a comment. In D57814#1386902 , @hokein wrote: > This patch updates **dev** dependencies, please correct the commit title to > avoid confusion :) Done, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D57813: [clangd] Enable clangd on Objective-C in VSCode

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE353295: [clangd] Enable clangd on Objective-C in VSCode (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D57813?vs=185518&id=185534#toc Repository: rCTE Cla

[PATCH] D57815: [clangd] Add type boost to fuzzy find in Dex.

ioeric created this revision. ioeric added reviewers: sammccall, ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. No noticeable impact on code completions overall except some improvement on cross-namespace completion. Repo

[clang-tools-extra] r353296 - [clangd] Update dev dependencies of clangd-vscode

Author: ibiryukov Date: Wed Feb 6 05:53:24 2019 New Revision: 353296 URL: http://llvm.org/viewvc/llvm-project?rev=353296&view=rev Log: [clangd] Update dev dependencies of clangd-vscode Summary: The version bumps are a result of running `npm audit`, which found 3 security issues in previous versi

[PATCH] D57814: [clangd] Update dev dependencies of clangd-vscode

This revision was automatically updated to reflect the committed changes. Closed by commit rL353296: [clangd] Update dev dependencies of clangd-vscode (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

kees added a comment. Not sure if this is the fault of the LLVM half or the Clang half, but I'm seeing mis-compilations in the current patches (llvm ca1e713fdd4fab5273b36ba6f292a844fca4cb2d with D53765 .185490 and clang 01879634f01bdbfac4636ebe03b68e85b20cd664

[PATCH] D57815: [clangd] Add type boost to fuzzy find in Dex.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clangd/index/Index.h:457 std::vector ProximityPaths; - - // FIXME(ibiryukov): add expected type to the request. + /// Preferred types of symbols. +

[PATCH] D57674: [clang-tidy] Add options to bugprone-argument-comment to add missing argument comments to literals

aaron.ballman added inline comments. Comment at: clang-tidy/bugprone/ArgumentCommentCheck.cpp:228-236 +static bool isStringLiteral(const Expr *Arg) { + const auto *Cast = dyn_cast(Arg); + return Cast ? isa(Cast->getSubExpr()) : false; +} + +static bool isNullPtrLiteral(const Ex

[PATCH] D57267: [AST] Factor out the logic of the various Expr::Ignore*

riccibruno updated this revision to Diff 185539. riccibruno added a comment. Go back to using `dyn_cast`s. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57267/new/ https://reviews.llvm.org/D57267 Files: include/clang/AST/Expr.h lib/AST/Expr.cpp Index: lib/A

[PATCH] D45978: dllexport const variables must have external linkage.

zahiraam updated this revision to Diff 185541. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D45978/new/ https://reviews.llvm.org/D45978 Files: lib/Sema/SemaDecl.cpp test/Sema/dllexport-1.cpp test/Sema/dllexport-2.cpp Index: test/Sema/dllexport-2.cpp ==

[PATCH] D45978: dllexport const variables must have external linkage.

zahiraam added a comment. > That seems like a reasonable place to try, to me. Ok. Let's see if this does the trick. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D45978/new/ https://reviews.llvm.org/D45978 ___ cfe-commits mailing

[PATCH] D57739: [clangd] Format tweak's replacements.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM! Also a few NITs. Comment at: clangd/ClangdServer.cpp:155 Opts.ClangTidyOpts = ClangTidyOptProvider->getOptions(File); + // FIXME: cache this + Opts

[PATCH] D54295: [WIP, RISCV] Add inline asm constraint A for RISC-V

jrtc27 requested changes to this revision. jrtc27 added inline comments. This revision now requires changes to proceed. Herald added a project: clang. Comment at: test/CodeGen/riscv-inline-asm.c:32 +// CHECK-LABEL: define void @test_A(i32* %p) +// CHECK: call void asm volatile ""

[PATCH] D57021: [clangd] Suggest adding missing includes for typos (like include-fixer).

ioeric updated this revision to Diff 185546. ioeric marked 15 inline comments as done. ioeric added a comment. - address review comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57021/new/ https://reviews.llvm.org/D57021 Files: clangd/Clangd

[PATCH] D57819: [clangd] Reduce number of threads used by BackgroundIndex to number of physical cores.

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric. Herald added a project: clang. clangd is using as many threads as logical cores for BackgroundIndex by default. Due to hyper-threading this causes ca

[PATCH] D57739: [clangd] Format tweak's replacements.

hokein updated this revision to Diff 185550. hokein marked an inline comment as done. hokein added a comment. Address comments. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57739/new/ https://reviews.llvm.org/D57739 Files: clangd/ClangdServer.cp

[PATCH] D57739: [clangd] Format tweak's replacements.

hokein updated this revision to Diff 185551. hokein added a comment. Remove accident change. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57739/new/ https://reviews.llvm.org/D57739 Files: clangd/ClangdServer.cpp clangd/ClangdUnit.cpp clangd/

[clang-tools-extra] r353306 - [clangd] Format tweak's replacements.

Author: hokein Date: Wed Feb 6 07:24:50 2019 New Revision: 353306 URL: http://llvm.org/viewvc/llvm-project?rev=353306&view=rev Log: [clangd] Format tweak's replacements. Modified: clang-tools-extra/trunk/clangd/ClangdServer.cpp clang-tools-extra/trunk/clangd/ClangdUnit.cpp clang-tool

[clang-tools-extra] r353309 - [clangd] Bump vscode-clangd v0.0.11

Author: hokein Date: Wed Feb 6 07:29:54 2019 New Revision: 353309 URL: http://llvm.org/viewvc/llvm-project?rev=353309&view=rev Log: [clangd] Bump vscode-clangd v0.0.11 CHANGELOG: - activate the extension on ObjC files. Modified: clang-tools-extra/trunk/clangd/clients/clangd-vscode/package.j

[PATCH] D57815: [clangd] Add type boost to fuzzy find in Dex.

ioeric updated this revision to Diff 185554. ioeric marked 4 inline comments as done. ioeric added a comment. - address comments plus some refactoring. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57815/new/ https://reviews.llvm.org/D57815 Files:

[clang-tools-extra] r353310 - [clangd] Add type boost to fuzzy find in Dex.

Author: ioeric Date: Wed Feb 6 07:36:23 2019 New Revision: 353310 URL: http://llvm.org/viewvc/llvm-project?rev=353310&view=rev Log: [clangd] Add type boost to fuzzy find in Dex. Summary: No noticeable impact on code completions overall except some improvement on cross-namespace completion. Revi

[PATCH] D57815: [clangd] Add type boost to fuzzy find in Dex.

ioeric updated this revision to Diff 18. ioeric added a comment. - revert unintended change. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57815/new/ https://reviews.llvm.org/D57815 Files: clangd/CodeComplete.cpp clangd/index/Index.cpp cl

[PATCH] D57815: [clangd] Add type boost to fuzzy find in Dex.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE353310: [clangd] Add type boost to fuzzy find in Dex. (authored by ioeric, committed by ). Changed prior to commit: https://reviews.llvm.org/D57815?vs=18&id=185556#toc Repository: rCTE Clang To

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

kees added a comment. I reduced the C code to this: volatile int mystery = 0; static int noinline demo(int klen) { int err; int len; err = mystery * klen; if (err) return err; if (len > klen) len = k

[PATCH] D57824: [OpenCL][PR40603] Align the use of extensions in C++ to be backwards compatible with OpenCL C v2.0

Anastasia created this revision. Anastasia added reviewers: svenvh, rjmccall. Herald added subscribers: ebevhan, jfb, yaxunl. One of the goal of C++ mode for OpenCL is to preserve backwards compatibility with OpenCL C v2.0! This patch aligns extensions! https://reviews.llvm.org/D57824 Files:

[PATCH] D53928: Enable builtins necessary for SLEEF [AArch64] vectorized trigonometry libm functions

steleman updated this revision to Diff 185578. steleman added a comment. Herald added a project: clang. This is a small - but signifcant - update to the original changeset. What's new in this update: ${top_srcdir}/lib/Frontend/CompilerInvocation.cpp: When -fveclib=SLEEF was passed on compile-li

[PATCH] D57464: Generalize method overloading on addr spaces to C++

Anastasia marked an inline comment as done. Anastasia added a comment. Btw, if we would implement something like this: http://lists.llvm.org/pipermail/cfe-dev/2019-January/060798.html Would it allow you to switch to more generic address space attributes and therefore help to decrease diverging f

[PATCH] D36806: Switch to cantFail(), since it does the same assertion.

This revision was automatically updated to reflect the committed changes. Closed by commit rL353318: Switch to cantFail(), since it does the same assertion. (authored by srhines, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES

r353318 - Switch to cantFail(), since it does the same assertion.

Author: srhines Date: Wed Feb 6 09:59:39 2019 New Revision: 353318 URL: http://llvm.org/viewvc/llvm-project?rev=353318&view=rev Log: Switch to cantFail(), since it does the same assertion. Reviewers: cfe-commits, lhames Reviewed By: lhames Subscribers: hintonda, klimek, pirama Differential Re

r353320 - Test commit. NFC

Author: plyster Date: Wed Feb 6 10:18:02 2019 New Revision: 353320 URL: http://llvm.org/viewvc/llvm-project?rev=353320&view=rev Log: Test commit. NFC Modified: cfe/trunk/lib/Sema/SemaOpenMP.cpp Modified: cfe/trunk/lib/Sema/SemaOpenMP.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/l

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57801: [opaque pointer types] Pass through function types for TLS initialization and global destructor calls.

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Great (: Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57801/new/ https://reviews.llvm.org/D57801 ___

[PATCH] D57804: [opaque pointer types] Make EmitCall pass Function Types to CreateCall/Invoke.

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Cool, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57804/new/ https://reviews.llvm.org/D57804 __

[PATCH] D57787: [clang-tidy] modernize-avoid-c-arrays: avoid main function (PR40604)

lebedev.ri updated this revision to Diff 185587. lebedev.ri marked 4 inline comments as done and an inline comment as not done. lebedev.ri added a comment. And back to `dyn_cast()`. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57787/new/ https://re

[PATCH] D57626: Disallow trivial_abi on a class if all copy and move constructors are deleted

Quuxplusone added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2953 + "have bases of non-trivial class types|have virtual bases|" + "have __weak fields under ARC|have fields of non-trivial class types}0">; ahatanak wrote: > Quuxplus

[PATCH] D57829: [HIP] Disable emitting llvm.linker.options in device compilation

yaxunl created this revision. yaxunl added reviewers: tra, rjmccall. HIP toolchain does not support llvm.linker.options in device compilation, therefore disable it. https://reviews.llvm.org/D57829 Files: lib/CodeGen/CodeGenModule.cpp test/CodeGenCUDA/linker-options.cu Index: test/CodeGen

[PATCH] D45978: dllexport const variables must have external linkage.

aaron.ballman added a comment. Can you add tests for C mode as well, as it seems the behavior differs there. Given: __declspec(dllexport) int const x = 3; __declspec(dllexport) const int y; extern int const z = 4; int main() { int a = x + y + z; return a; } I get: C:\Us

[PATCH] D57831: AMDGPU: set wchar_t and wint_t to be unsigned short on windows

yaxunl created this revision. yaxunl added a reviewer: b-sumner. Herald added subscribers: t-tye, Anastasia, tpr, dstuttard, nhaehnle, wdng, jvesely, kzhuravl. In MSVC wchar_t and wint_t are unsigned short. There is static_assert in MSVC headers checking that. Since HIP and OpenCL share the sam

[PATCH] D57787: [clang-tidy] modernize-avoid-c-arrays: avoid main function (PR40604)

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a nit. Comment at: clang-tidy/modernize/AvoidCArraysCheck.cpp:36-38 + if (!FD) // If not a FunctionDecl, then certainly not main entry function

[PATCH] D57265: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting

hiraditya accepted this revision. hiraditya added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57265/new/ https://reviews.llvm.org/D57265 ___ cfe-commits mailing list cfe-com

[PATCH] D57829: [HIP] Disable emitting llvm.linker.options in device compilation

tra added a comment. Could you elaborate on why you want to disable this metadata? I think the original idea of llvm.linker.options was that it should be ignored if the back-end does not support it. Comment at: lib/CodeGen/CodeGenModule.cpp:441 if (CodeGenOpts.Autolink &&

[PATCH] D57787: [clang-tidy] modernize-avoid-c-arrays: avoid main function (PR40604)

lebedev.ri added a comment. In D57787#1387406 , @aaron.ballman wrote: > LGTM aside from a nit. Thank you for the review. Comment at: clang-tidy/modernize/AvoidCArraysCheck.cpp:35 + const clang::DeclContext *DC = Node.getDeclContext(

[PATCH] D57829: [HIP] Disable emitting llvm.linker.options in device compilation

yaxunl added a comment. In D57829#1387412 , @tra wrote: > Could you elaborate on why you want to disable this metadata? I think the > original idea of llvm.linker.options was that it should be ignored if the > back-end does not support it. If backend d

[clang-tools-extra] r353327 - [clang-tidy] modernize-avoid-c-arrays: avoid main function (PR40604)

Author: lebedevri Date: Wed Feb 6 11:17:30 2019 New Revision: 353327 URL: http://llvm.org/viewvc/llvm-project?rev=353327&view=rev Log: [clang-tidy] modernize-avoid-c-arrays: avoid main function (PR40604) Summary: The check should ignore the main function, the program entry point. It is not possi

[PATCH] D57787: [clang-tidy] modernize-avoid-c-arrays: avoid main function (PR40604)

This revision was automatically updated to reflect the committed changes. Closed by commit rL353327: [clang-tidy] modernize-avoid-c-arrays: avoid main function (PR40604) (authored by lebedevri, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D57267: [AST] Factor out the logic of the various Expr::Ignore*

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! You should give @rsmith a few days in case he wants to express an opinion though. Comment at: lib/AST/Expr.cpp:2643-2645 + } + + else if (auto *GSE = d

[PATCH] D57829: [HIP] Disable emitting llvm.linker.options in device compilation

tra added a comment. In D57829#1387416 , @yaxunl wrote: > In D57829#1387412 , @tra wrote: > > > Could you elaborate on why you want to disable this metadata? I think the > > original idea of llvm.linker.options was

[PATCH] D57831: AMDGPU: set wchar_t and wint_t to be unsigned short on windows

b-sumner added a comment. Maybe there are already other types like this, but it saddens me that an offline compiled code object could potentially not work properly if the application is using any of these types. Or should the runtime try to detect a problem using argument metadata? CHANGES S

[PATCH] D57831: AMDGPU: set wchar_t and wint_t to be unsigned short on windows

compnerd requested changes to this revision. compnerd added inline comments. This revision now requires changes to proceed. Comment at: lib/Basic/Targets/AMDGPU.cpp:263 MaxAtomicPromoteWidth = MaxAtomicInlineWidth = 64; +#if _WIN32 + WCharType = UnsignedShort; ---

[PATCH] D57021: [clangd] Suggest adding missing includes for typos (like include-fixer).

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Great stuff! Sorry for the delay here. Comment at: clangd/IncludeFixer.h:59 +SourceLocation Loc; // Start location of the unresolved name. +// Callback to get p

[PATCH] D57631: [COFF, ARM64] Add ARM64 support for MS intrinsic _fastfail

This revision was automatically updated to reflect the committed changes. Closed by commit rL353337: [COFF, ARM64] Add ARM64 support for MS intrinsic _fastfail (authored by TomTan, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: ht

r353337 - [COFF, ARM64] Add ARM64 support for MS intrinsic _fastfail

Author: tomtan Date: Wed Feb 6 12:08:26 2019 New Revision: 353337 URL: http://llvm.org/viewvc/llvm-project?rev=353337&view=rev Log: [COFF, ARM64] Add ARM64 support for MS intrinsic _fastfail The MSDN document was also updated to reflect this, but it probably will take a few days to show in belo

[PATCH] D57835: Fix -ftime-report with -x ir

arsenm created this revision. Herald added a subscriber: wdng. This was only printing the clang frontend timer, and none of the backend timers. Set the llvm global for enabling the backend time report when creating the frontend timers, rather than in the BackendConsumer constructor. There

[PATCH] D57838: [clang-cl] support /Oy- on aarch64

froydnj created this revision. froydnj added a reviewer: mstorsjo. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. MSVC supports /Oy- on aarch64, so clang-cl should too. Repository: rC Clang https://reviews.llvm.org/D57838 Files: lib/Driver

[PATCH] D57835: Fix -ftime-report with -x ir

arsenm added a comment. I partially solved the problem with double printing the reports. It's from this in cc1_main: // If any timers were active but haven't been destroyed yet, print theirp // results now. This happens in -disable-free mode. llvm::TimerGroup::printAll(llvm::errs()); On

[PATCH] D57740: [ASTImporter] Import every Decl in lambda record

shafik added a comment. LGTM although I wish we had more lambda tests. Please remember to check the LLDB build bots when landing the patch. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57740/new/ https://reviews.llvm.org/D57740 __

[PATCH] D57674: [clang-tidy] Add options to bugprone-argument-comment to add missing argument comments to literals

MyDeveloperDay updated this revision to Diff 185632. MyDeveloperDay marked 5 inline comments as done. MyDeveloperDay added a comment. -Address review comments -Ignore argument comment addition for macro inputs -Add unit tests to cover the above -Fix clang-tidy suggestion (from readability-identifi

[PATCH] D57674: [clang-tidy] Add options to bugprone-argument-comment to add missing argument comments to literals

MyDeveloperDay marked 3 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang-tidy/bugprone/ArgumentCommentCheck.cpp:1 -//===--- ArgumentCommentCheck.cpp - clang-tidy ===// // aaron.ballman wrote: > Why did

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

rsmith added inline comments. Comment at: lib/AST/Stmt.cpp:628 + DiagOffs = CurPtr-StrStart-1; + return diag::err_asm_invalid_operand_for_goto_labels; +} jyu2 wrote: > rsmith wrote: > > I'm curious why we're checking this here, when all

[PATCH] D57265: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting

vsk added reviewers: fedor.sergeev, philip.pfaffe. vsk added a comment. Thanks @hiraditya. I'd also like to get a +1 from someone who's worked on the NewPM infrastructure extensively, just to make sure those changes look ok. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57265/new/ http

[PATCH] D57265: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting

vsk updated this revision to Diff 185642. vsk added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57265/new/ https://reviews.llvm.org/D57265 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/CC1Options.td clang/lib/CodeGen/BackendUt

[PATCH] D57230: [analyzer] Toning down invalidation a bit

NoQ added a comment. There seem to be a few regressions - weird memory leaks of inner objects in C++ destructors. Trying to investigate/reproduce. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57230/new/ https://reviews.llvm.org/D57230

[PATCH] D57850: [analyzer] Emit an error rather than assert on invalid checker option input

Szelethus created this revision. Szelethus added reviewers: george.karpenkov, NoQ, xazax.hun, rnkovacs, baloghadamsoftware. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity. Herald added a reviewer: teemperor. Herald added a proj

[PATCH] D57850: [analyzer] Emit an error rather than assert on invalid checker option input

teemperor resigned from this revision. teemperor added a comment. LGTM for the CloneChecker changes. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57850/new/ https://reviews.llvm.org/D57850 ___ cfe-commits mailing li

  1   2   >