r351528 - Fix failing MSan bots

Author: vlad.tsyrklevich Date: Fri Jan 18 00:43:22 2019 New Revision: 351528 URL: http://llvm.org/viewvc/llvm-project?rev=351528&view=rev Log: Fix failing MSan bots Revert r351508-351514, this block of changes introduced a consistent MSan failure on the sanitizer bots. Removed: cfe/trunk/tes

Re: r351514 - [analyzer] Introduce proper diagnostic for freeing unowned object

Hi, I've reverted r351508-351514 as they were causing MSan failures on the sanitizer bots. It looks like isLeak is not initialized by one of the RefCountReport constructors and it is not immediately obvious to me what an appropriate value for it is. You can observe the failures here

[PATCH] D56856: [tooling] Add a new argument adjuster for deleting plugin related command line args

kadircet updated this revision to Diff 182469. kadircet added a comment. - Address comments Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56856/new/ https://reviews.llvm.org/D56856 Files: include/clang/Tooling/ArgumentsAdjusters.h lib/Tooling/ArgumentsAdjust

r351531 - [tooling] Add a new argument adjuster for deleting plugin related command line args

Author: kadircet Date: Fri Jan 18 01:00:31 2019 New Revision: 351531 URL: http://llvm.org/viewvc/llvm-project?rev=351531&view=rev Log: [tooling] Add a new argument adjuster for deleting plugin related command line args Summary: Currently both clangd and clang-tidy makes use of this mechanism so

[PATCH] D56856: [tooling] Add a new argument adjuster for deleting plugin related command line args

This revision was automatically updated to reflect the committed changes. Closed by commit rC351531: [tooling] Add a new argument adjuster for deleting plugin related command line… (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D56856?vs=182469&id=18247

[PATCH] D56900: [Fixed Point Arithmetic] Fixed Point and Integer Conversions

ebevhan added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:9825 +if (Result.isSigned() && !DstSigned) { + Overflow = Result < 0 || Result.ugt(DstMax); +} else if (Result.isUnsigned() && DstSigned) { The `Result < 0` is more clearly exp

Re: r351457 - TLS: Respect visibility for thread_local variables on Darwin (PR40327)

Merged to the 8.0 branch in r351533. Please let me know if there are any further commits for this issue. Thanks, Hans On Thu, Jan 17, 2019 at 6:57 PM Vlad Tsyrklevich via cfe-commits wrote: > > Author: vlad.tsyrklevich > Date: Thu Jan 17 09:53:45 2019 > New Revision: 351457 > > URL: http://llvm.

[PATCH] D56752: [ASTDump] Mark BlockDecls which capture this with a tag

steveire updated this revision to Diff 182475. steveire added a comment. Rebase Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56752/new/ https://reviews.llvm.org/D56752 Files: lib/AST/ASTDumper.cpp test/AST/ast-dump-decl.mm Index: test/AST/ast-dump-decl.mm

[PATCH] D56753: [ASTDump] Mark null params with a tag rather than a child node

steveire updated this revision to Diff 182476. steveire marked an inline comment as done. steveire added a comment. Update Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56753/new/ https://reviews.llvm.org/D56753 Files: lib/AST/ASTDumper.cpp Index: lib/AST/AS

Re: r351459 - [ObjC] Follow-up r350768 and allow the use of unavailable methods that are

Merged in r351535. Please let me know if there are any more issues in this area. Also, do you want to write something for r350768 and this in the release notes? On Thu, Jan 17, 2019 at 7:22 PM Alex L wrote: > > Hi Hans, > > Could you please cherry-pick this change into the release branch? > > Ch

[PATCH] D56829: Move decl context dumping to TextNodeDumper

steveire updated this revision to Diff 182478. steveire added a comment. Update Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56829/new/ https://reviews.llvm.org/D56829 Files: lib/AST/ASTDumper.cpp lib/AST/TextNodeDumper.cpp Index: lib/AST/TextNodeDumper.c

Re: [clang-tools-extra] r351463 - [Documentation] Add a chapter about Clang-tidy integrations.

Merged to 8.0 along with the follow-ups in r351538. On Thu, Jan 17, 2019 at 7:35 PM Eugene Zelenko via cfe-commits wrote: > > Author: eugenezelenko > Date: Thu Jan 17 10:31:34 2019 > New Revision: 351463 > > URL: http://llvm.org/viewvc/llvm-project?rev=351463&view=rev > Log: > [Documentation] Add

[PATCH] D56841: [clangd] Filter out plugin related flags and move all commandline manipulations into OverlayCDB.

kadircet updated this revision to Diff 182479. kadircet added a comment. - Use getStripPluginsAdjuster and move manipulations into OverlayCDB Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56841/new/ https://reviews.llvm.org/D56841 Files: clangd/C

[PATCH] D56852: [AArch64] Use LLU for 64-bit crc32 arguments

samparker updated this revision to Diff 182481. samparker added a comment. Updated wsr, rsr and rbit CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56852/new/ https://reviews.llvm.org/D56852 Files: include/clang/Basic/BuiltinsAArch64.def test/CodeGen/arm64-crc32.c test/CodeGen/bui

[PATCH] D56829: Move decl context dumping to TextNodeDumper

steveire updated this revision to Diff 182482. steveire added a comment. Update Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56829/new/ https://reviews.llvm.org/D56829 Files: lib/AST/ASTDumper.cpp lib/AST/TextNodeDumper.cpp Index: lib/AST/TextNodeDumper.c

[PATCH] D56902: [clang-tidy] Use getStripPluginsAdjuster

kadircet created this revision. kadircet added a reviewer: alexfh. Herald added subscribers: cfe-commits, xazax.hun. See rC351531 for the introduction of getStripPluginsAdjuster. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D56902 Files:

r351540 - [analyzer] Unbreak building of SymbolReaperTest true BUILD_SHARED_LIBS=True

Author: asb Date: Fri Jan 18 02:13:07 2019 New Revision: 351540 URL: http://llvm.org/viewvc/llvm-project?rev=351540&view=rev Log: [analyzer] Unbreak building of SymbolReaperTest true BUILD_SHARED_LIBS=True Extra dependencies need to be listed for StaticAnalysisTests in order for linking to succee

[PATCH] D56903: [clangd] Suggest adding missing includes for incomplete type diagnostics.

ioeric created this revision. ioeric added a reviewer: sammccall. Herald added subscribers: cfe-commits, kadircet, arphaman, mgrang, jkorous, MaskRay, javed.absar, ilya-biryukov, mgorny. This enables clangd to intercept compiler diagnostics and attach fixes (e.g. by querying index). This patch ad

[PATCH] D56841: [clangd] Filter out plugin related flags and move all commandline manipulations into OverlayCDB.

ilya-biryukov added a comment. just a few nits Comment at: clangd/GlobalCompilationDatabase.cpp:23 + +void AdjustArguments(tooling::CompileCommand &Cmd, + const std::string &ResourceDir) { naming NIT: use `adjustArguments`

Re: r351495 - Make integral-o-pointer conversions in SFINAE illegal.

Hello Erich, The test added in this commit is failing on the Arm and Hexagon builders. I think that this is because the expected type "long" in the warning text is "int" on these platforms (possibly other 32-bit host platforms). The raw output from an Arm machine is: llvm-project/clang/test/SemaC

[PATCH] D35068: [analyzer] Detect usages of unsafe I/O functions

whisperity added a comment. In D35068#1361902 , @Szelethus wrote: > Edit: it doesn't, but CMake is mostly a C project and it does! CMake really isn't a C project if you look at what language it actually uses - the C files come from tests and system util

[PATCH] D56841: [clangd] Filter out plugin related flags and move all commandline manipulations into OverlayCDB.

kadircet updated this revision to Diff 182489. kadircet marked 3 inline comments as done. kadircet added a comment. - Address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56841/new/ https://reviews.llvm.org/D56841 Files: clangd/ClangdLS

[PATCH] D56841: [clangd] Filter out plugin related flags and move all commandline manipulations into OverlayCDB.

kadircet added inline comments. Comment at: clangd/GlobalCompilationDatabase.cpp:24 +void AdjustArguments(tooling::CompileCommand &Cmd, + const std::string &ResourceDir) { + // Strip plugin related command line arguments. Clangd does ilya-bir

[PATCH] D56735: [OpenCL] Fix overloading ranking rules to work correctly for address space conversions

This revision was automatically updated to reflect the committed changes. Closed by commit rL351546: [OpenCL] Fix overloading ranking rules for addrspace conversions. (authored by stulova, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org

r351546 - [OpenCL] Fix overloading ranking rules for addrspace conversions.

Author: stulova Date: Fri Jan 18 03:38:16 2019 New Revision: 351546 URL: http://llvm.org/viewvc/llvm-project?rev=351546&view=rev Log: [OpenCL] Fix overloading ranking rules for addrspace conversions. Extend ranking to work with address spaces correctly when resolving overloads. Differential Revi

[PATCH] D54141: [clang-tidy] add deduplication support for run-clang-tidy.py

MyDeveloperDay added a comment. > LLVM is very chatty as well, I don't consider LLVM to be a bad code-base. > Take readability-braces-around-statements for example. Do we need a llvm-elide-braces-for-small-statements? This would make a great pre-review check Repository: rCTE Clang Tools Ext

[PATCH] D55850: [OpenCL] Allow address spaces as method qualifiers

Anastasia updated this revision to Diff 182496. Anastasia added a comment. Added a comment explaining when multiple address spaces are diagnosed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55850/new/ https://reviews.llvm.org/D55850 Files: include/clang/AST/Type.h include/clang/S

[PATCH] D56836: [mips] Include whole lpthread when using both -pthread and -static

abeserminji added a comment. @atanasyan That looks good. I tried to make an equivalent for the Makefile --- SingleSource/UnitTests/C++11/Makefile (revision 351547) +++ SingleSource/UnitTests/C++11/Makefile (working copy) @@ -4,6 +4,11 @@ CPPFLAGS += -std=c++11 -pthread

[PATCH] D56267: [clangd] Interfaces for writing code actions

sammccall added a comment. This looks really good, everything else is pretty superficial I think. I think we'll want to add one lit test for the whole two-step tweak workflow, as well as TestTU/annotation-based unit-tests for each tweak. As this patch has no actual tweaks in it, we can work out

[PATCH] D56878: [mips] Add '-mrelax-pic-calls', '-mno-relax-pic-calls'

atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. LGTM with a nit. Comment at: lib/Driver/ToolChains/Clang.cpp:1720 + CmdArgs.push_back("-mllvm"); + CmdArgs.push_back(Args.MakeArgString("-mips-jalr-reloc=0"))

[PATCH] D56836: [mips] Include whole lpthread when using both -pthread and -static

atanasyan added a comment. In D56836#1362967 , @abeserminji wrote: > As an option, we can provide necessary flags for the test to finish > successfully instead of not testing it. Agreed. Repository: rC Clang CHANGES SINCE LAST ACTION https://revi

[PATCH] D56905: [libunwind] [SjLj] Don't use __declspec(thread) in MinGW mode

mstorsjo created this revision. mstorsjo added reviewers: mclow.lists, EricWF, ldionne, compnerd, smeenai, rnk. Herald added a subscriber: libcxx-commits. mstorsjo edited the summary of this revision. GCC and Clang in MinGW mode don't support `__declspec(thread)`, which after expanding macros end

[PATCH] D56752: [ASTDump] Mark BlockDecls which capture this with a tag

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56752/new/ https://reviews.llvm.org/D56752 ___

Re: r232680 - MS ABI: Don't try to emit VF/VB-Tables for extern class templates

(-old cfe-commits, +new cfe-commits) On Fri, Jan 18, 2019 at 8:21 AM Nico Weber wrote: > I found this comment useful, but from your reply it sounds like it's no > longer true: > > - // We must indicate which VFTable is larger to support linking > between > - // translation unit

[PATCH] D56902: [clang-tidy] Use getStripPluginsAdjuster

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56902/new/ https://reviews.llvm.org/D56902 ___ cf

[PATCH] D56753: [ASTDump] Mark null params with a tag rather than a child node

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. With bracket and comment changes, LGTM. No need for tests on this one because the scenario changed can only occur during debugging. Comment at: lib/AST/ASTDump

RE: r351495 - Make integral-o-pointer conversions in SFINAE illegal.

Thanks for the heads up! Looking now. -Original Message- From: Peter Smith [mailto:peter.sm...@linaro.org] Sent: Friday, January 18, 2019 2:33 AM To: Keane, Erich Cc: cfe-commits cfe Subject: Re: r351495 - Make integral-o-pointer conversions in SFINAE illegal. Hello Erich, The test a

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

JonasToth added a comment. I believe there is some sort of memory leak in the `run-clang-tidy` or so. I had similar experience :) Take this with a grain of salt, as I don't recall all details: `run-clang-tidy.py` just takes all output from clang-tidy and prints it. A lot is redundant due to the

r351550 - Fix test failure from r351495

Author: erichkeane Date: Fri Jan 18 05:58:10 2019 New Revision: 351550 URL: http://llvm.org/viewvc/llvm-project?rev=351550&view=rev Log: Fix test failure from r351495 The test has problems due to some platforms having a different type for ptrdiff_t, so the error message is different. The error m

[PATCH] D54141: [clang-tidy] add deduplication support for run-clang-tidy.py

JonasToth added a comment. In D54141#1362924 , @MyDeveloperDay wrote: > > LLVM is very chatty as well, I don't consider LLVM to be a bad code-base. > > Take readability-braces-around-statements for example. > > Do we need a llvm-elide-braces-for-small-st

[PATCH] D56879: [Sema] Suppress a warning about a forward-declared fixed enum in C mode

aaron.ballman added inline comments. Comment at: clang/test/Sema/fixed-enum.c:4 // RUN: %clang_cc1 -Weverything -xobjective-c -DOBJC -verify %s // RUN: %clang_cc1 -Weverything -std=c11 -xc -DC11 -verify %s // RUN: %clang_cc1 -Weverything -std=c11 -xc -fms-extensions -DMS -veri

[PATCH] D56892: Add a priority field to availability attributes to prioritize explicit attributes from declaration over attributes from '#pragma clang attribute'

aaron.ballman added a comment. I think the documentation for the attribute should be updated to explain this new behavior, otherwise this will be a very inexplicable feature to users. One question I have is: will this feature also be needed by other attributes? This seems like a somewhat genera

[PATCH] D56751: [ASTDump] Mark variadic declarations with a tag instead of child node

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56751/new/ https://reviews.llvm.org/D56751 ___

[PATCH] D56829: Move decl context dumping to TextNodeDumper

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from the testing situation -- so long as the tests come out without changes, this is good to go. If there is a change in test behavior, let's do another round of revie

[PATCH] D56909: [clang-format] Fix line parsing for noexcept lambdas

hultman created this revision. hultman added reviewers: benhamilton, jolesiak, klimek, Wizard. Herald added a subscriber: cfe-commits. > $ echo "int c = [b]() mutable noexcept { return [&b] { return b++; }(); }();" > |clang-format int c = [b]() mutable noexcept { return [&b] { return b++

[PATCH] D56267: [clangd] Interfaces for writing code actions

sammccall added inline comments. Comment at: clangd/ClangdServer.cpp:339 + return CB(llvm::createStringError(llvm::inconvertibleErrorCode(), +"could not create action context")); +CB(prepareTweaks(*Inputs)); (actio

[PATCH] D56611: [clangd] A code action to swap branches of an if statement

sammccall added a comment. Cool! Adopting this one as the simplest tweak for "how should tweaks do X" questions. This depends on helpers not (yet) present in this patch, so not commenting on them now. Need unit tests for tweaks. Something like this should work: Annotations Test(R"cpp(void f

r351559 - Clang side support for @cc assembly operands.

Author: niravd Date: Fri Jan 18 07:57:23 2019 New Revision: 351559 URL: http://llvm.org/viewvc/llvm-project?rev=351559&view=rev Log: Clang side support for @cc assembly operands. Modified: cfe/trunk/lib/Basic/Targets/X86.cpp Modified: cfe/trunk/lib/Basic/Targets/X86.cpp URL: http://llvm.org

[PATCH] D54324: [AST] Store the value of CharacterLiteral in the bit-fields of Stmt if possible

riccibruno abandoned this revision. riccibruno added a comment. This is not worth doing. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54324/new/ https://reviews.llvm.org/D54324 ___ cfe-commits mailing list cfe-commi

r351561 - Revert "Clang side support for @cc assembly operands."

Author: niravd Date: Fri Jan 18 08:03:08 2019 New Revision: 351561 URL: http://llvm.org/viewvc/llvm-project?rev=351561&view=rev Log: Revert "Clang side support for @cc assembly operands." Modified: cfe/trunk/lib/Basic/Targets/X86.cpp Modified: cfe/trunk/lib/Basic/Targets/X86.cpp URL: http:/

[PATCH] D56915: [clangd] Make background index less chatty

ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric. It is producing too much input in non-verbose mode, i.e. a message per indexed file https://reviews.llvm.org/D56915 Files: clang-tools-extra/

[PATCH] D56916: Fix crash due to ObjCPropertyDecl

dgoldman created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, ioeric, ilya-biryukov. With ObjCPropertyDecl, ASTNode.OrigD can be a ObjCPropertyImplDecl which is not a NamedDecl, leading to a crash since the code incorrectly assumes ASTNode.OrigD will always b

[PATCH] D56868: Add -fextern-visibility for -cc1

scott.linder updated this revision to Diff 182528. scott.linder retitled this revision from "Add -fset-visibility-for-decls for -cc1" to "Add -fextern-visibility for -cc1". scott.linder added a comment. Update the -cc1 option name and docs; also update the LangOpt and docs. CHANGES SINCE LAST A

Re: r351540 - [analyzer] Unbreak building of SymbolReaperTest true BUILD_SHARED_LIBS=True

Thanks!!! On 1/18/19 2:13 AM, Alex Bradbury via cfe-commits wrote: Author: asb Date: Fri Jan 18 02:13:07 2019 New Revision: 351540 URL: http://llvm.org/viewvc/llvm-project?rev=351540&view=rev Log: [analyzer] Unbreak building of SymbolReaperTest true BUILD_SHARED_LIBS=True Extra dependencies ne

[PATCH] D56871: [AMDGPU] Require at least protected visibility for certain symbols

scott.linder updated this revision to Diff 182532. scott.linder added a comment. Update option name CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56871/new/ https://reviews.llvm.org/D56871 Files: lib/CodeGen/CodeGenModule.cpp lib/CodeGen/TargetInfo.cpp test/CodeGenOpenCL/visibili

[PATCH] D56917: [clang] add tests to ExprMutAnalyzer that reproduced a crash in ASTMatchers

JonasToth created this revision. JonasToth added reviewers: aaron.ballman, sammccall, rsmith. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a reviewer: george.karpenkov. This patch adds two unit-tests that are the result of reduc

[PATCH] D56267: [clangd] Interfaces for writing code actions

ilya-biryukov added inline comments. Comment at: clangd/ClangdServer.cpp:363 + return CB(A.takeError()); +return CB((*A)->apply(*Inputs)); + }; sammccall wrote: > we should `format::cleanUpAroundReplacements`... fine to leave this as a FIXME Added a FIX

[PATCH] D56267: [clangd] Interfaces for writing code actions

ilya-biryukov updated this revision to Diff 182534. ilya-biryukov marked 10 inline comments as done. ilya-biryukov added a comment. - Update comments - Return an ID+Title instead of a Tweak object - Rename codeAction -> tweak everywhere - Remove Tweak::Selection::File - Return Expected instead of

[clang-tools-extra] r351563 - [clangd] Make background index less chatty

Author: ibiryukov Date: Fri Jan 18 09:04:26 2019 New Revision: 351563 URL: http://llvm.org/viewvc/llvm-project?rev=351563&view=rev Log: [clangd] Make background index less chatty Summary: It is producing too much input in non-verbose mode, i.e. a message per indexed file Reviewers: sammccall, ka

[PATCH] D56915: [clangd] Make background index less chatty

This revision was automatically updated to reflect the committed changes. Closed by commit rL351563: [clangd] Make background index less chatty (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D56915?vs=182523&id=

[PATCH] D56918: [clang-tidy] add reproducer for PR39949 into test-suite

JonasToth created this revision. JonasToth added reviewers: alexfh, aaron.ballman, hokein, hwright. Herald added subscribers: cfe-commits, xazax.hun. The underlying issue is fixed in https://reviews.llvm.org/D56444 and this test ensures the issue does not creep back into our code-base. Repositor

r351565 - [clang][slh] add Clang attr no_speculative_load_hardening

Author: zbrid Date: Fri Jan 18 09:20:46 2019 New Revision: 351565 URL: http://llvm.org/viewvc/llvm-project?rev=351565&view=rev Log: [clang][slh] add Clang attr no_speculative_load_hardening Summary: This attribute will allow users to opt specific functions out of speculative load hardening. This

[PATCH] D54909: [clang][slh] add Clang attr no_speculative_load_hardening

This revision was automatically updated to reflect the committed changes. Closed by commit rC351565: [clang][slh] add Clang attr no_speculative_load_hardening (authored by zbrid, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D54909?vs=

Re: r351391 - Recommit r351160 "[X86] Make _xgetbv/_xsetbv on non-windows platforms"

Hi Craig, We're seeing issues building a few other things now; notably this part in opencv: https://github.com/opencv/opencv/blob/master/modules/core/src/system.cpp#L422 #ifdef _XCR_XFEATURE_ENABLED_MASK // requires immintrin.h xcr0 = (int)_xgetbv(_XCR_XFEATURE_ENABLED_M

[PATCH] D56610: [clangd] A code action to qualify an unqualified name

ilya-biryukov updated this revision to Diff 182545. ilya-biryukov added a comment. - Move to the monorepo - Move out the source code helpers (they're now in swap-if-branches) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56610/new/ https://reviews.llvm.org/D56610 Files: clang-tools-e

[PATCH] D56611: [clangd] A code action to swap branches of an if statement

ilya-biryukov updated this revision to Diff 182546. ilya-biryukov added a comment. - Move source code helpers to this patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56611/new/ https://reviews.llvm.org/D56611 Files: clang-tools-extra/clangd/SourceCode.cpp clang-tools-extra/clan

[PATCH] D56612: [clangd] A code action to remove 'using namespace'

ilya-biryukov updated this revision to Diff 182547. ilya-biryukov added a comment. - Move to the monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56612/new/ https://reviews.llvm.org/D56612 Files: clang-tools-extra/clangd/AST.cpp clang-tools-extra/clangd/AST.h clang-tools-ex

r351568 - [X86] Only define _XCR_XFEATURE_ENABLED_MASK in xsaveintrin.h when _MSC_VER is defined. Remove from intrin.h.

Author: ctopper Date: Fri Jan 18 09:51:51 2019 New Revision: 351568 URL: http://llvm.org/viewvc/llvm-project?rev=351568&view=rev Log: [X86] Only define _XCR_XFEATURE_ENABLED_MASK in xsaveintrin.h when _MSC_VER is defined. Remove from intrin.h. I think this was my intention when I added it xsavei

[PATCH] D56879: [Sema] Suppress a warning about a forward-declared fixed enum in C mode

erik.pilkington updated this revision to Diff 182548. erik.pilkington marked an inline comment as done. erik.pilkington added a comment. Add a `-pedantic` RUN line. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56879/new/ https://reviews.llvm.org/D56879 Files: clang/lib/Sema/SemaDecl

RE: r351391 - Recommit r351160 "[X86] Make _xgetbv/_xsetbv on non-windows platforms"

I just committed a change to go back to only definining _XCR_XFEATURE_ENABLED_MASK when clang is in MSVC compatibility mode. I don’t think I meant to define it outside of that since it doesn’t appear gcc does. For the other two files, I assume you’re getting a collision of names similar to what

[PATCH] D56610: [clangd] A code action to qualify an unqualified name

JonasToth added a comment. Is this for something like `add const`? If yes, there is clang-tidy effort on that, see https://reviews.llvm.org/D54943 and https://reviews.llvm.org/D54395 for a similar effort. Would be best to share the code instead of reinventing it :) CHANGES SINCE LAST ACTION

[PATCH] D56868: Add -fextern-visibility for -cc1

rjmccall added a comment. I'm sorry to keep jerking you around, but let's spell out the flag a bit more: `-fapply-global-visibility-to-externs`. No reason not to be totally clear here. Thank you for updating the fields and descriptions, those all look good now. CHANGES SINCE LAST ACTION h

[PATCH] D54141: [clang-tidy] add deduplication support for run-clang-tidy.py

aaron.ballman added a comment. In D54141#1289980 , @hokein wrote: > >> If you're suggesting proceeding with this regex based solution, I > > > > don't think that's a good idea. Why commit a hack which people will object > > to ever removing? Just see if

[PATCH] D55868: [Fixed Point Arithmetic] Fixed Point Addition Constant Expression Evaluation

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55868/new/ https://reviews.llvm.org/D55868 ___ cfe-commi

[PATCH] D56918: [clang-tidy] add reproducer for PR39949 into test-suite

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the extra test coverage! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56918/new/ https://reviews.llvm.org/D569

[clang-tools-extra] r351569 - [clang-tidy] add reproducer for PR39949 into test-suite

Author: jonastoth Date: Fri Jan 18 10:03:11 2019 New Revision: 351569 URL: http://llvm.org/viewvc/llvm-project?rev=351569&view=rev Log: [clang-tidy] add reproducer for PR39949 into test-suite Summary: The underlying issue is fixed in https://reviews.llvm.org/D56444 and this test ensures the issue

Re: r351391 - Recommit r351160 "[X86] Make _xgetbv/_xsetbv on non-windows platforms"

Thanks! I'll rebuild clang from trunk and give it another try. Yes, for the second two, I think it should be a more straightforward fix a la https://chromium-review.googlesource.com/c/v8/v8/+/1414858 On Fri, Jan 18, 2019 at 9:58 AM Topper, Craig wrote: > I just committed a change to go back to o

[PATCH] D56918: [clang-tidy] add reproducer for PR39949 into test-suite

This revision was automatically updated to reflect the committed changes. Closed by commit rL351569: [clang-tidy] add reproducer for PR39949 into test-suite (authored by JonasToth, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://

Re: r351391 - Recommit r351160 "[X86] Make _xgetbv/_xsetbv on non-windows platforms"

Confirmed that opencv builds now, thanks :) On Fri, Jan 18, 2019 at 10:05 AM Jordan Rupprecht wrote: > Thanks! I'll rebuild clang from trunk and give it another try. > Yes, for the second two, I think it should be a more straightforward fix a > la https://chromium-review.googlesource.com/c/v8/v8

[PATCH] D56611: [clangd] A code action to swap branches of an if statement

ilya-biryukov updated this revision to Diff 182555. ilya-biryukov added a comment. - Add tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56611/new/ https://reviews.llvm.org/D56611 Files: clang-tools-extra/clangd/SourceCode.cpp clang-tools-extra/clangd/SourceCode.h clang-tool

[PATCH] D56610: [clangd] A code action to qualify an unqualified name

ilya-biryukov added a comment. In D56610#1363408 , @JonasToth wrote: > Is this for something like `add const`? > If yes, there is clang-tidy effort on that, see > https://reviews.llvm.org/D54943 and https://reviews.llvm.org/D54395 for a > similar effor

[PATCH] D56733: [OPENMP] update release note for implemented OMP 5.0 features

kkwli0 marked 2 inline comments as done. kkwli0 added inline comments. Comment at: docs/OpenMPSupport.rst:62 + +- Simplified code generation for distribute and parallel in SPMD mode. + gtbercea wrote: > Simplified SPMD code generation for `distribute parallel f

[PATCH] D56733: [OPENMP] update release note for implemented OMP 5.0 features

kkwli0 updated this revision to Diff 182556. kkwli0 marked an inline comment as done. kkwli0 added a comment. Addressed reviewer's comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56733/new/ https://reviews.llvm.org/D56733 Files: docs/OpenMPSupport.rst docs/ReleaseNotes.rst

[PATCH] D56916: Fix crash due to ObjCPropertyDecl

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. Thanks for fixing this. Quick LGTM to fix a crash, albeit a fews NITs. Comment at: clangd/index/SymbolCollector.cpp:372 + // ObjCPropertyDecl may have an Ori

[PATCH] D56841: [clangd] Filter out plugin related flags and move all commandline manipulations into OverlayCDB.

ilya-biryukov added inline comments. Comment at: clangd/GlobalCompilationDatabase.cpp:24 +void AdjustArguments(tooling::CompileCommand &Cmd, + const std::string &ResourceDir) { + // Strip plugin related command line arguments. Clangd does kad

[PATCH] D56868: Add -fapply-global-visibility-to-externs for -cc1

scott.linder updated this revision to Diff 182559. scott.linder retitled this revision from "Add -fextern-visibility for -cc1" to "Add -fapply-global-visibility-to-externs for -cc1". scott.linder added a comment. No worries, I agree that we don't gain much with a shorter flag here; explicit seem

[PATCH] D56610: [clangd] A code action to qualify an unqualified name

JonasToth added a comment. In D56610#1363461 , @ilya-biryukov wrote: > In D56610#1363408 , @JonasToth wrote: > > > Is this for something like `add const`? > > If yes, there is clang-tidy effort on that, see > >

[PATCH] D56871: [AMDGPU] Require at least protected visibility for certain symbols

scott.linder updated this revision to Diff 182561. scott.linder added a comment. Update option name CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56871/new/ https://reviews.llvm.org/D56871 Files: lib/CodeGen/CodeGenModule.cpp lib/CodeGen/TargetInfo.cpp test/CodeGenOpenCL/visibili

[PATCH] D56733: [OPENMP] update release note for implemented OMP 5.0 features

gtbercea accepted this revision. gtbercea added a comment. This revision is now accepted and ready to land. Thanks for the update! LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56733/new/ https://reviews.llvm.org/D56733 ___ cfe-commits

r351573 - [clang] Change to range-based invocation of llvm::sort

Author: mgrang Date: Fri Jan 18 10:45:26 2019 New Revision: 351573 URL: http://llvm.org/viewvc/llvm-project?rev=351573&view=rev Log: [clang] Change to range-based invocation of llvm::sort Modified: cfe/trunk/lib/Format/Format.cpp Modified: cfe/trunk/lib/Format/Format.cpp URL: http://llvm.or

[PATCH] D56852: [AArch64] Use LL for 64-bit arguments

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Comment at: test/CodeGen/builtins-arm64.c:2 // RUN: %clang_cc1 -triple arm64-unknown-linux -disable-O0-optnone -emit-llvm -o - %s | opt -S -mem2reg | FileCheck %s

[PATCH] D56916: Fix crash due to ObjCPropertyDecl

dgoldman updated this revision to Diff 182562. dgoldman marked an inline comment as done. dgoldman added a comment. - FIXME and dyn_cast Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56916/new/ https://reviews.llvm.org/D56916 Files: clangd/index/

[PATCH] D56868: Add -fapply-global-visibility-to-externs for -cc1

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, I appreciate you bearing with me on this. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56868/new/ https://reviews.llvm.org/D56868 __

[PATCH] D56905: [libunwind] [SjLj] Don't use __declspec(thread) in MinGW mode

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rUNW libunwind CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56905/new/ https://reviews.llvm.org/D56905 ___ cfe-commits ma

[PATCH] D56879: [Sema] Suppress a warning about a forward-declared fixed enum in C mode

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/test/Sema/fixed-enum.c:4 // RUN: %clang_cc1 -Weverything -xobjective-c -DOBJC -verify %s // RUN: %clang_cc1 -Weverything -std=c11 -xc

Re: r351514 - [analyzer] Introduce proper diagnostic for freeing unowned object

OK thanks - I’ll fix it. > On Jan 18, 2019, at 12:47 AM, Vlad Tsyrklevich wrote: > > Hi, I've reverted r351508-351514 as they were causing MSan failures on the > sanitizer bots. It looks like isLeak is not initialized by one of the > RefCountReport constructors and it is not immediately obviou

[PATCH] D55850: [OpenCL] Allow address spaces as method qualifiers

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay, LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55850/new/ https://reviews.llvm.org/D55850 ___ cfe-commits mailing list cf

r351575 - Revert "Fix failing MSan bots"

Author: george.karpenkov Date: Fri Jan 18 11:24:55 2019 New Revision: 351575 URL: http://llvm.org/viewvc/llvm-project?rev=351575&view=rev Log: Revert "Fix failing MSan bots" This reverts commit 2cedaaef383d8d6142046074ffebc2bb5a914778. Revert with a fix. Added: cfe/trunk/test/Analysis/os_ob

[PATCH] D56924: Handle ObjCCategoryDecl class extensions for print

dgoldman created this revision. Herald added a subscriber: cfe-commits. Since class extensions do not have a name, (class extension) is used instead. Repository: rC Clang https://reviews.llvm.org/D56924 Files: lib/AST/Decl.cpp Index: lib/AST/Decl.cpp =

r351576 - [NFC] Fix wParentheses warning in ASTContext getFixedPointSemantics

Author: erichkeane Date: Fri Jan 18 11:31:54 2019 New Revision: 351576 URL: http://llvm.org/viewvc/llvm-project?rev=351576&view=rev Log: [NFC] Fix wParentheses warning in ASTContext getFixedPointSemantics Change-Id: I862f00a548236872fe24f7da8eb2bf7917e123ff Modified: cfe/trunk/lib/AST/ASTCon

  1   2   >