[PATCH] D56424: [clang-tidy] Add check for underscores in googletest names.

MyDeveloperDay added a comment. In D56424#1356959 , @karepker wrote: > Hi all, ping on this patch. I've addressed all comments to the best of my > ability. Is there anything outstanding that needs to be changed? Round about this time of a review we norm

[PATCH] D56424: [clang-tidy] Add check for underscores in googletest names.

lebedev.ri added a comment. In D56424#1357471 , @MyDeveloperDay wrote: > In D56424#1356959 , @karepker wrote: > > > Hi all, ping on this patch. I've addressed all comments to the best of my > > ability. Is there a

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

MyDeveloperDay added a comment. In D55433#1351707 , @JonasToth wrote: > > I do not have commit rights. I'm not sure what constitutes someone who can > > commit, but let me contribute a little more before taking that step, I > > have another idea for a c

[PATCH] D56424: [clang-tidy] Add check for underscores in googletest names.

MyDeveloperDay added a comment. In D56424#1357481 , @lebedev.ri wrote: > In D56424#1357471 , @MyDeveloperDay > wrote: > > > In D56424#1356959 , @karepker > > wrote: > > > >

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

chandlerc added a subscriber: hans. chandlerc added a comment. Adding Hans so he can be aware of the progress. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56571/new/ https://reviews.llvm.org/D56571 ___ cfe-commits mailing list cfe-commits

[PATCH] D55340: NFC: Move dump of individual Stmts to TextNodeDumper

steveire closed this revision. steveire added a comment. Closing after it was reopened by spammer. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55340/new/ https://reviews.llvm.org/D55340 ___ cfe-commits mailing list

[PATCH] D56592: [clangd] Fix updated file detection logic in indexing

kadircet updated this revision to Diff 181735. kadircet marked 6 inline comments as done. kadircet added a comment. - Address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56592/new/ https://reviews.llvm.org/D56592 Files: clangd/index/Ba

[clang-tools-extra] r351170 - [clangd] Fix updated file detection logic in indexing

Author: kadircet Date: Tue Jan 15 01:03:33 2019 New Revision: 351170 URL: http://llvm.org/viewvc/llvm-project?rev=351170&view=rev Log: [clangd] Fix updated file detection logic in indexing Summary: Files without any symbols were never marked as updated during indexing, which resulted in failure

[PATCH] D56592: [clangd] Fix updated file detection logic in indexing

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE351170: [clangd] Fix updated file detection logic in indexing (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D56592?vs=181735&id=181736#toc Repository: rCT

r351172 - [ASTDump] NFC: Move dump of type nodes to NodeDumper

Author: steveire Date: Tue Jan 15 01:30:00 2019 New Revision: 351172 URL: http://llvm.org/viewvc/llvm-project?rev=351172&view=rev Log: [ASTDump] NFC: Move dump of type nodes to NodeDumper Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D56642 M

[PATCH] D56642: NFC: Move dump of type nodes to NodeDumper

This revision was automatically updated to reflect the committed changes. Closed by commit rC351172: [ASTDump] NFC: Move dump of type nodes to NodeDumper (authored by steveire, committed by ). Changed prior to commit: https://reviews.llvm.org/D56642?vs=181632&id=181738#toc Repository: rC Cla

[PATCH] D56006: [AST] Fix a -Wimplicit-fallthrough warning in ScanfFormatString.cpp

hans added a comment. Sorry for the late reply; I was on vacation. It seems Erich Keane already fixed this in r350941. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56006/new/ https://reviews.llvm.org/D56006 ___ cfe

r351175 - NFC: Move Decl node handling to TextNodeDumper

Author: steveire Date: Tue Jan 15 01:35:52 2019 New Revision: 351175 URL: http://llvm.org/viewvc/llvm-project?rev=351175&view=rev Log: NFC: Move Decl node handling to TextNodeDumper Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D56643 Modifie

[PATCH] D56643: NFC: Move Decl node handling to TextNodeDumper

This revision was automatically updated to reflect the committed changes. Closed by commit rC351175: NFC: Move Decl node handling to TextNodeDumper (authored by steveire, committed by ). Changed prior to commit: https://reviews.llvm.org/D56643?vs=181453&id=181740#toc Repository: rC Clang CH

[PATCH] D56707: Implement CXXCtorInitializer dump in terms of Visitor

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D56707 Files: include/clang/AST/TextNodeDumper.h lib/AST/ASTDumper.cpp lib/AST/TextNodeDumper.cpp Index: lib/AST/TextNodeDumpe

[PATCH] D56708: NFC: Implement OMPClause dump in terms of visitors

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D56708 Files: include/clang/AST/TextNodeDumper.h lib/AST/ASTDumper.cpp lib/AST/TextNodeDumper.cpp Index: lib/AST/TextNodeDumpe

[PATCH] D56709: Implement BlockDecl::Capture dump in terms of visitors

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D56709 Files: include/clang/AST/TextNodeDumper.h lib/AST/ASTDumper.cpp lib/AST/TextNodeDumper.cpp Index: lib/AST/TextNodeDumpe

r351177 - [clang][UBSan] Sanitization for alignment assumptions.

Author: lebedevri Date: Tue Jan 15 01:44:25 2019 New Revision: 351177 URL: http://llvm.org/viewvc/llvm-project?rev=351177&view=rev Log: [clang][UBSan] Sanitization for alignment assumptions. Summary: UB isn't nice. It's cool and powerful, but not nice. Having a way to detect it is nice though. [[

[PATCH] D55083: Re-arrange content in FunctionDecl dump

steveire updated this revision to Diff 181744. steveire added a comment. Update Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55083/new/ https://reviews.llvm.org/D55083 Files: lib/AST/ASTDumper.cpp test/AST/ast-dump-funcs.cpp Index: test/AST/ast-dump-funcs

[PATCH] D56708: NFC: Implement OMPClause dump in terms of visitors

steveire updated this revision to Diff 181749. steveire added a comment. Update Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56708/new/ https://reviews.llvm.org/D56708 Files: include/clang/AST/TextNodeDumper.h lib/AST/ASTDumper.cpp lib/AST/TextNodeDumper.

[PATCH] D56709: Implement BlockDecl::Capture dump in terms of visitors

steveire updated this revision to Diff 181751. steveire added a comment. Update Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56709/new/ https://reviews.llvm.org/D56709 Files: include/clang/AST/TextNodeDumper.h lib/AST/ASTDumper.cpp lib/AST/TextNodeDumper.

[PATCH] D56429: fix python3 compability issue

jstasiak marked an inline comment as done. jstasiak added inline comments. Comment at: bindings/python/clang/cindex.py:3001 +contents = b(contents) +unsaved_files_array[i].name = b(fspath(name)) +unsaved_files_array[i].contents = co

[PATCH] D56646: [OpenCL] opencl-c.h: read_image*(): sampler-less, and image{1, 2}d_array_t variants are OpenCL-1.2+, mark them as such

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Overall I feel we need to find some way to test the header better... Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56646/new/ https://reviews.llvm.

[PATCH] D56646: [OpenCL] opencl-c.h: read_image*(): sampler-less, and image{1,2}d_array_t variants are OpenCL-1.2+, mark them as such

lebedev.ri added a comment. In D56646#1357650 , @Anastasia wrote: > LGTM! Thank you for the review. In D56646#1357650 , @Anastasia wrote: > Overall I feel we need to find some way to test the header better...

[PATCH] D56661: [clang-tidy] Fix incorrect array name generation in cppcoreguidelines-pro-bounds-constant-array-index

Quolyk updated this revision to Diff 181763. Quolyk added a comment. Patch is not yet fixed. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56661/new/ https://reviews.llvm.org/D56661 Files: clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIndexC

r351188 - [OpenCL] opencl-c.h: read_image*(): sampler-less, and image{1, 2}d_array_t variants are OpenCL-1.2+, mark them as such

Author: lebedevri Date: Tue Jan 15 03:20:02 2019 New Revision: 351188 URL: http://llvm.org/viewvc/llvm-project?rev=351188&view=rev Log: [OpenCL] opencl-c.h: read_image*(): sampler-less, and image{1,2}d_array_t variants are OpenCL-1.2+, mark them as such Summary: Refer to [[ https://www.khronos.

[PATCH] D55850: [OpenCL] Allow address spaces as method qualifiers

brunodf added inline comments. Comment at: lib/Sema/SemaType.cpp:4877 T = Context.getFunctionType(T, ParamTys, EPI); T = state.getSema().Context.getAddrSpaceQualType(T, AS); } else { I follow all of the above (from the point "a clas

[PATCH] D56611: [clangd] A code action to swap branches of an if statement

ilya-biryukov added inline comments. Comment at: clangd/refactor/actions/SwapIfBranches.cpp:36 + + bool VisitIfStmt(IfStmt *If) { +auto R = toHalfOpenFileRange(Ctx.getSourceManager(), Ctx.getLangOpts(), jkorous wrote: > It seems to me we don't find If token

[PATCH] D56646: [OpenCL] opencl-c.h: read_image*(): sampler-less, and image{1, 2}d_array_t variants are OpenCL-1.2+, mark them as such

This revision was automatically updated to reflect the committed changes. Closed by commit rL351188: [OpenCL] opencl-c.h: read_image*(): sampler-less, and image{1,2}d_array_t… (authored by lebedevri, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://revie

[PATCH] D56003: [RFC] [CFE] Allocatable Global Register Variables for ARM

carwil updated this revision to Diff 181766. carwil set the repository for this revision to rC Clang. carwil added a comment. Herald added a subscriber: cfe-commits. Added cfe-commits. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56003/new/ https://reviews.llvm.

[PATCH] D51866: [analyzer][UninitializedObjectChecker] New flag to ignore guarded uninitialized fields

Szelethus added a comment. Ping^2 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51866/new/ https://reviews.llvm.org/D51866 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D55083: Re-arrange content in FunctionDecl dump

steveire marked an inline comment as done. steveire added inline comments. Comment at: test/AST/ast-dump-funcs.cpp:59 // CHECK: CXXMethodDecl 0x{{[^ ]*}} col:8 f 'void (float, int)' + // CHECK-NEXT: Overrides: [ 0x{{[^ ]*}} S::f 'void (float, int)' ] // CHECK-NEXT: ParmV

[PATCH] D55256: [clangd] Support clang-tidy configuration in clangd.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice! I think we should get to `.clang-tidy` files subsequently, but this is a great start and allows us to hook up the right set of checks in other environments. Com

[PATCH] D56680: [Tooling] Make clang-tool find libc++ dir on mac when running on a file without compilation database.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56680/new/ https://reviews.llvm.org/D56680 ___

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

joerg added a comment. As discussed with dankm on IRC, I still would like to see the correct behavior going into 8.0, i.e. not change it later. Since this also matters for potential faster implementations later, it seems like a good idea to do it now. The changes are well-localized. (1) Do pat

Re: r351172 - [ASTDump] NFC: Move dump of type nodes to NodeDumper

On Tue, Jan 15, 2019 at 4:33 AM Stephen Kelly via cfe-commits wrote: > > Author: steveire > Date: Tue Jan 15 01:30:00 2019 > New Revision: 351172 > > URL: http://llvm.org/viewvc/llvm-project?rev=351172&view=rev > Log: > [ASTDump] NFC: Move dump of type nodes to NodeDumper > > Reviewers: aaron.ball

Re: r351175 - NFC: Move Decl node handling to TextNodeDumper

On Tue, Jan 15, 2019 at 4:39 AM Stephen Kelly via cfe-commits wrote: > > Author: steveire > Date: Tue Jan 15 01:35:52 2019 > New Revision: 351175 > > URL: http://llvm.org/viewvc/llvm-project?rev=351175&view=rev > Log: > NFC: Move Decl node handling to TextNodeDumper > > Reviewers: aaron.ballman >

Re: r351160 - [X86] Make _xgetbv/_xsetbv on non-windows platforms

I'm seeing breakages on v8 with this, it defines its own _xgetbv. Any ideas what do do about this? https://chromium.googlesource.com/v8/v8.git/+/master/src/x64/assembler-x64.cc#36 src/x64/assembler-x64.cc:35:1: error: inline variables are incompatible with C++ standards before C++17 [-Werror,-Wc+

[PATCH] D56718: [clangd] Update docs to mention YCM integration and new LSP features

kadircet created this revision. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D56718 Files: docs/clangd.rst Index: docs/clangd.rst ==

[clang-tools-extra] r351194 - Update year in license files

Author: hans Date: Tue Jan 15 07:10:32 2019 New Revision: 351194 URL: http://llvm.org/viewvc/llvm-project?rev=351194&view=rev Log: Update year in license files In last year's update (D48219) it was suggested that the release manager might want to do this, so here we go. Modified: clang-tools

[libunwind] r351194 - Update year in license files

Author: hans Date: Tue Jan 15 07:10:32 2019 New Revision: 351194 URL: http://llvm.org/viewvc/llvm-project?rev=351194&view=rev Log: Update year in license files In last year's update (D48219) it was suggested that the release manager might want to do this, so here we go. Modified: libunwind/t

[libclc] r351194 - Update year in license files

Author: hans Date: Tue Jan 15 07:10:32 2019 New Revision: 351194 URL: http://llvm.org/viewvc/llvm-project?rev=351194&view=rev Log: Update year in license files In last year's update (D48219) it was suggested that the release manager might want to do this, so here we go. Modified: libclc/trun

r351194 - Update year in license files

Author: hans Date: Tue Jan 15 07:10:32 2019 New Revision: 351194 URL: http://llvm.org/viewvc/llvm-project?rev=351194&view=rev Log: Update year in license files In last year's update (D48219) it was suggested that the release manager might want to do this, so here we go. Modified: cfe/trunk/L

r351196 - Reduce ASTMatchers stack footprint. Addresses http://llvm.org/PR38851

Author: alexfh Date: Tue Jan 15 07:34:26 2019 New Revision: 351196 URL: http://llvm.org/viewvc/llvm-project?rev=351196&view=rev Log: Reduce ASTMatchers stack footprint. Addresses http://llvm.org/PR38851 The BoundNodesTreeBuilder class is used both directly and indirectly as a local variable in ma

[PATCH] D56723: [CodeComplete] Propagate preferred types through parser in more cases

ilya-biryukov created this revision. ilya-biryukov added reviewers: kadircet, rsmith. Preferred types are used by code completion for ranking. This commit considerably increases the number of points in code where those types are propagated. In order to avoid complicating signatures of Parser's me

[PATCH] D56723: [CodeComplete] Propagate preferred types through parser in more cases

ilya-biryukov added a comment. @kadircet for preferred-type related bits. @rsmith for parser-related bits. More specifically, (1) should we be worried that this might affect parser performance on the hot path and (2) whether there are better alternatives to do something like this. Repository:

[PATCH] D55868: [Fixed Point Arithmetic] Fixed Point Addition Constant Expression Evaluation

ebevhan added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:7568 +static bool EvaluateFixedPoint(const Expr *E, APValue &Result, EvalInfo &Info) { + if (E->getType()->isFixedPointType()) { This could provide an APFixedPoint rather than APValue.

[PATCH] D56661: [clang-tidy] Fix incorrect array name generation in cppcoreguidelines-pro-bounds-constant-array-index

JonasToth added a comment. Thank you for working on this! Could you please run the check over LLVM or any other significant codebase once you have the fix implemented and report if the transformation still breaks code? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://r

r351200 - Remove irrelevant references to legacy git repositories from

Author: jyknight Date: Tue Jan 15 08:18:52 2019 New Revision: 351200 URL: http://llvm.org/viewvc/llvm-project?rev=351200&view=rev Log: Remove irrelevant references to legacy git repositories from compiler identification lines in test-cases. (Doing so only because it's then easier to search for re

[PATCH] D56728: Regression test case for r350891 [Correct the source range returned from preprocessor callbacks]

rupprecht created this revision. rupprecht added a reviewer: aaron.ballman. Herald added subscribers: cfe-commits, jsji, kbarton, nemanjai. r350891 caused some internal failures that this test case exposes. Repository: rC Clang https://reviews.llvm.org/D56728 Files: unittests/Lex/PPCallbac

[clang-tools-extra] r351208 - Revert "Update clang-tools-extra for r350891 from Clang."

Author: d0k Date: Tue Jan 15 09:20:04 2019 New Revision: 351208 URL: http://llvm.org/viewvc/llvm-project?rev=351208&view=rev Log: Revert "Update clang-tools-extra for r350891 from Clang." This reverts commit r350892. Modified: clang-tools-extra/trunk/test/modularize/ProblemsInconsistent.modu

r351209 - Revert "Correct the source range returned from preprocessor callbacks."

Author: d0k Date: Tue Jan 15 09:20:05 2019 New Revision: 351209 URL: http://llvm.org/viewvc/llvm-project?rev=351209&view=rev Log: Revert "Correct the source range returned from preprocessor callbacks." This reverts commit r350891. Also add a test case that would return an empty string with r35089

Re: r350891 - Correct the source range returned from preprocessor callbacks.

With this patch some ranges just come back empty. I rolled the change back in r351209, which also includes a test case that shows the empty ranges with this patch. On Thu, Jan 10, 2019 at 10:26 PM Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: aaronballman > Date: Th

[PATCH] D56718: [clangd] Update docs to mention YCM integration and new LSP features

ilya-biryukov added inline comments. Comment at: docs/clangd.rst:125 + +One of the options of using :program:`Clangd` in :program:`vim` is to utilize +`YouCompleteMe Given how little information we actually provide for each option here (it's literally just point

r351210 - Revert "[X86] Make _xgetbv/_xsetbv on non-windows platforms"

Author: d0k Date: Tue Jan 15 09:23:36 2019 New Revision: 351210 URL: http://llvm.org/viewvc/llvm-project?rev=351210&view=rev Log: Revert "[X86] Make _xgetbv/_xsetbv on non-windows platforms" This reverts commit r351160. Breaks building v8. Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.

Re: r351160 - [X86] Make _xgetbv/_xsetbv on non-windows platforms

I rolled it back for now in r351210, this pattern seems to be quite common even outside of v8. Let's figure out if we can keep the code working or if it needs to be fixed all over the place :( On Tue, Jan 15, 2019 at 3:02 PM Benjamin Kramer wrote: > I'm seeing breakages on v8 with this, it defin

[PATCH] D56728: Regression test case for r350891 [Correct the source range returned from preprocessor callbacks]

rupprecht abandoned this revision. rupprecht added a comment. Looks like this test case was submitted as part of rL351209 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56728/new/ https://reviews.llvm.org/D56728 ___

[PATCH] D56267: [clangd] Interfaces for writing code actions

sammccall added a comment. Offline discussion: - CRTP doesn't buy anything. Simple inheritance is less clean than current function-passing version but probably more familiar. - `Tweak` is a good name: short, evocative but not commonly used, works as a noun and a verb. - Registry might be a good

r351212 - Fix cpu-dispatch MV regression caused by r347812

Author: erichkeane Date: Tue Jan 15 09:51:09 2019 New Revision: 351212 URL: http://llvm.org/viewvc/llvm-project?rev=351212&view=rev Log: Fix cpu-dispatch MV regression caused by r347812 r347812 permitted forward declarations for cpu-dispatch functions, which are occassionally useful as exposition

Re: r344241 - [tests] Include Python binding tests in CMake rules

The tests probably shouldn't run when LLVM_ENABLE_PIC=OFF is set, since they all fail there (due to lib/libclang.so not existing). On Thu, Oct 11, 2018 at 7:59 AM Michal Gorny via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: mgorny > Date: Thu Oct 11 04:58:14 2018 > New Revision: 34

Re: r344241 - [tests] Include Python binding tests in CMake rules

On Tue, 2019-01-15 at 13:10 -0500, Nico Weber wrote: > The tests probably shouldn't run when LLVM_ENABLE_PIC=OFF is set, since > they all fail there (due to lib/libclang.so not existing). Hmm, maybe we could make them conditional to the existence of libclang.so target? Would that work for you? >

[PATCH] D56731: Add -Wimplicit-ctad warning to diagnose CTAD on types with no user defined deduction guides.

EricWF created this revision. EricWF added reviewers: rsmith, james.dennett, gromer. Some style guides want to allow using CTAD only on types that "opt-in"; i.e. on types that are designed to support it and not just types that *happen* to work with it. This patch implements the `-Wimplicit-ctad

Re: r344241 - [tests] Include Python binding tests in CMake rules

As long as check-all passes with LLVM_ENABLE_PIC=OFF I'm happy :-) (Note it's .dylib on macOS and .dll on Windows, and by default setting LLVM_ENABLE_PIC=OFF causes a static library to be created instead on non-win). On Tue, Jan 15, 2019 at 1:16 PM Michał Górny wrote: > On Tue, 2019-01-15 at 13:

[PATCH] D53541: [COFF, ARM64] Do not emit x86_seh_recoverfp intrinsic

mgrang added a comment. In D53541#1356904 , @rnk wrote: > In D53541#1353251 , @mgrang wrote: > > > > What about the three stack pointer case of stack realignment plus a > > > dynamic alloca? Typically this is the c

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

JonasToth added a comment. In D55433#1357483 , @MyDeveloperDay wrote: > In D55433#1351707 , @JonasToth wrote: > > > > I do not have commit rights. I'm not sure what constitutes someone who > > > can commit, but le

r351217 - [Solaris] Move enabling IAS for SPARC from the Solaris toolchain to Generic_GCC.

Author: brad Date: Tue Jan 15 10:24:03 2019 New Revision: 351217 URL: http://llvm.org/viewvc/llvm-project?rev=351217&view=rev Log: [Solaris] Move enabling IAS for SPARC from the Solaris toolchain to Generic_GCC. Modified: cfe/trunk/lib/Driver/ToolChains/Gnu.cpp cfe/trunk/lib/Driver/ToolCh

[PATCH] D56731: Add -Wimplicit-ctad warning to diagnose CTAD on types with no user defined deduction guides.

lebedev.ri added inline comments. Comment at: include/clang/Basic/DiagnosticGroups.td:1054 + +def ImplicitCTADUsage : DiagGroup<"implicit-ctad">; Should this be in some group? Alternatively, would it make sense to add it to new `-Wctad` group?

Re: r351160 - [X86] Make _xgetbv/_xsetbv on non-windows platforms

Does V8 work with gcc which also has _xgetbv? Or is it because I had to make _xgetbv a macro to make the patch work? ~Craig On Tue, Jan 15, 2019 at 9:28 AM Benjamin Kramer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > I rolled it back for now in r351210, this pattern seems to be quite

[PATCH] D56732: [clang] [test] Disable Python binding tests w/ LLVM_ENABLE_PIC=OFF

mgorny created this revision. mgorny added a reviewer: thakis. Disable Python binding tests when LLVM_ENABLE_PIC is disabled, as libclang.so is not being built in that case. Reported by Nico Weber. @thakis, could you test it, please? Repository: rC Clang https://reviews.llvm.org/D56732 Fil

[PATCH] D56563: [clang-tidy] add options documentation to readability-identifier-naming checker

JonasToth added a comment. Thank you very much for working on this! See https://bugs.llvm.org/show_bug.cgi?id=34990 for the bug report, I mentionend this revision. TBH i did not read through all the document, but scrolled mostly starting from 25%, it looks good to me. Given its length, what do

[PATCH] D56731: Add -Wimplicit-ctad warning to diagnose CTAD on types with no user defined deduction guides.

Quuxplusone added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2129 +def warn_class_template_argument_deduction_no_user_defined_guides : Warning< + "class template argument deduction for %0 that has no user defined deduction guides" >, + InGroup, Def

[PATCH] D55676: [Modules] Fix decl order for DeclsInPrototype

bruno added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55676/new/ https://reviews.llvm.org/D55676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D56733: [OPENMP] update release note for implemented OMP 5.0 features

ABataev added a comment. It would be good to update `OpenMPSupport.rst` too to show supported features from OpenMP 5.0. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56733/new/ https://reviews.llvm.org/D56733 ___ cfe-commits mailing list c

Re: r351160 - [X86] Make _xgetbv/_xsetbv on non-windows platforms

I think the main issue is that libstdc++ 4.9 includes x86intrin.h transitively from . That's probably broken with all compilers :( On Tue, Jan 15, 2019 at 7:31 PM Craig Topper wrote: > Does V8 work with gcc which also has _xgetbv? Or is it because I had to > make _xgetbv a macro to make the patc

[PATCH] D56707: Implement CXXCtorInitializer dump in terms of Visitor

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56707/new/ https://reviews.llvm.org/D56707 ___

[PATCH] D56735: [OpenCL] Fix overloading ranking rules to work correctly for address space coversions

Anastasia created this revision. Anastasia added a reviewer: rjmccall. Herald added a subscriber: yaxunl. This bug was pointed out in https://reviews.llvm.org/D55850#inline-496966 https://reviews.llvm.org/D56735 Files: lib/Sema/SemaOverload.cpp test/SemaOpenCLCXX/address_space_overloading.c

[PATCH] D53541: [COFF, ARM64] Do not emit x86_seh_recoverfp intrinsic

rnk added a comment. I can't compile the example you gave yet because I haven't applied your patches locally, but this is the "three stack pointer" case that I have in mind: struct Foo { void (*ptr)(); int x, y, z; }; void escape(void *); void large_align(int a0, int a1, int a

[PATCH] D55868: [Fixed Point Arithmetic] Fixed Point Addition Constant Expression Evaluation

rjmccall added a comment. Yeah, I would recommend splitting the `APFixedPoint` in `APValue` changes into a separate patch. Comment at: clang/lib/AST/ExprConstant.cpp:9959 + } + llvm_unreachable("unknown cast resulting in fixed point value"); +} leonardchan w

[PATCH] D56708: NFC: Implement OMPClause dump in terms of visitors

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a nit. Comment at: lib/AST/ASTDumper.cpp:1462 const OMPExecutableDirective *Node) { - for (auto *C : Node->clauses()) { -dumpChild([=]

[PATCH] D55850: [OpenCL] Allow address spaces as method qualifiers

Anastasia updated this revision to Diff 181825. Anastasia added a comment. Rebased on top of recent related changes and addressed remaining review comments. This now depends on: https://reviews.llvm.org/D56735 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55850/new/ https://reviews.ll

[PATCH] D55850: [OpenCL] Allow address spaces as method qualifiers

Anastasia marked 3 inline comments as done. Anastasia added inline comments. Comment at: lib/Sema/SemaOverload.cpp:9279 +(CandAS1 != LangAS::opencl_generic && CandAS1 != LangAS::Default)) + return true; + } rjmccall wrote: > Anastasia wrote: > > rjm

[PATCH] D56735: [OpenCL] Fix overloading ranking rules to work correctly for address space coversions

rjmccall added a comment. Is there a reason not to just do `T1.getQualifiers() == T2.getQualifiers()`? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56735/new/ https://reviews.llvm.org/D56735 ___ cfe-commits mailing list cfe-commits@lists.l

r351222 - [Tooling] Make clang-tool find libc++ dir on mac when running on a file without compilation database.

Author: hokein Date: Tue Jan 15 11:05:50 2019 New Revision: 351222 URL: http://llvm.org/viewvc/llvm-project?rev=351222&view=rev Log: [Tooling] Make clang-tool find libc++ dir on mac when running on a file without compilation database. Summary: This is a regression of r348365. When clang-tools r

[PATCH] D56680: [Tooling] Make clang-tool find libc++ dir on mac when running on a file without compilation database.

This revision was automatically updated to reflect the committed changes. Closed by commit rC351222: [Tooling] Make clang-tool find libc++ dir on mac when running on a file without… (authored by hokein, committed by ). Changed prior to commit: https://reviews.llvm.org/D56680?vs=181637&id=181827

[PATCH] D56709: Implement BlockDecl::Capture dump in terms of visitors

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56709/new/ https://reviews.llvm.org/D56709 ___

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

rjmccall added a comment. In D53738#172 , @rjmccall wrote: > In D53738#1333276 , @leonardchan > wrote: > > > In D53738#1326071 , @rjmccall > > wrote: > > > > > I'm fine

[PATCH] D56731: Add -Wimplicit-ctad warning to diagnose CTAD on types with no user defined deduction guides.

EricWF marked 6 inline comments as done. EricWF added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2129 +def warn_class_template_argument_deduction_no_user_defined_guides : Warning< + "class template argument deduction for %0 that has no user defined d

[PATCH] D56731: Add -Wimplicit-ctad warning to diagnose CTAD on types with no user defined deduction guides.

EricWF updated this revision to Diff 181829. EricWF marked an inline comment as done. EricWF added a comment. Address inline comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56731/new/ https://reviews.llvm.org/D56731 Files: include/clang/Basic/DiagnosticGroups.td include/cla

[PATCH] D54428: [clangd] XPC transport layer, framework, test-client

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54428/new/ https://reviews.llvm.org/D54428 ___ cfe-commits mailing list cfe-commi

[PATCH] D56733: [OPENMP] update release note for implemented OMP 5.0 features

kkwli0 updated this revision to Diff 181834. kkwli0 added a comment. Add update in OpenMP support release note. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56733/new/ https://reviews.llvm.org/D56733 Files: docs/OpenMPSupport.rst docs/ReleaseNotes.rst Index: docs/ReleaseNotes.rst

[PATCH] D55394: Re-order type param children of ObjC nodes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D55394#1356941 , @rjmccall wrote: > This is the AST dumper. This is not a user feature. Clang developers are users, too. However, th

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

efriedma added inline comments. Comment at: include/clang/Basic/DiagnosticASTKinds.td:214 + def err_asm_invalid_operand_number_for_goto_labels : Error < +"invalid operand number which isn't point to a goto label in asm string">; } Grammar. Also, "invalid o

[PATCH] D56563: [clang-tidy] add options documentation to readability-identifier-naming checker

MyDeveloperDay added a comment. In D56563#1358149 , @JonasToth wrote: > > Given its length, what do you think about a short link-list at the beginning > that will point to the section in the docs? With that its easier to see whats > all handled by th

[PATCH] D56563: [clang-tidy] add options documentation to readability-identifier-naming checker

MyDeveloperDay updated this revision to Diff 181836. MyDeveloperDay marked 3 inline comments as done. MyDeveloperDay added a comment. Addressing review comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56563/new/ https://reviews.llvm.org/D56563 Files: docs/clang-tidy/checks/reada

[PATCH] D53541: [COFF, ARM64] Do not emit x86_seh_recoverfp intrinsic

mgrang added a comment. In D53541#1358210 , @rnk wrote: > I can't compile the example you gave yet because I haven't applied your > patches locally, but this is the "three stack pointer" case that I have in > mind: > > struct Foo { > void (*ptr)();

[PATCH] D53541: [COFF, ARM64] Do not emit x86_seh_recoverfp intrinsic

rnk added a comment. In D53541#1358310 , @mgrang wrote: > @rnk Thanks a lot for the clarification. Yes, I see o.x: 0 instead of 42. > Supporting this case would mean implementing recoverfp as well as support > generating the correct parent frame offset f

[PATCH] D56658: [MSP430] Add msp430 toochain

This revision was automatically updated to reflect the committed changes. Closed by commit rL351228: [MSP430] Provide a toolchain description (authored by asl, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D56658?vs=181531&id=181841#t

r351228 - [MSP430] Provide a toolchain description

Author: asl Date: Tue Jan 15 11:44:05 2019 New Revision: 351228 URL: http://llvm.org/viewvc/llvm-project?rev=351228&view=rev Log: [MSP430] Provide a toolchain description This is an initial implementation for msp430 toolchain including -mmcu option support -mhwmult options support -integrated-as

[PATCH] D56731: Add -Wimplicit-ctad warning to diagnose CTAD on types with no user defined deduction guides.

gromer added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2129 +def warn_class_template_argument_deduction_no_user_defined_guides : Warning< + "using class template argument deduction for %0 that has no user-defined deduction guides" >, + InGroup, De

r351229 - [Tooling] Fix broken compliation databse tests.

Author: hokein Date: Tue Jan 15 11:51:39 2019 New Revision: 351229 URL: http://llvm.org/viewvc/llvm-project?rev=351229&view=rev Log: [Tooling] Fix broken compliation databse tests. I forgot to update the unittest in r351222. Modified: cfe/trunk/unittests/Tooling/CompilationDatabaseTest.cpp

  1   2   3   >