[PATCH] D56608: [Darwin][Driver] Don't pass a file as object_path_lto during ThinLTO

This revision was automatically updated to reflect the committed changes. Closed by commit rC350970: [Darwin][Driver] Don't pass a file as object_path_lto during ThinLTO (authored by steven_wu, committed by ). Changed prior to commit: https://reviews.llvm.org/D56608?vs=181325&id=181361#toc Rep

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

joerg added a comment. Right, I'm not aware of anyone but FreeBSD really using the OSABI field. For FreeBSD it was a long standing hack around limitations in the ELF kernel loader. I'm not even sure if FreeBSD use(d) to set the OSABI field for the intermediate object files. CHANGES SINCE LAST

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

dankm updated this revision to Diff 181363. dankm added a comment. renamed err_drv_invalid_argument_to_prefix_map to err_drv_invalid_argument_to_option added more frontend tests for macro-prefix-map and file-prefix-map. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

dankm marked 4 inline comments as done. dankm added a comment. In D49466#1354468 , @Lekensteyn wrote: > Could you add more tests to check the error message for bad options (missing > `=`): > > -fdebug-prefix-map=bad > -fmacro-prefix-map=bad > -ffile

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

krytarowski added a comment. Actually probably Linux MIPS used it and some proprietary OSes.. but we skip them for now. Only FreeBSD sets OSABI in lld and uses an emulation name detection hack. Once we will get merged TripleTarget detection we can switch it to use proper Triple check. CHANGES

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in LLVM

jyu2 marked an inline comment as done. jyu2 added inline comments. Comment at: lib/Sema/SemaStmtAsm.cpp:470 +if (NS->isGCCAsmGoto() && +Exprs[ConstraintIdx]->getStmtClass() == Stmt::AddrLabelExprClass) + break; efriedma wrote: > jyu2 wrote: > > e

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

krytarowski added a comment. In D56215#1350179 , @ruiu wrote: > To be honest, I don't think I would lgtm a patch that changes lld's default > behavior depending on host/target only for NetBSD, and it seems like a > NetBSD's issue rather than an lld's iss

[PATCH] D56555: Add Attribute to define nonlazy objc classes

joedaniels29 updated this revision to Diff 181371. joedaniels29 added a comment. Tried to fix Aaron Ballman's feedback. Thanks Aaron! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56555/new/ https://reviews.llvm.org/D56555 Files: clang/include/clang/Basic/Attr

[PATCH] D55500: [Builtins] Implement __builtin_is_constant_evaluated for use in C++2a

rsmith added a comment. In D55500#1347493 , @EricWF wrote: > @rsmith, what sorts of additional tests are needed? Let's see... - test that we use the constant initializer for suitably-constant-initialized locals even if we can't constant-fold the refere

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Awesome! Thanks a lot ! LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54945/new/ https://reviews.llvm.org/D54945 ___ cfe-commits mail

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

ruiu added a comment. In D56554#1353572 , @krytarowski wrote: > What do you think about this new logic: > > 1. specified `-z execstack` -> do not emit GNU STACK segment > 2. specified `-z noexecstack` -> emit GNU STACK segment > 3. no option specified -> d

r350982 - [analyzer] Support for OSObjects out parameters in RetainCountChecker

Author: george.karpenkov Date: Fri Jan 11 15:35:17 2019 New Revision: 350982 URL: http://llvm.org/viewvc/llvm-project?rev=350982&view=rev Log: [analyzer] Support for OSObjects out parameters in RetainCountChecker rdar://46357478 rdar://47121327 Differential Revision: https://reviews.llvm.org/D56

r350981 - [analyzer] Introduce a convenience method for getting a CallEvent from an arbitrary Stmt

Author: george.karpenkov Date: Fri Jan 11 15:35:04 2019 New Revision: 350981 URL: http://llvm.org/viewvc/llvm-project?rev=350981&view=rev Log: [analyzer] Introduce a convenience method for getting a CallEvent from an arbitrary Stmt Differential Revision: https://reviews.llvm.org/D56300 Modified

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in LLVM

efriedma added inline comments. Comment at: lib/Analysis/CFG.cpp:1474 + appendScopeBegin(JT.block, VD, G); + addSuccessor(B, JT.block); +} Please don't copy-paste code. Comment at: lib/Sema/SemaStmtAsm.cpp:470 +if

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

Lekensteyn added a comment. Except one thing, it looks reasonable to me. I'll try to run some tests and report back tomorrow. (Not very familiar with Phabricator either. I still see some comments, hopefully the "Collapse" function does something useful here.) Comment at: tes

[PATCH] D56620: [COFF, ARM64] Include stdlib.h in arm64intr.h

mgrang created this revision. mgrang added reviewers: rnk, efriedma, ssijaric, TomTan, haripul. Herald added subscribers: kristof.beyls, javed.absar. We mimic x86 behavior which includes stdlib.h in x86intr.h. Repository: rC Clang https://reviews.llvm.org/D56620 Files: lib/Headers/arm64int

[PATCH] D56620: [COFF, ARM64] Include stdlib.h in arm64intr.h

efriedma added a comment. Have you verified this matches MSVC? (IIRC the only reason we include stdlib.h on x86 is so we can define _mm_malloc.) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56620/new/ https://reviews.llvm.org/D56620

[PATCH] D56620: [COFF, ARM64] Include stdlib.h in arm64intr.h

mgrang added a comment. In D56620#1354979 , @efriedma wrote: > Have you verified this matches MSVC? (IIRC the only reason we include > stdlib.h on x86 is so we can define _mm_malloc.) I don't see MSVC intrin.h including stdlib.h. So I guess I will just

[PATCH] D56620: [COFF, ARM64] Declare intrinsics: __nop, _byteswap_[short/long/uint64]

mgrang updated this revision to Diff 181390. mgrang retitled this revision from "[COFF, ARM64] Include stdlib.h in arm64intr.h" to "[COFF, ARM64] Declare intrinsics: __nop, _byteswap_[short/long/uint64]". mgrang edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

Eugene.Zelenko added a comment. I would suggest to rename //contribution// to //Contributing// (see LLVM documentation) and //integrations// to //Integrations//. Will be also good idea to fix D55523 script warnings. CHANGES SINCE LAST ACTION https://reviews

[PATCH] D55491: Implement TemplateArgument dumping in terms of Visitor

steveire updated this revision to Diff 181395. steveire added a comment. Updates Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55491/new/ https://reviews.llvm.org/D55491 Files: include/clang/AST/TemplateArgumentVisitor.h include/clang/AST/TextNodeDumper.h

r350984 - NFC: Port loop to cxx_range_for

Author: steveire Date: Fri Jan 11 16:42:59 2019 New Revision: 350984 URL: http://llvm.org/viewvc/llvm-project?rev=350984&view=rev Log: NFC: Port loop to cxx_range_for Modified: cfe/trunk/lib/AST/ASTDumper.cpp Modified: cfe/trunk/lib/AST/ASTDumper.cpp URL: http://llvm.org/viewvc/llvm-project

[PATCH] D56620: [COFF, ARM64] Declare intrinsics: __nop, _byteswap_[ushort/ulong/uint64]

efriedma added inline comments. Comment at: lib/Headers/intrin.h:569 +unsigned __int64 _byteswap_uint64 (unsigned __int64 val); +void __nop(); #endif Isn't there already a declaration of __nop in intrin.h? (Line 100.) CHANGES SINCE LAST ACTION https://revie

[PATCH] D56620: [COFF, ARM64] Declare intrinsics: __nop, _byteswap_[ushort/ulong/uint64]

TomTan added a comment. We need full definition for __nop in intrin.h. Comment at: lib/Headers/intrin.h:569 +unsigned __int64 _byteswap_uint64 (unsigned __int64 val); +void __nop(); #endif efriedma wrote: > Isn't there already a declaration of __nop in intrin.

[PATCH] D55616: Emit ASM input in a constant context

george.karpenkov added a comment. @void @efriedma I can't build XNU anymore after this commit, with an error message: osfmk/i386/genassym.c:298:2: error: value '18446743523953737728' out of range for constraint 'n' DECLAREULL("KERNEL_BASE", KERNEL_BASE); ^~

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in LLVM

jyu2 updated this revision to Diff 181403. jyu2 added a comment. Couple of change to respond Eli’s comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56571/new/ https://reviews.llvm.org/D56571 Files: include/clang/AST/Expr.h include/clang/AST/ExprCXX.h include/clang/AST/Expr

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in LLVM

jyu2 marked 3 inline comments as done. jyu2 added inline comments. Comment at: lib/Analysis/CFG.cpp:1474 + appendScopeBegin(JT.block, VD, G); + addSuccessor(B, JT.block); +} efriedma wrote: > Please don't copy-paste code. :-( changed

[PATCH] D55616: Emit ASM input in a constant context

george.karpenkov added a comment. Apologies - the value seems to indeed overflow, but I'm still very confused how this was affected by this change. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55616/new/ https://reviews.llvm.org/D55616 __

[PATCH] D55616: Emit ASM input in a constant context

void added a comment. > Apologies - the value seems to indeed overflow, but I'm still very confused > how this was affected by this change. What's different is that `setRequiresImmediate` is being set on the constraint where before it wasn't. If no range values are supplied (like in this patch)

[PATCH] D56353: Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer' with'-mframe-pointer='

tabloid.adroit added a comment. gentle ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56353/new/ https://reviews.llvm.org/D56353 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-b

Re: r350984 - NFC: Port loop to cxx_range_for

On Fri, Jan 11, 2019 at 7:46 PM Stephen Kelly via cfe-commits wrote: > > Author: steveire > Date: Fri Jan 11 16:42:59 2019 > New Revision: 350984 > > URL: http://llvm.org/viewvc/llvm-project?rev=350984&view=rev > Log: > NFC: Port loop to cxx_range_for Thanks for the cleanup! > > Modified: >

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in LLVM

jyu2 marked 2 inline comments as done. jyu2 added inline comments. Comment at: lib/Sema/SemaStmtAsm.cpp:470 +if (NS->isGCCAsmGoto() && +Exprs[ConstraintIdx]->getStmtClass() == Stmt::AddrLabelExprClass) + break; jyu2 wrote: > efriedma wrote: > > j

[PATCH] D55491: Implement TemplateArgument dumping in terms of Visitor

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from nits that aren't complete yet, LGTM. Comment at: include/clang/AST/TemplateArgumentVisitor.h:24 +/// A simple visitor class that helps create templat

[PATCH] D55491: Implement TemplateArgument dumping in terms of Visitor

thakis added a comment. Out of interest, what's the motivation for this? It seems to add way more code than it removes, so there must be some other advantage, but the patch description doesn't say. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55491/new/ https:

[PATCH] D56631: [MSVC Compat] Fix typo correction for inclusion directives.

vsapsai created this revision. vsapsai added reviewers: christylee, compnerd. Herald added subscribers: dexonsmith, jkorous. In MSVC compatibility mode we were checking not the typo corrected filename but the original filename. https://reviews.llvm.org/D56631 Files: clang/lib/Lex/PPDirectives

[PATCH] D56632: [analyzer] Track region liveness only through base regions.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, george.karpenkov, rnkovacs, mikhail.ramalho, Szelethus, baloghadamsoftware. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, a.sidorin, szepet, mgorny. This is a follow-up to D56042

[PATCH] D56632: [analyzer] Track region liveness only through base regions.

NoQ updated this revision to Diff 181419. NoQ marked an inline comment as done. NoQ added a comment. Prettify the unittest a bit, especially the `ASTMatcher` part of it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56632/new/ https://reviews.llvm.org/D56632 Files: include/clang/Stat

[PATCH] D55483: Introduce the callback attribute and emit !callback metadata

jdoerfert updated this revision to Diff 181420. jdoerfert marked 21 inline comments as done. jdoerfert added a comment. Style changes, clang-format, documentation improvements Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55483/new/ https://reviews.llvm.org/D5548

[PATCH] D55483: Introduce the callback attribute and emit !callback metadata

jdoerfert added a comment. Updated according to your comments. Comment at: lib/Sema/SemaDeclAttr.cpp:3481 + llvm::StringMap NameIdxMapping; + NameIdxMapping["__"] = -1; + aaron.ballman wrote: > This doesn't match the documentation -- I assume you switched fro

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

krytarowski added a comment. In D56554#1354885 , @ruiu wrote: > In D56554#1353572 , @krytarowski > wrote: > > > What do you think about this new logic: > > > > 1. specified `-z execstack` -> do not emit GNU STACK s

[PATCH] D55868: [Fixed Point Arithmetic] Fixed Point Addition Constant Expression Evaluation

leonardchan updated this revision to Diff 181421. leonardchan marked 13 inline comments as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55868/new/ https://reviews.llvm.org/D55868 Files: clang/include/clang/AST/APValue.h clang/include/clang/AST/Expr.h

[PATCH] D55868: [Fixed Point Arithmetic] Fixed Point Addition Constant Expression Evaluation

leonardchan added a comment. I ended up adding a lot to this patch, so feel free to let me know if I should split this up if it's more difficult to review. Changes: - Remove default ctors for `APFixedPoint` and `FixedPointSemantics`. The main reason I had these was so in the `EvaluateAsFixedPo

<    1   2