[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

krytarowski added a comment. On 03.01.2019 21:19, Joerg Sonnenberger wrote: > On Thu, Jan 03, 2019 at 06:34:22PM +, Kamil Rytarowski via Phabricator > via cfe-commits wrote: > >> krytarowski added a comment. >> >> Actually I find it frustrating and unfair as GNU ld doesn't have builtin >>

[PATCH] D56241: expose a control flag for interger to pointer ext warning

Kader updated this revision to Diff 180124. Kader added a comment. Added test case for C_lang Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56241/new/ https://reviews.llvm.org/D56241 Files: include/clang/Basic/DiagnosticSemaKinds.td test/Misc/warning-flags.c

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

mgorny added a comment. We've discussed this a bit and given other changes we need to do, and I see pretty much three options here: 1. We hardcode stuff under `defined(__NetBSD__)` which kinda solves the problem, except lld won't be very cross-friendly. 2. We try to do conditionals based on tri

[PATCH] D56113: [OpenMP] Replace predetermined shared for const variable

jdenny added a comment. In D56113#1345535 , @ABataev wrote: > In D56113#1345529 , @jdenny wrote: > > > In D56113#1345238 , @ABataev wrote: > > > > > >>> By the way, is there

[PATCH] D56241: expose a control flag for interger to pointer ext warning

Kader added a comment. @lebedev.ri Thanks for the quick review ; > Perhaps there should be a test for this flag specifically? I am not really familiar with this part of the code base, but it seems that the warnings is already tested in both test/Sema/Compare.c and test/SemaCXX/compare.cpp. I

[PATCH] D56241: expose a control flag for interger to pointer ext warning

Kader updated this revision to Diff 180125. Kader added a comment. added missing test file Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56241/new/ https://reviews.llvm.org/D56241 Files: include/clang/Basic/DiagnosticSemaKinds.td test/Misc/warning-flags.c

[PATCH] D56113: [OpenMP] Replace predetermined shared for const variable

ABataev added a comment. In D56113#1345564 , @jdenny wrote: > In D56113#1345535 , @ABataev wrote: > > > In D56113#1345529 , @jdenny wrote: > > > > > In D56113#1345238

[PATCH] D56288: [ELF] Do not enable 'new dtags' on NetBSD by default

krytarowski added a comment. We want to keep it disabled by default on NetBSD.. but it would be to keep dynamic detection of target NetBSD rather than hardcoded ifdef. GNU ld sets it by default to false, following it would be the easiest option. Repository: rLLD LLVM Linker CHANGES SINCE LA

Re: [PATCH] D17741: adds __FILE_BASENAME__ builtin macro

On Thu, Jan 03, 2019 at 05:01:00PM +, Ximin Luo via cfe-commits wrote: > My patch that Roman quoted in the email below was an additional > mechanism to set -fmacro-prefix-map and -fdebug-prefix-map via an > environment variable. This was not accepted into GCC because they are > (in summary) all

Re: [PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

On Thu, Jan 03, 2019 at 08:31:53PM +, Kamil Rytarowski via Phabricator via cfe-commits wrote: > krytarowski added a comment. > > On 03.01.2019 21:19, Joerg Sonnenberger wrote: > > > On Thu, Jan 03, 2019 at 06:34:22PM +, Kamil Rytarowski via Phabricator > > via cfe-commits wrote: > > >

[PATCH] D56113: [OpenMP] Replace predetermined shared for const variable

jdenny added a comment. In D56113#1345578 , @ABataev wrote: > >>> By the way, LangOpts.OpenMP currently defaults to 0. Should it? > >> > >> Yes, it means it is disabled by default. > > > > Ah, it becomes 1 when we have `-fopenmp` but not `-fopenmp-versi

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D56113: [OpenMP] Replace predetermined shared for const variable

ABataev added a comment. In D56113#1345588 , @jdenny wrote: > In D56113#1345578 , @ABataev wrote: > > > >>> By the way, LangOpts.OpenMP currently defaults to 0. Should it? > > >> > > >> Yes, it means it is disable

[PATCH] D56241: expose a control flag for interger to pointer ext warning

lebedev.ri added inline comments. Comment at: test/Sema/ext-typecheck-comparison-of-pointer-integer.c:1 +// RUN: %clang_cc1 -triple x86_64-apple-darwin -fsyntax-only -verify -Wpointer-integer-compare %s + I guess you want a run-line with no flag, this runline,

[PATCH] D56188: Adopt SwiftABIInfo for WebAssembly.

ddunbar added a comment. In D56188#1343667 , @rjmccall wrote: > ...although it might be reasonable to extract the method implementations on > `DefaultABIInfo` as helper functions so that the code can be reused without > requiring a particular inheritance

[PATCH] D54450: Get the correct range of tokens for preprocessor conditions

vmiklos added a comment. Could you please review this one? It would be especially helpful, due to the depending other review. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54450/new/ https://reviews.llvm.org/D54450 ___ cfe-commits

[PATCH] D55710: add pragmas to control Software Pipelining optimisation

alexey.lapshin added a comment. Thank you! Aaron, Could you integrate this patch, please? I do not have commit access yet. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55710/new/ https://reviews.llvm.org/D55710 ___ cfe-commits mailing li

[PATCH] D54450: Get the correct range of tokens for preprocessor conditions

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. To me this looks like a reasonably straight-forward refactoring. I'm guessing the initial code had good test coverage, and none of those tests break; and the new code appears to have re

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

krytarowski added a comment. I think that ifdefining the linker options with `__NetBSD__` is no-go. In D56215#1345563 , @mgorny wrote: > We've discussed this a bit and given other changes we need to do, and I see > pretty much three options here: > > 1.

[PATCH] D56188: Adopt SwiftABIInfo for WebAssembly.

rjmccall added a comment. I don't mind you committing it like this. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56188/new/ https://reviews.llvm.org/D56188 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D55865: [ObjC] Add a new attribute to opt-out of implicit callee retain/release in ARC

erik.pilkington updated this revision to Diff 180131. erik.pilkington marked 4 inline comments as done. erik.pilkington added a comment. Address John's comments. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55865/new/ https://reviews.llvm.org/D55865 Files: clang/docs/Automat

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

krytarowski added a comment. On Thu, Jan 03, 2019 at 08:31:53PM +, Kamil Rytarowski via Phabricator via cfe-commits wrote: > krytarowski added a comment. > > On 03.01.2019 21:19, Joerg Sonnenberger wrote: > >> On Thu, Jan 03, 2019 at 06:34:22PM +, Kamil Rytarowski via Phabrica

[PATCH] D55865: [ObjC] Add a new attribute to opt-out of implicit callee retain/release in ARC

rjmccall added inline comments. Comment at: clang/docs/AutomaticReferenceCounting.rst:1749 +instance, capturing an externally-retained variable in a block will retain the +value when capturing it, and release it when the block is destroyed. + Nit-picks: `it's` sh

[PATCH] D55865: [ObjC] Add a new attribute to opt-out of implicit callee retain/release in ARC

erik.pilkington marked an inline comment as done. erik.pilkington added inline comments. Comment at: clang/docs/AutomaticReferenceCounting.rst:1779 +externally-retained, unless the variable was explicitly qualified with +``__strong``. For instance, ``first_param`` is externally-r

Re: [PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

On Thu, Jan 03, 2019 at 09:38:49PM +, Kamil Rytarowski via Phabricator via cfe-commits wrote: > I think that this place is not the right place to bash GNU ld for performance > issues. I didn't. > I will refer just to slides and paper from Ian Lance Taylor to get overview > why it is unacce

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

krytarowski added a comment. On 03.01.2019 23:15, Joerg Sonnenberger wrote: > On Thu, Jan 03, 2019 at 09:38:49PM +, Kamil Rytarowski via Phabricator via cfe-commits wrote: >> I think that this place is not the right place to bash GNU ld for performance issues. > > I didn't. >

[PATCH] D56113: [OpenMP] Replace predetermined shared for const variable

jdenny added a comment. In D56113#1345529 , @jdenny wrote: > In D56113#1345238 , @ABataev wrote: > > > >>> By the way, is there any value to keeping the predetermined shared for > > >>> const if -openmp-version=3.1

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

ruiu added a comment. In D56215#1345417 , @joerg wrote: > Talking from the perspective of having had to deal with thousands of packages > in pkgsrc over the years: it is naive to believe that there isn't a lot of > software that calls the linker directly

[PATCH] D56241: expose a control flag for interger to pointer ext warning

Kader updated this revision to Diff 180142. Kader added a comment. address comments Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56241/new/ https://reviews.llvm.org/D56241 Files: include/clang/Basic/DiagnosticSemaKinds.td test/Misc/warning-flags.c test/Se

Re: [PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

On Thu, Jan 03, 2019 at 10:26:38PM +, Rui Ueyama via Phabricator via cfe-commits wrote: > I see there are pros and cons to not have host-specific config in ld. > That said, if other operating systems can live without host-specific > config in lld, why can't NetBSD do? I really don't like to be

[PATCH] D56241: expose a control flag for interger to pointer ext warning

Kader updated this revision to Diff 180143. Kader added a comment. remove typo Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56241/new/ https://reviews.llvm.org/D56241 Files: include/clang/Basic/DiagnosticSemaKinds.td test/Misc/warning-flags.c test/Sema/ex

[PATCH] D56288: [ELF] Do not enable 'new dtags' on NetBSD by default

ruiu added a comment. The compiler driver should pass -disable-new-tags to the linker, but let's discuss that in https://reviews.llvm.org/D56215 instead of here. Repository: rLLD LLVM Linker CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56288/new/ https://reviews.llvm.org/D56288

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

krytarowski added a comment. In D56215#1345695 , @ruiu wrote: > In D56215#1345417 , @joerg wrote: > > > Talking from the perspective of having had to deal with thousands of > > packages in pkgsrc over the years: it

r350361 - [cmake] Fix monorepo + LLVM_BUILD_EXTERNAL_COMPILER_RT=ON.

Author: eugenis Date: Thu Jan 3 14:41:10 2019 New Revision: 350361 URL: http://llvm.org/viewvc/llvm-project?rev=350361&view=rev Log: [cmake] Fix monorepo + LLVM_BUILD_EXTERNAL_COMPILER_RT=ON. In cmake 3.10.2, if (${VARIABLE_NAME}) seems to always be false no matter what documentation says (or ma

[PATCH] D55955: Properly diagnose [[nodiscard]] on the body of a range-based for loop

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks, this looks great. A couple of the changes to the tests look like the diagnostic output is slightly worse in some error recovery conditions, but generally this is a nice improvement.

r350363 - Fix check-hwasan with LLVM_BUILD_EXTERNAL_COMPILER_RT=ON

Author: eugenis Date: Thu Jan 3 14:50:45 2019 New Revision: 350363 URL: http://llvm.org/viewvc/llvm-project?rev=350363&view=rev Log: Fix check-hwasan with LLVM_BUILD_EXTERNAL_COMPILER_RT=ON Add a forwarding target for check-hwasan in clang. Modified: cfe/trunk/runtime/CMakeLists.txt Modifi

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

krytarowski added a comment. Actually I think that we can handle two cases witch a combination of proposals: - native mode - cross mode For the native mode we go for something like: #if defined(__NetBSD__) #define NATIVE_TARGET LLD_NETBSD #else ... and for cross mode read `argv[0]` to

[PATCH] D55865: [ObjC] Add a new attribute to opt-out of implicit callee retain/release in ARC

erik.pilkington updated this revision to Diff 180154. erik.pilkington marked an inline comment as done. erik.pilkington added a comment. Remove support for parameter indices. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55865/new/ https://reviews.llvm.org/D55865 Files: clang/docs/Au

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

ruiu added a comment. Not sure what I understand the point, but as to make lld work on/for NetBSD, I wonder if you can just add -L to the command line in the compiler driver. Isn't a NetBSD triple passed to the compiler driver? If so, I wonder if you can add a few extra options when invoking th

r350371 - Fix MSVC visualizations for ActionResult and OpaquePtr

Author: mps Date: Thu Jan 3 15:24:39 2019 New Revision: 350371 URL: http://llvm.org/viewvc/llvm-project?rev=350371&view=rev Log: Fix MSVC visualizations for ActionResult and OpaquePtr Mainly just fixing buggy code. Also removed unnecessary visualizers for specializations of OpaquePtr Modified:

[PATCH] D56188: Adopt SwiftABIInfo for WebAssembly.

This revision was automatically updated to reflect the committed changes. Closed by commit rC350372: Adopt SwiftABIInfo for WebAssembly. (authored by ddunbar, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56188/new/ https://reviews.llvm.org/D56188

r350372 - Adopt SwiftABIInfo for WebAssembly.

Author: ddunbar Date: Thu Jan 3 15:24:50 2019 New Revision: 350372 URL: http://llvm.org/viewvc/llvm-project?rev=350372&view=rev Log: Adopt SwiftABIInfo for WebAssembly. Summary: - This adopts SwiftABIInfo as the base class for WebAssemblyABIInfo, which is in keeping with what is done for other

[PATCH] D56299: [OpenMP] Refactor const restriction for linear

jdenny created this revision. jdenny added a reviewer: ABataev. Herald added a subscriber: guansong. As discussed in D56113 , this patch refactors the implementation of the const restriction for linear to reuse a function introduced by D56113

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

krytarowski added a comment. In D56215#1345845 , @ruiu wrote: > Not sure what I understand the point, but as to make lld work on/for NetBSD, > I wonder if you can just add -L to the command line in the compiler > driver. Isn't a NetBSD triple passed to t

[PATCH] D52847: [clang-doc] Handle anonymous namespaces

juliehockett updated this revision to Diff 180182. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52847/new/ https://reviews.llvm.org/D52847 Files: clang-tools-extra/clang-doc/Representation.cpp clang-tools-extra/clang-doc/Representation.h clang-tools-extra/clang-doc/Serialize.cpp

[PATCH] D56303: Handle case/default statements when simplifying boolean expressions

LegalizeAdulthood created this revision. LegalizeAdulthood added a reviewer: cfe-commits. LegalizeAdulthood added a project: clang-tools-extra. Structure this similarly to the way replaceCompoundReturnWithCondition works. - Add readability-simplify-boolean-expr test cases for case stmt - Add read

[PATCH] D56303: Handle case/default statements when simplifying boolean expressions

LegalizeAdulthood updated this revision to Diff 180184. LegalizeAdulthood added a comment. clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56303/new/ https://reviews.llvm.org/D56303 Files: clang-tidy/readability/SimplifyBooleanExprCheck.cpp clang-tidy/readability/Simplif

[PATCH] D55662: [Sema][ObjC] Do not warn about repeated uses of weak variables when the variables are accessed in an unevaluated context.

ahatanak updated this revision to Diff 180186. ahatanak marked an inline comment as done. ahatanak added a comment. Do not record use of weak variables when the type of an auto variable is being deduced. I'm not sure creating an RAII class is the best way to silence the warning, but I haven't b

[PATCH] D56241: expose a control flag for interger to pointer ext warning

Kader marked 2 inline comments as done. Kader added inline comments. Comment at: test/Sema/ext-typecheck-comparison-of-pointer-integer.c:1 +// RUN: %clang_cc1 -triple x86_64-apple-darwin -fsyntax-only -verify -Wpointer-integer-compare %s + lebedev.ri wrote: >

[PATCH] D55865: [ObjC] Add a new attribute to opt-out of implicit callee retain/release in ARC

rjmccall added a comment. Sorry, I keep coming up with small tweaks to the documentation. These should be the last of them, so if Aaron's also satisfied, feel free to commit with those modifications. Comment at: clang/docs/AutomaticReferenceCounting.rst:1788 +// ... + }

[PATCH] D55662: [Sema][ObjC] Do not warn about repeated uses of weak variables when the variables are accessed in an unevaluated context.

rjmccall added a comment. I think you could just disable the diagnostic in an unevaluated context. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55662/new/ https://reviews.llvm.org/D55662 ___ cfe-commits mailing list

[PATCH] D55865: [ObjC] Add a new attribute to opt-out of implicit callee retain/release in ARC

erik.pilkington updated this revision to Diff 180196. erik.pilkington marked 3 inline comments as done. erik.pilkington added a comment. Mention `__has_attribute` and the ignored without -fobjc-arc thing. @aaron.ballman: Do you have any more thoughts here? CHANGES SINCE LAST ACTION https://re

[PATCH] D55662: [Sema][ObjC] Do not warn about repeated uses of weak variables when the variables are accessed in an unevaluated context.

ahatanak added a comment. In D55662#1346055 , @rjmccall wrote: > I think you could just disable the diagnostic in an unevaluated context. The call to `isUnevaluatedContext` in `ObjCPropertyOpBuilder::complete` returns false when the type of `auto __weak

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

mgorny added a comment. For the record, another option is to actually fix other software not to call LD directly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56215/new/ https://reviews.llvm.org/D56215 ___ cfe-commits mailing list cfe-com

[PATCH] D56241: expose a control flag for interger to pointer ext warning

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. ok, LGTM. Comment at: test/Sema/ext-typecheck-comparison-of-pointer-integer.c:1 +// RUN: %clang_cc1 -triple x86_64-apple-darwin -fsyntax-only -verify -Wpointer-inte

[PATCH] D55662: [Sema][ObjC] Do not warn about repeated uses of weak variables when the variables are accessed in an unevaluated context.

rjmccall added a comment. In D55662#1346059 , @ahatanak wrote: > In D55662#1346055 , @rjmccall wrote: > > > I think you could just disable the diagnostic in an unevaluated context. > > > The call to `isUnevaluatedCo

<    1   2