[PATCH] D52674: [AST] Add Obj-C discriminator to MS ABI RTTI

rnk added a comment. Well, you could go further down the route of what we do for "structors", and store the top-level decl being mangled in the mangler. Would that solve the problem? Repository: rC Clang https://reviews.llvm.org/D52674 ___ cfe-

r347364 - Reinstate 347294 with a fix for the failures.

Author: void Date: Tue Nov 20 15:24:16 2018 New Revision: 347364 URL: http://llvm.org/viewvc/llvm-project?rev=347364&view=rev Log: Reinstate 347294 with a fix for the failures. EvaluateAsInt() is sometimes called in a constant context. When that's the case, we need to specify it as so. Modified:

[clang-tools-extra] r347366 - Update EvaluateAsInt to the new syntax.

Author: void Date: Tue Nov 20 15:24:39 2018 New Revision: 347366 URL: http://llvm.org/viewvc/llvm-project?rev=347366&view=rev Log: Update EvaluateAsInt to the new syntax. Modified: clang-tools-extra/trunk/clang-tidy/bugprone/MisplacedWideningCastCheck.cpp clang-tools-extra/trunk/clang-tid

[PATCH] D40988: Clang-format: add finer-grained options for putting all arguments on one line

russellmcc added a comment. Bump! Thanks again for your consideration. https://reviews.llvm.org/D40988 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54550: Mark lambda decl as invalid if a captured variable has an invalid type.

jgorbe updated this revision to Diff 174853. jgorbe marked 2 inline comments as done. https://reviews.llvm.org/D54550 Files: clang/lib/Sema/SemaExpr.cpp clang/test/SemaCXX/lambda-invalid-array-capture.cpp clang/test/SemaCXX/lambda-invalid-capture.cpp Index: clang/test/SemaCXX/lambda-inval

[PATCH] D54550: Mark lambda decl as invalid if a captured variable has an invalid type.

jgorbe added a comment. Added a test for the "capturing an array of incomplete type" case. See also responses to inline comments below. Comment at: clang/lib/Sema/SemaExpr.cpp:14946 + // as invalid as well. + if (const CXXRecordDecl *RD = FieldType->getAsCXXRecordDecl()) { +

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

cameron.mcinally added a comment. In https://reviews.llvm.org/D53157#1304275, @kpn wrote: > In https://reviews.llvm.org/D53157#1303398, @cameron.mcinally wrote: > > > If we all agree upon that, then we simply have to treat the functions that > > modify the FPEnv, e.g. fesetexcept(...), as barrie

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

hfinkel added a comment. In https://reviews.llvm.org/D53157#1304873, @cameron.mcinally wrote: > In https://reviews.llvm.org/D53157#1304275, @kpn wrote: > > > In https://reviews.llvm.org/D53157#1303398, @cameron.mcinally wrote: > > > > > If we all agree upon that, then we simply have to treat the

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

cameron.mcinally added a comment. In https://reviews.llvm.org/D53157#1304347, @uweigand wrote: > OK, let me try to expand on my point 3 above, which appears to have confused > everybody :-) Ah, that makes more sense. The problem I was missing is when a FENV_ACCESS=OFF operation, like a FDIV,

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

cameron.mcinally added a comment. In https://reviews.llvm.org/D53157#1304880, @hfinkel wrote: > In https://reviews.llvm.org/D53157#1304873, @cameron.mcinally wrote: > > > I'd like to hear more about this. The fesetexcept(...) function and friends > > change the FPEnv state, which can change the

r347371 - Implement YAML serialization of notes in clang::tooling::Diagnostic.

Author: alexfh Date: Tue Nov 20 17:06:32 2018 New Revision: 347371 URL: http://llvm.org/viewvc/llvm-project?rev=347371&view=rev Log: Implement YAML serialization of notes in clang::tooling::Diagnostic. Modified: cfe/trunk/include/clang/Tooling/DiagnosticsYaml.h cfe/trunk/unittests/Tooling

r347372 - clang::tooling::Diagnostic: Don't store offset in the scratch space.

Author: alexfh Date: Tue Nov 20 17:08:46 2018 New Revision: 347372 URL: http://llvm.org/viewvc/llvm-project?rev=347372&view=rev Log: clang::tooling::Diagnostic: Don't store offset in the scratch space. These offsets are useless (and even harmful in certain cases) in exported diagnostics. The test

[clang-tools-extra] r347373 - [clang-tidy] Add a test for proper handling of locations in scratch space.

Author: alexfh Date: Tue Nov 20 17:11:18 2018 New Revision: 347373 URL: http://llvm.org/viewvc/llvm-project?rev=347373&view=rev Log: [clang-tidy] Add a test for proper handling of locations in scratch space. This test examines the behavior change of clang::tooling::Diagnostic in r347372. Added:

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

andrew.w.kaylor added a comment. In https://reviews.llvm.org/D53157#1304895, @cameron.mcinally wrote: > The problem I was missing is when a FENV_ACCESS=OFF operation, like a FDIV, > is hoisted into a FENV_ACCESS=ON region. I see it now, but still think that > forcing FENV_ACCESS=OFF operations

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

cameron.mcinally added a comment. In https://reviews.llvm.org/D53157#1304900, @andrew.w.kaylor wrote: > I think at this point we're all on the same page in this regard. I just > wanted to make sure we also understand why we're on that page. I still > believe it was the correct choice. Yup, we

[PATCH] D54737: [clang-tidy] Add the abseil-duration-comparison check

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/abseil-duration-comparison.rst:11 +compared against a floating-pointer value, truncation during the ``Duration`` +conversion might yield a different result. In practice this is very rare, and +still indicat

[PATCH] D51268: [libc++] Implement P0487R1 - Fixing operator>>(basic_istream&, CharT*)

This revision was automatically updated to reflect the committed changes. Closed by commit rCXX347377: [libc++] Implement P0487R1 - Fixing operator>>(basic_istream&, CharT*) (authored by lichray, committed by ). Changed prior to commit: https://reviews.llvm.org/D51268?vs=174722&id=174864#toc

[PATCH] D54781: [clangd] Add 'Switch header/source' command in clangd-vscode

malaperle created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Alt+o is used on Windows/Linux and Option+Cmd+o on macOS. Signed-off-by: Marc-Andre Laperle Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D5478

[PATCH] D54781: [clangd] Add 'Switch header/source' command in clangd-vscode

malaperle updated this revision to Diff 174866. malaperle added a comment. Fix a bad change Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54781 Files: clangd/clients/clangd-vscode/package.json clangd/clients/clangd-vscode/src/extension.ts Index: clangd/clients/clangd-vsc

[PATCH] D54741: [Driver] Link sanitizer runtime deps on Fuchsia when needed

This revision was automatically updated to reflect the committed changes. Closed by commit rC347378: [Driver] Link sanitizer runtime deps on Fuchsia when needed (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D54741?vs=174728&id=174868#toc Repository: r

r347378 - [Driver] Link sanitizer runtime deps on Fuchsia when needed

Author: phosek Date: Tue Nov 20 20:33:44 2018 New Revision: 347378 URL: http://llvm.org/viewvc/llvm-project?rev=347378&view=rev Log: [Driver] Link sanitizer runtime deps on Fuchsia when needed Even though these deps weren't needed, this makes Fuchsia driver better match other drivers, and it may

[PATCH] D54550: Mark lambda decl as invalid if a captured variable has an invalid type.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks good, thanks! (Though we generally prefer fewer test files with more test per file, because a lot of the overhead of running tests is the setup / teardown time, so can you merge the two

[PATCH] D54724: [Driver] Automatically include C++ library dependencies

dim added a comment. In https://reviews.llvm.org/D54724#1303844, @phosek wrote: > In https://reviews.llvm.org/D54724#1303809, @dim wrote: > > > I think this is the wrong direction, placing "common" code in > > `addCXXStdlibLinkDeps`, which then has all kinds of ugly ifs and switches > > for dif

Re: r345099 - [analyzer] Trust summaries for OSObject::retain and OSObject::release

Hi George, I noticed that valgrind started complaining in one case with this patch. I've no idea if it's really due to something in the patch or if it's something old that surfaced or if it's a false flag. Anyway, with this patch the following valgrind clang-tidy -checks='-*,clang-analyzer-*

<    1   2