nickdesaulniers created this revision.
nickdesaulniers added reviewers: srhines, pirama, danalbert.
Herald added subscribers: cfe-commits, kristof.beyls, javed.absar.
Partial revert of r330873 ('[Driver] Reland "Android triples are not
aliases for other triples."')
While we don't want `-target aa
vsk added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:2871
+ auto *DI = CGF.getDebugInfo();
+ SourceLocation Loc = DI ? DI->getLocation() : SourceLocation();
+ auto DL = ApplyDebugLocation::CreateDefaultArtificial(CGF, Loc);
aprantl wrote:
> vsk wrote:
NoQ added a comment.
Hmm, i guess i sent this out too early.
As per our long-lasting tradition, i forgot the point about the web page :\
Bullets about RUN-lines, Checkers.td descriptions and CMakeLists are also great
for everyday use :)
https://reviews.llvm.org/D52984
_
Author: dergachev
Date: Fri Oct 19 17:29:24 2018
New Revision: 344823
URL: http://llvm.org/viewvc/llvm-project?rev=344823&view=rev
Log:
[analyzer] Be more plugin-friendly by moving static locals into .cpp files.
The GDMIndex functions return a pointer that's used as a key for looking up
data, but
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344823: [analyzer] Be more plugin-friendly by moving static
locals into .cpp files. (authored by dergachev, committed by ).
Herald added subscribers: llvm-commits, dkrupp, donat.nagy.
Changed prior to com
NoQ closed this revision.
NoQ added a comment.
Herald added subscribers: dkrupp, donat.nagy.
I committed both patches as https://reviews.llvm.org/rC344823 but it seems that
Phabricator doesn't pick up closing multiple revisions with the same commit, so
closing manually.
Also thanks!~
Reposito
NoQ accepted this revision.
NoQ added a comment.
I guess maybe let's skip stuff without examples and leave Objective-C
descriptions waiting on us?
Comment at: www/analyzer/available_checks.html:483
+
+LLVM Checkers
Wow, i never noticed this one. It seems to
srhines accepted this revision.
srhines added a comment.
This revision is now accepted and ready to land.
Please remove the reference to b/X in the commit message. LLVM doesn't allow
internal bug numbers, and you described the issue well enough without it.
Repository:
rC Clang
https://review
NoQ added a reviewer: dcoughlin.
NoQ added inline comments.
Herald added a subscriber: dkrupp.
Comment at: lib/StaticAnalyzer/Checkers/LocalizationChecker.cpp:1401-1402
checker->IsAggressive =
- mgr.getAnalyzerOptions().getBooleanOption("AggressiveReport", false);
+
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: dkrupp.
Thanks! Let's commit.
https://reviews.llvm.org/D53274
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
Author: ctopper
Date: Fri Oct 19 18:30:00 2018
New Revision: 344824
URL: http://llvm.org/viewvc/llvm-project?rev=344824&view=rev
Log:
[X86] When checking the bits in cpu_features for function multiversioning
dispatcher in the resolver, make sure all the required bits are set. Not just
one of the
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344824: [X86] When checking the bits in cpu_features for
function multiversioning… (authored by ctopper, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews
BillyONeal created this revision.
BillyONeal added reviewers: EricWF, mclow.lists.
The test is trying to avoid saying aligned_alloc on Windows' UCRT, which does
not (and can not) implement aligned_alloc. However, it's testing for c1xx,
meaning clang on Windows will fail this test when using the
BillyONeal updated this revision to Diff 170294.
BillyONeal added a comment.
Also fixed cstdlib tests.
https://reviews.llvm.org/D53466
Files:
test/std/depr/depr.c.headers/stdlib_h.pass.cpp
test/std/language.support/support.runtime/cstdlib.pass.cpp
Index: test/std/language.support/support.
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
I think this is awesome o_o
Comment at: include/clang/StaticAnalyzer/Core/AnalyzerOptions.def:70-71
+
+/// Controls the high-level analyzer mode, which influences the default
+///
NoQ added a comment.
Herald added a subscriber: dkrupp.
I guess we should consider the idea in
http://lists.llvm.org/pipermail/cfe-dev/2018-October/059864.html
Comment at: lib/Frontend/CompilerInvocation.cpp:343
}
+ // Check whether this really is a valid -analyzer
NoQ accepted this revision.
NoQ added a comment.
I'll use this.
And i think it's unfair to give users -analyzer-config and not give them a list
of options. Users should be able to discover either both or none of the two. If
a user goes far enough to start digging into non-driver options, such u
BillyONeal created this revision.
BillyONeal added reviewers: EricWF, mclow.lists.
https://reviews.llvm.org/D53468
Files:
test/support/msvc_stdlib_force_include.hpp
Index: test/support/msvc_stdlib_force_include.hpp
===
--- test/s
hubert.reinterpretcast requested changes to this revision.
hubert.reinterpretcast added inline comments.
This revision now requires changes to proceed.
Comment at: clang/lib/Sema/SemaOverload.cpp:3920
+
+ // Prefer a compatible vector conversion to lax vector conversion
+ // Fo
wuzish added inline comments.
Comment at: clang/test/Sema/altivec-generic-overload.c:3
+
+typedef signed char __v4sc __attribute__((__vector_size__(16)));
+typedef unsigned char __v4uc __attribute__((__vector_size__(16)));
hubert.reinterpretcast wrote:
> `__v4sc`
Author: ahatanak
Date: Fri Oct 19 19:11:45 2018
New Revision: 344827
URL: http://llvm.org/viewvc/llvm-project?rev=344827&view=rev
Log:
Disable unittests/clangd/JSONTransportTests.cpp on versions of macosx
earlier than 10.13.
rdar://problem/45310173
Modified:
clang-tools-extra/trunk/unittests
Author: rtrieu
Date: Fri Oct 19 19:15:58 2018
New Revision: 344828
URL: http://llvm.org/viewvc/llvm-project?rev=344828&view=rev
Log:
Make -Wfor-loop-analysis work with C++17
For now, disable the "variable in loop condition not modified" warning to not
be emitted when there is a structured binding
hubert.reinterpretcast added inline comments.
Comment at: clang/test/Sema/altivec-generic-overload.c:3
+
+typedef signed char __v4sc __attribute__((__vector_size__(16)));
+typedef unsigned char __v4uc __attribute__((__vector_size__(16)));
wuzish wrote:
> hubert.r
BillyONeal abandoned this revision.
BillyONeal added a comment.
Actually this doesn't work -- because we /FI this thing, this file is included
before the test gets to say _LIBCPP_ENABLE_DEPRECATION_WARNINGS.
https://reviews.llvm.org/D53468
___
cfe-
hwright added a comment.
Ping.
What are the next steps here?
https://reviews.llvm.org/D53339
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
Looks fine to me
https://reviews.llvm.org/D53466
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
BillyONeal closed this revision.
BillyONeal added a comment.
Thank you! :D
Committed r344829
https://reviews.llvm.org/D53466
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ctopper
Date: Fri Oct 19 20:51:52 2018
New Revision: 344832
URL: http://llvm.org/viewvc/llvm-project?rev=344832&view=rev
Log:
[X86] Add support for more than 32 features for __builtin_cpu_is
libgcc supports more than 32 features by adding a new 32-bit variable
__cpu_features2.
This adds
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Haha, fun!
Repository:
rC Clang
https://reviews.llvm.org/D53456
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
Author: ahatanak
Date: Fri Oct 19 22:45:01 2018
New Revision: 344833
URL: http://llvm.org/viewvc/llvm-project?rev=344833&view=rev
Log:
[CodeGen] Use the mangle context owned by CodeGenModule to correctly
mangle types of lambda objects captured by a block instead of creating a
new mangle context ev
101 - 130 of 130 matches
Mail list logo
