[PATCH] D52784: [ARM][AArch64] Pass through endianness flags to the GNU assembler and linker

peter.smith added a comment. Thanks for pointing that out, I'm out of office today, will look at describing the intention to fall through when I get back in on Monday. Comment at: lib/Driver/ToolChains/Gnu.cpp:241 + case llvm::Triple::thumbeb: +IsBigEndian = true; + case

[PATCH] D53417: [Clang][PowerPC] Choose a better candidate as function call if there is a compatible vector conversion instead of ambious call error

wuzish created this revision. wuzish added reviewers: hfinkel, nemanjai, Douglasgido, hubert.reinterpretcast, fpichet. There are 2 function variations with altivec type parameter. When we call them with argument of generic gcc vector type we would prefer to choose the variation with implicit ar

[PATCH] D51402: [OpenCL] Adding cl_intel_planar_yuv extension

sidorovd added a comment. Ping https://reviews.llvm.org/D51402 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52784: [ARM][AArch64] Pass through endianness flags to the GNU assembler and linker

xbolva00 added inline comments. Comment at: lib/Driver/ToolChains/Gnu.cpp:241 + case llvm::Triple::thumbeb: +IsBigEndian = true; + case llvm::Triple::arm: peter.smith wrote: > xbolva00 wrote: > > Gnu.cpp:241:17: warning: this statement may fall through > >

[PATCH] D53417: [Clang][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambious call error

wuzish added a comment. If anybody knows who are familiar with C/C++ function overload and code related to this issue, please feel free to add them as reviewers and subscribers. Repository: rC Clang https://reviews.llvm.org/D53417 ___ cfe-commit

[PATCH] D53372: [clang-tidy] Resolve readability-else-after-return false positive for constexpr if.

curdeius updated this revision to Diff 170152. curdeius added a comment. Fixed diff. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53372 Files: clang-tidy/readability/ElseAfterReturnCheck.cpp test/clang-tidy/readability-else-after-return-if-constexpr.cpp Index: test/clan

[PATCH] D53391: [clangd] Embed fixes as CodeAction, instead of clangd_fixes. Clean up serialization.

sammccall added a comment. Thanks! @arphaman, any concerns about the change to extension format? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53391 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

[PATCH] D53391: [clangd] Embed fixes as CodeAction, instead of clangd_fixes. Clean up serialization.

sammccall updated this revision to Diff 170153. sammccall marked an inline comment as done. sammccall added a comment. Don't call URIForFile again, rebase. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53391 Files: clangd/ClangdLSPServer.cpp clangd/Diagnostics.cpp clangd

[PATCH] D53072: [clang-format] Introduce the flag which allows not to shrink lines

yvvan added a comment. Do you know the better way to accomplish my aim than adding an option to libFormat? For example making a dependent library which serves a little different purpose than libFormat itself or something simpler? https://reviews.llvm.org/D53072 _

[PATCH] D51484: [OpenCL] Add support of cl_intel_device_side_avc_motion_estimation extension

AlexeySotkin added a comment. Ping https://reviews.llvm.org/D51484 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51340: Add /Zc:DllexportInlines option to clang-cl

takuto.ikuta added a comment. ping? Can I go forward in this way? https://reviews.llvm.org/D51340 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53400: [clangd] Remove the overflow log.

hokein updated this revision to Diff 170157. hokein marked an inline comment as done. hokein added a comment. Log the whole location when overflow happens. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53400 Files: clangd/XRefs.cpp clangd/index/Index.cpp clangd/index/Ind

[PATCH] D53400: [clangd] Remove the overflow log.

hokein added inline comments. Comment at: clangd/XRefs.cpp:43 + if (Line >= SymbolLocation::Position::MaxLine) +log("Get an overflowed line"); + return Line; sammccall wrote: > Log message could use more context. And I think it'd be really useful to > prin

[PATCH] D53400: [clangd] Remove the overflow log.

hokein updated this revision to Diff 170159. hokein added a comment. Minor cleanup. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53400 Files: clangd/XRefs.cpp clangd/index/Index.cpp clangd/index/Index.h unittests/clangd/IndexTests.cpp Index: unittests/clangd/IndexTe

[clang-tools-extra] r344777 - [clangd] Remove the overflow log.

Author: hokein Date: Fri Oct 19 01:35:24 2018 New Revision: 344777 URL: http://llvm.org/viewvc/llvm-project?rev=344777&view=rev Log: [clangd] Remove the overflow log. Summary: LLVM codebase has generated files (all are build/Target/XXX/*.inc) that exceed the MaxLine & MaxColumn. Printing these lo

[PATCH] D53400: [clangd] Remove the overflow log.

This revision was automatically updated to reflect the committed changes. Closed by commit rL344777: [clangd] Remove the overflow log. (authored by hokein, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D53400 Files: clang-tools-extra/t

r344778 - [OpenCL] Remove unwanted signedness conversion from tests

Author: mantognini Date: Fri Oct 19 02:01:37 2018 New Revision: 344778 URL: http://llvm.org/viewvc/llvm-project?rev=344778&view=rev Log: [OpenCL] Remove unwanted signedness conversion from tests The get_kernel_* functions used in cl20-device-side-enqueue.cl all return unsigned integers. This patc

[PATCH] D52873: Remove unwanted signedness conversion from tests

This revision was automatically updated to reflect the committed changes. Closed by commit rC344778: [OpenCL] Remove unwanted signedness conversion from tests (authored by mantognini, committed by ). Repository: rC Clang https://reviews.llvm.org/D52873 Files: test/SemaOpenCL/cl20-device-sid

[PATCH] D52873: Remove unwanted signedness conversion from tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL344778: [OpenCL] Remove unwanted signedness conversion from tests (authored by mantognini, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D528

[PATCH] D53369: [CodeComplete] Fix accessibility of protected members when accessing members implicitly.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. The change looks reasonable to me, I'd let @ilya-biryukov take a second look. Repository: rC Clang https://reviews.llvm.org/D53369 ___ cfe-com

[PATCH] D51633: [ASTImporter] Added error handling for AST import.

balazske added inline comments. Comment at: lib/AST/ASTImporter.cpp:8197 -void ASTImporter::ImportDefinition(Decl *From) { +Error ASTImporter::ImportDefinition_New(Decl *From) { Decl *To = Import(From); a_sidorin wrote: > ImportDefinitionOrError? The intenti

[PATCH] D53397: [MinGW] Link to correct openmp library

mstorsjo added a comment. Please add a testcase in test/Driver/, it looks like fopenmp.c there might be a good target to add a few lines in. Repository: rC Clang https://reviews.llvm.org/D53397 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D52730: [analyzer] ConversionChecker: handle floating point

donat.nagy updated this revision to Diff 170169. donat.nagy added a comment. Give a reference for the significand size values of the IEEE 754 floating point types; cleanup comments and formatting. Repository: rC Clang https://reviews.llvm.org/D52730 Files: lib/StaticAnalyzer/Checkers/Conv

[PATCH] D52730: [analyzer] ConversionChecker: handle floating point

donat.nagy marked 2 inline comments as done. donat.nagy added inline comments. Comment at: lib/StaticAnalyzer/Checkers/ConversionChecker.cpp:164 +// double and possibly long double on some systems +RepresentsUntilExp = 53; break; + case 32: d

[PATCH] D53427: [clangd] Replace StringRef in SymbolLocation with a char pointer.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. This would save us 8 bytes per ref, and buy us ~50MB in total for llvm index (from ~350MB to ~300 MB). The char pointer must be null-terminated

[PATCH] D53428: Adjust cl::opt uses for opt_storage refactored

yrouban created this revision. yrouban added reviewers: chandlerc, rsmith, reames, skatkov. Herald added a subscriber: cfe-commits. This patch fixes compilation errors that result from refactoring of LLVM cl::opt structures introduced by https://reviews.llvm.org/D53426. Basically for class-based

[PATCH] D53399: [clangd] Ensure that we reply to each call exactly once. NFC (I think!)

ioeric added inline comments. Comment at: clangd/ClangdLSPServer.cpp:182 + // - if there were multiple replies, only the first is sent + class ReplyOnce { +struct State { As discussed offline, we could potentially make this non-copyable to make harder to

[PATCH] D34796: upporting -f(no)-reorder-functions flag, clang side change

joerg added a comment. Excuse me for bring this up so late, but why do we want to make any such promises? As in: fundamentally, LLVM IR doesn't have any order property on the module level. I have yet so seen reasonable code where the order of functions matters for anything but performance. I've

[PATCH] D53339: [clang-tidy] Add the abseil-duration-factory-float check

JonasToth added inline comments. Comment at: clang-tidy/abseil/DurationFactoryFloatCheck.cpp:69 + // Macros are ignored. + if (Arg->getBeginLoc().isMacroID()) +return; hwright wrote: > JonasToth wrote: > > maybe `assert` instead, as your comment above sugge

[PATCH] D53433: [clangd] *Prototype* auto-index stores symbols per-file instead of per-TU.

ioeric created this revision. ioeric added reviewers: sammccall, hokein. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. This allows us to deduplicate header symbols across TUs. File digests are collects when collecting symbols/refs. And the index store

[PATCH] D53434: Java annotation declaration being handled correctly

SamMaier created this revision. Herald added a subscriber: cfe-commits. Previously, Java annotation declarations (`@interface AnnotationName`) were being handled as ObjC interfaces. This caused the brace formatting to mess up, so that when you had a class with an interface defined in it, it woul

[PATCH] D53417: [Clang][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:3908 + QualType ToType) { +assert(FromType->isVectorType() && "FromType should be a vector type"); +assert(ToType->isVectorType() &&

[PATCH] D53372: [clang-tidy] Resolve readability-else-after-return false positive for constexpr if.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r344784 - [ASTImporter] Removed uneeded default case label.

Author: balazske Date: Fri Oct 19 08:16:51 2018 New Revision: 344784 URL: http://llvm.org/viewvc/llvm-project?rev=344784&view=rev Log: [ASTImporter] Removed uneeded default case label. Modified: cfe/trunk/lib/AST/ASTImporter.cpp Modified: cfe/trunk/lib/AST/ASTImporter.cpp URL: http://llvm.o

[PATCH] D53433: [clangd] *Prototype* auto-index stores symbols per-file instead of per-TU.

sammccall added inline comments. Comment at: clangd/index/FileIndex.cpp:167 +} +// FIXME: aggregate symbol reference count based on references. +for (const auto &Sym : FileSyms.getValue()->Refs) { This is a good FIXME to carry over to FileSymbols::bui

[clang-tools-extra] r344785 - [clang-tidy] Resolve readability-else-after-return false positive for constexpr if.

Author: mkurdej Date: Fri Oct 19 08:26:17 2018 New Revision: 344785 URL: http://llvm.org/viewvc/llvm-project?rev=344785&view=rev Log: [clang-tidy] Resolve readability-else-after-return false positive for constexpr if. Summary: It fixes the false positive when using constexpr if and where else ca

[PATCH] D53372: [clang-tidy] Resolve readability-else-after-return false positive for constexpr if.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE344785: [clang-tidy] Resolve readability-else-after-return false positive for constexpr… (authored by mkurdej, committed by ). Changed prior to commit: https://reviews.llvm.org/D53372?vs=170152&id=170

r344786 - [Hexagon] Remove support for V4

Author: kparzysz Date: Fri Oct 19 08:36:45 2018 New Revision: 344786 URL: http://llvm.org/viewvc/llvm-project?rev=344786&view=rev Log: [Hexagon] Remove support for V4 Modified: cfe/trunk/docs/ClangCommandLineReference.rst cfe/trunk/include/clang/Driver/Options.td cfe/trunk/lib/Basic/T

[PATCH] D53404: [clangd] Set workspace root when initializing ClangdServer, disallow mutation.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE344787: [clangd] Set workspace root when initializing ClangdServer, disallow mutation. (authored by sammccall, committed by ). Changed prior to commit: https://reviews.llvm.org/D53404?vs=170098&id=170

[clang-tools-extra] r344787 - [clangd] Set workspace root when initializing ClangdServer, disallow mutation.

Author: sammccall Date: Fri Oct 19 08:42:23 2018 New Revision: 344787 URL: http://llvm.org/viewvc/llvm-project?rev=344787&view=rev Log: [clangd] Set workspace root when initializing ClangdServer, disallow mutation. Summary: Rename instance variable to WorkspaceRoot to match what we call it intern

[PATCH] D53434: Java annotation declaration being handled correctly

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Thanks for the fix! Do you happen to know what had regressed this? Repository: rC Clang https://reviews.llvm.org/D53434 ___ cfe-commits mailin

[PATCH] D34796: upporting -f(no)-reorder-functions flag, clang side change

twoh added a comment. @joerg Sorry but I'm not sure if I understand your question. This doesn't pretend to honor source code order, but makes linker to place "hot" functions under .text.hot section (There's no guarantee of ordering between functions inside .hot.text section) while "cold" functi

[PATCH] D34796: upporting -f(no)-reorder-functions flag, clang side change

twoh updated this revision to Diff 170205. twoh added a comment. Remove conflict line. Repository: rC Clang https://reviews.llvm.org/D34796 Files: docs/ClangCommandLineReference.rst include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def lib/CodeGen/BackendUtil.cpp

[PATCH] D53439: [clangd] Remove caching of compilation database commands.

sammccall created this revision. sammccall added reviewers: ioeric, ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. The CDB implementations used in open-source code are fast, and our private slow CDB will soon do the relevant caching itself. Simplifying

[PATCH] D53427: [clangd] Replace StringRef in SymbolLocation with a char pointer.

sammccall added a comment. Nice savings! My initial thought is that it seems weird to only do it for this one string - the readers look different, the serialization code has different logic etc for the different flavors of strings. The struct certainly looks nicer to my eyes. This may be the r

r344789 - Java annotation declaration being handled correctly

Author: hans Date: Fri Oct 19 09:19:52 2018 New Revision: 344789 URL: http://llvm.org/viewvc/llvm-project?rev=344789&view=rev Log: Java annotation declaration being handled correctly Previously, Java annotation declarations (@interface AnnotationName) were being handled as ObjC interfaces. This c

[PATCH] D53434: Java annotation declaration being handled correctly

This revision was automatically updated to reflect the committed changes. Closed by commit rL344789: Java annotation declaration being handled correctly (authored by hans, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D53434?vs=170197

[PATCH] D52301: [clang] Set TypeSourceInfo for vardecl's in addition to type when we can deduce.

ilya-biryukov added a comment. A few more comments, mostly marking places of unintentional changes that we need to revert. Hope it's not going past the point where the number of comments are not useful. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8616 "use of %se

[PATCH] D53441: [ms] Prevent explicit constructor name lookup if scope is missing

lantictac created this revision. lantictac added a reviewer: rsmith. lantictac added a project: clang. MicrosoftExt allows explicit constructor calls. Prevent lookup of constructor name unless the name has explicit scope. This avoids a compile-time crash due to confusing a member access for a co

[PATCH] D53369: [CodeComplete] Fix accessibility of protected members when accessing members implicitly.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. LGTM, thanks! Would be super-nice if didn't have to rewrite this in code completion Repository: rC Clang https://reviews.llvm.org/D53369 ___ cfe-commits mailing list cfe-commits

[PATCH] D52301: [clang] Set TypeSourceInfo for vardecl's in addition to type when we can deduce.

kadircet updated this revision to Diff 170215. kadircet added a comment. - Keep only relavant changes and rebase Repository: rC Clang https://reviews.llvm.org/D52301 Files: include/clang/AST/PrettyPrinter.h include/clang/Sema/Sema.h lib/AST/TypePrinter.cpp lib/Frontend/ASTConsumers.c

[PATCH] D52654: [OpenCL][NFC] Unify ZeroToOCL* cast types

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! https://reviews.llvm.org/D52654 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[PATCH] D53443: [OpenMP][NVPTX] Enable default scheduling for parallel for in non-SPMD cases.

gtbercea created this revision. gtbercea added reviewers: ABataev, caomhin. Herald added subscribers: cfe-commits, guansong, jholewinski. This patch enables the choosing of the default schedule for parallel for loops even in non-SPMD cases. Repository: rC Clang https://reviews.llvm.org/D5344

[PATCH] D53200: [OpenCL] Fix serialization of OpenCLExtensionDecls

Anastasia accepted this revision. Anastasia added inline comments. This revision is now accepted and ready to land. Comment at: test/Headers/opencl-pragma-extension-begin.cl:1 +// RUN: rm -rf %t +// RUN: mkdir -p %t I think the tests in this folder are for standa

r344795 - [Driver] Reland: Default Android toolchains to libc++.

Author: danalbert Date: Fri Oct 19 11:06:02 2018 New Revision: 344795 URL: http://llvm.org/viewvc/llvm-project?rev=344795&view=rev Log: [Driver] Reland: Default Android toolchains to libc++. The sanitizer builder that was broken by this should now be fixed. Original review was https://reviews.ll

[PATCH] D52296: [Clang] - Add -gsingle-file-split-dwarf option.

dblaikie added a comment. @echristo > As far as the standard text here, IMO it was just there in case people didn't > have an objcopy around or don't want to split it. I'm not sure why we would > want the ability. I think others have mentioned - but with distributed build it might be easier t

[PATCH] D51402: [OpenCL] Adding cl_intel_planar_yuv extension

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D51402 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D53334: [Frontend] Show diagnostics on prebuilt module configuration mismatch too

dblaikie added a comment. Don't know enough about the code to have an opinion on the fix - but in any case this would need a test case, if possible Repository: rC Clang https://reviews.llvm.org/D53334 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D53443: [OpenMP][NVPTX] Enable default scheduling for parallel for in non-SPMD cases.

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.h:350 void getDefaultScheduleAndChunk(CodeGenFunction &CGF, - const OMPLoopDirective &S, OpenMPScheduleClauseKind &ScheduleKind, + const OMPLoopDirective &S, OpenMPScheduleTy &ScheduleKind,

[PATCH] D52301: [clang] Set TypeSourceInfo for vardecl's in addition to type when we can deduce.

rsmith added a comment. In https://reviews.llvm.org/D52301#1267163, @kadircet wrote: > So in the middle of the patch we were just trying to figure out whether we > are going to break a big assumption that lots of different components relied > on but just didn't had any tests for. Maybe @rsmith

[PATCH] D51484: [OpenCL] Add support of cl_intel_device_side_avc_motion_estimation extension

Anastasia added inline comments. Comment at: lib/Headers/opencl-c.h:16197 +#ifdef cl_intel_device_side_avc_motion_estimation +#pragma OPENCL EXTENSION cl_intel_device_side_avc_motion_estimation : enable + Anastasia wrote: > Should we be using: > #pragma OPENCL

r344800 - Add basic test that we perform lifetime extension in the expected

Author: rsmith Date: Fri Oct 19 12:01:31 2018 New Revision: 344800 URL: http://llvm.org/viewvc/llvm-project?rev=344800&view=rev Log: Add basic test that we perform lifetime extension in the expected situations. Added: cfe/trunk/test/CXX/special/class.temporary/p6.cpp Added: cfe/trunk/test/CX

r344801 - PR24164, PR39336: init-captures are not distinct full-expressions.

Author: rsmith Date: Fri Oct 19 12:01:34 2018 New Revision: 344801 URL: http://llvm.org/viewvc/llvm-project?rev=344801&view=rev Log: PR24164, PR39336: init-captures are not distinct full-expressions. Rather, they are subexpressions of the enclosing lambda-expression, and any temporaries in them a

[PATCH] D53141: [OpenMP][libomptarget] Add runtime function for pushing coalesced global records

gtbercea updated this revision to Diff 170236. gtbercea added a comment. Herald added subscribers: cfe-commits, jholewinski. Refactor. Repository: rC Clang https://reviews.llvm.org/D53141 Files: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp Index: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp ==

[PATCH] D53443: [OpenMP][NVPTX] Enable default scheduling for parallel for in non-SPMD cases.

gtbercea updated this revision to Diff 170237. gtbercea added a comment. Refactor. Repository: rC Clang https://reviews.llvm.org/D53443 Files: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp Index: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp ==

[PATCH] D53141: [OpenMP][libomptarget] Add runtime function for pushing coalesced global records

gtbercea updated this revision to Diff 170238. gtbercea added a comment. Refactor. Repository: rOMP OpenMP https://reviews.llvm.org/D53141 Files: libomptarget/deviceRTLs/nvptx/src/data_sharing.cu libomptarget/deviceRTLs/nvptx/src/interface.h libomptarget/deviceRTLs/nvptx/src/omptarge

r344806 - Revert "[Driver] Reland: Default Android toolchains to libc++."

Author: danalbert Date: Fri Oct 19 12:23:01 2018 New Revision: 344806 URL: http://llvm.org/viewvc/llvm-project?rev=344806&view=rev Log: Revert "[Driver] Reland: Default Android toolchains to libc++." This reverts commit 84677d5009d613232d360fda27e6e41fb5cb6700. Modified: cfe/trunk/lib/Driver

[PATCH] D53448: [OpenMP][NVPTX] Use single loops when generating code for distribute parallel for

gtbercea created this revision. gtbercea added reviewers: ABataev, caomhin. Herald added subscribers: cfe-commits, guansong, jholewinski. This patch adds a new code generation path for bound sharing directives containing distribute parallel for. The new code generation scheme applies to chunked

[PATCH] D53448: [OpenMP][NVPTX] Use single loops when generating code for distribute parallel for

gtbercea updated this revision to Diff 170241. gtbercea added a comment. Rebase. Repository: rC Clang https://reviews.llvm.org/D53448 Files: include/clang/AST/StmtOpenMP.h include/clang/Basic/OpenMPKinds.h lib/AST/StmtOpenMP.cpp lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenM

[PATCH] D51866: [analyzer][UninitializedObjectChecker] New flag to ignore guarded uninitialized fields

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Code looks good to me, but I'd wait for @george.karpenkov because it was his idea. Comment at: lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObjectChecker.cpp:502

[PATCH] D53417: [Clang][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

hubert.reinterpretcast added inline comments. Comment at: clang/test/Sema/altivec-generic-overload.c:3 + +typedef signed char __v4sc __attribute__((__vector_size__(16))); +typedef unsigned char __v4uc __attribute__((__vector_size__(16))); `__v4sc` is suspicious.

[PATCH] D51866: [analyzer][UninitializedObjectChecker] New flag to ignore guarded uninitialized fields

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObjectChecker.cpp:515 + continue; +const auto *FirstAccess = Accesses[0].getNodeAs("access"); + I feel that it's a good practice to `assert(FirstAccess)`

[PATCH] D53406: [clangd] Provide excuses for bad code completions, based on diagnostics. C++ API only.

ilya-biryukov added a comment. Since we're showing the diagnostics in the editors anyway, how crucial do we think it is to actually add that to the procotol? Having more concrete reasons for misbehaving completions sounds more useful, though, e.g. "cannot complete members of the incomplete type"

[PATCH] D53454: [clang-tidy] add IgnoreMacros option to eadability-redundant-smartptr-get

vmiklos created this revision. vmiklos added reviewers: alexfh, sbenza. Herald added subscribers: cfe-commits, xazax.hun. And also enable it by default to be consistent with e.g. modernize-use-using. This helps e.g. when running this check on client code where the macro is provided by the

[PATCH] D53454: [clang-tidy] add IgnoreMacros option to eadability-redundant-smartptr-get

vmiklos added a comment. In practice cppunit's `CPPUNIT_TEST_SUITE_END` macro triggers this problem. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53454 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

[PATCH] D52730: [analyzer] ConversionChecker: handle floating point

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/ConversionChecker.cpp:163 + +switch (FloatingSize) { + case 64: Continuing the float semantics discussion on the new revision - Did you consider `llvm::APFloat`? (http://llvm.org/doxygen

[PATCH] D38061: Set AnonymousTagLocations false for ASTContext if column info is expected not to be used

echristo added a reviewer: aprantl. echristo added a comment. I think Adrian has looked at this more recently than I have. Adding him here. Repository: rC Clang https://reviews.llvm.org/D38061 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D52676: [clang-format] tweaked another case of lambda formatting

oleg.smolsky added a comment. In https://reviews.llvm.org/D52676#1268806, @djasper wrote: > In https://reviews.llvm.org/D52676#1268748, @oleg.smolsky wrote: > > > In https://reviews.llvm.org/D52676#1268706, @djasper wrote: > > > > > Ok, I think I agree with both of you to a certain extent, but I

[PATCH] D53456: [Sema] Do not show unused parameter warnings when body is skipped

ilya-biryukov created this revision. ilya-biryukov added reviewers: ioeric, sammccall. Herald added a subscriber: arphaman. Without the function body, we cannot determine is parameter was used. Repository: rC Clang https://reviews.llvm.org/D53456 Files: lib/Sema/SemaDecl.cpp test/Index/s

[PATCH] D52676: [clang-format] tweaked another case of lambda formatting

oleg.smolsky updated this revision to Diff 170270. oleg.smolsky added a comment. Generalized the patch so that it deals with lambda args irrespective of bin packing. Added additional tests and patched existing ones. Repository: rC Clang https://reviews.llvm.org/D52676 Files: lib/Format/Co

[PATCH] D53457: clang-cl: Add "/Xdriver:" pass-through arg support.

neerajksingh created this revision. neerajksingh added reviewers: rnk, hans. The clang-cl driver disables access to command line options outside of the "Core" and "CLOption" sets of command line arguments. This filtering makes it impossible to pass arguments that are interpreted by the clang drive

[PATCH] D52939: ExprConstant: Propagate correct return values from constant evaluation.

rsmith added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:711 + + /// Evaluate as a constant expression, as per C++11-and-later constexpr + /// rules. Stop if we find that the expression is not a constant jyknight wrote: > rsmith wrote: >

[PATCH] D38061: Set AnonymousTagLocations false for ASTContext if column info is expected not to be used

aprantl added a comment. I have a vague recollection that this column info hack was added to disambiguate two types defined on the same line (which is something that happened more often than one would think because of macro expansion). Did you do the git archeology to ensure that the original

[PATCH] D38061: Set AnonymousTagLocations false for ASTContext if column info is expected not to be used

aprantl added a comment. Oh wait, this patch is just for dumping the ASTs? Can you elaborate why this makes it into a binary then? Repository: rC Clang https://reviews.llvm.org/D38061 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:

[PATCH] D38061: Set AnonymousTagLocations false for ASTContext if column info is expected not to be used

aprantl added a comment. RTTI? Repository: rC Clang https://reviews.llvm.org/D38061 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53347: [clangd] Simplify auto hover

ilya-biryukov updated this revision to Diff 170273. ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. - Addressed review comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53347 Files: clangd/XRefs.cpp unittests/clangd/XRefsTests.cpp Inde

Re: [PATCH] D38061: Set AnonymousTagLocations false for ASTContext if column info is expected not to be used

On Fri, Oct 19, 2018 at 3:56 PM Adrian Prantl via Phabricator via llvm-commits wrote: > aprantl added a comment. > > I have a vague recollection that this column info hack was added to > disambiguate two types defined on the same line (which is something that > happened more often than one would

[PATCH] D52384: [Sema] Fix redeclaration contexts for enumerators in C

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. (Looks fine with a suitably-adjusted comment.) https://reviews.llvm.org/D52384 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lis

[PATCH] D52384: [Sema] Fix redeclaration contexts for enumerators in C

rsmith added inline comments. Comment at: lib/AST/DeclBase.cpp:1704-1705 + + // In C, the redeclaration context for enumerators is the translation unit, + // so we skip through transparent contexts as well as struct/union contexts. + bool SkipRecords = getDeclKind() == Decl::K

[PATCH] D53347: [clangd] Simplify auto hover

ilya-biryukov added a comment. In https://reviews.llvm.org/D53347#1267216, @kadircet wrote: > LGTM, it bugs me that some part in the documentation says it doesn't go > through decltype(`This looks through declarators like pointer types, but not > through decltype or typedefs`) but since tests c

[PATCH] D53457: clang-cl: Add "/Xdriver:" pass-through arg support.

hans added a comment. I haven't started looking at the code yet. I'm not completely convinced that we want this. So far we've used the strategy of promoting clang options that are also useful in clang-cl to core options, and if someone wants to use more clang than that, maybe clang-cl isn't the

[PATCH] D53459: Ensure sanitizer check function calls have a !dbg location

aprantl created this revision. aprantl added a reviewer: vsk. Function calls without a !dbg location inside a function that has a DISubprogram make it impossible to construct inline information and are rejected by the verifier. This patch ensures that sanitizer check function calls have a !dbg

[PATCH] D53460: [X86] When checking the bits in cpu_features for function multiversioning dispatcher in the resolver, make sure all the required bits are set. Not just one of them

craig.topper created this revision. craig.topper added reviewers: erichkeane, echristo. The multiversioning code repurposed the code from __builtin_cpu_supports for checking if a single feature is enabled. That code essentially performed (_cpu_features & (1 << C)) != 0. But with the multiversion

[PATCH] D50549: [libcxx] [test] Repair thread unsafety in thread tests

BillyONeal closed this revision. BillyONeal added a comment. Committed r344820 https://reviews.llvm.org/D50549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50551: [libcxx] [test] Add missing to several tests.

BillyONeal closed this revision. BillyONeal added a comment. Committed r344821 https://reviews.llvm.org/D50551 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53263: Fix places where the return type of a FunctionDecl was being used in place of the function type

bobsayshilol updated this revision to Diff 170277. bobsayshilol retitled this revision from "[CodeGen] Fix places where the return type of a FunctionDecl was being used in place of the function type" to "Fix places where the return type of a FunctionDecl was being used in place of the function t

[PATCH] D53329: Generate DIFile with main program if source is not available

dblaikie added a comment. @aprantl - yeah, not sure I have any big feels about this (nor do I fully understand it) @yonghong-song - could you explain this maybe in a bit more detail. What behavior does this fix provide? (compared to behavior of existing working cases that don't hit this bug, f

[PATCH] D53459: Ensure sanitizer check function calls have a !dbg location

vsk added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:2871 + auto *DI = CGF.getDebugInfo(); + SourceLocation Loc = DI ? DI->getLocation() : SourceLocation(); + auto DL = ApplyDebugLocation::CreateDefaultArtificial(CGF, Loc); Why shouldn't this always b

[PATCH] D53459: Ensure sanitizer check function calls have a !dbg location

aprantl added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:2871 + auto *DI = CGF.getDebugInfo(); + SourceLocation Loc = DI ? DI->getLocation() : SourceLocation(); + auto DL = ApplyDebugLocation::CreateDefaultArtificial(CGF, Loc); vsk wrote: > Why should

[PATCH] D52984: [analyzer] Checker reviewer's checklist

NoQ added a comment. My take on the out-of-alpha checklist: - The checker should be evaluated on a large codebase in order to discover crashes and false positives specific to the checker. It should demonstrate the expected reasonably good results on it, with the stress on having as little fals

  1   2   >