mgorny accepted this revision.
mgorny added a comment.
WFM. Thanks for analyzing the problem.
Comment at: bindings/python/tests/CMakeLists.txt:27
+# with ASan.
+if((NOT WIN32) AND (NOT LLVM_USE_ASAN))
set_property(GLOBAL APPEND PROPERTY
Hmm, I don't think
xbolva00 added a comment.
Thanks. ... So anything else to be done? Or it is ok?
https://reviews.llvm.org/D52750
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: vmiklos
Date: Sat Oct 13 00:58:05 2018
New Revision: 30
URL: http://llvm.org/viewvc/llvm-project?rev=30&view=rev
Log:
[clang-tidy] add IgnoreMacros option to modernize-use-equals-delete
And also enable it by default to be consistent with e.g. modernize-use-using.
This improves con
This revision was automatically updated to reflect the committed changes.
Closed by commit rL30: [clang-tidy] add IgnoreMacros option to
modernize-use-equals-delete (authored by vmiklos, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.o
baloghadamsoftware updated this revision to Diff 169552.
baloghadamsoftware added a comment.
Warning added to the docs.
https://reviews.llvm.org/D53187
Files:
clang-tidy/bugprone/ExceptionEscapeCheck.cpp
docs/clang-tidy/checks/bugprone-exception-escape.rst
test/clang-tidy/bugprone-excepti
baloghadamsoftware added a comment.
I think further optimization steps should be done is separate patches. However,
this is the biggest step.
https://reviews.llvm.org/D53187
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
JonasToth accepted this revision.
JonasToth added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D53187#1264415, @baloghadamsoftware wrote:
> I think further optimization steps should be done is separate patches.
> However, this is the biggest step.
Agr
JonasToth added inline comments.
Comment at: docs/ReleaseNotes.rst:113
+
+- New alias :doc:`cppcoreguidelines-non-private-member-variables-in-classes
+
`
lebedev.ri wrote:
> Eugene.Zelenko wrote:
> > Please move new alias after new checks.
> You mean after all
JonasToth added inline comments.
Comment at: clang-tidy/readability/ConstValueReturnCheck.cpp:64
+
+ // Fix the definition.
+ llvm::Optional Loc = findConstToRemove(Def, Result);
ymandel wrote:
> JonasToth wrote:
> > ymandel wrote:
> > > JonasToth wrote:
> > >
lebedev.ri updated this revision to Diff 169554.
lebedev.ri marked 8 inline comments as done.
lebedev.ri added a comment.
Hopefully address review notes:
- Support more (all?) obscure suffixes (complex, q, h, f16, i{8,16,32,64})
- Improve test coverage. There isn't coverage for every single
comb
lebedev.ri updated this revision to Diff 169555.
lebedev.ri added a comment.
Sort release notes.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52771
Files:
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTid
lebedev.ri added inline comments.
Comment at: docs/ReleaseNotes.rst:113
+
+- New alias :doc:`cppcoreguidelines-non-private-member-variables-in-classes
+
`
JonasToth wrote:
> lebedev.ri wrote:
> > Eugene.Zelenko wrote:
> > > Please move new alias after new check
JonasToth added a comment.
Unfortunatly this check does not compile on some ARM platforms. It seems that a
matcher exceeds the recursion limit in template instantations.
http://lab.llvm.org:8011/builders/clang-cmake-armv7-quick/builds/4405/steps/build%20stage%201/logs/stdio
I will revert the ch
Author: jonastoth
Date: Sat Oct 13 02:30:46 2018
New Revision: 31
URL: http://llvm.org/viewvc/llvm-project?rev=31&view=rev
Log:
Revert "[doc] fix markup in clang-tidy bugprone-not-null-terminated-result"
This reverts commit r344379.
Modified:
clang-tools-extra/trunk/docs/clang-tidy/
Author: jonastoth
Date: Sat Oct 13 02:30:58 2018
New Revision: 32
URL: http://llvm.org/viewvc/llvm-project?rev=32&view=rev
Log:
Revert "[clang-tidy] New checker for not null-terminated result caused by
strlen(), size() or equal length"
This reverts commit r344374.
Removed:
clang-too
JonasToth added inline comments.
Comment at: clang-tidy/readability/UppercaseLiteralSuffixCheck.cpp:94
+ // Else, find matching suffix, case-*insensitive*ly.
+ for (const auto &PotentialNewSuffix : NewSuffixes) {
+if (!OldSuffix.equals_lower(PotentialNewSuffix))
---
lebedev.ri updated this revision to Diff 169556.
lebedev.ri marked an inline comment as done.
lebedev.ri added a comment.
Bloat with `llvm::find_if()`
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52670
Files:
clang-tidy/cert/CERTTidyModule.cpp
clang-tidy/cert/CMakeLists.t
Author: baloghadamsoftware
Date: Sat Oct 13 03:24:48 2018
New Revision: 33
URL: http://llvm.org/viewvc/llvm-project?rev=33&view=rev
Log:
[Analyzer] Iterator Checker - Part 10: Tests for iterators passed as parameter
In earlier Clang Static Analyzer versions `check::Bind() was not invoked
This revision was automatically updated to reflect the committed changes.
Closed by commit rL34: [clang-tidy] Optimize query in
bugprone-exception-escape (authored by baloghadamsoftware, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.o
Author: baloghadamsoftware
Date: Sat Oct 13 03:34:52 2018
New Revision: 34
URL: http://llvm.org/viewvc/llvm-project?rev=34&view=rev
Log:
[clang-tidy] Optimize query in bugprone-exception-escape
Checking whether a functions throws indirectly may be very expensive because it
needs to visit
baloghadamsoftware closed this revision.
baloghadamsoftware added a comment.
Herald added a subscriber: donat.nagy.
Closed by commits in the previous comments, just URLs misspelled.
https://reviews.llvm.org/D32906
___
cfe-commits mailing list
cfe-co
baloghadamsoftware added a comment.
In https://reviews.llvm.org/D32906#1257140, @NoQ wrote:
> Also i'll have a look at whether the checker is in a good shape to be enabled
> by default. I suspect that mismatched iterators might be very safe to enable.
> With all these solver and rearrangement i
Author: baloghadamsoftware
Date: Sat Oct 13 04:17:59 2018
New Revision: 35
URL: http://llvm.org/viewvc/llvm-project?rev=35&view=rev
Log:
[clang-tidy] Fix for typos in the tests for `bugprone-exception-escape`
Modified:
clang-tools-extra/trunk/test/clang-tidy/bugprone-exception-escape
Charusso added a subscriber: klimek.
Charusso added a comment.
In https://reviews.llvm.org/D45050#1264435, @JonasToth wrote:
> Unfortunatly this check does not compile on some ARM platforms. It seems that
> a matcher exceeds the recursion limit in template instantations.
>
> http://lab.llvm.org:
orivej created this revision.
orivej added reviewers: bogner, rsmith, vsk, aaron.ballman.
Herald added a subscriber: cfe-commits.
popRegions used to assume that the start location of a region can't be nested
deeper than the end location, which is not always true.
Repository:
rC Clang
https:/
orivej updated this revision to Diff 169562.
orivej added a comment.
This looks better to me. (There is no difference in check-clang test results.)
Repository:
rC Clang
https://reviews.llvm.org/D53244
Files:
lib/CodeGen/CoverageMappingGen.cpp
test/CoverageMapping/macros.c
Index: test/Co
hamzasood added inline comments.
Comment at: CMakeLists.txt:550
+endif()
add_compile_flags_if_supported(
+-Wextra -W -Wwrite-strings
EricWF wrote:
> Couldn't we keep the "-Wall" here? And just add something else that adds
> "/W4"?
>
> Also, we don't yet su
xbolva00 updated this revision to Diff 169567.
xbolva00 added a comment.
- New diagnostic group
https://reviews.llvm.org/D52835
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaChecking.cpp
test/Sema/ext_vector_casts.c
Index: test/S
xbolva00 added a comment.
Libc++ fs works on Windows now?
https://reviews.llvm.org/D51868
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
orivej updated this revision to Diff 169568.
orivej added a comment.
Fix typo
Repository:
rC Clang
https://reviews.llvm.org/D53244
Files:
lib/CodeGen/CoverageMappingGen.cpp
test/CoverageMapping/macros.c
Index: test/CoverageMapping/macros.c
===
Author: hans
Date: Sat Oct 13 12:13:14 2018
New Revision: 344462
URL: http://llvm.org/viewvc/llvm-project?rev=344462&view=rev
Log:
Re-commit r344234 "clang-cl: Add /showFilenames option (PR31957)"
The test was failing on e.g. PPC which can't target Windows. Fix by
requiring X86 target in the test
Szelethus added a comment.
Herald added a subscriber: donat.nagy.
Ping, @NoQ, can you go a little bit more in depth about what you'd prefer to
see here?
https://reviews.llvm.org/D51531
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
This revision was automatically updated to reflect the committed changes.
Closed by commit rC344463: [analyzer] Small SMT API improvement (authored by
esteffin, committed by ).
Herald added subscribers: cfe-commits, donat.nagy.
Repository:
rC Clang
https://reviews.llvm.org/D52031
Files:
inc
This revision was automatically updated to reflect the committed changes.
Closed by commit rC344464: [analyzer] Improved cmake configuration for Z3
(authored by esteffin, committed by ).
Herald added subscribers: cfe-commits, donat.nagy.
Repository:
rC Clang
https://reviews.llvm.org/D50818
Fi
owenpan added a comment.
ping
Repository:
rC Clang
https://reviews.llvm.org/D52527
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: esteffin
Date: Sat Oct 13 12:42:10 2018
New Revision: 344463
URL: http://llvm.org/viewvc/llvm-project?rev=344463&view=rev
Log:
[analyzer] Small SMT API improvement
Summary: Removed const qualifier from reset method of SMTSolver and Z3Solver
objects.
Reviewers: mikhail.ramalho, george.ka
Author: esteffin
Date: Sat Oct 13 12:45:48 2018
New Revision: 344464
URL: http://llvm.org/viewvc/llvm-project?rev=344464&view=rev
Log:
[analyzer] Improved cmake configuration for Z3
Summary:
Enhanced support for Z3 in the cmake configuration of clang; now it is possible
to specify any arbitrary
echristo added a comment.
LGTM as well. Thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D52920
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mstorsjo updated this revision to Diff 169579.
mstorsjo retitled this revision from "[RFC] [MinGW] Print paths with forward
slashes in commands printed with -v" to "[RFC] [Driver] Use forward slashes in
most linker arguments".
mstorsjo edited the summary of this revision.
mstorsjo added a comment
Author: d0k
Date: Sat Oct 13 15:18:22 2018
New Revision: 344468
URL: http://llvm.org/viewvc/llvm-project?rev=344468&view=rev
Log:
Move some helpers from the global namespace into anonymous ones.
Modified:
clang-tools-extra/trunk/clangd/ClangdServer.cpp
Modified: clang-tools-extra/trunk/clang
Author: d0k
Date: Sat Oct 13 15:18:22 2018
New Revision: 344468
URL: http://llvm.org/viewvc/llvm-project?rev=344468&view=rev
Log:
Move some helpers from the global namespace into anonymous ones.
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/CallAndMessageChecker.cpp
cfe/trunk/lib/Static
Author: hans
Date: Sat Oct 13 15:22:03 2018
New Revision: 344469
URL: http://llvm.org/viewvc/llvm-project?rev=344469&view=rev
Log:
Try harder to fix test/Driver/cl-showfilenames.c
Follow-up to r344462.
Modified:
cfe/trunk/test/Driver/cl-showfilenames.c
Modified: cfe/trunk/test/Driver/cl-sho
phosek created this revision.
phosek added reviewers: pcc, jakehehrlich, echristo.
Herald added subscribers: cfe-commits, JDevlieghere, aprantl, mgorny.
This enables the driver support for direct split DWARF emission for
Fuchsia in addition to Linux.
Repository:
rC Clang
https://reviews.llvm.
phosek added a comment.
I'm fine moving the test to `test/Driver/split-debug.c` if you prefer to have
all target tests in a single file.
Repository:
rC Clang
https://reviews.llvm.org/D53248
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
vsk added a comment.
Thanks for looking into this! Do you know why the InitializationKind doesn't
contain the right brace locations in this scenario? Should it?
Repository:
rC Clang
https://reviews.llvm.org/D53231
___
cfe-commits mailing list
cf
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
I'm ok with the "here are a bunch of fuchsia tests" file :)
-eric
Repository:
rC Clang
https://reviews.llvm.org/D53248
___
cfe-commits ma
phosek created this revision.
phosek added reviewers: sidneym, rsmith.
Herald added a subscriber: cfe-commits.
Hexagon relies on hexagon-link so invoke Clang to -fuse-ld=ld to
always use the default linker, otherwise tests break when the Clang
default linker is set to anything other than default.
phosek added a comment.
This was introduced in https://reviews.llvm.org/D53038 which broke all our bots
that use `CLANG_DEFAULT_LINKER="lld"`. The same solution was applied to other
targets (e.g. https://reviews.llvm.org/D49899) and while isn't great it should
at least unbreak vendors that use
phosek created this revision.
phosek added reviewers: rsmith, Hahnfeld.
Herald added a subscriber: cfe-commits.
When the toolchain overrides default linker, use it rather than the
default Clang one which is unlikely to be useable for that toolchain
anyway. This avoids the need to explicitly specif
phosek added a comment.
This should avoid workarounds such as https://reviews.llvm.org/D49899 or
https://reviews.llvm.org/D53249.
Repository:
rC Clang
https://reviews.llvm.org/D53250
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
50 matches
Mail list logo
