phosek added inline comments.
Comment at: clang-tools-extra/unittests/clang-doc/MDGeneratorTest.cpp:44
+ assert(!Err);
+ std::string Expected = "# namespace Namespace\n"
+ "\n"
Can we use the C++11 raw string literals here and below to t
xbolva00 added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:10874
+ if (Target->isSpecificBuiltinType(BuiltinType::LongDouble))
+FloatSem = &llvm::APFloat::x87DoubleExtended();
+
efriedma wrote:
> ASTContext::getFloatTypeSemantics. (Your e
xbolva00 updated this revision to Diff 169162.
xbolva00 added a comment.
- Addressed comments
https://reviews.llvm.org/D52835
Files:
lib/Sema/SemaChecking.cpp
test/Sema/ext_vector_casts.c
test/Sema/impcast-integer-float.c
Index: test/Sema/impcast-integer-float.c
=
hans added a comment.
In https://reviews.llvm.org/D53052#1261158, @rnk wrote:
> This is rewritten enough that you might want to re-review it, but I'm going
> to push it today so we don't have to wait another day/night cycle for the fix.
Looks good to me. It's hard to follow the logic, but the
Author: chandlerc
Date: Thu Oct 11 01:05:10 2018
New Revision: 344225
URL: http://llvm.org/viewvc/llvm-project?rev=344225&view=rev
Log:
Fix the qualification of `IntrusiveRefCntPtr` to use `llvm::`.
Without this, the code only compiled if the header was included after
something introduced the ali
mgorny added inline comments.
Comment at: lib/Driver/Distro.cpp:139
+ File = VFS.getBufferForFile("/usr/lib/os-release");
+ if (File) {
Technically speaking, the spec says you are supposed to read `/etc/os-release`
first and fall back to `/usr/lib/os-release
kristof.beyls added a subscriber: peter.smith.
kristof.beyls added a comment.
In https://reviews.llvm.org/D53121#1261408, @srhines wrote:
> This LGTM, but we should wait to hear from Kristof before submitting.
Seems fine to me too. I'd maybe just add an additional test case to verify that
thin
arsenm added a comment.
Offload to me sounds like it decided to extract out a section of the program
for offload, which is not how OpenCL works
https://reviews.llvm.org/D52891
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
Author: lebedevri
Date: Thu Oct 11 02:09:50 2018
New Revision: 344230
URL: http://llvm.org/viewvc/llvm-project?rev=344230&view=rev
Log:
[clang][ubsan] Split Implicit Integer Truncation Sanitizer into unsigned and
signed checks
Summary:
As per IRC disscussion, it seems we really want to have more
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344230: [clang][ubsan] Split Implicit Integer Truncation
Sanitizer into unsigned and… (authored by lebedevri, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://re
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
Thanks for the cleanup.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53060
___
cfe-commits mailing list
cfe-commits@lists.llvm
lebedev.ri added a comment.
Ping.
Repository:
rC Clang
https://reviews.llvm.org/D52695
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zinovy.nis added inline comments.
Comment at: test/clang-tidy/misc-non-private-member-variables-in-classes.cpp:1
+// RUN: %check_clang_tidy -check-suffix=NONPRIVATE %s
misc-non-private-member-variables-in-classes %t
+// RUN: %check_clang_tidy -check-suffix=NONPRIVATE %s
misc-no
Rakete added inline comments.
Comment at: test/SemaCXX/warn-unsequenced-cxx17.cpp:1
+// RUN: %clang_cc1 -fsyntax-only -verify -std=c++17 -Wno-unused %s
+
lebedev.ri wrote:
> One last-minute thought: this is only a positive test.
> You don't test what happens
lebedev.ri added inline comments.
Comment at: test/SemaCXX/warn-unsequenced-cxx17.cpp:1
+// RUN: %clang_cc1 -fsyntax-only -verify -std=c++17 -Wno-unused %s
+
Rakete wrote:
> lebedev.ri wrote:
> > One last-minute thought: this is only a positive test.
> > You
hans added inline comments.
Comment at: test/Driver/cl-showfilenames.c:7-8
+// multiple: cl-showfilenames.c
+// multiple-NEXT: wildcard1.c
+// multiple-NEXT: wildcard2.c
rnk wrote:
> I think it'd be nice to have the test show that diagnostics come out
> interlea
Author: hans
Date: Thu Oct 11 03:04:15 2018
New Revision: 344234
URL: http://llvm.org/viewvc/llvm-project?rev=344234&view=rev
Log:
clang-cl: Add /showFilenames option (PR31957)
Add a /showFilenames option for users who want clang to echo the
currently compiled filename. MSVC does this echoing by
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344234: clang-cl: Add /showFilenames option (PR31957)
(authored by hans, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D52773?vs=168999&id=16
xbolva00 added a comment.
@Rakete plesse take a look :)
https://reviews.llvm.org/D52750
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
takuto.ikuta updated this revision to Diff 169179.
takuto.ikuta marked an inline comment as done.
takuto.ikuta added a comment.
address comment
https://reviews.llvm.org/D51340
Files:
clang/include/clang/Basic/Attr.td
clang/include/clang/Basic/LangOptions.h
clang/include/clang/Driver/CC1Op
ioeric created this revision.
ioeric added a reviewer: sammccall.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ilya-biryukov.
This should make all-scope completion more usable. Scope proximity for
indexes will be added in followup patch.
Measurements showed a slig
takuto.ikuta added a comment.
Thank you for review! I updated the code.
Comment at: clang/lib/Sema/SemaDecl.cpp:11976
+
+while (FD && !getDLLAttr(FD) &&
+ !FD->hasAttr() &&
hans wrote:
> Why does this need to be a loop? I don't think FunctionDecl'
joey updated this revision to Diff 169182.
joey added a comment.
Re-uploading the patch. The previous version of the patch was missing the
include and lib prefixes.
https://reviews.llvm.org/D53023
Files:
include/clang/Basic/CMakeLists.txt
include/clang/Basic/OpenCLBuiltins.td
lib/Sema/Se
Rakete added a comment.
The array size is still evaluated twice. Try to incorporate the check in
`Sema::VerifyIntegerConstantExpression`.
https://reviews.llvm.org/D52750
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
xbolva00 added a comment.
Thanks!
But I think I need to change EvaluateForOverflow method to return bool to
indicate overflowing.
https://reviews.llvm.org/D52750
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
sidorovd updated this revision to Diff 169187.
sidorovd added a comment.
Moved the test to test/Headers/opencl-c-header.cl
https://reviews.llvm.org/D51402
Files:
Headers/opencl-c-header.cl
Headers/opencl-c.h
Index: Headers/opencl-c-header.cl
===
sidorovd updated this revision to Diff 169188.
sidorovd added a comment.
- Forgot to add clarification comments on conditional branching. Added.
https://reviews.llvm.org/D51402
Files:
Headers/opencl-c-header.cl
Headers/opencl-c.h
Index: Headers/opencl-c-header.cl
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
LGTM
> Of course the question arises: *should* we set one
Agree with your points. If the cleanup is unsafe, it might end up biting us
harder in the future.
Repository:
rCTE Clang Tools Ex
Rakete added a comment.
Nah, you don't even need to call `EvaluateForOverflow` I believe. :) Have a
look overflow evaluation is done.
https://reviews.llvm.org/D52750
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
Szelethus updated this revision to Diff 169193.
Szelethus added a comment.
- Fixed typos
- Fixed stupid characters (Thank you so much @MTC for going the extra mile and
opening this patch in a browser!)
- Removed outdated entries as mentioned by @MTC
https://reviews.llvm.org/D53024
Files:
www
ioeric added inline comments.
Comment at: clangd/index/FileIndex.h:78
+ /// Remove all index data associated with the file \p Path.
+ void removeFile(PathRef Path);
+
hokein wrote:
> ioeric wrote:
> > should we use this somewhere? E.g. when file is closed in Cl
peter.smith added a comment.
It looks like we might be able to simplify a bit, and I think there probably
could be some more test cases but no objections from me.
Comment at: lib/Driver/ToolChains/Arch/ARM.cpp:360
+ unsigned ArchVersion;
+ if (ArchName.empty())
---
Author: mgorny
Date: Thu Oct 11 04:58:07 2018
New Revision: 344240
URL: http://llvm.org/viewvc/llvm-project?rev=344240&view=rev
Log:
[python] [tests] Support overriding library path via environment
Support a new CLANG_LIBRARY_PATH environment variable for the Python
binding tests. This variable
Author: mgorny
Date: Thu Oct 11 04:58:14 2018
New Revision: 344241
URL: http://llvm.org/viewvc/llvm-project?rev=344241&view=rev
Log:
[tests] Include Python binding tests in CMake rules
Add a new CMake rule check-clang-python to run the Python bindings'
test suite, and include it in check-all.
Di
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344241: [tests] Include Python binding tests in CMake rules
(authored by mgorny, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D52840?vs=1681
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344240: [python] [tests] Support overriding library path via
environment (authored by mgorny, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D
Author: szelethus
Date: Thu Oct 11 04:58:53 2018
New Revision: 344242
URL: http://llvm.org/viewvc/llvm-project?rev=344242&view=rev
Log:
[analyzer][UninitializedObjectChecker] Reports Loc fields pointing to themselves
I've added a new functionality, the checker is now able to
detect and report fie
Szelethus added a comment.
I'm afraid this may have broken many buildbots, I'm having issues building from
scratch. Can you please take a look?
Repository:
rL LLVM
https://reviews.llvm.org/D52840
___
cfe-commits mailing list
cfe-commits@lists.ll
sammccall created this revision.
sammccall added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, arphaman.
Repository:
rC Clang
https://reviews.llvm.org/D53135
Files:
include/clang/Driver/Job.h
include/clang/Frontend/PCHContainerOperations.h
include/clang/Serialization/
ilya-biryukov added a subscriber: sammccall.
ilya-biryukov added a comment.
In https://reviews.llvm.org/D51725#1255695, @simark wrote:
> But I am wondering what to do with the feature that allows clangd to change
> compilation database path using the `didChangeConfiguration` notification.
> In
ilya-biryukov added a comment.
In https://reviews.llvm.org/D52311#1255876, @simark wrote:
> I just tried this, this looks very promising! It should help build our
> outline view in a much more robust way than we do currently.
> A nit for the final patch, I would suggest omitting the fields tha
sammccall added inline comments.
Comment at: clangd/CodeComplete.cpp:558
+if (const auto *NS = dyn_cast(Ctx))
+ return NS->getQualifiedNameAsString() + "::";
+ return llvm::None;
does this do the right thing if it's anonymous or inline, or a parent is?
Author: aaronballman
Date: Thu Oct 11 05:57:29 2018
New Revision: 344244
URL: http://llvm.org/viewvc/llvm-project?rev=344244&view=rev
Log:
Revert r344241 as it broke multiple bots.
http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/10814
http://lab.llvm.org:8011/builders/llvm-clang
On Thu, Oct 11, 2018 at 8:23 AM Umann Kristóf via Phabricator via
llvm-commits wrote:
>
> Szelethus added a comment.
>
> I'm afraid this may have broken many buildbots, I'm having issues building
> from scratch. Can you please take a look?
I've reverted in r344244.
~Aaron
__
Author: sammccall
Date: Thu Oct 11 06:06:10 2018
New Revision: 344245
URL: http://llvm.org/viewvc/llvm-project?rev=344245&view=rev
Log:
[clangd] Remove no-op crash handler, we never set a crash context.
Summary:
I think this was just copied from somewhere with the belief that it actually
did some
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344245: [clangd] Remove no-op crash handler, we never set a
crash context. (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/
sammccall added a comment.
In https://reviews.llvm.org/D51725#1261798, @ilya-biryukov wrote:
> In https://reviews.llvm.org/D51725#1255695, @simark wrote:
>
> > But I am wondering what to do with the feature that allows clangd to change
> > compilation database path using the `didChangeConfigurat
Author: asavonic
Date: Thu Oct 11 06:35:34 2018
New Revision: 344246
URL: http://llvm.org/viewvc/llvm-project?rev=344246&view=rev
Log:
[Sema][OpenCL] Improve diagnostics for not viable overloadable function
candidates
Summary:
Allowed extension name (that ought to be disabled) printing in the no
This revision was automatically updated to reflect the committed changes.
Closed by commit rC344246: [Sema][OpenCL] Improve diagnostics for not viable
overloadable function… (authored by asavonic, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D52292
Files:
include/clang/Basi
Author: sammccall
Date: Thu Oct 11 06:42:53 2018
New Revision: 344247
URL: http://llvm.org/viewvc/llvm-project?rev=344247&view=rev
Log:
[Tooling] Move CompilationDatabasePlugin to the Registry header, where it's
useful. NFC
Modified:
cfe/trunk/include/clang/Tooling/CompilationDatabase.h
hans added inline comments.
Comment at: clang/lib/Sema/SemaDecl.cpp:11976
+
+while (FD && !getDLLAttr(FD) &&
+ !FD->hasAttr() &&
takuto.ikuta wrote:
> hans wrote:
> > Why does this need to be a loop? I don't think FunctionDecl's can be nested?
> Thi
huntergr created this revision.
Initial changes for clang to use the scalable type size queries
(https://reviews.llvm.org/D53137)
This isn't ready for inclusion yet, more discussion on the mailing list
required.
https://reviews.llvm.org/D53138
Files:
lib/CodeGen/CGBuiltin.cpp
lib/CodeGen
hans added a comment.
Looking good, just a few minor comments.
Comment at: docs/ClangCommandLineReference.rst:2241
+
+Enable or disable direct TLS access through segment registers
+
This file is automatically generated based on the options .td files, so no need
peter.smith added a comment.
Thanks for the comments. I agree with you that the -EB and -EL flags need to be
passed to the linker as well, I kind of expected that ld.bfd would infer it
from the endianness of the first object but it doesn't seem to do that. If it's
ok I'll do that in a separate
aaron.ballman added a comment.
Ping
https://reviews.llvm.org/D52384
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: plyster
Date: Thu Oct 11 07:41:10 2018
New Revision: 344249
URL: http://llvm.org/viewvc/llvm-project?rev=344249&view=rev
Log:
Add support for 'dynamic_allocators' clause on 'requires' directive.
Differential Revision: https://reviews.llvm.org/D53079
Modified:
cfe/trunk/include/clang/
JonasToth added a comment.
LG in principle, just the SmallVec thing could be done if you agree. I don't
insist on it, but it looks like a performance benefit to me.
Comment at: clang-tidy/performance/UnnecessaryCopyInitialization.h:41
ASTContext
hokein added inline comments.
Comment at: clangd/index/FileIndex.h:78
+ /// Remove all index data associated with the file \p Path.
+ void removeFile(PathRef Path);
+
ioeric wrote:
> hokein wrote:
> > ioeric wrote:
> > > should we use this somewhere? E.g. when
takuto.ikuta added inline comments.
Comment at: clang/lib/Sema/SemaDecl.cpp:11976
+
+while (FD && !getDLLAttr(FD) &&
+ !FD->hasAttr() &&
hans wrote:
> takuto.ikuta wrote:
> > hans wrote:
> > > Why does this need to be a loop? I don't think FunctionD
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: include/clang/Driver/Job.h:33
// Re-export this as clang::driver::ArgStringList.
-using llvm::opt::ArgStringList;
+using ArgStringList = llvm:
mgorny updated this revision to Diff 169218.
mgorny added a comment.
v2: fixed appending to check-all to make it compatible both with in-tree and
standalone builds
https://reviews.llvm.org/D52840
Files:
CMakeLists.txt
bindings/python/tests/CMakeLists.txt
Index: bindings/python/tests/CMak
mgorny updated this revision to Diff 169219.
mgorny added a comment.
v3: one more correction for stand-alone builds.
https://reviews.llvm.org/D52840
Files:
CMakeLists.txt
bindings/python/tests/CMakeLists.txt
Index: bindings/python/tests/CMakeLists.txt
=
hans added inline comments.
Comment at: clang/lib/Sema/SemaDecl.cpp:11976
+
+while (FD && !getDLLAttr(FD) &&
+ !FD->hasAttr() &&
takuto.ikuta wrote:
> hans wrote:
> > takuto.ikuta wrote:
> > > hans wrote:
> > > > Why does this need to be a loop? I d
mgorny requested review of this revision.
mgorny added a comment.
Please review the new version, addressing the issue caught by buildbots.
https://reviews.llvm.org/D52840
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
peter.smith added a comment.
On reflection after looking at what would be needed for the linker
tools::gnutools::Linker::ConstructJob() I think it may be better to move the
triple detection into a separate function. I'll work on that and will hopefully
post an update soon.
https://reviews.llv
juliehockett updated this revision to Diff 169221.
juliehockett added a comment.
Switching to raw strings.
https://reviews.llvm.org/D53085
Files:
clang-tools-extra/unittests/clang-doc/CMakeLists.txt
clang-tools-extra/unittests/clang-doc/MDGeneratorTest.cpp
Index: clang-tools-extra/unittest
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
I'm not a CMake expert, but when I apply this patch locally, I'm able to run
cmake to completion without errors, so LGTM!
https://reviews.llvm.org/D52840
Author: maskray
Date: Thu Oct 11 09:09:26 2018
New Revision: 344256
URL: http://llvm.org/viewvc/llvm-project?rev=344256&view=rev
Log:
[clang-move] Remove clang:: qualifier
Summary:
The use sites are enclosed by `namespace clang`, so clang:: is not
necessary. Many unqualified names have already be
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344256: [clang-move] Remove clang:: qualifier (authored by
MaskRay, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D53060
Files:
clang-tools-ex
nruslan added inline comments.
Comment at: docs/ClangCommandLineReference.rst:2241
+
+Enable or disable direct TLS access through segment registers
+
hans wrote:
> This file is automatically generated based on the options .td files, so no
> need to update it her
nruslan updated this revision to Diff 169224.
nruslan marked 3 inline comments as done.
nruslan added a comment.
@hans , @craig.topper : Updated the patch with all requested changes
https://reviews.llvm.org/D53102
Files:
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.
Author: brad
Date: Thu Oct 11 09:13:44 2018
New Revision: 344257
URL: http://llvm.org/viewvc/llvm-project?rev=344257&view=rev
Log:
Some improvements to the OpenBSD driver.
- OpenBSD has switched to compiler_rt / libcxx
- Fix sysroot and lib path handling
- Some cleaning up
Added:
cfe/trunk/t
This is a patch to fix bug 26547
(https://bugs.llvm.org/show_bug.cgi?id=26547)
This is my first patch, so please give feedback! This should be correct
though, and I've tested it on both Windows x86 (where it does nothing), and
Linux x86 (where it correctly returns alignof(double) = 4, __alignof(do
Author: mgorny
Date: Thu Oct 11 09:32:54 2018
New Revision: 344258
URL: http://llvm.org/viewvc/llvm-project?rev=344258&view=rev
Log:
[tests] Include Python binding tests in CMake rules
Add a new CMake rule check-clang-python to run the Python bindings'
test suite, and include it in check-all.
Di
This revision was automatically updated to reflect the committed changes.
Closed by commit rC344258: [tests] Include Python binding tests in CMake rules
(authored by mgorny, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D52840
Files:
CMakeLists.txt
bindings/python/tests/CM
Author: aaronballman
Date: Thu Oct 11 09:40:18 2018
New Revision: 344259
URL: http://llvm.org/viewvc/llvm-project?rev=344259&view=rev
Log:
Improve -Wshadow warnings with enumerators.
Addresses PR24718 by checking for enumerators that shadow other enumerators.
Catches issues like:
enum E1{e1};
v
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Committed in r344259 on @erik.pilkington 's LGTM. Self-accepting so I can close
the review.
https://reviews.llvm.org/D52400
___
cf
ioeric updated this revision to Diff 169231.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- address review comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53131
Files:
clangd/CodeComplete.cpp
clangd/Quality.cpp
clangd/Quality.h
unittests/clan
ioeric added inline comments.
Comment at: clangd/CodeComplete.cpp:558
+if (const auto *NS = dyn_cast(Ctx))
+ return NS->getQualifiedNameAsString() + "::";
+ return llvm::None;
sammccall wrote:
> does this do the right thing if it's anonymous or inline,
sammccall created this revision.
Herald added a subscriber: cfe-commits.
Prototype implementation, no tests yet.
See http://lists.llvm.org/pipermail/cfe-dev/2018-October/059752.html
Repository:
rC Clang
https://reviews.llvm.org/D53145
Files:
include/clang/Tooling/CompilationDatabase.h
in
patricklyster closed this revision.
patricklyster added a comment.
Closed by commit https://reviews.llvm.org/rL344249 sha:
851f70b951e5e068b0afa6f69ec58e0e80b0a1a4
Repository:
rC Clang
https://reviews.llvm.org/D53079
___
cfe-commits mailing list
thiagomacieira added inline comments.
Comment at: lib/Driver/Distro.cpp:139
+ File = VFS.getBufferForFile("/usr/lib/os-release");
+ if (File) {
mgorny wrote:
> Technically speaking, the spec says you are supposed to read
> `/etc/os-release` first and fall ba
EricWF added a comment.
There also seem to be some non-ASCII characters in this changeset. Could you
hunt them out and destroy them?
https://reviews.llvm.org/D51762
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
thiagomacieira updated this revision to Diff 169236.
thiagomacieira added a comment.
Updated to check for /etc/os-release first and /usr/lib/os-release if that fails
https://reviews.llvm.org/D53125
Files:
include/clang/Driver/Distro.h
lib/Driver/Distro.cpp
lib/Driver/ToolChains/Linux.cpp
EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.
Have you run `git clang-format` over this change set?
The blocking issues I see are:
- The literal's need to be guarded against older clang dialects. So do their
tests.
- There are
EricWF added a comment.
Also I'm not sure we want to commit to this ABI where the representation of
types like `day`, `month`, and `year` are smaller than the integer types they
can be constructed from.
https://reviews.llvm.org/D51762
___
cfe-comm
Author: mgorny
Date: Thu Oct 11 10:25:05 2018
New Revision: 344260
URL: http://llvm.org/viewvc/llvm-project?rev=344260&view=rev
Log:
[tests] Remove Python tests from check-all due to breakage
Remove the Python tests from default target in order to fix two
kinds of breakage uncovered by enabling t
Hello everyone,
LLVM buildmaster will be updated and restarted after 6PM Pacific time today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ioeric
Date: Thu Oct 11 10:35:29 2018
New Revision: 344262
URL: http://llvm.org/viewvc/llvm-project?rev=344262&view=rev
Log:
[Lex] TokenConcatenation now takes const Preprocessor
Differential Revision: https://reviews.llvm.org/D52502
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/U
ymandel added a comment.
Hi,
It looks like this change has disabled FileCheck for all clang-tidy lit tests
that don't use check-prefixes. So, they all trivially pass even if their
CHECK... lines are wrong. An easy repro is just to randomly modify any CHECK
line in a lit file (e.g.
llvm/tool
Author: mgorny
Date: Thu Oct 11 10:45:35 2018
New Revision: 344263
URL: http://llvm.org/viewvc/llvm-project?rev=344263&view=rev
Log:
[python] [tests] Retab CMakeLists.txt for consistency (NFC)
Modified:
cfe/trunk/bindings/python/tests/CMakeLists.txt
Modified: cfe/trunk/bindings/python/tests/
Author: ioeric
Date: Thu Oct 11 10:49:20 2018
New Revision: 344266
URL: http://llvm.org/viewvc/llvm-project?rev=344266&view=rev
Log:
clang-cl: set output of lit-test to a tmp file after r344234
Some test frameworks do not allow output file in CWD.
Modified:
cfe/trunk/test/Driver/cl-showfilen
Author: ioeric
Date: Thu Oct 11 10:50:04 2018
New Revision: 344267
URL: http://llvm.org/viewvc/llvm-project?rev=344267&view=rev
Log:
Revert "[Lex] TokenConcatenation now takes const Preprocessor"
This reverts commit r344262. This was an unintentional commit.
Modified:
cfe/trunk/lib/StaticAn
mgorny created this revision.
mgorny added a reviewer: rnk.
Fix passing arguments to the pytest command to use 'env' builtin CMake
command, in order to fix compatibility with Windows.
NB: I don't have a Windows environment to test it
Repository:
rC Clang
https://reviews.llvm.org/D53151
File
scott.linder created this revision.
scott.linder added reviewers: yaxunl, arsenm, kzhuravl, Anastasia.
Herald added subscribers: cfe-commits, wdng.
The rationale for this is that OpenCL provides programmatic access to these
symbols, but not to e.g. non-kernel functions. These symbols should have
ABataev added a comment.
Ping!
Repository:
rC Clang
https://reviews.llvm.org/D51554
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erik.pilkington created this revision.
erik.pilkington added reviewers: rjmccall, ahatanak, jfb.
Herald added a subscriber: dexonsmith.
Some ObjC users declare a `extern` variable named `OBJC_CLASS_$_Foo`, then use
it's address as a `Class`. I.e., one could define `isInstanceOfF`:
BOOL isInsta
jfb added a comment.
Overall this seems fine, but I'm no ObjC expert either so I'll defer to
@rjmccall
Comment at: clang/lib/CodeGen/CGObjCMac.cpp:7193
+ if (!GV || GV->getType() != ObjCTypes.ClassnfABITy->getPointerTo()) {
+auto *NewGV = new llvm::GlobalVariable(ObjCType
Author: abataev
Date: Thu Oct 11 11:30:31 2018
New Revision: 344273
URL: http://llvm.org/viewvc/llvm-project?rev=344273&view=rev
Log:
[OPENMP][NVPTX]Reduce memory use for globalized vars in
target/teams/distribute regions.
Previously introduced globalization scheme that uses memory coalescing
sch
Author: sfertile
Date: Thu Oct 11 11:40:35 2018
New Revision: 344276
URL: http://llvm.org/viewvc/llvm-project?rev=344276&view=rev
Log:
Revert "clang-cl: Add /showFilenames option (PR31957)"
This reverts https://reviews.llvm.org/rL344234 which is causing failures on
several bots due to invalid llv
1 - 100 of 158 matches
Mail list logo
