[PATCH] D52423: [analyzer] Make ConversionChecker load StdCLibraryFunctionsChecker

NoQ added a comment. As far as i understand, these driver-controlled thingies are for platform owners to be able to say "hey we clearly don't want this checker to be turned on on our platform". As long as there's no indication of that sort of issue, we should instead keep it all in one place, w

[clang-tools-extra] r343247 - [clangd] Add more tracing to index queries. NFC

Author: ioeric Date: Thu Sep 27 11:23:23 2018 New Revision: 343247 URL: http://llvm.org/viewvc/llvm-project?rev=343247&view=rev Log: [clangd] Add more tracing to index queries. NFC Reviewers: sammccall Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, cfe-commits Differential Re

[PATCH] D52611: [clangd] Add more tracing to index queries. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rL343247: [clangd] Add more tracing to index queries. NFC (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D52611 Files: clang

[PATCH] D51949: [WIP][clang-tidy] initial ideas to isolate variable declarations

JonasToth marked 11 inline comments as done. JonasToth added inline comments. Comment at: clang-tidy/readability/IsolateDeclCheck.cpp:68 +if (Start.isInvalid() || Start.isMacroID()) + return SourceLocation(); + } kbobyrev wrote: > Also, I don't think th

[PATCH] D52364: [clangd] Initial supoprt for cross-namespace global code completion.

ioeric updated this revision to Diff 167356. ioeric marked 2 inline comments as done. ioeric added a comment. - address review comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52364 Files: clangd/CodeComplete.cpp clangd/CodeComplete.h clangd/index/Index.h clangd/

[clang-tools-extra] r343248 - [clangd] Initial supoprt for cross-namespace global code completion.

Author: ioeric Date: Thu Sep 27 11:46:00 2018 New Revision: 343248 URL: http://llvm.org/viewvc/llvm-project?rev=343248&view=rev Log: [clangd] Initial supoprt for cross-namespace global code completion. Summary: When no scope qualifier is specified, allow completing index symbols from any scope an

[PATCH] D52364: [clangd] Initial supoprt for cross-namespace global code completion.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE343248: [clangd] Initial supoprt for cross-namespace global code completion. (authored by ioeric, committed by ). Changed prior to commit: https://reviews.llvm.org/D52364?vs=167356&id=167357#toc Repo

[PATCH] D30806: [nonnull] Teach Clang to attach the nonnull LLVM attribute to declarations and calls instead of just definitions, and then teach it to *not* attach such attributes even if the source c

xbolva00 added a comment. Herald added a subscriber: sanjoy. Coming from https://reviews.llvm.org/D50039. This patch was accepted but never merged? https://reviews.llvm.org/D30806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists

[PATCH] D52581: [AST] Revert mangling changes from r339428

smeenai added a subscriber: rnk. smeenai added a comment. Adding @rnk, since this'll touch MS ABI mangling. For context, we want `struct X` to have the same mangling as `@interface X` normally, but we want to be able to distinguish them for the purpose of exception handling. See this diff's sum

[PATCH] D52574: NFC: Fix some darwin linker warnings introduced in r338385

xbolva00 accepted this revision. xbolva00 added a comment. This revision is now accepted and ready to land. ok, thanks Repository: rC Clang https://reviews.llvm.org/D52574 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

[PATCH] D52617: [clangd] Make stable_partition on include candidates less slow. NFC

ioeric updated this revision to Diff 167361. ioeric marked 3 inline comments as done. ioeric added a comment. - simplify the code. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52617 Files: clangd/CodeComplete.cpp Index: clangd/CodeComplete.cpp

r343251 - [clang][ubsan][NFC] Slight test cleanup in preparation for D50901

Author: lebedevri Date: Thu Sep 27 12:07:48 2018 New Revision: 343251 URL: http://llvm.org/viewvc/llvm-project?rev=343251&view=rev Log: [clang][ubsan][NFC] Slight test cleanup in preparation for D50901 Reviewers: vsk, vitalybuka, filcab Reviewed By: vitalybuka Subscribers: cfe-commits Differen

[PATCH] D52589: [clang][ubsan][NFC] Slight test cleanup in preparation for D50901

This revision was automatically updated to reflect the committed changes. Closed by commit rL343251: [clang][ubsan][NFC] Slight test cleanup in preparation for D50901 (authored by lebedevri, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.o

[PATCH] D52419: [clangd] Cache FS stat() calls when building preamble.

ioeric updated this revision to Diff 167370. ioeric marked 2 inline comments as done. ioeric added a comment. - Address review comments - address review comments - address review comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52419 Files: clangd/CMakeLists.txt clan

[PATCH] D52419: [clangd] Cache FS stat() calls when building preamble.

ioeric added inline comments. Comment at: clangd/FS.cpp:29 +PreambleFileStatusCache::lookup(llvm::StringRef File) const { + auto I = StatCache.find(File); + if (I != StatCache.end()) sammccall wrote: > ioeric wrote: > > sammccall wrote: > > > lock > > After a s

r343253 - [OpenMP] Make default distribute schedule for NVPTX target regions in SPMD mode achieve coalescing

Author: gbercea Date: Thu Sep 27 12:22:56 2018 New Revision: 343253 URL: http://llvm.org/viewvc/llvm-project?rev=343253&view=rev Log: [OpenMP] Make default distribute schedule for NVPTX target regions in SPMD mode achieve coalescing Summary: For the OpenMP NVPTX toolchain choose a default distri

[PATCH] D52434: [OpenMP] Make default distribute schedule for NVPTX target regions in SPMD mode achieve coalescing

This revision was automatically updated to reflect the committed changes. Closed by commit rC343253: [OpenMP] Make default distribute schedule for NVPTX target regions in SPMD mode… (authored by gbercea, committed by ). Changed prior to commit: https://reviews.llvm.org/D52434?vs=167326&id=16737

[PATCH] D47233: [CodeGen] Emit MSVC RTTI for Obj-C EH types

smeenai added inline comments. Comment at: lib/CodeGen/CGObjCMac.cpp:7457-7460 CGObjCNonFragileABIMac::GetEHType(QualType T) { // There's a particular fixed type info for 'id'. if (T->isObjCIdType() || T->isObjCQualifiedIdType()) { +if (CGM.getTriple().isWindowsMSVCEnv

[PATCH] D51949: [WIP][clang-tidy] initial ideas to isolate variable declarations

JonasToth updated this revision to Diff 167377. JonasToth added a comment. - address review comments, most nits solved - fix typedefs and function pointers with comments as distraction - make memberpointer detection more accurate - move functioning member pointer test - clean debug output - clean

[PATCH] D51949: [WIP][clang-tidy] initial ideas to isolate variable declarations

JonasToth added inline comments. Comment at: clang-tidy/readability/IsolateDeclCheck.cpp:343 + auto Diag = + diag(WholeDecl->getBeginLoc(), "this statement declares %0 variables") + << static_cast( aaron.ballman wrote: > JonasToth wrote: > > kbobyrev w

[PATCH] D51949: [WIP][clang-tidy] initial ideas to isolate variable declarations

JonasToth updated this revision to Diff 167381. JonasToth marked 9 inline comments as done. JonasToth added a comment. - simplification on FIXME:/TODO: Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51949 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/I

[PATCH] D52625: [OPENMP] Add 'unified_shared_memory' clause to OMP5 'requires' directive

patricklyster created this revision. patricklyster added reviewers: ABataev, Hahnfeld, RaviNarayanaswamy, mikerice, kkwli0, hfinkel, gtbercea. patricklyster added projects: clang, OpenMP. Herald added a subscriber: guansong. Added new `unified_shared_memory` clause to existing OMP5.0 `requires` d

[PATCH] D51949: [WIP][clang-tidy] initial ideas to isolate variable declarations

JonasToth marked 9 inline comments as done. JonasToth added inline comments. Comment at: clang-tidy/readability/IsolateDeclCheck.cpp:211 + std::vector Snippets; + Snippets.reserve(Ranges.size()); + kbobyrev wrote: > nit: It would be probably easier to have `Sni

[PATCH] D52625: [OPENMP] Add 'unified_shared_memory' clause to OMP5 'requires' directive

ABataev added a comment. I forgot to mention that you need an ast print test (the positive test) Repository: rC Clang https://reviews.llvm.org/D52625 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D52629: [OpenMP] Make default parallel for schedule in NVPTX target regions in SPMD mode achieve coalescing

gtbercea created this revision. gtbercea added reviewers: ABataev, Hahnfeld, caomhin. Herald added subscribers: cfe-commits, guansong, jholewinski. Set default schedule for parallel for loops to schedule(static, 1) when using SPMD mode on the NVPTX device offloading toolchain to ensure coalescing

r343258 - Test commit. NFC

Author: plyster Date: Thu Sep 27 12:30:32 2018 New Revision: 343258 URL: http://llvm.org/viewvc/llvm-project?rev=343258&view=rev Log: Test commit. NFC Modified: cfe/trunk/lib/Sema/TreeTransform.h Modified: cfe/trunk/lib/Sema/TreeTransform.h URL: http://llvm.org/viewvc/llvm-project/cfe/trunk

[PATCH] D52629: [OpenMP] Make default parallel for schedule in NVPTX target regions in SPMD mode achieve coalescing

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:4103 +ScheduleKind = OMPC_SCHEDULE_static; +Chunk = CGF.Builder.getIntN(CGM.getDataLayout().getTypeAllocSizeInBits( +CGF.ConvertType(S.getIterationVariable()->getType())), 1);

[PATCH] D52629: [OpenMP] Make default parallel for schedule in NVPTX target regions in SPMD mode achieve coalescing

gtbercea updated this revision to Diff 167386. gtbercea added a comment. Address comment. Repository: rC Clang https://reviews.llvm.org/D52629 Files: lib/CodeGen/CGOpenMPRuntime.h lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp lib/CodeGen/CGOpenMPRuntimeNVPTX.h lib/CodeGen/CGStmtOpenMP.cpp t

[PATCH] D52629: [OpenMP] Make default parallel for schedule in NVPTX target regions in SPMD mode achieve coalescing

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang https://reviews.llvm.org/D52629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

r343260 - [OpenMP] Make default parallel for schedule in NVPTX target regions in SPMD mode achieve coalescing

Author: gbercea Date: Thu Sep 27 13:29:00 2018 New Revision: 343260 URL: http://llvm.org/viewvc/llvm-project?rev=343260&view=rev Log: [OpenMP] Make default parallel for schedule in NVPTX target regions in SPMD mode achieve coalescing Summary: Set default schedule for parallel for loops to schedu

[PATCH] D52629: [OpenMP] Make default parallel for schedule in NVPTX target regions in SPMD mode achieve coalescing

This revision was automatically updated to reflect the committed changes. Closed by commit rC343260: [OpenMP] Make default parallel for schedule in NVPTX target regions in SPMD… (authored by gbercea, committed by ). Changed prior to commit: https://reviews.llvm.org/D52629?vs=167386&id=167387#to

[PATCH] D51949: [WIP][clang-tidy] initial ideas to isolate variable declarations

JonasToth updated this revision to Diff 167389. JonasToth added a comment. - bail out in transformation if there are PP directives in the source range of the DeclStmt Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51949 Files: clang-tidy/readability/CMakeLists.txt clang-ti

[PATCH] D50901: [clang][ubsan] Split Implicit Integer Truncation Sanitizer into unsigned and signed checks

lebedev.ri updated this revision to Diff 167391. lebedev.ri marked an inline comment as done and 3 inline comments as not done. lebedev.ri added a comment. - Rebased Repository: rC Clang https://reviews.llvm.org/D50901 Files: docs/UndefinedBehaviorSanitizer.rst include/clang/Basic/Saniti

r343263 - NFC: Fix some darwin linker warnings introduced in r338385

Author: epilk Date: Thu Sep 27 13:36:28 2018 New Revision: 343263 URL: http://llvm.org/viewvc/llvm-project?rev=343263&view=rev Log: NFC: Fix some darwin linker warnings introduced in r338385 The darwin linker was complaining about Toolchains/RISCV.cpp and Toolchains/Arch/RISCV.cpp had the same na

[PATCH] D52574: NFC: Fix some darwin linker warnings introduced in r338385

This revision was automatically updated to reflect the committed changes. Closed by commit rC343263: NFC: Fix some darwin linker warnings introduced in r338385 (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D52574?vs=167193&id=167394#toc Repository: rC

[PATCH] D51949: [WIP][clang-tidy] initial ideas to isolate variable declarations

JonasToth updated this revision to Diff 167397. JonasToth added a comment. - fix doc typo Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51949 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/IsolateDeclCheck.cpp clang-tidy/readability/IsolateDeclCheck.

[PATCH] D52586: [X86] Add the movbe instruction intrinsics from icc.

spatel added a comment. The struct hack isn't obvious to me. Without that, we would produce a load with default alignment based on the size of the load (i132 -> align 4, etc)? But we want to force align 1 regardless of the load size, so the __packed__ attribute on the struct gets us that IIUC.

[PATCH] D51949: [WIP][clang-tidy] initial ideas to isolate variable declarations

JonasToth updated this revision to Diff 167400. JonasToth added a comment. - last cleanup for today, testing on clang/lib looks good, but is already very clean Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51949 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/read

[PATCH] D52443: Thread safety analysis: Examine constructor arguments

aaronpuchert added inline comments. Comment at: lib/Analysis/ThreadSafety.cpp:1970 + // There can be default arguments, so we stop when one iterator is at end(). + for (auto Arg = ArgBegin; Param != Params.end() && Arg != ArgEnd; + ++Param, ++Arg) { aaron

[PATCH] D30806: [nonnull] Teach Clang to attach the nonnull LLVM attribute to declarations and calls instead of just definitions, and then teach it to *not* attach such attributes even if the source c

efriedma closed this revision. efriedma added a comment. This was merged in https://reviews.llvm.org/rC298491 . https://reviews.llvm.org/D30806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D52443: Thread safety analysis: Examine constructor arguments

aaron.ballman added inline comments. Comment at: lib/Analysis/ThreadSafety.cpp:1970 + // There can be default arguments, so we stop when one iterator is at end(). + for (auto Arg = ArgBegin; Param != Params.end() && Arg != ArgEnd; + ++Param, ++Arg) { aaro

[PATCH] D52395: Thread safety analysis: Require exclusive lock for passing by non-const reference

delesley added a comment. I have mixed feelings about this patch. When you pass an object to a function, either by pointer or by reference, no actual load from memory has yet occurred. Thus, there is a real risk of false positives; what you are saying is that the function *might* read or writ

[PATCH] D52395: Thread safety analysis: Require exclusive lock for passing by non-const reference

delesley added a comment. With respect to data, I really think these patches should be tested against Google's code base, because otherwise you're going to start seeing angry rollbacks. However, I don't work on the C++ team any more, and I don't have time to do it. When I was actively develop

[PATCH] D52395: Thread safety analysis: Require exclusive lock for passing by non-const reference

aaron.ballman added a comment. In https://reviews.llvm.org/D52395#1248608, @delesley wrote: > With respect to data, I really think these patches should be tested against > Google's code base, because otherwise you're going to start seeing angry > rollbacks. However, I don't work on the C++ tea

[PATCH] D52443: Thread safety analysis: Examine constructor arguments

delesley added a comment. This looks good, and resolves an outstanding bug that was on my list. Thanks for the patch! Comment at: lib/Analysis/ThreadSafety.cpp:1537 void handleCall(const Expr *Exp, const NamedDecl *D, VarDecl *VD = nullptr); + void ExamineCallArguments(c

[PATCH] D52443: Thread safety analysis: Examine constructor arguments

delesley added inline comments. Comment at: lib/Analysis/ThreadSafety.cpp:2046 const CXXConstructorDecl *D = Exp->getConstructor(); if (D && D->isCopyConstructor()) { const Expr* Source = Exp->getArg(0); As a side note, we should probably special-case

r343276 - [analyzer] Hotfix for the bug in exploded graph printing

Author: george.karpenkov Date: Thu Sep 27 15:31:13 2018 New Revision: 343276 URL: http://llvm.org/viewvc/llvm-project?rev=343276&view=rev Log: [analyzer] Hotfix for the bug in exploded graph printing Modified: cfe/trunk/lib/StaticAnalyzer/Core/ExprEngine.cpp Modified: cfe/trunk/lib/StaticAna

[PATCH] D51714: CMake: Deprecate using llvm-config to detect llvm installation

smeenai added a comment. Is there anything holding this up? Repository: rC Clang https://reviews.llvm.org/D51714 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r343279 - [cxx2a] P0624R2: Lambdas with no capture-default are

Author: rsmith Date: Thu Sep 27 15:47:04 2018 New Revision: 343279 URL: http://llvm.org/viewvc/llvm-project?rev=343279&view=rev Log: [cxx2a] P0624R2: Lambdas with no capture-default are default-constructible and assignable. Added: cfe/trunk/test/SemaCXX/cxx2a-lambda-default-ctor-assign.cpp Mo

[PATCH] D52578: Thread safety analysis: Allow scoped releasing of capabilities

delesley added inline comments. Comment at: lib/Analysis/ThreadSafety.cpp:893 private: - SmallVector UnderlyingMutexes; + enum UnderlyingCapabilityKind { +UCK_Acquired, ///< Any kind of acquired capability. IMHO, it would make more sense to break

Re: r342925 - P0962R1: only use the member form of 'begin' and 'end' in a range-based

Looks like you fixed this in r343150, thanks! On Tue, 25 Sep 2018 at 10:49, Vitaly Buka via cfe-commits < cfe-commits@lists.llvm.org> wrote: > http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/24083 > > FAIL: Clang :: CXX/stmt.stmt/stmt.iter/stmt.ranged/p1.cpp (1692 of 13357) >

[PATCH] D30806: [nonnull] Teach Clang to attach the nonnull LLVM attribute to declarations and calls instead of just definitions, and then teach it to *not* attach such attributes even if the source c

spatel added a comment. In https://reviews.llvm.org/D30806#1248575, @efriedma wrote: > This was merged in https://reviews.llvm.org/rC298491 . But it got reverted soon after due to miscompiles: https://reviews.llvm.org/rL298695 And the functionality hasn't been reimplemented AFAICT. https://r

[PATCH] D51714: CMake: Deprecate using llvm-config to detect llvm installation

tstellar updated this revision to Diff 167413. tstellar added a comment. Use cmake's DEPRECATION message. Repository: rC Clang https://reviews.llvm.org/D51714 Files: CMakeLists.txt Index: CMakeLists.txt === --- CMakeLists.tx

[PATCH] D52586: [X86] Add the movbe instruction intrinsics from icc.

craig.topper updated this revision to Diff 167416. craig.topper added a comment. Add comment. Fix typo. Add preprocessor define checks to the various CPUs that have MOVBE https://reviews.llvm.org/D52586 Files: lib/Basic/Targets/X86.cpp lib/Headers/immintrin.h test/CodeGen/movbe-builtins.

[PATCH] D50850: clang: Add triples support for MIPS r6

wzssyqa updated this revision to Diff 167419. Herald added a subscriber: dexonsmith. https://reviews.llvm.org/D50850 Files: include/llvm/ADT/Triple.h lib/Support/Triple.cpp lib/Target/Mips/MCTargetDesc/MipsMCTargetDesc.cpp unittests/ADT/TripleTest.cpp Index: unittests/ADT/TripleTest.cpp

r343285 - [cxx2a] P0641R2: (Some) type mismatches on defaulted functions only

Author: rsmith Date: Thu Sep 27 18:16:43 2018 New Revision: 343285 URL: http://llvm.org/viewvc/llvm-project?rev=343285&view=rev Log: [cxx2a] P0641R2: (Some) type mismatches on defaulted functions only render the function deleted instead of rendering the program ill-formed. This change also adds a

[PATCH] D52395: Thread safety analysis: Require exclusive lock for passing by non-const reference

aaronpuchert added a comment. I've thought about your concerns and the important thing is: I didn't actually test this on a larger code base. The change makes sense to me, but maybe I'm missing something. So maybe instead of pushing through further restrictions, I should focus on rolling out th

[PATCH] D52384: [Sema] Fix redeclaration contexts for enumerators in C

aaron.ballman added a reviewer: echristo. aaron.ballman added a comment. Ping? https://reviews.llvm.org/D52384 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52400: Improve -Wshadow warnings with enumerators

aaron.ballman added a reviewer: echristo. aaron.ballman added a comment. Ping? https://reviews.llvm.org/D52400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52578: Thread safety analysis: Allow scoped releasing of capabilities

aaronpuchert added a comment. Maybe you should have a look at the tests first. I thought about the semantics that I think you are suggesting, but then we could have code like: class SCOPED_LOCKABLE MutexLockUnlock { public: MutexLockUnlock(Mutex *mu1, Mutex *mu2) EXCLUSIVE_UNLOCK_FUNCTIO

r343293 - Handle dependent class template names in class template argument

Author: rsmith Date: Thu Sep 27 20:18:53 2018 New Revision: 343293 URL: http://llvm.org/viewvc/llvm-project?rev=343293&view=rev Log: Handle dependent class template names in class template argument deduction for new-expressions. Modified: cfe/trunk/lib/Sema/SemaInit.cpp cfe/trunk/test/Sem

[PATCH] D52384: [Sema] Fix redeclaration contexts for enumerators in C

majnemer added inline comments. Comment at: lib/AST/DeclBase.cpp:1711-1712 + // contexts are always skipped. + while (SkipRecords ? Ctx->isTransparentContext() || Ctx->isRecord() + : Ctx->isTransparentContext()) Ctx = Ctx->getParent();

<    1   2