[PATCH] D52437: [CUDA] Add preliminary support for CUDA 10.0

tra added a comment. Great to see someone beating me to add support for a new CUDA version. :-) I've posted my patch in https://reviews.llvm.org/D52438. It's very similar to yours with a couple of other necessary changes. Repository: rC Clang https://reviews.llvm.org/D52437 _

[PATCH] D52437: [CUDA] Add preliminary support for CUDA 10.0

fwyzard added a comment. Thanks, indeed I missed some of the changes related to SM 7.5. Repository: rC Clang https://reviews.llvm.org/D52437 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D52440: Emit lifetime markers for temporary function parameter aggregates

itessier created this revision. itessier added a reviewer: rjmccall. Herald added a subscriber: cfe-commits. Clang is not emitting lifetime markers for temporary function parameters, so more stack space is potentially being allocated than necessary. A new parameter is added to the CreateAggTemp

[PATCH] D52395: Thread safety analysis: Require exclusive lock for passing by non-const reference

aaron.ballman added a comment. > Unlike checking const qualifiers on member functions, there are probably not > many false positives here: if a function takes a non-const reference, it will > in almost all cases modify the object that we passed it. I'm not certain I agree with the predicate her

[PATCH] D52443: Thread safety analysis: Examine constructor arguments

aaronpuchert created this revision. aaronpuchert added reviewers: aaron.ballman, delesley. Herald added a subscriber: cfe-commits. Instead of only examining call arguments, we also examine constructor arguments applying the same rules. That was an oppurtunity for refactoring the examination proce

[PATCH] D52398: Thread safety analysis: Unwrap __builtin_expect in getTrylockCallExpr

aaronpuchert added a comment. No problem. Thanks for reviewing! I'm terribly sorry to be bombarding the two of you with so many review requests lately, and I hope it'll soon be over. Repository: rC Clang https://reviews.llvm.org/D52398 ___ cfe-c

[PATCH] D52443: Thread safety analysis: Examine constructor arguments

aaronpuchert added a comment. There is a (technical) merge conflict between this change and https://reviews.llvm.org/D52395, but that shouldn't be of any concern for the review. The issues are rather independent. (I think.) Repository: rC Clang https://reviews.llvm.org/D52443 ___

r342924 - [CUDA] Added basic support for compiling with CUDA-10.0

Author: tra Date: Mon Sep 24 16:10:44 2018 New Revision: 342924 URL: http://llvm.org/viewvc/llvm-project?rev=342924&view=rev Log: [CUDA] Added basic support for compiling with CUDA-10.0 Modified: cfe/trunk/include/clang/Basic/Cuda.h cfe/trunk/lib/Basic/Cuda.cpp cfe/trunk/lib/Basic/Tar

[PATCH] D52398: Thread safety analysis: Unwrap __builtin_expect in getTrylockCallExpr

aaron.ballman added a comment. In https://reviews.llvm.org/D52398#1244074, @aaronpuchert wrote: > No problem. Thanks for reviewing! I'm terribly sorry to be bombarding the two > of you with so many review requests lately, and I hope it'll soon be over. No apologies necessary -- I love and appr

r342925 - P0962R1: only use the member form of 'begin' and 'end' in a range-based

Author: rsmith Date: Mon Sep 24 16:17:44 2018 New Revision: 342925 URL: http://llvm.org/viewvc/llvm-project?rev=342925&view=rev Log: P0962R1: only use the member form of 'begin' and 'end' in a range-based for loop if both members exist. This resolves a DR whereby an errant 'begin' or 'end' member

r342926 - [www] Update cxx_status to mark P0962R1 as done.

Author: rsmith Date: Mon Sep 24 16:19:11 2018 New Revision: 342926 URL: http://llvm.org/viewvc/llvm-project?rev=342926&view=rev Log: [www] Update cxx_status to mark P0962R1 as done. Modified: cfe/trunk/www/cxx_status.html Modified: cfe/trunk/www/cxx_status.html URL: http://llvm.org/viewvc/l

r342927 - [www] Change 'Clang 7' items from yellow to green now Clang 7 is

Author: rsmith Date: Mon Sep 24 16:21:09 2018 New Revision: 342927 URL: http://llvm.org/viewvc/llvm-project?rev=342927&view=rev Log: [www] Change 'Clang 7' items from yellow to green now Clang 7 is released. Modified: cfe/trunk/www/cxx_dr_status.html cfe/trunk/www/cxx_status.html cfe/

[PATCH] D52445: [Index] Use locations to uniquify function-scope BindingDecl USR

MaskRay created this revision. MaskRay added reviewers: akyrtzi, arphaman. Herald added a subscriber: cfe-commits. This makes BindingDecl's of the same name have different USRs, so that references can be correctly attributed. int a[1] = {}; { auto [x] = a; x; } { auto [x] = a; x; } Repos

[PATCH] D52401: Remove redundant null pointer check in operator delete

MaskRay added a comment. Ping :) Repository: rCXX libc++ https://reviews.llvm.org/D52401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r342929 - Driver: render arguments for the embedded bitcode correctly

Author: compnerd Date: Mon Sep 24 16:50:02 2018 New Revision: 342929 URL: http://llvm.org/viewvc/llvm-project?rev=342929&view=rev Log: Driver: render arguments for the embedded bitcode correctly When embedding bitcode, only a subset of the arguments should be recorded into the bitcode compilation

[PATCH] D52446: Remove Found.clear() to silent bugprone-use-after-move after rC342925

MaskRay created this revision. MaskRay added a reviewer: rsmith. Herald added a subscriber: cfe-commits. MaskRay added a reviewer: clang. Repository: rC Clang https://reviews.llvm.org/D52446 Files: lib/Sema/SemaStmt.cpp Index: lib/Sema/SemaStmt.cpp =

[PATCH] D52395: Thread safety analysis: Require exclusive lock for passing by non-const reference

aaronpuchert added a comment. While most people probably just use ordinary mutexes, hence won't be affected, those that use read/write locks need to know when to use a shared and when to use an exclusive lock. What makes things hard in C++ is that through passing by non-const reference, an obje

[PATCH] D50147: clang-format: support external styles

krasimir added a comment. I don't understand the use-case this patch is realizing. Suppose I have a bunch of projects that have to share a format style. Then I can checkout them under a common root directory and put an appropriate .clang-format file there. Repository: rC Clang https://revie

[PATCH] D52448: [clang-format] Break before next parameter after a formatted multiline raw string parameter

krasimir created this revision. Herald added a subscriber: cfe-commits. TODO: in progress Repository: rC Clang https://reviews.llvm.org/D52448 Files: lib/Format/ContinuationIndenter.cpp lib/Format/ContinuationIndenter.h unittests/Format/FormatTestRawStrings.cpp Index: unittests/Format

[PATCH] D52401: Remove redundant null pointer check in operator delete

khng300 accepted this revision. khng300 added a comment. This revision is now accepted and ready to land. LGTM Repository: rCXX libc++ https://reviews.llvm.org/D52401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

[PATCH] D52401: Remove redundant null pointer check in operator delete

hotpxl accepted this revision. hotpxl added a comment. LGTM Repository: rCXX libc++ https://reviews.llvm.org/D52401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51340: Add /Zc:DllexportInlines option to clang-cl

takuto.ikuta added a comment. In https://reviews.llvm.org/D51340#1243453, @hans wrote: > In https://reviews.llvm.org/D51340#1243331, @takuto.ikuta wrote: > > > Ping? > > > > This patch reduced obj size largely, and I expect this makes distributed > > build (like goma) faster by reducing data tra

[PATCH] D52401: Remove redundant null pointer check in operator delete

This revision was automatically updated to reflect the committed changes. Closed by commit rL342936: Remove redundant null pointer check in operator delete (authored by MaskRay, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D52401 Files:

[PATCH] D45050: [clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length

Charusso updated this revision to Diff 166802. Charusso marked 28 inline comments as done. Charusso added a comment. - Refactor and better English thanks for @whisperity! - Removed `InjectUL` option so the checker handles the special case if the capacity of a buffer is `int.Max()` https://revi

[PATCH] D52446: Remove Found.clear() to silent bugprone-use-after-move after rC342925

rsmith added a comment. I think the check is wrong here. We need this `clear` call to reinitialize the object after moving from it. Maybe that function should be annotated as reinitializing the object instead? Repository: rC Clang https://reviews.llvm.org/D52446 _

[PATCH] D52401: Remove redundant null pointer check in operator delete

ldionne added a comment. You did not get a thumbs up from any of the code owners for libc++. Reverted in r342938. Repository: rL LLVM https://reviews.llvm.org/D52401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

[PATCH] D45050: [clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length

Charusso added a comment. The results are accessible trough the `index.html` in each folder: F7303310: results.rar @aaron.ballman a friendly reminder. https://reviews.llvm.org/D45050 ___ cfe-commits mailing list

Re: [clang-tools-extra] r342730 - [clangd] Remember to serialize symbol origin in YAML.

Why would we want to serialize the origin? We only serialize and deserialize for the static index, it does not seem to be useful to serialize origin in that scenario. Am I missing something? On Fri, Sep 21, 2018 at 3:06 PM Eric Liu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: i

[PATCH] D52419: [clangd] Cache FS stat() calls when building preamble.

ilya-biryukov added inline comments. Comment at: clangd/ClangdUnit.cpp:119 +/// Collect and cache all file status from the underlying file system. +class CollectStatCacheVFS : public vfs::FileSystem { ioeric wrote: > Would it make sense to add a `clang::vfs::Pr

[PATCH] D52446: Annotate LookupResult::clear() as LLVM_ATTRIBUTE_REINITIALIZES to silence bugprone-use-after-move after rC342925

MaskRay updated this revision to Diff 166806. MaskRay retitled this revision from "Remove Found.clear() to silent bugprone-use-after-move after rC342925" to "Annotate LookupResult::clear() as LLVM_ATTRIBUTE_REINITIALIZES to silence bugprone-use-after-move after rC342925". MaskRay removed a review

[PATCH] D52446: Annotate LookupResult::clear() as LLVM_ATTRIBUTE_REINITIALIZES to silence bugprone-use-after-move after rC342925

MaskRay updated this revision to Diff 166805. MaskRay added a comment. Depends on https://reviews.llvm.org/D52451 (adding LLVM_ATTRIBUTE_REINITIALIZES) Repository: rC Clang https://reviews.llvm.org/D52446 Files: include/clang/Sema/Lookup.h Index: include/clang/Sema/Lookup.h =

[PATCH] D52252: Driver: render arguments for the embedded bitcode correctly

compnerd closed this revision. compnerd added a comment. SVN r342929 (with tests) Repository: rC Clang https://reviews.llvm.org/D52252 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D52259: [CUDA] Fix two failed test cases using --cuda-path-ignore-env

gaijiading updated this revision to Diff 166811. gaijiading retitled this revision from "[CUDA] Rearrange search path ordering to fix two test case failures" to "[CUDA] Fix two failed test cases using --cuda-path-ignore-env". gaijiading edited the summary of this revision. gaijiading added a comm

<    1   2