Author: dblaikie
Date: Tue Sep 18 13:11:45 2018
New Revision: 342510
URL: http://llvm.org/viewvc/llvm-project?rev=342510&view=rev
Log:
Fix fomit-frame-pointe+pg error
Modified:
cfe/trunk/lib/Driver/ToolChains/Clang.cpp
Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp
URL:
http://llvm.org
Fixed in r342510 with the solution I mentioned up-thread.
On Tue, Sep 18, 2018 at 1:10 PM Volodymyr Sapsai via Phabricator <
revi...@reviews.llvm.org> wrote:
> vsapsai added a comment.
>
> Confirm that reverting the change locally fixes the tests. If nobody beats
> me to it, I plan to revert the
dblaikie added a subscriber: srhines.
dblaikie added a comment.
Fixed in r342510 with the solution I mentioned up-thread.
Repository:
rL LLVM
https://reviews.llvm.org/D52191
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
Sure, I'm looking now.
Thanks,
Steve
On Tue, Sep 18, 2018 at 1:02 PM wrote:
> Hi Stephen,
>
> Your change is causing a test failure on the PS4 linux bot, can you please
> take a look?
>
>
> http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/36712/steps/test/logs
srhines added a comment.
Thanks @dblaikie for the quick fixup. I must have accidentally dropped the '!',
because I did run check-all to test the change.
Repository:
rL LLVM
https://reviews.llvm.org/D52191
___
cfe-commits mailing list
cfe-commits
r342510 by dblaikie fixed this.
Thanks,
Steve
On Tue, Sep 18, 2018 at 1:18 PM Stephen Hines wrote:
> Sure, I'm looking now.
>
> Thanks,
> Steve
>
> On Tue, Sep 18, 2018 at 1:02 PM wrote:
>
>> Hi Stephen,
>>
>> Your change is causing a test failure on the PS4 linux bot, can you
>> please take a
vitalybuka added inline comments.
Comment at: lib/CodeGen/CGExprScalar.cpp:305
enum ImplicitConversionCheckKind : unsigned char {
-ICCK_IntegerTruncation = 0,
+ICCK_IntegerTruncation = 0, // Legacy, no longer used.
+ICCK_UnsignedIntegerTruncation = 1,
-
lebedev.ri added a comment.
@vsk thanks for taking a look!
Comment at: lib/CodeGen/CGExprScalar.cpp:305
enum ImplicitConversionCheckKind : unsigned char {
-ICCK_IntegerTruncation = 0,
+ICCK_IntegerTruncation = 0, // Legacy, no longer used.
+ICCK_UnsignedIntegerTr
lebedev.ri added a comment.
In https://reviews.llvm.org/D50901#1238795, @lebedev.ri wrote:
> @vsk thanks for taking a look!
/me can't read :)
That was supposed to be @vitalybuka, of course (:
Repository:
rC Clang
https://reviews.llvm.org/D50901
__
Seems that it was fixed earlier today.
Thanks,
Yvan
On Tue, 18 Sep 2018 at 19:31, Yvan Roux wrote:
>
> Hi Sam,
>
> It took a very long time to identify it, but this commit broke ARMv7
> bots, where this test hangs. Logs are available here (initial ones
> are too old):
>
> http://lab.llvm.org:80
nickdesaulniers created this revision.
nickdesaulniers added reviewers: srhines, gbiv.
Herald added a reviewer: george.burgess.iv.
Herald added a subscriber: cfe-commits.
nickdesaulniers removed a reviewer: gbiv.
Fixes PR32985.
Repository:
rC Clang
https://reviews.llvm.org/D52248
Files:
li
nickdesaulniers updated this revision to Diff 166035.
nickdesaulniers added a comment.
git-clang-format HEAD~
Repository:
rC Clang
https://reviews.llvm.org/D52248
Files:
lib/Sema/SemaType.cpp
test/Sema/gnu89.c
Index: test/Sema/gnu89.c
===
Author: compnerd
Date: Tue Sep 18 14:12:39 2018
New Revision: 342512
URL: http://llvm.org/viewvc/llvm-project?rev=342512&view=rev
Log:
Driver: hoist `-mlimit-float-precision` (NFC)
Move the floating point argument handling into the RenderFloatingPointOptions
helper. This relocation just puts the
vsapsai added a comment.
Thanks for the fix.
Repository:
rL LLVM
https://reviews.llvm.org/D52191
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sammccall created this revision.
sammccall added a reviewer: ioeric.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ilya-biryukov.
This allows inheriting from it, so index() can ga away and allowing
TestTU::index) to be fixed.
Repository:
rCTE Clang Tools Extra
JonasToth updated this revision to Diff 166041.
JonasToth added a comment.
- Merge branch 'master' into experiment_isolate_decl
- further work on isolate decl, fix tokenizing bug with templates
- include big test-suite and make them run
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.
Author: tra
Date: Tue Sep 18 14:51:02 2018
New Revision: 342514
URL: http://llvm.org/viewvc/llvm-project?rev=342514&view=rev
Log:
[clang-tidy] Replace redundant checks with an assert().
findStyleKind is only called if D is an explicit identifier with a name,
so the checks for operators will never
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE342514: [clang-tidy] Replace redundant checks with an
assert(). (authored by tra, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52179?vs=165841&id=166042#toc
Repository:
rCTE C
Author: compnerd
Date: Tue Sep 18 15:14:50 2018
New Revision: 342515
URL: http://llvm.org/viewvc/llvm-project?rev=342515&view=rev
Log:
Driver: extract a local variable for the Toolchain (NFC)
Create and store a reference to the current toolchain rather than calling
`getToolChain` throughout the f
JonasToth updated this revision to Diff 166044.
JonasToth added a comment.
- minor adjustments, add fixmes
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51949
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/IsolateDeclCheck.cpp
clang-tidy/readability/
compnerd added inline comments.
Herald added a subscriber: libcxx-commits.
Comment at: include/filesystem:1396
- _LIBCPP_FUNC_VIS
void __create_what(int __num_paths);
This possibly changes the meaning on other targets. What was the error that
this trigger
aganea added a comment.
The goal of this change is frictionless compilation into VS2017 when using
`clang-cl` as a compiler. We've realized that compiling Clang+LLD with Clang
generates a faster executable that with MSVC (even latest one).
I currently can't see a good way of generating the Visua
elsteveogrande added inline comments.
Comment at: lib/Serialization/ASTReaderDecl.cpp:1771
auto *Def = DD.Definition;
DD = std::move(MergeDD);
DD.Definition = Def;
Hi @rsmith, thanks again for looking! This is the part that I was concerned
about:
compnerd created this revision.
compnerd added a reviewer: steven_wu.
When embedding bitcode, only a subset of the arguments should be recorded into
the bitcode compilation command line. The frontend job is split into two jobs,
one which will generate the bitcode. Ensure that the arguments for t
zturner added a comment.
In https://reviews.llvm.org/D52193#1238923, @aganea wrote:
> The goal of this change is frictionless compilation into VS2017 when using
> `clang-cl` as a compiler. We've realized that compiling Clang+LLD with Clang
> generates a faster executable that with MSVC (even la
zturner added a reviewer: thakis.
zturner added a comment.
That said, the numbers are pretty convincing
These two rows alone:
MSBuild, Clang + LLD(29min 12sec) 32 parallel msbuild
MSBuild, Clang /MP + LLD(9min 22sec)32 parallel msbuild
Are enough to make this patch worthy of se
Author: rnk
Date: Tue Sep 18 16:16:30 2018
New Revision: 342516
URL: http://llvm.org/viewvc/llvm-project?rev=342516&view=rev
Log:
[MS] Defer dllexport inline friend functions like other inline methods
This special case was added in r264841, but the code breaks our
invariants by calling EmitTopLev
Author: vsapsai
Date: Tue Sep 18 16:27:02 2018
New Revision: 342517
URL: http://llvm.org/viewvc/llvm-project?rev=342517&view=rev
Log:
Add a callback for `__has_include` and use it for dependency scanning.
This adds a preprocessor callback for the `__has_include` and
`__has_include_next` directive
This revision was automatically updated to reflect the committed changes.
Closed by commit rL342517: Add a callback for `__has_include` and use it for
dependency scanning. (authored by vsapsai, committed by ).
Herald added subscribers: llvm-commits, jsji.
Changed prior to commit:
https://review
aganea added a comment.
In https://reviews.llvm.org/D52193#1238944, @zturner wrote:
> In https://reviews.llvm.org/D52193#1238923, @aganea wrote:
>
> > The goal of this change is frictionless compilation into VS2017 when using
> > `clang-cl` as a compiler. We've realized that compiling Clang+LLD
zturner added a comment.
In https://reviews.llvm.org/D52193#1238978, @aganea wrote:
> In https://reviews.llvm.org/D52193#1238944, @zturner wrote:
>
> > In https://reviews.llvm.org/D52193#1238923, @aganea wrote:
> >
> > > The goal of this change is frictionless compilation into VS2017 when
> > >
aaronpuchert added a comment.
I found something that would theoretically work:
P->setArrow((isa(ME->getBase()) && Ctx && Ctx->SelfArg) ?
Ctx->SelfArrow : ME->isArrow());
So if we have `this` and a context that tells us we have to replace `this` by
something else, then we check `Ctx->SelfArro
tra updated this revision to Diff 166050.
tra marked an inline comment as done.
tra added a comment.
Updated assertion message.
https://reviews.llvm.org/D51808
Files:
clang/include/clang/AST/DeclCXX.h
clang/include/clang/Sema/Sema.h
clang/lib/AST/DeclCXX.cpp
clang/lib/Sema/SemaDeclCXX.c
aaronpuchert updated this revision to Diff 166051.
aaronpuchert added a comment.
Detect ObjC pointer types as well as ordinary pointers.
Repository:
rC Clang
https://reviews.llvm.org/D52200
Files:
include/clang/Analysis/Analyses/ThreadSafetyCommon.h
lib/Analysis/ThreadSafetyCommon.cpp
aaronpuchert marked 2 inline comments as done.
aaronpuchert added a comment.
I think it should be possible to get rid of `self->` in the warning message if
we want to, after all `this->` is omitted in C++ as well.
Comment at: test/SemaObjCXX/warn-thread-safety-analysis.mm:42
+
rnk added a comment.
This is pretty cool. The process launching APIs in LLVM were pretty basic, left
a lot to be desired, returned ints, etc etc. This addresses a lot of that.
Comment at: clang/trunk/lib/Driver/Driver.cpp:3030
+if (Arg *A = Args.getLastArg(options::OPT__SL
tra updated this revision to Diff 166053.
tra added a comment.
Renamed last instance of 'Matches' -> 'PreventedBy'.
https://reviews.llvm.org/D51808
Files:
clang/include/clang/AST/DeclCXX.h
clang/include/clang/Sema/Sema.h
clang/lib/AST/DeclCXX.cpp
clang/lib/Sema/SemaDeclCXX.cpp
clang/l
Author: aaronpuchert
Date: Tue Sep 18 17:19:38 2018
New Revision: 342519
URL: http://llvm.org/viewvc/llvm-project?rev=342519&view=rev
Log:
Thread safety analysis: Fix crash for function pointers
For function pointers, the FunctionDecl of the callee is unknown, so
getDirectCallee will return nullp
erik.pilkington created this revision.
erik.pilkington added a reviewer: bruno.
Herald added a subscriber: dexonsmith.
rdar://43692300
Repository:
rC Clang
https://reviews.llvm.org/D52253
Files:
clang/lib/Lex/HeaderSearch.cpp
clang/test/Frontend/Inputs/Radar43692300/Headers/Headers/File.
erik.pilkington added inline comments.
Comment at: clang/lib/Lex/HeaderSearch.cpp:670
if (IsIncludeeInFramework) {
NewInclude += StringRef(ToFramework).drop_back(10); // drop .framework
NewInclude += "/";
Crash was here, if ToFramework is empty
dpayne updated this revision to Diff 166057.
dpayne added a comment.
Adding the missing Style member variable.
Repository:
rC Clang
https://reviews.llvm.org/D51120
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
lib/Format/Format.cpp
lib/Format/UnwrappedLinePars
bruno added a comment.
Hi Erik,
Thanks for catching this.
Can you rename the test and the input file path to something more meaningful?
Better yet if you remove the radar bits. I think you can actually squeeze this
test in test/Modules/double-quotes.m.
Repository:
rC Clang
https://reviews
rjmccall added a comment.
In https://reviews.llvm.org/D52200#1239007, @aaronpuchert wrote:
> I think it should be possible to get rid of `self->` in the warning message
> if we want to, after all `this->` is omitted in C++ as well.
Hmm. It would be consistent to apply the same rule to both ca
mclow.lists added inline comments.
Comment at: test/support/verbose_assert.h:24
: (IsStreamable::value ? 2 : -1))>
-struct SelectStream {
+struct SelectErrStream {
static_assert(ST == -1, "specialization required for ST != -1");
Why the renaming here?
wuzish added a comment.
Herald added a subscriber: jsji.
Please help me to commit this patch. Thanks a lot.
Repository:
rC Clang
https://reviews.llvm.org/D52074
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
Author: shuaiwang
Date: Tue Sep 18 20:50:03 2018
New Revision: 342525
URL: http://llvm.org/viewvc/llvm-project?rev=342525&view=rev
Log:
[NFC] Fix uncompilable test cases of ExprMutationAnalyzer.
And ensure future test cases doesn't have compile errors.
Modified:
cfe/trunk/unittests/Analysis/
STL_MSFT added inline comments.
Comment at: test/support/test_macros.h:147
-# elif defined(_WIN32)
-#if defined(_MSC_VER) && !defined(__MINGW32__)
-# define TEST_HAS_C11_FEATURES // Using Microsoft's C Runtime library
compnerd wrote:
> I think that the
shuaiwang updated this revision to Diff 166065.
shuaiwang added a comment.
Rebase
Repository:
rC Clang
https://reviews.llvm.org/D52219
Files:
include/clang/Analysis/Analyses/ExprMutationAnalyzer.h
lib/Analysis/ExprMutationAnalyzer.cpp
unittests/Analysis/ExprMutationAnalyzerTest.cpp
In
shuaiwang added a comment.
In https://reviews.llvm.org/D52219#1238423, @JonasToth wrote:
> Do you think it would be possible to the analysis for `>const?< int
> ***`-cases? (recursively checking through the pointer levels)
I think that should be possible, will do after single-layer pointee ana
shuaiwang updated this revision to Diff 166068.
shuaiwang marked 7 inline comments as done.
shuaiwang added a comment.
[WIP] Addressed some of review comments.
Repository:
rC Clang
https://reviews.llvm.org/D52219
Files:
include/clang/Analysis/Analyses/ExprMutationAnalyzer.h
lib/Analysis/
gaijiading created this revision.
gaijiading added reviewers: jlebar, Hahnfeld, dlj, tra.
gaijiading added a project: clang.
Herald added a subscriber: cfe-commits.
Before this patch, when a system has the CUDA toolkit already installed to its
default locations in /usr/local/cuda, there will be t
erik.pilkington updated this revision to Diff 166070.
erik.pilkington added a comment.
Sure, the new patch moves the test to double-quotes.m and gives it a more
meaningful name.
Thanks!
https://reviews.llvm.org/D52253
Files:
clang/lib/Lex/HeaderSearch.cpp
clang/test/Modules/Inputs/double-
JonasToth added inline comments.
Comment at: lib/Analysis/ExprMutationAnalyzer.cpp:481
+ const auto AsArg =
+ anyOf(callExpr(hasAnyArgument(equalsNode(Exp))),
+cxxConstructExpr(hasAnyArgument(equalsNode(Exp))),
shuaiwang wrote:
> JonasToth wrote
101 - 153 of 153 matches
Mail list logo
