[PATCH] D52058: Add Parameters to DW_AT_name Attribute of Template Variables

JDevlieghere added a comment. Generally this looks good, but I'd like for the other to have a look first (at this and the other patch) before accepting. Comment at: lib/CodeGen/CGDebugInfo.cpp:1783 + if (auto *TS = dyn_cast(VL)) { +if (TS->getSpecializedTemplateOrPartial(

[PATCH] D52098: [Index] Add an option to collect macros from preprocesor.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Comment at: include/clang/Index/IndexingAction.h:59 /// Recursively indexes \p Decls. -/// Note that this does not index macros. -void indexTopLevelDecls(

[PATCH] D52079: [Sema] Do not load macros from preamble when LoadExternal is false.

ilya-biryukov added a comment. Maybe add a test? There is `test/Index/complete-pch-skip.cpp` that checks similar things for AST completions, adding macros there should be trivial. Repository: rC Clang https://reviews.llvm.org/D52079 ___ cfe-com

[PATCH] D52076: [CodeComplete] Add completions for filenames in #include directives.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Comment at: lib/Sema/SemaCodeComplete.cpp:8057 + if (!(Filename.endswith(".h") || Filename.endswith(".hh") || +Filename.endswith("

[PATCH] D51214: [clangd] Add options to enable/disable fixits and function argument snippets.

ilya-biryukov added a comment. Maybe commit only an option to enable function arg snippets for now (found myself wanting this option today :-))? The fixes would also be nice, but since they never work... Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51214 _

[PATCH] D52193: RFC: [clang] Multithreaded compilation support

hans added a comment. In https://reviews.llvm.org/D52193#1237468, @zturner wrote: > What about the timings of clang-cl without /MP? And one using Ninja rather than msbuild. I think the real question is whether we want clang and clang-cl to do this. I'm not sure we do as it adds complexity for

[PATCH] D52222: [clangd] Merge ClangdServer::DynamicIndex into FileIndex. NFC.

ioeric created this revision. ioeric added a reviewer: sammccall. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. FileIndex now provides explicit interfaces for preamble and main file updates. This avoids growing parameter list when preamble and main sy

[PATCH] D52098: [Index] Add an option to collect macros from preprocesor.

ioeric added inline comments. Comment at: unittests/Index/IndexTests.cpp:61 +S.Roles = Roles; +if (MI) + S.Info = getSymbolInfoForMacro(*MI); ilya-biryukov wrote: > ioeric wrote: > > ilya-biryukov wrote: > > > Can this actually happen? It seems weird

[PATCH] D52076: [CodeComplete] Add completions for filenames in #include directives.

sammccall added inline comments. Comment at: lib/Sema/SemaCodeComplete.cpp:8057 + if (!(Filename.endswith(".h") || Filename.endswith(".hh") || +Filename.endswith(".H") || Filename.endswith(".hpp") || +Filename.endswith(".inc"))) --

r342449 - [CodeComplete] Add completions for filenames in #include directives.

Author: sammccall Date: Tue Sep 18 01:40:41 2018 New Revision: 342449 URL: http://llvm.org/viewvc/llvm-project?rev=342449&view=rev Log: [CodeComplete] Add completions for filenames in #include directives. Summary: The dir component ("somedir" in #include ) is considered fixed. We append "foo" to

[PATCH] D52076: [CodeComplete] Add completions for filenames in #include directives.

This revision was automatically updated to reflect the committed changes. Closed by commit rC342449: [CodeComplete] Add completions for filenames in #include directives. (authored by sammccall, committed by ). Changed prior to commit: https://reviews.llvm.org/D52076?vs=165787&id=165904#toc Rep

[PATCH] D52076: [CodeComplete] Add completions for filenames in #include directives.

This revision was automatically updated to reflect the committed changes. Closed by commit rL342449: [CodeComplete] Add completions for filenames in #include directives. (authored by sammccall, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llv

r342451 - [Index] Add an option to collect macros from preprocesor.

Author: ioeric Date: Tue Sep 18 01:51:08 2018 New Revision: 342451 URL: http://llvm.org/viewvc/llvm-project?rev=342451&view=rev Log: [Index] Add an option to collect macros from preprocesor. Summary: Also added unit tests for the index library; lit+c-index-test is painful... Reviewers: ilya-bir

[PATCH] D52098: [Index] Add an option to collect macros from preprocesor.

This revision was automatically updated to reflect the committed changes. Closed by commit rL342451: [Index] Add an option to collect macros from preprocesor. (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D52098 File

[clang-tools-extra] r342452 - [clangd] Adapt API change after 342451.

Author: ioeric Date: Tue Sep 18 01:52:14 2018 New Revision: 342452 URL: http://llvm.org/viewvc/llvm-project?rev=342452&view=rev Log: [clangd] Adapt API change after 342451. Modified: clang-tools-extra/trunk/clangd/FindSymbols.cpp clang-tools-extra/trunk/clangd/XRefs.cpp clang-tools-ex

[clang-tools-extra] r342453 - [clangd] Update code completion for #include completions in r342449

Author: sammccall Date: Tue Sep 18 02:08:28 2018 New Revision: 342453 URL: http://llvm.org/viewvc/llvm-project?rev=342453&view=rev Log: [clangd] Update code completion for #include completions in r342449 Modified: clang-tools-extra/trunk/clangd/CodeComplete.cpp Modified: clang-tools-extra/tr

[PATCH] D52222: [clangd] Merge ClangdServer::DynamicIndex into FileIndex. NFC.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Glorious! Think the APIs could be simplified/clarified a little further, but up to you. Comment at: clangd/index/FileIndex.cpp:24 +indexSymbols(ASTContext &AST, std::s

[PATCH] D52187: [clang-tidy] use CHECK-NOTES in bugprone-unused-return-value

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG with a comment. Comment at: test/clang-tidy/bugprone-unused-return-value.cpp:81 std::async(std::launch::async, increment, 42); - // CHECK-MESSAGES: [[@LINE-1]]:3: warn

[PATCH] D52186: [clang-tidy] use CHECK-NOTES in bugprone-forwarding-reference-overload

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52186 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

[PATCH] D52178: [clang-tidy] use CHECK-NOTES in tests for bugprone-argument-comment

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52178 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

Re: [clang-tools-extra] r342388 - [Clang-Tidy: modernize] Fix for modernize-redundant-void-arg: complains about variable cast to void

Nope, that's fine. See my previous email. On Mon, Sep 17, 2018 at 3:18 PM IdrissRio wrote: > Yes I have already make the fix commit. It was an error in the tests. > > > https://github.com/llvm-mirror/clang-tools-extra/commit/77ed1cd838a249d6134de9a6bdbe17ef46ecf946 > > > Now on my Mac it compil

[clang-tools-extra] r342456 - [clangd] dexp tool uses llvm::cl to parse its flags.

Author: sammccall Date: Tue Sep 18 02:49:57 2018 New Revision: 342456 URL: http://llvm.org/viewvc/llvm-project?rev=342456&view=rev Log: [clangd] dexp tool uses llvm::cl to parse its flags. Summary: We can use cl::ResetCommandLineParser() to support different types of command-lines, as long as we'

[PATCH] D51989: [clangd] dexp tool uses llvm::cl to parse its flags.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE342456: [clangd] dexp tool uses llvm::cl to parse its flags. (authored by sammccall, committed by ). Herald added a subscriber: mgorny. Changed prior to commit: https://reviews.llvm.org/D51989?vs=1650

[clang-tools-extra] r342458 - [clang-tidy] use CHECK-NOTES in tests for bugprone-argument-comment

Author: jonastoth Date: Tue Sep 18 03:15:15 2018 New Revision: 342458 URL: http://llvm.org/viewvc/llvm-project?rev=342458&view=rev Log: [clang-tidy] use CHECK-NOTES in tests for bugprone-argument-comment Summary: This patch uses CHECK-NOTES for the tests. Its part of an effort to test *ALL* gener

[PATCH] D52178: [clang-tidy] use CHECK-NOTES in tests for bugprone-argument-comment

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE342458: [clang-tidy] use CHECK-NOTES in tests for bugprone-argument-comment (authored by JonasToth, committed by ). Changed prior to commit: https://reviews.llvm.org/D52178?vs=165784&id=165916#toc Re

[PATCH] D52178: [clang-tidy] use CHECK-NOTES in tests for bugprone-argument-comment

This revision was automatically updated to reflect the committed changes. Closed by commit rL342458: [clang-tidy] use CHECK-NOTES in tests for bugprone-argument-comment (authored by JonasToth, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org

[clang-tools-extra] r342459 - [clang-tidy] use CHECK-NOTES in bugprone-forwarding-reference-overload

Author: jonastoth Date: Tue Sep 18 03:21:33 2018 New Revision: 342459 URL: http://llvm.org/viewvc/llvm-project?rev=342459&view=rev Log: [clang-tidy] use CHECK-NOTES in bugprone-forwarding-reference-overload Reviewers: aaron.ballman, alexfh, hokein Reviewed By: alexfh Subscribers: xazax.hun, cfe

[PATCH] D52222: [clangd] Merge ClangdServer::DynamicIndex into FileIndex. NFC.

ioeric updated this revision to Diff 165918. ioeric marked 6 inline comments as done. ioeric added a comment. - addressed review comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D5 Files: clangd/ClangdServer.cpp clangd/ClangdServer.h clangd/index/FileIndex.cpp

[PATCH] D52225: [clang] Implement Override Suggestions in Sema.

kadircet created this revision. kadircet added reviewers: ioeric, ilya-biryukov. Herald added a subscriber: cfe-commits. In clangd we had a new type of completion suggestions for cpp class/struct/unions that will show override signatures for virtual methods in base classes. This patch implements i

[PATCH] D52186: [clang-tidy] use CHECK-NOTES in bugprone-forwarding-reference-overload

This revision was automatically updated to reflect the committed changes. Closed by commit rL342459: [clang-tidy] use CHECK-NOTES in bugprone-forwarding-reference-overload (authored by JonasToth, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.

[PATCH] D52186: [clang-tidy] use CHECK-NOTES in bugprone-forwarding-reference-overload

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE342459: [clang-tidy] use CHECK-NOTES in bugprone-forwarding-reference-overload (authored by JonasToth, committed by ). Changed prior to commit: https://reviews.llvm.org/D52186?vs=165806&id=165920#toc

[PATCH] D52222: [clangd] Merge ClangdServer::DynamicIndex into FileIndex. NFC.

ioeric added inline comments. Comment at: clangd/index/FileIndex.h:121 std::pair indexAST(ASTContext &AST, std::shared_ptr PP, llvm::ArrayRef URISchemes = {}); sammccall wrote: > indexPreamble would be clearer I think. What about `indexHeaderSymbols`?

[PATCH] D52222: [clangd] Merge ClangdServer::DynamicIndex into FileIndex. NFC.

sammccall added inline comments. Comment at: clangd/index/FileIndex.h:121 std::pair indexAST(ASTContext &AST, std::shared_ptr PP, llvm::ArrayRef URISchemes = {}); ioeric wrote: > sammccall wrote: > > indexPreamble would be clearer I think. > What abou

[clang-tools-extra] r342460 - [clangd] Merge ClangdServer::DynamicIndex into FileIndex. NFC.

Author: ioeric Date: Tue Sep 18 03:30:44 2018 New Revision: 342460 URL: http://llvm.org/viewvc/llvm-project?rev=342460&view=rev Log: [clangd] Merge ClangdServer::DynamicIndex into FileIndex. NFC. Summary: FileIndex now provides explicit interfaces for preamble and main file updates. This avoids g

[PATCH] D52222: [clangd] Merge ClangdServer::DynamicIndex into FileIndex. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE342460: [clangd] Merge ClangdServer::DynamicIndex into FileIndex. NFC. (authored by ioeric, committed by ). Changed prior to commit: https://reviews.llvm.org/D5?vs=165918&id=165923#toc Repository

[PATCH] D52222: [clangd] Merge ClangdServer::DynamicIndex into FileIndex. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rL342460: [clangd] Merge ClangdServer::DynamicIndex into FileIndex. NFC. (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D5

[PATCH] D52226: [clangd] Remove override result handling logic from clangd

kadircet created this revision. kadircet added reviewers: ioeric, ilya-biryukov. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay. kadircet added a dependency: D52225: [clang] Implement Override Suggestions in Sema.. Since we plan to move handling of override suggestions to Sema

[PATCH] D52187: [clang-tidy] use CHECK-NOTES in bugprone-unused-return-value

JonasToth updated this revision to Diff 165926. JonasToth added a comment. - shorten warning checks Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52187 Files: test/clang-tidy/bugprone-unused-return-value-custom.cpp test/clang-tidy/bugprone-unused-return-value.cpp Index: t

[PATCH] D52228: [clang-tidy] use CHECK-NOTES in tests for bugprone-use-after-move

JonasToth created this revision. JonasToth added reviewers: alexfh, aaron.ballman, hokein. Herald added subscribers: cfe-commits, xazax.hun. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52228 Files: test/clang-tidy/bugprone-use-after-move.cpp Index: test/clang-tidy/bugprone-

[clang-tools-extra] r342468 - [clang-tidy] use CHECK-NOTES in bugprone-unused-return-value

Author: jonastoth Date: Tue Sep 18 04:49:20 2018 New Revision: 342468 URL: http://llvm.org/viewvc/llvm-project?rev=342468&view=rev Log: [clang-tidy] use CHECK-NOTES in bugprone-unused-return-value Reviewers: aaron.ballman, alexfh, hokein Reviewed By: alexfh Subscribers: xazax.hun, cfe-commits

[PATCH] D52187: [clang-tidy] use CHECK-NOTES in bugprone-unused-return-value

This revision was automatically updated to reflect the committed changes. Closed by commit rL342468: [clang-tidy] use CHECK-NOTES in bugprone-unused-return-value (authored by JonasToth, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D52187

[PATCH] D52229: [clang-tidy] use CHECK-NOTES in tests for bugprone suspicious-enum-usage

JonasToth created this revision. JonasToth added reviewers: alexfh, aaron.ballman, hokein. Herald added subscribers: cfe-commits, xazax.hun. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52229 Files: test/clang-tidy/bugprone-suspicious-enum-usage-strict.cpp test/clang-tidy/b

[PATCH] D52230: [clang-tidy] use CHECK-NOTES in tests for bugprone-macro-repeated-side-effects

JonasToth created this revision. JonasToth added reviewers: alexfh, aaron.ballman, hokein. Herald added subscribers: cfe-commits, xazax.hun. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52230 Files: test/clang-tidy/bugprone-macro-repeated-side-effects.c Index: test/clang-tid

[PATCH] D52179: [clang-tidy] Replace redundant checks with an assert().

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:551-552 if (Decl->isMain() || !Decl->isUserProvided() || -Dec

[PATCH] D52200: Thread safety analysis: Handle ObjCIvarRefExpr in SExprBuilder::translate

aaron.ballman added a reviewer: rjmccall. aaron.ballman added a comment. Adding a reviewer who knows more about ObjC than I do. Comment at: include/clang/Analysis/Analyses/ThreadSafetyCommon.h:400 til::SExpr *translateMemberExpr(const MemberExpr *ME, CallingContext *Ctx); +

[PATCH] D52222: [clangd] Merge ClangdServer::DynamicIndex into FileIndex. NFC.

sammccall added inline comments. Comment at: clangd/index/FileIndex.h:77 + /// Update symbols from main file \p Path with symbols in \p TopLevelDecls. + void updateMain(PathRef Path, ASTContext &AST, + std::shared_ptr PP, sammccall wrote: > can

[PATCH] D50948: lambdas in modules: change storage for LambdaDefinitionData

elsteveogrande updated this revision to Diff 165947. elsteveogrande added a comment. Rebase past dependency commit C341499, fix a conflict Repository: rC Clang https://reviews.llvm.org/D50948 Files: include/clang/AST/DeclCXX.h lib/AST/DeclCXX.cpp lib/Serialization/ASTReaderDecl.cpp l

[PATCH] D50949: lambdas in modules: handle lambdas in .pcm [de]serialization

elsteveogrande updated this revision to Diff 165948. elsteveogrande added a comment. Rebase atop updated dependency https://reviews.llvm.org/D50948. Small cleanups to this diff. Repository: rC Clang https://reviews.llvm.org/D50949 Files: include/clang/AST/DeclCXX.h include/clang/AST/La

r342470 - cl-options.c: Fix negative -cfguard check

Author: hans Date: Tue Sep 18 06:07:55 2018 New Revision: 342470 URL: http://llvm.org/viewvc/llvm-project?rev=342470&view=rev Log: cl-options.c: Fix negative -cfguard check Modified: cfe/trunk/test/Driver/cl-options.c Modified: cfe/trunk/test/Driver/cl-options.c URL: http://llvm.org/viewvc/

Re: [PATCH] D52193: RFC: [clang] Multithreaded compilation support

In an ideal world yes, but the reality is that many people still use MSBuild, and in that world /MP presumably helps quite a bit. And given that many people already depend on this functionality of cl, it’s a potential showstopper for migrating if we don’t support it. That said, if the benefit isn’t

[PATCH] D51789: [clang] Add the exclude_from_explicit_instantiation attribute

ldionne added a comment. I'm thinking about this some more, and I'm wondering whether it would be a viable solution to just exclude members marked with hidden visibility from explicit template instantiations (and declarations thereof). I thought I had been convinced by Hubert

[PATCH] D52193: RFC: [clang] Multithreaded compilation support

zturner added a subscriber: aganea. zturner added a comment. In an ideal world yes, but the reality is that many people still use MSBuild, and in that world /MP presumably helps quite a bit. And given that many people already depend on this functionality of cl, it’s a potential showstopper for mig

[clang-tools-extra] r342473 - [clangd] Get rid of Decls parameter in indexMainDecls. NFC

Author: ioeric Date: Tue Sep 18 06:35:16 2018 New Revision: 342473 URL: http://llvm.org/viewvc/llvm-project?rev=342473&view=rev Log: [clangd] Get rid of Decls parameter in indexMainDecls. NFC It's already available in ParsedAST. Modified: clang-tools-extra/trunk/clangd/ClangdServer.cpp c

[PATCH] D52222: [clangd] Merge ClangdServer::DynamicIndex into FileIndex. NFC.

ioeric added inline comments. Comment at: clangd/index/FileIndex.h:77 + /// Update symbols from main file \p Path with symbols in \p TopLevelDecls. + void updateMain(PathRef Path, ASTContext &AST, + std::shared_ptr PP, sammccall wrote: > sammcc

[PATCH] D52078: [clangd] Store preamble macros in dynamic index.

ioeric updated this revision to Diff 165959. ioeric added a comment. - merge with origin/master Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52078 Files: clangd/index/FileIndex.cpp unittests/clangd/CodeCompleteTests.cpp unittests/clangd/FileIndexTests.cpp Index: unitte

[PATCH] D52047: [clangd] Add a "benchmark" for tracking memory

kbobyrev updated this revision to Diff 165962. kbobyrev marked an inline comment as done. kbobyrev added a comment. Rebase on top of master, move logging to symbol index `build()` caller side. https://reviews.llvm.org/D52047 Files: clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp clan

[PATCH] D52084: [clangd] NFC: Update documentation of Iterator's dump format

kbobyrev updated this revision to Diff 165964. kbobyrev added a comment. @ioeric does this format look better? https://reviews.llvm.org/D52084 Files: clang-tools-extra/clangd/index/dex/Iterator.h clang-tools-extra/clangd/index/dex/PostingList.cpp clang-tools-extra/unittests/clangd/DexTest

[PATCH] D51340: [WIP] Add /Zc:DllexportInlines option to clang-cl

takuto.ikuta updated this revision to Diff 165966. takuto.ikuta edited the summary of this revision. takuto.ikuta added a comment. Current implementation cannot build chrome when pch is enabled. undefined symbol error happens during linking blink_modules.dll https://reviews.llvm.org/D51340 File

[PATCH] D52084: [clangd] NFC: Update documentation of Iterator's dump format

ioeric accepted this revision. ioeric added inline comments. Comment at: clang-tools-extra/clangd/index/dex/PostingList.cpp:66 + OS << "... "; if (Index != std::end(Documents)) + OS << *Index << " ..."; nit: should we drop the trailing `...` if Ind

[PATCH] D52079: [Sema] Do not load macros from preamble when LoadExternal is false.

ioeric updated this revision to Diff 165969. ioeric added a comment. - added lit test Repository: rC Clang https://reviews.llvm.org/D52079 Files: include/clang/Sema/CodeCompleteOptions.h lib/Sema/SemaCodeComplete.cpp test/Index/complete-pch-skip.cpp Index: test/Index/complete-pch-skip

[PATCH] D52078: [clangd] Store preamble macros in dynamic index.

sammccall accepted this revision. sammccall added a comment. Something not listed in cons: because macros aren't namespaced and we don't have lots of signals, they can be really spammy. Potentially, offering macros that aren't in the TU could be a loss even if it's a win for other types of sign

[PATCH] D52084: [clangd] Improve PostingList iterator string representation

kbobyrev updated this revision to Diff 165973. kbobyrev marked an inline comment as done. https://reviews.llvm.org/D52084 Files: clang-tools-extra/clangd/index/dex/Iterator.h clang-tools-extra/clangd/index/dex/PostingList.cpp clang-tools-extra/unittests/clangd/DexTests.cpp Index: clang-to

[PATCH] D52233: [dexp] Allow users to dump JSON representations of fuzzy find requests

kbobyrev created this revision. kbobyrev added reviewers: ioeric, ilya-biryukov. kbobyrev added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, jkorous. This might be useful for benchmark construction. https://reviews.llvm.org/D52233 Files: clang-tools-extra/clangd

[PATCH] D52078: [clangd] Store preamble macros in dynamic index.

ioeric added a comment. In https://reviews.llvm.org/D52078#1238301, @sammccall wrote: > Something not listed in cons: because macros aren't namespaced and we don't > have lots of signals, they can be really spammy. > Potentially, offering macros that aren't in the TU could be a loss even if >

r342484 - [index] Enhance indexing for module references

Author: akirtzidis Date: Tue Sep 18 08:02:56 2018 New Revision: 342484 URL: http://llvm.org/viewvc/llvm-project?rev=342484&view=rev Log: [index] Enhance indexing for module references * Create a USR for the occurrences of the 'module' symbol kind * Record module references for each identifier in

[PATCH] D50948: lambdas in modules: change storage for LambdaDefinitionData

rsmith added a comment. We don't want to allocate storage for the lambda fields for non-lambda classes, which is why we use distinct base classes. Is the problem you're trying to solve here that we fake a definition in AST deserialization before we know whether the class is a lambda? If so, tha

Re: [PATCH] D52078: [clangd] Store preamble macros in dynamic index.

On Tue, Sep 18, 2018, 16:28 Eric Liu via Phabricator < revi...@reviews.llvm.org> wrote: > ioeric added a comment. > > In https://reviews.llvm.org/D52078#1238301, @sammccall wrote: > > > Something not listed in cons: because macros aren't namespaced and we > don't have lots of signals, they can be

[PATCH] D52078: [clangd] Store preamble macros in dynamic index.

cfe-commits added a comment. - F7238787: msg-7222-125.txt Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52078 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-b

[PATCH] D51789: [clang] Add the exclude_from_explicit_instantiation attribute

rjmccall added a comment. That may work for libc++'s purposes, but it's clearly inappropriate as a compiler rule. There are good reasons why something with hidden visibility would need to be explicitly instantiated. For many programmers, hidden visibility means "this is private to my library"

[PATCH] D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--)

alexfh added a comment. This is intended, IIUC. The syntax of the clang-tidy-diff.py mirrors the syntax of clang-tidy itself, and the `--` option is used in the same way as in clang-tidy - to denote the start of compiler arguments (and switch to the fixed compilation database). Do you have a us

[PATCH] D51789: [clang] Add the exclude_from_explicit_instantiation attribute

ldionne added a comment. In https://reviews.llvm.org/D51789#1238396, @rjmccall wrote: > That may work for libc++'s purposes, but it's clearly inappropriate as a > compiler rule. There are good reasons why something with hidden visibility > would need to be explicitly instantiated. I take you

[PATCH] D52200: Thread safety analysis: Handle ObjCIvarRefExpr in SExprBuilder::translate

rjmccall added inline comments. Comment at: lib/Analysis/ThreadSafetyCommon.cpp:362 + til::Project *P = new (Arena) til::Project(E, D); + if (hasCppPointerType(BE)) +P->setArrow(true); aaron.ballman wrote: > I feel like this will always return false. Howeve

[PATCH] D52219: [analyzer] (1/n) Support pointee mutation analysis in ExprMutationAnalyzer.

JonasToth added a comment. Looks like a good start! I think getting the pointers right will be most difficult, because of the multiple levels of indirection they allow. Do you think it would be possible to the analysis for `>const?< int ***`-cases? (recursively checking through the pointer leve

[PATCH] D52058: Add Parameters to DW_AT_name Attribute of Template Variables

ormris added a comment. In https://reviews.llvm.org/D52058#1237868, @JDevlieghere wrote: > Generally this looks good, but I'd like for the other to have a look first > (at this and the other patch) before accepting. Sounds good. Thanks for your comments! Comment at: lib/Cod

[PATCH] D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--)

janosimas added a comment. To use in a git pre-commit I wanted to use the flags: -warnings-as-errors=* -header-filter=.* I wanted that the script returned an error value for my selected checks, even if they are just warnings. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D4986

[PATCH] D51372: FENV_ACCESS support for libm-style constrained intrinsics

kpn updated this revision to Diff 165995. kpn added a comment. Rebase. Correct obvious error with powi. Fix test and test both C and (partial) C++. Ping. https://reviews.llvm.org/D51372 Files: include/clang/AST/Expr.h include/clang/AST/ExprCXX.h lib/AST/ASTImporter.cpp lib/AST/Expr.cp

[PATCH] D50766: Fix false positive unsequenced access and modification warning in array subscript expression.

stryku added a comment. Friendly ping (: https://reviews.llvm.org/D50766 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52084: [clangd] Improve PostingList iterator string representation

sammccall accepted this revision. sammccall added a comment. This change seems fine but... This representation with the raw DocIDs and position dumped seems mostly useful for debugging buggy iterator implementations, but not really useful for understanding query structure and behavior. I thoug

r342499 - [Modules] Add platform and environment features to requires clause

Author: bruno Date: Tue Sep 18 10:11:13 2018 New Revision: 342499 URL: http://llvm.org/viewvc/llvm-project?rev=342499&view=rev Log: [Modules] Add platform and environment features to requires clause Allows module map writers to add build requirements based on platform/os. This helps when target f

[PATCH] D51910: [Modules] Add platform feature to requires clause

This revision was automatically updated to reflect the committed changes. Closed by commit rC342499: [Modules] Add platform and environment features to requires clause (authored by bruno, committed by ). Changed prior to commit: https://reviews.llvm.org/D51910?vs=165861&id=165998#toc Repositor

[PATCH] D51910: [Modules] Add platform feature to requires clause

This revision was automatically updated to reflect the committed changes. Closed by commit rL342499: [Modules] Add platform and environment features to requires clause (authored by bruno, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/

[PATCH] D51789: [clang] Add the exclude_from_explicit_instantiation attribute

rjmccall added a comment. In https://reviews.llvm.org/D51789#1238410, @ldionne wrote: > In https://reviews.llvm.org/D51789#1238396, @rjmccall wrote: > > > That may work for libc++'s purposes, but it's clearly inappropriate as a > > compiler rule. There are good reasons why something with hidden

Re: [PATCH] D51438: [clangd] Run SignatureHelp using an up-to-date preamble, waiting if needed.

Hi Sam, It took a very long time to identify it, but this commit broke ARMv7 bots, where this test hangs. Logs are available here (initial ones are too old): http://lab.llvm.org:8011/builders/clang-cmake-armv7-quick/builds/3685/steps/ninja%20check%201/logs/stdiohttp://lab.llvm.org:8011/builders/

[PATCH] D52084: [clangd] Improve PostingList iterator string representation

kbobyrev added a comment. In https://reviews.llvm.org/D52084#1238537, @sammccall wrote: > This change seems fine but... > > This representation with the raw DocIDs and position dumped seems mostly > useful for debugging buggy iterator implementations, but not really useful > for understanding q

[PATCH] D52191: Fix logic around determining use of frame pointer with -pg.

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sure, looks good. Though my other/vague concern is why does this case error about fomit-frame-pointer having no effect, but other things (like using -fomit-frame-pointer on a target that r

[PATCH] D52191: Fix logic around determining use of frame pointer with -pg.

srhines added a comment. In https://reviews.llvm.org/D52191#1238628, @dblaikie wrote: > Sure, looks good. Though my other/vague concern is why does this case error > about fomit-frame-pointer having no effect, but other things (like using > -fomit-frame-pointer on a target that requires frame p

r342501 - Fix logic around determining use of frame pointer with -pg.

Author: srhines Date: Tue Sep 18 11:34:33 2018 New Revision: 342501 URL: http://llvm.org/viewvc/llvm-project?rev=342501&view=rev Log: Fix logic around determining use of frame pointer with -pg. Summary: As part of r342165, I rewrote the logic to check whether -fno-omit-frame-pointer was passed af

[PATCH] D52191: Fix logic around determining use of frame pointer with -pg.

This revision was automatically updated to reflect the committed changes. Closed by commit rL342501: Fix logic around determining use of frame pointer with -pg. (authored by srhines, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D52191 F

[PATCH] D52191: Fix logic around determining use of frame pointer with -pg.

This revision was automatically updated to reflect the committed changes. Closed by commit rC342501: Fix logic around determining use of frame pointer with -pg. (authored by srhines, committed by ). Changed prior to commit: https://reviews.llvm.org/D52191?vs=165826&id=166007#toc Repository:

[clang-tools-extra] r342505 - [clangd] Fix error handling for SymbolID parsing (notably YAML and dexp)

Author: sammccall Date: Tue Sep 18 12:00:59 2018 New Revision: 342505 URL: http://llvm.org/viewvc/llvm-project?rev=342505&view=rev Log: [clangd] Fix error handling for SymbolID parsing (notably YAML and dexp) Modified: clang-tools-extra/trunk/clangd/index/Index.cpp clang-tools-extra/trunk

[PATCH] D52191: Fix logic around determining use of frame pointer with -pg.

dblaikie added a comment. In https://reviews.llvm.org/D52191#1238648, @srhines wrote: > In https://reviews.llvm.org/D52191#1238628, @dblaikie wrote: > > > Sure, looks good. Though my other/vague concern is why does this case error > > about fomit-frame-pointer having no effect, but other things

Re: [clang-tools-extra] r342227 - [clangd] NFC: Fix IndexBenchmark CLI arguments handling

Hi Roman, Is there any benefit of doing so? Also, I’m not sure whether I understood you correctly. Consuming benchmark options *before* trimming would probably not be the desired behaviour since the first two arguments arguments are passed directly to the tool driver. I might have misunderstoo

Re: [clang-tools-extra] r342227 - [clangd] NFC: Fix IndexBenchmark CLI arguments handling

On Tue, Sep 18, 2018 at 10:09 PM, Kirill Bobyrev wrote: > Hi Roman, > > Is there any benefit of doing so? Also, I’m not sure whether I understood you > correctly. Consuming benchmark options *before* trimming would probably not > be the desired behaviour since the first two arguments arguments a

Re: [clang-tools-extra] r342227 - [clangd] NFC: Fix IndexBenchmark CLI arguments handling

Thanks for the explanation! I didn’t know that benchmark’s Initialize does that, that was probably the source of my confusion. The suggestion looks reasonable, I should try this approach, it looks to be cleaner. -Kirill > On 18 Sep 2018, at 21:16, Roman Lebedev wrote: > > On Tue, Sep 18, 2018

[PATCH] D52200: Thread safety analysis: Handle ObjCIvarRefExpr in SExprBuilder::translate

aaronpuchert planned changes to this revision. aaronpuchert added a comment. Thanks to both of you for the reviews. I'll see what I can do about the arrows. My gut feeling is that using `{Member,ObjCIVarRef}Expr::isArrow` is the right way, but it's not yet obvious to me how.

[PATCH] D52191: Fix logic around determining use of frame pointer with -pg.

vsapsai added a comment. Seems like this change causes 2 test failures: Clang :: Driver/clang_f_opts.c Clang :: Frontend/gnu-mcount.c Some of the failing bots are http://lab.llvm.org:8011/builders/clang-cmake-aarch64-quick/builds/15363/ http://green.lab.llvm.org/green/job/clang-stage1-cmake

[PATCH] D50901: [clang][ubsan] Split Implicit Integer Truncation Sanitizer into unsigned and signed checks

lebedev.ri added a comment. @rsmith - ping. This one should be rather uncontroversial i think? Is this moving in the direction you suggested? :) Repository: rC Clang https://reviews.llvm.org/D50901 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D52191: Fix logic around determining use of frame pointer with -pg.

rdhindsa added a comment. It seems that following tests are broken with this change: clang/test/Driver/clang_f_opts.c clang/test/Frontend/gnu-mcount.c Repository: rL LLVM https://reviews.llvm.org/D52191 ___ cfe-commits mailing list cfe-commits@l

RE: r342501 - Fix logic around determining use of frame pointer with -pg.

Hi Stephen, Your change is causing a test failure on the PS4 linux bot, can you please take a look? http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/36712/steps/test/logs/stdio FAIL: Clang :: Driver/clang_f_opts.c (8141 of 44013) TEST 'Cla

[PATCH] D52191: Fix logic around determining use of frame pointer with -pg.

vsapsai added a comment. Confirm that reverting the change locally fixes the tests. If nobody beats me to it, I plan to revert the change in 30-60 minutes. @srhines, if you want to fix it in another way and need more time, please let me know. Repository: rL LLVM https://reviews.llvm.org/D52

  1   2   >