[PATCH] D50171: [python] [tests] Update test_code_completion

ilya-biryukov added a comment. Will take a closer look. Thanks for finding the offending revision. https://reviews.llvm.org/D50171 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51628: [clangd] Implement a Proof-of-Concept tool for symbol index exploration

kbobyrev updated this revision to Diff 165016. kbobyrev marked an inline comment as done. kbobyrev added a comment. Remove artifact comment. https://reviews.llvm.org/D51628 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/index/dex/dexp/CMakeLists.txt clang-tools-ex

[clang-tools-extra] r342025 - [clangd] Implement a Proof-of-Concept tool for symbol index exploration

Author: omtcyfz Date: Wed Sep 12 00:32:54 2018 New Revision: 342025 URL: http://llvm.org/viewvc/llvm-project?rev=342025&view=rev Log: [clangd] Implement a Proof-of-Concept tool for symbol index exploration Reviewed By: sammccall, ilya-biryukov Differential Revision: https://reviews.llvm.org/D516

[PATCH] D51628: [clangd] Implement a Proof-of-Concept tool for symbol index exploration

This revision was automatically updated to reflect the committed changes. Closed by commit rL342025: [clangd] Implement a Proof-of-Concept tool for symbol index exploration (authored by omtcyfz, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.ll

[clang-tools-extra] r342026 - [clangd] Add index benchmarks

Author: omtcyfz Date: Wed Sep 12 00:49:44 2018 New Revision: 342026 URL: http://llvm.org/viewvc/llvm-project?rev=342026&view=rev Log: [clangd] Add index benchmarks This patch introduces index benchmarks on top of the proposed LLVM benchmark pull. Reviewed By: sammccall, lebedev.ri Differential

[PATCH] D51090: [clangd] Add index benchmarks

kbobyrev updated this revision to Diff 165023. kbobyrev marked an inline comment as done. https://reviews.llvm.org/D51090 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/benchmarks/CMakeLists.txt clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp clang-tools-ex

[PATCH] D51090: [clangd] Add index benchmarks

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE342026: [clangd] Add index benchmarks (authored by omtcyfz, committed by ). Changed prior to commit: https://reviews.llvm.org/D51090?vs=165023&id=165024#toc Repository: rL LLVM https://reviews.llv

[PATCH] D51090: [clangd] Add index benchmarks

This revision was automatically updated to reflect the committed changes. Closed by commit rL342026: [clangd] Add index benchmarks (authored by omtcyfz, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51090?vs=165023&id=165025#toc Rep

r342028 - [Tooling] Wait for all threads to finish before resetting CWD.

Author: ioeric Date: Wed Sep 12 01:29:47 2018 New Revision: 342028 URL: http://llvm.org/viewvc/llvm-project?rev=342028&view=rev Log: [Tooling] Wait for all threads to finish before resetting CWD. Modified: cfe/trunk/lib/Tooling/AllTUsExecution.cpp Modified: cfe/trunk/lib/Tooling/AllTUsExecut

r342031 - Fix Check test to avoid output string mismatch

Author: chrib Date: Wed Sep 12 01:59:17 2018 New Revision: 342031 URL: http://llvm.org/viewvc/llvm-project?rev=342031&view=rev Log: Fix Check test to avoid output string mismatch Differential Revision: http://reviews.llvm.org/D51354 Modified: cfe/trunk/test/Driver/print-multi-directory.c M

r342034 - [CodeGen][ARM] Coerce FP16 vectors to integer vectors when needed

Author: miyuki Date: Wed Sep 12 02:19:19 2018 New Revision: 342034 URL: http://llvm.org/viewvc/llvm-project?rev=342034&view=rev Log: [CodeGen][ARM] Coerce FP16 vectors to integer vectors when needed Summary: On targets that do not support FP16 natively LLVM currently legalizes vectors of FP16 val

[PATCH] D50507: [CodeGen][ARM] Coerce FP16 vectors to integer vectors when needed

This revision was automatically updated to reflect the committed changes. Closed by commit rC342034: [CodeGen][ARM] Coerce FP16 vectors to integer vectors when needed (authored by miyuki, committed by ). Repository: rC Clang https://reviews.llvm.org/D50507 Files: lib/CodeGen/TargetInfo.cpp

[PATCH] D51597: [ASTImporter] Fix import of VarDecl init

martong marked 3 inline comments as done. martong added inline comments. Comment at: lib/AST/ASTImporter.cpp:1441 + To->setInit(ToInit); + if (From->isInitKnownICE()) { +EvaluatedStmt *Eval = To->ensureEvaluatedStmt(); a_sidorin wrote: > I see that this is

[PATCH] D51597: [ASTImporter] Fix import of VarDecl init

martong updated this revision to Diff 165039. martong marked an inline comment as done. martong added a comment. - Fix formatting and typo Repository: rC Clang https://reviews.llvm.org/D51597 Files: lib/AST/ASTImporter.cpp unittests/AST/ASTImporterTest.cpp Index: unittests/AST/ASTImport

[clang-tools-extra] r342036 - Fix buildbots after r342027

Author: omtcyfz Date: Wed Sep 12 02:27:55 2018 New Revision: 342036 URL: http://llvm.org/viewvc/llvm-project?rev=342036&view=rev Log: Fix buildbots after r342027 Modified: clang-tools-extra/trunk/test/clangd/index-tools.test Modified: clang-tools-extra/trunk/test/clangd/index-tools.test URL:

[clang-tools-extra] r342037 - [clangd] Add missing clangBasic target_link_libraries

Author: aheejin Date: Wed Sep 12 02:40:13 2018 New Revision: 342037 URL: http://llvm.org/viewvc/llvm-project?rev=342037&view=rev Log: [clangd] Add missing clangBasic target_link_libraries Without this, builds with `-DSHARED_LIB=ON` fail. Modified: clang-tools-extra/trunk/clangd/index/dex/dex

[clang-tools-extra] r342041 - [clang-tidy] Abseil: Add more directories that are slated for future absl expansion.

Author: d0k Date: Wed Sep 12 03:04:16 2018 New Revision: 342041 URL: http://llvm.org/viewvc/llvm-project?rev=342041&view=rev Log: [clang-tidy] Abseil: Add more directories that are slated for future absl expansion. Modified: clang-tools-extra/trunk/clang-tidy/abseil/AbseilMatcher.h Modified

[PATCH] D51847: Print correctly dependency paths on Windows

xbolva00 updated this revision to Diff 165052. xbolva00 added a comment. - Fixed failing test https://reviews.llvm.org/D51847 Files: lib/Frontend/DependencyFile.cpp test/Frontend/dependency-gen-escaping.c Index: test/Frontend/dependency-gen-escaping.c =

[PATCH] D51971: [clangd] Use JSON format in benchmark requests reader

kbobyrev created this revision. kbobyrev added reviewers: ioeric, ilya-biryukov. kbobyrev added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. After `FuzzyFindRequest` JSON (de)serialization was introduced, it should replace ad-hoc fuzzy-find request

[PATCH] D51972: [RISCV] Explicitly set an empty --sysroot in the test

rogfer01 created this revision. rogfer01 added reviewers: lewis-revill, asb, simoncook, kristina. Herald added subscribers: jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, mgrang, edward-jones, zzheng, shiva0217, kito-cheng, niosHD, sabuasal, apazos, johnrusso, rbar. In https://reviews

[PATCH] D51949: [WIP][clang-tidy] initial ideas to isolate variable declarations

JonasToth added a comment. I knew there was something already but I couldn't find it. Thank you for pointing me there :) I will inspect the code and then decide, maybe I will incorporate some of his stuff into mine or take his one over. Am 12.09.2018 um 08:04 schrieb Roman Lebedev via Phabricato

[PATCH] D51977: [clangd] Clarify and hide -index flag.

ioeric created this revision. ioeric added reviewers: sammccall, ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. The wording implies global index support, which is confusing. As most users shouldn't care about this flag, also make it hidden to avoid furt

[clang-tools-extra] r342052 - Fix MSVC "not all control paths return a value" warnings. NFCI.

Author: rksimon Date: Wed Sep 12 05:56:58 2018 New Revision: 342052 URL: http://llvm.org/viewvc/llvm-project?rev=342052&view=rev Log: Fix MSVC "not all control paths return a value" warnings. NFCI. Modified: clang-tools-extra/trunk/clang-doc/MDGenerator.cpp Modified: clang-tools-extra/trunk/

[PATCH] D51429: [AArch64] Return Address Signing B Key Support

SjoerdMeijer added inline comments. Comment at: test/CodeGen/aarch64-sign-return-address.c:3 // RUN: %clang -target aarch64-arm-none-eabi -S -emit-llvm -o - -msign-return-address=non-leaf %s | FileCheck %s --check-prefix=CHECK-PARTIAL // RUN: %clang -target aarch64-arm-none-ea

[PATCH] D51949: [WIP][clang-tidy] initial ideas to isolate variable declarations

kbobyrev added inline comments. Comment at: clang-tidy/readability/IsolateDeclCheck.cpp:35 + + std::string TypeAndName = + VarType.getAsString(TypePrinter) + " " + D->getNameAsString(); `llvm::Twine` here? Seems like this one is used a lot for concatenation

Re: [PATCH] D51847: Print correctly dependency paths on Windows

Lgtm On Wed, Sep 12, 2018 at 3:23 AM Dávid Bolvanský via Phabricator < revi...@reviews.llvm.org> wrote: > xbolva00 updated this revision to Diff 165052. > xbolva00 added a comment. > > - Fixed failing test > > > https://reviews.llvm.org/D51847 > > Files: > lib/Frontend/DependencyFile.cpp > tes

[PATCH] D51847: Print correctly dependency paths on Windows

cfe-commits added a comment. Lgtm - F7184192: msg-6991-166.txt https://reviews.llvm.org/D51847 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51982: [clangd] Introduce PostingList interface

kbobyrev created this revision. kbobyrev added reviewers: ioeric, ilya-biryukov, sammccall. kbobyrev added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, mgorny. This patch introduces `PostingList` interface which is helpful for experiments with Spar

[PATCH] D51982: [clangd] Introduce PostingList interface

kbobyrev planned changes to this revision. kbobyrev added a comment. There is not enough documentation right now, I should fix that before patch could be reviewed. This is a preview mode. Also, Index size estimation is incorrect now and will be fixed in the next diff. https://reviews.llvm.org/

[PATCH] D51416: [RTTI] Align rtti types to prevent over-alignment

dmgreen added a comment. That sounds like a good idea. Thanks for the help on this one. https://reviews.llvm.org/D51416 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r342053 - [CodeGen] Align rtti and vtable data

Author: dmgreen Date: Wed Sep 12 07:09:06 2018 New Revision: 342053 URL: http://llvm.org/viewvc/llvm-project?rev=342053&view=rev Log: [CodeGen] Align rtti and vtable data Previously the alignment on the newly created rtti/typeinfo data was largely not set, meaning that DataLayout::getPreferredAli

[PATCH] D51416: [RTTI] Align rtti types to prevent over-alignment

This revision was automatically updated to reflect the committed changes. Closed by commit rL342053: [CodeGen] Align rtti and vtable data (authored by dmgreen, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51416?vs=164693&id=165077#t

[PATCH] D51986: Fixes for `LLVM_LINK_LLVM_DYLIB` && Polly.

DiamondLovesYou created this revision. DiamondLovesYou added a reviewer: beanz. Herald added subscribers: cfe-commits, mgorny. Herald added a reviewer: bollu. clang doesn't need to link Polly when built with `LLVM_LINK_LLVM_DYLIB`. Repository: rC Clang https://reviews.llvm.org/D51986 Files:

[PATCH] D51987: [clangd] Rename global-symbol-builder to clangd-symbol-builder.

ilya-biryukov created this revision. ilya-biryukov added reviewers: ioeric, sammccall, kadircet. Herald added subscribers: arphaman, jkorous, MaskRay, mgorny. Given that the indexer binary is put directly into ./bin directory when built, 'clangd-' prefix seems to provide better context to the read

[PATCH] D51987: [clangd] Rename global-symbol-builder to clangd-symbol-builder.

ilya-biryukov updated this revision to Diff 165085. ilya-biryukov added a comment. - Rebase, updated the added test Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51987 Files: clangd/CMakeLists.txt clangd/global-symbol-builder/CMakeLists.txt clangd/global-symbol-builder/G

[PATCH] D51987: [clangd] Rename global-symbol-builder to clangd-symbol-builder.

ilya-biryukov added a comment. We've used the new name internally before and now that we're testing this, we need to be consistent. The 'clangd-symbol-builder' looks like a better choice, so I'm pitching changing upstream first. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D5

[PATCH] D51987: [clangd] Rename global-symbol-builder to clangd-symbol-builder.

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. lgtm +1 to `clang-symbol-builder` Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51987 ___ cfe-commits mailing list cfe-commits

Re: [PATCH] D51987: [clangd] Rename global-symbol-builder to clangd-symbol-builder.

I mean `clangd-symbol-builder` On Wed, Sep 12, 2018 at 4:32 PM Eric Liu via Phabricator < revi...@reviews.llvm.org> wrote: > ioeric accepted this revision. > ioeric added a comment. > This revision is now accepted and ready to land. > > lgtm > > +1 to `clang-symbol-builder` > > > Repository: >

[PATCH] D51987: [clangd] Rename global-symbol-builder to clangd-symbol-builder.

ioeric added a subscriber: ilya-biryukov. ioeric added a comment. I mean `clangd-symbol-builder` Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51987 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

[PATCH] D51972: [RISCV] Explicitly set an empty --sysroot in the test

lewis-revill accepted this revision. lewis-revill added a comment. This revision is now accepted and ready to land. The reasoning seems sound for this testcase change. I think the behaviour of `computeSysRoot()` makes sense under this condition since it follows what the user specified, it's just

[PATCH] D51977: [clangd] Clarify and hide -index flag.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. +1 to making this hidden. Users (most of them) shouldn't care about it. Is there any motivation on why we someone would want to disable it currently? Maybe we want to deprecate it

[PATCH] D51971: [clangd] Use JSON format in benchmark requests reader

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp:21 +using clang::clangd::loadIndex; +using clang::clangd::SymbolIndex; We don't need the usings, just shorten the name on usage sites (usages are inside nam

[PATCH] D51989: [clangd] dexp tool uses llvm::cl to parse its flags.

sammccall created this revision. sammccall added a reviewer: kbobyrev. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. We can use cl::ResetCommandLineParser() to support different types of command-lines, as long as we're careful about option lif

[PATCH] D51986: Fixes for `LLVM_LINK_LLVM_DYLIB` && Polly.

DiamondLovesYou updated this revision to Diff 165090. DiamondLovesYou added a comment. - Fix cmake warning Repository: rC Clang https://reviews.llvm.org/D51986 Files: tools/driver/CMakeLists.txt Index: tools/driver/CMakeLists.txt ==

[libcxx] r342057 - Implement LWG #3017. list splice functions should use addressof

Author: marshall Date: Wed Sep 12 07:46:17 2018 New Revision: 342057 URL: http://llvm.org/viewvc/llvm-project?rev=342057&view=rev Log: Implement LWG #3017. list splice functions should use addressof Modified: libcxx/trunk/include/list libcxx/trunk/test/std/containers/sequences/list/list.o

[PATCH] D51987: [clangd] Rename global-symbol-builder to clangd-symbol-builder.

sammccall accepted this revision. sammccall added a comment. Much better. I think `clangd-indexer` might be **even** better, but up to you. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51987 ___ cfe-commits mailing list cfe-commit

[PATCH] D51987: [clangd] Rename global-symbol-builder to clangd-symbol-builder.

ilya-biryukov added a comment. `clangd-indexer` looks nice and short. @ioeric, WDYT? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51987 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[PATCH] D51972: [RISCV] Explicitly set an empty --sysroot in the test

rogfer01 added a comment. Thanks for the review! https://reviews.llvm.org/D51972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51488: [Sema][NFC] Small cleanup - remove dead code from ActOnCallExpr() ?

jkorous added a comment. I got some test failure with the patch, still investigating the issue. Repository: rC Clang https://reviews.llvm.org/D51488 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D51972: [RISCV] Explicitly set an empty --sysroot in the test

lewis-revill added a comment. @asb @kristina can we get this committed? https://reviews.llvm.org/D51972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51987: [clangd] Rename global-symbol-builder to clangd-symbol-builder.

ilya-biryukov updated this revision to Diff 165092. ilya-biryukov added a comment. - Rename to clangd-indexer Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51987 Files: clangd/CMakeLists.txt clangd/global-symbol-builder/CMakeLists.txt clangd/global-symbol-builder/GlobalS

[PATCH] D51987: [clangd] Rename global-symbol-builder to clangd-symbol-builder.

ioeric added a comment. In https://reviews.llvm.org/D51987#1231971, @ilya-biryukov wrote: > `clangd-indexer` looks nice and short. @ioeric, WDYT? You beat it to me, but I thought we didn't use `indexer` as it could be confused with the actual `indexing`? Repository: rCTE Clang Tools Extra

[PATCH] D51987: [clangd] Rename global-symbol-builder to clangd-symbol-builder.

ilya-biryukov added a comment. > You beat it to me, but I thought we didn't use indexer as it could be > confused with the actual indexing? Sorry. Not a big deal, can revert back if needed. Mostly like indexer since it's shorter. Also not very confusing, since we call the thing it produces an "

[PATCH] D51987: [clangd] Rename global-symbol-builder to clangd-symbol-builder.

kbobyrev added a comment. My 2 cents: `clangd-indexer` looks great! Typing 3-token tool name is always sad for me :( It's also easier to remember/understand in the first place. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51987 _

[PATCH] D51987: [clangd] Rename global-symbol-builder to clangd-symbol-builder.

ioeric added a comment. In https://reviews.llvm.org/D51987#1231990, @ilya-biryukov wrote: > > You beat it to me, but I thought we didn't use indexer as it could be > > confused with the actual indexing? > > Sorry. Not a big deal, can revert back if needed. > Mostly like indexer since it's short

[PATCH] D51990: [DebugInfo] Fix emitting of bit offset for ObjC

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, dexonsmith. We generate incorrect values for the DW_AT_data_bit_offset for interfaces in Objective-C. I can only speculate as to what we were trying to achieve by taking the modulo of the bit size with the byte size, but

[PATCH] D51725: Allow un-setting the compilation database path

simark added a comment. Not sure who should review this, please feel free to add anybody who would be appropriate. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51725 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://

[PATCH] D51972: [RISCV] Explicitly set an empty --sysroot in the test

rogfer01 added a comment. I can commit it. https://reviews.llvm.org/D51972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51972: [RISCV] Explicitly set an empty --sysroot in the test

lewis-revill added a comment. Great, go ahead. https://reviews.llvm.org/D51972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51972: [RISCV] Explicitly set an empty --sysroot in the test

rogfer01 added a comment. Thanks I will do it shortly. https://reviews.llvm.org/D51972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51340: [WIP] Add /Zc:DllexportInlines option to clang-cl

takuto.ikuta added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5244 + false)) +CmdArgs.push_back("-fvisibility-inlines-hidden"); + rnk wrote: > takuto.ikuta wrote: > > hans wrote: > > > takuto.ikuta wrote: > > > > hans

[PATCH] D51987: [clangd] Rename global-symbol-builder to clangd-symbol-builder.

sammccall added a comment. In https://reviews.llvm.org/D51987#1231993, @ioeric wrote: > In https://reviews.llvm.org/D51987#1231990, @ilya-biryukov wrote: > > > > You beat it to me, but I thought we didn't use indexer as it could be > > > confused with the actual indexing? > > > > Sorry. Not a bi

[PATCH] D51987: [clangd] Rename global-symbol-builder to clangd-symbol-builder.

ioeric accepted this revision. ioeric added a comment. In https://reviews.llvm.org/D51987#1232021, @sammccall wrote: > In https://reviews.llvm.org/D51987#1231993, @ioeric wrote: > > > In https://reviews.llvm.org/D51987#1231990, @ilya-biryukov wrote: > > > > > > You beat it to me, but I thought we

[PATCH] D51987: [clangd] Rename global-symbol-builder to clangd-symbol-builder.

ilya-biryukov added a comment. Thanks for the comments everyone! Will land this tomorrow, since I'm buildcop this week anyway. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51987 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D51990: [DebugInfo] Fix emitting of bit offset for ObjC

aprantl requested changes to this revision. aprantl added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2369 + ? CGM.getObjCRuntime().ComputeBitfieldBitOffset(CGM, ID, Field) + : 0; } e

[PATCH] D51990: [DebugInfo] Fix emitting of bit offset for ObjC

aprantl added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2369 + ? CGM.getObjCRuntime().ComputeBitfieldBitOffset(CGM, ID, Field) + : 0; } else { aprantl wrote: > It might help to attempt some git blame archeology.

r342060 - [RISCV] Explicitly set an empty --sysroot in the test

Author: rogfer01 Date: Wed Sep 12 08:55:14 2018 New Revision: 342060 URL: http://llvm.org/viewvc/llvm-project?rev=342060&view=rev Log: [RISCV] Explicitly set an empty --sysroot in the test In rL341655 we added additional behaviour to the Driver for riscv32-unknown-elf when the sysroot is empty.

[PATCH] D51972: [RISCV] Explicitly set an empty --sysroot in the test

This revision was automatically updated to reflect the committed changes. Closed by commit rC342060: [RISCV] Explicitly set an empty --sysroot in the test (authored by rogfer01, committed by ). Herald added a subscriber: jrtc27. Repository: rC Clang https://reviews.llvm.org/D51972 Files: te

[PATCH] D51971: [clangd] Use JSON format in benchmark requests reader

kbobyrev planned changes to this revision. kbobyrev marked an inline comment as done. kbobyrev added a comment. Apparently, the parsing seems to be wrong; I should fix that first. https://reviews.llvm.org/D51971 ___ cfe-commits mailing list cfe-comm

[PATCH] D51990: [DebugInfo] Fix emitting of bit offset for ObjC

JDevlieghere added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2369 + ? CGM.getObjCRuntime().ComputeBitfieldBitOffset(CGM, ID, Field) + : 0; } else { aprantl wrote: > aprantl wrote: > > It might help to attempt so

[PATCH] D51990: [DebugInfo] Fix emitting of bit offset for ObjC

JDevlieghere added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2369 + ? CGM.getObjCRuntime().ComputeBitfieldBitOffset(CGM, ID, Field) + : 0; } else { JDevlieghere wrote: > aprantl wrote: > > aprantl wrote: > > > I

[PATCH] D51725: Allow un-setting the compilation database path

ilya-biryukov added a comment. Wow, this is getting somewhat complicated. Have you considered rerunning clangd whenever someone changes an option like that? Would that be much more complicated on your side? Not opposed to having an option too, just want to be aware of the costs involved on you

[PATCH] D51971: [clangd] Use JSON format in benchmark requests reader

ilya-biryukov added a comment. In https://reviews.llvm.org/D51971#1232064, @kbobyrev wrote: > Apparently, the parsing seems to be wrong; I should fix that first. Oh, yeah, just use `llvm::json::parse` https://reviews.llvm.org/D51971 ___ cfe-commi

[PATCH] D51989: [clangd] dexp tool uses llvm::cl to parse its flags.

ilya-biryukov added a comment. A small drive-by comment. PS it'd be cool to have an interface to cl that does not rely on global state... Comment at: clangd/index/dex/dexp/Dexp.cpp:163 + +struct { + const char *Name; Maybe use a named struct? C++ is powerful,

[PATCH] D50901: [clang][ubsan] Split Implicit Integer Truncation Sanitizer into unsigned and signed checks

lebedev.ri added a comment. Ping once again :) Repository: rC Clang https://reviews.llvm.org/D50901 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50250: [clang][ubsan] Implicit Conversion Sanitizer - integer sign change - clang part

lebedev.ri added a comment. Ping once again :) Repository: rC Clang https://reviews.llvm.org/D50250 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r342062 - [OPENMP] Fix PR38902: support ADL for declare reduction constructs.

Author: abataev Date: Wed Sep 12 09:31:59 2018 New Revision: 342062 URL: http://llvm.org/viewvc/llvm-project?rev=342062&view=rev Log: [OPENMP] Fix PR38902: support ADL for declare reduction constructs. Added support for argument-dependent lookup when trying to find the required declare reduction

[PATCH] D51990: [DebugInfo] Fix emitting of bit offset for ObjC

aprantl added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2369 + ? CGM.getObjCRuntime().ComputeBitfieldBitOffset(CGM, ID, Field) + : 0; } else { JDevlieghere wrote: > JDevlieghere wrote: > > aprantl wrote: > > > a

[libcxx] r342063 - Update the failure annotations for the uncaught_exceptions test. The underlying abi library on some Mac OS versions does not support the plural uncaught_exceptions, so libc++ emulat

Author: marshall Date: Wed Sep 12 09:59:09 2018 New Revision: 342063 URL: http://llvm.org/viewvc/llvm-project?rev=342063&view=rev Log: Update the failure annotations for the uncaught_exceptions test. The underlying abi library on some Mac OS versions does not support the plural uncaught_exceptio

[PATCH] D51971: [clangd] Use JSON format in benchmark requests reader

kbobyrev updated this revision to Diff 165110. kbobyrev marked an inline comment as done. kbobyrev added a comment. @ilya-biryukov thanks! I was assuming that the `StringRef` constructor parses user-provided string :( `llvm::json::Array` is used now. https://reviews.llvm.org/D51971 Files: c

[PATCH] D51955: Create infrastructure for defining and testing feature test macros

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. Thanks! I don't like feature test macros either, but we should still strive for conformance. https://reviews.llvm.org/D51955 ___ cfe-commits m

[PATCH] D51725: Allow un-setting the compilation database path

simark added a comment. In https://reviews.llvm.org/D51725#1232092, @ilya-biryukov wrote: > Wow, this is getting somewhat complicated. > > Have you considered rerunning clangd whenever someone changes an option like > that? > Would that be much more complicated on your side? > > Not opposed to

[PATCH] D48896: [libcxx][c++17] P0083R5: Splicing Maps and Sets Part 2: merge

erik.pilkington added a comment. Ping! https://reviews.llvm.org/D48896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51949: [WIP][clang-tidy] initial ideas to isolate variable declarations

JonasToth added inline comments. Comment at: clang-tidy/readability/IsolateDeclCheck.cpp:35 + + std::string TypeAndName = + VarType.getAsString(TypePrinter) + " " + D->getNameAsString(); kbobyrev wrote: > `llvm::Twine` here? Seems like this one is used a lo

[PATCH] D51729: [Tooling] JSONCompilationDatabasePlugin infers compile commands for missing files

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. I like it Repository: rC Clang https://reviews.llvm.org/D51729 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

[PATCH] D50359: Add a new library, libclang-cxx

pirama updated this revision to Diff 165118. pirama added a comment. Herald added a subscriber: fedor.sergeev. Add empty source file to silence CMake warning. Support more platforms, similar to libLLVM.so Repository: rC Clang https://reviews.llvm.org/D50359 Files: CMakeLists.txt tools/CM

[PATCH] D51996: [clangd] Simplify cancellation public API

sammccall created this revision. sammccall added reviewers: ilya-biryukov, kadircet. Herald added subscribers: cfe-commits, jfb, arphaman, jkorous, MaskRay, ioeric. Task is no longer exposed: - task cancellation is hidden as a std::function - task creation returns the new context directly - check

[PATCH] D51997: [clang] Make sure attributes on member classes are applied properly

ldionne created this revision. ldionne added a reviewer: rsmith. Herald added subscribers: cfe-commits, dexonsmith. Attributes on member classes of class templates (and other similar entities) are not currently instantiated. This was discovered by Richard Smith here: http://lists.llvm.org/piper

[PATCH] D51921: [VFS] vfs::directory_iterator yields path and file type instead of full Status

bkramer added inline comments. Comment at: include/clang/Basic/VirtualFileSystem.h:135 + // For compatibility with old Status-based API. Prefer using Path directly. + StringRef getName() const { return Path; } +}; sammccall wrote: > Backwards-compatibility note

[PATCH] D50359: Add a new library, libclang-cxx

pirama added a comment. As I mentioned in the discussion, we decided to carry build rules for the proposed library in downstream. I've updated this to make it more general, and will leave it open in case there's more interest to revive it in the future. Repository: rC Clang https://reviews

[PATCH] D51996: [clangd] Simplify cancellation public API

sammccall updated this revision to Diff 165125. sammccall added a comment. Fix includes, formatting tweak. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51996 Files: clangd/Cancellation.cpp clangd/Cancellation.h clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h cla

[PATCH] D50359: Add a new library, libclang-cxx

lebedev.ri added a comment. > The motivation for this library is to > be used by Clang tools that use Clang's C++ api. They no longer need to > link against the individual static libraries. I would personally consider that to be a regression. It hides layering violations. Of course, in downstre

[PATCH] D51997: [clang] Make sure attributes on member classes are applied properly

ldionne added a comment. This patch is missing support for partial specializations and explicit specializations. The part I don't understand is how to get the `CXXRecordDecl`s to have the right attribute below. Here's the AST dump for the test file with the current patch: TranslationUnitDecl

r342068 - [Diagnostic] Fix a warning typo. NFC.

Author: mattd Date: Wed Sep 12 11:27:21 2018 New Revision: 342068 URL: http://llvm.org/viewvc/llvm-project?rev=342068&view=rev Log: [Diagnostic] Fix a warning typo. NFC. s/aligment/alignment/ Modified: cfe/trunk/docs/DiagnosticsReference.rst cfe/trunk/include/clang/Basic/DiagnosticSemaK

[PATCH] D50359: Add a new library, libclang-cxx

kristina added a comment. I'm in support as long as it's a configuration option defaulting similar to LLVM's one. Should likely follow the same naming convention as LLVM, ie. `clang-shlib`. Clang has a lot of tools it ships with especially if you consider extras, I think this is one of the case

[libcxx] r342070 - mark LWG#2953 as complete. No code changes required, but added a couple of extra tests.

Author: marshall Date: Wed Sep 12 11:51:12 2018 New Revision: 342070 URL: http://llvm.org/viewvc/llvm-project?rev=342070&view=rev Log: mark LWG#2953 as complete. No code changes required, but added a couple of extra tests. Modified: libcxx/trunk/test/std/containers/sequences/deque/deque.mod

[libcxx] r342071 - Actually mark LWG#2953, don't just say you've done so in r342070

Author: marshall Date: Wed Sep 12 11:53:02 2018 New Revision: 342071 URL: http://llvm.org/viewvc/llvm-project?rev=342071&view=rev Log: Actually mark LWG#2953, don't just say you've done so in r342070 Modified: libcxx/trunk/www/cxx2a_status.html Modified: libcxx/trunk/www/cxx2a_status.html UR

[PATCH] D51921: [VFS] vfs::directory_iterator yields path and file type instead of full Status

sammccall added inline comments. Comment at: include/clang/Basic/VirtualFileSystem.h:135 + // For compatibility with old Status-based API. Prefer using Path directly. + StringRef getName() const { return Path; } +}; bkramer wrote: > sammccall wrote: > > Backwar

[PATCH] D51986: Fixes for `LLVM_LINK_LLVM_DYLIB` && Polly.

beanz added a comment. I don’t think this is the right solution. The build system knows what components are in the dylib and should remove them from the list of libraries linked individually. You should be able to make Polly behave like an LLVM component, then tools don’t need to care if the dy

[PATCH] D51657: [CMake] Link to compiler-rt if LIBUNWIND_USE_COMPILER_RT is ON.

cdavis5x added a comment. Ping. Repository: rUNW libunwind https://reviews.llvm.org/D51657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   >