[PATCH] D51402: [OpenCL] Adding cl_intel_planar_yuv extension

sidorovd created this revision. sidorovd added reviewers: yaxunl, Anastasia. Herald added a subscriber: cfe-commits. Just adding a preprocessor #define for the extension. Patch by Alexey Sotkin Repository: rC Clang https://reviews.llvm.org/D51402 Files: include/clang/Basic/OpenCLExtension

[PATCH] D48714: [clang-tidy] fix PR37913, templated exception factory diagnosed correctly

JonasToth added a comment. In https://reviews.llvm.org/D48714#1216989, @lebedev.ri wrote: > In https://reviews.llvm.org/D48714#1216537, @JonasToth wrote: > > > I had to revert the `CHECK-NOTES` change that @lebedev.ri introduced with > > his revision. It fails the test, i think there is an incon

[PATCH] D51381: [clang-tidy] fix check_clang_tidy to properly mix CHECK-NOTES and CHECK-MESSAGES

JonasToth added a comment. @lebedev.ri lets do it in the the other patch, to not split discussions. But what do you mean by `You would still have to duplicate the check-lines for error: though.`? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51381 _

[PATCH] D51221: [clangd] Some nitpicking around the new split (preamble/main) dynamic index

sammccall updated this revision to Diff 163023. sammccall added a comment. (forgot some changes) Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51221 Files: clangd/ClangdServer.cpp clangd/ClangdServer.h clangd/ClangdUnit.cpp clangd/ClangdUnit.h clangd/TUScheduler.cpp

[PATCH] D51358: [driver] Do not pass "-flavor old-gnu" option to LLD linker

atanasyan closed this revision. atanasyan added a comment. Fixed by https://reviews.llvm.org/rL340845. Repository: rC Clang https://reviews.llvm.org/D51358 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

[PATCH] D51310: [clangd] Implement iterator cost

kbobyrev updated this revision to Diff 163024. kbobyrev marked 6 inline comments as done. This revision is now accepted and ready to land. https://reviews.llvm.org/D51310 Files: clang-tools-extra/clangd/index/dex/Iterator.cpp clang-tools-extra/clangd/index/dex/Iterator.h clang-tools-extra/u

[PATCH] D51310: [clangd] Implement iterator cost

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/dex/Iterator.cpp:93 + const std::unique_ptr &RHS) { +return LHS->cost() < RHS->cost(); + }); sammccall wrote: > (I'd actually suggest declaring

[PATCH] D51292: [docs] Update clang-rename documentation

kbobyrev updated this revision to Diff 163025. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Moved the note about Clangd integration to the end, rephrased a bit. https://reviews.llvm.org/D51292 Files: clang-tools-extra/docs/clang-rename.rst Index: clang-tools-extra/do

[PATCH] D51407: [Tooling] Do not restore working dir in ClangTool

ilya-biryukov created this revision. ilya-biryukov added reviewers: ioeric, sammccall. Resolve all relative paths before running the tool instead. This fixes the usage of ClangTool in AllTUsExecutor. The executor will try running multiple ClangTool instances in parallel with compile commands that

[PATCH] D51407: [Tooling] Do not restore working dir in ClangTool

ioeric added inline comments. Comment at: lib/Tooling/Tooling.cpp:419 - } else { -llvm::report_fatal_error("Cannot detect current path: " + - Twine(CWD.getError().message())); Should we still check if `CWD` is correctly set? Rep

[PATCH] D51382: [MinGW] Don't mark external variables as DSO local

mstorsjo added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:737 +// potentially could come from another DLL as DSO local. +if (GV->hasExternalLinkage() && GV->isDeclaration() && +isa(GV) && !GV->isThreadLocal()) rnk wrote: > I think

[PATCH] D51382: [MinGW] Don't mark external variables as DSO local

mstorsjo updated this revision to Diff 163033. mstorsjo added a comment. Changed the condition to GV->isDeclarationForLinker(), updated tests accordingly (weak_bar in CodeGen/dso-local-executable.c lost the dso_local flag) and added more tests in CodeGenCXX/dso-local-executable.cpp as requested.

[PATCH] D51212: [OpenCL][Docs] Release notes for OpenCL in Clang

This revision was automatically updated to reflect the committed changes. Closed by commit rL340910: [Docs] Release notes for OpenCL (authored by stulova, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51212?vs=162362&id=163034#toc R

[PATCH] D51407: [Tooling] Do not restore working dir in ClangTool

ilya-biryukov added inline comments. Comment at: lib/Tooling/Tooling.cpp:419 - } else { -llvm::report_fatal_error("Cannot detect current path: " + - Twine(CWD.getError().message())); ioeric wrote: > Should we still check if `CWD`

r340911 - [ARM] Set __ARM_FEATURE_SIMD32 for +dsp cores

Author: sam_parker Date: Wed Aug 29 03:39:03 2018 New Revision: 340911 URL: http://llvm.org/viewvc/llvm-project?rev=340911&view=rev Log: [ARM] Set __ARM_FEATURE_SIMD32 for +dsp cores ARM_FEATURE_DSP is already set for targets with the +dsp feature. In the backend, this target feature is also used

[PATCH] D51093: [ARM] Set __ARM_FEATURE_SIMD32 for +dsp cores

This revision was automatically updated to reflect the committed changes. Closed by commit rL340911: [ARM] Set __ARM_FEATURE_SIMD32 for +dsp cores (authored by sam_parker, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51093?vs=161925

[PATCH] D51407: [Tooling] Do not restore working dir in ClangTool

ioeric added inline comments. Comment at: lib/Tooling/Tooling.cpp:419 - } else { -llvm::report_fatal_error("Cannot detect current path: " + - Twine(CWD.getError().message())); ilya-biryukov wrote: > ioeric wrote: > > Should we sti

[PATCH] D51331: [OPENMP] Create non-const ident_t structs.

AndreyChurbanov added a comment. In https://reviews.llvm.org/D51331#1216509, @ABataev wrote: > When is ITT Notify used? Does it have some preconditions like debug info, > some optimizations level etc.? The libittnotify library is used by Intel tools (VTune Amplifier, Inspector, Spatial Adviso

[PATCH] D51411: [OpenCL] Improve diagnostic of argument in address space conversion builtins

AlistairD created this revision. AlistairD added a reviewer: yaxunl. This change adds a warning if a parameter is passed with named address space to parameter that is in generic address space. For example: int i; to_private(&i); //generate warning as conversion from private to private is r

[clang-tools-extra] r340915 - Introduce the abseil-str-cat-append check.

Author: aaronballman Date: Wed Aug 29 04:17:31 2018 New Revision: 340915 URL: http://llvm.org/viewvc/llvm-project?rev=340915&view=rev Log: Introduce the abseil-str-cat-append check. This flags uses of absl::StrCat when absl::StrAppend should be used instead. Patch by Hugo Gonzalez and Benjamin K

[PATCH] D51061: [clang-tidy] abseil-str-cat-append

aaron.ballman added a comment. In https://reviews.llvm.org/D51061#1215917, @hugoeg wrote: > @aaron.ballman when you get the chance could you take another look at this > and commit if it is ready? My internship ends rather soon and this is a tad > time sensitive and I don't have commit access. T

[PATCH] D51300: [analyzer][UninitializedObjectChecker] No longer using nonloc::LazyCompoundVal

Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObjectChecker.cpp:448-449 Loc ThisLoc = Context.getSValBuilder().getCXXThis(CtorDecl->getParent(), Context.getStack

[clang-tools-extra] r340918 - Introduce the abseil-redundant-strcat-calls check.

Author: aaronballman Date: Wed Aug 29 04:29:07 2018 New Revision: 340918 URL: http://llvm.org/viewvc/llvm-project?rev=340918&view=rev Log: Introduce the abseil-redundant-strcat-calls check. This flags redundant calls to absl::StrCat where the result is being passed to another call to absl::StrCa

[PATCH] D51132: [clang-tidy] abseil-redundant-strcat-calls-check

aaron.ballman closed this revision. aaron.ballman added a comment. I've commit in r340918. Thank you for the patch! https://reviews.llvm.org/D51132 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM with a nit, thanks for your work. Comment at: clang-tidy/abseil/NoInternalDependenciesCheck.h:20 +/// Finds instances where the user depends on internal details and warn

[PATCH] D51311: (WIP) Type hierarchy

ilya-biryukov added a subscriber: sammccall. ilya-biryukov added inline comments. Comment at: clangd/XRefs.cpp:669 + const CXXMethodDecl *Candidate) { + // FIXME: How do I determine if Method overrides Candidate? + kadircet wrote: > ilya

[PATCH] D51380: Fix incorrect usage of std::error_category

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D51380 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D51380: Fix incorrect usage of std::error_category

aganea added a comment. Thank you! Repository: rC Clang https://reviews.llvm.org/D51380 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51416: [RTTI] Align rtti type string to prevent over-alignment

dmgreen created this revision. dmgreen added reviewers: efriedma, echristo, hfinkel, davide. Previously the alignment on the newly created rtti string was not set, meaning that DataLayout::getPreferredAlignment was free to overalign it to 16 bytes. This causes unnecessary code bloat. https://rev

[PATCH] D49916: [CodeGen] Add to emitted DebugLoc information about coverage when it's required

calixte updated this revision to Diff 163062. calixte added a comment. - Use ImplicitCode instead of Covered - Set Artificial location as ImplicitCode to avoid coverage on landing pads Repository: rC Clang https://reviews.llvm.org/D49916 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGD

[PATCH] D51221: [clangd] Some nitpicking around the new split (preamble/main) dynamic index

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Comment at: clangd/ClangdServer.cpp:122 + // - symbols declared both in the main file and the preamble + // (Note that symbols *only* in the main file a

[PATCH] D51417: [analyzer][UninitializedObjectChecker] Updated comments

Szelethus created this revision. Szelethus added reviewers: NoQ, george.karpenkov, xazax.hun, rnkovacs. Herald added subscribers: cfe-commits, mikhail.ramalho, a.sidorin, szepet, whisperity. Some of the comments are incorrect, imprecise, or simply nonexistent. Since I have a better grasp on how

[PATCH] D51279: [clangd] Implement findOccurrences interface in dynamic index.

hokein updated this revision to Diff 163064. hokein marked 16 inline comments as done. hokein added a comment. Herald added a subscriber: mgrang. Address review comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51279 Files: clangd/index/FileIndex.cpp clangd/index/Fil

[PATCH] D51279: [clangd] Implement findOccurrences interface in dynamic index.

hokein updated this revision to Diff 163066. hokein added a comment. Minor cleanup. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51279 Files: clangd/index/FileIndex.cpp clangd/index/FileIndex.h clangd/index/Index.cpp clangd/index/Index.h clangd/index/MemIndex.cpp

[PATCH] D51279: [clangd] Implement findOccurrences interface in dynamic index.

hokein added a comment. Thanks for the comments. Comment at: clangd/index/FileIndex.cpp:48 + if (TopLevelDecls) { // index main AST, set occurrence flag. +CollectorOpts.OccurrenceFilter = SymbolOccurrenceKind::Declaration | ilya-biryukov wrote: > There i

[PATCH] D51417: [analyzer][UninitializedObjectChecker] Updated comments

Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObjectChecker.cpp:377-397 -// TODO: This function constructs an incorrect string if a void pointer is a -// part of the chain: -// -// struct B { int x; } -// -// struct

[PATCH] D51360: [clang-tidy] Use simple string matching instead of Regex

hokein added a comment. Thanks very much for improving it! Comment at: clang-tools-extra/clang-tidy/abseil/AbseilMatcher.h:45 - llvm::Regex RE( - "absl/(algorithm|base|container|debugging|memory|meta|numeric|strings|" - "synchronization|time|types|utility)"); ---

[PATCH] D51331: [OPENMP] Create non-const ident_t structs.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D51331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D51407: [Tooling] Do not restore working dir in ClangTool

ilya-biryukov updated this revision to Diff 163071. ilya-biryukov added a comment. - Use vfs for file accesses - Report errors when getAbsolutePath fails, skip those files Repository: rC Clang https://reviews.llvm.org/D51407 Files: lib/Tooling/Tooling.cpp Index: lib/Tooling/Tooling.cpp =

[PATCH] D51407: [Tooling] Do not restore working dir in ClangTool

ilya-biryukov added inline comments. Comment at: lib/Tooling/Tooling.cpp:419 - } else { -llvm::report_fatal_error("Cannot detect current path: " + - Twine(CWD.getError().message())); ioeric wrote: > ilya-biryukov wrote: > > ioeric

[PATCH] D51380: Fix incorrect usage of std::error_category

ilya-biryukov added a comment. Thanks for fixing this. Repository: rC Clang https://reviews.llvm.org/D51380 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51279: [clangd] Implement findOccurrences interface in dynamic index.

ilya-biryukov added inline comments. Comment at: clangd/index/FileIndex.cpp:48 + if (TopLevelDecls) { // index main AST, set occurrence flag. +CollectorOpts.OccurrenceFilter = SymbolOccurrenceKind::Declaration | hokein wrote: > ilya-biryukov wrote: > > The

[PATCH] D51422: [clangd] Factor out the data-swapping functionality from MemIndex/DexIndex.

sammccall created this revision. sammccall added a reviewer: kbobyrev. Herald added subscribers: cfe-commits, kadircet, arphaman, mgrang, jkorous, MaskRay, ioeric, ilya-biryukov. This is now handled by a wrapper class SwapIndex, so MemIndex/DexIndex can be immutable and focus on their job. Old a

[PATCH] D51291: [clangd] Support multiple #include headers in one symbol.

ioeric updated this revision to Diff 163074. ioeric added a comment. - minor cleanup Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51291 Files: clangd/CodeComplete.cpp clangd/index/Index.cpp clangd/index/Index.h clangd/index/Merge.cpp clangd/index/SymbolCollector.cpp

[PATCH] D51341: [HEADER] Overloadable function candidates for half/double types

Anastasia added inline comments. Comment at: lib/Sema/SemaOverload.cpp:6063 + // OpenCL: A candidate function that uses extentions that are not enabled or + // supported is not viable. + if (getLangOpts().OpenCL) { I would imagine if extension isn't supported

[PATCH] D51341: [HEADER] Overloadable function candidates for half/double types

Anastasia added a comment. I think this is related to: https://reviews.llvm.org/D46501 https://reviews.llvm.org/D51341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51411: [OpenCL] Improve diagnostic of argument in address space conversion builtins

yaxunl added a comment. Is this a feature requested by users? I can understand that this may be useful to pinpoint some conversions which are potentially harmful to performance. However such conversions can often be eliminated by optimization, which makes this warning less useful. On the other

[PATCH] D51402: [OpenCL] Adding cl_intel_planar_yuv extension

Anastasia added a comment. Will this extension require any Clang changes that are not possible to add using this approach for vendor extensions: https://clang.llvm.org/docs/UsersManual.html#opencl-extensions If not I would suggest to add this to the header file instead. Repository: rC Clang

[PATCH] D51411: [OpenCL] Improve diagnostic of argument in address space conversion builtins

yaxunl added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8584 + "passing non-generic address space pointer to %0" + " generates dynamic conversion where it is not needed">; How about change this to: may cause dynamic conversion af

[PATCH] D51292: [docs] Update clang-rename documentation

ilya-biryukov added a comment. Leaving some comments, but also suggest getting the final LGTM from the owner of the doc (@ioeric?) Comment at: clang-tools-extra/docs/clang-rename.rst:141 +:program:`clangd `_ uses +:program:`clang-renam

[PATCH] D43783: [OpenCL] Remove block invoke function from emitted block literal struct

yaxunl added a comment. In https://reviews.llvm.org/D43783#1215573, @Anastasia wrote: > In https://reviews.llvm.org/D43783#1212485, @yaxunl wrote: > > > In https://reviews.llvm.org/D43783#1204353, @svenvh wrote: > > > > > Sorry for digging up an old commit... > > > > > > Apparently this broke blo

[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check

hugoeg updated this revision to Diff 163083. hugoeg marked an inline comment as done. hugoeg added a comment. nit comment fixed https://reviews.llvm.org/D50542 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/NoInternalDependenciesCheck.cpp

[PATCH] D49244: Always search sysroot for GCC installs

greened added a comment. I agree that option 2 seems best. It's consistent with options overriding more general configuration/environment variables and more specific options overriding more general options. If it turns out option 1 is needed in the future, it should be a simple change given a

[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check

JonasToth added a comment. In https://reviews.llvm.org/D50542#1217511, @hugoeg wrote: > nit comment fixed DO you have commit rights or shall i commit for you? https://reviews.llvm.org/D50542 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check

hugoeg added a comment. In https://reviews.llvm.org/D50542#1217515, @JonasToth wrote: > In https://reviews.llvm.org/D50542#1217511, @hugoeg wrote: > > > nit comment fixed > > > DO you have commit rights or shall i commit for you? I do not have commit rights so I would appreciate it if you would

[clang-tools-extra] r340928 - [clang-tidy] Add abseil-no-internal-dependencies check

Author: jonastoth Date: Wed Aug 29 07:23:15 2018 New Revision: 340928 URL: http://llvm.org/viewvc/llvm-project?rev=340928&view=rev Log: [clang-tidy] Add abseil-no-internal-dependencies check Finds instances where the user depends on internal details and warns them against doing so. Should not be

[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check

JonasToth added a comment. Committed r340928. Thanks very much! Will you (and your team) upstream even more abseil checks? I think it might be reasonable to ask for commit rights. https://reviews.llvm.org/D50542 ___ cfe-commits mailing list cfe-co

[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check

This revision was automatically updated to reflect the committed changes. Closed by commit rL340928: [clang-tidy] Add abseil-no-internal-dependencies check (authored by JonasToth, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D50542?v

[PATCH] D51426: [Sema] Prohibit function-scope compound literals with address spaces.

ebevhan created this revision. ebevhan added reviewers: efriedma, rjmccall. Herald added a subscriber: cfe-commits. In C, compound literals in function scope are lvalues with automatic storage duration. This means that generally, they cannot be address space-qualified since you cannot have address

[PATCH] D51302: [OpenCL] Relax diagnostics on OpenCL access qualifiers

AlexeySachkov updated this revision to Diff 163086. AlexeySachkov added a comment. Applied comment from Anastasia https://reviews.llvm.org/D51302 Files: lib/Sema/SemaDeclAttr.cpp lib/Sema/SemaType.cpp test/SemaOpenCL/access-qualifier.cl Index: lib/Sema/SemaType.cpp ==

[PATCH] D51380: Fix incorrect usage of std::error_category

This revision was automatically updated to reflect the committed changes. Closed by commit rC340929: [Preamble] Fix incorrect usage of std::error_category (authored by aganea, committed by ). Repository: rC Clang https://reviews.llvm.org/D51380 Files: lib/Frontend/PrecompiledPreamble.cpp

[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check

hugoeg added a comment. In https://reviews.llvm.org/D50542#1217517, @JonasToth wrote: > Committed r340928. Thanks very much! > > Will you (and your team) upstream even more abseil checks? I think it might > be reasonable to ask for commit rights. We will likely not be up streaming more in the

[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check

JonasToth added a comment. Ok. Then we can commit for you guys, no problem :) Am 29.08.2018 um 16:34 schrieb Hugo Gonzalez via Phabricator: > hugoeg added a comment. > > In https://reviews.llvm.org/D50542#1217517, @JonasToth wrote: > >> Committed r340928. Thanks very much! >> >> Will you (and

r340929 - [Preamble] Fix incorrect usage of std::error_category

Author: aganea Date: Wed Aug 29 07:28:04 2018 New Revision: 340929 URL: http://llvm.org/viewvc/llvm-project?rev=340929&view=rev Log: [Preamble] Fix incorrect usage of std::error_category Differential Revision: https://reviews.llvm.org/D51380 Modified: cfe/trunk/lib/Frontend/PrecompiledPreamb

[PATCH] D51292: [docs] Update clang-rename documentation

ioeric added inline comments. Comment at: clang-tools-extra/docs/clang-rename.rst:140 + +:program:`clangd `_ uses +:program:`clang-rename` infrastructure to handle renaming requests. Currently, nit: `clangd *shares* the r

[PATCH] D51311: (WIP) Type hierarchy

simark added inline comments. Comment at: clangd/Protocol.h:891 + + std::vector Parents; + ilya-biryukov wrote: > What is the proposal to add children (i.e. overriden methods) to the > hierarchy? > This seems like a place where we might want to have multiple re

[PATCH] D51407: [Tooling] Do not restore working dir in ClangTool

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. lg Comment at: lib/Tooling/Tooling.cpp:202 -std::string getAbsolutePath(StringRef File) { +static llvm::Expected getAbsolutePath(vfs::FileSystem &FS, +

[PATCH] D51429: [AArch64] Return Address Signing B Key Support

LukeCheeseman created this revision. LukeCheeseman added reviewers: kcc, pcc, eugenis, vlad.tsyrklevich. Herald added a reviewer: javed.absar. Herald added subscribers: cfe-commits, kristof.beyls. - Add command line options for selecting the B key when enabling return address signing (also tidy u

[PATCH] D51321: [Tooling] Improve handling of CL-style options

hamzasood updated this revision to Diff 163098. hamzasood added a comment. I've addressed most of your comments and resolved the merge conflicts introduced in r340838. https://reviews.llvm.org/D51321 Files: lib/Tooling/InterpolatingCompilationDatabase.cpp unittests/Tooling/CompilationDatab

[PATCH] D51321: [Tooling] Improve handling of CL-style options

hamzasood marked 10 inline comments as done. hamzasood added inline comments. Comment at: lib/Tooling/InterpolatingCompilationDatabase.cpp:124 +// Determine whether the given file path is the clang-cl executable. +static bool checkIsCLMode(const std::vector &CmdLine, +

[PATCH] D51382: [MinGW] Don't mark external variables as DSO local

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: test/CodeGen/dso-local-executable.c:14 +// MINGW-DAG: @bar = external global i32 +// MINGW-DAG: @weak_bar = extern_weak global i32 +// MINGW-DAG: declare dso_local

[PATCH] D51393: Provide a method for generating deterministic IDs for pointers allocated in BumpPtrAllocator

aprantl added inline comments. Comment at: llvm/include/llvm/Support/Allocator.h:292 +const char *P = reinterpret_cast(Ptr); +for (size_t Idx=0; Idx < Slabs.size(); Idx++) { + const char *S = reinterpret_cast(Slabs[Idx]); clang-format?

[PATCH] D51393: Provide a method for generating deterministic IDs for pointers allocated in BumpPtrAllocator

aprantl added a comment. Just for consideration: The raw pointers in dumps are sometimes useful while in a debugger session, because you can cast a pointer and dump the object in the debugger. https://reviews.llvm.org/D51393 ___ cfe-commits mailin

[PATCH] D51432: [AArch64] Unwinding support for return address signing

LukeCheeseman created this revision. LukeCheeseman added reviewers: pcc, kcc, eugenis, vlad.tsyrklevich. Herald added a reviewer: javed.absar. Herald added subscribers: cfe-commits, chrib, JDevlieghere, kristof.beyls. - When return address signing is enabled, the LR may be signed on function entry

[PATCH] D51331: [OPENMP] Create non-const ident_t structs.

This revision was automatically updated to reflect the committed changes. Closed by commit rC340934: [OPENMP] Create non-const ident_t objects. (authored by mikerice, committed by ). Repository: rC Clang https://reviews.llvm.org/D51331 Files: lib/CodeGen/CGOpenMPRuntime.cpp test/OpenMP/di

r340934 - [OPENMP] Create non-const ident_t objects.

Author: mikerice Date: Wed Aug 29 08:45:11 2018 New Revision: 340934 URL: http://llvm.org/viewvc/llvm-project?rev=340934&view=rev Log: [OPENMP] Create non-const ident_t objects. Currently ident_t objects are created const when debug info is not enabled, but the libittnotify libray in the OpenMP r

[PATCH] D51331: [OPENMP] Create non-const ident_t structs.

This revision was automatically updated to reflect the committed changes. Closed by commit rL340934: [OPENMP] Create non-const ident_t objects. (authored by mikerice, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51331?vs=162776&id=1

[PATCH] D51434: [HIP] Add -amdgpu-internalize-symbols option to opt

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added subscribers: t-tye, tpr, dstuttard, wdng, kzhuravl. AMDGPU backend needs -amdgpu-internalize-symbols option for opt to work around a limitation of no PLT support, otherwise there is compilation error at -O0. https://reviews

[PATCH] D51382: [MinGW] Don't mark external variables as DSO local

mstorsjo added inline comments. Comment at: test/CodeGen/dso-local-executable.c:14 +// MINGW-DAG: @bar = external global i32 +// MINGW-DAG: @weak_bar = extern_weak global i32 +// MINGW-DAG: declare dso_local void @foo() rnk wrote: > I take it that was a side effe

[PATCH] D51436: [CodeComplete] Report location of opening parens for signature help

ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added subscribers: kadircet, ioeric. Used in clangd. Repository: rC Clang https://reviews.llvm.org/D51436 Files: include/clang/Sema/CodeCompleteConsumer.h include/clang/Sema/Sema.h lib/Frontend/ASTUn

[PATCH] D51437: [clangd] Report position of opening paren in singature help

ilya-biryukov updated this revision to Diff 163116. ilya-biryukov added a comment. - Format the code Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51437 Files: clangd/CodeComplete.cpp clangd/Protocol.h unittests/clangd/CodeCompleteTests.cpp Index: unittests/clangd/CodeC

[PATCH] D51437: [clangd] Report position of opening paren in singature help

ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric. ilya-biryukov added a dependency: D51436: [CodeComplete] Report location of opening parens for signature help. ilya-biryukov updated this revision

[PATCH] D51438: [clangd] Run SignatureHelp using an up-to-date preamble, waiting if needed.

sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ioeric, javed.absar. After code completion inserts a header, running signature help using the old preamble will usually fail. So we add support

[PATCH] D51438: [clangd] Run SignatureHelp using an up-to-date preamble, waiting if needed.

sammccall added a comment. (This needs new TUScheduler tests for `Consistent` mode, but would like some feedback on the implementation first) Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51438 ___ cfe-commits mailing list cfe-com

[PATCH] D51438: [clangd] Run SignatureHelp using an up-to-date preamble, waiting if needed.

sammccall updated this revision to Diff 163121. sammccall added a comment. Finish a sentence Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51438 Files: clangd/ClangdServer.cpp clangd/TUScheduler.cpp clangd/TUScheduler.h unittests/clangd/TUSchedulerTests.cpp Index: uni

[PATCH] D51407: [Tooling] Do not restore working dir in ClangTool

ilya-biryukov updated this revision to Diff 163122. ilya-biryukov added a comment. - Expose getAbsolutePath in the public API Repository: rC Clang https://reviews.llvm.org/D51407 Files: include/clang/Tooling/Tooling.h lib/Tooling/Tooling.cpp Index: lib/Tooling/Tooling.cpp ==

r340937 - [Tooling] Do not restore working dir in ClangTool

Author: ibiryukov Date: Wed Aug 29 09:35:31 2018 New Revision: 340937 URL: http://llvm.org/viewvc/llvm-project?rev=340937&view=rev Log: [Tooling] Do not restore working dir in ClangTool Summary: Resolve all relative paths before running the tool instead. This fixes the usage of ClangTool in AllT

[PATCH] D51407: [Tooling] Do not restore working dir in ClangTool

This revision was automatically updated to reflect the committed changes. Closed by commit rL340937: [Tooling] Do not restore working dir in ClangTool (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D51407 Files:

[PATCH] D51407: [Tooling] Do not restore working dir in ClangTool

This revision was automatically updated to reflect the committed changes. Closed by commit rC340937: [Tooling] Do not restore working dir in ClangTool (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D51407?vs=163122&id=163127#toc Repository: rC Clang

[PATCH] D51084: Implement -Watomic-implicit-seq-cst

jfb added a comment. In https://reviews.llvm.org/D51084#1216913, @rjmccall wrote: > It says the type of the assignment expression, not the type of the LHS. > > C11 [6.5.16]p2: "The type of an assignment expression is the type the left > operand would have after lvalue conversion." > > C11 [6.3.2

[PATCH] D51434: [HIP] Add -amdgpu-internalize-symbols option to opt

tra added a comment. Could you elaborate on what exactly is the problem this patch fixes? I don't see how internalizing the symbols connects to PLTs. My understanding is that PLTs are used to provide stubs for symbols to be resolved by dynamic linker at runtime. AFAICT AMD does not use shared li

[PATCH] D51359: Adding HardLink Support to VirtualFileSystem.

usaxena95 updated this revision to Diff 163128. usaxena95 added a comment. Created InMemoryHardLink Class which can handle the resolved InMemoryFile Repository: rC Clang https://reviews.llvm.org/D51359 Files: include/clang/Basic/VirtualFileSystem.h lib/Basic/VirtualFileSystem.cpp uni

[PATCH] D51426: [Sema] Prohibit function-scope compound literals with address spaces.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM, with one minor suggestion. Comment at: lib/Sema/SemaExpr.cpp:5745 +// C99 6.5.2.5p6: Function scope compound literals must have automatic +// storage which

[PATCH] D51440: [ToolChains] Link to compiler-rt with -L + -l when possible

mstorsjo created this revision. mstorsjo added reviewers: manojgupta, chandlerc, beanz. Herald added subscribers: aheejin, sbc100, dberris, srhines. Herald added a reviewer: javed.absar. This avoids a libtool issue (https://debbugs.gnu.org/cgi/bugreport.cgi?bug=27866), where libtool fails to pic

[PATCH] D51359: Adding HardLink Support to VirtualFileSystem.

usaxena95 marked 8 inline comments as done. usaxena95 added a comment. Applied the suggested changes. Added InMemoryHardLink as a subclass of InMemoryNode. Modified the tests accordingly. Repository: rC Clang https://reviews.llvm.org/D51359 ___

[PATCH] D51441: Add predefined macro __gnu_linux__ for proper aux-triple

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added a subscriber: krytarowski. Clang predefine macro `__linx__` for aux-triple with Linux OS but does not predefine macro `__gnu_linux__`. This causes some compilation error for certain applications, e.g. Eigen. This patch fixes

[PATCH] D51434: [HIP] Add -amdgpu-internalize-symbols option to opt

yaxunl added a comment. In https://reviews.llvm.org/D51434#1217772, @tra wrote: > Could you elaborate on what exactly is the problem this patch fixes? > I don't see how internalizing the symbols connects to PLTs. My understanding > is that PLTs are used to provide stubs for symbols to be resolv

[PATCH] D51440: [ToolChains] Link to compiler-rt with -L + -l when possible

beanz added a reviewer: phosek. beanz added a subscriber: phosek. beanz added a comment. Looping in @phosek. Repository: rC Clang https://reviews.llvm.org/D51440 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D51333: Diagnose likely typos in include statements

christylee updated this revision to Diff 163132. christylee edited the summary of this revision. christylee added a comment. Merged warning with existing file_not_found_error. https://reviews.llvm.org/D51333 Files: include/clang/Basic/DiagnosticLexKinds.td lib/Lex/PPDirectives.cpp lib/Lex

[PATCH] D51434: [HIP] Add -amdgpu-internalize-symbols option to opt

tra added a comment. I could not find anything about PLTs in AMDGPU-ABI , nor could I find anything relevant on google. I still have no idea why PLTs are required in this case. Without that info, the problem

  1   2   >