[PATCH] D50152: [CodeGen] Merge equivalent block copy/helper functions

rjmccall added a comment. In https://reviews.llvm.org/D50152#1191777, @ahatanak wrote: > Since BlockVarCopyInits is a map with key `VarDecl *`, I think we want to add > a flag to VarDecl (NonParmVarDeclBits) that indicates whether the copy > expression can throw or not. Or is there a reason to

[PATCH] D50099: [DebugInfo][OpenCL] Address post-commit review of D49930

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. LGTM. Thanks. https://reviews.llvm.org/D50099 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D50144: Add Windows support for the GNUstep Objective-C ABI V2.

rjmccall added inline comments. Comment at: lib/AST/MicrosoftMangle.cpp:448 mangleVariableEncoding(VD); - else + else if (!isa(D)) llvm_unreachable("Tried to mangle unexpected NamedDecl!"); I don't think we want `ObjCInterfaceDecl`s to enter this func

[PATCH] D50414: [libunwind][include] Add SEH declarations to .

mstorsjo added a comment. Should we maybe add the same declaration of `_GCC_specific_handler` to clang's unwind.h? That would allow removing the forward declaration in libcxxabi from https://reviews.llvm.org/D49638. Do you plan on implementing these SEH specific bits in libunwind, or are you j

[PATCH] D50413: [libunwind][include] Add some missing definitions to .

mstorsjo added inline comments. Comment at: include/unwind.h:46 +typedef uintptr_t _Unwind_Ptr; +#endif + What other reference is this list of typedefs for `_Unwind_Ptr` based on? I don't see any of these cases in clang's unwind.h at least. Co

[PATCH] D50412: [libunwind] Fix pointer-to-integer cast warnings on LLP64.

mstorsjo added a subscriber: hans. mstorsjo added a comment. @hans This looks 7.0-worthy to me. Repository: rL LLVM https://reviews.llvm.org/D50412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D50144: Add Windows support for the GNUstep Objective-C ABI V2.

DHowett-MSFT added inline comments. Comment at: lib/CodeGen/CGBlocks.cpp:1276 +InitVar->setSection(".CRT$XCLa"); +CGM.addUsedGlobal(InitVar); + } rjmccall wrote: > Is the priority system not good enough? My reading of the LLVM language reference leads me

[PATCH] D50380: [Headers] Expand _Unwind_Exception for SEH on MinGW/x86_64

hans added a comment. In https://reviews.llvm.org/D50380#1191423, @mstorsjo wrote: > @hans Can you merge this for 7.0? This is necessary for > https://reviews.llvm.org/D49638 (merged well before the branch) to work > properly without causing heap corruption. Merged in r339220. Repository:

Re: r339170 - [Headers] Expand _Unwind_Exception for SEH on MinGW/x86_64

Merged to 7.0 in r339220. On Tue, Aug 7, 2018 at 10:02 PM, Martin Storsjo via cfe-commits wrote: > Author: mstorsjo > Date: Tue Aug 7 13:02:40 2018 > New Revision: 339170 > > URL: http://llvm.org/viewvc/llvm-project?rev=339170&view=rev > Log: > [Headers] Expand _Unwind_Exception for SEH on MinGW

<    1   2   3