[PATCH] D49922: [P0936R0] add [[clang::lifetimebound]] attribute

rsmith marked 3 inline comments as done. rsmith added inline comments. Comment at: lib/Sema/SemaInit.cpp:6959 + case IndirectLocalPathEntry::LifetimeBoundCall: +// FIXME: Consider adding a note for this. +break; aaron.ballman wrote: > Is this

[PATCH] D49922: [P0936R0] add [[clang::lifetimebound]] attribute

This revision was automatically updated to reflect the committed changes. rsmith marked 2 inline comments as done. Closed by commit rC338464: [P0936R0] add [[clang::lifetimebound]] attribute (authored by rsmith, committed by ). Changed prior to commit: https://reviews.llvm.org/D49922?vs=158149&

[PATCH] D50008: [libc++] Remove _LIBCPP_BUILDING_XXX macros, which are redundant since _LIBCPP_BUILDING_LIBRARY

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. This looks fine to me. Repository: rCXX libc++ https://reviews.llvm.org/D50008 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

r338467 - Avoid exposing name for range-based for '__range' variables in lifetime warnings.

Author: rsmith Date: Tue Jul 31 18:03:33 2018 New Revision: 338467 URL: http://llvm.org/viewvc/llvm-project?rev=338467&view=rev Log: Avoid exposing name for range-based for '__range' variables in lifetime warnings. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td cfe/trunk/

[PATCH] D50122: Complex Variable defined in InitCapture Crash fix

bviyer created this revision. bviyer added reviewers: erik.pilkington, ahatanak, arphaman, dexonsmith. Herald added a subscriber: cfe-commits. When a variable is defined in the init capture and it is of type struct that is dependent on additional structure, its definition is not found. An excepti

[PATCH] D49396: [WebAssembly] Support for atomic.wait / atomic.wake builtins

aheejin updated this revision to Diff 158434. aheejin marked an inline comment as done. aheejin added a comment. - Changed types Repository: rC Clang https://reviews.llvm.org/D49396 Files: include/clang/Basic/BuiltinsWebAssembly.def lib/CodeGen/CGBuiltin.cpp test/CodeGen/builtins-wasm.

[PATCH] D49396: [WebAssembly] Support for atomic.wait / atomic.wake builtins

aheejin added inline comments. Comment at: include/clang/Basic/BuiltinsWebAssembly.def:38 +// Atomic wait and wake. +BUILTIN(__builtin_wasm_atomic_wait_i32, "Uii*iLLi", "n") +BUILTIN(__builtin_wasm_atomic_wait_i64, "UiLLi*LLiLLi", "n") dschuff wrote: > So this me

[PATCH] D50122: Complex Variable defined in InitCapture Crash fix

erik.pilkington added a comment. Hi Balaji, Can you try to manually reduce the attached testcase? Its really difficult to understand exactly what is actually happening here, and why your fix is correct, without having a minimal reproducer. Ideally there would just be a few decls that succinctly

r338471 - AMDGPU: Add clamp bit to dot builtins

Author: kzhuravl Date: Tue Jul 31 18:32:21 2018 New Revision: 338471 URL: http://llvm.org/viewvc/llvm-project?rev=338471&view=rev Log: AMDGPU: Add clamp bit to dot builtins Differential Revision: https://reviews.llvm.org/D50011 Added: cfe/trunk/test/CodeGenOpenCL/builtins-amdgcn-dl-insts-err

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

vit9696 added a comment. Hello, Thank you for working this. I tried the change and have a couple of suggestions: 1. -mspe option in GCC works like -mspe=yes or -mspe=no. While it does make sense to have it the way you did (-mno-spe and -mspe) it would be nice to have at least have an alias for

[PATCH] D50123: [OpenEmbedded] Explicitly specify -stdlib and -rtlib in tests

phosek created this revision. phosek added reviewers: rsmith, mgrang, Hahnfeld. Herald added a subscriber: cfe-commits. Tests added r338294 implicitly assume that the libstdc++ is the standard C++ library and libgcc is the runtime library, but that's not the case when the user configures Clang to

[PATCH] D50123: [OpenEmbedded] Explicitly specify -stdlib and -rtlib in tests

phosek added a comment. This broke all our bots so I plan on submitting this if I don't hear back soon. Repository: rC Clang https://reviews.llvm.org/D50123 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

[PATCH] D50101: [asan] Update a vector's storage annotation during destruction.

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. I'm OK with this. Repository: rCXX libc++ https://reviews.llvm.org/D50101 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

r338473 - Speculative fix for buildbot failures after r338464.

Author: rsmith Date: Tue Jul 31 18:57:49 2018 New Revision: 338473 URL: http://llvm.org/viewvc/llvm-project?rev=338473&view=rev Log: Speculative fix for buildbot failures after r338464. Modified: cfe/trunk/lib/Sema/SemaDecl.cpp Modified: cfe/trunk/lib/Sema/SemaDecl.cpp URL: http://llvm.org/

r338474 - [analyzer] CallEvent: Add helper methods for obtaining the callee stack frame.

Author: dergachev Date: Tue Jul 31 18:58:15 2018 New Revision: 338474 URL: http://llvm.org/viewvc/llvm-project?rev=338474&view=rev Log: [analyzer] CallEvent: Add helper methods for obtaining the callee stack frame. Newly added methods allow reasoning about the stack frame of the call (as opposed

[PATCH] D49715: [analyzer] CallEvent: Add partially working methods for obtaining the callee stack frame.

This revision was automatically updated to reflect the committed changes. Closed by commit rL338474: [analyzer] CallEvent: Add helper methods for obtaining the callee stack frame. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

[PATCH] D49997: [libcxx] Fix _LIBCPP_NO_EXCEPTIONS redefined warning

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. I'm fine with this; it matches the pattern used on line #354 of this file. (which is in the 'clang' block). We don't do anything like this for the IBM or MS compilers - yet. Reposi

[PATCH] D49114: [clang-tidy] Add a check for "magic numbers"

0x8000- updated this revision to Diff 158450. 0x8000- added a comment. Add reference to 5.1.1 Use symbolic names instead of literal values in code in the documentation. Repository: rCTE C

[libcxxabi] r338475 - [libc++] Remove _LIBCPP_BUILDING_XXX macros, which are redundant since _LIBCPP_BUILDING_LIBRARY

Author: ldionne Date: Tue Jul 31 19:08:59 2018 New Revision: 338475 URL: http://llvm.org/viewvc/llvm-project?rev=338475&view=rev Log: [libc++] Remove _LIBCPP_BUILDING_XXX macros, which are redundant since _LIBCPP_BUILDING_LIBRARY Summary: As suggested by Marshall in https://reviews.llvm.org/D499

[PATCH] D50008: [libc++] Remove _LIBCPP_BUILDING_XXX macros, which are redundant since _LIBCPP_BUILDING_LIBRARY

This revision was automatically updated to reflect the committed changes. Closed by commit rL338475: [libc++] Remove _LIBCPP_BUILDING_XXX macros, which are redundant since… (authored by ldionne, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.ll

[libcxx] r338475 - [libc++] Remove _LIBCPP_BUILDING_XXX macros, which are redundant since _LIBCPP_BUILDING_LIBRARY

Author: ldionne Date: Tue Jul 31 19:08:59 2018 New Revision: 338475 URL: http://llvm.org/viewvc/llvm-project?rev=338475&view=rev Log: [libc++] Remove _LIBCPP_BUILDING_XXX macros, which are redundant since _LIBCPP_BUILDING_LIBRARY Summary: As suggested by Marshall in https://reviews.llvm.org/D499

[PATCH] D49627: [CFG] [analyzer] Constructors of member CXXOperatorCallExpr's argument 0 are not argument constructors.

NoQ added a comment. Hmm, AST has just changed in https://reviews.llvm.org/rC338135. While the current patch is still relevant, it might be that we'll need to treat this construction context as if it's a simple temporary now. https://reviews.llvm.org/D49627 _

r338478 - Work around GCC miscompile exposed by r338464.

Author: rsmith Date: Tue Jul 31 19:27:18 2018 New Revision: 338478 URL: http://llvm.org/viewvc/llvm-project?rev=338478&view=rev Log: Work around GCC miscompile exposed by r338464. See gcc.gnu.org/PR86769 for details of the bug. Modified: cfe/trunk/lib/Sema/SemaDecl.cpp Modified: cfe/trunk/l

[PATCH] D50123: [OpenEmbedded] Explicitly specify -stdlib and -rtlib in tests

mgrang accepted this revision. mgrang added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang https://reviews.llvm.org/D50123 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-b

[libcxx] r338479 - [libc++][C++17] Elementary string conversions for integral types

Author: lichray Date: Tue Jul 31 19:38:30 2018 New Revision: 338479 URL: http://llvm.org/viewvc/llvm-project?rev=338479&view=rev Log: [libc++][C++17] Elementary string conversions for integral types Summary: Major QoI considerations: - The facility is backported to C++14, same as libstdc++. - Ef

[PATCH] D41458: [libc++][C++17] Elementary string conversions for integral types

This revision was automatically updated to reflect the committed changes. Closed by commit rL338479: [libc++][C++17] Elementary string conversions for integral types (authored by lichray, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/

[PATCH] D38320: [clang] Fix serializers for `TypeTemplateParmDecl` + related types

elsteveogrande added inline comments. Comment at: lib/Serialization/ASTReaderDecl.cpp:3448-3456 if (!inheritDefaultTemplateArgument(Context, FTTP, ToParam)) break; } else if (auto *FNTTP = dyn_cast(FromParam)) { if (!inheritDefaultTemplateArgument(Cont

r338482 - [OpenEmbedded] Explicitly specify -rtlib in tests

Author: phosek Date: Tue Jul 31 20:30:06 2018 New Revision: 338482 URL: http://llvm.org/viewvc/llvm-project?rev=338482&view=rev Log: [OpenEmbedded] Explicitly specify -rtlib in tests Tests added in r338294 implicitly assume that libgcc is the runtime library, but that's not the case when the user

[PATCH] D50123: [OpenEmbedded] Explicitly specify -stdlib and -rtlib in tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL338482: [OpenEmbedded] Explicitly specify -rtlib in tests (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D50123?vs=158444

[PATCH] D49771: CodeGen: use non-zero memset when possible for automatic variables

jfb added a comment. In https://reviews.llvm.org/D49771#1183641, @mehdi_amini wrote: > > I'm worried, however, about generating a bunch more code than needed from > > clang in the hopes that the compiler will clean it up later. > > Isn't a strong design component of clang/LLVM? Clang does not tr

[PATCH] D50130: [libc++] Fix build failures after merging

lichray created this revision. Herald added a reviewer: EricWF. Herald added subscribers: cfe-commits, ldionne, christof. - fix a stupid unit test typo - add symbols to Linux abilist Repository: rCXX libc++ https://reviews.llvm.org/D50130 Files: lib/abi/x86_64-unknown-linux-gnu.v1.abilist

[libcxx] r338486 - [libc++] Fix build failures after merging

Author: lichray Date: Tue Jul 31 22:21:26 2018 New Revision: 338486 URL: http://llvm.org/viewvc/llvm-project?rev=338486&view=rev Log: [libc++] Fix build failures after merging Summary: - fix a stupid unit test typo - add symbols to Linux abilist Reviewers: EricWF Subscribers: christof, ldionn

[PATCH] D50130: [libc++] Fix build failures after merging

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rCXX338486: [libc++] Fix build failures after merging (authored by lichray, committed by ). Changed prior to com

[PATCH] D50050: [AST] CastExpr: BasePathSize is not large enough.

This revision was automatically updated to reflect the committed changes. Closed by commit rC338489: [AST] CastExpr: BasePathSize is not large enough. (authored by lebedevri, committed by ). Repository: rC Clang https://reviews.llvm.org/D50050 Files: include/clang/AST/Expr.h include/clang

r338489 - [AST] CastExpr: BasePathSize is not large enough.

Author: lebedevri Date: Tue Jul 31 23:06:16 2018 New Revision: 338489 URL: http://llvm.org/viewvc/llvm-project?rev=338489&view=rev Log: [AST] CastExpr: BasePathSize is not large enough. Summary: rC337815 / D49508 had to cannibalize one bit of `CastExprBitfields::BasePathSize` in order to squeeze

[PATCH] D50104: [OpenCL] Always emit alloca in entry block for enqueue_kernel builtin

arsenm added a comment. Should this also test for lifetime markers? Repository: rC Clang https://reviews.llvm.org/D50104 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3