On Thu, Jul 19, 2018 at 7:10 AM Pavel Labath via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: labath
> Date: Thu Jul 19 07:05:22 2018
> New Revision: 337456
>
> URL: http://llvm.org/viewvc/llvm-project?rev=337456&view=rev
> Log:
> [CodeGen] Disable aggressive structor optimizations a
TheAhmad updated this revision to Diff 157846.
TheAhmad marked 4 inline comments as done.
TheAhmad added a comment.
auto used at line 612.
auto removed at line 614.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49890
Files:
ClangTidy.cpp
Index: ClangTidy.cpp
==
Author: sepavloff
Date: Sat Jul 28 08:33:03 2018
New Revision: 338199
URL: http://llvm.org/viewvc/llvm-project?rev=338199&view=rev
Log:
[UBSan] Strengthen pointer checks in 'new' expressions
With this change compiler generates alignment checks for wider range
of types. Previously such checks were
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338199: [UBSan] Strengthen pointer checks in 'new'
expressions (authored by sepavloff, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D49589
File
aaron.ballman added inline comments.
Comment at: clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp:45-46
"cppcoreguidelines-interfaces-global-init");
+CheckFactories.registerCheck(
+"cppcoreguidelines-avoid-magic-numbers");
CheckFactories.regi
aaron.ballman added a comment.
Should this attribute have some semantic checking that ensures the non-static
data members are accessed in the function that claims it reinitializes the
object? Otherwise, it seems like this would not trigger any diagnostics:
class C {
int a, b;
public:
aaron.ballman added inline comments.
Comment at: clang-tidy/utils/ExprSequence.cpp:147
return TheIfStmt->getCond();
+} else if (const auto *TheWhileStmt = dyn_cast(Parent)) {
+ // While statement: If a variable is declared inside the condition, the
-
0x8000- updated this revision to Diff 157863.
0x8000- added a comment.
Address review comments to improve documentation and readability
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49114
Files:
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
clang-tid
0x8000- marked 7 inline comments as done.
0x8000- added inline comments.
Comment at: clang-tidy/readability/MagicNumbersCheck.cpp:53
+
+const char DefaultIgnoredIntegerValues[] = "0;1;";
+
aaron.ballman wrote:
> Is the trailing semicolon after the `1` nec
aaron.ballman added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:2371
+is retained by the return value of the annotated function
+(or, for a constructor, in the value of the constructed object).
+It is only supported in C++.
I read this as allowin
aaron.ballman added inline comments.
Comment at: docs/clang-tidy/checks/readability-magic-numbers.rst:61-63
+configuration for accepted floating point values, primarily because most
+floating point comparisons are not exact, and some of the exact ones are not
+portable.
-
lebedev.ri added inline comments.
Comment at: docs/clang-tidy/checks/readability-magic-numbers.rst:61-63
+configuration for accepted floating point values, primarily because most
+floating point comparisons are not exact, and some of the exact ones are not
+portable.
0x8000- marked an inline comment as done.
0x8000- added inline comments.
Comment at: docs/clang-tidy/checks/readability-magic-numbers.rst:61-63
+configuration for accepted floating point values, primarily because most
+floating point comparisons are not exact, and some of
0x8000- added inline comments.
Comment at: docs/clang-tidy/checks/readability-magic-numbers.rst:61-63
+configuration for accepted floating point values, primarily because most
+floating point comparisons are not exact, and some of the exact ones are not
+portable.
---
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
The changes look reasonable to me (after fixing a few nits), but please give
@delesley a chance to weigh in before committing.
Comment at: lib/Analysis/ThreadS
0x8000- added a comment.
I will add one more option: IgnoreFloatingPointValues, to ignore all floats and
doubles, because the FloatingLiteral does not distinguish between them (as
implementation detail), and I don't see a good reason to be strict about
doubles and lenient about floats, or v
aaron.ballman added inline comments.
Comment at: docs/clang-tidy/checks/readability-magic-numbers.rst:61-63
+configuration for accepted floating point values, primarily because most
+floating point comparisons are not exact, and some of the exact ones are not
+portable.
-
lebedev.ri added inline comments.
Comment at: docs/clang-tidy/checks/readability-magic-numbers.rst:61-63
+configuration for accepted floating point values, primarily because most
+floating point comparisons are not exact, and some of the exact ones are not
+portable.
0x8000- updated this revision to Diff 157871.
0x8000- added a comment.
Add option to ignore all floating point values.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49114
Files:
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
clang-tidy/readability/CMa
0x8000- added inline comments.
Comment at: docs/clang-tidy/checks/readability-magic-numbers.rst:61-63
+configuration for accepted floating point values, primarily because most
+floating point comparisons are not exact, and some of the exact ones are not
+portable.
---
mclow.lists added a comment.
Getting really close.
Comment at: libcxx/include/experimental/simd:726
+#if defined(_LIBCPP_COMPILER_CLANG)
+#define _SPECIALIZE_VEC_EXT(_TYPE, _NUM_ELEMENT)
\
+ template <>
aaronpuchert updated this revision to Diff 157872.
aaronpuchert added a comment.
Formatting changes suggested by Aaron Ballman.
Repository:
rC Clang
https://reviews.llvm.org/D49885
Files:
lib/Analysis/ThreadSafety.cpp
test/SemaCXX/warn-thread-safety-analysis.cpp
Index: test/SemaCXX/warn
aaronpuchert marked 3 inline comments as done.
aaronpuchert added inline comments.
Comment at: lib/Analysis/ThreadSafety.cpp:960-961
+FSet.removeLock(FactMan, !UnderCp);
+FSet.addLock(FactMan, llvm::make_unique(UnderCp, LK,
+
aaron.ballman added inline comments.
Comment at: docs/clang-tidy/checks/readability-magic-numbers.rst:61-63
+configuration for accepted floating point values, primarily because most
+floating point comparisons are not exact, and some of the exact ones are not
+portable.
-
0x8000- added inline comments.
Comment at: docs/clang-tidy/checks/readability-magic-numbers.rst:61-63
+configuration for accepted floating point values, primarily because most
+floating point comparisons are not exact, and some of the exact ones are not
+portable.
---
0x8000- added a comment.
Not trying to be difficult here - I have attempted to implement the
straight-forward check.
Added this to the MagicNumbersCheck::MagicNumbersCheck constructor:
+ // process set of ignored floating point values
+ const std::vector IgnoredFloatingPointValuesInpu
0x8000- updated this revision to Diff 157879.
0x8000- added a comment.
Add support for ignoring specific floating point numbers.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49114
Files:
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
clang-tidy/reada
On Sat, Jul 28, 2018 at 2:26 AM Chandler Carruth
wrote:
> On Thu, Jul 19, 2018 at 7:10 AM Pavel Labath via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: labath
>> Date: Thu Jul 19 07:05:22 2018
>> New Revision: 337456
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=337456&vie
Author: chandlerc
Date: Sat Jul 28 20:05:07 2018
New Revision: 338209
URL: http://llvm.org/viewvc/llvm-project?rev=338209&view=rev
Log:
Revert r337456: [CodeGen] Disable aggressive structor optimizations at -O0,
take 3
This commit increases the number of sections and overall output size of
.o fi
29 matches
Mail list logo
