mgrang added a comment.
@rsmith Could you please take a look at the updated patch? I would like to
commit this. Thanks.
https://reviews.llvm.org/D48862
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
erik.pilkington created this revision.
erik.pilkington added reviewers: rsmith, rjmccall.
Herald added a subscriber: dexonsmith.
Only apply this exception on a type that we're able to check.
Thanks!
Erik
Repository:
rC Clang
https://reviews.llvm.org/D49868
Files:
clang/lib/Sema/SemaInit.c
Oh, yes, it is a typo, thanks for catching it!
-
Best regards,
Alexey Bataev
26.07.2018 13:59, Jonas Hahnfeld via cfe-commits пишет:
> Hi Alexey,
>
> On 2018-07-26 19:53, Alexey Bataev via cfe-commits wrote:
>> Author: abataev
>> Date: Thu Jul 26 10:53:45 2018
>> New Revision: 338049
Author: omtcyfz
Date: Thu Jul 26 11:25:48 2018
New Revision: 338054
URL: http://llvm.org/viewvc/llvm-project?rev=338054&view=rev
Log:
Revert Clangd Dex Iterators patch
This reverts two revisions:
* https://reviews.llvm.org/rL338017
* https://reviews.llvm.org/rL338028
They caused crash for Clang
Hi Jeremy,
Thank you for reporting the issue and apologies for inconvenience. There
was another bug which caused buildbots crashes, I was looking into that
before so I missed this one.
I built Clang 3.6 and Clang 3.7 locally, simply wrapping everything into
std::move didn't resolve the issue, I r
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Core/CallEvent.cpp:197
+
+ // Recover CFG block via reverse lookup. Maybe it should just be a part of
the
+ // CallEvent object? That would have been convenient.
george.karpenkov wrote:
> Can we remove
Author: abataev
Date: Thu Jul 26 11:40:41 2018
New Revision: 338055
URL: http://llvm.org/viewvc/llvm-project?rev=338055&view=rev
Log:
[OPENMP, DOCS] Fixed typo, NFC.
Modified:
cfe/trunk/docs/ReleaseNotes.rst
Modified: cfe/trunk/docs/ReleaseNotes.rst
URL:
http://llvm.org/viewvc/llvm-project/
Author: rsmith
Date: Thu Jul 26 11:41:30 2018
New Revision: 338056
URL: http://llvm.org/viewvc/llvm-project?rev=338056&view=rev
Log:
Refactor checking of switch conditions and case values.
Check each case value in turn while parsing it, performing the
conversion to the switch type within the cont
pcc added inline comments.
Comment at: clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp:147
+ builder.setUseOrcMCJITReplacement(false);
+ builder.setMCJITMemoryManager(make_unique());
+ builder.setOptLevel(OLvl);
morehouse wrote:
> This uses `llvm:make_uni
emmettneyman added inline comments.
Comment at: clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp:144
+ Context);
+ Module *M = Owner.get();
+ if (!M)
morehouse wrote:
> Why not just rename `Owner` to `M` and remove
emmettneyman updated this revision to Diff 157544.
emmettneyman added a comment.
- Code style fixes
- Removed `FPasses`
- Allowed CL Args to specify opt level for `OptLLVM()`
Repository:
rC Clang
https://reviews.llvm.org/D49526
Files:
clang/tools/clang-fuzzer/fuzzer-initialize/fuzzer_initi
emmettneyman updated this revision to Diff 157545.
emmettneyman added a comment.
Small change to fix line length
Repository:
rC Clang
https://reviews.llvm.org/D49526
Files:
clang/tools/clang-fuzzer/fuzzer-initialize/fuzzer_initialize.cpp
clang/tools/clang-fuzzer/handle-llvm/CMakeLists.tx
Author: simark
Date: Thu Jul 26 11:55:02 2018
New Revision: 338057
URL: http://llvm.org/viewvc/llvm-project?rev=338057&view=rev
Log:
[VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the
requested name
Summary:
InMemoryFileSystem::status behaves differently than
RealFileSyste
This revision was automatically updated to reflect the committed changes.
Closed by commit rC338057: [VirtualFileSystem] InMemoryFileSystem::status:
Return a Status with the… (authored by simark, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48903?vs=157467&id=157548#toc
R
aleksandr.urakov created this revision.
aleksandr.urakov added reviewers: rsmith, zturner, rnk, mstorsjo, majnemer.
aleksandr.urakov added a project: clang.
This patch improves support of PDB as an external layout source in the next
cases:
- Multiple non-virtual inheritance from packed base clas
NoQ updated this revision to Diff 157550.
NoQ added a comment.
Add one more handy method, `getAdjustedParameterIndex()`, which helps using
`getParameterLocation()`.
https://reviews.llvm.org/D49715
Files:
include/clang/Analysis/ConstructionContext.h
include/clang/StaticAnalyzer/Core/PathSen
morehouse added a comment.
Do we need to parse the arguments for opt-level, or can we just hardcode `-O2`
and remove the argument parsing code?
Comment at: clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp:144
+ Context);
+ Module
rjmccall added a comment.
Could you include a test that satisfies the exception but requires a template
to be instantiated to check that? It's probably already tested elsewhere, but
still.
Repository:
rC Clang
https://reviews.llvm.org/D49868
_
rjmccall added inline comments.
Comment at: lib/CodeGen/CGClass.cpp:2190
This, Args, AggValueSlot::MayOverlap,
- E->getLocation());
+ E->getLocation(), true);
}
Please include `/* */` comm
Other than the (fixed) ffmpeg false positive, I see this firing in three
places.
One of them is in the libc tests for memset and bzero, where the 0 argument
is intentional.
One of them is here:
https://github.com/apache/xerces-c/blob/trunk/src/xercesc/util/XMLUTF16Transcoder.cpp#L114
(note that th
malaperle added a comment.
In https://reviews.llvm.org/D49833#1176337, @ilya-biryukov wrote:
> Not strictly opposed to this change, but is there any reason why the clients
> can't guarantee they'll send didChangeConfiguration right after clangd is
> initialized?
LSP:
> Until the server has r
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rC Clang
https://reviews.llvm.org/D49871
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
emmettneyman added a comment.
In https://reviews.llvm.org/D49526#1177208, @morehouse wrote:
> Do we need to parse the arguments for opt-level, or can we just hardcode
> `-O2` and remove the argument parsing code?
I have the argument parsing code since the original `clang-proto-fuzzer` code
ha
emmettneyman updated this revision to Diff 157553.
emmettneyman added a comment.
Changed int to CodeGenOpt::Level and fixed unique_ptr issue
Repository:
rC Clang
https://reviews.llvm.org/D49526
Files:
clang/tools/clang-fuzzer/fuzzer-initialize/fuzzer_initialize.cpp
clang/tools/clang-fuzz
On 7/26/18 12:52 PM, Richard Smith wrote:
Other than the (fixed) ffmpeg false positive, I see this firing in
three places.
One of them is in the libc tests for memset and bzero, where the 0
argument is intentional.
I don't find this case very convincing, if you're literally the one
person
rsmith added inline comments.
Comment at: include/clang/AST/Expr.h:2928
+ bool getIsPartOfExplicitCast() const {
+return CastExprBits.PartOfExplicitCast;
Please also rename this to`isPartOfExplicitCast` as requested on IRC.
Comment at: i
On Thu, Jul 26, 2018 at 12:52 PM, Richard Smith
wrote:
> Other than the (fixed) ffmpeg false positive, I see this firing in three
> places.
>
> One of them is in the libc tests for memset and bzero, where the 0
> argument is intentional.
> One of them is here: https://github.com/apache/xerces-c/b
rsmith requested changes to this revision.
rsmith added a comment.
This revision now requires changes to proceed.
What I requested was that either we make `CastExpr::isPartOfExplicitCast()`
return `true` for `CastExpr`s that are not `ImplicitCastExpr`s, or that we move
`isPartOfExplicitCast` do
Meinersbur added a comment.
ping
Repository:
rC Clang
https://reviews.llvm.org/D48808
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
probinson accepted this revision.
probinson added a comment.
Although I am far from expert in how Clang manages declarations, AFAICT this
does what @rsmith requested, so LGTM.
https://reviews.llvm.org/D46190
___
cfe-commits mailing list
cfe-commits
lebedev.ri abandoned this revision.
lebedev.ri added a comment.
In https://reviews.llvm.org/D49844#1177273, @rsmith wrote:
> What I requested was that either we make `CastExpr::isPartOfExplicitCast()`
> return `true` for `CastExpr`s that are not `ImplicitCastExpr`s, or that we
> move `isPartOfE
ABataev updated this revision to Diff 157563.
ABataev added a comment.
Address ERic's comments.
Repository:
rC Clang
https://reviews.llvm.org/D49148
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Basic/DiagnosticGroups.td
include/clang/Driver/ToolChain.h
lib/Driver
ssijaric updated this revision to Diff 157559.
ssijaric added a comment.
Last change before committing to address Reid's point of using
CCK_MicrosoftWin64 for Windows on both X86_64 and ARM64.
Repository:
rC Clang
https://reviews.llvm.org/D49770
Files:
include/clang/Basic/TargetInfo.h
l
ABataev marked an inline comment as done.
ABataev added inline comments.
Comment at: lib/Driver/ToolChains/Clang.cpp:933-938
+ if (TC.supportsDebugInfoOption(A)) {
+Action();
+return true;
+ }
+ reportUnsupportedDebugInfoOption(A, Args, D, TC.getTriple());
+ return fa
rsmith added inline comments.
Comment at: include/clang/Sema/Sema.h:4040-4041
// explicit nested-name-specifier).
- void MarkAnyDeclReferenced(SourceLocation Loc, Decl *D, bool MightBeOdrUse);
+ void MarkAnyDeclReferenced(SourceLocation Loc, Decl *D, bool MightBeOdrUse,
+
devnexen created this revision.
devnexen added a reviewer: pcc.
devnexen created this object with visibility "All Users".
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D49873
Files:
docs/ReleaseNotes.rst
Index: docs/ReleaseNotes.rst
=
aleksandr.urakov added a comment.
Thank you!
Can you, please, commit this for me? I have no commit access.
Repository:
rC Clang
https://reviews.llvm.org/D49871
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
On Thu, 26 Jul 2018 at 13:14, Erik Pilkington via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
>
>
> On 7/26/18 12:52 PM, Richard Smith wrote:
>
> Other than the (fixed) ffmpeg false positive, I see this firing in three
> places.
>
> One of them is in the libc tests for memset and bzero, where
On Thu, 26 Jul 2018 at 13:22, Arthur O'Dwyer via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Thu, Jul 26, 2018 at 12:52 PM, Richard Smith
> wrote:
>
>> Other than the (fixed) ffmpeg false positive, I see this firing in three
>> places.
>>
>> One of them is in the libc tests for memset a
jvesely added a comment.
In https://reviews.llvm.org/D49650#1176336, @arsenm wrote:
> In https://reviews.llvm.org/D49650#1175461, @jvesely wrote:
>
> > In https://reviews.llvm.org/D49650#1175438, @arsenm wrote:
> >
> > > According to cayman manual, these registers do exist so we should
> > > pro
On 7/26/18 1:38 PM, Richard Smith wrote:
On Thu, 26 Jul 2018 at 13:14, Erik Pilkington via cfe-commits
mailto:cfe-commits@lists.llvm.org>> wrote:
On 7/26/18 12:52 PM, Richard Smith wrote:
Other than the (fixed) ffmpeg false positive, I see this firing
in three places.
One
morehouse added inline comments.
Comment at: clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp:125
+ Context);
+ Module *M = Owner.get();
+ if (!M)
We should be able to get rid of this line now, and rename Owner again
morehouse added inline comments.
Comment at: clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp:152
+ typedef void (*func)(int*, int*, int*, int);
+ func f = (func) EE->getPointerToFunction(EntryFunc);
+
Can we use `reinterpret_cast` here?
Repository:
rC
lebedev.ri updated this revision to Diff 157576.
lebedev.ri marked 3 inline comments as done.
lebedev.ri added a comment.
Address @rsmith review notes.
Repository:
rC Clang
https://reviews.llvm.org/D49838
Files:
include/clang/AST/Expr.h
include/clang/AST/Stmt.h
lib/AST/ASTDumper.cpp
lebedev.ri added inline comments.
Comment at: include/clang/AST/Expr.h:2928
+ bool getIsPartOfExplicitCast() const {
+return CastExprBits.PartOfExplicitCast;
rsmith wrote:
> Please also rename this to`isPartOfExplicitCast` as requested on IRC.
Right, sorry
emmettneyman updated this revision to Diff 157577.
emmettneyman added a comment.
Made some minor fixes
Repository:
rC Clang
https://reviews.llvm.org/D49526
Files:
clang/tools/clang-fuzzer/fuzzer-initialize/fuzzer_initialize.cpp
clang/tools/clang-fuzzer/handle-llvm/CMakeLists.txt
clang/
erik.pilkington updated this revision to Diff 157575.
erik.pilkington added a comment.
Add the testcase @rjmccall requested.
https://reviews.llvm.org/D49868
Files:
clang/lib/Sema/SemaInit.cpp
clang/test/SemaCXX/cxx1z-class-template-argument-deduction.cpp
Index: clang/test/SemaCXX/cxx1z-cl
Rakete updated this revision to Diff 157578.
Rakete added a comment.
@rsmith you're right, it should. But it doesn't, because the the fold
expression is considered to be a cast expression by ParseParenExpression and
which parses any postfix pieces immediately after a cast, but it doesn't
Rakete updated this revision to Diff 157580.
Rakete added a comment.
Add a test without any casts.
Repository:
rC Clang
https://reviews.llvm.org/D49848
Files:
include/clang/Parse/Parser.h
lib/Parse/ParseExpr.cpp
test/Parser/cxx1z-fold-expressions.cpp
Index: test/Parser/cxx1z-
leonardchan created this revision.
leonardchan added a project: clang.
Herald added a subscriber: cfe-commits.
This patch is not actually up for review and meant to hold the remaining work
done after https://reviews.llvm.org/D47017 but haven't submitted for review yet.
This patch contains:
- `m
Author: ssijaric
Date: Thu Jul 26 15:18:28 2018
New Revision: 338076
URL: http://llvm.org/viewvc/llvm-project?rev=338076&view=rev
Log:
[ARM64] [Windows] Follow MS X86_64 C++ ABI when passing structs
Summary: Microsoft's C++ object model for ARM64 is the same as that for X86_64.
For example, small
This revision was automatically updated to reflect the committed changes.
Closed by commit rC338076: [ARM64] [Windows] Follow MS X86_64 C++ ABI when
passing structs (authored by ssijaric, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D49770
Files:
include/clang/Basic/TargetI
lebedev.ri updated this revision to Diff 157585.
lebedev.ri added a comment.
Rebase,
Address @rsmith review notes - just inline https://reviews.llvm.org/D49844.
Repository:
rC Clang
https://reviews.llvm.org/D48958
Files:
docs/ReleaseNotes.rst
docs/UndefinedBehaviorSanitizer.rst
include
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338077: Updated llvm-proto-fuzzer to execute the compiled
code (authored by emmettneyman, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D49526?vs=157577&id=157591#toc
Repository:
Author: emmettneyman
Date: Thu Jul 26 15:23:25 2018
New Revision: 338077
URL: http://llvm.org/viewvc/llvm-project?rev=338077&view=rev
Log:
Updated llvm-proto-fuzzer to execute the compiled code
Summary:
Made changes to the llvm-proto-fuzzer
- Added loop vectorizer optimization pass in order to ha
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM.
https://reviews.llvm.org/D49868
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
aaronpuchert created this revision.
aaronpuchert added reviewers: delesley, aaron.ballman.
Herald added a subscriber: cfe-commits.
It's already allowed to prematurely release a scoped lock, now we also
allow relocking it again, possibly even in another mode.
Arguably the solution is not very eleg
Author: rnk
Date: Thu Jul 26 16:18:44 2018
New Revision: 338083
URL: http://llvm.org/viewvc/llvm-project?rev=338083&view=rev
Log:
[MS] Add L__FUNCSIG__ for compatibility
Clang already has L__FUNCTION__ as a workaround for dealing with
pre-processor code that expects to be able to do L##__FUNCTION
Author: rnk
Date: Thu Jul 26 16:21:51 2018
New Revision: 338084
URL: http://llvm.org/viewvc/llvm-project?rev=338084&view=rev
Log:
Revert r338057 "[VirtualFileSystem] InMemoryFileSystem::status: Return a Status
with the requested name"
This broke clang/test/PCH/case-insensitive-include.c on Windo
I reverted this in r338084 because it broke clang tests on Windows:
http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/12916
On Thu, Jul 26, 2018 at 11:55 AM Simon Marchi via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: simark
> Date: Thu Jul 26 11:55:02 2018
> New
Author: sqlbyme
Date: Thu Jul 26 16:23:40 2018
New Revision: 338086
URL: http://llvm.org/viewvc/llvm-project?rev=338086&view=rev
Log:
[WWW] Adding a test page to work out an auto-deployment issue.
Added:
cfe/trunk/www/test.html
Added: cfe/trunk/www/test.html
URL:
http://llvm.org/viewvc/llvm
Author: sqlbyme
Date: Thu Jul 26 16:29:54 2018
New Revision: 338087
URL: http://llvm.org/viewvc/llvm-project?rev=338087&view=rev
Log:
[WWW] Removing my test file as the auto-deployment script has been fixed.
Removed:
cfe/trunk/www/test.html
Removed: cfe/trunk/www/test.html
URL:
http://llvm.
This revision was automatically updated to reflect the committed changes.
Closed by commit rC338089: [Sema] Fix a crash by completing a type before using
it (authored by epilk, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D49868?vs=157575&id=157606#toc
Repository:
rC Cla
Author: epilk
Date: Thu Jul 26 16:40:42 2018
New Revision: 338089
URL: http://llvm.org/viewvc/llvm-project?rev=338089&view=rev
Log:
[Sema] Fix a crash by completing a type before using it
Only apply this exception on a type that we're able to check.
rdar://41903969
Differential revision: https:
aaronpuchert added a comment.
Imagine having a producer loop, where we check a loop condition while holding a
mutex, but release it in the loop body to let other producers/consumers do
their work. In that scenario it makes sense to allow "relocking" a scope.
RelockableScope Scope(mu);
while
TheAhmad created this revision.
TheAhmad added a reviewer: alexfh.
TheAhmad added a project: clang-tools-extra.
Hi.
Clang tidy has problem with compile command databases that do not use
necassarily absolute file paths. This is common in many projects that use
makefiles as the build system, whose
Rakete updated this revision to Diff 157611.
Rakete added a comment.
Rebased + friendly ping
Repository:
rC Clang
https://reviews.llvm.org/D36357
Files:
include/clang/Basic/DiagnosticParseKinds.td
lib/Parse/ParseExprCXX.cpp
test/Parser/cxx0x-lambda-expressions.cpp
test/SemaCX
0x8000- marked 3 inline comments as done.
0x8000- added inline comments.
Comment at: docs/clang-tidy/checks/readability-magic-numbers.rst:55
+
+By default only `0`, `1` and `-1` integer values are accepted without a
warning.
+This can be overridden with the :option:`Igno
emmettneyman created this revision.
emmettneyman added a reviewer: morehouse.
Herald added subscribers: cfe-commits, mgorny.
Repository:
rC Clang
https://reviews.llvm.org/D49892
Files:
clang/tools/clang-fuzzer/fuzzer-initialize/fuzzer_initialize.cpp
clang/tools/clang-fuzzer/handle-llvm/CMa
0x8000- updated this revision to Diff 157615.
0x8000- marked an inline comment as done.
0x8000- added a comment.
Remove extra verbose namespaces and update documentation to indicate why -1 is
accepted even when not explicitly called out.
Repository:
rCTE Clang Tools Extra
https:/
rsmith added a comment.
This looks good, with some minor changes. Please add more test coverage,
though, specifically:
- test all four forms of lambda that we recognize after `delete`
- add a test that the FixItHint is correct (maybe in
test/FixIt/fixit-cxx0x.cpp, which checks that applying the
emmettneyman created this revision.
Herald added subscribers: cfe-commits, mgorny.
added shared library to fix buildbot
Repository:
rC Clang
https://reviews.llvm.org/D49895
Files:
clang/tools/clang-fuzzer/handle-llvm/CMakeLists.txt
Index: clang/tools/clang-fuzzer/handle-llvm/CMakeLists.t
Author: emmettneyman
Date: Thu Jul 26 17:43:26 2018
New Revision: 338091
URL: http://llvm.org/viewvc/llvm-project?rev=338091&view=rev
Log:
added shared library to fix buildbot
Summary: added shared library to fix buildbot
Subscribers: mgorny, cfe-commits
Differential Revision: https://reviews.l
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC338091: added shared library to fix buildbot (authored by
emmettneyman, committed by ).
Changed prior to commit:
https:
Eugene.Zelenko added inline comments.
Comment at: ClangTidy.cpp:627
+Files->makeAbsolutePath(ErrorAbsoluteFilePath);
+if (SingleErrors.find(ErrorAbsoluteFilePath) == SingleErrors.end())
+{
Please run Clang-format.
Repository:
rCTE Clang Tools Extr
Eugene.Zelenko added inline comments.
Comment at: ClangTidy.cpp:620
+ llvm::StringMap SingleErrors;
+ for (const ClangTidyError &Error : Errors) {
+if (!Error.BuildDirectory.empty()) {
You could use auto, since it's iterator over container.
==
TheAhmad updated this revision to Diff 157623.
TheAhmad added a comment.
Ran Clang Format.
Redundant Braces Removed.
Used auto.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49890
Files:
ClangTidy.cpp
Index: ClangTidy.cpp
===
TheAhmad accepted this revision.
TheAhmad marked 3 inline comments as done.
TheAhmad added a comment.
This revision is now accepted and ready to land.
Thanks Eugene!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49890
___
cfe-commi
Eugene.Zelenko added inline comments.
Comment at: ClangTidy.cpp:612
+
+ FileManager *Files = new FileManager(FileSystemOptions());
+ vfs::FileSystem &FileSystem = *Files->getVirtualFileSystem();
You could use auto here, because type is in new statement.
=
mclow.lists closed this revision.
mclow.lists added a comment.
Landed as r337804.
https://reviews.llvm.org/D49338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
greened created this revision.
greened added reviewers: sbc100, sunfish.
Herald added subscribers: cfe-commits, aheejin, jgravelle-google, dschuff.
lld is the only supported linker that works for WebAssembly, so ensure clang is
using it for this test. This gets the tests passing when configuring
greened created this revision.
greened added reviewers: jroelofs, hans, probinson, ismail, rtrieu.
Herald added a subscriber: cfe-commits.
This test fails if clang is configure with, for example, gold as the default
linker. It does not appear that this test really relies on lld so make the
chec
arphaman added a comment.
In https://reviews.llvm.org/D49758#1174629, @ilya-biryukov wrote:
> The mode of operation where compile commands come from the client seems
> useful, but I wonder if there's any value in mixing it with
> `compile_commands.json` and other CDB plugins.
> Do you plan to
arphaman added inline comments.
Comment at: clangd/Protocol.h:429
+ // The changes that happened to the compilation database.
+ llvm::Optional>>
+ compilationDatabaseChanges;
ilya-biryukov wrote:
> - Maybe add a comment that the key of the map is a file na
greened created this revision.
greened added reviewers: phosek, rsmith.
Herald added subscribers: cfe-commits, dexonsmith, mehdi_amini.
These tests don't appear to depend on lld. They are invoking lto, so we should
ensure the linker is capable of that. Therefore, allow gold in addition to lld
Copied:
libcxx/trunk/test/std/input.output/filesystems/class.path/path.nonmember/path.factory.pass.cpp
(from r338006,
libcxx/trunk/test/std/experimental/filesystem/class.path/path.nonmember/path.factory.pass.cpp)
URL:
http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/input.output/filesy
rsmith added inline comments.
Comment at: docs/ReleaseNotes.rst:49-51
+- A new Implicit Cast Sanitizer (``-fsanitize=implicit-cast``) group was added.
+ Please refer to the :ref:`release-notes-ubsan` section of the release notes
+ for the details.
Regarding the
Author: ericwf
Date: Thu Jul 26 20:16:02 2018
New Revision: 338094
URL: http://llvm.org/viewvc/llvm-project?rev=338094&view=rev
Log:
Correctly mark the Filesystem status as complete.
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.html
URL:
http://llvm.o
Author: ericwf
Date: Thu Jul 26 20:42:58 2018
New Revision: 338095
URL: http://llvm.org/viewvc/llvm-project?rev=338095&view=rev
Log:
Attempt to unbreak *all the bots*
The bots were failing to build the cxx_filesystem target, so the
tests were failing. Though this does lead me to wonder how it
was
Author: ericwf
Date: Thu Jul 26 20:47:46 2018
New Revision: 338096
URL: http://llvm.org/viewvc/llvm-project?rev=338096&view=rev
Log:
Add libc++fs to the test deps, and not to the target 'cxx'.
Modified:
libcxx/trunk/lib/CMakeLists.txt
libcxx/trunk/test/CMakeLists.txt
Modified: libcxx/tru
Author: sqlbyme
Date: Thu Jul 26 21:41:37 2018
New Revision: 338098
URL: http://llvm.org/viewvc/llvm-project?rev=338098&view=rev
Log:
[WWW] Fixing file permissions for the .html pages.
Modified:
cfe/trunk/www/OpenProjects.html (props changed)
cfe/trunk/www/UniversalDriver.html (props
Rakete updated this revision to Diff 157642.
Rakete added a comment.
Addressed review comments.
Note that clang doesn't support the fourth kind of lambda yet ([]<>), because
https://reviews.llvm.org/D36527 hasn't been merged yet, so I didn't add a test
case for that one.
Repository:
sepavloff updated this revision to Diff 157643.
sepavloff added a comment.
Updated patch
Added names for boolean arguments, renamed a field in AggValueSlot.
No functional changes.
Repository:
rC Clang
https://reviews.llvm.org/D49589
Files:
lib/CodeGen/CGClass.cpp
lib/CodeGen/CGExprCXX.c
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: test/clang-tidy/fuchsia-multiple-inheritance-crash.cpp:1
+// RUN: clang-tidy -checks='fuchsia-multiple-inheritance' %s --
+template
nit: i
phosek requested changes to this revision.
phosek added a comment.
This revision now requires changes to proceed.
We don't actively support gold in Fuchsia driver and currently have no plans on
doing so. We should instead modify the driver to always use lld even if gold is
set as the default Cla
Author: ericwf
Date: Thu Jul 26 23:12:46 2018
New Revision: 338103
URL: http://llvm.org/viewvc/llvm-project?rev=338103&view=rev
Log:
Move Filesystem namespace definition out of a clang specific ifdef block.
Modified:
libcxx/trunk/include/__config
Modified: libcxx/trunk/include/__config
URL:
101 - 196 of 196 matches
Mail list logo
