[PATCH] D45124: [CodeGen] Record if a C++ record is a trivial type when emitting Codeview

rnk added inline comments. Comment at: CodeGen/CGDebugInfo.cpp:2842-2843 + +// When emitting codeview, record if a C++ record is trivial type. +if (CGM.getCodeGenOpts().EmitCodeView) { + if (CXXRD->isTrivial()) I think we might as well set it when em

[PATCH] D49606: [ms] Add __shiftleft128 / __shiftright128 intrinsics

thakis closed this revision. thakis added a comment. r337619, thanks! The hoisting point is a good one; will rewrite using funnelshift once that's possible :-) https://reviews.llvm.org/D49606 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r337620 - fix typo

Author: nico Date: Fri Jul 20 14:06:41 2018 New Revision: 337620 URL: http://llvm.org/viewvc/llvm-project?rev=337620&view=rev Log: fix typo Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/trunk/docs/ReleaseNotes.rst URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/docs/ReleaseNote

Re: r337381 - Mention clang-cl improvements from r335466 and r336379 in ReleaseNotes.rst

Fixed in 337620, thanks! On Wed, Jul 18, 2018 at 3:55 PM Kim Gräsman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > This is lovely! Found a bit inline... > > On Wed, Jul 18, 2018, 14:00 Nico Weber via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: nico >> Date: Wed Jul 18

[PATCH] D49523: [clangd] Add support for per-file override compilation command

arphaman added a comment. In https://reviews.llvm.org/D49523#1169621, @jkorous wrote: > Alex, I am just wondering if we shouldn't rather create another > implementation of GlobalCompilationDatabase interface (something like > InMemoryGlobalCompilationDatabase), add it to ClangdServer and use it

RE: r337540 - Sema: Fix explicit address space cast in C++

From: Richard Smith [mailto:rich...@metafoo.co.uk] Sent: Friday, July 20, 2018 3:29 PM To: Liu, Yaxun (Sam) Cc: cfe-commits Subject: Re: r337540 - Sema: Fix explicit address space cast in C++ On Fri, 20 Jul 2018 at 12:00, Richard Smith mailto:rich...@metafoo.co.uk>> wrote: On Fri, 20 Jul 2018

[PATCH] D49573: [CMake] Option to control whether shared/static library is installed

phosek added a comment. In https://reviews.llvm.org/D49573#1169615, @ldionne wrote: > I don't like the fact that we're adding options like crazy, thus making the > build more complicated. If you don't want to have some libraries that were > built, why not just remove them afterwards? The moti

[PATCH] D48759: [ASTMatchers] add matcher for decltypeType and its underlyingType

JonasToth updated this revision to Diff 156609. JonasToth marked an inline comment as done. JonasToth added a comment. - [Misc] add test and more doc - Merge branch 'master' into matcher_decltypetype Repository: rC Clang https://reviews.llvm.org/D48759 Files: include/clang/ASTMatchers/ASTM

[PATCH] D48714: [clang-tidy] fix PR37913, templated exception factory diagnosed correctly

JonasToth added inline comments. Comment at: test/clang-tidy/hicpp-exception-baseclass.cpp:191 +void templated_thrower() { throw T{}(); } +// CHECK-MESSAGES: [[@LINE-1]]:34: warning: throwing an exception whose type 'int' is not derived from 'std::exception' + a

[PATCH] D48717: [clang-tidy] fix PR36489 - respect deduced pointer types from auto as well

JonasToth added a comment. > I don't think we want to modify `hasType()` -- that would strip off too much > type information if it automatically reached through to the underlying type. > However, we may want to consider adding something like `hasUnderlyingType()` > that checks the matcher again

[PATCH] D49618: [clang-tidy] remove private decltypeType in TrailingReturnType

JonasToth created this revision. JonasToth added reviewers: aaron.ballman, alexfh, hokein. Herald added subscribers: cfe-commits, xazax.hun. This patch removes a private matcher in fuchsia/TrailingReturnType check because the matcher is now in ASTMatchers Repository: rCTE Clang Tools Extra ht

[PATCH] D48559: [clangd] refactoring for XPC transport layer [NFCI]

arphaman added a comment. In https://reviews.llvm.org/D48559#1169975, @sammccall wrote: > Sorry for the delay here, and I'm sorry I haven't been into the patches in > detail again yet - crazy week. After experiments, I am convinced the > Transport abstraction patch can turn into something nice

[PATCH] D48287: [HIP] Support -fcuda-flush-denormals-to-zero for amdgcn

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Thank you. That should work. https://reviews.llvm.org/D48287 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

r337627 - Fold dangling-field warning into general initialization lifetime checks.

Author: rsmith Date: Fri Jul 20 15:25:55 2018 New Revision: 337627 URL: http://llvm.org/viewvc/llvm-project?rev=337627&view=rev Log: Fold dangling-field warning into general initialization lifetime checks. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td cfe/trunk/lib/Sema/S

[PATCH] D15225: [Driver] Sanitizer support based on runtime library presence

delcypher added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.h:425 + /// \return Relative path to the filename for the library + /// containing the sanitizer {@code SanitizerName}. You might want to update that comment to not mention "Relat

[PATCH] D15225: [Driver] Sanitizer support based on runtime library presence

delcypher added a comment. @george.karpenkov Other than the comment that probably needs updating, LGTM. https://reviews.llvm.org/D15225 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

r337629 - Disable clang crash-report-modules.m test on Windows again

Author: rnk Date: Fri Jul 20 15:36:33 2018 New Revision: 337629 URL: http://llvm.org/viewvc/llvm-project?rev=337629&view=rev Log: Disable clang crash-report-modules.m test on Windows again It still appears to be failing: http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/12825 $

[PATCH] D46919: [libclang] Deprecate CXPrintingPolicy_IncludeTagDefinition

jdenny updated this revision to Diff 156620. jdenny added a comment. Ping. Rebased. https://reviews.llvm.org/D46919 Files: clang/include/clang-c/Index.h clang/include/clang/AST/PrettyPrinter.h clang/lib/AST/DeclPrinter.cpp clang/lib/AST/TypePrinter.cpp clang/tools/c-index-test/c-inde

[libcxx] r337630 - [CMake] Install C++ ABI headers into the right location

Author: phosek Date: Fri Jul 20 15:45:24 2018 New Revision: 337630 URL: http://llvm.org/viewvc/llvm-project?rev=337630&view=rev Log: [CMake] Install C++ ABI headers into the right location This is a follow-up to r335809 and r337118. While libc++ headers are now installed into the right location i

[PATCH] D49083: [HIP] Register/unregister device fat binary only once

This revision was automatically updated to reflect the committed changes. Closed by commit rC337631: [HIP] Register/unregister device fat binary only once (authored by yaxunl, committed by ). Repository: rC Clang https://reviews.llvm.org/D49083 Files: lib/CodeGen/CGCUDANV.cpp test/CodeGen

[PATCH] D49584: [CMake] Install C++ ABI headers into the right location

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL337630: [CMake] Install C++ ABI headers into the right location (authored by phosek, committed by ). Herald added a subscr

r337631 - [HIP] Register/unregister device fat binary only once

Author: yaxunl Date: Fri Jul 20 15:45:24 2018 New Revision: 337631 URL: http://llvm.org/viewvc/llvm-project?rev=337631&view=rev Log: [HIP] Register/unregister device fat binary only once HIP generates one fat binary for all devices after linking. However, for each compilation unit a ctor functio

[PATCH] D48743: Make pthread's __libcpp_get_tls declaration consistent

pirama added a comment. Ping... Repository: rCXX libc++ https://reviews.llvm.org/D48743 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D48742: Set _LIBCPP_TLS_DESTRUCTOR_CC convention to run_dtors

pirama added a comment. Ping... Repository: rCXXA libc++abi https://reviews.llvm.org/D48742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47849: [OpenMP][Clang][NVPTX] Enable math functions called in an OpenMP NVPTX target device region to be resolved as device-native function calls

tra added a comment. In https://reviews.llvm.org/D47849#1126925, @gtbercea wrote: > I just stumbled upon a very interesting situation. > > I noticed that, for OpenMP, the use of device math functions happens as I > expected for -O0. For -O1 or higher math functions such as "sqrt" resolve to > l

[PATCH] D49511: [Sema/Attribute] Check for noderef attribute

leonardchan updated this revision to Diff 156634. leonardchan marked 2 inline comments as done. Repository: rC Clang https://reviews.llvm.org/D49511 Files: include/clang/AST/Type.h include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/DiagnosticGroups.td inc

[PATCH] D49511: [Sema/Attribute] Check for noderef attribute

leonardchan added a comment. In https://reviews.llvm.org/D49511#1168692, @rsmith wrote: > The way in which you're checking for the problematic cases is unnecessarily > expensive. Instead of performing a separate AST traversal, please detect > whether you should be producing the warning directly

r337635 - [Driver] Sanitizer support based on runtime library presence

Author: george.karpenkov Date: Fri Jul 20 16:34:39 2018 New Revision: 337635 URL: http://llvm.org/viewvc/llvm-project?rev=337635&view=rev Log: [Driver] Sanitizer support based on runtime library presence The runtime libraries of sanitizers are built in compiler-rt, and Clang can be built without

[PATCH] D15225: [Driver] Sanitizer support based on runtime library presence

This revision was automatically updated to reflect the committed changes. Closed by commit rL337635: [Driver] Sanitizer support based on runtime library presence (authored by george.karpenkov, committed by ). Changed prior to commit: https://reviews.llvm.org/D15225?vs=156603&id=156639#toc Repo

r337636 - [NFC] CodeGen: rename memset to bzero

Author: jfb Date: Fri Jul 20 16:37:12 2018 New Revision: 337636 URL: http://llvm.org/viewvc/llvm-project?rev=337636&view=rev Log: [NFC] CodeGen: rename memset to bzero The optimization looks for opportunities to emit bzero, not memset. Rename the functions accordingly (and clang-format the diff)

[PATCH] D49627: [CFG] [analyzer] Constructors of member CXXOperatorCallExpr's argument 0 are not argument constructors.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet, rnkovacs, baloghadamsoftware. Herald added subscribers: cfe-commits, mikhail.ramalho. Because `CXXOperatorCallExpr`'s argument 0 is the `this`-argument of the operator if the operator is a

[PATCH] D46140: [coroutines] std::task type (WIP)

lewissbaker updated this revision to Diff 156641. lewissbaker edited the summary of this revision. lewissbaker added a comment. - Make `task` constructor from `coroutine_handle` private. - Run clang-format over . https://reviews.llvm.org/D46140 Files: include/CMakeLists.txt include/experime

[PATCH] D49628: [CMake] Link static libunwind and libc++abi into libc++ in Fuchsia toolchain

phosek created this revision. phosek added reviewers: mcgrathr, juliehockett, jakehehrlich. Herald added subscribers: cfe-commits, chrib, mgorny. Herald added a reviewer: EricWF. When building libc++ for Fuchsia, we want to distribute shared libc++, libc++abi and libunwind as separate libraries, b

r337639 - [HIP] Support -fcuda-flush-denormals-to-zero for amdgcn

Author: yaxunl Date: Fri Jul 20 19:02:22 2018 New Revision: 337639 URL: http://llvm.org/viewvc/llvm-project?rev=337639&view=rev Log: [HIP] Support -fcuda-flush-denormals-to-zero for amdgcn Differential Revision: https://reviews.llvm.org/D48287 Modified: cfe/trunk/include/clang/Basic/LangOpti

[PATCH] D48287: [HIP] Support -fcuda-flush-denormals-to-zero for amdgcn

This revision was automatically updated to reflect the committed changes. Closed by commit rC337639: [HIP] Support -fcuda-flush-denormals-to-zero for amdgcn (authored by yaxunl, committed by ). Repository: rC Clang https://reviews.llvm.org/D48287 Files: include/clang/Basic/LangOptions.def

[PATCH] D49629: [CMake] Fix the setting of LIBCXX_HEADER_DIR

aheejin created this revision. aheejin added a reviewer: phosek. Herald added subscribers: cfe-commits, ldionne, christof, mgorny. Repository: rCXX libc++ https://reviews.llvm.org/D49629 Files: CMakeLists.txt Index: CMakeLists.txt ===

[PATCH] D49629: [CMake] Fix the setting of LIBCXX_HEADER_DIR

aheejin added a comment. This line was added in https://reviews.llvm.org/rL335809, and after https://reviews.llvm.org/rL337630 `dst` in this line is set to NULL in our

[PATCH] D45124: [CodeGen] Record if a C++ record is a trivial type when emitting Codeview

asmith updated this revision to Diff 156664. https://reviews.llvm.org/D45124 Files: lib/CodeGen/CGDebugInfo.cpp Index: lib/CodeGen/CGDebugInfo.cpp === --- lib/CodeGen/CGDebugInfo.cpp +++ lib/CodeGen/CGDebugInfo.cpp @@ -2847,6 +28

<    1   2