Author: sammccall
Date: Fri Jul 20 01:01:37 2018
New Revision: 337527
URL: http://llvm.org/viewvc/llvm-project?rev=337527&view=rev
Log:
[clangd] FuzzyMatch exposes an API for its word segmentation. NFC
Summary: This is intended to be used for indexing, e.g. in D49417
Reviewers: ioeric, omtcyfz
This revision was automatically updated to reflect the committed changes.
Closed by commit rL337527: [clangd] FuzzyMatch exposes an API for its word
segmentation. NFC (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D
Author: ioeric
Date: Fri Jul 20 01:08:56 2018
New Revision: 337529
URL: http://llvm.org/viewvc/llvm-project?rev=337529&view=rev
Log:
[Index] Set OrigD before D is changed.
Reviewers: akyrtzi, arphaman
Reviewed By: akyrtzi
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rL337529: [Index] Set OrigD before D is changed. (authored by
ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D49476
Files:
cfe/trunk/lib/
Author: maskray
Date: Fri Jul 20 01:19:20 2018
New Revision: 337530
URL: http://llvm.org/viewvc/llvm-project?rev=337530&view=rev
Log:
Change \t to spaces
Modified:
cfe/trunk/include/clang-c/BuildSystem.h
cfe/trunk/include/clang/Basic/Attr.td
cfe/trunk/include/clang/Basic/DiagnosticSem
omtcyfz updated this revision to Diff 156443.
omtcyfz marked 35 inline comments as done.
omtcyfz added a comment.
Addressed most comments (aside from reusing fuzzy matching segmentation routine
and making data + hash a separate structure).
Since I already submitted my next revision (https://revi
omtcyfz added inline comments.
Comment at: clang-tools-extra/clangd/index/noctem/SearchAtom.h:53
+ SearchAtom(llvm::StringRef Data, Namespace Type = Namespace::Trigram)
+ : Data(Data), Hash(std::hash{}(Data)), Type(Type) {}
+
ioeric wrote:
> ioeric wrote:
>
kbobyrev created this revision.
kbobyrev added reviewers: ioeric, sammccall.
kbobyrev added a project: clang-tools-extra.
Herald added subscribers: arphaman, jkorous, MaskRay, mgorny.
This patch introduces trigram generation algorithm for the symbol index
proposed in a recent design document.
RFC
Author: ericwf
Date: Fri Jul 20 01:36:45 2018
New Revision: 337532
URL: http://llvm.org/viewvc/llvm-project?rev=337532&view=rev
Log:
adjust incorrect comment
Modified:
libcxx/trunk/src/experimental/filesystem/operations.cpp
Modified: libcxx/trunk/src/experimental/filesystem/operations.cpp
UR
kbobyrev planned changes to this revision.
kbobyrev added a comment.
The upcoming changes:
- Use segmentation API exposed in https://reviews.llvm.org/rL337527
- Create a separate structure for Data and Hash as suggested by Sam
- Fix the bug with whole segments concatenation
https://reviews.llvm
lichray added a comment.
Ping. Any more comments?
Repository:
rCXX libc++
https://reviews.llvm.org/D41458
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
JDevlieghere created this revision.
JDevlieghere added reviewers: labath, dblaikie, probinson.
Currently, support for debug_types is only present for ELF and trying to pass
-fdebug-types-section for other targets results in a crash in the backend.
Until this is fixed, we should emit a diagnostic
CarlosAlbertoEnciso updated this revision to Diff 156456.
CarlosAlbertoEnciso added a comment.
Used `clang-format-diff` as indicated by @probinson:
- The lib and include files follow the clang format.
- The tests mostly follow the clang format. I removed some extra formatting
which was introduce
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D49274
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
JDevlieghere added a comment.
Please see PR38190 for more details.
Repository:
rC Clang
https://reviews.llvm.org/D49594
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
CarlosAlbertoEnciso updated this revision to Diff 156460.
CarlosAlbertoEnciso marked an inline comment as done.
CarlosAlbertoEnciso added a comment.
A minor modification to allow the comments for `MarkNamespaceAliasReferenced`
to be picked up by doxygen.
https://reviews.llvm.org/D46190
Files:
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/index/dex/Token.cpp:25
+ Data.size() == 3 && "Trigram should contain three characters.");
+ switch (TokenKind) {
+ case Kind::Trigram:
specializing the hash function looks like premat
ikudrin added a comment.
You may want to add a test for placement new, no?
Repository:
rC Clang
https://reviews.llvm.org/D49589
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lebedev.ri updated this revision to Diff 156465.
lebedev.ri retitled this revision from "[Sema]
Expr::skipRValueSubobjectAdjustments(): record skipped NoOp casts." to "[Sema]
Mark implicitly-inserted ICE's as being part of explicit cast (PR38166)".
lebedev.ri edited the summary of this revision.
Author: yaxunl
Date: Fri Jul 20 04:32:51 2018
New Revision: 337540
URL: http://llvm.org/viewvc/llvm-project?rev=337540&view=rev
Log:
Sema: Fix explicit address space cast in C++
Currently clang does not allow implicit cast of a pointer to a pointer type
in different address space but allows C-sty
This revision was automatically updated to reflect the committed changes.
Closed by commit rL337540: Sema: Fix explicit address space cast in C++
(authored by yaxunl, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D49294?vs=156403&id=1
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/index/dex/Trigram.cpp:37
+
+ // Extract trigrams consisting of first characters of tokens sorted bytoken
+ // positions. Trigram generator is allowed to skip 1 word between each token.
sammcc
labath added a comment.
I believe debug_types is used on non-linux targets as well. Judging by the
other review all ELF targets should at least have a chance of working, so maybe
key the error off of that?
Repository:
rC Clang
https://reviews.llvm.org/D49594
_
ldionne added a comment.
LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D49502
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lebedev.ri updated this revision to Diff 156470.
lebedev.ri marked 6 inline comments as done.
lebedev.ri added a comment.
Rebased ontop of yet-again rewritten https://reviews.llvm.org/D49508.
Addressed all @vsk's review notes.
More review notes wanted :)
Repository:
rC Clang
https://reviews.
lebedev.ri added inline comments.
Comment at: docs/UndefinedBehaviorSanitizer.rst:134
+ integer promotions, as those may result in an unexpected computation
+ results, even though no overflow happens (signed or unsigned).
- ``-fsanitize=unreachable``: If control flow
ldionne added a comment.
I don't like the fact that we're adding options like crazy, thus making the
build more complicated. If you don't want to have some libraries that were
built, why not just remove them afterwards?
Repository:
rL LLVM
https://reviews.llvm.org/D49573
jkorous added a comment.
Hi Marc-Andre, what is a structure of data you are passing as parameter of
didChangeConfiguration message? All we need is to pass per-file compilation
command to clangd. Maybe we could send didChangeConfiguration message right
after didOpen.
Repository:
rCTE Clang T
jkorous added a comment.
Alex, I am just wondering if we shouldn't rather create another implementation
of GlobalCompilationDatabase interface (something like
InMemoryGlobalCompilationDatabase), add it to ClangdServer and use it as the
first place to be searched in ClangdServer::getCompileComma
JDevlieghere updated this revision to Diff 156471.
JDevlieghere added a comment.
Thanks, I meant to use `isOSBinFormatELF` but I think it got lost in an
accidental undo. The test didn't capture that because it's using a linux target
triple.
https://reviews.llvm.org/D49594
Files:
clang/lib/D
jkorous added a comment.
Hi Sam, we discussed a bit more with Alex offline. Ultimately we don't mind
using JSON as part of the generic interface but we'd like to optimize specific
cases in the future (thinking only about code completion so far) which might
need to "work-around" the abstraction.
jkorous added a comment.
BTW Just for the record - I put the rebased & updated patch here: [clangd] XPC
WIP https://reviews.llvm.org/D49548
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48560
___
cfe-commits mailing list
cfe-commi
jkorous added a comment.
BTW Just for the record - I put the rebased & updated patch here: [clangd] XPC
WIP https://reviews.llvm.org/D49548
https://reviews.llvm.org/D48562
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
jkorous added a comment.
BTW Just for the record - I put the rebased & updated patch here: [clangd] XPC
WIP https://reviews.llvm.org/D49548
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48559
___
cfe-commits mailing list
cfe-commi
ldionne added a comment.
This change LGTM. However, I do have a question about the overall change
(including r335809 and r337118). Why is it that we're not simply relying on the
`CMAKE_INSTALL_PREFIX` being set to the path where we should install instead of
using all these custom variables lik
thakis created this revision.
thakis added a reviewer: zturner.
If QMM_Result is set (which it is for return types, RTTI descriptors, and
exception type descriptors), tag types (structs, enums, classes, unions) get
their qualifiers mangled in.
__m64 and friends is a struct/union thingy in MSVC,
thakis added a comment.
If you want to compare the CHECK lines to MSVC's output:
https://godbolt.org/g/Cvf4p4
https://reviews.llvm.org/D49597
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
Author: erichkeane
Date: Fri Jul 20 07:13:28 2018
New Revision: 337552
URL: http://llvm.org/viewvc/llvm-project?rev=337552&view=rev
Log:
Implement cpu_dispatch/cpu_specific Multiversioning
As documented here: https://software.intel.com/en-us/node/682969 and
https://software.intel.com/en-us/node/5
This revision was automatically updated to reflect the committed changes.
Closed by commit rC337552: Implement cpu_dispatch/cpu_specific Multiversioning
(authored by erichkeane, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D47474
Files:
include/clang/AST/Decl.h
include/cl
kbobyrev updated this revision to Diff 156483.
kbobyrev marked 9 inline comments as done.
kbobyrev added a comment.
- Switched from `std::shared_ptr` to `std::unique_ptr` for iterator's children:
iterators own their subtrees, the lifetime should depend on the root
- Store `PostingListRef`in `Docu
kbobyrev planned changes to this revision.
kbobyrev added a comment.
Upcoming changes:
- Improve debugging experience by providing `llvm::raw_ostream
&operator<<(llvm::raw_ostream &OS, std::unique_ptr Iterator` to
recursively pretty print queries in human-readable format: e.g. `(& [0, 1, 2,
3]
malaperle added a comment.
In https://reviews.llvm.org/D49523#1169000, @arphaman wrote:
> In https://reviews.llvm.org/D49523#1167553, @malaperle wrote:
>
> > Interesting! We also have a need for passing compilation commands in a
> > context where there is no compile_commands.json, but we were th
jkorous added a comment.
BTW it looks like we already had kind of support for compilation command before
(extra flags).
commit 5ec1f7ca32eb85077a22ce81d41aa02a017d4852
Author: Krasimir Georgiev
Date: Thu Jul 6 08:44:54 2017 +
[clangd] Add support for per-file extra flags
There is even
Author: bruno
Date: Fri Jul 20 07:46:10 2018
New Revision: 337555
URL: http://llvm.org/viewvc/llvm-project?rev=337555&view=rev
Log:
[www] Add CodeCompass and CodeChecker to Clang Related Projects page
Modified:
cfe/trunk/www/related.html
Modified: cfe/trunk/www/related.html
URL:
http://llvm
Author: rkovacs
Date: Fri Jul 20 08:14:49 2018
New Revision: 337559
URL: http://llvm.org/viewvc/llvm-project?rev=337559&view=rev
Log:
[analyzer] Rename DanglingInternalBufferChecker to InnerPointerChecker.
Differential Revision: https://reviews.llvm.org/D49553
Added:
cfe/trunk/lib/StaticAnal
This revision was automatically updated to reflect the committed changes.
Closed by commit rL337559: [analyzer] Rename DanglingInternalBufferChecker to
InnerPointerChecker. (authored by rkovacs, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.ll
probinson added a comment.
Is this because type units depend on COMDAT support? I had a vague idea that
COFF also supports COMDAT.
https://reviews.llvm.org/D49594
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/CodeComplete.h:148
bool HasMore = false;
+ CodeCompletionContext::Kind SemaContext = CodeCompletionContext::CCC_Other;
};
n
JDevlieghere added a comment.
In https://reviews.llvm.org/D49594#1169809, @probinson wrote:
> Is this because type units depend on COMDAT support? I had a vague idea that
> COFF also supports COMDAT.
It's more that I want to reflect the current situation and prevent MC from
crashing while we
thakis created this revision.
thakis added a reviewer: craig.topper.
cl.exe maps these to shld / shrd, so let's do the same. ISel has
`Subtarget->isSHLDSlow()` to prevent use of these intrinsics on some machines,
but honoring them feels a bit like trying to outsmart the intrinsics user, and
the
Author: zturner
Date: Fri Jul 20 09:30:02 2018
New Revision: 337572
URL: http://llvm.org/viewvc/llvm-project?rev=337572&view=rev
Log:
Rewrite the VS integration scripts.
This is a new modernized VS integration installer. It adds a
Visual Studio .sln file which, when built, outputs a VSIX that ca
This revision was automatically updated to reflect the committed changes.
Closed by commit rC337572: Rewrite the VS integration scripts. (authored by
zturner, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://reviews.llvm.org/D42762?vs=156387&id=156520#toc
craig.topper added a comment.
@spatel, should this ultimately use funnel shift?
https://reviews.llvm.org/D49606
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sammccall added a comment.
Sorry for the delay here, and I'm sorry I haven't been into the patches in
detail again yet - crazy week. After experiments, I am convinced the Transport
abstraction patch can turn into something nice **if** we want XPC vs JSON to be
a pure transport-level difference
Author: ahatanak
Date: Fri Jul 20 10:10:32 2018
New Revision: 337580
URL: http://llvm.org/viewvc/llvm-project?rev=337580&view=rev
Log:
[CodeGen][ObjC] Make copying and disposing of a non-escaping block
no-ops.
A non-escaping block on the stack will never be called after its
lifetime ends, so it d
This revision was automatically updated to reflect the committed changes.
ahatanak marked an inline comment as done.
Closed by commit rL337580: [CodeGen][ObjC] Make copying and disposing of a
non-escaping block (authored by ahatanak, committed by ).
Herald added a subscriber: llvm-commits.
Change
probinson accepted this revision.
probinson added a comment.
This revision is now accepted and ready to land.
If the plan is for this to be relatively temporary then LGTM.
https://reviews.llvm.org/D49594
___
cfe-commits mailing list
cfe-commits@list
Author: zturner
Date: Fri Jul 20 10:16:49 2018
New Revision: 337582
URL: http://llvm.org/viewvc/llvm-project?rev=337582&view=rev
Log:
Merge changes to ItaniumDemangle over to libcxxabi.
ItaniumDemangle had a small NFC refactor to make some of its
code reusable by the newly added Microsoft demangl
Author: erichkeane
Date: Fri Jul 20 10:42:09 2018
New Revision: 337585
URL: http://llvm.org/viewvc/llvm-project?rev=337585&view=rev
Log:
Prevent Scoped Enums from being Integral constant expressions:
Discovered because of: https://bugs.llvm.org/show_bug.cgi?id=38235
It seems to me that a scoped
Author: tra
Date: Fri Jul 20 10:44:34 2018
New Revision: 337587
URL: http://llvm.org/viewvc/llvm-project?rev=337587&view=rev
Log:
[CUDA] Provide integer SIMD functions for CUDA-9.2
CUDA-9.2 made all integer SIMD functions into compiler builtins,
so clang no longer has access to the implementation
This revision was automatically updated to reflect the committed changes.
tra marked 2 inline comments as done.
Closed by commit rC337587: [CUDA] Provide integer SIMD functions for CUDA-9.2
(authored by tra, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D49274?vs=156397&id=1
erik.pilkington added a comment.
Ping!
https://reviews.llvm.org/D46845
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
george.karpenkov added a comment.
@delcypher sorry i don't agree with the change requests.
@mracek any comments?
Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:2298
SanitizerMask Res = ToolChain::getSupportedSanitizers();
- Res |= SanitizerKind::Address;
- Res |= Sanit
rjmccall added inline comments.
Comment at: include/clang/AST/Stmt.h:205
unsigned Kind : 6;
-unsigned BasePathSize : 32 - 6 - NumExprBits;
+bool PartOfExplicitCast : 1;
+unsigned BasePathSize : 32 - 6 - 1 - NumExprBits;
This needs to be `unsigned
arphaman added a comment.
In https://reviews.llvm.org/D49523#1169743, @jkorous wrote:
> BTW it looks like we already had kind of support for compilation command
> before (extra flags).
>
> commit 5ec1f7ca32eb85077a22ce81d41aa02a017d4852
> Author: Krasimir Georgiev
> Date: Thu Jul 6 08:44:54
lebedev.ri added inline comments.
Comment at: include/clang/AST/Stmt.h:206
+bool PartOfExplicitCast : 1;
+unsigned BasePathSize : 32 - 6 - 1 - NumExprBits;
};
rjmccall wrote:
> This needs to be serialized.
Uhm, could you please explain what do you mean
rjmccall added inline comments.
Comment at: include/clang/AST/Stmt.h:206
+bool PartOfExplicitCast : 1;
+unsigned BasePathSize : 32 - 6 - 1 - NumExprBits;
};
lebedev.ri wrote:
> rjmccall wrote:
> > This needs to be serialized.
> Uhm, could you please ex
Author: d0k
Date: Fri Jul 20 11:45:25 2018
New Revision: 337601
URL: http://llvm.org/viewvc/llvm-project?rev=337601&view=rev
Log:
[clangd] Fix racy use-after-scope in unittest
This only shows up with asan when the stars align in a bad way.
Modified:
clang-tools-extra/trunk/unittests/clangd/T
Author: juliehockett
Date: Fri Jul 20 11:49:55 2018
New Revision: 337602
URL: http://llvm.org/viewvc/llvm-project?rev=337602&view=rev
Log:
[clang-doc] Adding PublicOnly flag
Submitted on behalf of Annie Cherkaev (@anniecherk)
Added a flag which, when enabled, documents only those methods and
fie
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE337602: [clang-doc] Adding PublicOnly flag (authored by
juliehockett, committed by ).
Herald added a subscriber: arphaman.
Changed prior to commit:
https://reviews.llvm.org/D48395?vs=154470&id=156562#
On Fri, 20 Jul 2018 at 04:38, Yaxun Liu via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: yaxunl
> Date: Fri Jul 20 04:32:51 2018
> New Revision: 337540
>
> URL: http://llvm.org/viewvc/llvm-project?rev=337540&view=rev
> Log:
> Sema: Fix explicit address space cast in C++
>
> Currently
phosek added a subscriber: beanz.
phosek added a comment.
We currently support two different layouts:
1. The standard layout (for a lack of a better name) which is used when libc++
is built standalone as well as being built as part of LLVM without any other
options which is `$DESTDIR/include/c+
delcypher added inline comments.
Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:2298
SanitizerMask Res = ToolChain::getSupportedSanitizers();
- Res |= SanitizerKind::Address;
- Res |= SanitizerKind::Leak;
- Res |= SanitizerKind::Fuzzer;
- Res |= SanitizerKind::FuzzerNo
lewissbaker updated this revision to Diff 156565.
lewissbaker added a comment.
Herald added subscribers: cfe-commits, ldionne, mgorny.
Many improvements:
- Remove move-assignment operator
- `task::operator co_await()` now returns by value when awaiting `task`
rvalue.
- Explicitly scope calls to
On Fri, 20 Jul 2018 at 12:00, Richard Smith wrote:
> On Fri, 20 Jul 2018 at 04:38, Yaxun Liu via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: yaxunl
>> Date: Fri Jul 20 04:32:51 2018
>> New Revision: 337540
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=337540&view=rev
>> L
craig.topper added a comment.
Here are the IR patterns for this that work. Not sure if we can do this
directly in C, we need a 128 bit type, but maybe we can emit it from
CGBuiltin.cpp?
define i64 @__shiftleft128(i64 %x, i64 %y, i8 %amt) {
%a = zext i64 %x to i128
%b = zext i64 %y to
lebedev.ri updated this revision to Diff 156568.
lebedev.ri marked 4 inline comments as done.
lebedev.ri added a comment.
- Use `unsigned`, not bool.
- Serialization, although without tests, and likely incompatible with previous
versions.
Repository:
rC Clang
https://reviews.llvm.org/D49508
lebedev.ri added inline comments.
Comment at: include/clang/AST/Stmt.h:206
+bool PartOfExplicitCast : 1;
+unsigned BasePathSize : 32 - 6 - 1 - NumExprBits;
};
rjmccall wrote:
> lebedev.ri wrote:
> > rjmccall wrote:
> > > This needs to be serialized.
>
acoomans updated this revision to Diff 156571.
acoomans retitled this revision from "[WIP] Change clang-format to absolute
indentation" to "[clang-format] Adding style option for absolute formatting".
acoomans edited the summary of this revision.
https://reviews.llvm.org/D49580
Files:
docs/Cla
bricci added a comment.
@bkramer Thanks for the review! Can you commit it for my since I can not do it
myself?
Repository:
rC Clang
https://reviews.llvm.org/D49302
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
thakis added a comment.
We have __int128. If you think hitting the pattern is preferable to inline asm,
I can try to give that a try, either via C or via CGBuiltin.cpp.
https://reviews.llvm.org/D49606
___
cfe-commits mailing list
cfe-commits@lists.
ABataev updated this revision to Diff 156575.
ABataev added a comment.
Added checks for all possible debug options.
Repository:
rC Clang
https://reviews.llvm.org/D49148
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Basic/DiagnosticGroups.td
include/clang/Driver/Tool
Author: d0k
Date: Fri Jul 20 13:13:08 2018
New Revision: 337607
URL: http://llvm.org/viewvc/llvm-project?rev=337607&view=rev
Log:
[AST] Various micro-optimizations in CXXInheritance
1. Pack std::pair in CXXBasePaths::ClassSubobjects.
2. Use a SmallPtrSet instead of a SmallDenseSet for
CXXBasePat
This revision was automatically updated to reflect the committed changes.
Closed by commit rL337607: [AST] Various micro-optimizations in CXXInheritance
(authored by d0k, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D49302?vs=155392&
craig.topper added a comment.
I'd prefer the pattern over inline assembly. It'll give us more flexibility in
the backend if we should be using some other instruction on different targets.
https://reviews.llvm.org/D49606
___
cfe-commits mailing list
spatel added a comment.
In https://reviews.llvm.org/D49606#1170278, @craig.topper wrote:
> Here are the IR patterns for this that work. Not sure if we can do this
> directly in C, we need a 128 bit type, but maybe we can emit it from
> CGBuiltin.cpp?
>
> define i64 @__shiftleft128(i64 %x, i64
thakis updated this revision to Diff 156596.
thakis edited the summary of this revision.
https://reviews.llvm.org/D49606
Files:
clang/lib/Headers/intrin.h
clang/test/Headers/ms-intrin.cpp
Index: clang/test/Headers/ms-intrin.cpp
===
thakis added a comment.
Now with C builtins which get nicely optimized.
https://reviews.llvm.org/D49606
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: devnexen
Date: Fri Jul 20 13:39:49 2018
New Revision: 337611
URL: http://llvm.org/viewvc/llvm-project?rev=337611&view=rev
Log:
[CStringSyntaxChecker] Fix build bot builds != x86 archs
Reviewers: NoQ,george.karpenkov
Reviewed By: NoQ
Differential Revision: https://reviews.llvm.org/D49588
Author: kzhuravl
Date: Fri Jul 20 13:46:25 2018
New Revision: 337612
URL: http://llvm.org/viewvc/llvm-project?rev=337612&view=rev
Log:
AMDGPU: Switch default dwarf version to 2
There were some problems unearthed with version 5,
which I am going to look at.
Differential Revision: https://reviews.
craig.topper added a comment.
@spatel, yes its exactly funnel shift. I wasn't sure if we were ready for clang
to create it yet or not. Can we let this go as is and change it to funnel shift
once we have the variable case fixed in the backend?
https://reviews.llvm.org/D49606
thakis added a comment.
Isn't implementing this in plain old C the nicest approach anyhow, even once
funnel shift exists?
https://reviews.llvm.org/D49606
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
george.karpenkov updated this revision to Diff 156603.
https://reviews.llvm.org/D15225
Files:
clang/lib/Driver/ToolChains/Darwin.cpp
clang/lib/Driver/ToolChains/Darwin.h
clang/test/Driver/Inputs/resource_dir/lib/darwin/libclang_rt.asan_ios_dynamic.dylib
clang/test/Driver/Inputs/resource
rsmith added inline comments.
Comment at: include/clang/AST/Stmt.h:206
+bool PartOfExplicitCast : 1;
+unsigned BasePathSize : 32 - 6 - 1 - NumExprBits;
};
lebedev.ri wrote:
> rjmccall wrote:
> > lebedev.ri wrote:
> > > rjmccall wrote:
> > > > This need
Author: rnk
Date: Fri Jul 20 13:55:00 2018
New Revision: 337616
URL: http://llvm.org/viewvc/llvm-project?rev=337616&view=rev
Log:
[codeview] Don't emit variable templates as class members
MSVC doesn't, so neither should we.
Fixes PR38004, which is a crash that happens when we try to emit debug
i
craig.topper added a comment.
The only weird thing that I can really think of with the C version is that the
'and' on the shift amount might get hoisted out of a loop and not get dropped
during isel.
https://reviews.llvm.org/D49606
___
cfe-commits
arphaman added a comment.
In https://reviews.llvm.org/D49523#1169728, @malaperle wrote:
> In https://reviews.llvm.org/D49523#1169000, @arphaman wrote:
>
> > In https://reviews.llvm.org/D49523#1167553, @malaperle wrote:
> >
> > > Interesting! We also have a need for passing compilation commands in
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM. I'm inclined to let this go in now since we have a requested use for it.
We can change it to funnel shift once we're confident in the backend.
https://reviews.llvm.org/D4960
spatel added a comment.
In https://reviews.llvm.org/D49606#1170448, @thakis wrote:
> Isn't implementing this in plain old C the nicest approach anyhow, even once
> funnel shift exists?
No, the primary reason for creating the intrinsic is that we can’t guarantee
that we’ll recognize the patter
Author: nico
Date: Fri Jul 20 14:02:09 2018
New Revision: 337619
URL: http://llvm.org/viewvc/llvm-project?rev=337619&view=rev
Log:
[ms] Add __shiftleft128 / __shiftright128 intrinsics
Carefully match the pattern matched by ISel so that this produces shld / shrd
(unless Subtarget->isSHLDSlow() is
1 - 100 of 138 matches
Mail list logo
