[PATCH] D15225: [Driver] Sanitizer support based on runtime library presence

george.karpenkov updated this revision to Diff 155785. george.karpenkov edited the summary of this revision. george.karpenkov edited reviewers, added: delcypher; removed: bob.wilson, glider, t.p.northover, samsonov, beanz. george.karpenkov added a comment. Attempt #2: reduced version of this patc

[PATCH] D47233: [CodeGen] Emit MSVC RTTI for Obj-C EH types

smeenai added inline comments. Comment at: lib/CodeGen/CGObjCMac.cpp:7457-7460 CGObjCNonFragileABIMac::GetEHType(QualType T) { // There's a particular fixed type info for 'id'. if (T->isObjCIdType() || T->isObjCQualifiedIdType()) { +if (CGM.getTriple().isWindowsMSVCEnv

[PATCH] D47358: : Implement {un, }synchronized_pool_resource.

Quuxplusone updated this revision to Diff 155791. Quuxplusone added a comment. Implement similar cosmetic cleanup to https://reviews.llvm.org/D47111, but for the pool resources this time. I think the argument for keeping do_allocate and do_deallocate in the .cpp file is stronger for these guys t

[PATCH] D49360: [analyzer] Add support for more basic_string API in DanglingInternalBufferChecker

NoQ added a comment. Hmm, the destructor-specific message was pretty good, can we keep it? It should be possible to print a different message depending on the program point within `N`. https://reviews.llvm.org/D49360 ___ cfe-commits mailing list c

r337226 - Restructure checking for, and warning on, lifetime extension.

Author: rsmith Date: Mon Jul 16 17:11:41 2018 New Revision: 337226 URL: http://llvm.org/viewvc/llvm-project?rev=337226&view=rev Log: Restructure checking for, and warning on, lifetime extension. This change implements C++ DR1696, which makes initialization of a reference member of a class from a

[PATCH] D15225: [Driver] Sanitizer support based on runtime library presence

kubamracek added a comment. This looks great to me, but someone else should review this as well. https://reviews.llvm.org/D15225 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D48266: [Driver] Add -fno-digraphs

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks good with one cleanup. Comment at: lib/Frontend/CompilerInvocation.cpp:2177-2178 + if (const Arg *A = Args.getLastArg(OPT_fdigraphs, OPT_fno_digraphs)) +Opts.Dig

[PATCH] D49317: Move __construct_forward (etc.) out of std::allocator_traits.

vsapsai added a comment. My review is incomplete, especially I cannot say with confidence if the proposed change is entirely free from unintended consequences that might break code not covered by the test suite. So other reviewers are welcome to chime in. Comment at: include/

r337227 - [analyzer] Assert that nonloc::SymbolVal always wraps a non-Loc-type symbol.

Author: dergachev Date: Mon Jul 16 17:22:27 2018 New Revision: 337227 URL: http://llvm.org/viewvc/llvm-project?rev=337227&view=rev Log: [analyzer] Assert that nonloc::SymbolVal always wraps a non-Loc-type symbol. In the current SVal hierarchy there are multiple ways of representing certain values

[PATCH] D48205: [analyzer] Assert that nonloc::SymbolVal always wraps a non-Loc-type symbol.

This revision was automatically updated to reflect the committed changes. Closed by commit rC337227: [analyzer] Assert that nonloc::SymbolVal always wraps a non-Loc-type symbol. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D48205 Files: include/clang

[PATCH] D49265: [Tooling] Add operator== to CompileCommand

dblaikie accepted this revision. dblaikie added a comment. Looks good, Thanks! Repository: rC Clang https://reviews.llvm.org/D49265 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D48232: [analyzer] pr37802: Fix symbolic-pointer-to-boolean casts during load.

This revision was automatically updated to reflect the committed changes. Closed by commit rL337228: [analyzer] pr37802: Fix symbolic-pointer-to-boolean casts during load. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.l

r337228 - [analyzer] pr37802: Fix symbolic-pointer-to-boolean casts during load.

Author: dergachev Date: Mon Jul 16 17:42:35 2018 New Revision: 337228 URL: http://llvm.org/viewvc/llvm-project?rev=337228&view=rev Log: [analyzer] pr37802: Fix symbolic-pointer-to-boolean casts during load. The canonical representation of pointer &SymRegion{$x} casted to boolean is "$x != 0", not

[PATCH] D49317: Move __construct_forward (etc.) out of std::allocator_traits.

Quuxplusone updated this revision to Diff 155796. Quuxplusone marked 4 inline comments as done. Quuxplusone added a comment. Address @vsapsai's review comments. Repository: rCXX libc++ https://reviews.llvm.org/D49317 Files: include/memory include/vector test/libcxx/containers/sequences

[PATCH] D49317: Move __construct_forward (etc.) out of std::allocator_traits.

Quuxplusone added inline comments. Comment at: include/vector:298 +__copy_construct_forward(_Alloc& __a, _Iter __begin1, _Iter __end1, + _Ptr& __begin2, _CopyViaMemcpy) +{ vsapsai wrote: > Why does this function use `_CopyViaMemcpy` and no

r337229 - [CFG] [analyzer] Allow elidable copies to have more than one arguments.

Author: dergachev Date: Mon Jul 16 17:57:57 2018 New Revision: 337229 URL: http://llvm.org/viewvc/llvm-project?rev=337229&view=rev Log: [CFG] [analyzer] Allow elidable copies to have more than one arguments. Copy-constructors and move-constructors may have default arguments. It is incorrect to as

[PATCH] D49215: [analyzer] Admit that some copy/move constructors have more than one argument.

This revision was automatically updated to reflect the committed changes. Closed by commit rL337229: [CFG] [analyzer] Allow elidable copies to have more than one arguments. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.

[PATCH] D49360: [analyzer] Add support for more basic_string API in DanglingInternalBufferChecker

dcoughlin added a comment. It is really nice to see this checker take shape! Some drive by diagnostic comments in line. Comment at: test/Analysis/dangling-internal-buffer.cpp:175 std::string s; - { -c = s.c_str(); - } - consume(c); // no-warning + c = s.c_str(); //

[PATCH] D47757: [Sema] Produce diagnostics when unavailable aligned allocation/deallocation functions are called

ahatanak added a comment. ping Repository: rC Clang https://reviews.llvm.org/D47757 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r337231 - [analyzer] Fix size_t in tests.

Author: dergachev Date: Mon Jul 16 18:39:25 2018 New Revision: 337231 URL: http://llvm.org/viewvc/llvm-project?rev=337231&view=rev Log: [analyzer] Fix size_t in tests. Should fix a buildbot. No functional change intended. Modified: cfe/trunk/test/Analysis/pr37802.cpp Modified: cfe/trunk/t

[PATCH] D49348: Harden/relax clang/test/CodeGen/opt-record-MIR.c test

anemet accepted this revision. anemet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rC Clang https://reviews.llvm.org/D49348 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

[PATCH] D48266: [Driver] Add -fno-digraphs

This revision was automatically updated to reflect the committed changes. Closed by commit rL337232: [Driver] Add -fno-digraphs (authored by jtbandes, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D48266?vs=155116&id=155809#toc Repos

[PATCH] D48266: [Driver] Add -fno-digraphs

jtbandes marked an inline comment as done. jtbandes added a comment. Ping again 😇 Repository: rL LLVM https://reviews.llvm.org/D48266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[libcxx] r337235 - Address "always inline function is not always inlinable" warning with GCC.

Author: ericwf Date: Mon Jul 16 22:48:48 2018 New Revision: 337235 URL: http://llvm.org/viewvc/llvm-project?rev=337235&view=rev Log: Address "always inline function is not always inlinable" warning with GCC. When an always_inline function is used prior to the functions definition, the compiler ma

[PATCH] D49348: Harden/relax clang/test/CodeGen/opt-record-MIR.c test

lebedev.ri added a comment. In https://reviews.llvm.org/D49348#1164579, @anemet wrote: > LGTM, thanks! Thank you for the review. (I'll watch the bots, obviously) Repository: rC Clang https://reviews.llvm.org/D49348 ___ cfe-commits mailing list

<    1   2