[PATCH] D48941: [ASTImporter] import FunctionDecl end locations

a_sidorin added a comment. Hello Rafael. This change is good, just some cleanup is needed. Comment at: lib/AST/ASTImporter.cpp:2559 D->isImplicit()); +ToFunction->setRangeEnd(Importer.Import(D->getLocEnd())); } else if (auto *F

[PATCH] D45015: [Preprocessor] Allow libc++ to detect when aligned allocation is unavailable.

EricWF added a comment. @rsmith Ping. This needs to land before the next branch for release. https://reviews.llvm.org/D45015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D48753: [libcxx] Use custom allocator's `construct` in C++03 when available.

vsapsai added inline comments. Comment at: libcxx/test/std/containers/sequences/vector/vector.cons/construct_iter_iter_alloc.pass.cpp:60 + + void construct(pointer p, const value_type& val) + { Quuxplusone wrote: > Per my comments on D48342, I think it would b

[PATCH] D48342: [libcxx] Optimize vectors construction of trivial types from an iterator range with const-ness mismatch.

vsapsai added a comment. In https://reviews.llvm.org/D48342#1152063, @EricWF wrote: > Are there any tests which actually exercise the new behavior? Added tests only verify we don't use memcpy erroneously. And existing tests make sure there are no functionality regressions. But there is nothing

[PATCH] D48342: [libcxx] Optimize vectors construction of trivial types from an iterator range with const-ness mismatch.

vsapsai added inline comments. Comment at: libcxx/include/memory:1479 +struct __has_construct_missing +: false_type +{ Quuxplusone wrote: > vsapsai wrote: > > Quuxplusone wrote: > > > vsapsai wrote: > > > > vsapsai wrote: > > > > > vsapsai wrote: > > > > > >

r336300 - [Index] Remove unused index::IndexDataConsumer::_anchor()

Author: maskray Date: Wed Jul 4 17:33:03 2018 New Revision: 336300 URL: http://llvm.org/viewvc/llvm-project?rev=336300&view=rev Log: [Index] Remove unused index::IndexDataConsumer::_anchor() It was supposed to serve as a key function, but it was invalid as it was not the first out-of-line non-p

[clang-tools-extra] r336301 - Add the cert-msc51-cpp and cert-msc32-c checks.

Author: aaronballman Date: Wed Jul 4 18:16:31 2018 New Revision: 336301 URL: http://llvm.org/viewvc/llvm-project?rev=336301&view=rev Log: Add the cert-msc51-cpp and cert-msc32-c checks. These checks flag use of random number generators with poor seeds that would possibly lead to degraded random

[PATCH] D44143: [clang-tidy] Create properly seeded random generator check

aaron.ballman closed this revision. aaron.ballman added a comment. In https://reviews.llvm.org/D44143#1152550, @boga95 wrote: > How can I commit it? You need to have obtained commit access first. I went ahead and committed on your behalf in r336301. Thank you for the patch!

[clang-tools-extra] r336302 - Adding some documentation changes that were missed in r336301.

Author: aaronballman Date: Wed Jul 4 18:35:49 2018 New Revision: 336302 URL: http://llvm.org/viewvc/llvm-project?rev=336302&view=rev Log: Adding some documentation changes that were missed in r336301. Added: clang-tools-extra/trunk/docs/clang-tidy/checks/cert-msc51-cpp.rst Modified: clan

[PATCH] D48044: [Power9] Update fp128 as a valid homogenous aggregate base type

This revision was automatically updated to reflect the committed changes. Closed by commit rL336308: [Power9] Update fp128 as a valid homogenous aggregate base type (authored by lei, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D4804

[PATCH] D48628: [AST] Structural equivalence of methods

a_sidorin accepted this revision. a_sidorin added a comment. LG with a nit. Thank you! Comment at: unittests/AST/StructuralEquivalenceTest.cpp:489 + +TEST_F(StructuralEquivalenceRecordTest, DISABLED_Methods) { + auto t = makeNamedDecls( Could you add a comment

[PATCH] D48938: [clangd] Track origins of symbols (various indexes, Sema).

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rL336309: [clangd] Track origins of symbols (various indexes, Sema). (authored by sammccall, committed by ). Herald added a subscriber: llvm-commits. Changed prio

[clang-tools-extra] r336309 - [clangd] Track origins of symbols (various indexes, Sema).

Author: sammccall Date: Wed Jul 4 23:20:41 2018 New Revision: 336309 URL: http://llvm.org/viewvc/llvm-project?rev=336309&view=rev Log: [clangd] Track origins of symbols (various indexes, Sema). Summary: Surface it in the completion items C++ API, and when a flag is set. Reviewers: ioeric Subsc

[PATCH] D48938: [clangd] Track origins of symbols (various indexes, Sema).

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE336309: [clangd] Track origins of symbols (various indexes, Sema). (authored by sammccall, committed by ). Changed prior to commit: https://reviews.llvm.org/D48938?vs=154105&id=154168#toc Repository:

[libcxxabi] r336312 - [demangler] Avoid alignment warning

Author: sepavloff Date: Wed Jul 4 23:24:29 2018 New Revision: 336312 URL: http://llvm.org/viewvc/llvm-project?rev=336312&view=rev Log: [demangler] Avoid alignment warning The alignment specified by a constant for the field `BumpPointerAllocator::InitialBuffer` exceeded the alignment guaranteed b

<    1   2