Re: r335618 - [ThinLTO] Add testing of summary index parsing to a couple CFI tests

The check lines added here are failing for me on CentOS 7. https://reviews.llvm.org/P8091 has the lit output and the actual output being produced by one of the added RUN lines. My llvm and clang repositories are in sync. Any idea what might be going on here? From: cfe-commits on behalf of Tere

[PATCH] D48616: Implement LWG 2946, 3075 and 3076

STL_MSFT added inline comments. Comment at: test/std/strings/basic.string/string.cons/string_view_deduction.fail.cpp:26 +// The deduction guide shall not participate in overload resolution if Allocator is +// is a type that does not qualify as an allocator. +

[PATCH] D48617: [Builtins][Attributes][X86] Tag all X86 builtins with their required vector width. Add a min_vector_width function attribute and tag all x86 instrinsics with it.

craig.topper created this revision. craig.topper added reviewers: rsmith, chandlerc, echristo, rnk. This is part of an ongoing attempt at making 512 bit vectors illegal in the X86 backend type legalizer due to CPU frequency penalties associated with wide vectors on Skylake Server CPUs. We want t

Re: r335618 - [ThinLTO] Add testing of summary index parsing to a couple CFI tests

I haven't seen any bot failures for the change. The failing check was there before, so presumably llvm-dis on its own is producing the expected lines, just not when it goes through llvm-as. Can you let me know whether llvm-as has been updated and whether it gives an error. Note that there were a nu

r335683 - [analyzer] Minor cleanups for BugReporter, expose a getter for AnalyzerOptions.

Author: george.karpenkov Date: Tue Jun 26 16:10:05 2018 New Revision: 335683 URL: http://llvm.org/viewvc/llvm-project?rev=335683&view=rev Log: [analyzer] Minor cleanups for BugReporter, expose a getter for AnalyzerOptions. Modified: cfe/trunk/include/clang/StaticAnalyzer/Core/BugReporter/BugR

r335684 - Revert "[MS] Use mangled names and comdats for string merging with ASan"

Author: eugenis Date: Tue Jun 26 16:10:48 2018 New Revision: 335684 URL: http://llvm.org/viewvc/llvm-project?rev=335684&view=rev Log: Revert "[MS] Use mangled names and comdats for string merging with ASan" Depends on r334313, which has been reverted in r335681. Modified: cfe/trunk/lib/CodeG

r335685 - [analyzer] [tests] Include statistics in tests.

Author: george.karpenkov Date: Tue Jun 26 16:17:35 2018 New Revision: 335685 URL: http://llvm.org/viewvc/llvm-project?rev=335685&view=rev Log: [analyzer] [tests] Include statistics in tests. Modified: cfe/trunk/utils/analyzer/SATestBuild.py Modified: cfe/trunk/utils/analyzer/SATestBuild.py U

r335686 - [clang] Add test dependency on llvm-as

Author: smeenai Date: Tue Jun 26 16:18:59 2018 New Revision: 335686 URL: http://llvm.org/viewvc/llvm-project?rev=335686&view=rev Log: [clang] Add test dependency on llvm-as r335618 added tests that invoke llvm-as, so we should also ensure that running clang tests rebuilds llvm-as. Modified:

Re: r335618 - [ThinLTO] Add testing of summary index parsing to a couple CFI tests

Ah, my llvm-as was indeed out of date. I made check-clang depend on llvm-as in r335686 to avoid this issue in the future. From: Teresa Johnson Date: Tuesday, June 26, 2018 at 4:11 PM To: Shoaib Meenai Cc: "cfe-commits@lists.llvm.org" Subject: Re: r335618 - [ThinLTO] Add testing of summary inde

r335687 - Diagnose missing 'template' keywords in more cases.

Author: rsmith Date: Tue Jun 26 16:20:26 2018 New Revision: 335687 URL: http://llvm.org/viewvc/llvm-project?rev=335687&view=rev Log: Diagnose missing 'template' keywords in more cases. We track when we see a name-shaped expression followed by a '<' token and parse the '<' as a comparison. Then:

[PATCH] D48571: improve diagnostics for missing 'template' keyword

This revision was automatically updated to reflect the committed changes. Closed by commit rC335687: Diagnose missing 'template' keywords in more cases. (authored by rsmith, committed by ). Repository: rC Clang https://reviews.llvm.org/D48571 Files: include/clang/Basic/BitmaskEnum.h inclu

[PATCH] D48285: [analyzer][UninitializedObjectChecker] Added "NotesAsWarnings" flag

NoQ accepted this revision. NoQ added a comment. Looks great, thanks! Comment at: lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp:696 void ento::registerUninitializedObjectChecker(CheckerManager &Mgr) { auto Chk = Mgr.registerChecker(); Chk->IsPedantic = Mgr.g

[PATCH] D48342: [libcxx] Optimize vectors construction of trivial types from an iterator range with const-ness mismatch.

vsapsai updated this revision to Diff 152990. vsapsai added a comment. - Don't use memcpy specialization with custom allocators. Not entirely satisfied with comparing allocator to non-const and const, don't know if there is a more elegant way to do the same. https://reviews.llvm.org/D48342 Fil

r335691 - [mips] Explicitly specify the linker emulation for MIPS on FreeBSD.

Author: jhb Date: Tue Jun 26 17:02:16 2018 New Revision: 335691 URL: http://llvm.org/viewvc/llvm-project?rev=335691&view=rev Log: [mips] Explicitly specify the linker emulation for MIPS on FreeBSD. FreeBSD's mips64 builds O32 binaries for /usr/lib32 by default and thus needs to be able to link O3

[PATCH] D48507: [mips] Explicitly specify the linker emulation for MIPS on FreeBSD.

This revision was automatically updated to reflect the committed changes. Closed by commit rL335691: [mips] Explicitly specify the linker emulation for MIPS on FreeBSD. (authored by jhb, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D4850

[PATCH] D48291: [analyzer][UninitializedObjectChecker] Fixed captured lambda variable name

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp:699 +for (const LambdaCapture &L : CXXParent->captures()) { + if (L.getLocation() == Field->getLocation()) +return L.getCapturedVar()->getName(); Uh

[PATCH] D48291: [analyzer][UninitializedObjectChecker] Fixed captured lambda variable name

george.karpenkov added a comment. Few more nits. Comment at: lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp:691 +StringRef getVariableName(const FieldDecl *Field) { + // If \p Field is a captured lambda variable, Field->getName() will return Is t

[PATCH] D48291: [analyzer][UninitializedObjectChecker] Fixed captured lambda variable name

george.karpenkov requested changes to this revision. george.karpenkov added a comment. This revision now requires changes to proceed. Looks like @NoQ had some valid comments as well. https://reviews.llvm.org/D48291 ___ cfe-commits mailing list cfe-c

[PATCH] D47616: [CFG] [analyzer] Explain copy elision through construction contexts.

george.karpenkov accepted this revision. george.karpenkov added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D47616 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[PATCH] D47554: [analyzer] Check for dead/impossible status checks

george.karpenkov requested changes to this revision. george.karpenkov added a comment. This revision now requires changes to proceed. @NoQ had some valid comments. I think this could be still useful without dataflow if we negate matches containing escaping and assignments. Though of course this c

[PATCH] D48608: [CFG] [analyzer] Add construction contexts for C++ objects returned from Objective-C messages.

george.karpenkov requested changes to this revision. george.karpenkov added a comment. This revision now requires changes to proceed. Minor nits: would like some more comments. Comment at: include/clang/Analysis/CFG.h:185 +assert(isa(E) || isa(E)); +return !E->isGLValue

[PATCH] D48436: [analyzer][UninitializedObjectChecker] Fixed a false negative by no longer filtering out certain constructor calls

george.karpenkov accepted this revision. george.karpenkov added a comment. This revision is now accepted and ready to land. LGTM with a nit. Comment at: lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp:674 + const LocationContext *LC = Context.getLocationContext(); +

[PATCH] D48616: Implement LWG 2946, 3075 and 3076

mclow.lists updated this revision to Diff 152995. mclow.lists added a comment. Remove a bunch of `noexcept`s that I missed the first time. Put in an error message to be checked in one of the failing deduction cases that was lacking it. Address STL's comments. https://reviews.llvm.org/D48616 F

[PATCH] D48325: [analyzer][UninitializedObjectChecker] Support for MemberPointerTypes

george.karpenkov requested changes to this revision. george.karpenkov added a comment. This revision now requires changes to proceed. Requesting changes or clarification on uninitialized references. Comment at: lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp:392 -

[PATCH] D48325: [analyzer][UninitializedObjectChecker] Support for MemberPointerTypes

NoQ accepted this revision. NoQ added a comment. Looks good! One minor comment. Comment at: lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp:488-491 // TODO: Dereferencing should be done according to the dynamic type. while (Optional L = DerefdV.getAs()) {

[PATCH] D48325: [analyzer][UninitializedObjectChecker] Support for MemberPointerTypes

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp:392 -if (T->isMemberPointerType()) { - if (isMemberPointerUninit(FR, LocalChain)) +if (T->isPointerType() || T->isReferenceType()) { + if (isPointerOrReferenceUni

[PATCH] D48436: [analyzer][UninitializedObjectChecker] Fixed a false negative by no longer filtering out certain constructor calls

NoQ added a comment. I think we need to finish our dialog on who's responsible for initialization and why do we need to filter constructors at all, cause it's kinda hanging (i.e. https://reviews.llvm.org/D45532#inline-422673). https://reviews.llvm.org/D48436

[PATCH] D48249: [analyzer] Add stubs for argument construction contexts for arguments of C++ constructors and Objective-C messages.

george.karpenkov requested changes to this revision. george.karpenkov added inline comments. This revision now requires changes to proceed. Comment at: lib/Analysis/CFG.cpp:2397 + for (auto Arg: C->arguments()) +if (Arg->getType()->getAsCXXRecordDecl() && !Arg->isGLValue())

r335699 - Diagnose missing 'template' keywords in contexts where a comma is not a

Author: rsmith Date: Tue Jun 26 18:32:04 2018 New Revision: 335699 URL: http://llvm.org/viewvc/llvm-project?rev=335699&view=rev Log: Diagnose missing 'template' keywords in contexts where a comma is not a binary operator. Factor out the checking for a comma within potential angle brackets and als

r335700 - [analyzer] [NFC] Add -verify to malloc checker test

Author: george.karpenkov Date: Tue Jun 26 18:51:36 2018 New Revision: 335700 URL: http://llvm.org/viewvc/llvm-project?rev=335700&view=rev Log: [analyzer] [NFC] Add -verify to malloc checker test Differential Revision: https://reviews.llvm.org/D48514 Modified: cfe/trunk/test/Analysis/malloc-p

[PATCH] D44756: [analyzer] [NFC] A convenient getter for getting a current stack frame

This revision was automatically updated to reflect the committed changes. Closed by commit rC335701: [analyzer] [NFC] A convenient getter for getting a current stack frame (authored by george.karpenkov, committed by ). Herald added subscribers: cfe-commits, mikhail.ramalho. Changed prior to commi

r335701 - [analyzer] [NFC] A convenient getter for getting a current stack frame

Author: george.karpenkov Date: Tue Jun 26 18:51:55 2018 New Revision: 335701 URL: http://llvm.org/viewvc/llvm-project?rev=335701&view=rev Log: [analyzer] [NFC] A convenient getter for getting a current stack frame Differential Revision: https://reviews.llvm.org/D44756 Modified: cfe/trunk/inc

[PATCH] D48514: [analyzer] [NFC] Add -verify to malloc checker test

This revision was automatically updated to reflect the committed changes. Closed by commit rC335700: [analyzer] [NFC] Add -verify to malloc checker test (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D4851

Re: r335618 - [ThinLTO] Add testing of summary index parsing to a couple CFI tests

Ah - thanks for fixing that. Surprised none of the bots hit it. Teresa On Tue, Jun 26, 2018 at 4:24 PM Shoaib Meenai wrote: > Ah, my llvm-as was indeed out of date. I made check-clang depend on > llvm-as in r335686 to avoid this issue in the future. > > > > *From: *Teresa Johnson > *Date: *Tues

[PATCH] D48524: [ODRHash] Do not put elaborated types in the TypeMap

rtrieu added a comment. Hey Vassil, I have been giving this a little more thought and I have a solution I'd like you to try out. If the type pointers aren't unique enough, then the indexing scheme will not work for hashing. Can you try this idea in your build environment and see if works for

r335702 - Fix warning about unhandled enumeration in switch.

Author: zturner Date: Tue Jun 26 19:49:22 2018 New Revision: 335702 URL: http://llvm.org/viewvc/llvm-project?rev=335702&view=rev Log: Fix warning about unhandled enumeration in switch. Modified: cfe/trunk/lib/Driver/ToolChains/FreeBSD.cpp Modified: cfe/trunk/lib/Driver/ToolChains/FreeBSD.cpp

[PATCH] D48563: [CMake] Use explicit targets for building Linux runtimes

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang https://reviews.llvm.org/D48563 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[PATCH] D48459: Respect CMAKE_SYSROOT and CMAKE_CROSSCOMPILING when searching for libxml2.

phosek added inline comments. Comment at: CMakeLists.txt:191 +# are cross-compiling. +if(NOT CMAKE_SYSROOT AND NOT CMAKE_CROSSCOMPILING AND NOT LLVM_USE_SANITIZER MATCHES "Memory.*") set (LIBXML2_FOUND 0) This isn't going to cause a problem for us since we al

[PATCH] D48564: [CMake] Support passing FUCHSIA_SDK as the only variable

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang https://reviews.llvm.org/D48564 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

r335704 - [CMake] Provide direct support for building sanitized runtimes

Author: phosek Date: Tue Jun 26 20:35:53 2018 New Revision: 335704 URL: http://llvm.org/viewvc/llvm-project?rev=335704&view=rev Log: [CMake] Provide direct support for building sanitized runtimes This avoids having to rely on magic separators and special parsing. Differential Revision: https://r

[PATCH] D48459: Respect CMAKE_SYSROOT and CMAKE_CROSSCOMPILING when searching for libxml2.

srhines added a comment. In https://reviews.llvm.org/D48459#1143012, @smeenai wrote: > Actually, I would imagine that if you're cross-compiling or using a custom > sysroot, you should probably also specify CMAKE_FIND_ROOT_PATH and set > CMAKE_FIND_ROOT_PATH_MODE_PACKAGE to ONLY, to limit all th

[PATCH] D47846: [clangd] Implementation of textDocument/documentSymbol

malaperle planned changes to this revision. malaperle added a comment. I found some issues while testing, I will investigate before review. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47846 ___ cfe-commits mailing list cfe-commit

[PATCH] D48616: Implement LWG 2946, 3075 and 3076

mclow.lists updated this revision to Diff 153001. mclow.lists added a comment. Updated the `__is_allocator` type trait to work all the way back to C++03 Added a bunch of tests from issue2946. I think this has all the pieces that it needs now. https://reviews.llvm.org/D48616 Files: include/me

[PATCH] D48564: [CMake] Support passing FUCHSIA_SDK as the only variable

This revision was automatically updated to reflect the committed changes. Closed by commit rL335708: [CMake] Support passing FUCHSIA_SDK as the only variable (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D48564?vs

r335708 - [CMake] Support passing FUCHSIA_SDK as the only variable

Author: phosek Date: Tue Jun 26 22:50:43 2018 New Revision: 335708 URL: http://llvm.org/viewvc/llvm-project?rev=335708&view=rev Log: [CMake] Support passing FUCHSIA_SDK as the only variable Now that the structure of Fuchsia SDK has been formalized, we no longer need to pass all the different CFLA

[PATCH] D47819: [test] Support using libtirpc on Linux

mgorny added reviewers: dvyukov, eugenis. mgorny added a comment. Ping. This is necessary to resolve https://github.com/google/sanitizers/issues/974 and fix tests on systems which don't enable all the backwards compatibility cruft (Arch, Gentoo). See also https://reviews.llvm.org/D47817 as nece

<    1   2