[PATCH] D48443: [WIP] Add no-prototype attribute to prototype-less C functions

aheejin added inline comments. Comment at: lib/CodeGen/CGCall.cpp:1849 + if (!AttrOnCallSite && !Fn->hasPrototype()) +FuncAttrs.addAttribute("no-prototype"); AddAttributesFromFunctionProtoType( Is there a reason why this is not something like

r335291 - Revert "[LTO] Enable module summary emission by default for regular LTO"

Author: tobiasvk Date: Thu Jun 21 14:24:30 2018 New Revision: 335291 URL: http://llvm.org/viewvc/llvm-project?rev=335291&view=rev Log: Revert "[LTO] Enable module summary emission by default for regular LTO" This is breaking a couple of buildbots. We need to run the NameAnonGlobal pass for regula

[PATCH] D48456: [Fixed Point Arithmetic] Casting between fixed point types and other arithmetic types

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr, jakehehrlich, rsmith, ebevhan. leonardchan added a project: clang. leonardchan added a dependency: D46917: [Fixed Point Arithmetic] Comparison and Unary Operations for Fixed Point Types. Add support for casting betw

[PATCH] D36357: Added a better diagnostic when using the delete operator with lambdas

rsmith added inline comments. Comment at: lib/Parse/ParseExprCXX.cpp:2907-2909 +const Token Next = GetLookAheadToken(2); +const Token After = GetLookAheadToken(3); +const Token Last = GetLookAheadToken(4); Please don't request the additional lookahead

[PATCH] D46926: [Fixed Point Arithmetic] Conversion between Fixed Point and Floating Point Numbers

leonardchan abandoned this revision. leonardchan added a comment. The logic in this patch is moved to https://reviews.llvm.org/D48456 Repository: rC Clang https://reviews.llvm.org/D46926 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

r335295 - Re-apply: Add python tool to dump and construct header maps

Author: bruno Date: Thu Jun 21 14:45:24 2018 New Revision: 335295 URL: http://llvm.org/viewvc/llvm-project?rev=335295&view=rev Log: Re-apply: Add python tool to dump and construct header maps Header maps are binary files used by Xcode, which are used to map header names or paths to other location

[PATCH] D48456: [Fixed Point Arithmetic] Casting between fixed point types and other arithmetic types

leonardchan updated this revision to Diff 152385. Repository: rC Clang https://reviews.llvm.org/D48456 Files: include/clang/AST/ASTContext.h include/clang/AST/OperationKinds.def include/clang/AST/Type.h include/clang/Basic/DiagnosticSemaKinds.td include/clang/Basic/TargetInfo.h inc

[PATCH] D48459: Respect CMAKE_SYSROOT and CMAKE_CROSSCOMPILING when searching for libxml2.

srhines created this revision. Herald added a subscriber: mgorny. If we ignore these variables, we end up always using the host information for libxml2, when it is not appropriate. This makes builds less hermetic than they should ideally be. Repository: rC Clang https://reviews.llvm.org/D4845

[PATCH] D48443: [WIP] Add no-prototype attribute to prototype-less C functions

dschuff added inline comments. Comment at: lib/CodeGen/CGCall.cpp:1849 + if (!AttrOnCallSite && !Fn->hasPrototype()) +FuncAttrs.addAttribute("no-prototype"); AddAttributesFromFunctionProtoType( aheejin wrote: > Is there a reason why this is no

[PATCH] D48443: [WIP] Add no-prototype attribute to prototype-less C functions

dschuff added inline comments. Comment at: lib/CodeGen/CGCall.cpp:1849 + if (!AttrOnCallSite && !Fn->hasPrototype()) +FuncAttrs.addAttribute("no-prototype"); AddAttributesFromFunctionProtoType( dschuff wrote: > aheejin wrote: > > Is there a re

[PATCH] D48460: [analyzer] Fix invalidation on C++ const methods.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet, rnkovacs. Herald added subscribers: cfe-commits, mikhail.ramalho, baloghadamsoftware. `const` methods shouldn't invalidate the object unless mutable fields kick in. They sometimes were inva

[PATCH] D48395: Added PublicOnly flag

juliehockett added a comment. So on seeing this, all of the plumbing needed to get that particular value where you need it is a bit ugly. I'm inclined to suggest wrapping it in a `ClangDocContext`, containing it and the `ExecutionContext` in the `ClangDoc.h` file: struct ClangDocContext {

[PATCH] D47044: [analyzer] Ensure that we only visit a destructor for a reference if type information is available.

ormris added a comment. In https://reviews.llvm.org/D47044#1130339, @NoQ wrote: > I'm still curious whether this also works: > > void foo() { > const A &x = B(); > bar(); > } > > void bar() { > for (int i = 0; i < 10; ++i) {} > } > > > Though we can land this patch and deal

[PATCH] D48454: Ignore blacklist when generating __cfi_check_fail.

pcc added a comment. __cfi_check_fail certainly seems like a special case in that its behaviour is controlled only by flags and not the blacklist. Maybe a simpler fix would be to add this to the top of `EmitCfiCheckFail`? SanOpts = CGM.getLangOpts().Sanitize; https://reviews.llvm.org/D48454

r335299 - Test commit, made a minor change to a comment

Author: emmettneyman Date: Thu Jun 21 15:08:20 2018 New Revision: 335299 URL: http://llvm.org/viewvc/llvm-project?rev=335299&view=rev Log: Test commit, made a minor change to a comment Modified: cfe/trunk/tools/clang-fuzzer/ExampleClangLoopProtoFuzzer.cpp Modified: cfe/trunk/tools/clang-fuzz

[PATCH] D48454: Ignore blacklist when generating __cfi_check_fail.

eugenis updated this revision to Diff 152395. eugenis added a comment. Simplify code. https://reviews.llvm.org/D48454 Files: clang/lib/CodeGen/CGExpr.cpp clang/test/CodeGen/cfi-check-fail2.c Index: clang/test/CodeGen/cfi-check-fail2.c ==

[PATCH] D48454: Ignore blacklist when generating __cfi_check_fail.

eugenis added a comment. Yes, that's better. https://reviews.llvm.org/D48454 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D48454: Ignore blacklist when generating __cfi_check_fail.

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D48454 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D48462: [X86] Update handling in CGBuiltin to be tolerant of out of range immediates.

craig.topper created this revision. craig.topper added reviewers: chandlerc, RKSimon, spatel. Chandler is working changes that will loosen some of the range checks in SemaChecking to only be warning that can be disabled. This patch adds explicit masking to avoid using the upper bits of immediate

[PATCH] D48462: [X86] Update handling in CGBuiltin to be tolerant of out of range immediates.

craig.topper added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:9322 unsigned Index = BuiltinID == X86::BI__builtin_ia32_storelps ? 0 : 1; -llvm::Value *Idx = llvm::ConstantInt::get(SizeTy, Index); -Ops[1] = Builder.CreateExtractElement(Ops[1], Idx, "extrac

[PATCH] D48426: [clang-cl] Don't emit dllexport inline functions etc. from pch files (PR37801)

dblaikie added a comment. In https://reviews.llvm.org/D48426#1139823, @rnk wrote: > `LangOpts.ModulesCodegen` is very related in spirit to this, but I think we > need a distinct option because that was designed to handle all inline > functions (too much), not just dllexport inline functions. +

[PATCH] D48454: Ignore blacklist when generating __cfi_check_fail.

This revision was automatically updated to reflect the committed changes. Closed by commit rL335305: Ignore blacklist when generating __cfi_check_fail. (authored by eugenis, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D48454?vs=1523

r335305 - Ignore blacklist when generating __cfi_check_fail.

Author: eugenis Date: Thu Jun 21 16:22:37 2018 New Revision: 335305 URL: http://llvm.org/viewvc/llvm-project?rev=335305&view=rev Log: Ignore blacklist when generating __cfi_check_fail. Summary: Fixes PR37898. Reviewers: pcc, vlad.tsyrklevich Subscribers: cfe-commits Differential Revision: http

[PATCH] D48464: [x86] Teach the builtin argument range check to allow invalid ranges in dead code.

chandlerc created this revision. chandlerc added reviewers: craig.topper, rsmith. Herald added subscribers: llvm-commits, atanasyan, kbarton, nemanjai, mcrosier, sanjoy. Herald added a reviewer: javed.absar. This is important for C++ templates that essentially compute the valid input in a way tha

[PATCH] D48462: [X86] Update handling in CGBuiltin to be tolerant of out of range immediates.

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. LGTM, thanks! https://reviews.llvm.org/D48462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[PATCH] D48464: [x86] Teach the builtin argument range check to allow invalid ranges in dead code.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D48464 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

r335308 - [X86] Update handling in CGBuiltin to be tolerant of out of range immediates.

Author: ctopper Date: Thu Jun 21 16:39:47 2018 New Revision: 335308 URL: http://llvm.org/viewvc/llvm-project?rev=335308&view=rev Log: [X86] Update handling in CGBuiltin to be tolerant of out of range immediates. D48464 contains changes that will loosen some of the range checks in SemaChecking to

r335309 - [x86] Teach the builtin argument range check to allow invalid ranges in

Author: chandlerc Date: Thu Jun 21 16:46:09 2018 New Revision: 335309 URL: http://llvm.org/viewvc/llvm-project?rev=335309&view=rev Log: [x86] Teach the builtin argument range check to allow invalid ranges in dead code. This is important for C++ templates that essentially compute the valid input i

[PATCH] D48464: [x86] Teach the builtin argument range check to allow invalid ranges in dead code.

This revision was automatically updated to reflect the committed changes. Closed by commit rC335309: [x86] Teach the builtin argument range check to allow invalid ranges in (authored by chandlerc, committed by ). Changed prior to commit: https://reviews.llvm.org/D48464?vs=152404&id=152411#toc

r335310 - [x86] Fix a tiny bug in my test case in r335309 by marking that we don't

Author: chandlerc Date: Thu Jun 21 16:52:36 2018 New Revision: 335310 URL: http://llvm.org/viewvc/llvm-project?rev=335310&view=rev Log: [x86] Fix a tiny bug in my test case in r335309 by marking that we don't expect any diagnostics. Modified: cfe/trunk/test/Sema/builtins-x86.cpp Modified: cf

[PATCH] D48412: [RISCV] Support for __attribute__((interrupt))

apazos updated this revision to Diff 152416. apazos added a comment. Herald added subscribers: brucehoult, MartinMosbeck. Hi Simon, I have added a warning for repeated interrupt attributes. https://reviews.llvm.org/D48412 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td

[PATCH] D48432: [clang-format] Add AlwaysBreakBeforeMultilineString tests

stephanemoore accepted this revision. stephanemoore added a comment. This revision is now accepted and ready to land. Thanks! Repository: rC Clang https://reviews.llvm.org/D48432 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://list

[PATCH] D48460: [analyzer] Fix invalidation on C++ const methods.

baloghadamsoftware added a comment. I find it a strange behavior that this-expression is sometimes a pointer, sometimes a record declaration. If references are resolved, why are pointers not? This is an important fix, but I wonder how many other places are in the code where we do not handle th

[clang-tools-extra] r335321 - [clangd] Remove FilterText from the index.

Author: sammccall Date: Thu Jun 21 23:41:43 2018 New Revision: 335321 URL: http://llvm.org/viewvc/llvm-project?rev=335321&view=rev Log: [clangd] Remove FilterText from the index. Summary: It's almost always identical to Name, and in fact we never used it (we used name instead). The only case wher

[PATCH] D48375: [clangd] Remove FilterText from the index.

This revision was automatically updated to reflect the committed changes. Closed by commit rL335321: [clangd] Remove FilterText from the index. (authored by sammccall, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D48375 Files: clang-t

<    1   2