Author: ormris
Date: Tue Jun 12 15:22:35 2018
New Revision: 334554
URL: http://llvm.org/viewvc/llvm-project?rev=334554&view=rev
Log:
[analyzer] Ensure that loop widening does not invalidate references
Loop widening can invalidate a reference. If the analyzer attempts to visit the
destructor to a
nicholas added inline comments.
Comment at: lib/Sema/SemaOverload.cpp:6194
static SmallVector
getOrderedEnableIfAttrs(const FunctionDecl *Function) {
SmallVector Result;
This function shouldn't be necessary any more. All it's doing now is making an
unnecess
Meinersbur added inline comments.
Comment at: lib/Sema/SemaOverload.cpp:6194
static SmallVector
getOrderedEnableIfAttrs(const FunctionDecl *Function) {
SmallVector Result;
nicholas wrote:
> This function shouldn't be necessary any more. All it's doing now is
rsmith accepted this revision.
rsmith added a comment.
LGTM with one change.
Comment at: clang/include/clang/Basic/LangOptions.def:292
+BENIGN_LANGOPT(ForceEmitVTables, 1, 0,
+ "whether to emit all vtables")
I don't think this is benign or even
ethanhs added a comment.
In https://reviews.llvm.org/D47672#1128863, @rnk wrote:
> In https://reviews.llvm.org/D47672#1128308, @hans wrote:
>
> > It sounds like adding proper support for HLE prefixes is a largeish project.
> >
> > ctopper, rnk: Do you think it would be worth adding inline asm ver
emmettneyman created this revision.
emmettneyman added reviewers: kcc, vitalybuka, morehouse.
Herald added subscribers: cfe-commits, mgorny.
implemented proto_to_llvm
- also removed div and mod to eliminate UB
Repository:
rC Clang
https://reviews.llvm.org/D48106
Files:
tools/clang-fuzzer/
emmettneyman updated this revision to Diff 151063.
emmettneyman added a comment.
- removed unneeded file
Repository:
rC Clang
https://reviews.llvm.org/D48106
Files:
tools/clang-fuzzer/CMakeLists.txt
tools/clang-fuzzer/cxx_loop_proto.proto
tools/clang-fuzzer/proto-to-cxx/loop_proto_to_c
craig.topper added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:10071
+ // is _MM_FROUND_CUR_DIRECTION
+ if (cast(Ops[4])->getZExtValue() != 4)
+UsesNonDefaultRounding = true;
GBuella wrote:
> efriedma wrote:
> > Given we're ignoring f
emmettneyman updated this revision to Diff 151066.
emmettneyman added a comment.
- fixed proto_to_cxx.cpp
Repository:
rC Clang
https://reviews.llvm.org/D48106
Files:
tools/clang-fuzzer/CMakeLists.txt
tools/clang-fuzzer/cxx_loop_proto.proto
tools/clang-fuzzer/proto-to-cxx/loop_proto_to_
Author: george.karpenkov
Date: Tue Jun 12 16:53:54 2018
New Revision: 334560
URL: http://llvm.org/viewvc/llvm-project?rev=334560&view=rev
Log:
[analyzer] Do not crash in the visitor when the function is given more
arguments than it has parameters
rdar://40335545
Differential Revision: https://r
Author: yaxunl
Date: Tue Jun 12 16:58:59 2018
New Revision: 334561
URL: http://llvm.org/viewvc/llvm-project?rev=334561&view=rev
Log:
[CUDA][HIP] Allow CUDA __global__ functions to have amdgpu kernel attributes
There are HIP applications e.g. Tensorflow 1.3 using amdgpu kernel attributes,
however
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334561: [CUDA][HIP] Allow CUDA __global__ functions to have
amdgpu kernel attributes (authored by yaxunl, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://review
craig.topper added a comment.
I'll give the inline assembly a shot.
Repository:
rC Clang
https://reviews.llvm.org/D47672
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
george.karpenkov added subscribers: aaron.ballman, alexfh.
george.karpenkov added a comment.
Herald added a subscriber: mikhail.ramalho.
Getting there! Sorry for the delay. Would it be possible to rewrite the
remaining imperative code using matchers?
👍 on defining your own matcher. However, that
morehouse added a comment.
Where is the fuzz target?
Comment at: tools/clang-fuzzer/proto-to-llvm/loop_proto_to_llvm.cpp:33
+int ptr_ctr = 0;
+int val_ctr = 0;
+
I'd suggest wrapper functions that return unused variable names, so your code
below won't need to
Author: rsmith
Date: Tue Jun 12 19:06:28 2018
New Revision: 334565
URL: http://llvm.org/viewvc/llvm-project?rev=334565&view=rev
Log:
Fix crash emitting transparent list initializer for a large aggregate.
Modified:
cfe/trunk/lib/CodeGen/CGExprAgg.cpp
cfe/trunk/test/CodeGenCXX/value-init.cp
pcc updated this revision to Diff 151090.
pcc added a comment.
Herald added subscribers: steven_wu, kubamracek, mehdi_amini.
- Address TODOs
https://reviews.llvm.org/D47567
Files:
clang/docs/ControlFlowIntegrity.rst
clang/docs/LTOVisibility.rst
clang/include/clang/Basic/Sanitizers.def
c
Well, that was wrong. There are more install-cxx-headers targets that
the cache distribution implicitly depends on.
Is there a reason for your cxx-headers -> cxx_headers change? If
there is, should the other cxx-headers targets change as well? If
not, can we revert it?
I'll try to reproduce in
compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.
x86-Linux-only test is good. LG with the discussed changes.
Comment at: src/DwarfInstructions.hpp:195
}
+else if (i == (int)cieInfo.returnAddressRegiste
That could be the case. However, the bot shall not be left red.
Hans, could you revert the patch for now, till the problem would be
addressed on all the Windows bots one way or another, please?
I can take a look at my bots later this week.
Thanks
Galina
On Tue, Jun 12, 2018 at 1:52 PM, Reid Kle
craig.topper updated this revision to Diff 151100.
craig.topper added a comment.
Inline assembly implementations.
https://reviews.llvm.org/D47672
Files:
lib/Headers/immintrin.h
lib/Headers/intrin.h
test/CodeGen/ms-intrinsics.c
Index: test/CodeGen/ms-intrinsics.c
=
Author: ahatanak
Date: Tue Jun 12 22:26:23 2018
New Revision: 334569
URL: http://llvm.org/viewvc/llvm-project?rev=334569&view=rev
Log:
[Sema] When the address of a member function is used as a template
argument, use the context in which it is used for checking its
accessibility.
This fixes PR3289
This revision was automatically updated to reflect the committed changes.
Closed by commit rC334569: [Sema] When the address of a member function is used
as a template (authored by ahatanak, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D36918?vs=148334&id=151102#toc
Reposi
sammccall added a comment.
Generally LG.
I guess you might be able to test this by starting with a/compile_flags.txt and
a/b/x.cc, and then adding a/b/compile_flags.txt?
Comment at: clangd/ClangdLSPServer.h:38
llvm::Optional CompileCommandsDir,
-
Author: sammccall
Date: Tue Jun 12 23:25:36 2018
New Revision: 334572
URL: http://llvm.org/viewvc/llvm-project?rev=334572&view=rev
Log:
[clangd] Log completion context type. NFC
Modified:
clang-tools-extra/trunk/clangd/CodeComplete.cpp
Modified: clang-tools-extra/trunk/clangd/CodeComplete.cp
Author: void
Date: Tue Jun 12 23:33:59 2018
New Revision: 334573
URL: http://llvm.org/viewvc/llvm-project?rev=334573&view=rev
Log:
Remove extraneous semicolon.
Modified:
cfe/trunk/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp
Modified: cfe/trunk/lib/StaticAnalyzer/Core/BugReporterVisitors.
sammccall updated this revision to Diff 151104.
sammccall added a comment.
Fix completion tests. (Simplify a bit - no need to re-test all the nuances of
fuzzy matching there).
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47950
Files:
clangd/FuzzyMatch.cpp
clangd/FuzzyMatc
sammccall added a comment.
@ilya-biryukov ping. I'm excited about this change :-)
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47950
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
Author: hans
Date: Tue Jun 12 23:48:40 2018
New Revision: 334574
URL: http://llvm.org/viewvc/llvm-project?rev=334574&view=rev
Log:
crash-report-modules.m: Shorten path length to make Windows bot happy
Modified:
cfe/trunk/test/Driver/crash-report-modules.m
Modified: cfe/trunk/test/Driver/cras
As a near term fix, I've tried to shorten the path in r334574. Let's
see if the bot likes it.
On Wed, Jun 13, 2018 at 6:34 AM, Galina Kistanova via cfe-commits
wrote:
> That could be the case. However, the bot shall not be left red.
>
> Hans, could you revert the patch for now, till the problem w
101 - 130 of 130 matches
Mail list logo
