[PATCH] D47356: [CMake] Use libc++ and compiler-rt for bootstrap Fuchsia Clang

This revision was automatically updated to reflect the committed changes. Closed by commit rC334445: [CMake] Use libc++ and compiler-rt for bootstrap Fuchsia Clang (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D47356?vs=150841&id=150859#toc Repository:

r334445 - [CMake] Use libc++ and compiler-rt for bootstrap Fuchsia Clang

Author: phosek Date: Mon Jun 11 15:06:44 2018 New Revision: 334445 URL: http://llvm.org/viewvc/llvm-project?rev=334445&view=rev Log: [CMake] Use libc++ and compiler-rt for bootstrap Fuchsia Clang We want to build the second stage compiler with libc++ and compiler-rt, also include builtins and run

[PATCH] D47233: [CodeGen] Emit MSVC RTTI for Obj-C EH types

rjmccall added a comment. The non-fragile Objective-C path — i.e. interoperation with C++ exceptions instead of using `setjmp`/`longjmp` in an utterly-incompatible style — is absolutely the right direction going forward. How does "wrapping an Objective-C exception inside a C++ exception" work?

[clang-tools-extra] r334448 - - Add "AV" as new default acronym. - Add support for "I" and "A" in lowerCamelCase pattern

Author: wizard Date: Mon Jun 11 15:44:06 2018 New Revision: 334448 URL: http://llvm.org/viewvc/llvm-project?rev=334448&view=rev Log: - Add "AV" as new default acronym. - Add support for "I" and "A" in lowerCamelCase pattern Summary: Now we can support property names like "hasADog" correctly. Re

[PATCH] D48039: - Add "AV" as new default acronym. - Add support for "I" and "A" in lowerCamelCase pattern

This revision was automatically updated to reflect the committed changes. Closed by commit rL334448: - Add "AV" as new default acronym. - Add support for "I" and "A" in… (authored by Wizard, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/

[PATCH] D47044: [analyzer] Ensure that we only visit a destructor for a reference if type information is available.

NoQ added a comment. Thanks, this looks very reasonable! I agree that the syntax pointed out by @george.karpenkov is much cleaner. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/LoopWidening.h:30 ProgramStateRef getWidenedLoopState(ProgramStateRef PrevState, +

[PATCH] D47044: [analyzer] Ensure that we only visit a destructor for a reference if type information is available.

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Core/LoopWidening.cpp:89 +new Callback(LCtx, MRMgr, ITraits)); + Finder.matchAST(ASTCtx); + NoQ wrote: > george.karpenkov wrote: > > ormris wrote: > > > george.karpenkov wrote: > > > >

[PATCH] D47233: [CodeGen] Emit MSVC RTTI for Obj-C EH types

smeenai added a comment. Wrapping an Objective-C exception inside a C++ exception means dynamically constructing a C++ exception object and traversing the class hierarchy of the thrown Obj-C object to populate the catchable types array of the C++ exception. Microsoft's C++ runtime will perform

r334457 - [CUDA][HIP] Set kernel calling convention before arrange function

Author: yaxunl Date: Mon Jun 11 17:16:33 2018 New Revision: 334457 URL: http://llvm.org/viewvc/llvm-project?rev=334457&view=rev Log: [CUDA][HIP] Set kernel calling convention before arrange function Currently clang set kernel calling convention for CUDA/HIP after arranging function, which causes

[PATCH] D47733: [CUDA][HIP] Set kernel calling convention before arrange function

This revision was automatically updated to reflect the committed changes. Closed by commit rL334457: [CUDA][HIP] Set kernel calling convention before arrange function (authored by yaxunl, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/

[PATCH] D47958: [CUDA][HIP] Allow CUDA __global__ functions to have amdgpu kernel attributes

yaxunl updated this revision to Diff 150872. yaxunl marked 2 inline comments as done. yaxunl retitled this revision from "[CUDA][HIP] Allow CUDA `__global__` functions to have amdgpu kernel attributes" to "[CUDA][HIP] Allow CUDA __global__ functions to have amdgpu kernel attributes". yaxunl added

[PATCH] D47044: [analyzer] Ensure that we only visit a destructor for a reference if type information is available.

ormris added inline comments. Comment at: lib/StaticAnalyzer/Core/LoopWidening.cpp:89 +new Callback(LCtx, MRMgr, ITraits)); + Finder.matchAST(ASTCtx); + NoQ wrote: > NoQ wrote: > > george.karpenkov wrote: > > > ormris wrote: > > > > george.ka

RE: r334418 - Enable crash recovery tests on Windows, globs work in the lit internal shell now

Hi Reid, I don't know if you noticed, but one of the tests you changed with this commit is failing on the PS4 Windows bot. Can you take a look? http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/17695/ FAIL: Clang :: Driver/crash-report-modules.m (7229 of

[PATCH] D47233: [CodeGen] Emit MSVC RTTI for Obj-C EH types

rjmccall added a comment. In https://reviews.llvm.org/D47233#1129110, @smeenai wrote: > Wrapping an Objective-C exception inside a C++ exception means dynamically > constructing a C++ exception object and traversing the class hierarchy of the > thrown Obj-C object to populate the catchable type

[PATCH] D48027: [analyzer] Improve `CallDescription` to handle c++ method.

MTC added a comment. In https://reviews.llvm.org/D48027#1128301, @xazax.hun wrote: > Having C++ support would be awesome! > Thanks for working on this! > > While I do agree matching is not trivial with qualified names, this problem > is already solved with AST matchers. > > I wonder if using ma

RE: r334418 - Enable crash recovery tests on Windows, globs work in the lit internal shell now

Hi Reid, Actually, it seems all four tests you changed are failing on one Windows bot http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/12464. Can you please take a look and fix the tests? Douglas Yung > -Original Message- > From: cfe-commits [mailto:cfe-commits-boun.

[PATCH] D47687: [Sema] Missing -Wlogical-op-parentheses warnings in macros (PR18971)

Higuoxing added a comment. In https://reviews.llvm.org/D47687#1128757, @dexonsmith wrote: > > Yes, I think understand the patch; but I think it's the wrong direction. I > think we should just make the existing `-Wlogical-op-parentheses` smart > enough to show actionable warnings in macros

[libcxx] r334467 - Update the to-do list with motions from Rapperswil.

Author: marshall Date: Mon Jun 11 19:45:30 2018 New Revision: 334467 URL: http://llvm.org/viewvc/llvm-project?rev=334467&view=rev Log: Update the to-do list with motions from Rapperswil. Modified: libcxx/trunk/www/cxx2a_status.html Modified: libcxx/trunk/www/cxx2a_status.html URL: http://l

[libcxx] r334468 - Reland "Use custom command and target to install libc++ headers"

Author: phosek Date: Mon Jun 11 20:10:02 2018 New Revision: 334468 URL: http://llvm.org/viewvc/llvm-project?rev=334468&view=rev Log: Reland "Use custom command and target to install libc++ headers" Using file(COPY FILE...) has several downsides. Since the file command is only executed at configur

[PATCH] D48062: Fix that AlignedAllocation.h doesn't compile because of VersionTuple

teemperor created this revision. https://reviews.llvm.org/rL334399 put VersionTuple in the llvm namespace, but this header still assumes it's in the clang namespace. This leads to compilation failures with enabled modules when building Clang. Repository: rC Clang https://reviews.llvm.org/D48

[libcxx] r334470 - [CMake] Add a missing target dependency on C++ ABI headers

Author: phosek Date: Mon Jun 11 20:31:03 2018 New Revision: 334470 URL: http://llvm.org/viewvc/llvm-project?rev=334470&view=rev Log: [CMake] Add a missing target dependency on C++ ABI headers This resolves the breakage introduced in r334468 which results in build error when using CMake Makefile g

r334471 - Fix that AlignedAllocation.h doesn't compile because of VersionTuple

Author: teemperor Date: Mon Jun 11 20:43:21 2018 New Revision: 334471 URL: http://llvm.org/viewvc/llvm-project?rev=334471&view=rev Log: Fix that AlignedAllocation.h doesn't compile because of VersionTuple Summary: rL334399 put VersionTuple in the llvm namespace, but this header still assumes it

[PATCH] D48062: Fix that AlignedAllocation.h doesn't compile because of VersionTuple

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC334471: Fix that AlignedAllocation.h doesn't compile because of VersionTuple (authored by teemperor, committed by ). Repo

[PATCH] D47299: [CodeGenCXX] Emit strip.invariant.group with -fstrict-vtable-pointers

rjmccall added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:784 +return !hasDefinition() || !isDynamicClass() || hasAnyDependentBases(); + } + Both of these new methods deserve doc comments explaining that they're conservative checks becau

<    1   2