xazax.hun added a comment.
Herald added a subscriber: mikhail.ramalho.
Just for the record, there is a common example where relying on copy elision
might bite and google do not recommend relying on it for correctness:
https://abseil.io/tips/120
The main purpose of sharing is to add some more co
hamzasood updated this revision to Diff 150649.
hamzasood added a comment.
Addressed Richard's comments.
https://reviews.llvm.org/D40443
Files:
include/clang/Basic/Module.h
lib/Basic/Module.cpp
lib/Sema/SemaDecl.cpp
test/CXX/modules-ts/basic/basic.def.odr/p6/module-vs-module.cpp
test/
hamzasood marked 2 inline comments as done.
hamzasood added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:16185-16194
+ if (getLangOpts().ModulesTS) {
+Module *CurrentModule = getCurrentModule();
+assert(CurrentModule && "Expected to be in a module scope");
+
+/
tkrupa added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:9926
+Value *Div = Builder.CreateFDiv(A, B);
+llvm::VectorType *MaskTy = llvm::VectorType::get(Builder.getInt1Ty(),
+
cast(Mask->getType())->getBitWidth());
c
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D47979
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
Author: ctopper
Date: Sun Jun 10 10:27:05 2018
New Revision: 334366
URL: http://llvm.org/viewvc/llvm-project?rev=334366&view=rev
Log:
[X86] Use target independent masked expandload and compressstore intrinsics to
implement expandload/compressstore builtins.
Summary: We've had these target indepe
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334366: [X86] Use target independent masked expandload and
compressstore intrinsics to… (authored by ctopper, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47693?vs=149657&id=150654
Quuxplusone added inline comments.
Comment at: include/experimental/memory_resource:489
+memory_resource* __res_;
+size_t __next_buffer_size_;
+};
I've discovered that Boost.Container does not bother to preserve this state
across calls to `release()`. If
balazske added a comment.
Problem: This change interferes with https://reviews.llvm.org/D47445. Probably
that should be committed, it is approved already.
Repository:
rC Clang
https://reviews.llvm.org/D47946
___
cfe-commits mailing list
cfe-comm
Author: ctopper
Date: Sun Jun 10 23:18:29 2018
New Revision: 334385
URL: http://llvm.org/viewvc/llvm-project?rev=334385&view=rev
Log:
[X86] Remove masking from dbpsadbw builtins, use select builtin instead.
Modified:
cfe/trunk/include/clang/Basic/BuiltinsX86.def
cfe/trunk/lib/Headers/avx5
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334388: [MS ABI] Mangle unnamed empty enums (PR37723)
(authored by hans, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D47875?vs=150462&id=15
pilki added a comment.
Thanks Alex!
I do not have the submit right, can you take care of it?
Thanks
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47945
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
Author: hans
Date: Sun Jun 10 23:54:23 2018
New Revision: 334388
URL: http://llvm.org/viewvc/llvm-project?rev=334388&view=rev
Log:
[MS ABI] Mangle unnamed empty enums (PR37723)
Differential Revision: https://reviews.llvm.org/D47875
Modified:
cfe/trunk/lib/AST/MicrosoftMangle.cpp
cfe/trun
13 matches
Mail list logo