Author: maskray
Date: Sun Jun 3 01:12:15 2018
New Revision: 333836
URL: http://llvm.org/viewvc/llvm-project?rev=333836&view=rev
Log:
clang-interpreter: Add missing LLVM component Object
Modified:
cfe/trunk/examples/clang-interpreter/CMakeLists.txt
Modified: cfe/trunk/examples/clang-interpre
mephi42 added a comment.
This change is very useful for me (I even rebuilt my clang-format with it), but
there were no updates for quite some time - do you still intend to integrate it?
Apologies in advance if Phabricator is not the right place for such discussions.
Repository:
rC Clang
htt
RKSimon added inline comments.
Comment at: test/CodeGen/sse2-builtins.c:1199
// CHECK-LABEL: test_mm_sqrt_sd
- // CHECK: call <2 x double> @llvm.x86.sse2.sqrt.sd(<2 x double> %{{.*}})
- // CHECK: extractelement <2 x double> %{{.*}}, i32 0
- // CHECK: insertelement <2 x doub
whisperity requested changes to this revision.
whisperity added a comment.
This revision now requires changes to proceed.
In general, make sure the documentation page renders well in a browser.
Mostly style and phrasing stuff inline:
Comment at: clang-tidy/bugprone/NotNullTerm
Higuoxing created this revision.
Herald added a subscriber: cfe-commits.
Higuoxing edited the summary of this revision.
Hi,
As you see, to avoid some expression like
assert(x || y && "some messages");
clang will skip all the parentheses check if the expression is in `macro`;
and this rule is
Higuoxing added a comment.
As for some test cases,
$ cat a.cc
#include
#include
#define bar(x) \
( \
( std::cout << x ) \
)
bool x;
int val;
void foo(bool b) {
std::cout << b << std::endl;
}
int main () {
foo(x && val == 4 || (!x && v
lebedev.ri added reviewers: rsmith, aaron.ballman.
lebedev.ri added a comment.
Tests?
Repository:
rC Clang
https://reviews.llvm.org/D47687
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
lebedev.ri added a comment.
In https://reviews.llvm.org/D47687#1120213, @Higuoxing wrote:
> As for some test cases,
The tests need to be within the patch itself, in this case
i guess that should go into `clang/test/Sema/`.
See other tests in there on how to write them.
And they will be run via
Higuoxing added a comment.
In https://reviews.llvm.org/D47687#1120226, @lebedev.ri wrote:
> In https://reviews.llvm.org/D47687#1120213, @Higuoxing wrote:
>
> > As for some test cases,
>
>
> The tests need to be within the patch itself, in this case
> i guess that should go into `clang/test/Sema/
mikhail.ramalho updated this revision to Diff 149653.
mikhail.ramalho added a comment.
Update patch based on https://reviews.llvm.org/D47640 and
https://reviews.llvm.org/D47689.
I updated the test case as the cross check is not marking the true bug as
invalid anymore.
My `make clang-test` is s
mikhail.ramalho added inline comments.
Comment at: lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:2366
+
+ SMTConstraintManager *SMTRefutationMgr =
+ static_cast(RefutationMgr.get());
I'm not happy about this cast. Suggestions are welcome.
https://review
Hahnfeld added a comment.
In https://reviews.llvm.org/D47394#1119489, @gtbercea wrote:
> In https://reviews.llvm.org/D47394#1119056, @Hahnfeld wrote:
>
> > Hmm, maybe the scope is much larger: I just tried linking an executable
> > that references a `declare target` function in a shared library.
Author: ctopper
Date: Sun Jun 3 11:08:37 2018
New Revision: 333848
URL: http://llvm.org/viewvc/llvm-project?rev=333848&view=rev
Log:
[X86] Pass ArrayRef instead of SmallVectorImpl& to the X86 builtin helper
functions. NFC
Modified:
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
Modified: cfe/trunk/li
Author: ctopper
Date: Sun Jun 3 11:08:34 2018
New Revision: 333846
URL: http://llvm.org/viewvc/llvm-project?rev=333846&view=rev
Log:
[X86] Mark the pointer arguments to expandload builtins as const consistently.
Some of them had it and some didn't. This should make them consistent.
Modified:
Author: ctopper
Date: Sun Jun 3 11:08:36 2018
New Revision: 333847
URL: http://llvm.org/viewvc/llvm-project?rev=333847&view=rev
Log:
[X86] When emitting masked loads/stores don't check for all ones mask.
This seems like a premature optimization. It's unlikely a user would pass
something the fro
Author: ctopper
Date: Sun Jun 3 11:41:22 2018
New Revision: 333850
URL: http://llvm.org/viewvc/llvm-project?rev=333850&view=rev
Log:
Revert r333848 "[X86] Pass ArrayRef instead of SmallVectorImpl& to the X86
builtin helper functions. NFC"
Looks like I missed some changes to make this work.
Mod
Author: ctopper
Date: Sun Jun 3 12:02:57 2018
New Revision: 333851
URL: http://llvm.org/viewvc/llvm-project?rev=333851&view=rev
Log:
[X86] Pass ArrayRef instead of SmallVectorImpl& to the X86 builtin helper
functions. NFC
Modified:
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
Modified: cfe/trunk/li
Hahnfeld abandoned this revision.
Hahnfeld added a comment.
Superseded by https://reviews.llvm.org/D47691
Repository:
rC Clang
https://reviews.llvm.org/D47070
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
Author: ctopper
Date: Sun Jun 3 12:42:59 2018
New Revision: 333853
URL: http://llvm.org/viewvc/llvm-project?rev=333853&view=rev
Log:
[X86] Replace __builtin_ia32_vbroadcastf128_pd256 and
__builtin_ia32_vbroadcastf128_ps256 with an unaligned load intrinsics and a
__builtin_shufflevector call.
M
george.karpenkov requested changes to this revision.
george.karpenkov added a comment.
This revision now requires changes to proceed.
> I updated the test case as the cross check is not marking the true bug as
> invalid anymore.
Awesome! Does it mean that the optimization for adding less constra
Author: ctopper
Date: Sun Jun 3 15:05:19 2018
New Revision: 333855
URL: http://llvm.org/viewvc/llvm-project?rev=333855&view=rev
Log:
[X86] Explicitly make the arguments to __slwpcb intrinsic 'void'.
This is the correct way to say it takes no arguments in C.
Modified:
cfe/trunk/lib/Headers/l
mikhail.ramalho added a subscriber: rnkovacs.
mikhail.ramalho added a comment.
> Awesome! Does it mean that the optimization for adding less constraints
> was in fact buggy?
I pretty sure it was not related to the optimizations, I removed them days
ago (in the previous version of this patch) and
craig.topper created this revision.
craig.topper added reviewers: RKSimon, delena, spatel, GBuella.
Herald added a subscriber: cfe-commits.
We've had these target independent intrinsics for at least a year and a half.
Looks like they do exactly what we need here and the backend already supports
george.karpenkov added a comment.
> I pretty sure it was not related to the optimizations, I removed them days
ago (in the previous version of this patch) and the bug was still there.
OK so any idea what the change could have been? Clearly the bug was there but
not now. Anyway, should be OK to
shuaiwang updated this revision to Diff 149659.
shuaiwang marked 5 inline comments as done.
shuaiwang added a comment.
Handle sizeof on VLA.
Added test case for typeof()
Added TODO for handling typeid and generic selection.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45679
F
shuaiwang added inline comments.
Comment at: clang-tidy/utils/ExprMutationAnalyzer.cpp:34-38
+const ast_matchers::internal::VariadicDynCastAllOfMatcher
+cxxTypeidExpr;
+
+const ast_matchers::internal::VariadicDynCastAllOfMatcher
+cxxNoexceptExpr;
aaron.ba
Author: ctopper
Date: Sun Jun 3 16:31:01 2018
New Revision: 333858
URL: http://llvm.org/viewvc/llvm-project?rev=333858&view=rev
Log:
[X86] Remove superfluous escaped new lines from intrinsic files.
Modified:
cfe/trunk/lib/Headers/avx512fintrin.h
Modified: cfe/trunk/lib/Headers/avx512fintrin
yaxunl created this revision.
yaxunl added reviewers: rjmccall, tra.
CUDA/HIP does not support RTTI on device side, therefore there
is no point of emitting type info when compiling for device.
Emitting type info for device not only clutters the IR with useless
global variables, but also causes un
yaxunl added a comment.
ping
https://reviews.llvm.org/D47376
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
shuaiwang updated this revision to Diff 149661.
shuaiwang marked 4 inline comments as done.
shuaiwang added a comment.
Handle typeid and generic selection.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45679
Files:
clang-tidy/utils/CMakeLists.txt
clang-tidy/utils/ExprMutat
shuaiwang added a comment.
Overestimated the work of supporting typeid and _Generic, done now.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45679
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
This revision was automatically updated to reflect the committed changes.
Closed by commit rC333862: Moved RangedConstraintManager header to the
StaticAnalyser include dir (authored by mramalho, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://reviews.llv
mikhail.ramalho updated this revision to Diff 149664.
mikhail.ramalho edited the summary of this revision.
mikhail.ramalho added a comment.
Fix naming issue.
https://reviews.llvm.org/D45517
Files:
include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
include/clang/StaticAnalyzer/Core/BugRepor
rjmccall added a comment.
Why not just have the driver disable RTTI in the frontend invocation?
https://reviews.llvm.org/D47694
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
HLJ2009 updated this revision to Diff 149665.
HLJ2009 added a comment.
update test case.
Repository:
rC Clang
https://reviews.llvm.org/D46805
Files:
include/clang/Basic/Attr.td
test/Sema/attr-alias-has.c
test/Sema/attr-alias.c
Index: test/Sema/attr-alias.c
===
Author: ctopper
Date: Sun Jun 3 19:56:18 2018
New Revision: 333865
URL: http://llvm.org/viewvc/llvm-project?rev=333865&view=rev
Log:
[X86] Fix a couple places that were using macro arguments twice when of the
usages could just be undefined.
One of the arguments was being used when the passthru
yaxunl added a comment.
In https://reviews.llvm.org/D47694#1120367, @rjmccall wrote:
> Why not just have the driver disable RTTI in the frontend invocation?
CUDA/HIP uses single source for device and host. The host code may depend on
RTTI,
e.g., an application may include some boost headers wh
malaperle added a comment.
In https://reviews.llvm.org/D47643#1119187, @sammccall wrote:
> @malaperle: would you mind patching this in and checking whether attaching a
> debugger still works on Mac (this was the reason for the EINTR loop, right?)
>
> I want to preserve this but now people other
MTC added inline comments.
Comment at: include/clang/Analysis/ConstructionContext.h:351
+
+ explicit SimpleTemporaryObjectConstructionContext(
+ const CXXBindTemporaryExpr *BTE, const MaterializeTemporaryExpr *MTE)
`explicit` useless?
Com
39 matches
Mail list logo