a.sidorin accepted this revision.
a.sidorin added a comment.
This revision is now accepted and ready to land.
Hi Gabor,
LGTM, thank you for addressing the comments! Just a minor nit, it's OK to fix
it before committing without a separate review.
Comment at: unittests/AST/Stru
vsk added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:72
+ // Set debug location in order to preserve the scope
+ Alloca->setDebugLoc(Builder.getCurrentDebugLocation());
if (AllocaAddr)
I think we need to be a bit more careful here. The current debug
Author: eugenezelenko
Date: Wed May 23 10:39:46 2018
New Revision: 333104
URL: http://llvm.org/viewvc/llvm-project?rev=333104&view=rev
Log:
[Documentation] Fix link syntax in Release Notes.
Modified:
clang-tools-extra/trunk/docs/ReleaseNotes.rst
Modified: clang-tools-extra/trunk/docs/Release
mgrang accepted this revision.
mgrang added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: lib/Driver/ToolChains/Gnu.cpp:1885
+ "riscv64-unknown-linux-gnu",
+
Author: ahatanak
Date: Wed May 23 10:50:41 2018
New Revision: 333108
URL: http://llvm.org/viewvc/llvm-project?rev=333108&view=rev
Log:
Do not define template specialization __libcpp_is_floating_point<__fp16>
if the compiler is not clang.
gcc doesn't allow using __fp16 on non-ARM targets.
Modifie
lebedev.ri abandoned this revision.
lebedev.ri added a comment.
https://reviews.llvm.org/D46187#1098571
Sad, but ok.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46188
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
lebedev.ri abandoned this revision.
lebedev.ri added a comment.
Sad, but ok.
Repository:
rC Clang
https://reviews.llvm.org/D46187
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
craig.topper updated this revision to Diff 148252.
craig.topper added a comment.
Add back popcntintrin.h
https://reviews.llvm.org/D47182
Files:
lib/Headers/cldemoteintrin.h
lib/Headers/clzerointrin.h
lib/Headers/immintrin.h
lib/Headers/movdirintrin.h
lib/Headers/pconfigintrin.h
lib/
vsapsai added a comment.
Somewhat tangential, in discussion with Duncan he mentioned that `-nostdinc++`
should turn off assumptions about old Darwin. So if you build libc++ yourself,
you don't care what does the system stdlib support. I agree with that and think
it doesn't interfere with the la
DavidKreitzer accepted this revision.
DavidKreitzer added a comment.
This revision is now accepted and ready to land.
Thanks, Craig. LGTM.
https://reviews.llvm.org/D47182
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
leonardchan added inline comments.
Comment at: include/clang/Basic/DiagnosticCommonKinds.td:172
+def err_fixed_point_only_allowed_in_c : Error<
+ "Fixed point types are only allowed in C">;
leonardchan wrote:
> rsmith wrote:
> > Diagnostics should not be capit
ilya-biryukov created this revision.
ilya-biryukov added reviewers: ioeric, sammccall.
Herald added subscribers: jkorous, MaskRay, javed.absar, klimek.
This is more efficient and avoids data races when reading files that
come from the preamble. The staleness can occur when reading a file
from disk
benlangmuir created this revision.
benlangmuir added reviewers: yamaguchi, v.g.vassilev, ruiu, teemperor.
Herald added a subscriber: cfe-commits.
We have a regex that needs to match a tab character in the command output, but
on macOS `sed` doesn't support '\t', causing it to split on the 't' char
malaperle added a comment.
> We do not to rely on symbols from the main file anyway, since any info hat
> those provide can always be taken from the AST.
I'll be adding those soon for workspace symbols... And also for document
symbols.
Repository:
rCTE Clang Tools Extra
https://reviews.llv
dmgreen added a comment.
> In my experience, they are used.
Good to know, cheers.
> Could we maybe disable the #pragma clang loop unroll_and_jam spelling ftm to
> avoid compatibility issues?
Sure, I'm not against. It sounds like you have opinions on how this should
work. That's good. If there
jfb added a comment.
> Actually, scratch that. We will be enabling it since GCC does. Will update
> this and other relevant C++ related code appropriately.
Could you also add tests which mix _Accum with volatile, _Atomic, _Complex,
constexpr, inline?
Repository:
rC Clang
https://reviews.ll
ilya-biryukov added a comment.
In https://reviews.llvm.org/D47272#1109909, @malaperle wrote:
> > We do not to rely on symbols from the main file anyway, since any info hat
> > those provide can always be taken from the AST.
>
> I'll be adding those soon for workspace symbols... And also for docu
This revision was automatically updated to reflect the committed changes.
Closed by commit rL333110: [X86] Move all Intel defined intrinsic includes into
immintrin.h (authored by ctopper, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/
malaperle added a comment.
In https://reviews.llvm.org/D47272#1109914, @ilya-biryukov wrote:
> In https://reviews.llvm.org/D47272#1109909, @malaperle wrote:
>
> > > We do not to rely on symbols from the main file anyway, since any info
> > > hat those provide can always be taken from the AST.
>
ilya-biryukov added a comment.
@malaperle, a slight offtopic. I was wondering which completion options do you
use for clangd? Defaults?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47272
___
cfe-commits mailing list
cfe-commits@l
Author: ctopper
Date: Wed May 23 11:32:58 2018
New Revision: 333110
URL: http://llvm.org/viewvc/llvm-project?rev=333110&view=rev
Log:
[X86] Move all Intel defined intrinsic includes into immintrin.h
This matches the Intel documentation which shows them available by importing
immintrin.h. x86intr
aprantl added a comment.
Once we encounter a # directive we are (most likely) looking at some form of
preprocessed source and that means that the checksum will inevitably be
different than what we would have gotten were we reading the file directly,
because of the preprocessing. At this point t
ilya-biryukov updated this revision to Diff 148262.
ilya-biryukov added a comment.
- Added forgotten renames
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47272
Files:
clangd/ClangdServer.cpp
clangd/ClangdUnit.cpp
clangd/ClangdUnit.h
clangd/TUScheduler.cpp
clangd/TUS
aprantl added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:72
+ // Set debug location in order to preserve the scope
+ Alloca->setDebugLoc(Builder.getCurrentDebugLocation());
if (AllocaAddr)
vsk wrote:
> I think we need to be a bit more careful here.
ruiu added a comment.
Even though Perl may be installed to 99.99% of machines that use this
autocomplete script, using perl instead of sed is too much. If we could use
perl, we'd have wrote this script entirely in perl in the first place. We
shouldn't add a dependency to perl.
I wonder if you
ilya-biryukov created this revision.
ilya-biryukov added a reviewer: sammccall.
Herald added subscribers: jkorous, MaskRay, ioeric, klimek.
To fix a crash in code completion that occurrs when reading doc
comments from files that were updated after the preamble was
computed. In that case, the files
benlangmuir added a comment.
In https://reviews.llvm.org/D47273#1109934, @ruiu wrote:
> I wonder if you could replace \t with \0x09. At least it works on my machine
> which has GNU sed.
Unfortunately that doesn't work either on mac :-\
Repository:
rC Clang
https://reviews.llvm.org/D47273
Meinersbur added a comment.
In https://reviews.llvm.org/D47267#1109912, @dmgreen wrote:
> > Could we maybe disable the #pragma clang loop unroll_and_jam spelling ftm
> > to avoid compatibility issues?
>
> Sure, I'm not against. It sounds like you have opinions on how this should
> work. That's
ruiu added a comment.
How about
sed -e "$(echo -e 's/\t.*//')"
?
Repository:
rC Clang
https://reviews.llvm.org/D47273
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tra added inline comments.
Comment at: lib/Driver/ToolChains/HIP.cpp:29-47
+static bool addBCLib(Compilation &C, const ArgList &Args,
+ ArgStringList &CmdArgs, ArgStringList LibraryPaths,
+ StringRef BCName) {
+ StringRef FullName;
+ bool
benlangmuir added a comment.
In https://reviews.llvm.org/D47273#1109985, @ruiu wrote:
> sed -e "$(echo -e 's/\t.*//')"
Yep, that works! Is there a reason you prefer that over the more succinct
`$'s/\t.*//'`?
Repository:
rC Clang
https://reviews.llvm.org/D47273
__
ruiu added a comment.
Oh, I didn't know the existence of $''. Thank you for the suggestion! I wonder
which version of bash started supporting that notation. Do you know if all
recent versions of bash support it? Unfortunately `$'' bash` is very hard query
to google...
Repository:
rC Clang
ruiu added a comment.
(I found that information at
http://wiki.bash-hackers.org/scripting/bashchanges#quoting_expansions_substitutions_and_related)
Repository:
rC Clang
https://reviews.llvm.org/D47273
___
cfe-commits mailing list
cfe-commits@lis
ruiu added a comment.
Looks like $'' is there since bash 2.0 which should be pretty safe to use in
the script. So feel free to use $'' instead of $(echo ...) in this patch.
Repository:
rC Clang
https://reviews.llvm.org/D47273
___
cfe-commits mai
teemperor created this revision.
teemperor added reviewers: rsmith, slydiman.
Since clang r332929 these two headers throw errors when included from somewhere
else than their wrapper header. It seems marking them as textual is the best
way to fix the builds.
Fixes this new module build error:
malcolm.parsons added inline comments.
Comment at:
clang-tools-extra/trunk/clang-tidy/readability/SimplifyBooleanExprCheck.cpp:198
E = E->ignoreParenBaseCasts();
+ if (const auto *EC = dyn_cast(E))
+E = EC->getSubExpr();
zinovy.nis wrote:
> zinovy.nis wr
teemperor edited reviewers, added: v.g.vassilev; removed: slydiman.
teemperor added a comment.
(Wrong Vassil, sorry)
https://reviews.llvm.org/D47277
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
aemerson added a comment.
Hi Craig,
The `__builtin_ia32_cvtdq2ps` builtin seems to be supported by gcc, and this
change breaks code which has been using this without problems for years. Can we
restore it?
Amara
Repository:
rC Clang
https://reviews.llvm.org/D46863
__
vsk added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:72
+ // Set debug location in order to preserve the scope
+ Alloca->setDebugLoc(Builder.getCurrentDebugLocation());
if (AllocaAddr)
aprantl wrote:
> vsk wrote:
> > I think we need to be a bit more
aprantl added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:72
+ // Set debug location in order to preserve the scope
+ Alloca->setDebugLoc(Builder.getCurrentDebugLocation());
if (AllocaAddr)
vsk wrote:
> aprantl wrote:
> > vsk wrote:
> > > I think we
vsk added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:72
+ // Set debug location in order to preserve the scope
+ Alloca->setDebugLoc(Builder.getCurrentDebugLocation());
if (AllocaAddr)
aprantl wrote:
> vsk wrote:
> > aprantl wrote:
> > > vsk wrote:
craig.topper added a comment.
Hi @aemerson, I'm not opposed to adding it back. But the clang policy for
vector builtins has always been that we won't support all the builtins that gcc
does and to encourage the use of the _mm_* wrappers which are guaranteed to
work in both compilers. It possible
yaxunl marked 6 inline comments as done.
yaxunl added inline comments.
Comment at: lib/Driver/ToolChains/HIP.cpp:29-47
+static bool addBCLib(Compilation &C, const ArgList &Args,
+ ArgStringList &CmdArgs, ArgStringList LibraryPaths,
+ String
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D47277
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
benlangmuir updated this revision to Diff 148278.
benlangmuir edited the summary of this revision.
benlangmuir added a comment.
Thanks for looking up the supported bash version! Updated diff.
https://reviews.llvm.org/D47273
Files:
utils/bash-autocomplete.sh
Index: utils/bash-autocomplete.
yaxunl updated this revision to Diff 148277.
yaxunl marked 6 inline comments as done.
yaxunl added a comment.
Revised by Artem's comments.
https://reviews.llvm.org/D45212
Files:
include/clang/Driver/Options.td
lib/Driver/CMakeLists.txt
lib/Driver/Driver.cpp
lib/Driver/ToolChains/HIP.cpp
ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D47273
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
One small nit. LGTM otherwise.
Comment at: lib/Driver/ToolChains/HIP.cpp:44
+ }
+ if (!FoundLibDevice)
+C.getDriver().Diag(diag::err_drv_no_such_file) << BCName;
steven_wu created this revision.
steven_wu added reviewers: erik.pilkington, arphaman, doug.gregor.
Remove the call to DiagnoseUseOfDecl in LookupMemberExpr because:
1. LookupMemberExpr eagerly lookup both getter and setter, reguardless
if they are used or not. It causes wrong diagnostics if you
aprantl added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:72
+ // Set debug location in order to preserve the scope
+ Alloca->setDebugLoc(Builder.getCurrentDebugLocation());
if (AllocaAddr)
vsk wrote:
> aprantl wrote:
> > vsk wrote:
> > > aprantl wro
yaxunl marked an inline comment as done.
yaxunl added inline comments.
Comment at: lib/Driver/ToolChains/HIP.cpp:44
+ }
+ if (!FoundLibDevice)
+C.getDriver().Diag(diag::err_drv_no_such_file) << BCName;
tra wrote:
> You don't need FoundLibDevice any more as
Author: teemperor
Date: Wed May 23 13:59:46 2018
New Revision: 333123
URL: http://llvm.org/viewvc/llvm-project?rev=333123&view=rev
Log:
[modules] Mark __wmmintrin_pclmul.h/__wmmintrin_aes.h as textual
Summary:
Since clang r332929 these two headers throw errors when included from somewhere
else t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL333123: [modules] Mark
__wmmintrin_pclmul.h/__wmmintrin_aes.h as textual (authored by teemperor,
committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.o
Author: ctopper
Date: Wed May 23 14:04:26 2018
New Revision: 333124
URL: http://llvm.org/viewvc/llvm-project?rev=333124&view=rev
Log:
[X86] Move the include of clzerointrin.h from immintrin.h back to x86intrin.h.
This is an AMD intrinsic not an Intel intrinsic so it shouldn't be in
immintrin.h
rjmccall added a comment.
In https://reviews.llvm.org/D47108#1109145, @Prazek wrote:
> In https://reviews.llvm.org/D47108#1109014, @rjmccall wrote:
>
> > I thought we already had places in Sema that marked inline virtual methods
> > as used, instantiated templates, etc. for devirtualization purp
Author: rsmith
Date: Wed May 23 14:18:00 2018
New Revision: 333126
URL: http://llvm.org/viewvc/llvm-project?rev=333126&view=rev
Log:
Rework __builtin_classify_type support to better match GCC and to not assert on
unusual types.
Following the observed behavior of GCC, we now return -1 for vector t
mikerice added a comment.
Ping. Still looking for a reviewer, mostly Lex and clang-cl driver changes.
https://reviews.llvm.org/D46652
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
whitequark added a comment.
@compnerd ping
Repository:
rUNW libunwind
https://reviews.llvm.org/D46971
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jfb created this revision.
jfb added reviewers: ahatanak, vsapsai, alexshap, aaron.ballman, javed.absar,
jfb, rjmccall.
Herald added subscribers: cfe-commits, aheejin, kristof.beyls.
Pick https://reviews.llvm.org/D42933 back up, and make NSInteger/NSUInteger
with %zu/%zi specifiers on Darwin war
Sunil_Srivastava created this revision.
Herald added a subscriber: cfe-commits.
This patch changes the wording of two errors to make them more generic.
An attempt to use dynamic_cast while rtti is disabled, curently emits the error:
cannot use dynamic_cast with -fno-rtti
and a similar one for
alexshap added inline comments.
Comment at: test/FixIt/fixit-format-ios-nopedantic.m:21
+ printf("test 4: %zd %zd", getNSInteger(), getNSInteger());
+}
maybe i'm missing smth, but i don't see any verification in this test.
Repository:
rC Clang
https://revie
jfb marked an inline comment as done.
jfb added inline comments.
Comment at: test/FixIt/fixit-format-ios-nopedantic.m:21
+ printf("test 4: %zd %zd", getNSInteger(), getNSInteger());
+}
alexshap wrote:
> maybe i'm missing smth, but i don't see any verification in
bruno created this revision.
bruno added a reviewer: rsmith.
Not doing so causes the AST writter to assert since the decl in question never
gets emitted. This is fine when modules is not used, but otherwise we need to
serialize something other than garbage.
rdar://problem/39844933
Repository:
Prazek created this revision.
Prazek added reviewers: rjmccall, rsmith, amharc, kuhar.
Herald added a subscriber: llvm-commits.
Emmiting new intrinsic that strips invariant.groups to make
devirtulization sound, as described in RFC: Devirtualization v2.
Repository:
rL LLVM
https://reviews.llv
Prazek added inline comments.
Comment at: clang/lib/CodeGen/CGExpr.cpp:3858
+}
+ }
+
rjmccall wrote:
> Please add a comment explaining why this is necessary. (I'm actually not
> sure why it is, because surely the invariant groups we generate don't contain
Prazek updated this revision to Diff 148313.
Prazek marked 2 inline comments as done.
Prazek added a comment.
Slitted commit into defining and using intrinsic
Repository:
rL LLVM
https://reviews.llvm.org/D47103
Files:
llvm/docs/LangRef.rst
llvm/include/llvm/IR/IRBuilder.h
llvm/include/
lhames accepted this revision.
lhames added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: mgrang.
Looks good to me. :)
Repository:
rC Clang
https://reviews.llvm.org/D45897
___
cfe-commits mailing list
cfe-
bruno created this revision.
bruno added reviewers: ributzka, vsapsai, dexonsmith.
Framework vendors usually layout their framework headers in the following way:
Foo.framework/Headers -> "public" headers
Foo.framework/PrivateHeader -> "private" headers
Since both headers in both directories
bruno updated this revision to Diff 148317.
bruno added a comment.
Update to a more recent version of the patch.
https://reviews.llvm.org/D47301
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticLexKinds.td
lib/Lex/HeaderSearch.cpp
test/Modules/Inputs/framewor
rsmith added a comment.
In https://reviews.llvm.org/D45015#1109049, @ahatanak wrote:
> - Currently clang errors out when aligned operator new is selected but the
> OS's version is too old to support it. What's the reason we want to change
> this now to be a warning rather than an error?
I thi
Author: rsmith
Date: Wed May 23 16:41:38 2018
New Revision: 333141
URL: http://llvm.org/viewvc/llvm-project?rev=333141&view=rev
Log:
Use zeroinitializer for (trailing zero portion of) large array initializers
more reliably.
This re-commits r333044 with a fix for PR37560.
Modified:
cfe/trunk/
bruno added a comment.
Hi Eugene,
> You could just not include new warning into -Wall and -Wextra. Those who will
> want to check #include statements correctness could enable it explicitly.
This is exactly what's happening in the patch, the new warning isn't part of
`-Wall` or `-Wextra`, and i
yamaguchi accepted this revision.
yamaguchi added a comment.
LGTM
https://reviews.llvm.org/D47273
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Eugene.Zelenko added a comment.
In https://reviews.llvm.org/D47157#1110430, @bruno wrote:
> Hi Eugene,
>
> > You could just not include new warning into -Wall and -Wextra. Those who
> > will want to check #include statements correctness could enable it
> > explicitly.
>
> This is exactly what's
ahatanak added a comment.
Herald added a subscriber: llvm-commits.
Could you rebase this patch against ToT?
Also, it's not clear to me why only four Exprs (DeclRefExpr, MemberExpr,
ObjCIvarRefExpr, and ObjCPropertyRefExpr) should have the IsTypoCorrected flag.
Can you elaborate on how you chose
rsmith added inline comments.
Comment at: clang/include/clang/AST/DeclCXX.h:779
+ bool mayBeDynamicClass() const {
+return !isCompleteDefinition() || isDynamicClass();
+ }
`isCompleteDefinition` checks whether this declaration of the class is a
definition,
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet,
rnkovacs.
Herald added subscribers: cfe-commits, baloghadamsoftware.
As noticed in http://lists.llvm.org/pipermail/cfe-dev/2018-May/058055.html we
need a path-sensitive program state trait
leonardchan added inline comments.
Comment at: include/clang/Basic/DiagnosticCommonKinds.td:172
+def err_fixed_point_only_allowed_in_c : Error<
+ "Fixed point types are only allowed in C">;
leonardchan wrote:
> leonardchan wrote:
> > rsmith wrote:
> > > Diagno
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rC Clang
https://reviews.llvm.org/D47280
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
Author: steven_wu
Date: Wed May 23 18:01:43 2018
New Revision: 333148
URL: http://llvm.org/viewvc/llvm-project?rev=333148&view=rev
Log:
[Sema][ObjC] Do not DiagnoseUseOfDecl in LookupMemberExpr
Summary:
Remove the call to DiagnoseUseOfDecl in LookupMemberExpr because:
1. LookupMemberExpr eagerly
This revision was automatically updated to reflect the committed changes.
Closed by commit rC333148: [Sema][ObjC] Do not DiagnoseUseOfDecl in
LookupMemberExpr (authored by steven_wu, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47280?vs=148279&id=148327#toc
Repository:
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet,
rnkovacs.
Herald added subscribers: cfe-commits, baloghadamsoftware.
`getLocationForConstructedObject()` looks at the construction context and
figures out what region should represent the o
rsmith added a comment.
Thanks! This looks like exactly the right way to compute when to apply NRVO.
It'd be good to track (in your commit message at least) that this addresses
PR13067.
Comment at: lib/Sema/SemaDecl.cpp:12760
// to deduce an implicit return type.
-
arphaman added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:3497
+else if (Form == Copy || Form == Xchg) {
+ if (!IsC11 && !IsN)
+// The value pointer is always dereferenced, a nullptr is
undefined.
Nit: might make more sen
george.karpenkov requested changes to this revision.
george.karpenkov added a comment.
This revision now requires changes to proceed.
Definitely looks much cleaner, some nits inline. Can we protect against API
misuse?
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet,
rnkovacs.
Herald added subscribers: cfe-commits, baloghadamsoftware.
As explained in http://lists.llvm.org/pipermail/cfe-dev/2018-May/058055.html,
`findDirectConstructorForCurrentCFGElement
malaperle updated this revision to Diff 148329.
malaperle added a comment.
Use "SupportGlobalCompletion", white-list decl contexts, add more tests
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44954
Files:
clangd/CodeComplete.cpp
clangd/index/Index.h
clangd/index/MemInde
malaperle added a comment.
In https://reviews.llvm.org/D47223#1109247, @ilya-biryukov wrote:
> I'm not sure if we have tests for that, but I remember that we kept the
> enumerators in the outer scope so that completion could find them..
> Am I right that this patch will change the behavior and
leonardchan added a comment.
After further discussion, we think the best approach for now would be only
supporting fixed point types in C, then go back and support C++ once there is a
standardized way for mangling the fixed point types under itanium.
Repository:
rC Clang
https://reviews.llv
rjmccall added inline comments.
Comment at: clang/lib/CodeGen/CGExpr.cpp:3858
+}
+ }
+
Prazek wrote:
> rjmccall wrote:
> > Please add a comment explaining why this is necessary. (I'm actually not
> > sure why it is, because surely the invariant groups we g
rjmccall added inline comments.
Comment at: include/clang/Basic/DiagnosticCommonKinds.td:172
+def err_fixed_point_only_allowed_in_c : Error<
+ "Fixed point types are only allowed in C">;
leonardchan wrote:
> leonardchan wrote:
> > leonardchan wrote:
> > > rsmi
ahatanak updated this revision to Diff 148334.
ahatanak added a comment.
Add a test case for the Chromium failure. Also, simplify a bit by capturing the
calling context in Sema::DeduceTemplateArguments.
Repository:
rC Clang
https://reviews.llvm.org/D36918
Files:
lib/Sema/SemaTemplateDeduc
Author: echristo
Date: Wed May 23 23:00:50 2018
New Revision: 333154
URL: http://llvm.org/viewvc/llvm-project?rev=333154&view=rev
Log:
Migrate libcalls-fno-builtin.c test from checking optimized assembly
to checking for attributes on the call site - and fix up builtin
functions that we were testin
Author: echristo
Date: Wed May 23 23:09:28 2018
New Revision: 333156
URL: http://llvm.org/viewvc/llvm-project?rev=333156&view=rev
Log:
Add Builtins.def support for fread and fwrite to ensure that -fno-builtin-
works with them and test accordingly.
Modified:
cfe/trunk/include/clang/Basic/Built
This revision was automatically updated to reflect the committed changes.
Closed by commit rC333157: [Sparc] Use the leon arch for Leon3's when
using an external assembler (authored by dcederman, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D47138
Files:
lib/Driver/ToolCha
CarlosAlbertoEnciso added a comment.
Ping.
Thanks
https://reviews.llvm.org/D46190
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
GBuella updated this revision to Diff 148341.
GBuella added a comment.
Relocated header inclusion from x86intrin.h -> immintrin.h
I gave up on the MSVC intrinsic idea, it wouldn't work in a way compatible with
MSVC as long as LLVM requires the feature to be enabled anyways. If once we
decide to
101 - 197 of 197 matches
Mail list logo
