I should have fixed it in r332576.
On Wed, May 16, 2018 at 11:49 PM, Galina Kistanova via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Also few other builders are affected:
>
> http://lab.llvm.org:8011/builders/clang-x86_64-linux-abi-test
> http://lab.llvm.org:8011/builders/clang-lld-x86_64
phosek added inline comments.
Comment at: lib/Index/USRGeneration.cpp:691
+case BuiltinType::ULongAccum:
+ llvm_unreachable("No USR name mangling for fixed point types.");
case BuiltinType::Float16:
We need some solution for fixed point
Author: yvvan
Date: Thu May 17 00:31:29 2018
New Revision: 332578
URL: http://llvm.org/viewvc/llvm-project?rev=332578&view=rev
Log:
[libclang] Allow skipping function bodies in preamble only
As an addition to CXTranslationUnit_SkipFunctionBodies, provide the
new option CXTranslationUnit_LimitSkip
This revision was automatically updated to reflect the committed changes.
Closed by commit rC332578: [libclang] Allow skipping function bodies in
preamble only (authored by yvvan, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D45815?vs=145648&id=147253#toc
Repository:
rC
devnexen added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:1560-1566
// If the size is known to be zero, we're done.
if (StateZeroSize && !StateNonZeroSize) {
StateZeroSize = StateZeroSize->BindExpr(CE, LCtx, DstVal);
yvvan added a comment.
Tests run fine but the solution feels like a workaround.
Nevertheless if we are sure that extending the subscript/call operator range
does not work properly or breaks too many other things than it's probably fine
to have this workaround.
https://reviews.llvm.org/D40481
Author: jolesiak
Date: Thu May 17 01:35:15 2018
New Revision: 332582
URL: http://llvm.org/viewvc/llvm-project?rev=332582&view=rev
Log:
[clang-format] Fix putting ObjC message arguments in one line for multiline
receiver
Summary:
Currently BreakBeforeParameter is set to true everytime message rec
This revision was automatically updated to reflect the committed changes.
Closed by commit rC332582: [clang-format] Fix putting ObjC message arguments in
one line for multiline… (authored by jolesiak, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46879?vs=146818&id=147265#t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL332582: [clang-format] Fix putting ObjC message arguments in
one line for multiline… (authored by jolesiak, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.
martong added a comment.
Hi Aleksei,
I am OK with this, I just have a little concern about friend declarations.
Since https://reviews.llvm.org/D32947 ( [ASTImporter] FriendDecl importing
improvements ) records' structural equivalency depends on the order of their
friend declarations.
Anyway, I
ilya-biryukov added a comment.
Sorry, a few more things and we're good to go.
Comment at: include/clang/Driver/CC1Options.td:449
+def code_completion_include_fixits : Flag<["-"],
"code-completion-include-fixits">,
+ HelpText<"Include code completion results which require havi
r.stahl updated this revision to Diff 147268.
r.stahl marked 2 inline comments as done.
r.stahl added a comment.
addressed review comments
https://reviews.llvm.org/D46940
Files:
include/clang/AST/ASTContext.h
lib/AST/ASTImporter.cpp
unittests/AST/ASTImporterTest.cpp
Index: unittests/AST/
martong updated this revision to Diff 147274.
martong added a comment.
Addressing review comments.
Repository:
rC Clang
https://reviews.llvm.org/D46835
Files:
lib/AST/DeclBase.cpp
unittests/AST/ASTImporterTest.cpp
Index: unittests/AST/ASTImporterTest.cpp
Author: yvvan
Date: Thu May 17 02:15:22 2018
New Revision: 332585
URL: http://llvm.org/viewvc/llvm-project?rev=332585&view=rev
Log:
Revert https://reviews.llvm.org/D46050 and https://reviews.llvm.org/D45815
Windows line endings.
Requires proper resubmission.
Removed:
cfe/trunk/test/Index/com
Author: yvvan
Date: Thu May 17 02:21:07 2018
New Revision: 332586
URL: http://llvm.org/viewvc/llvm-project?rev=332586&view=rev
Log:
[Frontend] Avoid running plugins during code completion parse
Second attempt. Proper line endings.
The parsing that is done for code completion is a special case th
martong added a comment.
In https://reviews.llvm.org/D46958#1101570, @a.sidorin wrote:
> So, we fail to add injected name to a CXXRecordDecl that has a described
> class template?
Yes, we failed to import the implicit `CXXRecordDecl`.
Here is how it looked before the fix:
From:
ClassTempl
Author: yvvan
Date: Thu May 17 02:24:37 2018
New Revision: 332587
URL: http://llvm.org/viewvc/llvm-project?rev=332587&view=rev
Log:
[libclang] Allow skipping function bodies in preamble only
Second attempt. Fix line endings and warning.
As an addition to CXTranslationUnit_SkipFunctionBodies, pro
Terribly sorry for the breakage and many thanks for fixing this!
On Thu, May 17, 2018 at 9:04 AM Clement Courbet wrote:
> I should have fixed it in r332576.
>
> On Wed, May 16, 2018 at 11:49 PM, Galina Kistanova via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Also few other builders
devnexen created this revision.
devnexen added reviewers: NoQ, george.karpenkov.
devnexen created this object with visibility "All Users".
Herald added a subscriber: cfe-commits.
Again strlc* does not return a pointer so the zero size case does not fit.
Repository:
rC Clang
https://reviews.ll
ioeric added inline comments.
Comment at: clang-doc/Representation.h:238
+ // Non-const accessors for YAML output.
+ std::vector &getNamespaceInfos() { return NamespaceInfos; }
There are two alternatives to avoid this:
1) Pull the info storage into a separate
Szelethus added a comment.
Thanks for the review!
If you like the new overload, can you please commit this for me?
https://reviews.llvm.org/D46891
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
Looks good. Please watch the windows buildbots carefully after landing this.
Comment at: lib/Basic/FileManager.cpp:537
-#ifdef LLVM_ON_UNIX
- char CanonicalNameBuf[PATH_
This revision was automatically updated to reflect the committed changes.
Closed by commit rL332588: [ASTImporter] Fix missing implict CXXRecordDecl
(authored by martong, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D46958
Files:
cfe/
ilya-biryukov added a comment.
A few questions regarding class members. To pinpoint some interesting cases and
agree on how we want those to behave in the long run.
How do we handle template specializations? What will the qualified names of
those instantiations be?
I.e. how do I query for `push
ioeric updated this revision to Diff 147278.
ioeric marked an inline comment as done.
ioeric added a comment.
- s/PATH_MAX/4096/
Repository:
rC Clang
https://reviews.llvm.org/D46942
Files:
include/clang/Basic/VirtualFileSystem.h
lib/Basic/FileManager.cpp
lib/Basic/VirtualFileSystem.cpp
ioeric added inline comments.
Comment at: lib/Basic/FileManager.cpp:537
-#ifdef LLVM_ON_UNIX
- char CanonicalNameBuf[PATH_MAX];
- if (realpath(Dir->getName().str().c_str(), CanonicalNameBuf))
+ SmallString CanonicalNameBuf;
+ if (!FS->getRealPath(Dir->getName(), CanonicalNa
ioeric added inline comments.
Comment at: clang-doc/generators/Generators.h:44
+class MDGenerator : public Generator {
+public:
Could you add high-level comment on what this does? This seems to build up some
directory structure and write different infos into d
asb added a comment.
I wonder if it would be safer to change this patch so it adds -mrelax and
-mno-relax but doesn't compile with linker relaxation by default. That makes it
easier to test linker relaxation support, and gives more time for testing
before then flipping to -mrelax as the default
This revision was automatically updated to reflect the committed changes.
Closed by commit rL332590: Add vfs::FileSystem::getRealPath (authored by
ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D46942
Files:
cfe/trunk/include/cl
Author: ioeric
Date: Thu May 17 03:26:23 2018
New Revision: 332590
URL: http://llvm.org/viewvc/llvm-project?rev=332590&view=rev
Log:
Add vfs::FileSystem::getRealPath
Summary: And change `FileManager::getCanonicalName` to use getRealPath.
Reviewers: bkramer
Reviewed By: bkramer
Subscribers: cfe
aheejin updated this revision to Diff 147287.
aheejin marked an inline comment as done.
aheejin added a comment.
`CatchStartBlock` -> `WasmCatchStartBlock`
Repository:
rC Clang
https://reviews.llvm.org/D44931
Files:
lib/CodeGen/CGCXXABI.h
lib/CodeGen/CGCleanup.cpp
lib/CodeGen/CGCleanup
aheejin added a comment.
Thank you for the reviews!
Comment at: lib/CodeGen/CGException.cpp:1173
+cast(CatchStartBlock->getFirstNonPHI());
+CurrentFuncletPad = CPI;
+ }
majnemer wrote:
> Hmm, why is this done? Won't RestoreCurrentFuncletPad undo th
ilya-biryukov added inline comments.
Comment at: clangd/Quality.cpp:24
+ if (SemaCCResult.Declaration)
+AllDeclsInMainFile = allDeclsInMainFile(SemaCCResult.Declaration);
if (SemaCCResult.Availability == CXAvailability_Deprecated)
sammccall wrote:
> ioeri
Author: yaxunl
Date: Thu May 17 04:16:35 2018
New Revision: 332593
URL: http://llvm.org/viewvc/llvm-project?rev=332593&view=rev
Log:
CodeGen: Fix invalid bitcast for lifetime.start/end
lifetime.start/end expects pointer argument in alloca address space.
However in C++ a temporary variable is in d
This revision was automatically updated to reflect the committed changes.
Closed by commit rL332593: CodeGen: Fix invalid bitcast for lifetime.start/end
(authored by yaxunl, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D45900?vs=1469
alexfh added a comment.
This patch seems to cause an assertion failure:
assert.h assertion failed at clang/lib/StaticAnalyzer/Core/SValBuilder.cpp:427
in clang::ento::SVal
clang::ento::SValBuilder::evalBinOp(clang::ento::ProgramStateRef,
BinaryOperator::Opcode, clang::ento::SVal, clang::ento::
alexfh added a comment.
This is reproducible in r332425.
Repository:
rC Clang
https://reviews.llvm.org/D45177
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aheejin added inline comments.
Comment at: lib/CodeGen/CGException.cpp:1241-1245
+while (llvm::TerminatorInst *TI = RethrowBlock->getTerminator()) {
+ llvm::BranchInst *BI = cast(TI);
+ assert(BI->isConditional());
+ RethrowBlock = BI->getSuccessor(1);
+}
-
mike.dvoretsky updated this revision to Diff 147292.
mike.dvoretsky added a comment.
Removed the unused HasIBT variable declaration from X86.h.
https://reviews.llvm.org/D46881
Files:
clang/docs/ClangCommandLineReference.rst
clang/include/clang/Basic/DiagnosticCommonKinds.td
clang/include/
Typz updated this revision to Diff 147293.
Typz marked an inline comment as done.
Typz added a comment.
Address review comments
Repository:
rC Clang
https://reviews.llvm.org/D33440
Files:
include/clang/Format/Format.h
lib/Format/Format.cpp
lib/Format/FormatToken.h
lib/Format/FormatTo
Typz marked an inline comment as done.
Typz added inline comments.
Comment at: lib/Format/Format.cpp:647-648
LLVMStyle.SortUsingDeclarations = true;
+ LLVMStyle.StatementMacros.push_back("Q_UNUSED");
+ LLVMStyle.StatementMacros.push_back("QT_REQUIRE_VERSION");
Author: jkorous
Date: Thu May 17 04:51:49 2018
New Revision: 332598
URL: http://llvm.org/viewvc/llvm-project?rev=332598&view=rev
Log:
Use dotted format of version tuple for availability diagnostics
E. g. use "10.11" instead of "10_11".
We are maintaining backward compatibility by parsing undersc
This revision was automatically updated to reflect the committed changes.
Closed by commit rL332598: Use dotted format of version tuple for availability
diagnostics (authored by jkorous, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D
devnexen added a comment.
In https://reviews.llvm.org/D45177#1102887, @alexfh wrote:
> This is reproducible in r332425.
I posted this PR https://reviews.llvm.org/D47007 hopes it helps.
Repository:
rC Clang
https://reviews.llvm.org/D45177
___
c
Author: martong
Date: Thu May 17 02:46:07 2018
New Revision: 332588
URL: http://llvm.org/viewvc/llvm-project?rev=332588&view=rev
Log:
[ASTImporter] Fix missing implict CXXRecordDecl
Summary:
Implicit CXXRecordDecl is not added to its DeclContext during import, but in
the original AST it is. This
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D46835
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
Author: ioeric
Date: Thu May 17 05:40:50 2018
New Revision: 332603
URL: http://llvm.org/viewvc/llvm-project?rev=332603&view=rev
Log:
Attempt to fix clang-move tests broken by r332590 on windows
http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/12007
Modified:
clang-tools-ex
ilya-biryukov updated this revision to Diff 147301.
ilya-biryukov added a comment.
- Move tests to QualityTests.cpp
- Fix findDecl() assertion on redecls of the same thing
- Fix file comment of TestTU.cpp
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46943
Files:
clangd/AST.
ilya-biryukov added inline comments.
Comment at: clangd/AST.h:32
+/// Returns true iff all redecls of \p D are in the main file.
+bool allDeclsInMainFile(const Decl *D);
sammccall wrote:
> Do you expect this to be reused?
> If so, unit test? Otherwise this seem
martong marked 14 inline comments as done.
martong added a comment.
> Do you plan to enable this functionality for AST import checking?
Yes. We'd like to test the structural equivalency independently from
ASTImporter, because in certain cases it may have faulty behavior. This can be
very handy
Author: psmith
Date: Thu May 17 06:17:33 2018
New Revision: 332606
URL: http://llvm.org/viewvc/llvm-project?rev=332606&view=rev
Log:
[AArch64] Correct inline assembly test case for S modifier [NFC]
The existing test for the AArch64 inline assembly constraint S uses the
A and L modifiers. These mo
martong updated this revision to Diff 147304.
martong marked an inline comment as done.
martong added a comment.
- Address aleksei's comments
Repository:
rC Clang
https://reviews.llvm.org/D46867
Files:
unittests/AST/ASTImporterTest.cpp
unittests/AST/CMakeLists.txt
unittests/AST/Languag
This revision was automatically updated to reflect the committed changes.
Closed by commit rC332606: [AArch64] Correct inline assembly test case for S
modifier [NFC] (authored by psmith, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D46932
Files:
test/CodeGen/aarch64-inline-
ioeric added a comment.
In https://reviews.llvm.org/D44954#1101922, @malaperle wrote:
> @ioeric You mentioned in https://reviews.llvm.org/D46751 that it would make
> sense to add a flag to disable indexing members. Could you comment on that?
> What kind of granularity were you thinking? Would a
This revision was automatically updated to reflect the committed changes.
Closed by commit rL332609: [clang-tidy] Add a flag to enable alpha checkers
(authored by alexfh, committed by ).
Herald added subscribers: llvm-commits, klimek.
Changed prior to commit:
https://reviews.llvm.org/D46159?vs=
Author: alexfh
Date: Thu May 17 07:04:27 2018
New Revision: 332609
URL: http://llvm.org/viewvc/llvm-project?rev=332609&view=rev
Log:
[clang-tidy] Add a flag to enable alpha checkers
Summary: The alpha checkers can already be enabled using the clang driver, this
allows them to be enabled using th
ioeric added inline comments.
Comment at: clangd/Quality.cpp:24
+ if (SemaCCResult.Declaration)
+AllDeclsInMainFile = allDeclsInMainFile(SemaCCResult.Declaration);
if (SemaCCResult.Availability == CXAvailability_Deprecated)
ilya-biryukov wrote:
> sammccal
ioeric added inline comments.
Comment at: clangd/Quality.cpp:24
+ if (SemaCCResult.Declaration)
+AllDeclsInMainFile = allDeclsInMainFile(SemaCCResult.Declaration);
if (SemaCCResult.Availability == CXAvailability_Deprecated)
ioeric wrote:
> ilya-biryukov w
labath updated this revision to Diff 147315.
labath added a comment.
Updating with a new version of the patch. The problem with the previous version
was that it caused us to use C5/https://reviews.llvm.org/D5 comdats very
aggressively (at -O0), and this
is not always correct. This uses a more nua
ilya-biryukov added inline comments.
Comment at: clangd/Quality.cpp:24
+ if (SemaCCResult.Declaration)
+AllDeclsInMainFile = allDeclsInMainFile(SemaCCResult.Declaration);
if (SemaCCResult.Availability == CXAvailability_Deprecated)
ioeric wrote:
> ioeric w
mclow.lists updated this revision to Diff 147317.
mclow.lists added a comment.
Added tests (and fix!) for the implicit deduction guides.
https://reviews.llvm.org/D46975
Files:
include/deque
test/std/containers/sequences/deque/deque.cons/deduct.pass.cpp
Index: test/std/containers/sequences/
leonardchan created this revision.
leonardchan added reviewers: phosek, mcgrathr, jakehehrlich.
leonardchan added a project: clang.
This patch includes changes for division on saturated fixed point types.
Overflow occurs when the resulting value cannot fit into the number of data
bits for the re
Author: ioeric
Date: Thu May 17 07:59:15 2018
New Revision: 332612
URL: http://llvm.org/viewvc/llvm-project?rev=332612&view=rev
Log:
Second attempt to fix clang-move tests broken by r332590 on windows
http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/12010
Add back a path conve
ioeric added inline comments.
Comment at: clangd/index/SymbolCollector.cpp:113
- // We only want:
- // * symbols in namespaces or translation unit scopes (e.g. no class
- // members)
- // * enum constants in unscoped enum decl (e.g. "red" in "enum {red};")
- auto I
leonardchan created this revision.
leonardchan added reviewers: phosek, mcgrathr, jakehehrlich.
leonardchan added a project: clang.
This patch includes changes for the shift left operator involving saturated
fixed point types.
For unsigned shifting, overflow occurs if the number of bits we shift
Author: nico
Date: Thu May 17 08:26:37 2018
New Revision: 332614
URL: http://llvm.org/viewvc/llvm-project?rev=332614&view=rev
Log:
Fix __uuidof handling on non-type template parameter in C++17
Clang used to pass the base lvalue of a non-type template parameter
to the template instantiation phase
thakis closed this revision.
thakis added a comment.
r332614, thanks!
Repository:
rC Clang
https://reviews.llvm.org/D46820
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh added a comment.
See https://bugs.llvm.org/show_bug.cgi?id=37503 for a test case.
Repository:
rC Clang
https://reviews.llvm.org/D45177
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
jlebar added a comment.
Thank you for the review!
https://reviews.llvm.org/D46993
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: jlebar
Date: Thu May 17 09:12:42 2018
New Revision: 332619
URL: http://llvm.org/viewvc/llvm-project?rev=332619&view=rev
Log:
[CUDA] Make std::min/max work when compiling in C++14 mode with a C++11 stdlib.
Reviewers: rsmith
Subscribers: sanjoy, cfe-commits, tra
Differential Revision: htt
This revision was automatically updated to reflect the committed changes.
Closed by commit rC332619: [CUDA] Make std::min/max work when compiling in
C++14 mode with a C++11 stdlib. (authored by jlebar, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46993?vs=147224&id=147330#
Author: ioeric
Date: Thu May 17 09:13:36 2018
New Revision: 332620
URL: http://llvm.org/viewvc/llvm-project?rev=332620&view=rev
Log:
Disable a failing clang-move test on windows.
This was broken by r332590 but is likely caused by a bug in clang-move.
http://lab.llvm.org:8011/builders/clang-x86-w
This revision was automatically updated to reflect the committed changes.
Closed by commit rC332621: [CUDA] Allow "extern __shared__ Foo foo[]"
within anon. namespaces. (authored by jlebar, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://reviews.llvm.org
Author: jlebar
Date: Thu May 17 09:15:07 2018
New Revision: 332621
URL: http://llvm.org/viewvc/llvm-project?rev=332621&view=rev
Log:
[CUDA] Allow "extern __shared__ Foo foo[]" within anon. namespaces.
Summary:
Previously this triggered a -Wundefined-internal warning. But it's not
an undefined va
craig.topper added a comment.
LGTM
https://reviews.llvm.org/D46881
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aschwaighofer accepted this revision.
aschwaighofer added a comment.
This revision is now accepted and ready to land.
Looks good.
Repository:
rC Clang
https://reviews.llvm.org/D46550
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
dexonsmith added inline comments.
Comment at: test/Preprocessor/headermap-rel.c:2-3
// This uses a headermap with this entry:
// Foo.h -> Foo/Foo.h
Should we delete this comment now that the header map is human-readable?
Comment at: tes
tra accepted this revision.
tra added inline comments.
This revision is now accepted and ready to land.
Comment at: External/CUDA/CMakeLists.txt:339-345
# Same as above, but for libc++
# Tell clang to use libc++
# We also need to add compiler's include pat
tra accepted this revision.
tra added inline comments.
This revision is now accepted and ready to land.
Comment at: External/CUDA/complex.cu:24
// libstdc++ (compile errors in ).
-#if __cplusplus >= 201103L && !defined(_LIBCPP_VERSION) && \
-(__cplusplus < 201402L || STDLIB_
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Shall I go ahead and commit this for you?
Comment at: lib/AST/VTableBuilder.cpp:2507
const MethodInfo &MI = I.second;
+ assert(MD == MD->getCanonicalDecl());
+
--
thakis added a comment.
Please do, tzik doesn't have commit access yet.
Repository:
rC Clang
https://reviews.llvm.org/D46929
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: waltl
Date: Thu May 17 11:04:39 2018
New Revision: 332635
URL: http://llvm.org/viewvc/llvm-project?rev=332635&view=rev
Log:
[sanitizer] Don't add --export-dynamic for Myriad
This is to work around a bug in some versions of gnu ld, where
--export-dynamic implies -shared even if -static is
This revision was automatically updated to reflect the committed changes.
Closed by commit rC332635: [sanitizer] Don't add --export-dynamic for
Myriad (authored by waltl, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46452?vs=147233&id=147355#toc
Repository:
rC Clang
ht
Author: rnk
Date: Thu May 17 11:12:18 2018
New Revision: 332639
URL: http://llvm.org/viewvc/llvm-project?rev=332639&view=rev
Log:
Fix a mangling failure on clang-cl C++17
MethodVFTableLocations in MigrosoftVTableContext contains canonicalized
decl. But, it's sometimes asked to lookup for non-cano
This revision was automatically updated to reflect the committed changes.
Closed by commit rC332639: Fix a mangling failure on clang-cl C++17 (authored
by rnk, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46929?vs=147244&id=147359#toc
Repository:
rC Clang
https://revie
vsk updated this revision to Diff 147360.
vsk added a comment.
- Add a regression test for switches.
https://reviews.llvm.org/D46918
Files:
lib/CodeGen/CoverageMappingGen.cpp
test/CoverageMapping/deferred-region.cpp
test/CoverageMapping/label.cpp
test/CoverageMapping/moremacros.c
test
dblaikie added a comment.
"In the future we can revisit this when we have a better idea as to why not
depending on the C++ ABI functionality is a better solution." - this was
discussed previously in the thread linked from the bug.
A big thing, so far as I understand it, is that Clang doesn't r
You might've forgotten to svn add the test :-)
On Thu, May 17, 2018, 2:16 PM Reid Kleckner via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rnk
> Date: Thu May 17 11:12:18 2018
> New Revision: 332639
>
> URL: http://llvm.org/viewvc/llvm-project?rev=332639&view=rev
> Log:
> Fix a man
Author: rnk
Date: Thu May 17 11:34:05 2018
New Revision: 332646
URL: http://llvm.org/viewvc/llvm-project?rev=332646&view=rev
Log:
Add missing test case for r332639
Added:
cfe/trunk/test/CodeGenCXX/PR37481.cpp
Added: cfe/trunk/test/CodeGenCXX/PR37481.cpp
URL:
http://llvm.org/viewvc/llvm-proj
yaxunl added a comment.
ping
https://reviews.llvm.org/D46476
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl added a comment.
ping
https://reviews.llvm.org/D46472
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl added a comment.
ping
https://reviews.llvm.org/D45212
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kimgr added a comment.
>> Can you test what happens when you do clang-cl.exe /Yc stdafx.h /Tp
>> stdafx.h, i.e. compile the header
> > directly as C++ code and generate .pch from it? The normal MSVC modus
> operandi is to have stdafx.h
> > included in all source files (with /Yu) and stdafx.c
benhamilton created this revision.
benhamilton added reviewers: djasper, jolesiak.
Herald added subscribers: cfe-commits, klimek.
Previously, clang-format's parser would fail to annotate the
selector in a single-component Objective-C method invocation with
`TT_SelectorName`. For example, the follo
craig.topper created this revision.
craig.topper added reviewers: echristo, RKSimon, spatel.
These look to be a couple things that weren't remvoed when we switched to
target attribute.
The popcnt makes including just smmintrin.h also include popcntintrin.h. The
popcnt file itself already contai
george.karpenkov added a comment.
Is it a fix for https://bugs.llvm.org/show_bug.cgi?id=37503 ?
Repository:
rC Clang
https://reviews.llvm.org/D47007
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
leonardchan created this revision.
leonardchan added reviewers: phosek, mcgrathr, jakehehrlich.
leonardchan added a project: clang.
Herald added a subscriber: mgorny.
This patch includes checks that the precision macros used for the fixed point
fractional and integral bits meet the requirements f
t-tye accepted this revision.
t-tye added a comment.
This revision is now accepted and ready to land.
LGTM except for minor suggestions.
Comment at: lib/CodeGen/CGCUDANV.cpp:361-373
+ if (IsHIP)
+FatbinConstantName = ".hip_fatbin";
+ else if (RelocatableDeviceCode)
/
devnexen added a comment.
In https://reviews.llvm.org/D47007#1103551, @george.karpenkov wrote:
> Is it a fix for https://bugs.llvm.org/show_bug.cgi?id=37503 ?
Nope. more for last NoQ comment. Will try for this one once I finish setting it
up.
Repository:
rC Clang
https://reviews.llvm.org/
jlebar marked an inline comment as done.
jlebar added inline comments.
Comment at: External/CUDA/complex.cu:24
// libstdc++ (compile errors in ).
-#if __cplusplus >= 201103L && !defined(_LIBCPP_VERSION) && \
-(__cplusplus < 201402L || STDLIB_VERSION >= 2014)
+#if __cplusplus
1 - 100 of 126 matches
Mail list logo
