[PATCH] D17741: adds __FILE_BASENAME__ builtin macro

dexonsmith added a reviewer: vsapsai. dexonsmith added a comment. In https://reviews.llvm.org/D17741#1067816, @weimingz wrote: > split the original into two parts. This one supports > -ffile-macro-prefix-to-remove function. > > I locally verified it. To add a test case, do we need to use VFS?

[PATCH] D46902: [analyzer] Make plist-html multi-file.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet, rnkovacs. Herald added subscribers: cfe-commits, baloghadamsoftware. Plist diagnostics support multi-file reports since forever. HTML diagnostics support multi-file reports since https://r

[PATCH] D46902: [analyzer] Make plist-html multi-file.

NoQ added inline comments. Comment at: test/Analysis/diagnostics/plist-multi-file.c:202 +// CHECK-NEXT: +// CHECK-NEXT: report-{{([0-9a-f]{6})}}.html +// CHECK-NEXT: Yay we have regular expressions. `()` are needed so that not to confuse `}``}}` with `}}``}

[PATCH] D46903: [Attr] Don't print attr arg with default value

jdenny created this revision. jdenny added reviewers: aaron.ballman, rsmith, hfinkel. For example, given: class __single_inheritance T; -ast-print -fms-extensions used to print: class __single_inheritance(1) T; Clang fails to parse that because the "(1)" is not valid syntax. This was disc

[PATCH] D46485: Add python tool to dump and construct header maps

bruno added a comment. @jkorous, thanks for taking a look. This is an old python script which I haven't touched before, maybe there were answers to your questions but they are now lost in time. I'll address the review though and upload a new version. Repository: rC Clang https://reviews.llv

[PATCH] D46822: [RISCV] Add driver for riscv32-unknown-elf baremetal target

asb added a comment. In https://reviews.llvm.org/D46822#1098764, @efriedma wrote: > Could you include some documentation for how to construct a baremetal > environment like the one this code expects? It's not clear what exactly you > expect to be installed where. Thanks for taking a look Eli

r332397 - Address post-commit review comments after r328731. NFC.

Author: ahatanak Date: Tue May 15 14:00:30 2018 New Revision: 332397 URL: http://llvm.org/viewvc/llvm-project?rev=332397&view=rev Log: Address post-commit review comments after r328731. NFC. - Define a function (canPassInRegisters) that determines whether a record can be passed in registers based

[PATCH] D46903: [Attr] Don't print attr arg with default value

jdenny added a comment. I occurs to me now that I could have fixed __single_inheritance by declaring its argument "fake". However, I still prefer the above solution because (1) it should help with any other attributes where arguments should have been declared fake (but no, I haven't identified

[PATCH] D46822: [RISCV] Add driver for riscv32-unknown-elf baremetal target

efriedma added a comment. Just a brief comment in the code explaining that would be fine. Repository: rC Clang https://reviews.llvm.org/D46822 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

r332400 - Move helper classes into anonymous namespaces. NFCI.

Author: d0k Date: Tue May 15 14:26:47 2018 New Revision: 332400 URL: http://llvm.org/viewvc/llvm-project?rev=332400&view=rev Log: Move helper classes into anonymous namespaces. NFCI. Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp cfe/trunk/lib/Serialization/ASTReaderDecl.cpp Modifie

r332401 - Don't produce a redundant "auto type is incompatible with C++98" on every lambda with no explicit return type.

Author: rsmith Date: Tue May 15 14:27:30 2018 New Revision: 332401 URL: http://llvm.org/viewvc/llvm-project?rev=332401&view=rev Log: Don't produce a redundant "auto type is incompatible with C++98" on every lambda with no explicit return type. We already warned about the lambda, and we don't hav

r332405 - [Documentation] Fix Release Notes format issues.

Author: eugenezelenko Date: Tue May 15 14:45:01 2018 New Revision: 332405 URL: http://llvm.org/viewvc/llvm-project?rev=332405&view=rev Log: [Documentation] Fix Release Notes format issues. Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/trunk/docs/ReleaseNotes.rst URL: http://llvm.o

[PATCH] D46905: [Attr] Don't print fake MSInheritance argument

jdenny created this revision. jdenny added reviewers: aaron.ballman, rsmith, hfinkel. This was discovered at: http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20180514/228390.html https://reviews.llvm.org/D46905 Files: include/clang/Basic/Attr.td test/SemaCXX/attr-print.cpp Index:

[PATCH] D46903: [Attr] Don't print attr arg with default value

jdenny abandoned this revision. jdenny added a comment. After further thought, this patch doesn't seem worthwhile. Sorry for all the noise. https://reviews.llvm.org/D46903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

[PATCH] D46452: [sanitizer] Don't add --export-dynamic for Myriad

alekseyshl added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:706 // to be dynamic to be sure we export sanitizer interface functions. - if (AddExportDynamic) + if (AddExportDynamic && TC.getTriple().getVendor() != llvm::Triple::Myriad) CmdArg

[PATCH] D44934: [analyzer] Improve the modeling of `memset()`.

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks! This looks great now. Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:1055 +std::tie(StateNullChar, StateNonNullChar) = +assumeZero(C, State, CharVal

[PATCH] D46906: [clangd] Fix a link failure in unittests

aheejin created this revision. aheejin added a reviewer: sammccall. Herald added subscribers: cfe-commits, jkorous, MaskRay, ioeric, ilya-biryukov, mgorny, klimek. aheejin edited the summary of this revision. https://reviews.llvm.org/D46524 (https://reviews.llvm.org/rL332378) introduced a link f

r332411 - [Attr] Don't print implicit attributes

Author: jdenny Date: Tue May 15 15:16:47 2018 New Revision: 332411 URL: http://llvm.org/viewvc/llvm-project?rev=332411&view=rev Log: [Attr] Don't print implicit attributes Fixes bug reported at: http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20180514/228390.html Reviewed by: aaron.ball

[PATCH] D46894: [Attr] Don't print implicit attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rC332411: [Attr] Don't print implicit attributes (authored by jdenny, committed by ). Repository: rC Clang https://reviews.llvm.org/D46894 Files: lib/AST/DeclPrinter.cpp test/Misc/ast-print-record-d

[PATCH] D46909: [Sema] Fix assertion when constructor is disabled with partially specialized template.

vsapsai created this revision. vsapsai added reviewers: rsmith, arphaman. The added test case was triggering assertion > Assertion failed: > (!SpecializedTemplate.is() && "Already set > to a class template partial specialization!"), function setInstantiationOf, > file clang/include/clang/AST/D

[PATCH] D46909: [Sema] Fix assertion when constructor is disabled with partially specialized template.

vsapsai added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:3873-3881 // Find the variable template specialization declaration that // corresponds to these arguments. void *InsertPos = nullptr; if (VarTemplateSpecializationDecl *Spec = Template->findSpe

[PATCH] D46909: [Sema] Fix assertion when constructor is disabled with partially specialized template.

vsapsai updated this revision to Diff 146944. vsapsai added a comment. Potentially, VarTemplateDecl is susceptible to the same bug as ClassTemplateSpecializationDecl. But I wasn't able to trigger it. And based on code I've convinced myself that the mentioned early exit in Sema::CheckVarTemplateId

[PATCH] D45470: Emit an error when include after

This revision was automatically updated to reflect the committed changes. Closed by commit rL332413: Emit an error when include after (authored by vsapsai, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D45470?vs

[libcxx] r332413 - Emit an error when include after

Author: vsapsai Date: Tue May 15 15:38:31 2018 New Revision: 332413 URL: http://llvm.org/viewvc/llvm-project?rev=332413&view=rev Log: Emit an error when include after C11 defines `kill_dependency` as a macro in . When you include after , the macro clashes with `std::kill_dependency` and causes

[PATCH] D45470: Emit an error when include after

vsapsai added a comment. Thanks for review. Repository: rL LLVM https://reviews.llvm.org/D45470 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] r332414 - [libunwind][MIPS] Support MIPS floating-point registers for hard-float ABIs.

Author: jhb Date: Tue May 15 15:44:56 2018 New Revision: 332414 URL: http://llvm.org/viewvc/llvm-project?rev=332414&view=rev Log: [libunwind][MIPS] Support MIPS floating-point registers for hard-float ABIs. Summary: For MIPS ABIs with 64-bit floating point registers including newabi and O32 with

[PATCH] D41968: [libunwind][MIPS] Support MIPS floating-point registers for hard-float ABIs.

This revision was automatically updated to reflect the committed changes. Closed by commit rL332414: [libunwind][MIPS] Support MIPS floating-point registers for hard-float ABIs. (authored by jhb, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.

[PATCH] D46909: [Sema] Fix assertion when constructor is disabled with partially specialized template.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks good. It might be beneficial to do the lookup twice in this case and then issue a diagnostic if the results differ, but given how rarely this is happening, it doesn't really seem worthwh

[PATCH] D46911: Addition of the remaining fixed point types and their saturated equivalents

leonardchan created this revision. leonardchan added a project: clang. This diff includes changes for the remaining _Fract and _Sat fixed point types. signed short _Fract s_short_fract; signed _Fract s_fract; signed long _Fract s_long_fract; unsigned short _Fract u_short_fract; unsigned

[PATCH] D46914: Run scan-view on systems with python3 as default python provider

raj.khem created this revision. Herald added a subscriber: cfe-commits. Linux Distros e.g. archlinux have started to use python3 as default python interpreter, therefore we need to be specific if we need python2 Repository: rC Clang https://reviews.llvm.org/D46914 Files: tools/scan-view/b

[PATCH] D46915: Set Fixed Point Precision Bits and Create Fixed Point Literals

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr, jakehehrlich. leonardchan added a project: clang. Herald added a subscriber: mgorny. This diff includes the logic for setting the precision bits for each primary fixed point type when building clang and logic for in

[PATCH] D46917: Comparison and Unary Operations for Fixed Point Types

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr. leonardchan added a project: clang. This patch contains logic and tests for different unary and comparison operations on fixed point types, and casting between integers and fixed point types. The operations are `=

[PATCH] D46918: [Coverage] Discard the last uncompleted deferred region in a decl

vsk created this revision. vsk added a reviewer: arphaman. Discard the last uncompleted deferred region in a decl, if one exists. This prevents lines at the end of a function containing only whitespace or closing braces from being marked as uncovered, if they follow a region terminator (return/bre

[PATCH] D46902: [analyzer] Make plist-html multi-file.

george.karpenkov accepted this revision. george.karpenkov added a comment. This revision is now accepted and ready to land. LGTM! with stable-filename option we could even avoid the regexp. Repository: rC Clang https://reviews.llvm.org/D46902 ___

r332417 - [analyzer] Make plist-html diagnostic consumer produce multi-file reports.

Author: dergachev Date: Tue May 15 17:11:24 2018 New Revision: 332417 URL: http://llvm.org/viewvc/llvm-project?rev=332417&view=rev Log: [analyzer] Make plist-html diagnostic consumer produce multi-file reports. Previously plist-html output produced multi-file HTML reports but only single-file Pli

[PATCH] D46902: [analyzer] Make plist-html multi-file.

This revision was automatically updated to reflect the committed changes. Closed by commit rL332417: [analyzer] Make plist-html diagnostic consumer produce multi-file reports. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://revie

[PATCH] D46919: [libclang] Deprecate CXPrintingPolicy_IncludeTagDefinition

jdenny created this revision. jdenny added a reviewer: rsmith. And make it have no effect. Suggested at: https://reviews.llvm.org/D45463#1096629 I'm not sure of the proper way to deprecate something in libclang. Let me know if something else is needed. https://reviews.llvm.org/D46919 Files:

r332421 - Revert commits r332160, r332164, r332236.

Author: dyung Date: Tue May 15 17:27:43 2018 New Revision: 332421 URL: http://llvm.org/viewvc/llvm-project?rev=332421&view=rev Log: Revert commits r332160, r332164, r332236. It was decided this is the wrong approach to fix this issue. Removed: cfe/trunk/test/Driver/clang-abi-compat.cpp Modif

[PATCH] D46603: [Support] TimerGroup changes

george.karpenkov added a comment. I see four separate changes: s/.sys/mem one (can be committed without review), exposing printJSONValues and consequent adding of a lock, adding a constructor accepting a map, and fixing formatting in `printJSONValue`. All four look good to me, but probably shou

r332422 - [analyzer] Do not crash on callback for call_once passed by value

Author: george.karpenkov Date: Tue May 15 17:29:13 2018 New Revision: 332422 URL: http://llvm.org/viewvc/llvm-project?rev=332422&view=rev Log: [analyzer] Do not crash on callback for call_once passed by value https://bugs.llvm.org/show_bug.cgi?id=37312 rdar://40270582 Differential Revision: http

[PATCH] D46891: [StaticAnalyzer] Added a getLValue method to ProgramState for bases

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks good, thanks! Yeah, seems that these were accidentally omitted. You may want to add the `const CXXRecordDecl *` variant as well. Repository: rC Clang https://reviews.llvm.org/D46891 ___

[PATCH] D46891: [StaticAnalyzer] Added a getLValue method to ProgramState for bases

NoQ added inline comments. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h:732 + const SubRegion *Super) const { + const auto Base = BaseSpec.getType()->getAsCXXRecordDecl(); + return loc::MemRegionVal( --

[PATCH] D46791: Make -gsplit-dwarf generally available

trixirt updated this revision to Diff 146970. trixirt added a comment. Improve comment in CLANG_DEFAULT_OBJCOPY to specify what is required of objcopy. Remove the llvm- prefix from testing to allow for override of default value. https://reviews.llvm.org/D46791 Files: CMakeLists.txt lib/Driv

Re: r332286 - PR37450: Fix bug that disabled some type checks for variables with deduced types.

Sorry for the delay, looking now. On 15 May 2018 at 02:24, Maxim Kuvyrkov wrote: > Hi Richard, > > The for-range-examples.cpp test fails on 32-bit arm buildbots, e.g.: > http://lab.llvm.org:8011/builders/clang-cmake-armv7-full/builds/840 . > Would you please investigate? > > You didn't get a not

r332425 - Fix 32-bit buildbots.

Author: rsmith Date: Tue May 15 18:08:07 2018 New Revision: 332425 URL: http://llvm.org/viewvc/llvm-project?rev=332425&view=rev Log: Fix 32-bit buildbots. Modified: cfe/trunk/test/SemaCXX/for-range-examples.cpp Modified: cfe/trunk/test/SemaCXX/for-range-examples.cpp URL: http://llvm.org/vie

Re: r332286 - PR37450: Fix bug that disabled some type checks for variables with deduced types.

Should be fixed in r332425. Apologies for the delay addressing this. On 15 May 2018 at 18:10, Richard Smith wrote: > Sorry for the delay, looking now. > > On 15 May 2018 at 02:24, Maxim Kuvyrkov wrote: > >> Hi Richard, >> >> The for-range-examples.cpp test fails on 32-bit arm buildbots, e.g.: >

[PATCH] D40864: [Darwin] Add a new -mstack-probe option and enable by default

dexonsmith added a comment. Did this eventually go in? Repository: rC Clang https://reviews.llvm.org/D40864 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46919: [libclang] Deprecate CXPrintingPolicy_IncludeTagDefinition

rsmith added a comment. The deprecated enumerator is also referenced by `tools/c-index-test/c-index-test.c` This looks fine to me, but let's leave this review thread open for a week or so, to give people a bit more time to object in case they're using the flag for something. ===

[PATCH] D46922: [checks/property-decls] Fix comment in clang-tidy/objc/PropertyDeclarationCheck.cpp ✍️

stephanemoore created this revision. Herald added a subscriber: cfe-commits. The comment incorrectly claims that the listed acronyms are all extracted from the linked Apple documentation. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46922 Files: clang-tidy/objc/PropertyDec

[PATCH] D46881: [X86][CET] Changing -fcf-protection behavior to comply with gcc (clang part)

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D46881 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

[PATCH] D46925: Remaining Binary Operations on Primary Fixed Point Types

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr, jakehehrlich. leonardchan added a project: clang. This patch implements the remaining arithmetic and logical operations on the primary fixed point types. The operations are `+`, `-`, `*`, `/`, `<<`, and `>>`. //

[PATCH] D46926: Conversion between Fixed Point and Floating Point Numbers

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr, jakehehrlich. leonardchan added a project: clang. This patch has the implementation and tests for converting between fixed point and floating point numbers. The conversion process is simply dividing the fixed point

[PATCH] D45900: CodeGen: Fix invalid bitcast for lifetime.start/end

yaxunl updated this revision to Diff 146987. yaxunl edited the summary of this revision. yaxunl added a comment. Add optional argument to CreateMemTemp and CreateTempAlloca to get the original alloca and use it for lifetime intrinsic. https://reviews.llvm.org/D45900 Files: lib/CodeGen/CGCall

[PATCH] D46927: Augmented Assignment for Fixed Point Types

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr, jakehehrlich. leonardchan added a project: clang. This patch contains the changes and tests for augmented assignments for primary fixed point types. s_accum = 7.5hk; s_accum2 = 2.0hk; s_accum += s_accum2; a

[PATCH] D46485: Add python tool to dump and construct header maps

bruno marked an inline comment as done. bruno added inline comments. Comment at: utils/hmaptool/hmaptool:55 +# The number of buckets must be a power of two. +if num_buckets == 0 or (num_buckets & num_buckets - 1) != 0: +raise SystemExit("er

[PATCH] D46485: Add python tool to dump and construct header maps

bruno updated this revision to Diff 146992. bruno added a comment. Update after Jan review. https://reviews.llvm.org/D46485 Files: CMakeLists.txt test/CMakeLists.txt test/Preprocessor/Inputs/headermap-rel/foo.hmap test/Preprocessor/Inputs/headermap-rel/foo.hmap.json test/Preprocessor/

[PATCH] D46929: Fix a mangling failure on clang-cl C++17

tzik created this revision. tzik added reviewers: majnemer, rnk. Herald added a subscriber: cfe-commits. MethodVFTableLocations in MigrosoftVTableContext contains canonicalized decl. But, it's sometimes asked to lookup for non-canonicalized decl, and that causes assertion failure, and compilation

[PATCH] D46820: Fix __uuidof handling on non-type template parameter in C++17

tzik added a comment. rsmith: Could you PTAL to this? Repository: rC Clang https://reviews.llvm.org/D46820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2