Author: ericwf
Date: Tue May 8 00:56:05 2018
New Revision: 331745
URL: http://llvm.org/viewvc/llvm-project?rev=331745&view=rev
Log:
[C++2a] Implement operator<=>: Fix another bug in the code gen tests.
Sorry for the failures. I'm quite new at writing code gen tests, and
I'm not sure the best way
EricWF updated this revision to Diff 145643.
EricWF added a comment.
- Rebase on master.
I think the correct direction to head with this patch is to start removing the
bits of the implementation which evaluate and build rewritten expressions
during overload resolution. I'll submit such an updat
delena updated this revision to Diff 145646.
delena added a comment.
Removed the unsigned version of atomics. Enhanced semantics check.
Added more tests.
Added documentation.
Repository:
rC Clang
https://reviews.llvm.org/D46386
Files:
docs/LanguageExtensions.rst
include/clang/Basic/Built
nik updated this revision to Diff 145648.
nik marked 3 inline comments as done.
nik edited the summary of this revision.
nik added a comment.
Addressed comments.
Repository:
rC Clang
https://reviews.llvm.org/D45815
Files:
include/clang-c/Index.h
include/clang/Frontend/ASTUnit.h
lib/Fro
nik added inline comments.
Comment at: include/clang/Frontend/ASTUnit.h:370
+ IntrusiveRefCntPtr VFS,
+ SkipFunctionBodiesScope SkipFunctionBodiesScp =
+ SkipFunctionBodiesScope::None,
ilya-biryukov wrote:
> NIT: Maybe keep the name `SkipFuncti
EricWF added a comment.
I'm still not sure how to best generate a diff that best ignores white spaces
changes caused by clang-format or my editor.
I'll work on removing existing whitespace changes.
https://reviews.llvm.org/D45680
___
cfe-commits m
krasimir created this revision.
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D46572
Files:
docs/ReleaseNotes.rst
Index: docs/ReleaseNotes.rst
===
--- docs/ReleaseNotes.rst
+++ docs/Rele
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D46572
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
djasper added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:44
+ int MatchingStackIndex = Stack.size() - 1;
+ while (MatchingStackIndex >= 0 && Stack[MatchingStackIndex].Tok != &Tok)
+--MatchingStackIndex;
I think this needs a long explan
Author: krasimir
Date: Tue May 8 02:25:12 2018
New Revision: 331750
URL: http://llvm.org/viewvc/llvm-project?rev=331750&view=rev
Log:
[clang-format] Add raw string formatting to release notes
Reviewers: hans
Reviewed By: hans
Subscribers: cfe-commits
Differential Revision: https://reviews.llv
This revision was automatically updated to reflect the committed changes.
Closed by commit rL331750: [clang-format] Add raw string formatting to release
notes (authored by krasimir, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D46572
Fi
a.sidorin accepted this revision.
a.sidorin added a comment.
This revision is now accepted and ready to land.
Looks good!
Comment at: lib/AST/ASTImporter.cpp:2650
+ for (const auto *A : D->attrs())
+ToIndirectField->addAttr(Importer.Import(const_cast(A)));
--
Author: rksimon
Date: Tue May 8 02:40:32 2018
New Revision: 331753
URL: http://llvm.org/viewvc/llvm-project?rev=331753&view=rev
Log:
Fix 'not all control paths return a value' MSVC warnings. NFCI.
Modified:
cfe/trunk/lib/AST/ExprConstant.cpp
cfe/trunk/lib/CodeGen/CGExprAgg.cpp
Modified:
ilya-biryukov added a comment.
The new uploaded diff has lots of unrelated changes to clang-tidy, clang-move,
etc...
Looking at commits, it seems `arc diff` was called with the wrong base
commit...
Could you please reupload the change?
Comment at: clangd/Quality.h:45
+
+// A
r.stahl updated this revision to Diff 145660.
r.stahl added a comment.
Didn't see that overload, thanks!
I need someone to commit this for me.
https://reviews.llvm.org/D46115
Files:
include/clang/AST/ASTImporter.h
lib/AST/ASTImporter.cpp
test/Import/attr/Inputs/S.cpp
test/Import/attr/t
krasimir updated this revision to Diff 145661.
krasimir marked 2 inline comments as done.
krasimir added a comment.
- Address review comments
Repository:
rC Clang
https://reviews.llvm.org/D46519
Files:
lib/Format/ContinuationIndenter.cpp
lib/Format/ContinuationIndenter.h
lib/Format/Unw
krasimir marked an inline comment as done and an inline comment as not done.
krasimir added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:44
+ int MatchingStackIndex = Stack.size() - 1;
+ while (MatchingStackIndex >= 0 && Stack[MatchingStackIndex].Tok != &Tok
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Generally looks good.
Comment at: lib/Format/ContinuationIndenter.cpp:93
+ break;
+if (End->Next->is(tok::r_brace)) {
+ const ParenState *State = FindParenSta
yvvan added inline comments.
Comment at: include/clang-c/Index.h:5220
+CINDEX_LINKAGE CXString
+clang_getCompletionCorrection(CXCompletionString completion_string,
+ unsigned correction_index,
ilya-biryukov wrote:
> I'm a bit vary abo
yvvan updated this revision to Diff 145664.
yvvan added a comment.
Address comments and provide diff with full context
https://reviews.llvm.org/D41537
Files:
include/clang-c/Index.h
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/CodeCompleteConsumer.h
include/clang/Sema/C
Lekensteyn added reviewers: brad.king, gottesmm, mgorny.
Lekensteyn added a comment.
Hi, this patch was required to make `find_package(Clang CONFIG)` work when
`/usr/lib/llvm/clang-X.Y` was a symlink and is integrated in the Debian
packaging. Please have a look, thanks!
One unfortunate limitati
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Given Artem's answer (and if there are no objections from other CSA
maintainers), I have no concerns with this patch going in. A couple of minor
nits.
Comment at: clang-tid
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D46233
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
aaron.ballman accepted this revision.
aaron.ballman added a comment.
Aside from a minor commenting nit, also LGTM.
Comment at: clang-tidy/tool/ClangTidyMain.cpp:195
+/// This option allows enabling alpha checkers from the static analyzer, that
+/// are experimental. This opti
Author: xazax
Date: Tue May 8 04:53:32 2018
New Revision: 331759
URL: http://llvm.org/viewvc/llvm-project?rev=331759&view=rev
Log:
[ASTMatchers] Overload isConstexpr for ifStmts
Differential Revision: https://reviews.llvm.org/D46233
Modified:
cfe/trunk/docs/LibASTMatchersReference.html
This revision was automatically updated to reflect the committed changes.
Closed by commit rC331759: [ASTMatchers] Overload isConstexpr for ifStmts
(authored by xazax, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46233?vs=145370&id=145668#toc
Repository:
rC Clang
https
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG with a couple of nits.
Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:181
std::unique_ptr OptionsProvider)
-: DiagEngine(nullptr), OptionsProvider(std::mo
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
I don't think debug CSA checkers belong to clang-tidy. If one needs to dump
CFG, they are probably doing quite involved stuff already, so going a step
further and running `clang -cc1
aaron.ballman added a comment.
In https://reviews.llvm.org/D42933#1090268, @jfb wrote:
> I was just looking at this, and I think @arphaman's patch is pretty much the
> right approach (with 2 suggested fixes below).
>
> I don't think the code we're currently warning on is broken: a user code has
lebedev.ri added subscribers: george.karpenkov, NoQ, dcoughlin.
lebedev.ri added a comment.
In https://reviews.llvm.org/D46188#1091221, @alexfh wrote:
> I don't think debug CSA checkers belong to clang-tidy. If one needs to dump
> CFG, they are probably doing quite involved stuff already, so goi
lebedev.ri added a comment.
In https://reviews.llvm.org/D46504#1091210, @alexfh wrote:
> LG with a couple of nits.
Thank you for the review, faster than ever :)
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46504
___
cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL331762: [ASTImporter] Properly import SourceLocations of
Attrs (authored by a.sidorin, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D46115?v
Author: a.sidorin
Date: Tue May 8 05:45:21 2018
New Revision: 331762
URL: http://llvm.org/viewvc/llvm-project?rev=331762&view=rev
Log:
[ASTImporter] Properly import SourceLocations of Attrs
Patch by Rafael Stahl!
Differential Revision: https://reviews.llvm.org/D46115
Added:
cfe/trunk/test
krasimir updated this revision to Diff 145677.
krasimir added a comment.
- Added other parens detection
Repository:
rC Clang
https://reviews.llvm.org/D46519
Files:
lib/Format/ContinuationIndenter.cpp
lib/Format/ContinuationIndenter.h
lib/Format/UnwrappedLineFormatter.cpp
unittests/Fo
krasimir marked an inline comment as done.
krasimir added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:93
+ break;
+if (End->Next->is(tok::r_brace)) {
+ const ParenState *State = FindParenState(End->Next->MatchingParen);
djasper
Author: lebedevri
Date: Tue May 8 06:14:21 2018
New Revision: 331763
URL: http://llvm.org/viewvc/llvm-project?rev=331763&view=rev
Log:
[clang-tidy] Profile is a per-AST (per-TU) data.
Summary:
As discussed in D45931, currently, profiling output of clang-tidy is somewhat
not great.
It outputs on
This revision was automatically updated to reflect the committed changes.
Closed by commit rL331763: [clang-tidy] Profile is a per-AST (per-TU) data.
(authored by lebedevri, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D46504?vs=1454
GBuella updated this revision to Diff 145680.
https://reviews.llvm.org/D46541
Files:
lib/CodeGen/CodeGenFunction.cpp
lib/CodeGen/CodeGenModule.cpp
lib/CodeGen/CodeGenModule.h
test/CodeGen/target-features-error-2.c
test/CodeGen/target-features-error.c
Index: test/CodeGen/target-features
GBuella updated this revision to Diff 145681.
GBuella added a comment.
Rebased.
https://reviews.llvm.org/D46540
Files:
include/clang/Basic/BuiltinsX86.def
include/clang/Basic/BuiltinsX86_64.def
include/clang/Driver/Options.td
lib/Basic/Targets/X86.cpp
lib/Basic/Targets/X86.h
lib/Hea
ilya-biryukov updated this revision to Diff 145683.
ilya-biryukov marked 3 inline comments as done.
ilya-biryukov added a comment.
Herald added a subscriber: mgorny.
- Move unit tests from clangd code to AST tests
- Assert locations are valid
- Address review other comments
Repository:
rC Clan
ilya-biryukov added inline comments.
Comment at: lib/AST/RawCommentList.cpp:376
+SourceMgr.getSpellingColumnNumber(Tok.getLocation(), &LocInvalid);
+if (LocInvalid)
+ TokColumn = 0;
ioeric wrote:
> This is a bit confusing... Could you please add
ilya-biryukov added a comment.
@arphaman, friendly ping. In case you're the wrong person to review it, I'll
try to find someone else.
Repository:
rC Clang
https://reviews.llvm.org/D46001
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
Author: svenvh
Date: Tue May 8 06:47:43 2018
New Revision: 331766
URL: http://llvm.org/viewvc/llvm-project?rev=331766&view=rev
Log:
[OpenCL] Factor out language version printing
Generate a printable OpenCL language version number in a single place
and select between the OpenCL C or OpenCL C++ ve
This revision was automatically updated to reflect the committed changes.
Closed by commit rL331766: [OpenCL] Factor out language version printing
(authored by svenvh, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D46382?vs=144991&id=
alexfh added a comment.
In https://reviews.llvm.org/D46188#1091237, @lebedev.ri wrote:
> In https://reviews.llvm.org/D46188#1091221, @alexfh wrote:
>
> > I don't think debug CSA checkers belong to clang-tidy. If one needs to dump
> > CFG, they are probably doing quite involved stuff already, so
alexfh added a comment.
In https://reviews.llvm.org/D46187#1088722, @NoQ wrote:
> It seems that you're using debug checkers of the analyzer to gain some free
> tools for exploring the source code (such as displaying a call graph) for
> free, right?
>
> I believe we could also benefit from a met
Author: abataev
Date: Tue May 8 07:16:57 2018
New Revision: 331768
URL: http://llvm.org/viewvc/llvm-project?rev=331768&view=rev
Log:
[OPENMP, NVPTX] Fix linkage of the global entries.
The linkage of the global entries must be weak to enable support of
redefinition of the same target regions in m
101 - 147 of 147 matches
Mail list logo
