[PATCH] D40443: [Modules TS] Make imports from an interface unit visible to its implementation units

rsmith added inline comments. Comment at: lib/Sema/SemaDecl.cpp:16135 +for (Module *ImportedModule : Mod->Imports) + VisibleModules.setVisible(ImportedModule, ModuleLoc); + } For completeness, you should also call `getModuleLoader().makeModuleVisible(M

[PATCH] D41566: [Modules TS] Diagnose exported internal linkage declarations

rsmith added inline comments. Comment at: include/clang/AST/DeclBase.h:2055-2075 +template<> +struct GraphTraits { + using NodeRef = const ::clang::Decl *; + using ChildIteratorType = ::clang::DeclContext::decl_iterator; + + static NodeRef getEntryNode(const ::clang::DeclConte

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

This revision was automatically updated to reflect the committed changes. Closed by commit rC331096: [analyzer] CStringChecker: Add support for BSD strlcpy() and strlcat(). (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D45177?vs=140667&id=144421#toc

r331096 - [analyzer] CStringChecker: Add support for BSD strlcpy() and strlcat().

Author: dergachev Date: Fri Apr 27 16:50:55 2018 New Revision: 331096 URL: http://llvm.org/viewvc/llvm-project?rev=331096&view=rev Log: [analyzer] CStringChecker: Add support for BSD strlcpy() and strlcat(). Patch by David Carlier! Differential Revision: https://reviews.llvm.org/D45177 Modified

[PATCH] D41627: [Modules TS] Fix namespace visibility

rsmith added inline comments. Comment at: lib/AST/DeclBase.cpp:285 +Decl::ModuleOwnershipKind Decl::getModuleOwnershipKindForChildOf(DeclContext *DC) { + // Ignore namespaces because they're visible by default. + while (DC && DC->isNamespace()) "because they'r

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:106 +bool isAppending, +bool canOverlap = false) const; The fact that the regular `strcpy`/`strcat` isn't checked for overlaps

[PATCH] D45416: [analyzer] ExprEngine: model GCC inline asm rvalue cast outputs

NoQ accepted this revision. NoQ added a subscriber: rsmith. NoQ added a comment. Woohoo LGTM. Heads up to @rsmith because we're about to break the CFG again, and also yay we've found another use case for rewriting AST in our CFG. Repository: rC Clang https://reviews.llvm.org/D45416 _

[PATCH] D46007: [analyzer] Add `TaintBugVisitor` to the ArrayBoundV2, DivideZero and VLASize.

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks great, thanks! I think the overall plan for any taint work would be to remove it from the program state API and move getters/setters into its own translation unit (like dynamic type propagati

Re: r331056 - [docs] add -ffp-cast-overflow-workaround to the release notes

On Fri, Apr 27, 2018 at 4:36 PM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On 27 April 2018 at 16:07, Sanjay Patel via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Missing dash corrected at r331057. I can improve the doc wording, but >> let's settle on the flag

Re: r331056 - [docs] add -ffp-cast-overflow-workaround to the release notes

On 27 April 2018 at 17:09, Chandler Carruth via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Fri, Apr 27, 2018 at 4:36 PM Richard Smith via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> On 27 April 2018 at 16:07, Sanjay Patel via cfe-commits < >> cfe-commits@lists.llvm.org> wrot

[PATCH] D46190: For an ODR declaration, set the 'Used' bit on its associated declarations.

rsmith added a comment. In https://reviews.llvm.org/D46190#1081773, @rsmith wrote: > No, absolutely not. This would be insanely expensive, and marks entirely > unrelated things "used". My apologies, reading this again it comes off a lot harsher than I'd intended. Repository: rC Clang http

[PATCH] D45416: [analyzer] ExprEngine: model GCC inline asm rvalue cast outputs

rsmith added inline comments. Comment at: test/Analysis/asm.cpp:9 + ref = 1; + __asm__("" : "=r"((int)global)); // don't crash on rvalue output operand + clang_analyzer_eval(global == 1); // expected-warning{{UNKNOWN}} Ugh, do we really need to support this n

Re: r331056 - [docs] add -ffp-cast-overflow-workaround to the release notes

On Fri, Apr 27, 2018 at 5:13 PM Richard Smith wrote: > On 27 April 2018 at 17:09, Chandler Carruth via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> On Fri, Apr 27, 2018 at 4:36 PM Richard Smith via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> On 27 April 2018 at 16:07, Sa

Buildbot numbers for the week of 4/8/2018 - 4/14/2018

Hello everyone, Below are some buildbot numbers for the week of 4/8/2018 - 4/14/2018. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed to re

Buildbot numbers for the week of 4/15/2018 - 4/21/2018

Hello everyone, Below are some buildbot numbers for the last week of 4/15/2018 - 4/21/2018. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed

[PATCH] D46224: [analyzer] pr37209: Fix casts of lvalues to references.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs, baloghadamsoftware. In the provided test case the expression `(int *&)*(int *)p` is evaluated as follows: 1. Take an lvalue `p` of type `cha

r331098 - [ItaniumMangle] Undeduced auto type shouldn't be substitutable.

Author: epilk Date: Fri Apr 27 19:40:28 2018 New Revision: 331098 URL: http://llvm.org/viewvc/llvm-project?rev=331098&view=rev Log: [ItaniumMangle] Undeduced auto type shouldn't be substitutable. We still support the old mangling if we're trying to be ABI-compatible with Clang 6.0, though. Diffe

[PATCH] D45451: [ItaniumMangle] Undeduced auto type doesn't belong in the substitution table

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL331098: [ItaniumMangle] Undeduced auto type shouldn't be substitutable. (authored by epilk, committed by ). Herald added a

[PATCH] D45451: [ItaniumMangle] Undeduced auto type doesn't belong in the substitution table

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC331098: [ItaniumMangle] Undeduced auto type shouldn't be substitutable. (authored by epilk, committed by ). Changed prior

[PATCH] D35110: [Analyzer] Constraint Manager Negates Difference

NoQ added a comment. LGTM! Minor nitpicking in comments. Currently there's no such problem, but as `GetRange` becomes more complicated, we'll really miss the possibility of saying something like "if there's a range for negated symbol, `return GetRange(the negated symbol)`", so that all other s

If I want to disable certain attributes, such as "swiftcall", is there any way to do it now?

As the title says,thanks.___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35110: [Analyzer] Constraint Manager Negates Difference

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:265-276 + const llvm::APSInt &from = i->From(), &to = i->To(); + const llvm::APSInt &newFrom = (to.isMinSignedValue() ? + BV.getMaxValue(to) : +

[PATCH] D46218: PR37275 packed attribute should not apply to base classes

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. I wonder if that was originally just an oversight that got turned into official policy. Anyway, if it's the policy, it's what we have to do; LGTM. Have you checked whether we do the right

<    1   2