Re: r330210 - Remove unused variable

FWIW, I don't think you actually need the if. Peter On Tue, Apr 17, 2018 at 1:21 PM, Teresa Johnson via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: tejohnson > Date: Tue Apr 17 13:21:53 2018 > New Revision: 330210 > > URL: http://llvm.org/viewvc/llvm-project?rev=330210&view=rev >

[PATCH] D45615: [builtins] __builtin_dump_struct : added more types format

paulsemel added a comment. In https://reviews.llvm.org/D45615#1069755, @aaron.ballman wrote: > LGTM! I will go ahead and commit on your behalf. Btw, if you're thinking of > making additional patches, now might be a good time to ask for commit > privileges > (https://llvm.org/docs/DeveloperPoli

[PATCH] D45504: [MinGW] Look for a cross sysroot relative to the clang binary

mstorsjo added a comment. Ping https://reviews.llvm.org/D45504 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r330212 - Require shell for test

Author: tejohnson Date: Tue Apr 17 13:36:51 2018 New Revision: 330212 URL: http://llvm.org/viewvc/llvm-project?rev=330212&view=rev Log: Require shell for test Attempt to fix windows bot which doesn't like the "(cd .." invocation added in r330194: http://lab.llvm.org:8011/builders/clang-with-thin-

[PATCH] D44882: [clangd] Implementation of workspace/symbol request

sammccall added a comment. Sorry, missed this. Just a few leftovers from removing the line/col conversion code. Then ship it! Comment at: clangd/ClangdServer.h:166 + // FIXME: Remove this parameter when the index has line/col. + const DraftSt

[PATCH] D45290: [Driver] Use the per-API level Android library directories.

This revision was automatically updated to reflect the committed changes. Closed by commit rL330213: [Driver] Use the per-API level Android library directories. (authored by danalbert, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D45290

[PATCH] D45504: [MinGW] Look for a cross sysroot relative to the clang binary

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D45504 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45504: [MinGW] Look for a cross sysroot relative to the clang binary

rnk added a comment. Sorry, I skipped over the message and looked at the code, which seems pretty straightforward. > Tests still are TBD, but posting this early to see if there's comments. (How > do I easily do a test that checks something relative to the clang binary, > since I don't control

[PATCH] D45504: [MinGW] Look for a cross sysroot relative to the clang binary

mstorsjo added a comment. In https://reviews.llvm.org/D45504#1070198, @rnk wrote: > Sorry, I skipped over the message and looked at the code, which seems pretty > straightforward. > > > Tests still are TBD, but posting this early to see if there's comments. > > (How do I easily do a test that c

[PATCH] D45292: [Driver] Obey computed sysroot when finding libc++ headers.

danalbert added a comment. Ping? Repository: rC Clang https://reviews.llvm.org/D45292 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45291: [Driver] Infer Android sysroot location.

danalbert added a comment. Ping? Repository: rC Clang https://reviews.llvm.org/D45291 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45738: Add Microsoft mangling for _Float16, similar to technique used for _Complex

mibintc created this revision. mibintc added reviewers: erichkeane, cfe-commits, majnemer. Herald added a subscriber: llvm-commits. Microsoft doesn't support _Float16, so this patch invents a mangling using the technique that was used for _Complex, putting _Float16 into __clang namespace. What

[PATCH] D45738: Add Microsoft mangling for _Float16, similar to technique used for _Complex

erichkeane added a comment. FWIW, this demangles on both demangler.com and undname as "void __cdecl Float16::f(struct __clang::_Float16)", which seems like the right thing, since the "Complex" above demangles to: "void __cdecl Complex::f(struct __clang::_Complex)" I also note (since upon first

[PATCH] D45738: Add Microsoft mangling for _Float16, similar to technique used for _Complex

majnemer accepted this revision. majnemer added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D45738 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

[PATCH] D45716: [XRay] Add clang builtin for xray typed events.

This revision was automatically updated to reflect the committed changes. Closed by commit rC330220: [XRay] Add clang builtin for xray typed events. (authored by kpw, committed by ). Changed prior to commit: https://reviews.llvm.org/D45716?vs=142790&id=142836#toc Repository: rC Clang https:

[PATCH] D45716: [XRay] Add clang builtin for xray typed events.

This revision was automatically updated to reflect the committed changes. Closed by commit rL330220: [XRay] Add clang builtin for xray typed events. (authored by kpw, committed by ). Repository: rC Clang https://reviews.llvm.org/D45716 Files: cfe/trunk/include/clang/Basic/Builtins.def cfe

r330225 - Add Microsoft mangling for _Float16

Author: erichkeane Date: Tue Apr 17 15:00:54 2018 New Revision: 330225 URL: http://llvm.org/viewvc/llvm-project?rev=330225&view=rev Log: Add Microsoft mangling for _Float16 Enables _Float16 on Windows by creating a mangling mechanism in MicrosoftMangle. It accomplishes this by mangling as a str

[PATCH] D45738: Add Microsoft mangling for _Float16, similar to technique used for _Complex

This revision was automatically updated to reflect the committed changes. Closed by commit rL330225: Add Microsoft mangling for _Float16 (authored by erichkeane, committed by ). Changed prior to commit: https://reviews.llvm.org/D45738?vs=142827&id=142846#toc Repository: rL LLVM https://revi

[PATCH] D45741: Python bindings: Fix handling of file bodies with multi-byte characters

mheinzler created this revision. mheinzler added a reviewer: clang. Herald added a subscriber: cfe-commits. With python3 there is a difference between the length of the string and the length of the utf-8 encoded bytes array. To not cut off characters at the end when the string contains multi-byt

[PATCH] D44984: [HIP] Add hip input kind and codegen for kernel launching

tra added inline comments. Comment at: lib/CodeGen/CGCUDANV.cpp:51-52 llvm::Constant *getLaunchFn() const; + std::string addPrefixToName(CodeGenModule &CGM, StringRef FuncName) const; + std::string addUnderscoredPrefixToName(CodeGenModule &CGM, +

[PATCH] D45544: [AAch64] Add the __ARM_FEATURE_DOTPROD macro definition

This revision was automatically updated to reflect the committed changes. Closed by commit rL330229: [AAch64] Add the __ARM_FEATURE_DOTPROD macro definition (authored by flyingforyou, committed by ). Herald added subscribers: llvm-commits, chrib. Changed prior to commit: https://reviews.llvm.or

[PATCH] D44670: [CXX] Templates specialization visibility can be wrong

doug.gregor added inline comments. Comment at: lib/AST/Decl.cpp:1078 +for (const auto *RD : + spec->getSpecializedTemplate()->getTemplatedDecl()->redecls()) { + auto Vis = getVisibilityOf(RD, kind); Do we want to look at *all* redeclarations, or

[PATCH] D45671: [python bindings] Fix Cursor.result_type for ObjC method declarations - Bug 36677

kjteske added a comment. First time llvm contributor here, so no commit access. @jbcoe, can you commit this for me? Repository: rC Clang https://reviews.llvm.org/D45671 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

[PATCH] D45662: OpenBSD add C++ runtime in a driver's standpoint

dberris accepted this revision. dberris added a comment. This revision is now accepted and ready to land. LGTM Thanks for working through this @devnexen! I can land this a little later on my day (Sydney, Australia). https://reviews.llvm.org/D45662 ___

[PATCH] D45212: [HIP] Let CUDA toolchain support HIP language mode and amdgpu

tra requested changes to this revision. tra added a subscriber: jlebar. tra added a comment. This revision now requires changes to proceed. Sorry about the delay. I've been out for few days. Comment at: include/clang/Driver/Options.td:552-553 +def : Joined<["--"], "offload-arch

[PATCH] D45489: [HIP] Add input type for HIP

tra added a comment. I'm getting confused about the order of the patches. The patch stack phabricator displays in this patch is different compared to the stack in https://reviews.llvm.org/D44984. Which one should I trust? https://reviews.llvm.org/D45489 _

[PATCH] D45750: add extra acronyms for objc property names

Wizard created this revision. Herald added subscribers: cfe-commits, klimek. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45750 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp test/clang-tidy/objc-property-declaration.m Index: test/clang-tidy/objc-property-declaration

[PATCH] D45679: [clang-tidy] Add a helper function isModified, that checks whether an expression is modified within a statement.

shuaiwang updated this revision to Diff 142870. shuaiwang edited the summary of this revision. shuaiwang added a comment. Handle casts, ternary operator and lambdas. Also optionally returns a chain of Stmt giving more details about how the conclusion is reached. Repository: rCTE Clang Tools E

[PATCH] D39053: [Bitfield] Add more cases to making the bitfield a separate location

mgrang added a comment. Added @apazos and myself a reviewers since this is something we would be interested in getting to work. https://reviews.llvm.org/D39053 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[PATCH] D45679: [clang-tidy] Add a helper function isModified, that checks whether an expression is modified within a statement.

shuaiwang updated this revision to Diff 142878. shuaiwang added a comment. Handle range-based for loop Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45679 Files: clang-tidy/utils/ASTUtils.cpp clang-tidy/utils/ASTUtils.h unittests/clang-tidy/CMakeLists.txt unittests/cla

[PATCH] D45685: [Sema] Add -wtest global flag that silences -Wself-assign for overloaded operators.

thakis added a comment. +1 to just adding a dedicated Wno flag for the new warning instead of coming up with this new spelling. Repository: rC Clang https://reviews.llvm.org/D45685 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://li

Re: [PATCH] D45685: [Sema] Add -wtest global flag that silences -Wself-assign for overloaded operators.

+1 to just adding a dedicated Wno flag for the new warning instead of coming up with this new spelling. On Mon, Apr 16, 2018, 3:41 PM Roman Lebedev via Phabricator via cfe-commits wrote: > lebedev.ri added a comment. > > Uuuh, the fact that phab posts the top-postings, but silently ignores > inl

[PATCH] D45442: Parse .h files as objective-c++ if we don't have a compile command.

sammccall added a comment. @ilya-biryukov Ping :-) Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45442 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45679: [clang-tidy] Add a helper function isModified, that checks whether an expression is modified within a statement.

shuaiwang updated this revision to Diff 142882. shuaiwang added a comment. Better range for loop handling. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45679 Files: clang-tidy/utils/ASTUtils.cpp clang-tidy/utils/ASTUtils.h unittests/clang-tidy/CMakeLists.txt unittests

r330240 - [Modules] Turn on system header validation for implicit modules

Author: bruno Date: Tue Apr 17 23:07:49 2018 New Revision: 330240 URL: http://llvm.org/viewvc/llvm-project?rev=330240&view=rev Log: [Modules] Turn on system header validation for implicit modules After r300027 implicit builds might fail when updating the SDK on darwin. Make validation of system h

[PATCH] D45755: [Sema] Do not match function type with const T in template argument deduction

lliu0 created this revision. lliu0 added reviewers: rjmccall, vsapsai. Herald added a subscriber: cfe-commits. >From http://www.open-std.org/jtc1/sc22/wg21/docs/cwg_active.html#1584, >function type should not match cv-qualified type in template argument >deduction. This also matches what GCC an

<    1   2