[PATCH] D45284: [RISCV] More validations on the input value of -march=

apazos updated this revision to Diff 142502. apazos added a comment. Fixed failure in release mode https://reviews.llvm.org/D45284 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/ToolChains/Arch/RISCV.cpp test/Driver/riscv-arch.c Index: test/Driver/riscv-arch.c ===

[PATCH] D45643: [Failing one test] Reword [-Wreturn-type] messages to "non-void x does not return a value"

Quuxplusone added inline comments. Comment at: bindings/python/tests/cindex/test_diagnostics.py:18 self.assertEqual(tu.diagnostics[0].spelling, -'control reaches end of non-void function') +'non-void function does not return a value') --

r330080 - Revert "[Serialization] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC)."

Author: vedantk Date: Fri Apr 13 18:40:48 2018 New Revision: 330080 URL: http://llvm.org/viewvc/llvm-project?rev=330080&view=rev Log: Revert "[Serialization] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC)." This reverts commit r330068. It breaks the lldb

Re: r330068 - [Serialization] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).

I've gone ahead and reverted this in r330080. I tested this with "./bin/lldb-dotest -p TestForwardDecl", and it no longer asserts, etc. @Eugene, regarding the specifics of this commit, there are a number of refactors here that don't make sense. E.g there's no need to create a reference to a St

[PATCH] D45650: [CFG] [analyzer] Don't treat argument constructors as temporary constructors.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs. Function argument constructors (that are used for passing objects into functions by value) are completely unlike temporary object constructor

[PATCH] D45650: [CFG] [analyzer] Don't treat argument constructors as temporary constructors.

NoQ updated this revision to Diff 142505. NoQ added a comment. Add tests where the argument is passed by reference. These tests work correctly (i.e. they correctly identify the argument constructor as a temporary constructor) because such constructors would include a `MaterializeTemporaryExpr`

[PATCH] D45491: [analyzer] Do not invalidate the `this` pointer.

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Yeah, i think this makes sense, thanks! It feels a bit weird that we have to add it as an exception - i wonder if there are other exceptions that we need to make. Widening over the stack memory spac

[PATCH] D45416: [analyzer] ExprEngine: model GCC inline asm rvalue cast outputs

NoQ accepted this revision. NoQ added a comment. Wow, you actually did that. Ok, now we can decide if we want this to be analyzer-only (with a `CFG::BuildOptions` flag) or get someone else to have a look at that as a global CFG change (i.e. it may potentially affect compiler warnings). Or at l

[PATCH] D45416: [analyzer] ExprEngine: model GCC inline asm rvalue cast outputs

NoQ added a comment. (i'd much rather do the latter) Repository: rC Clang https://reviews.llvm.org/D45416 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45407: [StaticAnalyzer] Added notes to the plist output

NoQ added a comment. Sorry, overwhelmed a bit, i'll try to get to this as soon as possible. Btw, what sort of UI are you trying to make these extra note pieces of mine work with? Was `-analyzer-config notes-as-events=true` of any help? Repository: rC Clang https://reviews.llvm.org/D45407

[PATCH] D45476: [C++2a] Implement operator<=> CodeGen and ExprConstant

EricWF marked 30 inline comments as done. EricWF added inline comments. Comment at: include/clang/AST/ComparisonCategories.h:194 + + const ASTContext &Ctx; + mutable llvm::DenseMap Data; Storing the `ASTContext` in `ComparisonCategories` and `ComparisonCategory

<    1   2