tra added a comment.
In https://reviews.llvm.org/D45061#1063791, @echristo wrote:
> Guessing that SM_60 (etc) are defines?
>
> Anyhow LGTM. I'm not sure you can split up the satom part of the patch, but
> if you can that'd be great.
>
> -eric
I'll split out removal of satom feature into a sepa
craig.topper accepted this revision.
craig.topper added a comment.
LGTM
https://reviews.llvm.org/D43817
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lebedev.ri added a comment.
I'm waiting for @mclow.lists to have the final say re this differential.
In https://reviews.llvm.org/D45179#1057187, @Quuxplusone wrote:
> In https://reviews.llvm.org/D45179#1056706, @lebedev.ri wrote:
>
> > gcc does not silence the warning produced by
> > these attr
Author: tra
Date: Wed Apr 11 10:51:19 2018
New Revision: 329829
URL: http://llvm.org/viewvc/llvm-project?rev=329829&view=rev
Log:
[NVPTX, CUDA] Improved feature constraints on NVPTX target builtins.
When NVPTX TARGET_BUILTIN specifies sm_XX or ptxYY as required feature,
consider those features av
Author: tra
Date: Wed Apr 11 10:51:33 2018
New Revision: 329830
URL: http://llvm.org/viewvc/llvm-project?rev=329830&view=rev
Log:
[NVPTX] Removed 'satom' feature which is no longer used.
Differential Revision: https://reviews.llvm.org/D45061
Modified:
cfe/trunk/lib/Basic/Targets/NVPTX.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rC329829: [NVPTX, CUDA] Improved feature constraints on NVPTX
target builtins. (authored by tra, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D45061?vs=141932&id=142047#toc
Repositor
Szelethus created this revision.
Szelethus added reviewers: NoQ, xazax.hun, dkrupp, whisperity.
Herald added subscribers: cfe-commits, a.sidorin, rnkovacs, szepet, mgorny.
Herald added a reviewer: george.karpenkov.
This checker checks at the end of a constructor call whether all fields of the
obj
Author: eugenezelenko
Date: Wed Apr 11 11:03:57 2018
New Revision: 329833
URL: http://llvm.org/viewvc/llvm-project?rev=329833&view=rev
Log:
[Documentation] Fix formatting and order in Release Notes for recent changes in
modernize-use-auto.
Modified:
clang-tools-extra/trunk/docs/ReleaseNotes.
lebedev.ri added a comment.
Please always upload all patches with full context (`-U9`)
Repository:
rC Clang
https://reviews.llvm.org/D45532
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
Quuxplusone added a comment.
In https://reviews.llvm.org/D45179#1064589, @lebedev.ri wrote:
> I'm waiting for @mclow.lists to have the final say re this differential.
Ack. :)
> So roughly:
>
> // NOTE: Do not use [[nodiscard]] in pre-C++17 mode
> // to avoid -Wc++17-extensions warni
Szelethus updated this revision to Diff 142053.
Szelethus added a comment.
Reuploaded the diff with full context.
https://reviews.llvm.org/D45532
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/CMakeLists.txt
lib/StaticAnalyzer/Checkers/CtorUninitializ
Author: smeenai
Date: Wed Apr 11 11:17:35 2018
New Revision: 329836
URL: http://llvm.org/viewvc/llvm-project?rev=329836&view=rev
Log:
[CodeGen] Handle __func__ inside __finally
When we enter a __finally block, the CGF's CurCodeDecl will be null
(because CodeGenFunction::StartFunction is given an
This revision was automatically updated to reflect the committed changes.
Closed by commit rL329836: [CodeGen] Handle __func__ inside __finally (authored
by smeenai, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D45523
Files:
cfe/trunk
chh added a comment.
Yes, calling `__gcov_flush` within .so files are different,
but it's a revert of https://reviews.llvm.org/D38124.
I think https://bugs.llvm.org/show_bug.cgi?id=27224
can be fixed by hiding only llvm_gcda_* functions,
without any change to `__gcov_flush`.
(1) Before https://r
NoQ added a comment.
That's a lot of code, so it'll take me some time to understand what's going on
here. You might be able to help me by the large patch in smaller logical chunks.
The idea looks reasonable. We're having specific warnings for, eg., assigning
an uninitialized value, which fire m
Szelethus added inline comments.
Comment at: test/Analysis/ctor-uninitialized-member.cpp:869
+void f44() {
+ ContainsUnionWithSimpleUnionTest2(); // xpected-warning{{1 uninitialized
field}}
+}
NoQ wrote:
> Hmm, shouldn't it say "expected"? Do these tests actual
Szelethus added a comment.
In https://reviews.llvm.org/D45532#1064652, @NoQ wrote:
> > In most cases, all fields of a union is regarded as unknown. I checked
> > these cases by regarding unknown fields as uninitialized.
>
> The whole point of making them unknown, as far as i understand, was to
NoQ added a comment.
Ok, thanks, looking forward to it!
Comment at: test/Analysis/ctor-uninitialized-member.cpp:869
+void f44() {
+ ContainsUnionWithSimpleUnionTest2(); // xpected-warning{{1 uninitialized
field}}
+}
Szelethus wrote:
> NoQ wrote:
> > Hmm, shou
Wizard updated this revision to Diff 142057.
Wizard added a comment.
remove unnecessary flags
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45392
Files:
clang-tidy/readability/IdentifierNamingCheck.cpp
test/clang-tidy/readability-identifier-naming-objc.m
Index: test/clan
Wizard added inline comments.
Comment at: test/clang-tidy/readability-identifier-naming-objc.m:8-9
+// RUN: ]}' -- -fno-delayed-template-parsing \
+// RUN: -I%S/Inputs/readability-identifier-naming \
+// RUN: -isystem %S/Inputs/readability-identifier-naming/system
+
---
Szelethus added a comment.
In https://reviews.llvm.org/D45532#1064670, @Szelethus wrote:
> I wasn't too clear on this one: unknown fields are regarded as uninitialized,
> what I wrote was a temporary change in the code so I could check whether it
> would work.
Woops, I meant that unknown fiel
Author: abataev
Date: Wed Apr 11 12:21:00 2018
New Revision: 329843
URL: http://llvm.org/viewvc/llvm-project?rev=329843&view=rev
Log:
[OPENMP] Code cleanup, NFC.
Modified:
cfe/trunk/lib/Sema/SemaOpenMP.cpp
Modified: cfe/trunk/lib/Sema/SemaOpenMP.cpp
URL:
http://llvm.org/viewvc/llvm-project/
On Wed, Apr 11, 2018 at 11:31 AM, Chih-Hung Hsieh via Phabricator via
llvm-commits wrote:
> chh added a comment.
>
> Yes, calling `__gcov_flush` within .so files are different,
> but it's a revert of https://reviews.llvm.org/D38124.
> I think https://bugs.llvm.org/show_bug.cgi?id=27224
> can be
This revision was automatically updated to reflect the committed changes.
Closed by commit rC329848: [x86] wbnoinvd intrinsic (authored by GBuella,
committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D43817
Files:
docs/ClangCommandLineReference.rst
include/clang/Basic/BuiltinsX8
NoQ added a comment.
In https://reviews.llvm.org/D45532#1064685, @Szelethus wrote:
> In https://reviews.llvm.org/D45532#1064670, @Szelethus wrote:
>
> > I wasn't too clear on this one: unknown fields are regarded as
> > uninitialized, what I wrote was a temporary change in the code so I could
>
enyquist added a comment.
As far as I know, there are no updates required from me for this pull request--
I rebased on the main trunk recently, and will do it again tonight to be sure.
So it should be compiling/working just fine.
I believe it is just awaiting final approval from somebody.
Repo
Author: eugenezelenko
Date: Wed Apr 11 13:57:28 2018
New Revision: 329851
URL: http://llvm.org/viewvc/llvm-project?rev=329851&view=rev
Log:
[Serialization] Fix some Clang-tidy modernize and Include What You Use
warnings; other minor fixes (NFC).
Modified:
cfe/trunk/include/clang/Serializatio
101 - 127 of 127 matches
Mail list logo
